RE: [PATCH 3/3] drm/i915: split out display register macros to a separate file

[Jani Nikula <jani.nikula@intel.com>]

On Wed, 12 Feb 2025, "Kandpal, Suraj" <suraj.kandpal@intel.com> wrote:
>> -----Original Message-----
>> From: Intel-xe <intel-xe-bounces@lists.freedesktop.org> On Behalf Of Jani
>> Nikula
>> Sent: Friday, February 7, 2025 7:05 PM
>> To: intel-gfx@lists.freedesktop.org; intel-xe@lists.freedesktop.org
>> Cc: Nikula, Jani <jani.nikula@intel.com>; ville.syrjala@linux.intel.com; Deak,
>> Imre <imre.deak@intel.com>
>> Subject: [PATCH 3/3] drm/i915: split out display register macros to a
>> separate file
>>
>> This is a scripted split of the display related register macros from
>> i915_reg.h to display/intel_display_regs.h. Basically move all the
>> macros that are only used in display code (or GVT). If there are users
>> in core i915 code or soc/, or no users anywhere, keep the macros in
>> i915_reg.h. This is done in groups of macros separated by blank lines,
>> moving the comments along with the groups.
>>
>> This is obviously a very crude approach. It's not perfect. But there are
>> 4.2k lines in i915_reg.h, and its refactoring has ground to a halt. This
>> is the big hammer that splits the file to two, and enables further
>> cleanup.
>>
>
> This is a really big patch and I may have very well missed something but
> Seeing that this is majorly code movement and things like conversion of 1<<x
> To reg_bit will need to happen In a different patch or series LGTM,
> Reviewed-by: Suraj Kandpal <suraj.kandpal@intel.com>

Oh, I sincerely hope you're aware of 'git show --color-moved'. Applying
the patch and looking at it with that makes it a breeze to review code
movement!

Thanks for the review.

BR,
Jani.


-- 
Jani Nikula, Intel