From: Jani Nikula <jani.nikula@linux.intel.com>
To: matthew.s.atwood@intel.com, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/dp: Correctly mask DP_TRAINING_AUX_RD_INTERVAL values for DP 1.4
Date: Mon, 19 Mar 2018 21:13:55 +0200 [thread overview]
Message-ID: <87sh8vzxn0.fsf@intel.com> (raw)
In-Reply-To: <1521219275-25802-1-git-send-email-matthew.s.atwood@intel.com>
On Fri, 16 Mar 2018, matthew.s.atwood@intel.com wrote:
> From: Matt Atwood <matthew.s.atwood@intel.com>
>
> DP_TRAINING_AUX_RD_INTERVAL with DP 1.3 spec changed bit scheeme from 8
> bits to 7 in DPCD 0x000e. The 8th bit is used to identify extended
> receiver capabilities. For panels that use this new feature wait interval
> would be increased by 512 ms, when spec is max 16 ms. This behavior is
> described in table 2-158 of DP 1.4 spec address 0000eh.
>
> With the introduction of DP 1.4 spec main link clock recovery was
> standardized to 100 us regardless of TRAINING_AUX_RD_INTERVAL value.
>
> To avoid breaking panels that are not spec compiant we now warn on
> invalid values.
>
> V2: commit title/message, masking all 7 bits, warn on out of spec values.
> V3: commit message, make link train clock recovery follow DP 1.4 spec.
> V4: style changes
> V5: typo
> V6: print statement revisions, DP_REV to DPCD_REV, comment correction
> V7: typo
> V8: Style
>
> Signed-off-by: Matt Atwood <matthew.s.atwood@intel.com>
> ---
> drivers/gpu/drm/drm_dp_helper.c | 22 ++++++++++++++++++----
> include/drm/drm_dp_helper.h | 6 ++++++
This should be sent to dri-devel. See scripts/get_maintainer.pl.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-03-19 19:14 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-16 16:54 [PATCH] drm/dp: Correctly mask DP_TRAINING_AUX_RD_INTERVAL values for DP 1.4 matthew.s.atwood
2018-03-16 18:00 ` ✓ Fi.CI.BAT: success for drm/dp: Correctly mask DP_TRAINING_AUX_RD_INTERVAL values for DP 1.4 (rev2) Patchwork
2018-03-16 22:35 ` ✗ Fi.CI.IGT: warning " Patchwork
2018-03-19 19:13 ` Jani Nikula [this message]
2018-03-23 16:04 ` [PATCH] drm/dp: Correctly mask DP_TRAINING_AUX_RD_INTERVAL values for DP 1.4 matthew.s.atwood
2018-03-27 13:03 ` kbuild test robot
2018-03-20 0:56 ` kbuild test robot
2018-03-20 1:26 ` kbuild test robot
2018-03-23 18:48 ` ✓ Fi.CI.BAT: success for drm/dp: Correctly mask DP_TRAINING_AUX_RD_INTERVAL values for DP 1.4 (rev3) Patchwork
2018-03-23 22:40 ` ✗ Fi.CI.IGT: failure " Patchwork
[not found] <1520029558-12219-1-git-send-email-matthew.s.atwood@intel.com>
2018-03-06 18:37 ` [PATCH] drm/dp: Correctly mask DP_TRAINING_AUX_RD_INTERVAL values for DP 1.4 matthew.s.atwood
2018-03-06 19:21 ` Benson Leung
2018-03-06 23:24 ` Rodrigo Vivi
2018-03-07 0:24 ` Pandiyan, Dhinakaran
2018-03-07 1:36 ` [Intel-gfx] " Manasi Navare
2018-03-07 2:13 ` Pandiyan, Dhinakaran
2018-03-07 22:06 ` Rodrigo Vivi
2018-03-07 23:44 ` matthew.s.atwood
2018-03-07 23:58 ` Ilia Mirkin
2018-03-08 0:18 ` Manasi Navare
2018-03-08 0:13 ` matthew.s.atwood
2018-03-08 0:36 ` Benson Leung
2018-03-08 0:28 ` matthew.s.atwood
2018-03-08 0:49 ` Benson Leung
2018-03-08 7:22 ` [Intel-gfx] " Jani Nikula
2018-03-09 23:49 ` Atwood, Matthew S
2018-03-12 19:39 ` Rodrigo Vivi
2018-03-14 17:40 ` matthew.s.atwood
2018-03-14 20:22 ` Rodrigo Vivi
2018-03-16 11:47 ` kbuild test robot
2018-03-14 20:20 ` matthew.s.atwood
2018-03-14 20:59 ` Rodrigo Vivi
2018-03-15 21:08 ` matthew.s.atwood
2018-03-16 0:39 ` Rodrigo Vivi
2018-03-16 23:10 ` kbuild test robot
2018-03-17 3:34 ` Benson Leung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sh8vzxn0.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.s.atwood@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox