* [PATCH] drm/i915: Fix new -Wint-in-bool-context gcc compiler warning
@ 2017-05-18 11:06 Hans de Goede
2017-05-18 12:31 ` Jani Nikula
0 siblings, 1 reply; 2+ messages in thread
From: Hans de Goede @ 2017-05-18 11:06 UTC (permalink / raw)
To: Daniel Vetter, Jani Nikula, Ville Syrjälä
Cc: Hans de Goede, intel-gfx
This commit fixes the following compiler warning:
drivers/gpu/drm/i915/intel_dsi.c: In function ‘intel_dsi_prepare’:
drivers/gpu/drm/i915/intel_dsi.c:1487:23: warning:
?: using integer constants in boolean context [-Wint-in-bool-context]
PORT_A ? PORT_C : PORT_A),
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
drivers/gpu/drm/i915/i915_reg.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index 11b12f412492..db5c49531033 100644
--- a/drivers/gpu/drm/i915/i915_reg.h
+++ b/drivers/gpu/drm/i915/i915_reg.h
@@ -8276,7 +8276,7 @@ enum {
/* MIPI DSI registers */
-#define _MIPI_PORT(port, a, c) ((port) ? c : a) /* ports A and C only */
+#define _MIPI_PORT(port, a, c) (((port) == PORT_A) ? a : c) /* ports A and C only */
#define _MMIO_MIPI(port, a, c) _MMIO(_MIPI_PORT(port, a, c))
#define MIPIO_TXESC_CLK_DIV1 _MMIO(0x160004)
--
2.12.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/i915: Fix new -Wint-in-bool-context gcc compiler warning
2017-05-18 11:06 [PATCH] drm/i915: Fix new -Wint-in-bool-context gcc compiler warning Hans de Goede
@ 2017-05-18 12:31 ` Jani Nikula
0 siblings, 0 replies; 2+ messages in thread
From: Jani Nikula @ 2017-05-18 12:31 UTC (permalink / raw)
To: Daniel Vetter, Ville Syrjälä; +Cc: Hans de Goede, intel-gfx
On Thu, 18 May 2017, Hans de Goede <hdegoede@redhat.com> wrote:
> This commit fixes the following compiler warning:
>
> drivers/gpu/drm/i915/intel_dsi.c: In function ‘intel_dsi_prepare’:
> drivers/gpu/drm/i915/intel_dsi.c:1487:23: warning:
> ?: using integer constants in boolean context [-Wint-in-bool-context]
> PORT_A ? PORT_C : PORT_A),
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Pushed to drm-intel-next-queued, thanks for the patch.
BR,
Jani.
> ---
> drivers/gpu/drm/i915/i915_reg.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> index 11b12f412492..db5c49531033 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -8276,7 +8276,7 @@ enum {
>
> /* MIPI DSI registers */
>
> -#define _MIPI_PORT(port, a, c) ((port) ? c : a) /* ports A and C only */
> +#define _MIPI_PORT(port, a, c) (((port) == PORT_A) ? a : c) /* ports A and C only */
> #define _MMIO_MIPI(port, a, c) _MMIO(_MIPI_PORT(port, a, c))
>
> #define MIPIO_TXESC_CLK_DIV1 _MMIO(0x160004)
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-05-18 12:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-18 11:06 [PATCH] drm/i915: Fix new -Wint-in-bool-context gcc compiler warning Hans de Goede
2017-05-18 12:31 ` Jani Nikula
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox