Re: [Intel-gfx] [PATCH 2/2] drm/i915: Prefix hex numbers with 0x

[Jani Nikula <jani.nikula@linux.intel.com>]

On Mon, 30 Jan 2023, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> It's hard to figure out whether the number is hex
> or decimal if doesn't have the 0x to indicate hex.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> ---
>  drivers/gpu/drm/i915/intel_device_info.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_device_info.c b/drivers/gpu/drm/i915/intel_device_info.c
> index 599c6d399de4..524f93768c41 100644
> --- a/drivers/gpu/drm/i915/intel_device_info.c
> +++ b/drivers/gpu/drm/i915/intel_device_info.c
> @@ -125,8 +125,8 @@ void intel_device_info_print(const struct intel_device_info *info,
>  	drm_printf(p, "base die stepping: %s\n", intel_step_name(runtime->step.basedie_step));
>  
>  	drm_printf(p, "gt: %d\n", info->gt);
> -	drm_printf(p, "memory-regions: %x\n", runtime->memory_regions);
> -	drm_printf(p, "page-sizes: %x\n", runtime->page_sizes);
> +	drm_printf(p, "memory-regions: 0x%x\n", runtime->memory_regions);
> +	drm_printf(p, "page-sizes: 0x%x\n", runtime->page_sizes);
>  	drm_printf(p, "platform: %s\n", intel_platform_name(info->platform));
>  	drm_printf(p, "ppgtt-size: %d\n", runtime->ppgtt_size);
>  	drm_printf(p, "ppgtt-type: %d\n", runtime->ppgtt_type);
> @@ -540,5 +540,5 @@ void intel_driver_caps_print(const struct intel_driver_caps *caps,
>  {
>  	drm_printf(p, "Has logical contexts? %s\n",
>  		   str_yes_no(caps->has_logical_contexts));
> -	drm_printf(p, "scheduler: %x\n", caps->scheduler);
> +	drm_printf(p, "scheduler: 0x%x\n", caps->scheduler);
>  }

-- 
Jani Nikula, Intel Open Source Graphics Center