Re: [Intel-gfx] [PATCH 1/2] drm/i915: Include stepping informaiton in device info dump

[Jani Nikula <jani.nikula@linux.intel.com>]

On Tue, 31 Jan 2023, Jani Nikula <jani.nikula@linux.intel.com> wrote:
> On Mon, 30 Jan 2023, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
>> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>>
>> Dump the stepping information alongside all the other device
>> info. Might avoid some guesswork when reading logs.
>>
>> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>

*information

in the subject line, can be fixed while applying.

>
>> ---
>>  drivers/gpu/drm/i915/intel_device_info.c | 5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_device_info.c b/drivers/gpu/drm/i915/intel_device_info.c
>> index 98769e5f2c3d..599c6d399de4 100644
>> --- a/drivers/gpu/drm/i915/intel_device_info.c
>> +++ b/drivers/gpu/drm/i915/intel_device_info.c
>> @@ -119,6 +119,11 @@ void intel_device_info_print(const struct intel_device_info *info,
>>  		drm_printf(p, "display version: %u\n",
>>  			   runtime->display.ip.ver);
>>  
>> +	drm_printf(p, "graphics stepping: %s\n", intel_step_name(runtime->step.graphics_step));
>> +	drm_printf(p, "media stepping: %s\n", intel_step_name(runtime->step.media_step));
>> +	drm_printf(p, "display stepping: %s\n", intel_step_name(runtime->step.display_step));
>> +	drm_printf(p, "base die stepping: %s\n", intel_step_name(runtime->step.basedie_step));
>> +
>>  	drm_printf(p, "gt: %d\n", info->gt);
>>  	drm_printf(p, "memory-regions: %x\n", runtime->memory_regions);
>>  	drm_printf(p, "page-sizes: %x\n", runtime->page_sizes);

-- 
Jani Nikula, Intel Open Source Graphics Center