public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Eric Anholt <eric@anholt.net>
To: Ian Romanick <idr@freedesktop.org>,
	intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Cc: Ben Widawsky <ben@bwidawsk.net>, Ian Romanick <ian.d.romanick@intel.com>
Subject: Re: [PATCH 1/2] intel: Add accessor to get HW context ID from a drm_intel_context
Date: Mon, 11 Nov 2013 11:58:59 -0800	[thread overview]
Message-ID: <87txfig16k.fsf@eliezer.anholt.net> (raw)
In-Reply-To: <1384192107-14314-1-git-send-email-idr@freedesktop.org>


[-- Attachment #1.1: Type: text/plain, Size: 563 bytes --]

Ian Romanick <idr@freedesktop.org> writes:

> From: Ian Romanick <ian.d.romanick@intel.com>
>
> The drm_intel_context structure is, wisely, opaque.  However, libdrm
> users may want to know the hardware context ID associated with the
> structure.

We've had a bunch of our other structures be partially transparent.  The
context id to be passed to the kernel could easily be public just like
the gem handle in a BO is public.  I would lean slightly toward that.

But I don't feel strongly either way, so these two are:

Reviewed-by: Eric Anholt <eric@anholt.net>

[-- Attachment #1.2: Type: application/pgp-signature, Size: 835 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2013-11-11 19:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-11 17:48 [PATCH 1/2] intel: Add accessor to get HW context ID from a drm_intel_context Ian Romanick
2013-11-11 17:48 ` [PATCH 2/2] intel: Silence warning in non-Valgrind build Ian Romanick
2013-11-11 19:58 ` Eric Anholt [this message]
2013-11-13  7:08   ` [PATCH 1/2] intel: Add accessor to get HW context ID from a drm_intel_context Ben Widawsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87txfig16k.fsf@eliezer.anholt.net \
    --to=eric@anholt.net \
    --cc=ben@bwidawsk.net \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=ian.d.romanick@intel.com \
    --cc=idr@freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox