From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915/gt: Drop false assertion on user_forcewake
Date: Mon, 04 Nov 2019 11:38:33 +0200 [thread overview]
Message-ID: <87v9s0nfqe.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <20191104090158.2959-1-chris@chris-wilson.co.uk>
Chris Wilson <chris@chris-wilson.co.uk> writes:
> The counter is removed from the pm wakeref count, but it remains intact
> so that we can restore it upon resume. Ergo inside suspend, it may have
> a value.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
oh, user_forcewake needs a better name with a verb...
> ---
> drivers/gpu/drm/i915/gt/intel_gt_pm.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_gt_pm.c b/drivers/gpu/drm/i915/gt/intel_gt_pm.c
> index 6374744bb65e..060a27d9af34 100644
> --- a/drivers/gpu/drm/i915/gt/intel_gt_pm.c
> +++ b/drivers/gpu/drm/i915/gt/intel_gt_pm.c
> @@ -251,7 +251,6 @@ static void wait_for_suspend(struct intel_gt *gt)
> intel_gt_set_wedged(gt);
> }
>
> - GEM_BUG_ON(atomic_read(>->user_wakeref));
> intel_gt_pm_wait_for_idle(gt);
> }
>
> --
> 2.24.0.rc2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 1/2] drm/i915/gt: Drop false assertion on user_forcewake
Date: Mon, 04 Nov 2019 11:38:33 +0200 [thread overview]
Message-ID: <87v9s0nfqe.fsf@gaia.fi.intel.com> (raw)
Message-ID: <20191104093833.JXgrQ0aunh6-e8pORGbc5PGVl0OgkKY5RWrNrbBd4V4@z> (raw)
In-Reply-To: <20191104090158.2959-1-chris@chris-wilson.co.uk>
Chris Wilson <chris@chris-wilson.co.uk> writes:
> The counter is removed from the pm wakeref count, but it remains intact
> so that we can restore it upon resume. Ergo inside suspend, it may have
> a value.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
oh, user_forcewake needs a better name with a verb...
> ---
> drivers/gpu/drm/i915/gt/intel_gt_pm.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_gt_pm.c b/drivers/gpu/drm/i915/gt/intel_gt_pm.c
> index 6374744bb65e..060a27d9af34 100644
> --- a/drivers/gpu/drm/i915/gt/intel_gt_pm.c
> +++ b/drivers/gpu/drm/i915/gt/intel_gt_pm.c
> @@ -251,7 +251,6 @@ static void wait_for_suspend(struct intel_gt *gt)
> intel_gt_set_wedged(gt);
> }
>
> - GEM_BUG_ON(atomic_read(>->user_wakeref));
> intel_gt_pm_wait_for_idle(gt);
> }
>
> --
> 2.24.0.rc2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-11-04 9:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-04 9:01 [PATCH 1/2] drm/i915/gt: Drop false assertion on user_forcewake Chris Wilson
2019-11-04 9:01 ` [Intel-gfx] " Chris Wilson
2019-11-04 9:01 ` [PATCH 2/2] drm/i915: Protect request peeking with RCU Chris Wilson
2019-11-04 9:01 ` [Intel-gfx] " Chris Wilson
2019-11-04 9:59 ` Mika Kuoppala
2019-11-04 9:59 ` [Intel-gfx] " Mika Kuoppala
2019-11-04 9:38 ` Mika Kuoppala [this message]
2019-11-04 9:38 ` [Intel-gfx] [PATCH 1/2] drm/i915/gt: Drop false assertion on user_forcewake Mika Kuoppala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9s0nfqe.fsf@gaia.fi.intel.com \
--to=mika.kuoppala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox