* [PATCH i-g-t] tools/intel_reg: Fix builtin register spec for gen4
@ 2016-04-05 12:13 ville.syrjala
2016-04-05 12:17 ` Matthew Auld
2016-04-05 13:50 ` Jani Nikula
0 siblings, 2 replies; 3+ messages in thread
From: ville.syrjala @ 2016-04-05 12:13 UTC (permalink / raw)
To: intel-gfx
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Actually use the builtin register spec on gen4. Makes intel_reg dump
actually do something on gen4.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
tools/intel_reg_decode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/intel_reg_decode.c b/tools/intel_reg_decode.c
index bb8f5b30311f..470fecc165c6 100644
--- a/tools/intel_reg_decode.c
+++ b/tools/intel_reg_decode.c
@@ -2580,7 +2580,7 @@ static bool is_945gm(uint32_t devid, uint32_t pch)
static bool is_gen234(uint32_t devid, uint32_t pch)
{
- return IS_GEN2(devid) || IS_GEN3(devid) || IS_GEN3(devid);
+ return IS_GEN2(devid) || IS_GEN3(devid) || IS_GEN4(devid);
}
#define DECLARE_REGS(d,r,m) \
--
2.7.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH i-g-t] tools/intel_reg: Fix builtin register spec for gen4
2016-04-05 12:13 [PATCH i-g-t] tools/intel_reg: Fix builtin register spec for gen4 ville.syrjala
@ 2016-04-05 12:17 ` Matthew Auld
2016-04-05 13:50 ` Jani Nikula
1 sibling, 0 replies; 3+ messages in thread
From: Matthew Auld @ 2016-04-05 12:17 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH i-g-t] tools/intel_reg: Fix builtin register spec for gen4
2016-04-05 12:13 [PATCH i-g-t] tools/intel_reg: Fix builtin register spec for gen4 ville.syrjala
2016-04-05 12:17 ` Matthew Auld
@ 2016-04-05 13:50 ` Jani Nikula
1 sibling, 0 replies; 3+ messages in thread
From: Jani Nikula @ 2016-04-05 13:50 UTC (permalink / raw)
To: ville.syrjala, intel-gfx
On Tue, 05 Apr 2016, ville.syrjala@linux.intel.com wrote:
> [ text/plain ]
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Actually use the builtin register spec on gen4. Makes intel_reg dump
> actually do something on gen4.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> tools/intel_reg_decode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/intel_reg_decode.c b/tools/intel_reg_decode.c
> index bb8f5b30311f..470fecc165c6 100644
> --- a/tools/intel_reg_decode.c
> +++ b/tools/intel_reg_decode.c
> @@ -2580,7 +2580,7 @@ static bool is_945gm(uint32_t devid, uint32_t pch)
>
> static bool is_gen234(uint32_t devid, uint32_t pch)
> {
> - return IS_GEN2(devid) || IS_GEN3(devid) || IS_GEN3(devid);
> + return IS_GEN2(devid) || IS_GEN3(devid) || IS_GEN4(devid);
Facepalm-by: Jani Nikula <jani.nikula@intel.com>
> }
>
> #define DECLARE_REGS(d,r,m) \
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-04-05 13:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-05 12:13 [PATCH i-g-t] tools/intel_reg: Fix builtin register spec for gen4 ville.syrjala
2016-04-05 12:17 ` Matthew Auld
2016-04-05 13:50 ` Jani Nikula
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox