Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: Manasi Navare <manasi.d.navare@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/display: only include intel_dp_link_training.h where needed
Date: Thu, 07 Nov 2019 12:44:20 +0200	[thread overview]
Message-ID: <87wocc55kr.fsf@intel.com> (raw)
In-Reply-To: <20191029201504.GB17819@intel.com>

On Tue, 29 Oct 2019, Manasi Navare <manasi.d.navare@intel.com> wrote:
> On Tue, Oct 29, 2019 at 12:39:47PM +0200, Jani Nikula wrote:
>> The intel_dp_link_training.h include has no need or place in
>> intel_display.h. Include it in intel_display.c instead.
>> 
>> Cc:
>> 
>> Cc: Manasi Navare <manasi.d.navare@intel.com>
>> Fixes: eadf6f9170d5 ("drm/i915/display/icl: Enable master-slaves in trans port sync")
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Ah okay yes makes sens eto add it in intel_display.c Thanks for fixing this.
> After removing the redundant Cc:,
>
> Reviewed-by: Manasi Navare <manasi.d.navare@intel.com>

Finally pushed, thanks for the review.

BR,
Jani.

>
> Manasi
>
>> ---
>>  drivers/gpu/drm/i915/display/intel_display.c | 1 +
>>  drivers/gpu/drm/i915/display/intel_display.h | 1 -
>>  2 files changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
>> index 9dce2e9e5376..505d697f6b4c 100644
>> --- a/drivers/gpu/drm/i915/display/intel_display.c
>> +++ b/drivers/gpu/drm/i915/display/intel_display.c
>> @@ -66,6 +66,7 @@
>>  #include "intel_cdclk.h"
>>  #include "intel_color.h"
>>  #include "intel_display_types.h"
>> +#include "intel_dp_link_training.h"
>>  #include "intel_fbc.h"
>>  #include "intel_fbdev.h"
>>  #include "intel_fifo_underrun.h"
>> diff --git a/drivers/gpu/drm/i915/display/intel_display.h b/drivers/gpu/drm/i915/display/intel_display.h
>> index ca7ca2804d8b..7278f9aee8ca 100644
>> --- a/drivers/gpu/drm/i915/display/intel_display.h
>> +++ b/drivers/gpu/drm/i915/display/intel_display.h
>> @@ -27,7 +27,6 @@
>>  
>>  #include <drm/drm_util.h>
>>  #include <drm/i915_drm.h>
>> -#include "intel_dp_link_training.h"
>>  
>>  enum link_m_n_set;
>>  struct dpll;
>> -- 
>> 2.20.1
>> 

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@intel.com>
To: Manasi Navare <manasi.d.navare@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/display: only include intel_dp_link_training.h where needed
Date: Thu, 07 Nov 2019 12:44:20 +0200	[thread overview]
Message-ID: <87wocc55kr.fsf@intel.com> (raw)
Message-ID: <20191107104420.CTuTPcw-x75_zgxBmAQmem7wejD6rp701wbO2EGsoqc@z> (raw)
In-Reply-To: <20191029201504.GB17819@intel.com>

On Tue, 29 Oct 2019, Manasi Navare <manasi.d.navare@intel.com> wrote:
> On Tue, Oct 29, 2019 at 12:39:47PM +0200, Jani Nikula wrote:
>> The intel_dp_link_training.h include has no need or place in
>> intel_display.h. Include it in intel_display.c instead.
>> 
>> Cc:
>> 
>> Cc: Manasi Navare <manasi.d.navare@intel.com>
>> Fixes: eadf6f9170d5 ("drm/i915/display/icl: Enable master-slaves in trans port sync")
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Ah okay yes makes sens eto add it in intel_display.c Thanks for fixing this.
> After removing the redundant Cc:,
>
> Reviewed-by: Manasi Navare <manasi.d.navare@intel.com>

Finally pushed, thanks for the review.

BR,
Jani.

>
> Manasi
>
>> ---
>>  drivers/gpu/drm/i915/display/intel_display.c | 1 +
>>  drivers/gpu/drm/i915/display/intel_display.h | 1 -
>>  2 files changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
>> index 9dce2e9e5376..505d697f6b4c 100644
>> --- a/drivers/gpu/drm/i915/display/intel_display.c
>> +++ b/drivers/gpu/drm/i915/display/intel_display.c
>> @@ -66,6 +66,7 @@
>>  #include "intel_cdclk.h"
>>  #include "intel_color.h"
>>  #include "intel_display_types.h"
>> +#include "intel_dp_link_training.h"
>>  #include "intel_fbc.h"
>>  #include "intel_fbdev.h"
>>  #include "intel_fifo_underrun.h"
>> diff --git a/drivers/gpu/drm/i915/display/intel_display.h b/drivers/gpu/drm/i915/display/intel_display.h
>> index ca7ca2804d8b..7278f9aee8ca 100644
>> --- a/drivers/gpu/drm/i915/display/intel_display.h
>> +++ b/drivers/gpu/drm/i915/display/intel_display.h
>> @@ -27,7 +27,6 @@
>>  
>>  #include <drm/drm_util.h>
>>  #include <drm/i915_drm.h>
>> -#include "intel_dp_link_training.h"
>>  
>>  enum link_m_n_set;
>>  struct dpll;
>> -- 
>> 2.20.1
>> 

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2019-11-07 10:44 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-29 10:39 [PATCH] drm/i915/display: only include intel_dp_link_training.h where needed Jani Nikula
2019-10-29 10:39 ` [Intel-gfx] " Jani Nikula
2019-10-29 10:52 ` Jani Nikula
2019-10-29 10:52   ` [Intel-gfx] " Jani Nikula
2019-10-29 12:43 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2019-10-29 12:43   ` [Intel-gfx] " Patchwork
2019-10-29 14:34 ` ✗ Fi.CI.BAT: failure " Patchwork
2019-10-29 14:34   ` [Intel-gfx] " Patchwork
2019-10-29 20:15 ` [PATCH] " Manasi Navare
2019-10-29 20:15   ` [Intel-gfx] " Manasi Navare
2019-11-07 10:44   ` Jani Nikula [this message]
2019-11-07 10:44     ` Jani Nikula
2019-10-29 21:49 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display: only include intel_dp_link_training.h where needed (rev2) Patchwork
2019-10-29 21:49   ` [Intel-gfx] " Patchwork
2019-10-29 22:11 ` ✓ Fi.CI.BAT: success " Patchwork
2019-10-29 22:11   ` [Intel-gfx] " Patchwork
2019-10-30 19:43 ` ✓ Fi.CI.IGT: " Patchwork
2019-10-30 19:43   ` [Intel-gfx] " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wocc55kr.fsf@intel.com \
    --to=jani.nikula@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=manasi.d.navare@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox