From: Jani Nikula <jani.nikula@intel.com>
To: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2 1/4] drm/i915/dsi: remove unused _MIPIA_AUTOPWG register definition
Date: Tue, 23 Apr 2024 17:41:52 +0300 [thread overview]
Message-ID: <87y194qgy7.fsf@intel.com> (raw)
In-Reply-To: <ZibPwTsKs7M7K2fL@intel.com>
On Mon, 22 Apr 2024, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
> On Fri, Apr 19, 2024 at 01:04:03PM +0300, Jani Nikula wrote:
>> There are other unused registers, but this is also unusable and
>> inadequate. Remove.
>>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Thanks for the review, pushed the lot to din.
BR,
Jani.
>
>> ---
>> drivers/gpu/drm/i915/display/vlv_dsi_regs.h | 3 ---
>> 1 file changed, 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/vlv_dsi_regs.h b/drivers/gpu/drm/i915/display/vlv_dsi_regs.h
>> index abbe427e462e..b0cdaad7db9c 100644
>> --- a/drivers/gpu/drm/i915/display/vlv_dsi_regs.h
>> +++ b/drivers/gpu/drm/i915/display/vlv_dsi_regs.h
>> @@ -93,9 +93,6 @@
>> #define TEARING_EFFECT_DELAY_SHIFT 0
>> #define TEARING_EFFECT_DELAY_MASK (0xffff << 0)
>>
>> -/* XXX: all bits reserved */
>> -#define _MIPIA_AUTOPWG (VLV_DISPLAY_BASE + 0x611a0)
>> -
>> /* MIPI DSI Controller and D-PHY registers */
>>
>> #define _MIPIA_DEVICE_READY (_MIPI_MMIO_BASE(dev_priv) + 0xb000)
>> --
>> 2.39.2
>>
--
Jani Nikula, Intel
next prev parent reply other threads:[~2024-04-23 14:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-19 10:04 [PATCH v2 0/4] drm/i915/dsi: stop relying on implicit dev_priv variable Jani Nikula
2024-04-19 10:04 ` [PATCH v2 1/4] drm/i915/dsi: remove unused _MIPIA_AUTOPWG register definition Jani Nikula
2024-04-22 20:59 ` Rodrigo Vivi
2024-04-23 14:41 ` Jani Nikula [this message]
2024-04-19 10:04 ` [PATCH v2 2/4] drm/i915/dsi: add VLV_ prefix to VLV only register macros Jani Nikula
2024-04-22 21:00 ` Rodrigo Vivi
2024-04-19 10:04 ` [PATCH v2 3/4] drm/i915/dsi: unify connector/encoder type and name usage Jani Nikula
2024-04-22 21:07 ` Rodrigo Vivi
2024-04-19 10:04 ` [PATCH v2 4/4] drm/i915/dsi: pass display to register macros instead of implicit variable Jani Nikula
2024-04-22 21:10 ` Rodrigo Vivi
2024-04-22 21:16 ` Gustavo Sousa
2024-04-22 21:21 ` Rodrigo Vivi
2024-04-19 10:46 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dsi: stop relying on implicit dev_priv variable (rev2) Patchwork
2024-04-19 10:53 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-04-19 12:04 ` Jani Nikula
2024-04-22 23:33 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dsi: stop relying on implicit dev_priv variable (rev3) Patchwork
2024-04-22 23:40 ` ✓ Fi.CI.BAT: success " Patchwork
2024-04-23 20:48 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y194qgy7.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox