Re: [Intel-gfx] [PATCH] drm/i915: Add bigjoiner force enable option to debugfs

[Jani Nikula <jani.nikula@intel.com>]

On Wed, 17 Jan 2024, "Sharma, Swati2" <swati2.sharma@intel.com> wrote:
> Hi Ville,
>
> On 25-Oct-23 6:29 PM, Ville Syrjälä wrote:
>> On Wed, Oct 18, 2023 at 04:24:00PM +0300, Stanislav Lisovskiy wrote:
>>> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
>>> index 4f6835a7578e..6a9148232a9c 100644
>>> --- a/drivers/gpu/drm/i915/display/intel_dp.c
>>> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
>>> @@ -1153,7 +1153,11 @@ bool intel_dp_need_bigjoiner(struct intel_dp *intel_dp,
>>>   	if (!intel_dp_can_bigjoiner(intel_dp))
>>>   		return false;
>>>   
>>> -	return clock > i915->max_dotclk_freq || hdisplay > 5120;
>>> +	if (intel_dp->force_bigjoiner_enable)
>>> +		drm_dbg_kms(&i915->drm, "Forcing bigjoiner mode\n");
>> 
>> That's going to cause excessive dmesg spam.
>
> Then how from dmesg we will get to know, big joiner was forced? 
> Shouldn't we have atleast one debug print to know this?

Yeah. But this gets called for every single display mode via
intel_dp_mode_valid().

BR,
Jani.


-- 
Jani Nikula, Intel