Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH v3] drm/i915/display/lspcon: Increase LSPCON mode settle timeout
@ 2023-08-16  4:56 Pablo Ceballos
  2023-08-16  6:50 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display/lspcon: Increase LSPCON mode settle timeout (rev4) Patchwork
                   ` (5 more replies)
  0 siblings, 6 replies; 7+ messages in thread
From: Pablo Ceballos @ 2023-08-16  4:56 UTC (permalink / raw)
  To: Ankit K Nautiyal
  Cc: intel-gfx, linux-kernel, dri-devel, Daniel Vetter, Rodrigo Vivi,
	David Airlie, Pablo Ceballos

This is to eliminate all cases of "*ERROR* LSPCON mode hasn't settled",
followed by link training errors. Intel engineers recommended increasing
this timeout and that does resolve the issue.

On some CometLake-based device designs the Parade PS175 takes more than
400ms to settle in PCON mode. 100 reboot trials on one device resulted
in a median settle time of 440ms and a maximum of 444ms. Even after
increasing the timeout to 500ms, 2% of devices still had this error. So
this increases the timeout to 800ms.

Signed-off-by: Pablo Ceballos <pceballos@google.com>
---

V2: Added more details in the commit message
V3: Only apply the increased timeout if the vendor is Parade

drivers/gpu/drm/i915/display/intel_lspcon.c | 21 ++++++++++++++++++++-
 1 file changed, 20 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_lspcon.c b/drivers/gpu/drm/i915/display/intel_lspcon.c
index bb3b5355a0d9..b07eab84cc63 100644
--- a/drivers/gpu/drm/i915/display/intel_lspcon.c
+++ b/drivers/gpu/drm/i915/display/intel_lspcon.c
@@ -153,6 +153,24 @@ static enum drm_lspcon_mode lspcon_get_current_mode(struct intel_lspcon *lspcon)
 	return current_mode;
 }
 
+static u32 lspcon_get_mode_settle_timeout(struct intel_lspcon *lspcon)
+{
+	u32 timeout_ms = 400;
+
+	/*
+	 * On some CometLake-based device designs the Parade PS175 takes more
+	 * than 400ms to settle in PCON mode. 100 reboot trials on one device
+	 * resulted in a median settle time of 440ms and a maximum of 444ms.
+	 * Even after increasing the timeout to 500ms, 2% of devices still had
+	 * this error. So this sets the timeout to 800ms.
+	 */
+	if (lspcon->vendor == LSPCON_VENDOR_PARADE)
+		timeout_ms = 800;
+
+	return timeout_ms;
+}
+
+
 static enum drm_lspcon_mode lspcon_wait_mode(struct intel_lspcon *lspcon,
 					     enum drm_lspcon_mode mode)
 {
@@ -167,7 +185,8 @@ static enum drm_lspcon_mode lspcon_wait_mode(struct intel_lspcon *lspcon,
 	drm_dbg_kms(&i915->drm, "Waiting for LSPCON mode %s to settle\n",
 		    lspcon_mode_name(mode));
 
-	wait_for((current_mode = lspcon_get_current_mode(lspcon)) == mode, 400);
+	wait_for((current_mode = lspcon_get_current_mode(lspcon)) == mode,
+		 lspcon_get_mode_settle_timeout(lspcon));
 	if (current_mode != mode)
 		drm_err(&i915->drm, "LSPCON mode hasn't settled\n");
 
-- 
2.39.2


^ permalink raw reply related	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-10-02 10:01 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-16  4:56 [Intel-gfx] [PATCH v3] drm/i915/display/lspcon: Increase LSPCON mode settle timeout Pablo Ceballos
2023-08-16  6:50 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display/lspcon: Increase LSPCON mode settle timeout (rev4) Patchwork
2023-08-16  6:50 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-08-16  7:08 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-08-16  9:02 ` [Intel-gfx] [PATCH v3] drm/i915/display/lspcon: Increase LSPCON mode settle timeout Jani Nikula
2023-08-16 10:42 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/display/lspcon: Increase LSPCON mode settle timeout (rev4) Patchwork
2023-10-02 10:00 ` [Intel-gfx] [PATCH v3] drm/i915/display/lspcon: Increase LSPCON mode settle timeout Jani Nikula

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox