* [Intel-gfx] [PATCH 0/2] gtt_offset and OA buffer cached head/tail
@ 2023-07-18 2:43 Ashutosh Dixit
2023-07-18 2:43 ` [Intel-gfx] [PATCH 1/2] drm/i915/perf: Subtract gtt_offset from hw_tail Ashutosh Dixit
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Ashutosh Dixit @ 2023-07-18 2:43 UTC (permalink / raw)
To: intel-gfx
Ashutosh Dixit (2):
drm/i915/perf: Subtract gtt_offset from hw_tail
drm/i915/perf: Remove gtt_offset from stream->oa_buffer.head/.tail
drivers/gpu/drm/i915/i915_perf.c | 52 ++++++++------------------------
1 file changed, 13 insertions(+), 39 deletions(-)
--
2.41.0
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Intel-gfx] [PATCH 1/2] drm/i915/perf: Subtract gtt_offset from hw_tail
2023-07-18 2:43 [Intel-gfx] [PATCH 0/2] gtt_offset and OA buffer cached head/tail Ashutosh Dixit
@ 2023-07-18 2:43 ` Ashutosh Dixit
2023-07-18 8:39 ` Lionel Landwerlin
2023-07-18 2:43 ` [Intel-gfx] [PATCH 2/2] drm/i915/perf: Remove gtt_offset from stream->oa_buffer.head/.tail Ashutosh Dixit
` (2 subsequent siblings)
3 siblings, 1 reply; 7+ messages in thread
From: Ashutosh Dixit @ 2023-07-18 2:43 UTC (permalink / raw)
To: intel-gfx
The code in oa_buffer_check_unlocked() is correct only if the OA buffer is
16 MB aligned (which seems to be the case today in i915). However when the
16 MB alignment is dropped, when we "Subtract partial amount off the tail",
the "& (OA_BUFFER_SIZE - 1)" operation in OA_TAKEN() will result in an
incorrect hw_tail value.
Therefore hw_tail must be brought to the same base as head and read_tail
prior to OA_TAKEN by subtracting gtt_offset from hw_tail.
Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
---
drivers/gpu/drm/i915/i915_perf.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c
index 49c6f1ff11284..f7888a44d1284 100644
--- a/drivers/gpu/drm/i915/i915_perf.c
+++ b/drivers/gpu/drm/i915/i915_perf.c
@@ -565,6 +565,7 @@ static bool oa_buffer_check_unlocked(struct i915_perf_stream *stream)
partial_report_size %= report_size;
/* Subtract partial amount off the tail */
+ hw_tail -= gtt_offset;
hw_tail = OA_TAKEN(hw_tail, partial_report_size);
/* NB: The head we observe here might effectively be a little
--
2.41.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Intel-gfx] [PATCH 2/2] drm/i915/perf: Remove gtt_offset from stream->oa_buffer.head/.tail
2023-07-18 2:43 [Intel-gfx] [PATCH 0/2] gtt_offset and OA buffer cached head/tail Ashutosh Dixit
2023-07-18 2:43 ` [Intel-gfx] [PATCH 1/2] drm/i915/perf: Subtract gtt_offset from hw_tail Ashutosh Dixit
@ 2023-07-18 2:43 ` Ashutosh Dixit
2023-07-18 3:48 ` [Intel-gfx] ✓ Fi.CI.BAT: success for gtt_offset and OA buffer cached head/tail Patchwork
2023-07-18 5:38 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
3 siblings, 0 replies; 7+ messages in thread
From: Ashutosh Dixit @ 2023-07-18 2:43 UTC (permalink / raw)
To: intel-gfx
There is no reason to add gtt_offset to the cached head/tail pointers
stream->oa_buffer.head and stream->oa_buffer.tail. This causes the code to
constantly add gtt_offset and subtract gtt_offset and is error
prone (e.g. see previous patch).
It is much simpler to maintain stream->oa_buffer.head and
stream->oa_buffer.tail without adding gtt_offset to them and just allow for
the gtt_offset when reading/writing from/to HW registers.
Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
---
drivers/gpu/drm/i915/i915_perf.c | 53 ++++++++------------------------
1 file changed, 13 insertions(+), 40 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c
index f7888a44d1284..5cd2346c7df80 100644
--- a/drivers/gpu/drm/i915/i915_perf.c
+++ b/drivers/gpu/drm/i915/i915_perf.c
@@ -543,10 +543,9 @@ static bool oa_buffer_check_unlocked(struct i915_perf_stream *stream)
{
u32 gtt_offset = i915_ggtt_offset(stream->oa_buffer.vma);
int report_size = stream->oa_buffer.format->size;
- u32 head, tail, read_tail;
+ u32 tail, hw_tail;
unsigned long flags;
bool pollin;
- u32 hw_tail;
u32 partial_report_size;
/* We have to consider the (unlikely) possibility that read() errors
@@ -556,6 +555,7 @@ static bool oa_buffer_check_unlocked(struct i915_perf_stream *stream)
spin_lock_irqsave(&stream->oa_buffer.ptr_lock, flags);
hw_tail = stream->perf->ops.oa_hw_tail_read(stream);
+ hw_tail -= gtt_offset;
/* The tail pointer increases in 64 byte increments, not in report_size
* steps. Also the report size may not be a power of 2. Compute
@@ -565,16 +565,8 @@ static bool oa_buffer_check_unlocked(struct i915_perf_stream *stream)
partial_report_size %= report_size;
/* Subtract partial amount off the tail */
- hw_tail -= gtt_offset;
hw_tail = OA_TAKEN(hw_tail, partial_report_size);
- /* NB: The head we observe here might effectively be a little
- * out of date. If a read() is in progress, the head could be
- * anywhere between this head and stream->oa_buffer.tail.
- */
- head = stream->oa_buffer.head - gtt_offset;
- read_tail = stream->oa_buffer.tail - gtt_offset;
-
tail = hw_tail;
/* Walk the stream backward until we find a report with report
@@ -588,7 +580,7 @@ static bool oa_buffer_check_unlocked(struct i915_perf_stream *stream)
* memory in the order they were written to.
* If not : (╯°□°）╯︵ ┻━┻
*/
- while (OA_TAKEN(tail, read_tail) >= report_size) {
+ while (OA_TAKEN(tail, stream->oa_buffer.tail) >= report_size) {
void *report = stream->oa_buffer.vaddr + tail;
if (oa_report_id(stream, report) ||
@@ -602,9 +594,9 @@ static bool oa_buffer_check_unlocked(struct i915_perf_stream *stream)
__ratelimit(&stream->perf->tail_pointer_race))
drm_notice(&stream->uncore->i915->drm,
"unlanded report(s) head=0x%x tail=0x%x hw_tail=0x%x\n",
- head, tail, hw_tail);
+ stream->oa_buffer.head, tail, hw_tail);
- stream->oa_buffer.tail = gtt_offset + tail;
+ stream->oa_buffer.tail = tail;
pollin = OA_TAKEN(stream->oa_buffer.tail,
stream->oa_buffer.head) >= report_size;
@@ -754,13 +746,6 @@ static int gen8_append_oa_reports(struct i915_perf_stream *stream,
spin_unlock_irqrestore(&stream->oa_buffer.ptr_lock, flags);
- /*
- * NB: oa_buffer.head/tail include the gtt_offset which we don't want
- * while indexing relative to oa_buf_base.
- */
- head -= gtt_offset;
- tail -= gtt_offset;
-
/*
* An out of bounds or misaligned head or tail pointer implies a driver
* bug since we validate + align the tail pointers we read from the
@@ -896,9 +881,8 @@ static int gen8_append_oa_reports(struct i915_perf_stream *stream,
* We removed the gtt_offset for the copy loop above, indexing
* relative to oa_buf_base so put back here...
*/
- head += gtt_offset;
intel_uncore_write(uncore, oaheadptr,
- head & GEN12_OAG_OAHEADPTR_MASK);
+ (head + gtt_offset) & GEN12_OAG_OAHEADPTR_MASK);
stream->oa_buffer.head = head;
spin_unlock_irqrestore(&stream->oa_buffer.ptr_lock, flags);
@@ -1043,12 +1027,6 @@ static int gen7_append_oa_reports(struct i915_perf_stream *stream,
spin_unlock_irqrestore(&stream->oa_buffer.ptr_lock, flags);
- /* NB: oa_buffer.head/tail include the gtt_offset which we don't want
- * while indexing relative to oa_buf_base.
- */
- head -= gtt_offset;
- tail -= gtt_offset;
-
/* An out of bounds or misaligned head or tail pointer implies a driver
* bug since we validate + align the tail pointers we read from the
* hardware and we are in full control of the head pointer which should
@@ -1111,13 +1089,8 @@ static int gen7_append_oa_reports(struct i915_perf_stream *stream,
if (start_offset != *offset) {
spin_lock_irqsave(&stream->oa_buffer.ptr_lock, flags);
- /* We removed the gtt_offset for the copy loop above, indexing
- * relative to oa_buf_base so put back here...
- */
- head += gtt_offset;
-
intel_uncore_write(uncore, GEN7_OASTATUS2,
- (head & GEN7_OASTATUS2_HEAD_MASK) |
+ ((head + gtt_offset) & GEN7_OASTATUS2_HEAD_MASK) |
GEN7_OASTATUS2_MEM_SELECT_GGTT);
stream->oa_buffer.head = head;
@@ -1712,7 +1685,7 @@ static void gen7_init_oa_buffer(struct i915_perf_stream *stream)
*/
intel_uncore_write(uncore, GEN7_OASTATUS2, /* head */
gtt_offset | GEN7_OASTATUS2_MEM_SELECT_GGTT);
- stream->oa_buffer.head = gtt_offset;
+ stream->oa_buffer.head = 0;
intel_uncore_write(uncore, GEN7_OABUFFER, gtt_offset);
@@ -1720,7 +1693,7 @@ static void gen7_init_oa_buffer(struct i915_perf_stream *stream)
gtt_offset | OABUFFER_SIZE_16M);
/* Mark that we need updated tail pointers to read from... */
- stream->oa_buffer.tail = gtt_offset;
+ stream->oa_buffer.tail = 0;
spin_unlock_irqrestore(&stream->oa_buffer.ptr_lock, flags);
@@ -1754,7 +1727,7 @@ static void gen8_init_oa_buffer(struct i915_perf_stream *stream)
intel_uncore_write(uncore, GEN8_OASTATUS, 0);
intel_uncore_write(uncore, GEN8_OAHEADPTR, gtt_offset);
- stream->oa_buffer.head = gtt_offset;
+ stream->oa_buffer.head = 0;
intel_uncore_write(uncore, GEN8_OABUFFER_UDW, 0);
@@ -1771,7 +1744,7 @@ static void gen8_init_oa_buffer(struct i915_perf_stream *stream)
intel_uncore_write(uncore, GEN8_OATAILPTR, gtt_offset & GEN8_OATAILPTR_MASK);
/* Mark that we need updated tail pointers to read from... */
- stream->oa_buffer.tail = gtt_offset;
+ stream->oa_buffer.tail = 0;
/*
* Reset state used to recognise context switches, affecting which
@@ -1808,7 +1781,7 @@ static void gen12_init_oa_buffer(struct i915_perf_stream *stream)
intel_uncore_write(uncore, __oa_regs(stream)->oa_status, 0);
intel_uncore_write(uncore, __oa_regs(stream)->oa_head_ptr,
gtt_offset & GEN12_OAG_OAHEADPTR_MASK);
- stream->oa_buffer.head = gtt_offset;
+ stream->oa_buffer.head = 0;
/*
* PRM says:
@@ -1824,7 +1797,7 @@ static void gen12_init_oa_buffer(struct i915_perf_stream *stream)
gtt_offset & GEN12_OAG_OATAILPTR_MASK);
/* Mark that we need updated tail pointers to read from... */
- stream->oa_buffer.tail = gtt_offset;
+ stream->oa_buffer.tail = 0;
/*
* Reset state used to recognise context switches, affecting which
--
2.41.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for gtt_offset and OA buffer cached head/tail
2023-07-18 2:43 [Intel-gfx] [PATCH 0/2] gtt_offset and OA buffer cached head/tail Ashutosh Dixit
2023-07-18 2:43 ` [Intel-gfx] [PATCH 1/2] drm/i915/perf: Subtract gtt_offset from hw_tail Ashutosh Dixit
2023-07-18 2:43 ` [Intel-gfx] [PATCH 2/2] drm/i915/perf: Remove gtt_offset from stream->oa_buffer.head/.tail Ashutosh Dixit
@ 2023-07-18 3:48 ` Patchwork
2023-07-18 5:38 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
3 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2023-07-18 3:48 UTC (permalink / raw)
To: Ashutosh Dixit; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 14981 bytes --]
== Series Details ==
Series: gtt_offset and OA buffer cached head/tail
URL : https://patchwork.freedesktop.org/series/120880/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13392 -> Patchwork_120880v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/index.html
Participating hosts (43 -> 41)
------------------------------
Additional (1): bat-rpls-2
Missing (3): fi-kbl-soraka fi-snb-2520m fi-pnv-d510
Known issues
------------
Here are the changes found in Patchwork_120880v1 that come from known issues:
### CI changes ###
#### Issues hit ####
* boot:
- fi-apl-guc: [PASS][1] -> [FAIL][2] ([i915#4386] / [i915#8293])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/fi-apl-guc/boot.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/fi-apl-guc/boot.html
### IGT changes ###
#### Issues hit ####
* igt@debugfs_test@basic-hwmon:
- bat-rpls-2: NOTRUN -> [SKIP][3] ([i915#7456])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/bat-rpls-2/igt@debugfs_test@basic-hwmon.html
* igt@fbdev@info:
- bat-rpls-2: NOTRUN -> [SKIP][4] ([i915#1849] / [i915#2582])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/bat-rpls-2/igt@fbdev@info.html
* igt@fbdev@read:
- bat-rpls-2: NOTRUN -> [SKIP][5] ([i915#2582]) +3 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/bat-rpls-2/igt@fbdev@read.html
* igt@gem_lmem_swapping@verify-random:
- bat-rpls-2: NOTRUN -> [SKIP][6] ([i915#4613]) +3 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/bat-rpls-2/igt@gem_lmem_swapping@verify-random.html
* igt@gem_tiled_pread_basic:
- bat-rpls-2: NOTRUN -> [SKIP][7] ([i915#3282])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/bat-rpls-2/igt@gem_tiled_pread_basic.html
* igt@i915_pm_backlight@basic-brightness:
- bat-rpls-2: NOTRUN -> [SKIP][8] ([i915#7561])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/bat-rpls-2/igt@i915_pm_backlight@basic-brightness.html
* igt@i915_pm_rpm@basic-rte:
- fi-cfl-guc: [PASS][9] -> [FAIL][10] ([i915#7940])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/fi-cfl-guc/igt@i915_pm_rpm@basic-rte.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/fi-cfl-guc/igt@i915_pm_rpm@basic-rte.html
- fi-cfl-8700k: [PASS][11] -> [FAIL][12] ([i915#7940])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/fi-cfl-8700k/igt@i915_pm_rpm@basic-rte.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/fi-cfl-8700k/igt@i915_pm_rpm@basic-rte.html
* igt@i915_pm_rpm@module-reload:
- fi-skl-guc: [PASS][13] -> [FAIL][14] ([i915#7940])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/fi-skl-guc/igt@i915_pm_rpm@module-reload.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/fi-skl-guc/igt@i915_pm_rpm@module-reload.html
* igt@i915_pm_rps@basic-api:
- bat-rpls-2: NOTRUN -> [SKIP][15] ([i915#6621])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/bat-rpls-2/igt@i915_pm_rps@basic-api.html
* igt@i915_selftest@live@gt_mocs:
- bat-mtlp-6: [PASS][16] -> [DMESG-FAIL][17] ([i915#7059])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/bat-mtlp-6/igt@i915_selftest@live@gt_mocs.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/bat-mtlp-6/igt@i915_selftest@live@gt_mocs.html
* igt@i915_selftest@live@gt_pm:
- bat-rpls-2: NOTRUN -> [DMESG-FAIL][18] ([i915#4258] / [i915#7913])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/bat-rpls-2/igt@i915_selftest@live@gt_pm.html
* igt@i915_selftest@live@hangcheck:
- bat-dg2-11: [PASS][19] -> [ABORT][20] ([i915#7913] / [i915#7979])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/bat-dg2-11/igt@i915_selftest@live@hangcheck.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/bat-dg2-11/igt@i915_selftest@live@hangcheck.html
* igt@i915_selftest@live@requests:
- bat-mtlp-8: [PASS][21] -> [ABORT][22] ([i915#7982])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/bat-mtlp-8/igt@i915_selftest@live@requests.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/bat-mtlp-8/igt@i915_selftest@live@requests.html
* igt@i915_selftest@live@slpc:
- bat-mtlp-6: [PASS][23] -> [DMESG-WARN][24] ([i915#6367])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/bat-mtlp-6/igt@i915_selftest@live@slpc.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/bat-mtlp-6/igt@i915_selftest@live@slpc.html
- bat-rpls-1: [PASS][25] -> [DMESG-WARN][26] ([i915#6367])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/bat-rpls-1/igt@i915_selftest@live@slpc.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/bat-rpls-1/igt@i915_selftest@live@slpc.html
* igt@i915_selftest@live@workarounds:
- bat-rpls-1: [PASS][27] -> [DMESG-FAIL][28] ([i915#7102])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/bat-rpls-1/igt@i915_selftest@live@workarounds.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/bat-rpls-1/igt@i915_selftest@live@workarounds.html
* igt@i915_suspend@basic-s3-without-i915:
- bat-rpls-2: NOTRUN -> [ABORT][29] ([i915#6687] / [i915#7978] / [i915#8668])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/bat-rpls-2/igt@i915_suspend@basic-s3-without-i915.html
* igt@kms_busy@basic:
- bat-rpls-2: NOTRUN -> [SKIP][30] ([i915#1845]) +14 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/bat-rpls-2/igt@kms_busy@basic.html
* igt@kms_chamelium_edid@hdmi-edid-read:
- bat-rpls-2: NOTRUN -> [SKIP][31] ([i915#7828]) +7 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/bat-rpls-2/igt@kms_chamelium_edid@hdmi-edid-read.html
* igt@kms_flip@basic-flip-vs-dpms:
- bat-rpls-2: NOTRUN -> [SKIP][32] ([i915#3637]) +3 similar issues
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/bat-rpls-2/igt@kms_flip@basic-flip-vs-dpms.html
* igt@kms_force_connector_basic@force-load-detect:
- bat-rpls-2: NOTRUN -> [SKIP][33] ([fdo#109285])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/bat-rpls-2/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_frontbuffer_tracking@basic:
- bat-rpls-2: NOTRUN -> [SKIP][34] ([i915#1849])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/bat-rpls-2/igt@kms_frontbuffer_tracking@basic.html
* igt@kms_psr@cursor_plane_move:
- bat-rplp-1: NOTRUN -> [ABORT][35] ([i915#8434])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/bat-rplp-1/igt@kms_psr@cursor_plane_move.html
* igt@kms_psr@primary_page_flip:
- bat-rplp-1: NOTRUN -> [SKIP][36] ([i915#1072])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/bat-rplp-1/igt@kms_psr@primary_page_flip.html
* igt@kms_psr@sprite_plane_onoff:
- bat-rpls-2: NOTRUN -> [SKIP][37] ([i915#1072]) +3 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/bat-rpls-2/igt@kms_psr@sprite_plane_onoff.html
* igt@kms_setmode@basic-clone-single-crtc:
- bat-rpls-2: NOTRUN -> [SKIP][38] ([i915#3555])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/bat-rpls-2/igt@kms_setmode@basic-clone-single-crtc.html
* igt@prime_vgem@basic-fence-flip:
- bat-rpls-2: NOTRUN -> [SKIP][39] ([fdo#109295] / [i915#1845] / [i915#3708])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/bat-rpls-2/igt@prime_vgem@basic-fence-flip.html
* igt@prime_vgem@basic-write:
- bat-rpls-2: NOTRUN -> [SKIP][40] ([fdo#109295] / [i915#3708]) +2 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/bat-rpls-2/igt@prime_vgem@basic-write.html
#### Possible fixes ####
* igt@i915_pm_rpm@basic-rte:
- fi-cfl-8109u: [FAIL][41] ([i915#7940]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/fi-cfl-8109u/igt@i915_pm_rpm@basic-rte.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/fi-cfl-8109u/igt@i915_pm_rpm@basic-rte.html
- fi-skl-guc: [FAIL][43] ([i915#7940]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/fi-skl-guc/igt@i915_pm_rpm@basic-rte.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/fi-skl-guc/igt@i915_pm_rpm@basic-rte.html
* igt@i915_pm_rpm@module-reload:
- fi-rkl-11600: [FAIL][45] ([i915#7940]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/fi-rkl-11600/igt@i915_pm_rpm@module-reload.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/fi-rkl-11600/igt@i915_pm_rpm@module-reload.html
- fi-tgl-1115g4: [FAIL][47] ([i915#7940]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/fi-tgl-1115g4/igt@i915_pm_rpm@module-reload.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/fi-tgl-1115g4/igt@i915_pm_rpm@module-reload.html
* igt@i915_selftest@live@migrate:
- bat-dg2-11: [DMESG-WARN][49] ([i915#7699]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/bat-dg2-11/igt@i915_selftest@live@migrate.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/bat-dg2-11/igt@i915_selftest@live@migrate.html
* igt@i915_selftest@live@requests:
- bat-mtlp-6: [DMESG-FAIL][51] ([i915#8497]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/bat-mtlp-6/igt@i915_selftest@live@requests.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/bat-mtlp-6/igt@i915_selftest@live@requests.html
* igt@kms_chamelium_frames@dp-crc-fast:
- {bat-dg2-13}: [DMESG-WARN][53] ([Intel XE#485]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/bat-dg2-13/igt@kms_chamelium_frames@dp-crc-fast.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/bat-dg2-13/igt@kms_chamelium_frames@dp-crc-fast.html
* igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1:
- bat-rplp-1: [ABORT][55] ([i915#8442] / [i915#8668]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/bat-rplp-1/igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/bat-rplp-1/igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1.html
#### Warnings ####
* igt@i915_module_load@load:
- bat-adlp-11: [DMESG-WARN][57] ([i915#4423]) -> [ABORT][58] ([i915#4423])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/bat-adlp-11/igt@i915_module_load@load.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/bat-adlp-11/igt@i915_module_load@load.html
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-kbl-guc: [FAIL][59] ([i915#7940]) -> [SKIP][60] ([fdo#109271])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/fi-kbl-guc/igt@i915_pm_rpm@basic-pci-d3-state.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/fi-kbl-guc/igt@i915_pm_rpm@basic-pci-d3-state.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[Intel XE#485]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/485
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4258]: https://gitlab.freedesktop.org/drm/intel/issues/4258
[i915#4386]: https://gitlab.freedesktop.org/drm/intel/issues/4386
[i915#4423]: https://gitlab.freedesktop.org/drm/intel/issues/4423
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6687]: https://gitlab.freedesktop.org/drm/intel/issues/6687
[i915#7059]: https://gitlab.freedesktop.org/drm/intel/issues/7059
[i915#7102]: https://gitlab.freedesktop.org/drm/intel/issues/7102
[i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7699]: https://gitlab.freedesktop.org/drm/intel/issues/7699
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7940]: https://gitlab.freedesktop.org/drm/intel/issues/7940
[i915#7978]: https://gitlab.freedesktop.org/drm/intel/issues/7978
[i915#7979]: https://gitlab.freedesktop.org/drm/intel/issues/7979
[i915#7982]: https://gitlab.freedesktop.org/drm/intel/issues/7982
[i915#8293]: https://gitlab.freedesktop.org/drm/intel/issues/8293
[i915#8434]: https://gitlab.freedesktop.org/drm/intel/issues/8434
[i915#8442]: https://gitlab.freedesktop.org/drm/intel/issues/8442
[i915#8497]: https://gitlab.freedesktop.org/drm/intel/issues/8497
[i915#8668]: https://gitlab.freedesktop.org/drm/intel/issues/8668
Build changes
-------------
* Linux: CI_DRM_13392 -> Patchwork_120880v1
CI-20190529: 20190529
CI_DRM_13392: 4903d5c2fbae6ab902d3750aaf6a0264b8391442 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7388: 7388
Patchwork_120880v1: 4903d5c2fbae6ab902d3750aaf6a0264b8391442 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
84d783e66cec drm/i915/perf: Remove gtt_offset from stream->oa_buffer.head/.tail
39c013e72f8e drm/i915/perf: Subtract gtt_offset from hw_tail
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/index.html
[-- Attachment #2: Type: text/html, Size: 17716 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for gtt_offset and OA buffer cached head/tail
2023-07-18 2:43 [Intel-gfx] [PATCH 0/2] gtt_offset and OA buffer cached head/tail Ashutosh Dixit
` (2 preceding siblings ...)
2023-07-18 3:48 ` [Intel-gfx] ✓ Fi.CI.BAT: success for gtt_offset and OA buffer cached head/tail Patchwork
@ 2023-07-18 5:38 ` Patchwork
3 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2023-07-18 5:38 UTC (permalink / raw)
To: Dixit, Ashutosh; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 33781 bytes --]
== Series Details ==
Series: gtt_offset and OA buffer cached head/tail
URL : https://patchwork.freedesktop.org/series/120880/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_13392_full -> Patchwork_120880v1_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_120880v1_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_120880v1_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Participating hosts (10 -> 11)
------------------------------
Additional (1): shard-tglu0
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_120880v1_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_mmap_wc@write-gtt-read-wc:
- shard-snb: [PASS][1] -> [ABORT][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-snb1/igt@gem_mmap_wc@write-gtt-read-wc.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-snb7/igt@gem_mmap_wc@write-gtt-read-wc.html
Known issues
------------
Here are the changes found in Patchwork_120880v1_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@api_intel_bb@object-reloc-purge-cache:
- shard-dg2: NOTRUN -> [SKIP][3] ([i915#8411])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-dg2-3/igt@api_intel_bb@object-reloc-purge-cache.html
* igt@drm_fdinfo@most-busy-check-all@rcs0:
- shard-rkl: [PASS][4] -> [FAIL][5] ([i915#7742])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-rkl-6/igt@drm_fdinfo@most-busy-check-all@rcs0.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-rkl-2/igt@drm_fdinfo@most-busy-check-all@rcs0.html
* igt@gem_barrier_race@remote-request@rcs0:
- shard-tglu: [PASS][6] -> [ABORT][7] ([i915#8178])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-tglu-8/igt@gem_barrier_race@remote-request@rcs0.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-tglu-6/igt@gem_barrier_race@remote-request@rcs0.html
* igt@gem_basic@multigpu-create-close:
- shard-dg2: NOTRUN -> [SKIP][8] ([i915#7697])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-dg2-3/igt@gem_basic@multigpu-create-close.html
* igt@gem_ctx_exec@basic-nohangcheck:
- shard-rkl: [PASS][9] -> [FAIL][10] ([i915#6268])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-rkl-2/igt@gem_ctx_exec@basic-nohangcheck.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-rkl-1/igt@gem_ctx_exec@basic-nohangcheck.html
* igt@gem_ctx_persistence@processes:
- shard-snb: NOTRUN -> [SKIP][11] ([fdo#109271] / [i915#1099]) +1 similar issue
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-snb7/igt@gem_ctx_persistence@processes.html
* igt@gem_eio@hibernate:
- shard-dg2: NOTRUN -> [ABORT][12] ([i915#7975] / [i915#8213])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-dg2-3/igt@gem_eio@hibernate.html
* igt@gem_eio@reset-stress:
- shard-dg2: [PASS][13] -> [FAIL][14] ([i915#5784])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-dg2-3/igt@gem_eio@reset-stress.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-dg2-5/igt@gem_eio@reset-stress.html
* igt@gem_exec_fair@basic-none@bcs0:
- shard-rkl: [PASS][15] -> [FAIL][16] ([i915#2842])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-rkl-6/igt@gem_exec_fair@basic-none@bcs0.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-rkl-6/igt@gem_exec_fair@basic-none@bcs0.html
* igt@gem_exec_fence@submit:
- shard-mtlp: NOTRUN -> [SKIP][17] ([i915#4812])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-mtlp-6/igt@gem_exec_fence@submit.html
* igt@gem_exec_fence@submit67:
- shard-dg2: NOTRUN -> [SKIP][18] ([i915#4812])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-dg2-3/igt@gem_exec_fence@submit67.html
* igt@gem_exec_flush@basic-batch-kernel-default-uc:
- shard-dg2: NOTRUN -> [SKIP][19] ([i915#3539] / [i915#4852])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-dg2-3/igt@gem_exec_flush@basic-batch-kernel-default-uc.html
* igt@gem_mmap_gtt@medium-copy-xy:
- shard-mtlp: NOTRUN -> [SKIP][20] ([i915#4077]) +1 similar issue
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-mtlp-6/igt@gem_mmap_gtt@medium-copy-xy.html
* igt@gem_mmap_gtt@ptrace:
- shard-dg2: NOTRUN -> [SKIP][21] ([i915#4077]) +1 similar issue
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-dg2-3/igt@gem_mmap_gtt@ptrace.html
* igt@gem_mmap_wc@write-wc-read-gtt:
- shard-mtlp: NOTRUN -> [SKIP][22] ([i915#4083])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-mtlp-6/igt@gem_mmap_wc@write-wc-read-gtt.html
* igt@gem_render_copy@yf-tiled-ccs-to-linear:
- shard-dg2: NOTRUN -> [SKIP][23] ([i915#5190])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-dg2-3/igt@gem_render_copy@yf-tiled-ccs-to-linear.html
* igt@gem_set_tiling_vs_blt@tiled-to-untiled:
- shard-dg2: NOTRUN -> [SKIP][24] ([i915#4079])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-dg2-3/igt@gem_set_tiling_vs_blt@tiled-to-untiled.html
* igt@i915_module_load@reload-with-fault-injection:
- shard-mtlp: [PASS][25] -> [ABORT][26] ([i915#8489] / [i915#8668])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-mtlp-7/igt@i915_module_load@reload-with-fault-injection.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-mtlp-3/igt@i915_module_load@reload-with-fault-injection.html
* igt@i915_pm_dc@dc5-psr:
- shard-dg2: NOTRUN -> [SKIP][27] ([i915#658])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-dg2-3/igt@i915_pm_dc@dc5-psr.html
* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a:
- shard-dg2: NOTRUN -> [SKIP][28] ([i915#1937])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-dg2-5/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a.html
* igt@i915_pm_rpm@dpms-mode-unset-non-lpsp:
- shard-rkl: [PASS][29] -> [SKIP][30] ([i915#1397]) +1 similar issue
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-rkl-2/igt@i915_pm_rpm@dpms-mode-unset-non-lpsp.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-rkl-7/igt@i915_pm_rpm@dpms-mode-unset-non-lpsp.html
* igt@i915_pm_rpm@i2c:
- shard-dg2: [PASS][31] -> [FAIL][32] ([i915#8717])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-dg2-12/igt@i915_pm_rpm@i2c.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-dg2-2/igt@i915_pm_rpm@i2c.html
* igt@i915_pm_rpm@modeset-non-lpsp-stress:
- shard-dg2: [PASS][33] -> [SKIP][34] ([i915#1397]) +1 similar issue
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-dg2-7/igt@i915_pm_rpm@modeset-non-lpsp-stress.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-dg2-10/igt@i915_pm_rpm@modeset-non-lpsp-stress.html
* igt@i915_pm_rpm@system-suspend-modeset:
- shard-tglu: [PASS][35] -> [FAIL][36] ([i915#7940])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-tglu-10/igt@i915_pm_rpm@system-suspend-modeset.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-tglu-3/igt@i915_pm_rpm@system-suspend-modeset.html
* igt@i915_selftest@live@gt_heartbeat:
- shard-apl: [PASS][37] -> [DMESG-FAIL][38] ([i915#5334])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-apl2/igt@i915_selftest@live@gt_heartbeat.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-apl7/igt@i915_selftest@live@gt_heartbeat.html
* igt@i915_suspend@fence-restore-untiled:
- shard-snb: NOTRUN -> [DMESG-WARN][39] ([i915#8841])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-snb7/igt@i915_suspend@fence-restore-untiled.html
* igt@i915_suspend@forcewake:
- shard-dg2: [PASS][40] -> [INCOMPLETE][41] ([i915#4817])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-dg2-8/igt@i915_suspend@forcewake.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-dg2-11/igt@i915_suspend@forcewake.html
* igt@kms_async_flips@alternate-sync-async-flip@pipe-b-hdmi-a-1:
- shard-glk: [PASS][42] -> [FAIL][43] ([i915#2521])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-glk3/igt@kms_async_flips@alternate-sync-async-flip@pipe-b-hdmi-a-1.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-glk1/igt@kms_async_flips@alternate-sync-async-flip@pipe-b-hdmi-a-1.html
* igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-async-flip:
- shard-mtlp: NOTRUN -> [FAIL][44] ([i915#3743])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-mtlp-5/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-async-flip.html
* igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-0-async-flip:
- shard-mtlp: [PASS][45] -> [FAIL][46] ([i915#3743])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-mtlp-2/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-0-async-flip.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-mtlp-1/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-0-async-flip.html
* igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0:
- shard-dg2: NOTRUN -> [SKIP][47] ([i915#4538] / [i915#5190])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-dg2-3/igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0.html
* igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_ccs:
- shard-mtlp: NOTRUN -> [SKIP][48] ([i915#6095])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-mtlp-5/igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_ccs.html
* igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_mc_ccs:
- shard-dg2: NOTRUN -> [SKIP][49] ([i915#3689] / [i915#3886] / [i915#5354])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-dg2-3/igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc:
- shard-mtlp: NOTRUN -> [SKIP][50] ([i915#3886] / [i915#6095]) +1 similar issue
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-mtlp-6/igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-c-crc-primary-rotation-180-yf_tiled_ccs:
- shard-dg2: NOTRUN -> [SKIP][51] ([i915#3689] / [i915#5354]) +2 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-dg2-3/igt@kms_ccs@pipe-c-crc-primary-rotation-180-yf_tiled_ccs.html
* igt@kms_cdclk@mode-transition@pipe-b-hdmi-a-1:
- shard-dg2: NOTRUN -> [SKIP][52] ([i915#4087] / [i915#7213]) +2 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-dg2-10/igt@kms_cdclk@mode-transition@pipe-b-hdmi-a-1.html
* igt@kms_cdclk@mode-transition@pipe-d-hdmi-a-1:
- shard-dg2: NOTRUN -> [SKIP][53] ([i915#7213])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-dg2-10/igt@kms_cdclk@mode-transition@pipe-d-hdmi-a-1.html
* igt@kms_cdclk@plane-scaling@pipe-c-hdmi-a-3:
- shard-dg2: NOTRUN -> [SKIP][54] ([i915#4087]) +3 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-dg2-6/igt@kms_cdclk@plane-scaling@pipe-c-hdmi-a-3.html
* igt@kms_content_protection@atomic-dpms:
- shard-dg2: NOTRUN -> [SKIP][55] ([i915#7118]) +1 similar issue
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-dg2-5/igt@kms_content_protection@atomic-dpms.html
* igt@kms_content_protection@atomic@pipe-a-dp-4:
- shard-dg2: NOTRUN -> [TIMEOUT][56] ([i915#7173])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-dg2-11/igt@kms_content_protection@atomic@pipe-a-dp-4.html
* igt@kms_cursor_crc@cursor-rapid-movement-512x512:
- shard-dg2: NOTRUN -> [SKIP][57] ([i915#3359])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-dg2-3/igt@kms_cursor_crc@cursor-rapid-movement-512x512.html
* igt@kms_cursor_crc@cursor-sliding-64x21@pipe-a-edp-1:
- shard-mtlp: [PASS][58] -> [DMESG-WARN][59] ([i915#1982])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-mtlp-3/igt@kms_cursor_crc@cursor-sliding-64x21@pipe-a-edp-1.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-mtlp-6/igt@kms_cursor_crc@cursor-sliding-64x21@pipe-a-edp-1.html
* igt@kms_cursor_legacy@cursorb-vs-flipa-atomic-transitions-varying-size:
- shard-mtlp: NOTRUN -> [SKIP][60] ([i915#3546])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-mtlp-5/igt@kms_cursor_legacy@cursorb-vs-flipa-atomic-transitions-varying-size.html
* igt@kms_dither@fb-8bpc-vs-panel-8bpc:
- shard-dg2: NOTRUN -> [SKIP][61] ([i915#3555])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-dg2-3/igt@kms_dither@fb-8bpc-vs-panel-8bpc.html
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-dg2: [PASS][62] -> [FAIL][63] ([fdo#103375])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-dg2-11/igt@kms_fbcon_fbt@fbc-suspend.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-dg2-5/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
- shard-snb: NOTRUN -> [SKIP][64] ([fdo#109271] / [fdo#111767])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-snb7/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@bc-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][65] -> [FAIL][66] ([i915#79])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-glk2/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@bc-hdmi-a1-hdmi-a2.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-glk9/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@bc-hdmi-a1-hdmi-a2.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-pwrite:
- shard-dg2: [PASS][67] -> [FAIL][68] ([i915#6880])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-dg2-12/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-pwrite.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-dg2-3/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-move:
- shard-mtlp: NOTRUN -> [SKIP][69] ([i915#1825])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-mtlp-5/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-move.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-shrfb-draw-blt:
- shard-dg2: NOTRUN -> [SKIP][70] ([i915#5354]) +4 similar issues
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-dg2-3/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-shrfb-draw-blt.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-onoff:
- shard-snb: NOTRUN -> [SKIP][71] ([fdo#109271]) +97 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-snb7/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-onoff.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-indfb-pgflip-blt:
- shard-dg2: NOTRUN -> [SKIP][72] ([i915#3458]) +1 similar issue
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-dg2-3/igt@kms_frontbuffer_tracking@psr-1p-primscrn-indfb-pgflip-blt.html
* igt@kms_hdr@invalid-metadata-sizes:
- shard-dg2: NOTRUN -> [SKIP][73] ([i915#3555] / [i915#8228])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-dg2-5/igt@kms_hdr@invalid-metadata-sizes.html
* igt@kms_plane_scaling@2x-scaler-multi-pipe:
- shard-dg2: NOTRUN -> [SKIP][74] ([fdo#109274] / [i915#5354])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-dg2-3/igt@kms_plane_scaling@2x-scaler-multi-pipe.html
* igt@kms_plane_scaling@plane-downscale-with-modifiers-factor-0-25@pipe-b-hdmi-a-1:
- shard-rkl: NOTRUN -> [SKIP][75] ([i915#5176]) +3 similar issues
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-rkl-7/igt@kms_plane_scaling@plane-downscale-with-modifiers-factor-0-25@pipe-b-hdmi-a-1.html
* igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-25@pipe-d-dp-4:
- shard-dg2: NOTRUN -> [SKIP][76] ([i915#5176]) +11 similar issues
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-dg2-11/igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-25@pipe-d-dp-4.html
* igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-20x20@pipe-b-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][77] ([i915#5235]) +1 similar issue
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-rkl-1/igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-20x20@pipe-b-hdmi-a-2.html
* igt@kms_plane_scaling@planes-downscale-factor-0-25@pipe-d-hdmi-a-2:
- shard-dg2: NOTRUN -> [SKIP][78] ([i915#5235]) +19 similar issues
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-dg2-2/igt@kms_plane_scaling@planes-downscale-factor-0-25@pipe-d-hdmi-a-2.html
* igt@kms_rotation_crc@primary-rotation-90:
- shard-dg2: NOTRUN -> [SKIP][79] ([i915#4235])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-dg2-3/igt@kms_rotation_crc@primary-rotation-90.html
* igt@kms_writeback@writeback-invalid-parameters:
- shard-mtlp: NOTRUN -> [SKIP][80] ([i915#2437])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-mtlp-2/igt@kms_writeback@writeback-invalid-parameters.html
* igt@v3d/v3d_job_submission@multiple-singlesync-to-multisync:
- shard-mtlp: NOTRUN -> [SKIP][81] ([i915#2575])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-mtlp-5/igt@v3d/v3d_job_submission@multiple-singlesync-to-multisync.html
* igt@vc4/vc4_tiling@get-bad-handle:
- shard-dg2: NOTRUN -> [SKIP][82] ([i915#7711]) +1 similar issue
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-dg2-3/igt@vc4/vc4_tiling@get-bad-handle.html
#### Possible fixes ####
* igt@gem_eio@kms:
- {shard-dg1}: [FAIL][83] ([i915#5784]) -> [PASS][84]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-dg1-17/igt@gem_eio@kms.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-dg1-14/igt@gem_eio@kms.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-rkl: [FAIL][85] ([i915#2842]) -> [PASS][86] +2 similar issues
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-rkl-4/igt@gem_exec_fair@basic-throttle@rcs0.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-rkl-6/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@gem_exec_suspend@basic-s3@lmem0:
- shard-dg2: [FAIL][87] ([fdo#103375]) -> [PASS][88] +2 similar issues
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-dg2-2/igt@gem_exec_suspend@basic-s3@lmem0.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-dg2-6/igt@gem_exec_suspend@basic-s3@lmem0.html
* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a:
- shard-rkl: [SKIP][89] ([i915#1937]) -> [PASS][90]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-rkl-2/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-rkl-7/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a.html
* igt@i915_pm_rpm@dpms-mode-unset-non-lpsp:
- shard-dg2: [SKIP][91] ([i915#1397]) -> [PASS][92] +1 similar issue
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-dg2-12/igt@i915_pm_rpm@dpms-mode-unset-non-lpsp.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-dg2-2/igt@i915_pm_rpm@dpms-mode-unset-non-lpsp.html
* igt@i915_pm_rpm@gem-execbuf-stress@extra-wait-smem0:
- shard-tglu: [FAIL][93] ([i915#7940]) -> [PASS][94] +1 similar issue
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-tglu-6/igt@i915_pm_rpm@gem-execbuf-stress@extra-wait-smem0.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-tglu-3/igt@i915_pm_rpm@gem-execbuf-stress@extra-wait-smem0.html
* igt@i915_pm_rpm@gem-execbuf-stress@smem0:
- {shard-dg1}: [FAIL][95] ([i915#7940]) -> [PASS][96]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-dg1-18/igt@i915_pm_rpm@gem-execbuf-stress@smem0.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-dg1-16/igt@i915_pm_rpm@gem-execbuf-stress@smem0.html
* igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-async-flip:
- shard-mtlp: [FAIL][97] ([i915#3743]) -> [PASS][98]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-mtlp-8/igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-mtlp-1/igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html
* igt@kms_cursor_legacy@cursor-vs-flip-toggle:
- shard-mtlp: [FAIL][99] ([i915#8248]) -> [PASS][100]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-mtlp-2/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-mtlp-2/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-glk: [FAIL][101] ([i915#2346]) -> [PASS][102]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-glk4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-glk6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
- shard-apl: [FAIL][103] ([i915#2346]) -> [PASS][104]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-apl1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-apl6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ab-hdmi-a1-hdmi-a2:
- shard-glk: [FAIL][105] ([i915#79]) -> [PASS][106]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-glk2/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ab-hdmi-a1-hdmi-a2.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-glk9/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ab-hdmi-a1-hdmi-a2.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@c-hdmi-a1:
- shard-glk: [FAIL][107] ([i915#2122]) -> [PASS][108]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-glk3/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-hdmi-a1.html
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-glk1/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-hdmi-a1.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@c-hdmi-a3:
- shard-dg2: [FAIL][109] ([i915#79]) -> [PASS][110]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-dg2-5/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-hdmi-a3.html
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-dg2-8/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-hdmi-a3.html
* igt@perf@non-zero-reason@0-rcs0:
- shard-dg2: [FAIL][111] ([i915#7484]) -> [PASS][112]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-dg2-1/igt@perf@non-zero-reason@0-rcs0.html
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-dg2-7/igt@perf@non-zero-reason@0-rcs0.html
#### Warnings ####
* igt@gem_exec_whisper@basic-contexts-forked-all:
- shard-mtlp: [ABORT][113] ([i915#8131]) -> [TIMEOUT][114] ([i915#8628])
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-mtlp-2/igt@gem_exec_whisper@basic-contexts-forked-all.html
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-mtlp-2/igt@gem_exec_whisper@basic-contexts-forked-all.html
* igt@gem_lmem_swapping@smem-oom@lmem0:
- shard-dg2: [TIMEOUT][115] ([i915#5493]) -> [DMESG-WARN][116] ([i915#4936] / [i915#5493])
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-dg2-1/igt@gem_lmem_swapping@smem-oom@lmem0.html
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-dg2-7/igt@gem_lmem_swapping@smem-oom@lmem0.html
* igt@kms_content_protection@mei_interface:
- shard-dg2: [SKIP][117] ([i915#7118] / [i915#7162]) -> [SKIP][118] ([i915#7118])
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-dg2-11/igt@kms_content_protection@mei_interface.html
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-dg2-5/igt@kms_content_protection@mei_interface.html
* igt@kms_fbcon_fbt@psr:
- shard-rkl: [SKIP][119] ([i915#3955]) -> [SKIP][120] ([fdo#110189] / [i915#3955])
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-rkl-4/igt@kms_fbcon_fbt@psr.html
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-rkl-1/igt@kms_fbcon_fbt@psr.html
* igt@kms_fbcon_fbt@psr-suspend:
- shard-rkl: [SKIP][121] ([fdo#110189] / [i915#3955]) -> [SKIP][122] ([i915#3955])
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-rkl-2/igt@kms_fbcon_fbt@psr-suspend.html
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-rkl-7/igt@kms_fbcon_fbt@psr-suspend.html
* igt@prime_mmap@test_aperture_limit@test_aperture_limit-smem:
- shard-dg2: [INCOMPLETE][123] ([i915#5493]) -> [CRASH][124] ([i915#7331])
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13392/shard-dg2-3/igt@prime_mmap@test_aperture_limit@test_aperture_limit-smem.html
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/shard-dg2-6/igt@prime_mmap@test_aperture_limit@test_aperture_limit-smem.html
### Piglit changes ###
#### Issues hit ####
* igt@i915_pm_rpm@basic-pci-d3-state:
- pig-kbl-iris: NOTRUN -> [FAIL][125] ([i915#5603])
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/pig-kbl-iris/igt@i915_pm_rpm@basic-pci-d3-state.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#111767]: https://bugs.freedesktop.org/show_bug.cgi?id=111767
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4087]: https://gitlab.freedesktop.org/drm/intel/issues/4087
[i915#4235]: https://gitlab.freedesktop.org/drm/intel/issues/4235
[i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391
[i915#4423]: https://gitlab.freedesktop.org/drm/intel/issues/4423
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4817]: https://gitlab.freedesktop.org/drm/intel/issues/4817
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4936]: https://gitlab.freedesktop.org/drm/intel/issues/4936
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5493]: https://gitlab.freedesktop.org/drm/intel/issues/5493
[i915#5603]: https://gitlab.freedesktop.org/drm/intel/issues/5603
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6880]: https://gitlab.freedesktop.org/drm/intel/issues/6880
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7162]: https://gitlab.freedesktop.org/drm/intel/issues/7162
[i915#7173]: https://gitlab.freedesktop.org/drm/intel/issues/7173
[i915#7213]: https://gitlab.freedesktop.org/drm/intel/issues/7213
[i915#7331]: https://gitlab.freedesktop.org/drm/intel/issues/7331
[i915#7484]: https://gitlab.freedesktop.org/drm/intel/issues/7484
[i915#7691]: https://gitlab.freedesktop.org/drm/intel/issues/7691
[i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#7940]: https://gitlab.freedesktop.org/drm/intel/issues/7940
[i915#7975]: https://gitlab.freedesktop.org/drm/intel/issues/7975
[i915#8131]: https://gitlab.freedesktop.org/drm/intel/issues/8131
[i915#8178]: https://gitlab.freedesktop.org/drm/intel/issues/8178
[i915#8213]: https://gitlab.freedesktop.org/drm/intel/issues/8213
[i915#8228]: https://gitlab.freedesktop.org/drm/intel/issues/8228
[i915#8247]: https://gitlab.freedesktop.org/drm/intel/issues/8247
[i915#8248]: https://gitlab.freedesktop.org/drm/intel/issues/8248
[i915#8411]: https://gitlab.freedesktop.org/drm/intel/issues/8411
[i915#8489]: https://gitlab.freedesktop.org/drm/intel/issues/8489
[i915#8628]: https://gitlab.freedesktop.org/drm/intel/issues/8628
[i915#8661]: https://gitlab.freedesktop.org/drm/intel/issues/8661
[i915#8668]: https://gitlab.freedesktop.org/drm/intel/issues/8668
[i915#8717]: https://gitlab.freedesktop.org/drm/intel/issues/8717
[i915#8841]: https://gitlab.freedesktop.org/drm/intel/issues/8841
Build changes
-------------
* Linux: CI_DRM_13392 -> Patchwork_120880v1
CI-20190529: 20190529
CI_DRM_13392: 4903d5c2fbae6ab902d3750aaf6a0264b8391442 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7388: 7388
Patchwork_120880v1: 4903d5c2fbae6ab902d3750aaf6a0264b8391442 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_120880v1/index.html
[-- Attachment #2: Type: text/html, Size: 38466 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH 1/2] drm/i915/perf: Subtract gtt_offset from hw_tail
2023-07-18 2:43 ` [Intel-gfx] [PATCH 1/2] drm/i915/perf: Subtract gtt_offset from hw_tail Ashutosh Dixit
@ 2023-07-18 8:39 ` Lionel Landwerlin
2023-07-18 17:17 ` Dixit, Ashutosh
0 siblings, 1 reply; 7+ messages in thread
From: Lionel Landwerlin @ 2023-07-18 8:39 UTC (permalink / raw)
To: Ashutosh Dixit, intel-gfx
On 18/07/2023 05:43, Ashutosh Dixit wrote:
> The code in oa_buffer_check_unlocked() is correct only if the OA buffer is
> 16 MB aligned (which seems to be the case today in i915). However when the
> 16 MB alignment is dropped, when we "Subtract partial amount off the tail",
> the "& (OA_BUFFER_SIZE - 1)" operation in OA_TAKEN() will result in an
> incorrect hw_tail value.
>
> Therefore hw_tail must be brought to the same base as head and read_tail
> prior to OA_TAKEN by subtracting gtt_offset from hw_tail.
>
> Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
> ---
> drivers/gpu/drm/i915/i915_perf.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c
> index 49c6f1ff11284..f7888a44d1284 100644
> --- a/drivers/gpu/drm/i915/i915_perf.c
> +++ b/drivers/gpu/drm/i915/i915_perf.c
> @@ -565,6 +565,7 @@ static bool oa_buffer_check_unlocked(struct i915_perf_stream *stream)
> partial_report_size %= report_size;
>
> /* Subtract partial amount off the tail */
> + hw_tail -= gtt_offset;
> hw_tail = OA_TAKEN(hw_tail, partial_report_size);
>
> /* NB: The head we observe here might effectively be a little
You should squash this patch with the next one. Otherwise further down
this function there is another
hw_tail -= gtt_offset;
-Lionel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH 1/2] drm/i915/perf: Subtract gtt_offset from hw_tail
2023-07-18 8:39 ` Lionel Landwerlin
@ 2023-07-18 17:17 ` Dixit, Ashutosh
0 siblings, 0 replies; 7+ messages in thread
From: Dixit, Ashutosh @ 2023-07-18 17:17 UTC (permalink / raw)
To: Lionel Landwerlin; +Cc: intel-gfx
On Tue, 18 Jul 2023 01:39:35 -0700, Lionel Landwerlin wrote:
>
Hi Lionel,
> On 18/07/2023 05:43, Ashutosh Dixit wrote:
> > The code in oa_buffer_check_unlocked() is correct only if the OA buffer is
> > 16 MB aligned (which seems to be the case today in i915). However when the
> > 16 MB alignment is dropped, when we "Subtract partial amount off the tail",
> > the "& (OA_BUFFER_SIZE - 1)" operation in OA_TAKEN() will result in an
> > incorrect hw_tail value.
> >
> > Therefore hw_tail must be brought to the same base as head and read_tail
> > prior to OA_TAKEN by subtracting gtt_offset from hw_tail.
> >
> > Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
> > ---
> > drivers/gpu/drm/i915/i915_perf.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c
> > index 49c6f1ff11284..f7888a44d1284 100644
> > --- a/drivers/gpu/drm/i915/i915_perf.c
> > +++ b/drivers/gpu/drm/i915/i915_perf.c
> > @@ -565,6 +565,7 @@ static bool oa_buffer_check_unlocked(struct i915_perf_stream *stream)
> > partial_report_size %= report_size;
> > /* Subtract partial amount off the tail */
> > + hw_tail -= gtt_offset;
> > hw_tail = OA_TAKEN(hw_tail, partial_report_size);
> > /* NB: The head we observe here might effectively be a little
>
>
> You should squash this patch with the next one. Otherwise further down this
> function there is another
>
> hw_tail -= gtt_offset;
Are you looking at old code, because this line is not there in this
function any more. There have been several changes to the function lately,
aging tail etc. is gone e.g.
But otherwise you are right, Patch 2 basically writes over Patch 1, so the
two patches can be squashed. I separated out Patch 1 since it shows the bug
(incidentally the bug doesn't show up in i915 since a 16 MB BO in i915 is
16 MB aligned, I discovered the bug while porting stuff to xe).
So if you are going to R-b this series I can repost after squashing. But if
we wait for Umesh to return (he is out till the end of the month) and
review this, I'd rather leave the two patches as they are till Umesh
reviews them.
Thanks.
--
Ashutosh
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-07-18 17:17 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-18 2:43 [Intel-gfx] [PATCH 0/2] gtt_offset and OA buffer cached head/tail Ashutosh Dixit
2023-07-18 2:43 ` [Intel-gfx] [PATCH 1/2] drm/i915/perf: Subtract gtt_offset from hw_tail Ashutosh Dixit
2023-07-18 8:39 ` Lionel Landwerlin
2023-07-18 17:17 ` Dixit, Ashutosh
2023-07-18 2:43 ` [Intel-gfx] [PATCH 2/2] drm/i915/perf: Remove gtt_offset from stream->oa_buffer.head/.tail Ashutosh Dixit
2023-07-18 3:48 ` [Intel-gfx] ✓ Fi.CI.BAT: success for gtt_offset and OA buffer cached head/tail Patchwork
2023-07-18 5:38 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox