From: Jani Nikula <jani.nikula@intel.com>
To: Andrzej Hajda <andrzej.hajda@intel.com>,
"Piorkowski, Piotr" <piotr.piorkowski@intel.com>,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Subject: Re: [Intel-gfx] [PATCH v3 1/2] drm/i915: Use of BARs names instead of numbers
Date: Wed, 10 Aug 2022 14:31:22 +0300 [thread overview]
Message-ID: <87y1vwtjw5.fsf@intel.com> (raw)
In-Reply-To: <429ca486-6b75-5565-e18a-45a7afa3dd8d@intel.com>
On Wed, 10 Aug 2022, Andrzej Hajda <andrzej.hajda@intel.com> wrote:
> On 05.08.2022 17:59, Piorkowski, Piotr wrote:
>> +/* PCI BARs */
>> +#define GTTMMADR_BAR 0
>> +#define GEN2_GTTMMADR_BAR 1
>> +#define GFXMEM_BAR 2
>> +#define GTT_APERTURE_BAR GFXMEM_BAR
>> +#define GEN12_LMEM_BAR GFXMEM_BAR
>
> In INTEL_GVT_PCI_BAR_GTTMMIO we have BAR in prefix, here in suffix.
> I am not sure which onel is better, just pointing out slight incosistency.
Thought about it too, but decided this one's trivial to change if
needed. The main change is switching to macros.
> Anyway:
> Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
Thanks, though I already pushed this. :)
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
next prev parent reply other threads:[~2022-08-10 11:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-05 15:59 [Intel-gfx] [PATCH v3 0/2] Sanitycheck PCI BARs Piorkowski, Piotr
2022-08-05 15:59 ` [Intel-gfx] [PATCH v3 1/2] drm/i915: Use of BARs names instead of numbers Piorkowski, Piotr
2022-08-10 10:53 ` Andrzej Hajda
2022-08-10 11:31 ` Jani Nikula [this message]
2022-08-05 15:59 ` [Intel-gfx] [PATCH v3 2/2] drm/i915: Sanitycheck PCI BARs Piorkowski, Piotr
2022-08-10 10:39 ` Jani Nikula
2022-08-05 17:18 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for Sanitycheck PCI BARs (rev2) Patchwork
2022-08-05 17:41 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2022-08-08 20:26 ` Matt Roper
2022-08-08 20:34 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-08-08 23:46 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1vwtjw5.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=andrzej.hajda@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
--cc=piotr.piorkowski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox