From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/i915/display: Mark conn as initialised by iterator
Date: Mon, 28 Oct 2019 16:55:37 +0200 [thread overview]
Message-ID: <87y2x46hsm.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <20191028142652.1987-2-chris@chris-wilson.co.uk>
Chris Wilson <chris@chris-wilson.co.uk> writes:
> smatch complains about
> drivers/gpu/drm/i915//display/intel_display.c:14403 intel_set_dp_tp_ctl_normal() error: uninitialized symbol 'conn'.
> because it has no way to determine that the loop must have an entry.
> Tell the static analysers to ignore the local, it will always be set.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_display.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index 0f0c582a56d5..9dce2e9e5376 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -14391,8 +14391,8 @@ static void intel_crtc_enable_trans_port_sync(struct intel_crtc *crtc,
> static void intel_set_dp_tp_ctl_normal(struct intel_crtc *crtc,
> struct intel_atomic_state *state)
> {
> + struct drm_connector *uninitialized_var(conn);
> struct drm_connector_state *conn_state;
> - struct drm_connector *conn;
> struct intel_dp *intel_dp;
> int i;
>
> --
> 2.24.0.rc1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915/display: Mark conn as initialised by iterator
Date: Mon, 28 Oct 2019 16:55:37 +0200 [thread overview]
Message-ID: <87y2x46hsm.fsf@gaia.fi.intel.com> (raw)
Message-ID: <20191028145537.81CZ2k9W6Y9BffAbV8qJ7YVSky6JMTElHEIuNUb2630@z> (raw)
In-Reply-To: <20191028142652.1987-2-chris@chris-wilson.co.uk>
Chris Wilson <chris@chris-wilson.co.uk> writes:
> smatch complains about
> drivers/gpu/drm/i915//display/intel_display.c:14403 intel_set_dp_tp_ctl_normal() error: uninitialized symbol 'conn'.
> because it has no way to determine that the loop must have an entry.
> Tell the static analysers to ignore the local, it will always be set.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_display.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index 0f0c582a56d5..9dce2e9e5376 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -14391,8 +14391,8 @@ static void intel_crtc_enable_trans_port_sync(struct intel_crtc *crtc,
> static void intel_set_dp_tp_ctl_normal(struct intel_crtc *crtc,
> struct intel_atomic_state *state)
> {
> + struct drm_connector *uninitialized_var(conn);
> struct drm_connector_state *conn_state;
> - struct drm_connector *conn;
> struct intel_dp *intel_dp;
> int i;
>
> --
> 2.24.0.rc1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-10-28 14:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-28 14:26 [PATCH 1/2] drm/i915/selftests: Initialise ret Chris Wilson
2019-10-28 14:26 ` [Intel-gfx] " Chris Wilson
2019-10-28 14:26 ` [PATCH 2/2] drm/i915/display: Mark conn as initialised by iterator Chris Wilson
2019-10-28 14:26 ` [Intel-gfx] " Chris Wilson
2019-10-28 14:55 ` Mika Kuoppala [this message]
2019-10-28 14:55 ` Mika Kuoppala
2019-10-28 14:52 ` [PATCH 1/2] drm/i915/selftests: Initialise ret Mika Kuoppala
2019-10-28 14:52 ` [Intel-gfx] " Mika Kuoppala
2019-10-28 17:58 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] " Patchwork
2019-10-28 17:58 ` [Intel-gfx] " Patchwork
2019-10-28 18:20 ` ✓ Fi.CI.BAT: success " Patchwork
2019-10-28 18:20 ` [Intel-gfx] " Patchwork
2019-10-29 13:16 ` ✓ Fi.CI.IGT: " Patchwork
2019-10-29 13:16 ` [Intel-gfx] " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2x46hsm.fsf@gaia.fi.intel.com \
--to=mika.kuoppala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox