Re: [Intel-gfx] [PATCH 2/4] drm/i915/mst: Fix .mode_valid_ctx() return values

[Jani Nikula <jani.nikula@linux.intel.com>]

On Mon, 27 Nov 2023, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> .mode_valid_ctx() returns an errno, not the mode status. Fix
> the code to do the right thing.
>
> Cc: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
> Fixes: d51f25eb479a ("drm/i915: Add DSC support to MST path")
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> ---
>  drivers/gpu/drm/i915/display/intel_dp_mst.c | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp_mst.c b/drivers/gpu/drm/i915/display/intel_dp_mst.c
> index 0514f825baf5..0680a42f7d2a 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp_mst.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp_mst.c
> @@ -1366,11 +1366,15 @@ intel_dp_mst_mode_valid_ctx(struct drm_connector *connector,
>  	 * Big joiner configuration needs DSC for TGL which is not true for
>  	 * XE_LPD where uncompressed joiner is supported.
>  	 */
> -	if (DISPLAY_VER(dev_priv) < 13 && bigjoiner && !dsc)
> -		return MODE_CLOCK_HIGH;
> +	if (DISPLAY_VER(dev_priv) < 13 && bigjoiner && !dsc) {
> +		*status = MODE_CLOCK_HIGH;
> +		return 0;
> +	}
>  
> -	if (mode_rate > max_rate && !dsc)
> -		return MODE_CLOCK_HIGH;
> +	if (mode_rate > max_rate && !dsc) {
> +		*status = MODE_CLOCK_HIGH;
> +		return 0;
> +	}
>  
>  	*status = intel_mode_valid_max_plane_size(dev_priv, mode, false);
>  	return 0;

-- 
Jani Nikula, Intel