Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: "Hogander, Jouni" <jouni.hogander@intel.com>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH] drm/i915/vma: constify unbind_fence_ops
Date: Fri, 25 Aug 2023 09:03:32 +0300	[thread overview]
Message-ID: <87zg2f3bgr.fsf@intel.com> (raw)
In-Reply-To: <b7e8f31cf1dbf6f234e6e8836c4a24aef0f5ad1e.camel@intel.com>

On Wed, 23 Aug 2023, "Hogander, Jouni" <jouni.hogander@intel.com> wrote:
> On Fri, 2023-08-18 at 14:27 +0300, Jani Nikula wrote:
>> unbind_fence_ops can be const and placed in rodata.
>>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Reviewed-by: Jouni Högander <jouni.hogander@intel.com>

Thanks, pushed to din.

BR,
Jani.

>
>> ---
>>  drivers/gpu/drm/i915/i915_vma_resource.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/i915_vma_resource.c
>> b/drivers/gpu/drm/i915/i915_vma_resource.c
>> index 6ba7a7feceba..53d619ef0c3d 100644
>> --- a/drivers/gpu/drm/i915/i915_vma_resource.c
>> +++ b/drivers/gpu/drm/i915/i915_vma_resource.c
>> @@ -94,7 +94,7 @@ static void unbind_fence_release(struct dma_fence
>> *fence)
>>         call_rcu(&fence->rcu, unbind_fence_free_rcu);
>>  }
>>
>> -static struct dma_fence_ops unbind_fence_ops = {
>> +static const struct dma_fence_ops unbind_fence_ops = {
>>         .get_driver_name = get_driver_name,
>>         .get_timeline_name = get_timeline_name,
>>         .release = unbind_fence_release,
>

-- 
Jani Nikula, Intel Open Source Graphics Center

  reply	other threads:[~2023-08-25  6:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-18 11:27 [Intel-gfx] [PATCH] drm/i915/vma: constify unbind_fence_ops Jani Nikula
2023-08-18 13:53 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2023-08-18 13:53 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-08-18 14:13 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2023-08-23 12:27 ` [Intel-gfx] [PATCH] " Hogander, Jouni
2023-08-25  6:03   ` Jani Nikula [this message]
2023-08-24 12:44 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/vma: constify unbind_fence_ops (rev2) Patchwork
2023-08-24 12:58 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-08-24 22:25 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zg2f3bgr.fsf@intel.com \
    --to=jani.nikula@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jouni.hogander@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox