* [Intel-gfx] [PATCH] drm/i915: Make sure dsm_size has correct granularity
@ 2023-01-24 15:00 Nirmoy Das
2023-01-24 23:15 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Nirmoy Das @ 2023-01-24 15:00 UTC (permalink / raw)
To: intel-gfx; +Cc: Lucas De Marchi, Matthew Auld, dri-devel, Nirmoy Das
DSM granularity is 1MB so make sure we stick to that.
Cc: Matthew Auld <matthew.auld@intel.com>
Suggested-by: Lucas De Marchi <lucas.demarchi@intel.com>
Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
---
drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
index 90a967374b1a..0c027263f09e 100644
--- a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
+++ b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c
@@ -909,7 +909,7 @@ i915_gem_stolen_lmem_setup(struct drm_i915_private *i915, u16 type,
dsm_base = intel_uncore_read64(uncore, GEN12_DSMBASE) & GEN12_BDSM_MASK;
if (WARN_ON(lmem_size < dsm_base))
return ERR_PTR(-ENODEV);
- dsm_size = lmem_size - dsm_base;
+ dsm_size = ALIGN_DOWN(lmem_size - dsm_base, 1 * SZ_1M);
}
io_size = dsm_size;
--
2.39.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Make sure dsm_size has correct granularity 2023-01-24 15:00 [Intel-gfx] [PATCH] drm/i915: Make sure dsm_size has correct granularity Nirmoy Das @ 2023-01-24 23:15 ` Patchwork 2023-01-25 3:33 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 2023-01-25 7:47 ` [Intel-gfx] [PATCH] " Andrzej Hajda 2 siblings, 0 replies; 7+ messages in thread From: Patchwork @ 2023-01-24 23:15 UTC (permalink / raw) To: Nirmoy Das; +Cc: intel-gfx [-- Attachment #1: Type: text/plain, Size: 5874 bytes --] == Series Details == Series: drm/i915: Make sure dsm_size has correct granularity URL : https://patchwork.freedesktop.org/series/113282/ State : success == Summary == CI Bug Log - changes from CI_DRM_12630 -> Patchwork_113282v1 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113282v1/index.html Participating hosts (36 -> 39) ------------------------------ Additional (3): fi-bsw-kefka fi-hsw-4770 bat-atsm-1 Known issues ------------ Here are the changes found in Patchwork_113282v1 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@i915_module_load@load: - fi-ctg-p8600: [PASS][1] -> [DMESG-WARN][2] ([i915#6020]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12630/fi-ctg-p8600/igt@i915_module_load@load.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113282v1/fi-ctg-p8600/igt@i915_module_load@load.html * igt@i915_selftest@live@gt_heartbeat: - fi-apl-guc: [PASS][3] -> [DMESG-FAIL][4] ([i915#5334]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12630/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113282v1/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html * igt@i915_suspend@basic-s3-without-i915: - fi-rkl-11600: [PASS][5] -> [INCOMPLETE][6] ([i915#4817]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12630/fi-rkl-11600/igt@i915_suspend@basic-s3-without-i915.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113282v1/fi-rkl-11600/igt@i915_suspend@basic-s3-without-i915.html * igt@kms_chamelium_frames@hdmi-crc-fast: - fi-hsw-4770: NOTRUN -> [SKIP][7] ([fdo#109271]) +20 similar issues [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113282v1/fi-hsw-4770/igt@kms_chamelium_frames@hdmi-crc-fast.html * igt@kms_psr@sprite_plane_onoff: - fi-hsw-4770: NOTRUN -> [SKIP][8] ([fdo#109271] / [i915#1072]) +3 similar issues [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113282v1/fi-hsw-4770/igt@kms_psr@sprite_plane_onoff.html * igt@prime_vgem@basic-fence-flip: - fi-bsw-kefka: NOTRUN -> [SKIP][9] ([fdo#109271]) +26 similar issues [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113282v1/fi-bsw-kefka/igt@prime_vgem@basic-fence-flip.html #### Possible fixes #### * igt@i915_selftest@live@gt_heartbeat: - fi-kbl-soraka: [DMESG-FAIL][10] ([i915#5334] / [i915#7872]) -> [PASS][11] [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12630/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113282v1/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html * igt@i915_selftest@live@requests: - {bat-rpls-1}: [INCOMPLETE][12] ([i915#4983] / [i915#6257]) -> [PASS][13] [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12630/bat-rpls-1/igt@i915_selftest@live@requests.html [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113282v1/bat-rpls-1/igt@i915_selftest@live@requests.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295 [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072 [i915#1836]: https://gitlab.freedesktop.org/drm/intel/issues/1836 [i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582 [i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077 [i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079 [i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083 [i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312 [i915#4817]: https://gitlab.freedesktop.org/drm/intel/issues/4817 [i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983 [i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334 [i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354 [i915#6020]: https://gitlab.freedesktop.org/drm/intel/issues/6020 [i915#6077]: https://gitlab.freedesktop.org/drm/intel/issues/6077 [i915#6078]: https://gitlab.freedesktop.org/drm/intel/issues/6078 [i915#6093]: https://gitlab.freedesktop.org/drm/intel/issues/6093 [i915#6094]: https://gitlab.freedesktop.org/drm/intel/issues/6094 [i915#6166]: https://gitlab.freedesktop.org/drm/intel/issues/6166 [i915#6257]: https://gitlab.freedesktop.org/drm/intel/issues/6257 [i915#6311]: https://gitlab.freedesktop.org/drm/intel/issues/6311 [i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367 [i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621 [i915#6645]: https://gitlab.freedesktop.org/drm/intel/issues/6645 [i915#7357]: https://gitlab.freedesktop.org/drm/intel/issues/7357 [i915#7625]: https://gitlab.freedesktop.org/drm/intel/issues/7625 [i915#7872]: https://gitlab.freedesktop.org/drm/intel/issues/7872 [i915#7931]: https://gitlab.freedesktop.org/drm/intel/issues/7931 Build changes ------------- * Linux: CI_DRM_12630 -> Patchwork_113282v1 CI-20190529: 20190529 CI_DRM_12630: 49bd4c650125827fdfc0bc1d319d10da87aedf95 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_7136: 31b6af91747ad8c705399c9006cdb81cb1864146 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git Patchwork_113282v1: 49bd4c650125827fdfc0bc1d319d10da87aedf95 @ git://anongit.freedesktop.org/gfx-ci/linux ### Linux commits 6dbccd9d4aa0 drm/i915: Make sure dsm_size has correct granularity == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113282v1/index.html [-- Attachment #2: Type: text/html, Size: 5518 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Make sure dsm_size has correct granularity 2023-01-24 15:00 [Intel-gfx] [PATCH] drm/i915: Make sure dsm_size has correct granularity Nirmoy Das 2023-01-24 23:15 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork @ 2023-01-25 3:33 ` Patchwork 2023-01-25 7:47 ` [Intel-gfx] [PATCH] " Andrzej Hajda 2 siblings, 0 replies; 7+ messages in thread From: Patchwork @ 2023-01-25 3:33 UTC (permalink / raw) To: Nirmoy Das; +Cc: intel-gfx [-- Attachment #1: Type: text/plain, Size: 18973 bytes --] == Series Details == Series: drm/i915: Make sure dsm_size has correct granularity URL : https://patchwork.freedesktop.org/series/113282/ State : success == Summary == CI Bug Log - changes from CI_DRM_12630_full -> Patchwork_113282v1_full ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113282v1/index.html Participating hosts (13 -> 11) ------------------------------ Missing (2): pig-skl-6260u pig-kbl-iris Known issues ------------ Here are the changes found in Patchwork_113282v1_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_exec_fair@basic-deadline: - shard-glk: [PASS][1] -> [FAIL][2] ([i915#2846]) [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12630/shard-glk3/igt@gem_exec_fair@basic-deadline.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113282v1/shard-glk8/igt@gem_exec_fair@basic-deadline.html * igt@kms_flip@2x-flip-vs-expired-vblank@ab-hdmi-a1-hdmi-a2: - shard-glk: [PASS][3] -> [FAIL][4] ([i915#2122]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12630/shard-glk3/igt@kms_flip@2x-flip-vs-expired-vblank@ab-hdmi-a1-hdmi-a2.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113282v1/shard-glk8/igt@kms_flip@2x-flip-vs-expired-vblank@ab-hdmi-a1-hdmi-a2.html * igt@perf@stress-open-close: - shard-glk: [PASS][5] -> [INCOMPLETE][6] ([i915#5213]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12630/shard-glk8/igt@perf@stress-open-close.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113282v1/shard-glk4/igt@perf@stress-open-close.html * igt@runner@aborted: - shard-glk: NOTRUN -> [FAIL][7] ([i915#4312]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113282v1/shard-glk4/igt@runner@aborted.html #### Possible fixes #### * igt@api_intel_bb@object-reloc-keep-cache: - {shard-rkl}: [SKIP][8] ([i915#3281]) -> [PASS][9] +11 similar issues [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12630/shard-rkl-4/igt@api_intel_bb@object-reloc-keep-cache.html [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113282v1/shard-rkl-5/igt@api_intel_bb@object-reloc-keep-cache.html * igt@drm_read@empty-nonblock: - {shard-rkl}: [SKIP][10] ([i915#1845] / [i915#4098]) -> [PASS][11] +11 similar issues [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12630/shard-rkl-5/igt@drm_read@empty-nonblock.html [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113282v1/shard-rkl-6/igt@drm_read@empty-nonblock.html * igt@fbdev@read: - {shard-rkl}: [SKIP][12] ([i915#2582]) -> [PASS][13] [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12630/shard-rkl-5/igt@fbdev@read.html [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113282v1/shard-rkl-6/igt@fbdev@read.html * igt@gem_eio@reset-stress: - {shard-dg1}: [FAIL][14] ([i915#5784]) -> [PASS][15] [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12630/shard-dg1-17/igt@gem_eio@reset-stress.html [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113282v1/shard-dg1-16/igt@gem_eio@reset-stress.html * igt@gem_exec_fair@basic-none@vcs0: - {shard-rkl}: [FAIL][16] ([i915#2842]) -> [PASS][17] +2 similar issues [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12630/shard-rkl-2/igt@gem_exec_fair@basic-none@vcs0.html [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113282v1/shard-rkl-5/igt@gem_exec_fair@basic-none@vcs0.html * igt@gem_exec_fair@basic-pace-share@rcs0: - shard-glk: [FAIL][18] ([i915#2842]) -> [PASS][19] +2 similar issues [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12630/shard-glk2/igt@gem_exec_fair@basic-pace-share@rcs0.html [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113282v1/shard-glk6/igt@gem_exec_fair@basic-pace-share@rcs0.html * igt@gem_pread@uncached: - {shard-rkl}: [SKIP][20] ([i915#3282]) -> [PASS][21] +3 similar issues [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12630/shard-rkl-2/igt@gem_pread@uncached.html [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113282v1/shard-rkl-5/igt@gem_pread@uncached.html * igt@gen9_exec_parse@cmd-crossing-page: - {shard-rkl}: [SKIP][22] ([i915#2527]) -> [PASS][23] +1 similar issue [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12630/shard-rkl-2/igt@gen9_exec_parse@cmd-crossing-page.html [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113282v1/shard-rkl-5/igt@gen9_exec_parse@cmd-crossing-page.html * igt@i915_pm_dc@dc6-dpms: - {shard-rkl}: [SKIP][24] ([i915#3361]) -> [PASS][25] [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12630/shard-rkl-5/igt@i915_pm_dc@dc6-dpms.html [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113282v1/shard-rkl-2/igt@i915_pm_dc@dc6-dpms.html * igt@i915_suspend@fence-restore-tiled2untiled: - {shard-rkl}: [FAIL][26] ([fdo#103375]) -> [PASS][27] [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12630/shard-rkl-3/igt@i915_suspend@fence-restore-tiled2untiled.html [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113282v1/shard-rkl-1/igt@i915_suspend@fence-restore-tiled2untiled.html * igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-mmap-wc: - {shard-rkl}: [SKIP][28] ([i915#1849] / [i915#4098]) -> [PASS][29] +5 similar issues [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12630/shard-rkl-5/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-mmap-wc.html [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113282v1/shard-rkl-6/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-mmap-wc.html * igt@kms_properties@plane-properties-atomic: - {shard-rkl}: [SKIP][30] ([i915#1849]) -> [PASS][31] [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12630/shard-rkl-5/igt@kms_properties@plane-properties-atomic.html [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113282v1/shard-rkl-6/igt@kms_properties@plane-properties-atomic.html * igt@kms_psr@suspend: - {shard-rkl}: [SKIP][32] ([i915#1072]) -> [PASS][33] [32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12630/shard-rkl-5/igt@kms_psr@suspend.html [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113282v1/shard-rkl-6/igt@kms_psr@suspend.html * igt@perf@gen12-oa-tlb-invalidate: - {shard-rkl}: [SKIP][34] ([fdo#109289]) -> [PASS][35] +1 similar issue [34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12630/shard-rkl-5/igt@perf@gen12-oa-tlb-invalidate.html [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113282v1/shard-rkl-2/igt@perf@gen12-oa-tlb-invalidate.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375 [fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274 [fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279 [fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280 [fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283 [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285 [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289 [fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291 [fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295 [fdo#109302]: https://bugs.freedesktop.org/show_bug.cgi?id=109302 [fdo#109307]: https://bugs.freedesktop.org/show_bug.cgi?id=109307 [fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309 [fdo#109312]: https://bugs.freedesktop.org/show_bug.cgi?id=109312 [fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315 [fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506 [fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642 [fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189 [fdo#110542]: https://bugs.freedesktop.org/show_bug.cgi?id=110542 [fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723 [fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068 [fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614 [fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615 [fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644 [fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656 [fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054 [fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283 [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072 [i915#1257]: https://gitlab.freedesktop.org/drm/intel/issues/1257 [i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132 [i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397 [i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825 [i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839 [i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845 [i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849 [i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122 [i915#2433]: https://gitlab.freedesktop.org/drm/intel/issues/2433 [i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437 [i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527 [i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575 [i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582 [i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587 [i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658 [i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672 [i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681 [i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705 [i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280 [i915#284]: https://gitlab.freedesktop.org/drm/intel/issues/284 [i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842 [i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846 [i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856 [i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920 [i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116 [i915#315]: https://gitlab.freedesktop.org/drm/intel/issues/315 [i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281 [i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282 [i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291 [i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297 [i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299 [i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301 [i915#3323]: https://gitlab.freedesktop.org/drm/intel/issues/3323 [i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359 [i915#3361]: https://gitlab.freedesktop.org/drm/intel/issues/3361 [i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458 [i915#3528]: https://gitlab.freedesktop.org/drm/intel/issues/3528 [i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539 [i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546 [i915#3547]: https://gitlab.freedesktop.org/drm/intel/issues/3547 [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555 [i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558 [i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637 [i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638 [i915#3639]: https://gitlab.freedesktop.org/drm/intel/issues/3639 [i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689 [i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708 [i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734 [i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742 [i915#3804]: https://gitlab.freedesktop.org/drm/intel/issues/3804 [i915#3810]: https://gitlab.freedesktop.org/drm/intel/issues/3810 [i915#3825]: https://gitlab.freedesktop.org/drm/intel/issues/3825 [i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840 [i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886 [i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955 [i915#3966]: https://gitlab.freedesktop.org/drm/intel/issues/3966 [i915#3989]: https://gitlab.freedesktop.org/drm/intel/issues/3989 [i915#4036]: https://gitlab.freedesktop.org/drm/intel/issues/4036 [i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070 [i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077 [i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078 [i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079 [i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083 [i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098 [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103 [i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212 [i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213 [i915#426]: https://gitlab.freedesktop.org/drm/intel/issues/426 [i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270 [i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312 [i915#433]: https://gitlab.freedesktop.org/drm/intel/issues/433 [i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349 [i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387 [i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525 [i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538 [i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454 [i915#4565]: https://gitlab.freedesktop.org/drm/intel/issues/4565 [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613 [i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767 [i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771 [i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812 [i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833 [i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852 [i915#4859]: https://gitlab.freedesktop.org/drm/intel/issues/4859 [i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860 [i915#4958]: https://gitlab.freedesktop.org/drm/intel/issues/4958 [i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983 [i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176 [i915#5213]: https://gitlab.freedesktop.org/drm/intel/issues/5213 [i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235 [i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286 [i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288 [i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289 [i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325 [i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533 [i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439 [i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461 [i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563 [i915#5723]: https://gitlab.freedesktop.org/drm/intel/issues/5723 [i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784 [i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095 [i915#6227]: https://gitlab.freedesktop.org/drm/intel/issues/6227 [i915#6230]: https://gitlab.freedesktop.org/drm/intel/issues/6230 [i915#6245]: https://gitlab.freedesktop.org/drm/intel/issues/6245 [i915#6247]: https://gitlab.freedesktop.org/drm/intel/issues/6247 [i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248 [i915#6252]: https://gitlab.freedesktop.org/drm/intel/issues/6252 [i915#6258]: https://gitlab.freedesktop.org/drm/intel/issues/6258 [i915#6259]: https://gitlab.freedesktop.org/drm/intel/issues/6259 [i915#6301]: https://gitlab.freedesktop.org/drm/intel/issues/6301 [i915#6334]: https://gitlab.freedesktop.org/drm/intel/issues/6334 [i915#6335]: https://gitlab.freedesktop.org/drm/intel/issues/6335 [i915#6344]: https://gitlab.freedesktop.org/drm/intel/issues/6344 [i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433 [i915#6463]: https://gitlab.freedesktop.org/drm/intel/issues/6463 [i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497 [i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524 [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658 [i915#6590]: https://gitlab.freedesktop.org/drm/intel/issues/6590 [i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621 [i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768 [i915#6944]: https://gitlab.freedesktop.org/drm/intel/issues/6944 [i915#6946]: https://gitlab.freedesktop.org/drm/intel/issues/6946 [i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953 [i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116 [i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118 [i915#7128]: https://gitlab.freedesktop.org/drm/intel/issues/7128 [i915#7178]: https://gitlab.freedesktop.org/drm/intel/issues/7178 [i915#7294]: https://gitlab.freedesktop.org/drm/intel/issues/7294 [i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561 [i915#7651]: https://gitlab.freedesktop.org/drm/intel/issues/7651 [i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697 [i915#7701]: https://gitlab.freedesktop.org/drm/intel/issues/7701 [i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711 [i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742 [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828 [i915#7949]: https://gitlab.freedesktop.org/drm/intel/issues/7949 Build changes ------------- * Linux: CI_DRM_12630 -> Patchwork_113282v1 * Piglit: piglit_4509 -> None CI-20190529: 20190529 CI_DRM_12630: 49bd4c650125827fdfc0bc1d319d10da87aedf95 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_7136: 31b6af91747ad8c705399c9006cdb81cb1864146 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git Patchwork_113282v1: 49bd4c650125827fdfc0bc1d319d10da87aedf95 @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113282v1/index.html [-- Attachment #2: Type: text/html, Size: 10120 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Make sure dsm_size has correct granularity 2023-01-24 15:00 [Intel-gfx] [PATCH] drm/i915: Make sure dsm_size has correct granularity Nirmoy Das 2023-01-24 23:15 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork 2023-01-25 3:33 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork @ 2023-01-25 7:47 ` Andrzej Hajda 2 siblings, 0 replies; 7+ messages in thread From: Andrzej Hajda @ 2023-01-25 7:47 UTC (permalink / raw) To: Nirmoy Das, intel-gfx; +Cc: Lucas De Marchi, Matthew Auld, dri-devel On 24.01.2023 16:00, Nirmoy Das wrote: > DSM granularity is 1MB so make sure we stick to that. > > Cc: Matthew Auld <matthew.auld@intel.com> > Suggested-by: Lucas De Marchi <lucas.demarchi@intel.com> > Signed-off-by: Nirmoy Das <nirmoy.das@intel.com> > --- > drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c > index 90a967374b1a..0c027263f09e 100644 > --- a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c > +++ b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c > @@ -909,7 +909,7 @@ i915_gem_stolen_lmem_setup(struct drm_i915_private *i915, u16 type, > dsm_base = intel_uncore_read64(uncore, GEN12_DSMBASE) & GEN12_BDSM_MASK; > if (WARN_ON(lmem_size < dsm_base)) > return ERR_PTR(-ENODEV); > - dsm_size = lmem_size - dsm_base; > + dsm_size = ALIGN_DOWN(lmem_size - dsm_base, 1 * SZ_1M); 1st seen "1 * SZ_1M", usually it is just SZ_1M, up to you. Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com> Regards Andrzej > } > > io_size = dsm_size; ^ permalink raw reply [flat|nested] 7+ messages in thread
* [Intel-gfx] [PATCH] drm/i915: Make sure dsm_size has correct granularity @ 2023-02-02 18:02 Nirmoy Das 2023-02-03 18:56 ` Lucas De Marchi 0 siblings, 1 reply; 7+ messages in thread From: Nirmoy Das @ 2023-02-02 18:02 UTC (permalink / raw) To: intel-gfx Cc: Andrzej Hajda, Lucas De Marchi, Matthew Auld, dri-devel, Nirmoy Das DSM granularity is 1MB so make sure we stick to that. v2: replace "1 * SZ_1M" with SZ_1M (Andrzej). Cc: Matthew Auld <matthew.auld@intel.com> Suggested-by: Lucas De Marchi <lucas.demarchi@intel.com> Signed-off-by: Nirmoy Das <nirmoy.das@intel.com> Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com> --- drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c index 90a967374b1a..d8e06e783e30 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c @@ -909,7 +909,7 @@ i915_gem_stolen_lmem_setup(struct drm_i915_private *i915, u16 type, dsm_base = intel_uncore_read64(uncore, GEN12_DSMBASE) & GEN12_BDSM_MASK; if (WARN_ON(lmem_size < dsm_base)) return ERR_PTR(-ENODEV); - dsm_size = lmem_size - dsm_base; + dsm_size = ALIGN_DOWN(lmem_size - dsm_base, SZ_1M); } io_size = dsm_size; -- 2.39.0 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Make sure dsm_size has correct granularity 2023-02-02 18:02 Nirmoy Das @ 2023-02-03 18:56 ` Lucas De Marchi 2023-02-03 19:00 ` Das, Nirmoy 0 siblings, 1 reply; 7+ messages in thread From: Lucas De Marchi @ 2023-02-03 18:56 UTC (permalink / raw) To: Nirmoy Das; +Cc: dri-devel, intel-gfx, Matthew Auld, Andrzej Hajda On Thu, Feb 02, 2023 at 07:02:43PM +0100, Nirmoy Das wrote: >DSM granularity is 1MB so make sure we stick to that. I think we need to be a bit more verbose here, because in future we may need to refer to this commit if/when things change (e.g. the granularity or the additional size needed on top of DSM). The issue this is fixing is that the address set by firmware in GEN12_DSMBASE and read here doesn't mean "anything above it until the of lmem is part of DSM". There may be a few KB that is not part of DSM. How large is that space is platform-dependent, but since it's always less than the DSM granularity, it can be simplified by simply aligning the size like is done here. > >v2: replace "1 * SZ_1M" with SZ_1M (Andrzej). > >Cc: Matthew Auld <matthew.auld@intel.com> >Suggested-by: Lucas De Marchi <lucas.demarchi@intel.com> >Signed-off-by: Nirmoy Das <nirmoy.das@intel.com> >Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com> Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com> Are you ok with me amending the commit message and applying? After this patch I think you can follow the process to request committer access. Lucas De Marchi >--- > drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c >index 90a967374b1a..d8e06e783e30 100644 >--- a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c >+++ b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c >@@ -909,7 +909,7 @@ i915_gem_stolen_lmem_setup(struct drm_i915_private *i915, u16 type, > dsm_base = intel_uncore_read64(uncore, GEN12_DSMBASE) & GEN12_BDSM_MASK; > if (WARN_ON(lmem_size < dsm_base)) > return ERR_PTR(-ENODEV); >- dsm_size = lmem_size - dsm_base; >+ dsm_size = ALIGN_DOWN(lmem_size - dsm_base, SZ_1M); > } > > io_size = dsm_size; >-- >2.39.0 > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Make sure dsm_size has correct granularity 2023-02-03 18:56 ` Lucas De Marchi @ 2023-02-03 19:00 ` Das, Nirmoy 0 siblings, 0 replies; 7+ messages in thread From: Das, Nirmoy @ 2023-02-03 19:00 UTC (permalink / raw) To: Lucas De Marchi; +Cc: dri-devel, intel-gfx, Matthew Auld, Andrzej Hajda Hi Lucas, On 2/3/2023 7:56 PM, Lucas De Marchi wrote: > On Thu, Feb 02, 2023 at 07:02:43PM +0100, Nirmoy Das wrote: >> DSM granularity is 1MB so make sure we stick to that. > > I think we need to be a bit more verbose here, because in future we may > need to refer to this commit if/when things change (e.g. the granularity > or the additional size needed on top of DSM). > > The issue this is fixing is that the address set by firmware in > GEN12_DSMBASE > and read here doesn't mean "anything above it until the of lmem is > part of DSM". > There may be a few KB that is not part of DSM. How large is that space > is platform-dependent, but since it's always less than the DSM > granularity, it can be simplified by simply aligning the size like > is done here. > >> >> v2: replace "1 * SZ_1M" with SZ_1M (Andrzej). >> >> Cc: Matthew Auld <matthew.auld@intel.com> >> Suggested-by: Lucas De Marchi <lucas.demarchi@intel.com> >> Signed-off-by: Nirmoy Das <nirmoy.das@intel.com> >> Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com> > > > Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com> > > Are you ok with me amending the commit message and applying? Yes, I fine that, thanks for doing that. I agree this is very short description that I have wrote. > > After this patch I think you can follow the process to request committer > access. Looking for to doing that :) Nirmoy > > Lucas De Marchi > >> --- >> drivers/gpu/drm/i915/gem/i915_gem_stolen.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c >> b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c >> index 90a967374b1a..d8e06e783e30 100644 >> --- a/drivers/gpu/drm/i915/gem/i915_gem_stolen.c >> +++ b/drivers/gpu/drm/i915/gem/i915_gem_stolen.c >> @@ -909,7 +909,7 @@ i915_gem_stolen_lmem_setup(struct >> drm_i915_private *i915, u16 type, >> dsm_base = intel_uncore_read64(uncore, GEN12_DSMBASE) & >> GEN12_BDSM_MASK; >> if (WARN_ON(lmem_size < dsm_base)) >> return ERR_PTR(-ENODEV); >> - dsm_size = lmem_size - dsm_base; >> + dsm_size = ALIGN_DOWN(lmem_size - dsm_base, SZ_1M); >> } >> >> io_size = dsm_size; >> -- >> 2.39.0 >> ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-02-03 19:01 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-01-24 15:00 [Intel-gfx] [PATCH] drm/i915: Make sure dsm_size has correct granularity Nirmoy Das 2023-01-24 23:15 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork 2023-01-25 3:33 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 2023-01-25 7:47 ` [Intel-gfx] [PATCH] " Andrzej Hajda -- strict thread matches above, loose matches on Subject: below -- 2023-02-02 18:02 Nirmoy Das 2023-02-03 18:56 ` Lucas De Marchi 2023-02-03 19:00 ` Das, Nirmoy
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox