Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH v2 0/2] drm/i915: fix rb-tree/llist/list confusion
@ 2023-09-28 18:20 Mathias Krause
  2023-09-28 18:20 ` [Intel-gfx] [PATCH v2 1/2] drm/i915: Register engines early to avoid type confusion Mathias Krause
                   ` (12 more replies)
  0 siblings, 13 replies; 19+ messages in thread
From: Mathias Krause @ 2023-09-28 18:20 UTC (permalink / raw)
  To: intel-gfx; +Cc: Mathias Krause

Commit 1ec23ed7126e ("drm/i915: Use uabi engines for the default engine
map") introduced a bug regarding engine iteration in default_engines()
as the rb tree isn't set up this early during driver initialization.
This triggered a sanity check we have in our grsecurity kernels, fixed
by doing the engine registration earlier (as suggested by Tvrtko) and
giving the type-multiplexed members some more visibility to avoid making
a similar mistake again in the future (patch 2).

Changelog:
v1 -> v2:
- instead of reverting commit 1ec23ed7126e, register engines earlier
  (Tvrtko)

v1: https://lore.kernel.org/intel-gfx/20230905113921.14071-1-minipli@grsecurity.net/

Please apply!

Thanks,
Mathias

Mathias Krause (2):
  drm/i915: Register engines early to avoid type confusion
  drm/i915: Clarify type evolution of uabi_node/uabi_engines

 drivers/gpu/drm/i915/gt/intel_engine_types.h | 10 +++++++++-
 drivers/gpu/drm/i915/gt/intel_engine_user.c  | 17 +++++++----------
 drivers/gpu/drm/i915/i915_drv.h              | 17 ++++++++++++++++-
 drivers/gpu/drm/i915/i915_gem.c              |  9 +++++++--
 4 files changed, 39 insertions(+), 14 deletions(-)

-- 
2.39.2


^ permalink raw reply	[flat|nested] 19+ messages in thread

end of thread, other threads:[~2023-10-04 10:44 UTC | newest]

Thread overview: 19+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-28 18:20 [Intel-gfx] [PATCH v2 0/2] drm/i915: fix rb-tree/llist/list confusion Mathias Krause
2023-09-28 18:20 ` [Intel-gfx] [PATCH v2 1/2] drm/i915: Register engines early to avoid type confusion Mathias Krause
2023-09-29 10:57   ` Tvrtko Ursulin
2023-09-28 18:20 ` [Intel-gfx] [PATCH v2 2/2] drm/i915: Clarify type evolution of uabi_node/uabi_engines Mathias Krause
2023-09-29 11:00   ` Tvrtko Ursulin
2023-10-03  7:32     ` Tvrtko Ursulin
2023-10-04  9:52       ` Mathias Krause
2023-10-04 10:44         ` Tvrtko Ursulin
2023-09-28 19:29 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: fix rb-tree/llist/list confusion (rev2) Patchwork
2023-09-28 19:29 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-09-28 19:48 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2023-09-29  7:55 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: fix rb-tree/llist/list confusion (rev3) Patchwork
2023-09-29  7:55 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-09-29  8:07 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-09-29 12:39 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2023-10-02 19:02 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: fix rb-tree/llist/list confusion (rev4) Patchwork
2023-10-02 19:02 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-10-02 19:12 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-10-02 20:42 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox