From: Jani Nikula <jani.nikula@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: jani.nikula@intel.com, ville.syrjala@linux.intel.com
Subject: [PATCH 04/16] drm/i915: pass dev_priv explicitly to DSPLINOFF
Date: Thu, 23 May 2024 15:59:32 +0300 [thread overview]
Message-ID: <922b6b0795787b335bd3d5b0541bd30dc2c19dd5.1716469091.git.jani.nikula@intel.com> (raw)
In-Reply-To: <cover.1716469091.git.jani.nikula@intel.com>
Avoid the implicit dev_priv local variable use, and pass dev_priv
explicitly to the DSPLINOFF register macro.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/display/i9xx_plane.c | 4 ++--
drivers/gpu/drm/i915/display/i9xx_plane_regs.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/i9xx_plane.c b/drivers/gpu/drm/i915/display/i9xx_plane.c
index 79280fe2662d..ba76c952a656 100644
--- a/drivers/gpu/drm/i915/display/i9xx_plane.c
+++ b/drivers/gpu/drm/i915/display/i9xx_plane.c
@@ -485,7 +485,7 @@ static void i9xx_plane_update_arm(struct intel_plane *plane,
intel_de_write_fw(dev_priv, DSPOFFSET(i9xx_plane),
DISP_OFFSET_Y(y) | DISP_OFFSET_X(x));
} else if (DISPLAY_VER(dev_priv) >= 4) {
- intel_de_write_fw(dev_priv, DSPLINOFF(i9xx_plane),
+ intel_de_write_fw(dev_priv, DSPLINOFF(dev_priv, i9xx_plane),
linear_offset);
intel_de_write_fw(dev_priv, DSPTILEOFF(i9xx_plane),
DISP_OFFSET_Y(y) | DISP_OFFSET_X(x));
@@ -1041,7 +1041,7 @@ i9xx_get_initial_plane_config(struct intel_crtc *crtc,
DSPTILEOFF(i9xx_plane));
else
offset = intel_de_read(dev_priv,
- DSPLINOFF(i9xx_plane));
+ DSPLINOFF(dev_priv, i9xx_plane));
base = intel_de_read(dev_priv, DSPSURF(i9xx_plane)) & DISP_ADDR_MASK;
} else {
offset = 0;
diff --git a/drivers/gpu/drm/i915/display/i9xx_plane_regs.h b/drivers/gpu/drm/i915/display/i9xx_plane_regs.h
index a68d7b228187..e222c0333d19 100644
--- a/drivers/gpu/drm/i915/display/i9xx_plane_regs.h
+++ b/drivers/gpu/drm/i915/display/i9xx_plane_regs.h
@@ -47,7 +47,7 @@
#define DSPADDR(dev_priv, plane) _MMIO_PIPE2(dev_priv, plane, _DSPAADDR)
#define _DSPALINOFF 0x70184 /* i965+ */
-#define DSPLINOFF(plane) _MMIO_PIPE2(dev_priv, plane, _DSPALINOFF)
+#define DSPLINOFF(dev_priv, plane) _MMIO_PIPE2(dev_priv, plane, _DSPALINOFF)
#define _DSPASTRIDE 0x70188
#define DSPSTRIDE(plane) _MMIO_PIPE2(dev_priv, plane, _DSPASTRIDE)
--
2.39.2
next prev parent reply other threads:[~2024-05-23 13:00 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-23 12:59 [PATCH 00/16] drm/i915: dev_priv fixes for i9xx_plane_regs.h/intel_color_regs.h Jani Nikula
2024-05-23 12:59 ` [PATCH 01/16] drm/i915: pass dev_priv explicitly to DSPADDR_VLV Jani Nikula
2024-05-23 12:59 ` [PATCH 02/16] drm/i915: pass dev_priv explicitly to DSPCNTR Jani Nikula
2024-05-23 12:59 ` [PATCH 03/16] drm/i915: pass dev_priv explicitly to DSPADDR Jani Nikula
2024-05-23 12:59 ` Jani Nikula [this message]
2024-05-23 12:59 ` [PATCH 05/16] drm/i915: pass dev_priv explicitly to DSPSTRIDE Jani Nikula
2024-05-23 12:59 ` [PATCH 06/16] drm/i915: pass dev_priv explicitly to DSPPOS Jani Nikula
2024-05-23 12:59 ` [PATCH 07/16] drm/i915: pass dev_priv explicitly to DSPSIZE Jani Nikula
2024-05-23 12:59 ` [PATCH 08/16] drm/i915: pass dev_priv explicitly to DSPSURF Jani Nikula
2024-05-23 12:59 ` [PATCH 09/16] drm/i915: pass dev_priv explicitly to DSPTILEOFF Jani Nikula
2024-05-23 12:59 ` [PATCH 10/16] drm/i915: pass dev_priv explicitly to DSPOFFSET Jani Nikula
2024-05-23 12:59 ` [PATCH 11/16] drm/i915: pass dev_priv explicitly to DSPSURFLIVE Jani Nikula
2024-05-23 12:59 ` [PATCH 12/16] drm/i915: pass dev_priv explicitly to DSPGAMC Jani Nikula
2024-05-23 12:59 ` [PATCH 13/16] drm/i915: pass dev_priv explicitly to PRIMPOS Jani Nikula
2024-05-23 12:59 ` [PATCH 14/16] drm/i915: pass dev_priv explicitly to PRIMSIZE Jani Nikula
2024-05-23 12:59 ` [PATCH 15/16] drm/i915: pass dev_priv explicitly to PRIMCNSTALPHA Jani Nikula
2024-05-23 12:59 ` [PATCH 16/16] drm/i915: pass dev_priv explicitly to PIPEGCMAX Jani Nikula
2024-05-23 13:14 ` Ville Syrjälä
2024-05-23 13:18 ` Jani Nikula
2024-05-24 9:12 ` Jani Nikula
2024-05-23 14:39 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: dev_priv fixes for i9xx_plane_regs.h/intel_color_regs.h Patchwork
2024-05-23 14:39 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-05-23 14:48 ` ✓ Fi.CI.BAT: success " Patchwork
2024-05-24 7:06 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=922b6b0795787b335bd3d5b0541bd30dc2c19dd5.1716469091.git.jani.nikula@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox