Re: [PATCH 0/8] drm/{i915,xe}/panic: refactor framebuffer allocation etc.

[Jani Nikula <jani.nikula@intel.com>]

On Thu, 04 Sep 2025, Jocelyn Falempe <jfalempe@redhat.com> wrote:
> On 02/09/2025 19:51, Jani Nikula wrote:
>> Split out intel_panic functionality separate from intel_bo abstraction,
>> and lift the framebuffer allocation back to where it belongs in
>> intel_fb.c.
>> 
>> There's more that should be improved, ideally making struct
>> intel_framebuffer opaque towards i915 and xe, but this already goes
>> along way in adjusting where the abstractions should happen.
>
> Thanks for this series, this makes sense, and moving the panic part to 
> intel_panic.c is a good idea.
>
> I think this may conflict with 
> https://patchwork.freedesktop.org/series/150887/ but that should be 
> trivial to resolve.

Thanks for the review. It seems to me that's much easier to rebase than
this series, and moves further away from the goals here, so I've opted
to push this one.

BR,
Jani.

> For the whole series:
> Reviewed-by: Jocelyn Falempe <jfalempe@redhat.com>
>
> Best regards,

-- 
Jani Nikula, Intel