* [Intel-gfx] [PATCH] drm/i915/perf: remove redundant variable 'taken'
@ 2022-10-07 19:53 Colin Ian King
2022-10-07 21:27 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Colin Ian King @ 2022-10-07 19:53 UTC (permalink / raw)
To: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, Tvrtko Ursulin,
David Airlie, Daniel Vetter, intel-gfx, dri-devel
Cc: kernel-janitors, linux-kernel
The assignment to variable taken is redundant and so it can be
removed as well as the variable too.
Cleans up clang-scan build warnings:
warning: Although the value stored to 'taken' is used in the enclosing
expression, the value is never actually read from 'taken'
[deadcode.DeadStores]
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/gpu/drm/i915/i915_perf.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c
index 0defbb43ceea..15816df916c7 100644
--- a/drivers/gpu/drm/i915/i915_perf.c
+++ b/drivers/gpu/drm/i915/i915_perf.c
@@ -656,7 +656,6 @@ static int gen8_append_oa_reports(struct i915_perf_stream *stream,
size_t start_offset = *offset;
unsigned long flags;
u32 head, tail;
- u32 taken;
int ret = 0;
if (drm_WARN_ON(&uncore->i915->drm, !stream->enabled))
@@ -692,7 +691,7 @@ static int gen8_append_oa_reports(struct i915_perf_stream *stream,
for (/* none */;
- (taken = OA_TAKEN(tail, head));
+ OA_TAKEN(tail, head);
head = (head + report_size) & mask) {
u8 *report = oa_buf_base + head;
u32 *report32 = (void *)report;
@@ -950,7 +949,6 @@ static int gen7_append_oa_reports(struct i915_perf_stream *stream,
size_t start_offset = *offset;
unsigned long flags;
u32 head, tail;
- u32 taken;
int ret = 0;
if (drm_WARN_ON(&uncore->i915->drm, !stream->enabled))
@@ -984,7 +982,7 @@ static int gen7_append_oa_reports(struct i915_perf_stream *stream,
for (/* none */;
- (taken = OA_TAKEN(tail, head));
+ OA_TAKEN(tail, head);
head = (head + report_size) & mask) {
u8 *report = oa_buf_base + head;
u32 *report32 = (void *)report;
--
2.37.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/perf: remove redundant variable 'taken'
2022-10-07 19:53 [Intel-gfx] [PATCH] drm/i915/perf: remove redundant variable 'taken' Colin Ian King
@ 2022-10-07 21:27 ` Patchwork
2022-10-08 3:23 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-10-08 11:55 ` [Intel-gfx] [PATCH] " Christophe JAILLET
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2022-10-07 21:27 UTC (permalink / raw)
To: Colin Ian King; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 6851 bytes --]
== Series Details ==
Series: drm/i915/perf: remove redundant variable 'taken'
URL : https://patchwork.freedesktop.org/series/109491/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12226 -> Patchwork_109491v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109491v1/index.html
Participating hosts (44 -> 42)
------------------------------
Additional (2): fi-hsw-4770 bat-atsm-1
Missing (4): fi-ctg-p8600 fi-bxt-dsi fi-tgl-dsi fi-hsw-4200u
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_109491v1:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@i915_selftest@live@reset:
- {bat-rpls-2}: [PASS][1] -> [DMESG-WARN][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/bat-rpls-2/igt@i915_selftest@live@reset.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109491v1/bat-rpls-2/igt@i915_selftest@live@reset.html
Known issues
------------
Here are the changes found in Patchwork_109491v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_softpin@allocator-basic-reserve:
- fi-hsw-4770: NOTRUN -> [SKIP][3] ([fdo#109271]) +9 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109491v1/fi-hsw-4770/igt@gem_softpin@allocator-basic-reserve.html
* igt@i915_pm_backlight@basic-brightness:
- fi-hsw-4770: NOTRUN -> [SKIP][4] ([fdo#109271] / [i915#3012])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109491v1/fi-hsw-4770/igt@i915_pm_backlight@basic-brightness.html
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-hsw-g3258: NOTRUN -> [SKIP][5] ([fdo#109271] / [fdo#111827])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109491v1/fi-hsw-g3258/igt@kms_chamelium@common-hpd-after-suspend.html
- fi-bdw-5557u: NOTRUN -> [SKIP][6] ([fdo#109271] / [fdo#111827])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109491v1/fi-bdw-5557u/igt@kms_chamelium@common-hpd-after-suspend.html
* igt@kms_chamelium@dp-crc-fast:
- fi-hsw-4770: NOTRUN -> [SKIP][7] ([fdo#109271] / [fdo#111827]) +8 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109491v1/fi-hsw-4770/igt@kms_chamelium@dp-crc-fast.html
* igt@kms_psr@sprite_plane_onoff:
- fi-hsw-4770: NOTRUN -> [SKIP][8] ([fdo#109271] / [i915#1072]) +3 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109491v1/fi-hsw-4770/igt@kms_psr@sprite_plane_onoff.html
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s3@lmem0:
- {bat-dg2-11}: [DMESG-WARN][9] ([i915#6816]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/bat-dg2-11/igt@gem_exec_suspend@basic-s3@lmem0.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109491v1/bat-dg2-11/igt@gem_exec_suspend@basic-s3@lmem0.html
* igt@i915_selftest@live@gt_timelines:
- fi-hsw-g3258: [INCOMPLETE][11] -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/fi-hsw-g3258/igt@i915_selftest@live@gt_timelines.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109491v1/fi-hsw-g3258/igt@i915_selftest@live@gt_timelines.html
* igt@i915_selftest@live@guc:
- {bat-rpls-2}: [DMESG-WARN][13] ([i915#6471]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/bat-rpls-2/igt@i915_selftest@live@guc.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109491v1/bat-rpls-2/igt@i915_selftest@live@guc.html
* igt@i915_selftest@live@hangcheck:
- {fi-ehl-2}: [INCOMPLETE][15] ([i915#5153]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/fi-ehl-2/igt@i915_selftest@live@hangcheck.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109491v1/fi-ehl-2/igt@i915_selftest@live@hangcheck.html
* igt@i915_selftest@live@slpc:
- {bat-adln-1}: [DMESG-FAIL][17] ([i915#6997]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/bat-adln-1/igt@i915_selftest@live@slpc.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109491v1/bat-adln-1/igt@i915_selftest@live@slpc.html
* igt@i915_suspend@basic-s3-without-i915:
- fi-bdw-5557u: [INCOMPLETE][19] ([i915#146] / [i915#6712]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/fi-bdw-5557u/igt@i915_suspend@basic-s3-without-i915.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109491v1/fi-bdw-5557u/igt@i915_suspend@basic-s3-without-i915.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#146]: https://gitlab.freedesktop.org/drm/intel/issues/146
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#5153]: https://gitlab.freedesktop.org/drm/intel/issues/5153
[i915#5537]: https://gitlab.freedesktop.org/drm/intel/issues/5537
[i915#6434]: https://gitlab.freedesktop.org/drm/intel/issues/6434
[i915#6471]: https://gitlab.freedesktop.org/drm/intel/issues/6471
[i915#6712]: https://gitlab.freedesktop.org/drm/intel/issues/6712
[i915#6816]: https://gitlab.freedesktop.org/drm/intel/issues/6816
[i915#6997]: https://gitlab.freedesktop.org/drm/intel/issues/6997
[i915#7030]: https://gitlab.freedesktop.org/drm/intel/issues/7030
Build changes
-------------
* Linux: CI_DRM_12226 -> Patchwork_109491v1
CI-20190529: 20190529
CI_DRM_12226: bcc9e3eb1e7ba32651eae68b842df07db01e63be @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7003: 1ea9ec5e7295fbc1cb784be4692971fd342bea53 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_109491v1: bcc9e3eb1e7ba32651eae68b842df07db01e63be @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
af765a1f1b24 drm/i915/perf: remove redundant variable 'taken'
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109491v1/index.html
[-- Attachment #2: Type: text/html, Size: 7710 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/perf: remove redundant variable 'taken'
2022-10-07 19:53 [Intel-gfx] [PATCH] drm/i915/perf: remove redundant variable 'taken' Colin Ian King
2022-10-07 21:27 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
@ 2022-10-08 3:23 ` Patchwork
2022-10-08 11:55 ` [Intel-gfx] [PATCH] " Christophe JAILLET
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2022-10-08 3:23 UTC (permalink / raw)
To: Colin Ian King; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 32102 bytes --]
== Series Details ==
Series: drm/i915/perf: remove redundant variable 'taken'
URL : https://patchwork.freedesktop.org/series/109491/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12226_full -> Patchwork_109491v1_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_109491v1_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_109491v1_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Participating hosts (9 -> 12)
------------------------------
Additional (3): shard-rkl shard-dg1 shard-tglu
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_109491v1_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_mmap_gtt@hang:
- shard-snb: [PASS][1] -> [DMESG-WARN][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/shard-snb4/igt@gem_mmap_gtt@hang.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109491v1/shard-snb7/igt@gem_mmap_gtt@hang.html
* igt@kms_sequence@queue-busy@edp-1-pipe-a:
- shard-skl: [PASS][3] -> [FAIL][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/shard-skl1/igt@kms_sequence@queue-busy@edp-1-pipe-a.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109491v1/shard-skl10/igt@kms_sequence@queue-busy@edp-1-pipe-a.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@gem_eio@suspend:
- {shard-rkl}: NOTRUN -> [FAIL][5]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109491v1/shard-rkl-4/igt@gem_eio@suspend.html
Known issues
------------
Here are the changes found in Patchwork_109491v1_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_persistence@engines-mixed:
- shard-snb: NOTRUN -> [SKIP][6] ([fdo#109271] / [i915#1099])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109491v1/shard-snb4/igt@gem_ctx_persistence@engines-mixed.html
* igt@gem_exec_fair@basic-flow@rcs0:
- shard-tglb: [PASS][7] -> [FAIL][8] ([i915#2842])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/shard-tglb2/igt@gem_exec_fair@basic-flow@rcs0.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109491v1/shard-tglb7/igt@gem_exec_fair@basic-flow@rcs0.html
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-apl: [PASS][9] -> [SKIP][10] ([fdo#109271])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/shard-apl1/igt@gem_exec_fair@basic-none-share@rcs0.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109491v1/shard-apl2/igt@gem_exec_fair@basic-none-share@rcs0.html
* igt@gem_exec_fair@basic-none@vcs0:
- shard-glk: [PASS][11] -> [FAIL][12] ([i915#2842])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/shard-glk9/igt@gem_exec_fair@basic-none@vcs0.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109491v1/shard-glk1/igt@gem_exec_fair@basic-none@vcs0.html
* igt@gem_softpin@evict-single-offset:
- shard-tglb: [PASS][13] -> [FAIL][14] ([i915#4171])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/shard-tglb3/igt@gem_softpin@evict-single-offset.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109491v1/shard-tglb7/igt@gem_softpin@evict-single-offset.html
* igt@gem_workarounds@suspend-resume:
- shard-apl: [PASS][15] -> [DMESG-WARN][16] ([i915#180]) +3 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/shard-apl1/igt@gem_workarounds@suspend-resume.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109491v1/shard-apl8/igt@gem_workarounds@suspend-resume.html
* igt@i915_pm_dc@dc9-dpms:
- shard-iclb: [PASS][17] -> [SKIP][18] ([i915#4281])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/shard-iclb1/igt@i915_pm_dc@dc9-dpms.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109491v1/shard-iclb3/igt@i915_pm_dc@dc9-dpms.html
* igt@i915_selftest@live@gt_heartbeat:
- shard-skl: [PASS][19] -> [DMESG-FAIL][20] ([i915#5334])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/shard-skl4/igt@i915_selftest@live@gt_heartbeat.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109491v1/shard-skl6/igt@i915_selftest@live@gt_heartbeat.html
* igt@kms_async_flips@alternate-sync-async-flip@pipe-b-edp-1:
- shard-skl: [PASS][21] -> [FAIL][22] ([i915#2521])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/shard-skl10/igt@kms_async_flips@alternate-sync-async-flip@pipe-b-edp-1.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109491v1/shard-skl4/igt@kms_async_flips@alternate-sync-async-flip@pipe-b-edp-1.html
* igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180-async-flip:
- shard-skl: NOTRUN -> [SKIP][23] ([fdo#109271]) +3 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109491v1/shard-skl7/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180-async-flip.html
* igt@kms_chamelium@dp-crc-multiple:
- shard-snb: NOTRUN -> [SKIP][24] ([fdo#109271] / [fdo#111827])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109491v1/shard-snb4/igt@kms_chamelium@dp-crc-multiple.html
* igt@kms_chamelium@vga-edid-read:
- shard-skl: NOTRUN -> [SKIP][25] ([fdo#109271] / [fdo#111827])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109491v1/shard-skl7/igt@kms_chamelium@vga-edid-read.html
* igt@kms_color@ctm-0-75@pipe-b-vga-1:
- shard-snb: NOTRUN -> [SKIP][26] ([fdo#109271]) +17 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109491v1/shard-snb4/igt@kms_color@ctm-0-75@pipe-b-vga-1.html
* igt@kms_cursor_legacy@flip-vs-cursor@varying-size:
- shard-skl: [PASS][27] -> [FAIL][28] ([i915#2346])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/shard-skl1/igt@kms_cursor_legacy@flip-vs-cursor@varying-size.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109491v1/shard-skl7/igt@kms_cursor_legacy@flip-vs-cursor@varying-size.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1:
- shard-skl: [PASS][29] -> [FAIL][30] ([i915#79])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/shard-skl9/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109491v1/shard-skl6/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
* igt@kms_flip@plain-flip-ts-check@c-edp1:
- shard-skl: [PASS][31] -> [FAIL][32] ([i915#2122]) +1 similar issue
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/shard-skl1/igt@kms_flip@plain-flip-ts-check@c-edp1.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109491v1/shard-skl10/igt@kms_flip@plain-flip-ts-check@c-edp1.html
* igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-16bpp-4tile-downscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][33] ([i915#2587] / [i915#2672]) +1 similar issue
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109491v1/shard-iclb6/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-16bpp-4tile-downscaling@pipe-a-valid-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-xtile-to-16bpp-xtile-downscaling@pipe-a-default-mode:
- shard-iclb: [PASS][34] -> [SKIP][35] ([i915#3555])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/shard-iclb3/igt@kms_flip_scaled_crc@flip-64bpp-xtile-to-16bpp-xtile-downscaling@pipe-a-default-mode.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109491v1/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-xtile-to-16bpp-xtile-downscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-32bpp-yftile-upscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][36] ([i915#2672]) +4 similar issues
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109491v1/shard-iclb3/igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-32bpp-yftile-upscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs-downscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][37] ([i915#2672] / [i915#3555])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109491v1/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs-downscaling@pipe-a-default-mode.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-mmap-wc:
- shard-skl: [PASS][38] -> [DMESG-WARN][39] ([i915#1982])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/shard-skl4/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-mmap-wc.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109491v1/shard-skl6/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@psr-suspend:
- shard-skl: [PASS][40] -> [INCOMPLETE][41] ([i915#4939])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/shard-skl7/igt@kms_frontbuffer_tracking@psr-suspend.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109491v1/shard-skl7/igt@kms_frontbuffer_tracking@psr-suspend.html
* igt@kms_plane_scaling@planes-downscale-factor-0-5@pipe-a-edp-1:
- shard-iclb: [PASS][42] -> [SKIP][43] ([i915#5235]) +2 similar issues
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/shard-iclb8/igt@kms_plane_scaling@planes-downscale-factor-0-5@pipe-a-edp-1.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109491v1/shard-iclb2/igt@kms_plane_scaling@planes-downscale-factor-0-5@pipe-a-edp-1.html
* igt@kms_psr@psr2_primary_mmap_gtt:
- shard-iclb: [PASS][44] -> [SKIP][45] ([fdo#109441]) +1 similar issue
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/shard-iclb2/igt@kms_psr@psr2_primary_mmap_gtt.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109491v1/shard-iclb5/igt@kms_psr@psr2_primary_mmap_gtt.html
#### Possible fixes ####
* igt@gem_exec_balancer@parallel-keep-submit-fence:
- shard-iclb: [SKIP][46] ([i915#4525]) -> [PASS][47] +3 similar issues
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/shard-iclb5/igt@gem_exec_balancer@parallel-keep-submit-fence.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109491v1/shard-iclb1/igt@gem_exec_balancer@parallel-keep-submit-fence.html
* igt@gem_exec_schedule@pi-ringfull@rcs0:
- shard-skl: [FAIL][48] -> [PASS][49]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/shard-skl9/igt@gem_exec_schedule@pi-ringfull@rcs0.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109491v1/shard-skl1/igt@gem_exec_schedule@pi-ringfull@rcs0.html
* igt@i915_pm_rps@engine-order:
- shard-apl: [FAIL][50] ([i915#6537]) -> [PASS][51]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/shard-apl6/igt@i915_pm_rps@engine-order.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109491v1/shard-apl6/igt@i915_pm_rps@engine-order.html
* igt@i915_selftest@live@hangcheck:
- shard-snb: [INCOMPLETE][52] ([i915#6992]) -> [PASS][53]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/shard-snb6/igt@i915_selftest@live@hangcheck.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109491v1/shard-snb4/igt@i915_selftest@live@hangcheck.html
* igt@kms_async_flips@alternate-sync-async-flip@pipe-c-edp-1:
- shard-skl: [FAIL][54] ([i915#2521]) -> [PASS][55]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/shard-skl10/igt@kms_async_flips@alternate-sync-async-flip@pipe-c-edp-1.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109491v1/shard-skl4/igt@kms_async_flips@alternate-sync-async-flip@pipe-c-edp-1.html
* igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size:
- shard-glk: [FAIL][56] ([i915#2346]) -> [PASS][57]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/shard-glk7/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109491v1/shard-glk9/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size.html
* igt@kms_cursor_legacy@flip-vs-cursor@legacy:
- shard-skl: [FAIL][58] ([i915#2346]) -> [PASS][59]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/shard-skl1/igt@kms_cursor_legacy@flip-vs-cursor@legacy.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109491v1/shard-skl7/igt@kms_cursor_legacy@flip-vs-cursor@legacy.html
* igt@kms_fbcon_fbt@psr-suspend:
- shard-skl: [FAIL][60] ([i915#4767]) -> [PASS][61]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/shard-skl7/igt@kms_fbcon_fbt@psr-suspend.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109491v1/shard-skl1/igt@kms_fbcon_fbt@psr-suspend.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a2:
- shard-glk: [FAIL][62] ([i915#79]) -> [PASS][63]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/shard-glk3/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a2.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109491v1/shard-glk7/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a2.html
* igt@kms_flip@plain-flip-fb-recreate@c-edp1:
- shard-skl: [FAIL][64] ([i915#2122]) -> [PASS][65]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/shard-skl7/igt@kms_flip@plain-flip-fb-recreate@c-edp1.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109491v1/shard-skl1/igt@kms_flip@plain-flip-fb-recreate@c-edp1.html
* igt@kms_flip_scaled_crc@flip-32bpp-xtile-to-64bpp-xtile-downscaling@pipe-a-default-mode:
- shard-iclb: [SKIP][66] ([i915#3555]) -> [PASS][67]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-xtile-to-64bpp-xtile-downscaling@pipe-a-default-mode.html
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109491v1/shard-iclb3/igt@kms_flip_scaled_crc@flip-32bpp-xtile-to-64bpp-xtile-downscaling@pipe-a-default-mode.html
* igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-a-edp-1:
- shard-iclb: [SKIP][68] ([i915#5235]) -> [PASS][69] +2 similar issues
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/shard-iclb2/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-a-edp-1.html
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109491v1/shard-iclb8/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-a-edp-1.html
* igt@kms_psr@psr2_primary_render:
- shard-iclb: [SKIP][70] ([fdo#109441]) -> [PASS][71] +1 similar issue
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/shard-iclb3/igt@kms_psr@psr2_primary_render.html
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109491v1/shard-iclb2/igt@kms_psr@psr2_primary_render.html
* igt@perf@polling-parameterized:
- shard-skl: [FAIL][72] ([i915#5639]) -> [PASS][73]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/shard-skl10/igt@perf@polling-parameterized.html
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109491v1/shard-skl4/igt@perf@polling-parameterized.html
* igt@vgem_basic@dmabuf-fence:
- shard-skl: [DMESG-WARN][74] ([i915#1982]) -> [PASS][75]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/shard-skl1/igt@vgem_basic@dmabuf-fence.html
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109491v1/shard-skl10/igt@vgem_basic@dmabuf-fence.html
#### Warnings ####
* igt@kms_psr2_sf@cursor-plane-update-sf:
- shard-iclb: [SKIP][76] ([i915#2920]) -> [SKIP][77] ([fdo#111068] / [i915#658])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/shard-iclb2/igt@kms_psr2_sf@cursor-plane-update-sf.html
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109491v1/shard-iclb3/igt@kms_psr2_sf@cursor-plane-update-sf.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area:
- shard-iclb: [SKIP][78] ([fdo#111068] / [i915#658]) -> [SKIP][79] ([i915#2920])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/shard-iclb5/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area.html
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109491v1/shard-iclb2/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-big-fb:
- shard-iclb: [SKIP][80] ([i915#2920]) -> [SKIP][81] ([i915#658])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/shard-iclb2/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-big-fb.html
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109491v1/shard-iclb3/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-big-fb.html
* igt@runner@aborted:
- shard-apl: ([FAIL][82], [FAIL][83]) ([i915#3002] / [i915#4312]) -> ([FAIL][84], [FAIL][85], [FAIL][86], [FAIL][87], [FAIL][88], [FAIL][89]) ([fdo#109271] / [i915#180] / [i915#3002] / [i915#4312])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/shard-apl2/igt@runner@aborted.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12226/shard-apl6/igt@runner@aborted.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109491v1/shard-apl3/igt@runner@aborted.html
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109491v1/shard-apl8/igt@runner@aborted.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109491v1/shard-apl3/igt@runner@aborted.html
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109491v1/shard-apl2/igt@runner@aborted.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109491v1/shard-apl2/igt@runner@aborted.html
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109491v1/shard-apl1/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
[fdo#109302]: https://bugs.freedesktop.org/show_bug.cgi?id=109302
[fdo#109307]: https://bugs.freedesktop.org/show_bug.cgi?id=109307
[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[fdo#109312]: https://bugs.freedesktop.org/show_bug.cgi?id=109312
[fdo#109314]: https://bugs.freedesktop.org/show_bug.cgi?id=109314
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110254]: https://bugs.freedesktop.org/show_bug.cgi?id=110254
[fdo#110542]: https://bugs.freedesktop.org/show_bug.cgi?id=110542
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644
[fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1063]: https://gitlab.freedesktop.org/drm/intel/issues/1063
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#1257]: https://gitlab.freedesktop.org/drm/intel/issues/1257
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1722]: https://gitlab.freedesktop.org/drm/intel/issues/1722
[i915#1755]: https://gitlab.freedesktop.org/drm/intel/issues/1755
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1850]: https://gitlab.freedesktop.org/drm/intel/issues/1850
[i915#1902]: https://gitlab.freedesktop.org/drm/intel/issues/1902
[i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2232]: https://gitlab.freedesktop.org/drm/intel/issues/2232
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2410]: https://gitlab.freedesktop.org/drm/intel/issues/2410
[i915#2433]: https://gitlab.freedesktop.org/drm/intel/issues/2433
[i915#2434]: https://gitlab.freedesktop.org/drm/intel/issues/2434
[i915#2435]: https://gitlab.freedesktop.org/drm/intel/issues/2435
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#284]: https://gitlab.freedesktop.org/drm/intel/issues/284
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2876]: https://gitlab.freedesktop.org/drm/intel/issues/2876
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#315]: https://gitlab.freedesktop.org/drm/intel/issues/315
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3361]: https://gitlab.freedesktop.org/drm/intel/issues/3361
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
[i915#3528]: https://gitlab.freedesktop.org/drm/intel/issues/3528
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3825]: https://gitlab.freedesktop.org/drm/intel/issues/3825
[i915#3826]: https://gitlab.freedesktop.org/drm/intel/issues/3826
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3952]: https://gitlab.freedesktop.org/drm/intel/issues/3952
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#3989]: https://gitlab.freedesktop.org/drm/intel/issues/3989
[i915#4036]: https://gitlab.freedesktop.org/drm/intel/issues/4036
[i915#404]: https://gitlab.freedesktop.org/drm/intel/issues/404
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4171]: https://gitlab.freedesktop.org/drm/intel/issues/4171
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
[i915#426]: https://gitlab.freedesktop.org/drm/intel/issues/426
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#433]: https://gitlab.freedesktop.org/drm/intel/issues/433
[i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387
[i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4565]: https://gitlab.freedesktop.org/drm/intel/issues/4565
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
[i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4818]: https://gitlab.freedesktop.org/drm/intel/issues/4818
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4854]: https://gitlab.freedesktop.org/drm/intel/issues/4854
[i915#4855]: https://gitlab.freedesktop.org/drm/intel/issues/4855
[i915#4859]: https://gitlab.freedesktop.org/drm/intel/issues/4859
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873
[i915#4874]: https://gitlab.freedesktop.org/drm/intel/issues/4874
[i915#4879]: https://gitlab.freedesktop.org/drm/intel/issues/4879
[i915#4880]: https://gitlab.freedesktop.org/drm/intel/issues/4880
[i915#4881]: https://gitlab.freedesktop.org/drm/intel/issues/4881
[i915#4883]: https://gitlab.freedesktop.org/drm/intel/issues/4883
[i915#4884]: https://gitlab.freedesktop.org/drm/intel/issues/4884
[i915#4939]: https://gitlab.freedesktop.org/drm/intel/issues/4939
[i915#4958]: https://gitlab.freedesktop.org/drm/intel/issues/4958
[i915#4991]: https://gitlab.freedesktop.org/drm/intel/issues/4991
[i915#5122]: https://gitlab.freedesktop.org/drm/intel/issues/5122
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5182]: https://gitlab.freedesktop.org/drm/intel/issues/5182
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
[i915#5639]: https://gitlab.freedesktop.org/drm/intel/issues/5639
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6227]: https://gitlab.freedesktop.org/drm/intel/issues/6227
[i915#6230]: https://gitlab.freedesktop.org/drm/intel/issues/6230
[i915#6245]: https://gitlab.freedesktop.org/drm/intel/issues/6245
[i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
[i915#6251]: https://gitlab.freedesktop.org/drm/intel/issues/6251
[i915#6301]: https://gitlab.freedesktop.org/drm/intel/issues/6301
[i915#6335]: https://gitlab.freedesktop.org/drm/intel/issues/6335
[i915#6355]: https://gitlab.freedesktop.org/drm/intel/issues/6355
[i915#6412]: https://gitlab.freedesktop.org/drm/intel/issues/6412
[i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
[i915#6458]: https://gitlab.freedesktop.org/drm/intel/issues/6458
[i915#6463]: https://gitlab.freedesktop.org/drm/intel/issues/6463
[i915#6493]: https://gitlab.freedesktop.org/drm/intel/issues/6493
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#6537]: https://gitlab.freedesktop.org/drm/intel/issues/6537
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6590]: https://gitlab.freedesktop.org/drm/intel/issues/6590
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6946]: https://gitlab.freedesktop.org/drm/intel/issues/6946
[i915#6987]: https://gitlab.freedesktop.org/drm/intel/issues/6987
[i915#6992]: https://gitlab.freedesktop.org/drm/intel/issues/6992
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
Build changes
-------------
* Linux: CI_DRM_12226 -> Patchwork_109491v1
CI-20190529: 20190529
CI_DRM_12226: bcc9e3eb1e7ba32651eae68b842df07db01e63be @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7003: 1ea9ec5e7295fbc1cb784be4692971fd342bea53 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_109491v1: bcc9e3eb1e7ba32651eae68b842df07db01e63be @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109491v1/index.html
[-- Attachment #2: Type: text/html, Size: 25232 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/perf: remove redundant variable 'taken'
2022-10-07 19:53 [Intel-gfx] [PATCH] drm/i915/perf: remove redundant variable 'taken' Colin Ian King
2022-10-07 21:27 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2022-10-08 3:23 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
@ 2022-10-08 11:55 ` Christophe JAILLET
2022-10-10 8:14 ` Tvrtko Ursulin
2 siblings, 1 reply; 5+ messages in thread
From: Christophe JAILLET @ 2022-10-08 11:55 UTC (permalink / raw)
To: Colin Ian King, Jani Nikula, Joonas Lahtinen, Rodrigo Vivi,
Tvrtko Ursulin, David Airlie, Daniel Vetter, intel-gfx, dri-devel
Cc: kernel-janitors, linux-kernel
Le 07/10/2022 à 21:53, Colin Ian King a écrit :
> The assignment to variable taken is redundant and so it can be
> removed as well as the variable too.
>
> Cleans up clang-scan build warnings:
> warning: Although the value stored to 'taken' is used in the enclosing
> expression, the value is never actually read from 'taken'
> [deadcode.DeadStores]
Hi,
#define OA_TAKEN(tail, head) ((tail - head) & (OA_BUFFER_SIZE - 1))
So if the result is not used, maybe calling OA_TAKEN() can be removed as
well?
It looks like a no-op in such a case.
CJ
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
> drivers/gpu/drm/i915/i915_perf.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c
> index 0defbb43ceea..15816df916c7 100644
> --- a/drivers/gpu/drm/i915/i915_perf.c
> +++ b/drivers/gpu/drm/i915/i915_perf.c
> @@ -656,7 +656,6 @@ static int gen8_append_oa_reports(struct i915_perf_stream *stream,
> size_t start_offset = *offset;
> unsigned long flags;
> u32 head, tail;
> - u32 taken;
> int ret = 0;
>
> if (drm_WARN_ON(&uncore->i915->drm, !stream->enabled))
> @@ -692,7 +691,7 @@ static int gen8_append_oa_reports(struct i915_perf_stream *stream,
>
>
> for (/* none */;
> - (taken = OA_TAKEN(tail, head));
> + OA_TAKEN(tail, head);
> head = (head + report_size) & mask) {
> u8 *report = oa_buf_base + head;
> u32 *report32 = (void *)report;
> @@ -950,7 +949,6 @@ static int gen7_append_oa_reports(struct i915_perf_stream *stream,
> size_t start_offset = *offset;
> unsigned long flags;
> u32 head, tail;
> - u32 taken;
> int ret = 0;
>
> if (drm_WARN_ON(&uncore->i915->drm, !stream->enabled))
> @@ -984,7 +982,7 @@ static int gen7_append_oa_reports(struct i915_perf_stream *stream,
>
>
> for (/* none */;
> - (taken = OA_TAKEN(tail, head));
> + OA_TAKEN(tail, head);
> head = (head + report_size) & mask) {
> u8 *report = oa_buf_base + head;
> u32 *report32 = (void *)report;
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/perf: remove redundant variable 'taken'
2022-10-08 11:55 ` [Intel-gfx] [PATCH] " Christophe JAILLET
@ 2022-10-10 8:14 ` Tvrtko Ursulin
0 siblings, 0 replies; 5+ messages in thread
From: Tvrtko Ursulin @ 2022-10-10 8:14 UTC (permalink / raw)
To: Christophe JAILLET, Colin Ian King, Jani Nikula, Joonas Lahtinen,
Rodrigo Vivi, David Airlie, Daniel Vetter, intel-gfx, dri-devel
Cc: kernel-janitors, linux-kernel
On 08/10/2022 12:55, Christophe JAILLET wrote:
> Le 07/10/2022 à 21:53, Colin Ian King a écrit :
>> The assignment to variable taken is redundant and so it can be
>> removed as well as the variable too.
>>
>> Cleans up clang-scan build warnings:
>> warning: Although the value stored to 'taken' is used in the enclosing
>> expression, the value is never actually read from 'taken'
>> [deadcode.DeadStores]
>
> Hi,
>
> #define OA_TAKEN(tail, head) ((tail - head) & (OA_BUFFER_SIZE - 1))
>
> So if the result is not used, maybe calling OA_TAKEN() can be removed as
> well?
> It looks like a no-op in such a case.
AFAICS result is used, just the copy/local variable is not.
For the patch:
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Thanks for the cleanup, will merge.
Regards,
Tvrtko
>
> CJ
>
>>
>> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
>> ---
>> drivers/gpu/drm/i915/i915_perf.c | 6 ++----
>> 1 file changed, 2 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/i915_perf.c
>> b/drivers/gpu/drm/i915/i915_perf.c
>> index 0defbb43ceea..15816df916c7 100644
>> --- a/drivers/gpu/drm/i915/i915_perf.c
>> +++ b/drivers/gpu/drm/i915/i915_perf.c
>> @@ -656,7 +656,6 @@ static int gen8_append_oa_reports(struct
>> i915_perf_stream *stream,
>> size_t start_offset = *offset;
>> unsigned long flags;
>> u32 head, tail;
>> - u32 taken;
>> int ret = 0;
>> if (drm_WARN_ON(&uncore->i915->drm, !stream->enabled))
>> @@ -692,7 +691,7 @@ static int gen8_append_oa_reports(struct
>> i915_perf_stream *stream,
>> for (/* none */;
>> - (taken = OA_TAKEN(tail, head));
>> + OA_TAKEN(tail, head);
>> head = (head + report_size) & mask) {
>> u8 *report = oa_buf_base + head;
>> u32 *report32 = (void *)report;
>> @@ -950,7 +949,6 @@ static int gen7_append_oa_reports(struct
>> i915_perf_stream *stream,
>> size_t start_offset = *offset;
>> unsigned long flags;
>> u32 head, tail;
>> - u32 taken;
>> int ret = 0;
>> if (drm_WARN_ON(&uncore->i915->drm, !stream->enabled))
>> @@ -984,7 +982,7 @@ static int gen7_append_oa_reports(struct
>> i915_perf_stream *stream,
>> for (/* none */;
>> - (taken = OA_TAKEN(tail, head));
>> + OA_TAKEN(tail, head);
>> head = (head + report_size) & mask) {
>> u8 *report = oa_buf_base + head;
>> u32 *report32 = (void *)report;
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-10-10 8:14 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-07 19:53 [Intel-gfx] [PATCH] drm/i915/perf: remove redundant variable 'taken' Colin Ian King
2022-10-07 21:27 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2022-10-08 3:23 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-10-08 11:55 ` [Intel-gfx] [PATCH] " Christophe JAILLET
2022-10-10 8:14 ` Tvrtko Ursulin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox