Re: [PATCH v3 01/11] drm/i915/dsb: feature flag added for display state buffer.

["Sharma, Shashank" <shashank.sharma@intel.com>]

Hello Animesh

On 8/28/2019 12:40 AM, Animesh Manna wrote:
>  From gen12 onwards Display State Buffer(DSB) is hardware capability
> added which allows driver to batch submit display HW programming.

Let's rephrase this line a bit, how about:

DSB is a new hardware capability, introduced in GEN12 display.

It allows a driver to batch-program display HW registers.

> Feature flag has_dsb added to identify the driver/platform support
> at runtime.
>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: Animesh Manna <animesh.manna@intel.com>
> ---
>   drivers/gpu/drm/i915/i915_drv.h          | 2 ++
>   drivers/gpu/drm/i915/intel_device_info.h | 1 +
>   2 files changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index b42651a387d9..d32cfdb78b74 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -1856,6 +1856,8 @@ static inline struct drm_i915_private *pdev_to_i915(struct pci_dev *pdev)
>   	(BUILD_BUG_ON_ZERO(!__builtin_constant_p(n)) + \
>   	 INTEL_INFO(dev_priv)->gen == (n))
>   
> +#define HAS_DSB(dev_priv)	(INTEL_INFO(dev_priv)->display.has_dsb)
> +
>   /*
>    * Return true if revision is in range [since,until] inclusive.
>    *
> diff --git a/drivers/gpu/drm/i915/intel_device_info.h b/drivers/gpu/drm/i915/intel_device_info.h
> index 92e0c2e0954c..e206f298f48e 100644
> --- a/drivers/gpu/drm/i915/intel_device_info.h
> +++ b/drivers/gpu/drm/i915/intel_device_info.h
> @@ -135,6 +135,7 @@ enum intel_ppgtt_type {
>   	func(has_csr); \
>   	func(has_ddi); \
>   	func(has_dp_mst); \
> +	func(has_dsb); \
>   	func(has_fbc); \
>   	func(has_gmch); \
>   	func(has_hotplug); \
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx