public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/gt: Convert the leftover for_each_engine(gt)
Date: Fri, 18 Oct 2019 13:11:27 +0100	[thread overview]
Message-ID: <98b7484a-8712-8816-d23f-1e2ea4753263@linux.intel.com> (raw)
In-Reply-To: <20191018114925.30779-1-chris@chris-wilson.co.uk>


On 18/10/2019 12:49, Chris Wilson wrote:
> Use the local gt for iterating over the available set of engines.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> ---
>   drivers/gpu/drm/i915/gt/intel_rc6.c        | 12 ++++++------
>   drivers/gpu/drm/i915/gt/intel_ringbuffer.c |  6 +++---
>   2 files changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gt/intel_rc6.c b/drivers/gpu/drm/i915/gt/intel_rc6.c
> index 71184aa72896..70f0e01a38b9 100644
> --- a/drivers/gpu/drm/i915/gt/intel_rc6.c
> +++ b/drivers/gpu/drm/i915/gt/intel_rc6.c
> @@ -65,7 +65,7 @@ static void gen11_rc6_enable(struct intel_rc6 *rc6)
>   
>   	set(uncore, GEN6_RC_EVALUATION_INTERVAL, 125000); /* 12500 * 1280ns */
>   	set(uncore, GEN6_RC_IDLE_HYSTERSIS, 25); /* 25 * 1280ns */
> -	for_each_engine(engine, rc6_to_gt(rc6)->i915, id)
> +	for_each_engine(engine, rc6_to_gt(rc6), id)
>   		set(uncore, RING_MAX_IDLE(engine->mmio_base), 10);
>   
>   	set(uncore, GUC_MAX_IDLE_COUNT, 0xA);
> @@ -133,7 +133,7 @@ static void gen9_rc6_enable(struct intel_rc6 *rc6)
>   
>   	set(uncore, GEN6_RC_EVALUATION_INTERVAL, 125000); /* 12500 * 1280ns */
>   	set(uncore, GEN6_RC_IDLE_HYSTERSIS, 25); /* 25 * 1280ns */
> -	for_each_engine(engine, rc6_to_gt(rc6)->i915, id)
> +	for_each_engine(engine, rc6_to_gt(rc6), id)
>   		set(uncore, RING_MAX_IDLE(engine->mmio_base), 10);
>   
>   	set(uncore, GUC_MAX_IDLE_COUNT, 0xA);
> @@ -192,7 +192,7 @@ static void gen8_rc6_enable(struct intel_rc6 *rc6)
>   	set(uncore, GEN6_RC6_WAKE_RATE_LIMIT, 40 << 16);
>   	set(uncore, GEN6_RC_EVALUATION_INTERVAL, 125000); /* 12500 * 1280ns */
>   	set(uncore, GEN6_RC_IDLE_HYSTERSIS, 25); /* 25 * 1280ns */
> -	for_each_engine(engine, rc6_to_gt(rc6)->i915, id)
> +	for_each_engine(engine, rc6_to_gt(rc6), id)
>   		set(uncore, RING_MAX_IDLE(engine->mmio_base), 10);
>   	set(uncore, GEN6_RC_SLEEP, 0);
>   	set(uncore, GEN6_RC6_THRESHOLD, 625); /* 800us/1.28 for TO */
> @@ -219,7 +219,7 @@ static void gen6_rc6_enable(struct intel_rc6 *rc6)
>   	set(uncore, GEN6_RC_EVALUATION_INTERVAL, 125000);
>   	set(uncore, GEN6_RC_IDLE_HYSTERSIS, 25);
>   
> -	for_each_engine(engine, i915, id)
> +	for_each_engine(engine, rc6_to_gt(rc6), id)
>   		set(uncore, RING_MAX_IDLE(engine->mmio_base), 10);
>   
>   	set(uncore, GEN6_RC_SLEEP, 0);
> @@ -344,7 +344,7 @@ static void chv_rc6_enable(struct intel_rc6 *rc6)
>   	set(uncore, GEN6_RC_EVALUATION_INTERVAL, 125000); /* 12500 * 1280ns */
>   	set(uncore, GEN6_RC_IDLE_HYSTERSIS, 25); /* 25 * 1280ns */
>   
> -	for_each_engine(engine, rc6_to_gt(rc6)->i915, id)
> +	for_each_engine(engine, rc6_to_gt(rc6), id)
>   		set(uncore, RING_MAX_IDLE(engine->mmio_base), 10);
>   	set(uncore, GEN6_RC_SLEEP, 0);
>   
> @@ -371,7 +371,7 @@ static void vlv_rc6_enable(struct intel_rc6 *rc6)
>   	set(uncore, GEN6_RC_EVALUATION_INTERVAL, 125000);
>   	set(uncore, GEN6_RC_IDLE_HYSTERSIS, 25);
>   
> -	for_each_engine(engine, rc6_to_gt(rc6)->i915, id)
> +	for_each_engine(engine, rc6_to_gt(rc6), id)
>   		set(uncore, RING_MAX_IDLE(engine->mmio_base), 10);
>   
>   	set(uncore, GEN6_RC6_THRESHOLD, 0x557);
> diff --git a/drivers/gpu/drm/i915/gt/intel_ringbuffer.c b/drivers/gpu/drm/i915/gt/intel_ringbuffer.c
> index 311fdc0a21bc..bf631f15aa78 100644
> --- a/drivers/gpu/drm/i915/gt/intel_ringbuffer.c
> +++ b/drivers/gpu/drm/i915/gt/intel_ringbuffer.c
> @@ -1609,7 +1609,7 @@ static inline int mi_set_context(struct i915_request *rq, u32 flags)
>   			struct intel_engine_cs *signaller;
>   
>   			*cs++ = MI_LOAD_REGISTER_IMM(num_engines);
> -			for_each_engine(signaller, i915, id) {
> +			for_each_engine(signaller, engine->gt, id) {
>   				if (signaller == engine)
>   					continue;
>   
> @@ -1663,7 +1663,7 @@ static inline int mi_set_context(struct i915_request *rq, u32 flags)
>   			i915_reg_t last_reg = {}; /* keep gcc quiet */
>   
>   			*cs++ = MI_LOAD_REGISTER_IMM(num_engines);
> -			for_each_engine(signaller, i915, id) {
> +			for_each_engine(signaller, engine->gt, id) {
>   				if (signaller == engine)
>   					continue;
>   
> @@ -1676,7 +1676,7 @@ static inline int mi_set_context(struct i915_request *rq, u32 flags)
>   			/* Insert a delay before the next switch! */
>   			*cs++ = MI_STORE_REGISTER_MEM | MI_SRM_LRM_GLOBAL_GTT;
>   			*cs++ = i915_mmio_reg_offset(last_reg);
> -			*cs++ = intel_gt_scratch_offset(rq->engine->gt,
> +			*cs++ = intel_gt_scratch_offset(engine->gt,
>   							INTEL_GT_SCRATCH_FIELD_DEFAULT);
>   			*cs++ = MI_NOOP;
>   		}
> 

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2019-10-18 12:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-18 11:49 [PATCH] drm/i915/gt: Convert the leftover for_each_engine(gt) Chris Wilson
2019-10-18 11:53 ` Chris Wilson
2019-10-18 12:13   ` Tvrtko Ursulin
2019-10-18 12:11 ` Tvrtko Ursulin [this message]
2019-10-18 14:04 ` ✗ Fi.CI.BAT: failure for drm/i915/gt: Convert the leftover for_each_engine(gt) (rev2) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=98b7484a-8712-8816-d23f-1e2ea4753263@linux.intel.com \
    --to=tvrtko.ursulin@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox