From: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
To: Matthew Auld <matthew.auld@intel.com>, Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH v2 0/9] Prereqs for TTM accelerated migration
Date: Wed, 9 Jun 2021 16:35:57 +0200 [thread overview]
Message-ID: <99ff0d9f-9bd4-c27d-45a5-a66d2ad9064f@linux.intel.com> (raw)
In-Reply-To: <1cd6b04d-8928-14b3-a63d-c9ac2e81fcca@linux.intel.com>
On 6/9/21 3:08 PM, Thomas Hellström wrote:
>
> On 6/9/21 2:20 PM, Matthew Auld wrote:
>> On 09/06/2021 13:16, Thomas Hellström wrote:
>>>
>>> On 6/9/21 1:48 PM, Daniel Vetter wrote:
>>>> On Wed, Jun 09, 2021 at 08:34:27AM +0200, Thomas Hellström wrote:
>>>>> A couple of patches from Chris which implement pipelined migration
>>>>> and
>>>>> clears by atomically writing the PTEs in place before performing the
>>>>> actual blit.
>>>>>
>>>>> Some ww utilities mainly for the accompanying selftests added by
>>>>> Thomas,
>>>>> as well as modified the above patches for ww locking- and lmem
>>>>> support.
>>>>>
>>>>> The actual hook up to the i915 ttm backend is being worked on and not
>>>>> included yet, so this is considered to be an early review
>>>>> opportunity.
>>>>>
>>>>> v2:
>>>>> - A couple of minor style fixes pointed out by Matthew Auld
>>>>> - Export and use intel_engine_destroy_pinned_context() to address a
>>>>> ls CI warning / failure.
>>>> Just to check my understanding of the plan: These are the new windowed
>>>> clear/blt functions which we plan to use everywhere, because less
>>>> nasty
>>>> locking implications? And the clear/blt we currently have in
>>>> upstream will
>>>> be replaced?
>>>
>>> Yes. These are for LMEM clearing and migration. It looks to me like
>>> the other ones we have in upstream are actually unused except for
>>> selftests. We're actually using CPU clearing for now.
>>>
>>>>
>>>> If so would be nice if this patch set includes that replacement
>>>> work (I
>>>> think right now all we have is the clear for lmem), including
>>>> updating of
>>>> selftests and stuff like that. Just to avoid having two ways to do the
>>>> same thing in the driver.
>>>
>>> OK, I'll have a look at stripping the existing code. If we need it
>>> moving forward, we can always re-add.
>>
>> Some low hanging fruit would be all the client_blt stuff which can
>> for sure be deleted now.
>
> What has the client_blt stuff been used for?
>
> In any case, I need 25 commits for commit access to be granted.
>
> /Thomas
>
>
Series on trybot now. It's the dg1 live memory_region selftest that
changes sligthly to use the new migration fill blt.
/Thomas
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-06-09 14:36 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-09 6:34 [Intel-gfx] [PATCH v2 0/9] Prereqs for TTM accelerated migration Thomas Hellström
2021-06-09 6:34 ` [Intel-gfx] [PATCH v2 1/9] drm/i915: Reference objects on the ww object list Thomas Hellström
2021-06-09 6:34 ` [Intel-gfx] [PATCH v2 2/9] drm/i915: Break out dma_resv ww locking utilities to separate files Thomas Hellström
2021-06-09 6:34 ` [Intel-gfx] [PATCH v2 3/9] drm/i915: Introduce a ww transaction helper Thomas Hellström
2021-06-09 6:34 ` [Intel-gfx] [PATCH v2 4/9] drm/i915/gt: Add an insert_entry for gen8_ppgtt Thomas Hellström
2021-06-09 7:44 ` Matthew Auld
2021-06-09 6:34 ` [Intel-gfx] [PATCH v2 5/9] drm/i915/gt: Add a routine to iterate over the pagetables of a GTT Thomas Hellström
2021-06-09 7:48 ` Matthew Auld
2021-06-09 6:34 ` [Intel-gfx] [PATCH v2 6/9] drm/i915/gt: Export the pinned context constructor and destructor Thomas Hellström
2021-06-09 8:00 ` Matthew Auld
2021-06-09 6:34 ` [Intel-gfx] [PATCH v2 7/9] drm/i915/gt: Pipelined page migration Thomas Hellström
2021-06-09 12:14 ` Matthew Auld
2021-06-09 12:48 ` Matthew Auld
2021-06-09 6:34 ` [Intel-gfx] [PATCH v2 8/9] drm/i915/gt: Pipelined clear Thomas Hellström
2021-06-09 13:42 ` Matthew Auld
2021-06-09 6:34 ` [Intel-gfx] [PATCH v2 9/9] drm/i915/gt: Setup a default migration context on the GT Thomas Hellström
2021-06-09 14:17 ` Matthew Auld
2021-06-09 7:54 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Prereqs for TTM accelerated migration (rev2) Patchwork
2021-06-09 8:23 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-06-09 8:23 ` [Intel-gfx] ✗ Fi.CI.BUILD: warning " Patchwork
2021-06-09 9:56 ` [Intel-gfx] ✓ Fi.CI.IGT: success " Patchwork
2021-06-09 11:48 ` [Intel-gfx] [PATCH v2 0/9] Prereqs for TTM accelerated migration Daniel Vetter
2021-06-09 12:16 ` Thomas Hellström
2021-06-09 12:20 ` Matthew Auld
2021-06-09 13:08 ` Thomas Hellström
2021-06-09 14:35 ` Thomas Hellström [this message]
2021-06-09 14:54 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99ff0d9f-9bd4-c27d-45a5-a66d2ad9064f@linux.intel.com \
--to=thomas.hellstrom@linux.intel.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.auld@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox