* [Intel-gfx] [PATCH] drm/i915/dsb: modified to drm_info in dsb_prepare()
@ 2022-03-24 7:43 Animesh Manna
2022-03-24 8:49 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
` (4 more replies)
0 siblings, 5 replies; 12+ messages in thread
From: Animesh Manna @ 2022-03-24 7:43 UTC (permalink / raw)
To: intel-gfx
The request to aqquire gem resources is failing for DSB in rare
scenario where it is busy and the register programming will be done
through mmio fallback path.
DSB has extra advantage of faster register programming which may
go away through mmio path. Adding wait for gem resource also may
not be right as anyways losing time.
To make the CI execution happy replaced drm_dbg_kms() to drm_info()
for printing debuf info during dsb buffer preparation.
Signed-off-by: Animesh Manna <animesh.manna@intel.com>
---
drivers/gpu/drm/i915/display/intel_dsb.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dsb.c b/drivers/gpu/drm/i915/display/intel_dsb.c
index b34a67309976..b68dd7bd5271 100644
--- a/drivers/gpu/drm/i915/display/intel_dsb.c
+++ b/drivers/gpu/drm/i915/display/intel_dsb.c
@@ -275,7 +275,7 @@ void intel_dsb_prepare(struct intel_crtc_state *crtc_state)
dsb = kmalloc(sizeof(*dsb), GFP_KERNEL);
if (!dsb) {
- drm_err(&i915->drm, "DSB object creation failed\n");
+ drm_info(&i915->drm, "DSB object creation failed\n");
return;
}
@@ -283,14 +283,14 @@ void intel_dsb_prepare(struct intel_crtc_state *crtc_state)
obj = i915_gem_object_create_internal(i915, DSB_BUF_SIZE);
if (IS_ERR(obj)) {
- drm_err(&i915->drm, "Gem object creation failed\n");
+ drm_info(&i915->drm, "Gem object creation failed\n");
kfree(dsb);
goto out;
}
vma = i915_gem_object_ggtt_pin(obj, NULL, 0, 0, 0);
if (IS_ERR(vma)) {
- drm_err(&i915->drm, "Vma creation failed\n");
+ drm_info(&i915->drm, "Vma creation failed\n");
i915_gem_object_put(obj);
kfree(dsb);
goto out;
@@ -298,7 +298,7 @@ void intel_dsb_prepare(struct intel_crtc_state *crtc_state)
buf = i915_gem_object_pin_map_unlocked(vma->obj, I915_MAP_WC);
if (IS_ERR(buf)) {
- drm_err(&i915->drm, "Command buffer creation failed\n");
+ drm_info(&i915->drm, "Command buffer creation failed\n");
i915_vma_unpin_and_release(&vma, I915_VMA_RELEASE_MAP);
kfree(dsb);
goto out;
--
2.29.0
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dsb: modified to drm_info in dsb_prepare()
2022-03-24 7:43 [Intel-gfx] [PATCH] drm/i915/dsb: modified to drm_info in dsb_prepare() Animesh Manna
@ 2022-03-24 8:49 ` Patchwork
2022-03-24 8:53 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork
` (3 subsequent siblings)
4 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2022-03-24 8:49 UTC (permalink / raw)
To: Animesh Manna; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/dsb: modified to drm_info in dsb_prepare()
URL : https://patchwork.freedesktop.org/series/101723/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
d7c0e5b3bf10 drm/i915/dsb: modified to drm_info in dsb_prepare()
-:28: WARNING:OOM_MESSAGE: Possible unnecessary 'out of memory' message
#28: FILE: drivers/gpu/drm/i915/display/intel_dsb.c:278:
if (!dsb) {
+ drm_info(&i915->drm, "DSB object creation failed\n");
total: 0 errors, 1 warnings, 0 checks, 32 lines checked
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/dsb: modified to drm_info in dsb_prepare()
2022-03-24 7:43 [Intel-gfx] [PATCH] drm/i915/dsb: modified to drm_info in dsb_prepare() Animesh Manna
2022-03-24 8:49 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
@ 2022-03-24 8:53 ` Patchwork
2022-03-24 9:08 ` [Intel-gfx] [PATCH] " Das, Nirmoy
` (2 subsequent siblings)
4 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2022-03-24 8:53 UTC (permalink / raw)
To: Animesh Manna; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/dsb: modified to drm_info in dsb_prepare()
URL : https://patchwork.freedesktop.org/series/101723/
State : warning
== Summary ==
$ make htmldocs 2>&1 > /dev/null | grep i915
./drivers/gpu/drm/i915/display/intel_drrs.c:1: warning: 'intel_drrs_enable' not found
./drivers/gpu/drm/i915/display/intel_drrs.c:1: warning: 'intel_drrs_disable' not found
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/dsb: modified to drm_info in dsb_prepare()
2022-03-24 7:43 [Intel-gfx] [PATCH] drm/i915/dsb: modified to drm_info in dsb_prepare() Animesh Manna
2022-03-24 8:49 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2022-03-24 8:53 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork
@ 2022-03-24 9:08 ` Das, Nirmoy
2022-03-25 13:22 ` Manna, Animesh
2022-03-24 9:21 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2022-03-24 11:47 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
4 siblings, 1 reply; 12+ messages in thread
From: Das, Nirmoy @ 2022-03-24 9:08 UTC (permalink / raw)
To: Animesh Manna, intel-gfx
On 3/24/2022 8:43 AM, Animesh Manna wrote:
> The request to aqquire gem resources is failing for DSB in rare
> scenario where it is busy and the register programming will be done
> through mmio fallback path.
>
> DSB has extra advantage of faster register programming which may
> go away through mmio path. Adding wait for gem resource also may
> not be right as anyways losing time.
>
> To make the CI execution happy replaced drm_dbg_kms() to drm_info()
> for printing debuf info during dsb buffer preparation.
>
> Signed-off-by: Animesh Manna <animesh.manna@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dsb.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dsb.c b/drivers/gpu/drm/i915/display/intel_dsb.c
> index b34a67309976..b68dd7bd5271 100644
> --- a/drivers/gpu/drm/i915/display/intel_dsb.c
> +++ b/drivers/gpu/drm/i915/display/intel_dsb.c
> @@ -275,7 +275,7 @@ void intel_dsb_prepare(struct intel_crtc_state *crtc_state)
>
> dsb = kmalloc(sizeof(*dsb), GFP_KERNEL);
> if (!dsb) {
> - drm_err(&i915->drm, "DSB object creation failed\n");
> + drm_info(&i915->drm, "DSB object creation failed\n");
> return;
> }
>
> @@ -283,14 +283,14 @@ void intel_dsb_prepare(struct intel_crtc_state *crtc_state)
>
> obj = i915_gem_object_create_internal(i915, DSB_BUF_SIZE);
> if (IS_ERR(obj)) {
> - drm_err(&i915->drm, "Gem object creation failed\n");
> + drm_info(&i915->drm, "Gem object creation failed\n");
If CI is happy with drm_warn then it makes sense to use drm_warn.
> kfree(dsb);
> goto out;
> }
>
> vma = i915_gem_object_ggtt_pin(obj, NULL, 0, 0, 0);
> if (IS_ERR(vma)) {
> - drm_err(&i915->drm, "Vma creation failed\n");
> + drm_info(&i915->drm, "Vma creation failed\n");
These messages are bit vague, add "DSB VMA creation failed" or something
similar.
With that Acked-by: Nirmoy Das <nirmoy.das@intel.com>
Nirmoy
> i915_gem_object_put(obj);
> kfree(dsb);
> goto out;
> @@ -298,7 +298,7 @@ void intel_dsb_prepare(struct intel_crtc_state *crtc_state)
>
> buf = i915_gem_object_pin_map_unlocked(vma->obj, I915_MAP_WC);
> if (IS_ERR(buf)) {
> - drm_err(&i915->drm, "Command buffer creation failed\n");
> + drm_info(&i915->drm, "Command buffer creation failed\n");
> i915_vma_unpin_and_release(&vma, I915_VMA_RELEASE_MAP);
> kfree(dsb);
> goto out;
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dsb: modified to drm_info in dsb_prepare()
2022-03-24 7:43 [Intel-gfx] [PATCH] drm/i915/dsb: modified to drm_info in dsb_prepare() Animesh Manna
` (2 preceding siblings ...)
2022-03-24 9:08 ` [Intel-gfx] [PATCH] " Das, Nirmoy
@ 2022-03-24 9:21 ` Patchwork
2022-03-24 11:47 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
4 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2022-03-24 9:21 UTC (permalink / raw)
To: Animesh Manna; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 9634 bytes --]
== Series Details ==
Series: drm/i915/dsb: modified to drm_info in dsb_prepare()
URL : https://patchwork.freedesktop.org/series/101723/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11398 -> Patchwork_22668
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/index.html
Participating hosts (46 -> 45)
------------------------------
Additional (6): bat-adls-5 bat-dg2-8 bat-dg2-9 fi-kbl-8809g bat-rpls-1 bat-jsl-1
Missing (7): shard-tglu fi-hsw-4200u fi-bsw-cyan fi-ctg-p8600 shard-rkl shard-dg1 fi-bdw-samus
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_22668:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@i915_selftest@live@migrate:
- {bat-rpls-2}: NOTRUN -> [INCOMPLETE][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/bat-rpls-2/igt@i915_selftest@live@migrate.html
* igt@runner@aborted:
- {bat-adlm-1}: NOTRUN -> [FAIL][2]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/bat-adlm-1/igt@runner@aborted.html
Known issues
------------
Here are the changes found in Patchwork_22668 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_cs_nop@sync-fork-compute0:
- fi-snb-2600: NOTRUN -> [SKIP][3] ([fdo#109271]) +17 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/fi-snb-2600/igt@amdgpu/amd_cs_nop@sync-fork-compute0.html
* igt@gem_exec_suspend@basic-s0@smem:
- fi-kbl-8809g: NOTRUN -> [DMESG-WARN][4] ([i915#4962]) +1 similar issue
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/fi-kbl-8809g/igt@gem_exec_suspend@basic-s0@smem.html
* igt@gem_huc_copy@huc-copy:
- fi-kbl-8809g: NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#2190])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/fi-kbl-8809g/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@random-engines:
- fi-kbl-8809g: NOTRUN -> [SKIP][6] ([fdo#109271] / [i915#4613]) +3 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/fi-kbl-8809g/igt@gem_lmem_swapping@random-engines.html
* igt@i915_pm_rpm@basic-rte:
- fi-kbl-8809g: NOTRUN -> [SKIP][7] ([fdo#109271]) +54 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/fi-kbl-8809g/igt@i915_pm_rpm@basic-rte.html
* igt@i915_pm_rpm@module-reload:
- fi-bsw-n3050: [PASS][8] -> [DMESG-WARN][9] ([i915#1982])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11398/fi-bsw-n3050/igt@i915_pm_rpm@module-reload.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/fi-bsw-n3050/igt@i915_pm_rpm@module-reload.html
* igt@kms_chamelium@hdmi-edid-read:
- fi-kbl-8809g: NOTRUN -> [SKIP][10] ([fdo#109271] / [fdo#111827]) +8 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/fi-kbl-8809g/igt@kms_chamelium@hdmi-edid-read.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c:
- fi-kbl-8809g: NOTRUN -> [SKIP][11] ([fdo#109271] / [i915#5341])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/fi-kbl-8809g/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- fi-kbl-8809g: NOTRUN -> [SKIP][12] ([fdo#109271] / [i915#533])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/fi-kbl-8809g/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
#### Possible fixes ####
* igt@i915_selftest@live@gt_timelines:
- {bat-rpls-2}: [DMESG-WARN][13] ([i915#4391]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11398/bat-rpls-2/igt@i915_selftest@live@gt_timelines.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/bat-rpls-2/igt@i915_selftest@live@gt_timelines.html
* igt@i915_selftest@live@hangcheck:
- bat-dg1-6: [DMESG-FAIL][15] ([i915#4494] / [i915#4957]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11398/bat-dg1-6/igt@i915_selftest@live@hangcheck.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/bat-dg1-6/igt@i915_selftest@live@hangcheck.html
- fi-snb-2600: [INCOMPLETE][17] ([i915#3921]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11398/fi-snb-2600/igt@i915_selftest@live@hangcheck.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/fi-snb-2600/igt@i915_selftest@live@hangcheck.html
* igt@kms_busy@basic@modeset:
- {bat-adlp-6}: [DMESG-WARN][19] ([i915#3576]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11398/bat-adlp-6/igt@kms_busy@basic@modeset.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/bat-adlp-6/igt@kms_busy@basic@modeset.html
#### Warnings ####
* igt@i915_pm_rpm@basic-rte:
- fi-kbl-guc: [SKIP][21] ([fdo#109271]) -> [FAIL][22] ([i915#579])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11398/fi-kbl-guc/igt@i915_pm_rpm@basic-rte.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/fi-kbl-guc/igt@i915_pm_rpm@basic-rte.html
* igt@kms_frontbuffer_tracking@basic:
- fi-cfl-8109u: [DMESG-WARN][23] ([i915#295]) -> [DMESG-FAIL][24] ([i915#295])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11398/fi-cfl-8109u/igt@kms_frontbuffer_tracking@basic.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/fi-cfl-8109u/igt@kms_frontbuffer_tracking@basic.html
* igt@runner@aborted:
- fi-apl-guc: [FAIL][25] ([i915#2426] / [i915#4312]) -> [FAIL][26] ([i915#4312])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11398/fi-apl-guc/igt@runner@aborted.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/fi-apl-guc/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#295]: https://gitlab.freedesktop.org/drm/intel/issues/295
[i915#3003]: https://gitlab.freedesktop.org/drm/intel/issues/3003
[i915#3138]: https://gitlab.freedesktop.org/drm/intel/issues/3138
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3576]: https://gitlab.freedesktop.org/drm/intel/issues/3576
[i915#3595]: https://gitlab.freedesktop.org/drm/intel/issues/3595
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3921]: https://gitlab.freedesktop.org/drm/intel/issues/3921
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391
[i915#4494]: https://gitlab.freedesktop.org/drm/intel/issues/4494
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4957]: https://gitlab.freedesktop.org/drm/intel/issues/4957
[i915#4962]: https://gitlab.freedesktop.org/drm/intel/issues/4962
[i915#5087]: https://gitlab.freedesktop.org/drm/intel/issues/5087
[i915#5192]: https://gitlab.freedesktop.org/drm/intel/issues/5192
[i915#5193]: https://gitlab.freedesktop.org/drm/intel/issues/5193
[i915#5306]: https://gitlab.freedesktop.org/drm/intel/issues/5306
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5338]: https://gitlab.freedesktop.org/drm/intel/issues/5338
[i915#5339]: https://gitlab.freedesktop.org/drm/intel/issues/5339
[i915#5341]: https://gitlab.freedesktop.org/drm/intel/issues/5341
[i915#579]: https://gitlab.freedesktop.org/drm/intel/issues/579
Build changes
-------------
* Linux: CI_DRM_11398 -> Patchwork_22668
CI-20190529: 20190529
CI_DRM_11398: da54e0aff302424358b14f443a9be2f84bb6ca47 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6389: fa423f527496936a759eb838b023642deea7625f @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_22668: d7c0e5b3bf109a74fad73c59f0438fbc7b11b8d5 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
d7c0e5b3bf10 drm/i915/dsb: modified to drm_info in dsb_prepare()
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/index.html
[-- Attachment #2: Type: text/html, Size: 9733 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/dsb: modified to drm_info in dsb_prepare()
2022-03-24 7:43 [Intel-gfx] [PATCH] drm/i915/dsb: modified to drm_info in dsb_prepare() Animesh Manna
` (3 preceding siblings ...)
2022-03-24 9:21 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
@ 2022-03-24 11:47 ` Patchwork
4 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2022-03-24 11:47 UTC (permalink / raw)
To: Animesh Manna; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 30275 bytes --]
== Series Details ==
Series: drm/i915/dsb: modified to drm_info in dsb_prepare()
URL : https://patchwork.freedesktop.org/series/101723/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11398_full -> Patchwork_22668_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (12 -> 12)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_22668_full:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@gem_exec_nop@basic-series:
- {shard-rkl}: NOTRUN -> [INCOMPLETE][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-rkl-5/igt@gem_exec_nop@basic-series.html
Known issues
------------
Here are the changes found in Patchwork_22668_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_isolation@preservation-s3@bcs0:
- shard-kbl: [PASS][2] -> [DMESG-WARN][3] ([i915#180]) +1 similar issue
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11398/shard-kbl7/igt@gem_ctx_isolation@preservation-s3@bcs0.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-kbl1/igt@gem_ctx_isolation@preservation-s3@bcs0.html
* igt@gem_exec_balancer@parallel-balancer:
- shard-iclb: [PASS][4] -> [SKIP][5] ([i915#4525])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11398/shard-iclb4/igt@gem_exec_balancer@parallel-balancer.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-iclb3/igt@gem_exec_balancer@parallel-balancer.html
* igt@gem_exec_fair@basic-deadline:
- shard-kbl: [PASS][6] -> [FAIL][7] ([i915#2846])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11398/shard-kbl1/igt@gem_exec_fair@basic-deadline.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-kbl4/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-flow@rcs0:
- shard-skl: NOTRUN -> [SKIP][8] ([fdo#109271]) +105 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-skl1/igt@gem_exec_fair@basic-flow@rcs0.html
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-iclb: [PASS][9] -> [FAIL][10] ([i915#2842])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11398/shard-iclb7/igt@gem_exec_fair@basic-none-share@rcs0.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-iclb8/igt@gem_exec_fair@basic-none-share@rcs0.html
* igt@gem_exec_fair@basic-none@vecs0:
- shard-apl: [PASS][11] -> [FAIL][12] ([i915#2842])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11398/shard-apl8/igt@gem_exec_fair@basic-none@vecs0.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-apl4/igt@gem_exec_fair@basic-none@vecs0.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglb: [PASS][13] -> [FAIL][14] ([i915#2842])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11398/shard-tglb8/igt@gem_exec_fair@basic-pace-share@rcs0.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-tglb6/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-pace@vecs0:
- shard-kbl: [PASS][15] -> [FAIL][16] ([i915#2842])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11398/shard-kbl7/igt@gem_exec_fair@basic-pace@vecs0.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-kbl7/igt@gem_exec_fair@basic-pace@vecs0.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-iclb: [PASS][17] -> [FAIL][18] ([i915#2849])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11398/shard-iclb4/igt@gem_exec_fair@basic-throttle@rcs0.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-iclb3/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@gem_lmem_swapping@heavy-random:
- shard-tglb: NOTRUN -> [SKIP][19] ([i915#4613])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-tglb7/igt@gem_lmem_swapping@heavy-random.html
* igt@gem_lmem_swapping@parallel-random:
- shard-skl: NOTRUN -> [SKIP][20] ([fdo#109271] / [i915#4613])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-skl6/igt@gem_lmem_swapping@parallel-random.html
* igt@gem_lmem_swapping@parallel-random-engines:
- shard-apl: NOTRUN -> [SKIP][21] ([fdo#109271] / [i915#4613])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-apl3/igt@gem_lmem_swapping@parallel-random-engines.html
* igt@gem_mmap_gtt@fault-concurrent-y:
- shard-snb: [PASS][22] -> [INCOMPLETE][23] ([i915#5161])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11398/shard-snb7/igt@gem_mmap_gtt@fault-concurrent-y.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-snb2/igt@gem_mmap_gtt@fault-concurrent-y.html
* igt@gem_pxp@fail-invalid-protected-context:
- shard-tglb: NOTRUN -> [SKIP][24] ([i915#4270])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-tglb2/igt@gem_pxp@fail-invalid-protected-context.html
- shard-iclb: NOTRUN -> [SKIP][25] ([i915#4270])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-iclb1/igt@gem_pxp@fail-invalid-protected-context.html
* igt@gem_userptr_blits@coherency-sync:
- shard-iclb: NOTRUN -> [SKIP][26] ([fdo#109290])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-iclb1/igt@gem_userptr_blits@coherency-sync.html
* igt@gem_userptr_blits@vma-merge:
- shard-snb: NOTRUN -> [FAIL][27] ([i915#2724])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-snb7/igt@gem_userptr_blits@vma-merge.html
* igt@gen9_exec_parse@bb-oversize:
- shard-iclb: NOTRUN -> [SKIP][28] ([i915#2856]) +1 similar issue
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-iclb1/igt@gen9_exec_parse@bb-oversize.html
* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [PASS][29] -> [FAIL][30] ([i915#454])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11398/shard-iclb4/igt@i915_pm_dc@dc6-psr.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-iclb3/igt@i915_pm_dc@dc6-psr.html
* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp:
- shard-apl: NOTRUN -> [SKIP][31] ([fdo#109271] / [i915#1937])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-apl3/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp.html
* igt@kms_big_fb@linear-32bpp-rotate-180:
- shard-glk: [PASS][32] -> [DMESG-WARN][33] ([i915#118])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11398/shard-glk1/igt@kms_big_fb@linear-32bpp-rotate-180.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-glk1/igt@kms_big_fb@linear-32bpp-rotate-180.html
* igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-hflip:
- shard-kbl: NOTRUN -> [SKIP][34] ([fdo#109271] / [i915#3777])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-kbl4/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-hflip.html
* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-async-flip:
- shard-skl: NOTRUN -> [FAIL][35] ([i915#3743])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-skl7/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html
* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-hflip:
- shard-apl: NOTRUN -> [SKIP][36] ([fdo#109271] / [i915#3777])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-apl3/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-hflip.html
* igt@kms_ccs@pipe-a-random-ccs-data-y_tiled_gen12_rc_ccs_cc:
- shard-kbl: NOTRUN -> [SKIP][37] ([fdo#109271] / [i915#3886]) +1 similar issue
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-kbl4/igt@kms_ccs@pipe-a-random-ccs-data-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_rc_ccs:
- shard-iclb: NOTRUN -> [SKIP][38] ([fdo#109278]) +3 similar issues
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-iclb1/igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_rc_ccs.html
* igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][39] ([fdo#109271] / [i915#3886]) +1 similar issue
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-apl8/igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-c-bad-aux-stride-y_tiled_gen12_mc_ccs:
- shard-skl: NOTRUN -> [SKIP][40] ([fdo#109271] / [i915#3886]) +3 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-skl2/igt@kms_ccs@pipe-c-bad-aux-stride-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-c-bad-rotation-90-yf_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][41] ([fdo#111615] / [i915#3689])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-tglb2/igt@kms_ccs@pipe-c-bad-rotation-90-yf_tiled_ccs.html
* igt@kms_chamelium@hdmi-aspect-ratio:
- shard-skl: NOTRUN -> [SKIP][42] ([fdo#109271] / [fdo#111827]) +9 similar issues
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-skl7/igt@kms_chamelium@hdmi-aspect-ratio.html
* igt@kms_chamelium@hdmi-crc-single:
- shard-snb: NOTRUN -> [SKIP][43] ([fdo#109271] / [fdo#111827])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-snb7/igt@kms_chamelium@hdmi-crc-single.html
* igt@kms_chamelium@vga-frame-dump:
- shard-tglb: NOTRUN -> [SKIP][44] ([fdo#109284] / [fdo#111827]) +3 similar issues
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-tglb2/igt@kms_chamelium@vga-frame-dump.html
* igt@kms_color@pipe-b-deep-color:
- shard-apl: NOTRUN -> [SKIP][45] ([fdo#109271]) +83 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-apl7/igt@kms_color@pipe-b-deep-color.html
* igt@kms_color@pipe-d-ctm-red-to-blue:
- shard-iclb: NOTRUN -> [SKIP][46] ([fdo#109278] / [i915#1149])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-iclb1/igt@kms_color@pipe-d-ctm-red-to-blue.html
* igt@kms_color_chamelium@pipe-a-degamma:
- shard-kbl: NOTRUN -> [SKIP][47] ([fdo#109271] / [fdo#111827]) +2 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-kbl4/igt@kms_color_chamelium@pipe-a-degamma.html
* igt@kms_color_chamelium@pipe-b-ctm-red-to-blue:
- shard-iclb: NOTRUN -> [SKIP][48] ([fdo#109284] / [fdo#111827]) +3 similar issues
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-iclb1/igt@kms_color_chamelium@pipe-b-ctm-red-to-blue.html
- shard-apl: NOTRUN -> [SKIP][49] ([fdo#109271] / [fdo#111827]) +8 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-apl3/igt@kms_color_chamelium@pipe-b-ctm-red-to-blue.html
* igt@kms_content_protection@legacy:
- shard-apl: NOTRUN -> [TIMEOUT][50] ([i915#1319])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-apl8/igt@kms_content_protection@legacy.html
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-skl: [PASS][51] -> [INCOMPLETE][52] ([i915#2828] / [i915#300])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11398/shard-skl7/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-skl4/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
* igt@kms_cursor_crc@pipe-d-cursor-512x512-sliding:
- shard-tglb: NOTRUN -> [SKIP][53] ([fdo#109279] / [i915#3359]) +2 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-tglb2/igt@kms_cursor_crc@pipe-d-cursor-512x512-sliding.html
* igt@kms_cursor_legacy@cursora-vs-flipb-varying-size:
- shard-iclb: NOTRUN -> [SKIP][54] ([fdo#109274] / [fdo#109278])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-iclb1/igt@kms_cursor_legacy@cursora-vs-flipb-varying-size.html
* igt@kms_flip@flip-vs-expired-vblank@a-edp1:
- shard-skl: [PASS][55] -> [FAIL][56] ([i915#79])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11398/shard-skl9/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-skl8/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html
* igt@kms_flip@flip-vs-suspend-interruptible@b-edp1:
- shard-skl: [PASS][57] -> [INCOMPLETE][58] ([i915#4839])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11398/shard-skl8/igt@kms_flip@flip-vs-suspend-interruptible@b-edp1.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-skl9/igt@kms_flip@flip-vs-suspend-interruptible@b-edp1.html
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-blt:
- shard-kbl: NOTRUN -> [SKIP][59] ([fdo#109271]) +28 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-kbl3/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-blt.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-shrfb-draw-render:
- shard-iclb: NOTRUN -> [SKIP][60] ([fdo#109280]) +3 similar issues
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-shrfb-draw-render.html
* igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-indfb-draw-mmap-cpu:
- shard-tglb: NOTRUN -> [SKIP][61] ([fdo#109280] / [fdo#111825])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-tglb2/igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-indfb-draw-mmap-cpu.html
* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-spr-indfb-draw-mmap-cpu:
- shard-snb: NOTRUN -> [SKIP][62] ([fdo#109271]) +14 similar issues
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-snb7/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-spr-indfb-draw-mmap-cpu.html
* igt@kms_hdr@static-swap:
- shard-iclb: NOTRUN -> [SKIP][63] ([i915#3555])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-iclb1/igt@kms_hdr@static-swap.html
* igt@kms_pipe_crc_basic@hang-read-crc-pipe-d:
- shard-apl: NOTRUN -> [SKIP][64] ([fdo#109271] / [i915#533])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-apl3/igt@kms_pipe_crc_basic@hang-read-crc-pipe-d.html
* igt@kms_plane@plane-panning-bottom-right-suspend@pipe-b-planes:
- shard-apl: [PASS][65] -> [DMESG-WARN][66] ([i915#180]) +1 similar issue
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11398/shard-apl3/igt@kms_plane@plane-panning-bottom-right-suspend@pipe-b-planes.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-apl3/igt@kms_plane@plane-panning-bottom-right-suspend@pipe-b-planes.html
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [PASS][67] -> [FAIL][68] ([fdo#108145] / [i915#265]) +1 similar issue
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11398/shard-skl7/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-skl4/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
* igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb:
- shard-skl: NOTRUN -> [FAIL][69] ([i915#265])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-skl6/igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb.html
* igt@kms_psr@psr2_no_drrs:
- shard-iclb: NOTRUN -> [SKIP][70] ([fdo#109441])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-iclb1/igt@kms_psr@psr2_no_drrs.html
- shard-tglb: NOTRUN -> [FAIL][71] ([i915#132] / [i915#3467])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-tglb2/igt@kms_psr@psr2_no_drrs.html
* igt@kms_writeback@writeback-fb-id:
- shard-apl: NOTRUN -> [SKIP][72] ([fdo#109271] / [i915#2437])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-apl3/igt@kms_writeback@writeback-fb-id.html
* igt@perf@gen8-unprivileged-single-ctx-counters:
- shard-tglb: NOTRUN -> [SKIP][73] ([fdo#109289])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-tglb2/igt@perf@gen8-unprivileged-single-ctx-counters.html
* igt@sysfs_clients@create:
- shard-apl: NOTRUN -> [SKIP][74] ([fdo#109271] / [i915#2994])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-apl7/igt@sysfs_clients@create.html
* igt@sysfs_clients@fair-0:
- shard-skl: NOTRUN -> [SKIP][75] ([fdo#109271] / [i915#2994]) +3 similar issues
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-skl6/igt@sysfs_clients@fair-0.html
#### Possible fixes ####
* igt@feature_discovery@psr2:
- {shard-rkl}: [SKIP][76] ([i915#658]) -> [PASS][77]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11398/shard-rkl-2/igt@feature_discovery@psr2.html
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-rkl-6/igt@feature_discovery@psr2.html
* igt@gem_eio@in-flight-immediate:
- shard-tglb: [TIMEOUT][78] ([i915#3063]) -> [PASS][79]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11398/shard-tglb5/igt@gem_eio@in-flight-immediate.html
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-tglb7/igt@gem_eio@in-flight-immediate.html
* igt@gem_eio@unwedge-stress:
- {shard-rkl}: [TIMEOUT][80] ([i915#3063]) -> [PASS][81]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11398/shard-rkl-2/igt@gem_eio@unwedge-stress.html
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-rkl-6/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_create@madvise@smem:
- {shard-rkl}: [INCOMPLETE][82] ([i915#5385]) -> [PASS][83]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11398/shard-rkl-5/igt@gem_exec_create@madvise@smem.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-rkl-5/igt@gem_exec_create@madvise@smem.html
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-kbl: [FAIL][84] ([i915#2842]) -> [PASS][85] +1 similar issue
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11398/shard-kbl3/igt@gem_exec_fair@basic-pace-solo@rcs0.html
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-kbl7/igt@gem_exec_fair@basic-pace-solo@rcs0.html
* igt@gem_exec_fair@basic-pace@vcs0:
- shard-glk: [FAIL][86] ([i915#2842]) -> [PASS][87]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11398/shard-glk1/igt@gem_exec_fair@basic-pace@vcs0.html
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-glk1/igt@gem_exec_fair@basic-pace@vcs0.html
* igt@i915_pm_rpm@basic-rte:
- {shard-rkl}: [SKIP][88] ([fdo#109308]) -> [PASS][89]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11398/shard-rkl-5/igt@i915_pm_rpm@basic-rte.html
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-rkl-6/igt@i915_pm_rpm@basic-rte.html
* igt@i915_suspend@fence-restore-tiled2untiled:
- shard-apl: [DMESG-WARN][90] ([i915#180]) -> [PASS][91] +3 similar issues
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11398/shard-apl1/igt@i915_suspend@fence-restore-tiled2untiled.html
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-apl8/igt@i915_suspend@fence-restore-tiled2untiled.html
* igt@i915_suspend@sysfs-reader:
- shard-kbl: [INCOMPLETE][92] ([i915#3614]) -> [PASS][93]
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11398/shard-kbl4/igt@i915_suspend@sysfs-reader.html
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-kbl1/igt@i915_suspend@sysfs-reader.html
* igt@kms_atomic@test-only:
- {shard-rkl}: [SKIP][94] ([i915#1845] / [i915#4098]) -> [PASS][95] +17 similar issues
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11398/shard-rkl-5/igt@kms_atomic@test-only.html
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-rkl-6/igt@kms_atomic@test-only.html
* igt@kms_big_fb@x-tiled-32bpp-rotate-180:
- {shard-rkl}: ([SKIP][96], [SKIP][97]) ([i915#1845] / [i915#4098]) -> [PASS][98] +2 similar issues
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11398/shard-rkl-2/igt@kms_big_fb@x-tiled-32bpp-rotate-180.html
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11398/shard-rkl-4/igt@kms_big_fb@x-tiled-32bpp-rotate-180.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-rkl-6/igt@kms_big_fb@x-tiled-32bpp-rotate-180.html
* igt@kms_color@pipe-b-ctm-red-to-blue:
- {shard-rkl}: [SKIP][99] ([i915#1149] / [i915#1849] / [i915#4070] / [i915#4098]) -> [PASS][100] +1 similar issue
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11398/shard-rkl-5/igt@kms_color@pipe-b-ctm-red-to-blue.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-rkl-6/igt@kms_color@pipe-b-ctm-red-to-blue.html
* igt@kms_cursor_crc@pipe-a-cursor-128x42-sliding:
- {shard-rkl}: ([SKIP][101], [SKIP][102]) ([fdo#112022] / [i915#4070]) -> [PASS][103]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11398/shard-rkl-4/igt@kms_cursor_crc@pipe-a-cursor-128x42-sliding.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11398/shard-rkl-2/igt@kms_cursor_crc@pipe-a-cursor-128x42-sliding.html
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-rkl-6/igt@kms_cursor_crc@pipe-a-cursor-128x42-sliding.html
* igt@kms_cursor_crc@pipe-b-cursor-64x64-random:
- {shard-rkl}: [SKIP][104] ([fdo#112022] / [i915#4070]) -> [PASS][105] +4 similar issues
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11398/shard-rkl-5/igt@kms_cursor_crc@pipe-b-cursor-64x64-random.html
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-rkl-6/igt@kms_cursor_crc@pipe-b-cursor-64x64-random.html
* igt@kms_cursor_edge_walk@pipe-a-256x256-top-edge:
- {shard-rkl}: [SKIP][106] ([i915#1849] / [i915#4070] / [i915#4098]) -> [PASS][107] +2 similar issues
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11398/shard-rkl-5/igt@kms_cursor_edge_walk@pipe-a-256x256-top-edge.html
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-rkl-6/igt@kms_cursor_edge_walk@pipe-a-256x256-top-edge.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-glk: [FAIL][108] ([i915#2346]) -> [PASS][109]
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11398/shard-glk1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-glk1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
* igt@kms_cursor_legacy@long-nonblocking-modeset-vs-cursor-atomic:
- {shard-rkl}: [SKIP][110] ([fdo#111825] / [i915#4070]) -> [PASS][111] +2 similar issues
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11398/shard-rkl-5/igt@kms_cursor_legacy@long-nonblocking-modeset-vs-cursor-atomic.html
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-rkl-6/igt@kms_cursor_legacy@long-nonblocking-modeset-vs-cursor-atomic.html
* igt@kms_cursor_legacy@pipe-c-torture-bo:
- {shard-rkl}: [SKIP][112] ([i915#4070]) -> [PASS][113]
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11398/shard-rkl-1/igt@kms_cursor_legacy@pipe-c-torture-bo.html
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-rkl-5/igt@kms_cursor_legacy@pipe-c-torture-bo.html
* igt@kms_draw_crc@draw-method-rgb565-pwrite-ytiled:
- {shard-rkl}: [SKIP][114] ([fdo#111314] / [i915#4098] / [i915#4369]) -> [PASS][115] +2 similar issues
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11398/shard-rkl-5/igt@kms_draw_crc@draw-method-rgb565-pwrite-ytiled.html
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-rkl-6/igt@kms_draw_crc@draw-method-rgb565-pwrite-ytiled.html
* igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@ab-hdmi-a1-hdmi-a2:
- shard-glk: [FAIL][116] ([i915#2122]) -> [PASS][117] +1 similar issue
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11398/shard-glk2/igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@ab-hdmi-a1-hdmi-a2.html
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-glk4/igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@ab-hdmi-a1-hdmi-a2.html
* igt@kms_flip@flip-vs-expired-vblank@c-edp1:
- shard-skl: [FAIL][118] ([i915#79]) -> [PASS][119]
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11398/shard-skl9/igt@kms_flip@flip-vs-expired-vblank@c-edp1.html
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-skl8/igt@kms_flip@flip-vs-expired-vblank@c-edp1.html
* igt@kms_flip@flip-vs-fences-interruptible@b-vga1:
- shard-snb: [INCOMPLETE][120] ([i915#5000] / [i915#5204]) -> [PASS][121]
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11398/shard-snb4/igt@kms_flip@flip-vs-fences-interruptible@b-vga1.html
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-snb7/igt@kms_flip@flip-vs-fences-interruptible@b-vga1.html
* igt@kms_flip@plain-flip-ts-check-interruptible@c-edp1:
- shard-skl: [FAIL][122] ([i915#2122]) -> [PASS][123]
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11398/shard-skl6/igt@kms_flip@plain-flip-ts-check-interruptible@c-edp1.html
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-skl1/igt@kms_flip@plain-flip-ts-check-interruptible@c-edp1.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs-upscaling:
- {shard-rkl}: [INCOMPLETE][124] ([i915#3701]) -> [PASS][125]
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11398/shard-rkl-5/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs-upscaling.html
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-rkl-6/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs-upscaling.html
* igt@kms_frontbuffer_tracking@fbcpsr-rgb101010-draw-mmap-cpu:
- {shard-rkl}: [SKIP][126] ([i915#1849]) -> [PASS][127] +16 similar issues
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11398/shard-rkl-5/igt@kms_frontbuffer_tracking@fbcpsr-rgb101010-draw-mmap-cpu.html
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-rkl-6/igt@kms_frontbuffer_tracking@fbcpsr-rgb101010-draw-mmap-cpu.html
* igt@kms_hdr@bpc-switch@bpc-switch-edp-1-pipe-a:
- shard-skl: [FAIL][128] ([i915#1188]) -> [PASS][129]
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11398/shard-skl6/igt@kms_hdr@bpc-switch@bpc-switch-edp-1-pipe-a.html
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-skl2/igt@kms_hdr@bpc-switch@bpc-switch-edp-1-pipe-a.html
* igt@kms_invalid_mode@int-max-clock:
- {shard-rkl}: [SKIP][130] ([i915#4278]) -> [PASS][131] +1 similar issue
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11398/shard-rkl-5/igt@kms_invalid_mode@int-max-clock.html
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-rkl-6/igt@kms_invalid_mode@int-max-clock.html
* igt@kms_plane@plane-panning-bottom-right-suspend@pipe-b-planes:
- shard-kbl: [DMESG-WARN][132] ([i915#180]) -> [PASS][133] +4 similar issues
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11398/shard-kbl7/igt@kms_plane@plane-panning-bottom-right-suspend@pipe-b-planes.html
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-kbl7/igt@kms_plane@plane-panning-bottom-right-suspend@pipe-b-planes.html
* igt@kms_plane@plane-position-covered@pipe-b-planes:
- {shard-rkl}: [SKIP][134] ([i915#1849] / [i915#3558]) -> [PASS][135] +3 similar issues
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11398/shard-rkl-2/igt@kms_plane@plane-position-covered@pipe-b-planes.html
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-rkl-6/igt@kms_plane@plane-position-covered@pipe-b-planes.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [FAIL][136] ([fdo#108145] / [i915#265]) -> [PASS][137]
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11398/shard-skl6/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-skl1/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
* igt@kms_plane_multiple@atomic-pipe-b-tiling-none:
- {shard-rkl}: [SKIP][138] ([i915#1849] / [i915#3558] / [i915#4070]) -> [PASS][139]
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11398/shard-rkl-5/igt@kms_plane_multiple@atomic-pipe-b-tiling-none.html
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-rkl-6/igt@kms_plane_multiple@atomic-pipe-b-tiling-none.html
* igt@kms_psr@sprite_plane_move:
- {shard-rkl}: [SKIP][140] ([i915#1072]) -> [PASS][141]
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11398/shard-rkl-5/igt@kms_psr@sprite_plane_move.html
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/shard-rkl-6/igt@kms_psr@sprite_plane_move.html
* igt@kms_universal_plane@universal-plane-pipe-b-functional:
- {shard-rkl}: [SKIP][142] ([i915#1845] / [i915#4070]
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22668/index.html
[-- Attachment #2: Type: text/html, Size: 33338 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/dsb: modified to drm_info in dsb_prepare()
2022-03-24 9:08 ` [Intel-gfx] [PATCH] " Das, Nirmoy
@ 2022-03-25 13:22 ` Manna, Animesh
2022-03-25 13:39 ` Das, Nirmoy
0 siblings, 1 reply; 12+ messages in thread
From: Manna, Animesh @ 2022-03-25 13:22 UTC (permalink / raw)
To: Das, Nirmoy, intel-gfx@lists.freedesktop.org
> -----Original Message-----
> From: Das, Nirmoy <nirmoy.das@linux.intel.com>
> Sent: Thursday, March 24, 2022 2:39 PM
> To: Manna, Animesh <animesh.manna@intel.com>; intel-
> gfx@lists.freedesktop.org
> Subject: Re: [Intel-gfx] [PATCH] drm/i915/dsb: modified to drm_info in
> dsb_prepare()
>
>
> On 3/24/2022 8:43 AM, Animesh Manna wrote:
> > The request to aqquire gem resources is failing for DSB in rare
> > scenario where it is busy and the register programming will be done
> > through mmio fallback path.
> >
> > DSB has extra advantage of faster register programming which may go
> > away through mmio path. Adding wait for gem resource also may not be
> > right as anyways losing time.
> >
> > To make the CI execution happy replaced drm_dbg_kms() to drm_info()
> > for printing debuf info during dsb buffer preparation.
> >
> > Signed-off-by: Animesh Manna <animesh.manna@intel.com>
> > ---
> > drivers/gpu/drm/i915/display/intel_dsb.c | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_dsb.c
> > b/drivers/gpu/drm/i915/display/intel_dsb.c
> > index b34a67309976..b68dd7bd5271 100644
> > --- a/drivers/gpu/drm/i915/display/intel_dsb.c
> > +++ b/drivers/gpu/drm/i915/display/intel_dsb.c
> > @@ -275,7 +275,7 @@ void intel_dsb_prepare(struct intel_crtc_state
> > *crtc_state)
> >
> > dsb = kmalloc(sizeof(*dsb), GFP_KERNEL);
> > if (!dsb) {
> > - drm_err(&i915->drm, "DSB object creation failed\n");
> > + drm_info(&i915->drm, "DSB object creation failed\n");
> > return;
> > }
> >
> > @@ -283,14 +283,14 @@ void intel_dsb_prepare(struct intel_crtc_state
> > *crtc_state)
> >
> > obj = i915_gem_object_create_internal(i915, DSB_BUF_SIZE);
> > if (IS_ERR(obj)) {
> > - drm_err(&i915->drm, "Gem object creation failed\n");
> > + drm_info(&i915->drm, "Gem object creation failed\n");
>
> If CI is happy with drm_warn then it makes sense to use drm_warn.
Checked with CI team, seems drm_warn also considered as bug, is it ok to use drm_info?
>
>
> > kfree(dsb);
> > goto out;
> > }
> >
> > vma = i915_gem_object_ggtt_pin(obj, NULL, 0, 0, 0);
> > if (IS_ERR(vma)) {
> > - drm_err(&i915->drm, "Vma creation failed\n");
> > + drm_info(&i915->drm, "Vma creation failed\n");
>
>
> These messages are bit vague, add "DSB VMA creation failed" or something
> similar.
>
> With that Acked-by: Nirmoy Das <nirmoy.das@intel.com>
Thanks for review, will modify in next version.
Regards,
Animesh
>
>
> Nirmoy
>
>
> > i915_gem_object_put(obj);
> > kfree(dsb);
> > goto out;
> > @@ -298,7 +298,7 @@ void intel_dsb_prepare(struct intel_crtc_state
> > *crtc_state)
> >
> > buf = i915_gem_object_pin_map_unlocked(vma->obj, I915_MAP_WC);
> > if (IS_ERR(buf)) {
> > - drm_err(&i915->drm, "Command buffer creation failed\n");
> > + drm_info(&i915->drm, "Command buffer creation failed\n");
> > i915_vma_unpin_and_release(&vma,
> I915_VMA_RELEASE_MAP);
> > kfree(dsb);
> > goto out;
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/dsb: modified to drm_info in dsb_prepare()
2022-03-25 13:22 ` Manna, Animesh
@ 2022-03-25 13:39 ` Das, Nirmoy
0 siblings, 0 replies; 12+ messages in thread
From: Das, Nirmoy @ 2022-03-25 13:39 UTC (permalink / raw)
To: Manna, Animesh, intel-gfx@lists.freedesktop.org
On 3/25/2022 2:22 PM, Manna, Animesh wrote:
>
>> -----Original Message-----
>> From: Das, Nirmoy <nirmoy.das@linux.intel.com>
>> Sent: Thursday, March 24, 2022 2:39 PM
>> To: Manna, Animesh <animesh.manna@intel.com>; intel-
>> gfx@lists.freedesktop.org
>> Subject: Re: [Intel-gfx] [PATCH] drm/i915/dsb: modified to drm_info in
>> dsb_prepare()
>>
>>
>> On 3/24/2022 8:43 AM, Animesh Manna wrote:
>>> The request to aqquire gem resources is failing for DSB in rare
>>> scenario where it is busy and the register programming will be done
>>> through mmio fallback path.
>>>
>>> DSB has extra advantage of faster register programming which may go
>>> away through mmio path. Adding wait for gem resource also may not be
>>> right as anyways losing time.
>>>
>>> To make the CI execution happy replaced drm_dbg_kms() to drm_info()
>>> for printing debuf info during dsb buffer preparation.
>>>
>>> Signed-off-by: Animesh Manna <animesh.manna@intel.com>
>>> ---
>>> drivers/gpu/drm/i915/display/intel_dsb.c | 8 ++++----
>>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/i915/display/intel_dsb.c
>>> b/drivers/gpu/drm/i915/display/intel_dsb.c
>>> index b34a67309976..b68dd7bd5271 100644
>>> --- a/drivers/gpu/drm/i915/display/intel_dsb.c
>>> +++ b/drivers/gpu/drm/i915/display/intel_dsb.c
>>> @@ -275,7 +275,7 @@ void intel_dsb_prepare(struct intel_crtc_state
>>> *crtc_state)
>>>
>>> dsb = kmalloc(sizeof(*dsb), GFP_KERNEL);
>>> if (!dsb) {
>>> - drm_err(&i915->drm, "DSB object creation failed\n");
>>> + drm_info(&i915->drm, "DSB object creation failed\n");
>>> return;
>>> }
>>>
>>> @@ -283,14 +283,14 @@ void intel_dsb_prepare(struct intel_crtc_state
>>> *crtc_state)
>>>
>>> obj = i915_gem_object_create_internal(i915, DSB_BUF_SIZE);
>>> if (IS_ERR(obj)) {
>>> - drm_err(&i915->drm, "Gem object creation failed\n");
>>> + drm_info(&i915->drm, "Gem object creation failed\n");
>> If CI is happy with drm_warn then it makes sense to use drm_warn.
> Checked with CI team, seems drm_warn also considered as bug, is it ok to use drm_info?
In that case: don't print anything on each error and at out label, you
can print an info about the fallback option.
Nirmoy
>
>>
>>> kfree(dsb);
>>> goto out;
>>> }
>>>
>>> vma = i915_gem_object_ggtt_pin(obj, NULL, 0, 0, 0);
>>> if (IS_ERR(vma)) {
>>> - drm_err(&i915->drm, "Vma creation failed\n");
>>> + drm_info(&i915->drm, "Vma creation failed\n");
>>
>> These messages are bit vague, add "DSB VMA creation failed" or something
>> similar.
>>
>> With that Acked-by: Nirmoy Das <nirmoy.das@intel.com>
> Thanks for review, will modify in next version.
>
> Regards,
> Animesh
>
>>
>> Nirmoy
>>
>>
>>> i915_gem_object_put(obj);
>>> kfree(dsb);
>>> goto out;
>>> @@ -298,7 +298,7 @@ void intel_dsb_prepare(struct intel_crtc_state
>>> *crtc_state)
>>>
>>> buf = i915_gem_object_pin_map_unlocked(vma->obj, I915_MAP_WC);
>>> if (IS_ERR(buf)) {
>>> - drm_err(&i915->drm, "Command buffer creation failed\n");
>>> + drm_info(&i915->drm, "Command buffer creation failed\n");
>>> i915_vma_unpin_and_release(&vma,
>> I915_VMA_RELEASE_MAP);
>>> kfree(dsb);
>>> goto out;
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Intel-gfx] [PATCH] drm/i915/dsb: modified to drm_info in dsb_prepare()
@ 2022-03-25 14:28 Animesh Manna
2022-03-25 14:58 ` Das, Nirmoy
0 siblings, 1 reply; 12+ messages in thread
From: Animesh Manna @ 2022-03-25 14:28 UTC (permalink / raw)
To: intel-gfx
The request to aqquire gem resources is failing for DSB in rare
scenario where it is busy and the register programming will be done
through mmio fallback path.
DSB has extra advantage of faster register programming which may
go away through mmio path. Adding wait for gem resource also may
not be right as anyways losing time.
To make the CI execution happy replaced drm_err() to drm_info()
for printing debug info during dsb buffer preparation.
v1: Initial version.
v2: Added print for mmio fallback at out label. [Nirmoy]
Cc: Nirmoy Das <nirmoy.das@linux.intel.com>
Signed-off-by: Animesh Manna <animesh.manna@intel.com>
---
drivers/gpu/drm/i915/display/intel_dsb.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dsb.c b/drivers/gpu/drm/i915/display/intel_dsb.c
index b34a67309976..86c0cf5a03b5 100644
--- a/drivers/gpu/drm/i915/display/intel_dsb.c
+++ b/drivers/gpu/drm/i915/display/intel_dsb.c
@@ -283,14 +283,12 @@ void intel_dsb_prepare(struct intel_crtc_state *crtc_state)
obj = i915_gem_object_create_internal(i915, DSB_BUF_SIZE);
if (IS_ERR(obj)) {
- drm_err(&i915->drm, "Gem object creation failed\n");
kfree(dsb);
goto out;
}
vma = i915_gem_object_ggtt_pin(obj, NULL, 0, 0, 0);
if (IS_ERR(vma)) {
- drm_err(&i915->drm, "Vma creation failed\n");
i915_gem_object_put(obj);
kfree(dsb);
goto out;
@@ -298,7 +296,6 @@ void intel_dsb_prepare(struct intel_crtc_state *crtc_state)
buf = i915_gem_object_pin_map_unlocked(vma->obj, I915_MAP_WC);
if (IS_ERR(buf)) {
- drm_err(&i915->drm, "Command buffer creation failed\n");
i915_vma_unpin_and_release(&vma, I915_VMA_RELEASE_MAP);
kfree(dsb);
goto out;
@@ -311,6 +308,9 @@ void intel_dsb_prepare(struct intel_crtc_state *crtc_state)
dsb->ins_start_offset = 0;
crtc_state->dsb = dsb;
out:
+ if (!crtc_state->dsb)
+ drm_info(&i915->drm, "Fallback to mmio for register programming\n");
+
intel_runtime_pm_put(&i915->runtime_pm, wakeref);
}
--
2.29.0
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/dsb: modified to drm_info in dsb_prepare()
2022-03-25 14:28 [Intel-gfx] [PATCH] " Animesh Manna
@ 2022-03-25 14:58 ` Das, Nirmoy
0 siblings, 0 replies; 12+ messages in thread
From: Das, Nirmoy @ 2022-03-25 14:58 UTC (permalink / raw)
To: Animesh Manna, intel-gfx
On 3/25/2022 3:28 PM, Animesh Manna wrote:
> The request to aqquire gem resources is failing for DSB in rare
> scenario where it is busy and the register programming will be done
> through mmio fallback path.
>
> DSB has extra advantage of faster register programming which may
> go away through mmio path. Adding wait for gem resource also may
> not be right as anyways losing time.
>
> To make the CI execution happy replaced drm_err() to drm_info()
> for printing debug info during dsb buffer preparation.
>
> v1: Initial version.
> v2: Added print for mmio fallback at out label. [Nirmoy]
>
> Cc: Nirmoy Das <nirmoy.das@linux.intel.com>
> Signed-off-by: Animesh Manna <animesh.manna@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dsb.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dsb.c b/drivers/gpu/drm/i915/display/intel_dsb.c
> index b34a67309976..86c0cf5a03b5 100644
> --- a/drivers/gpu/drm/i915/display/intel_dsb.c
> +++ b/drivers/gpu/drm/i915/display/intel_dsb.c
> @@ -283,14 +283,12 @@ void intel_dsb_prepare(struct intel_crtc_state *crtc_state)
>
> obj = i915_gem_object_create_internal(i915, DSB_BUF_SIZE);
> if (IS_ERR(obj)) {
> - drm_err(&i915->drm, "Gem object creation failed\n");
> kfree(dsb);
> goto out;
> }
>
> vma = i915_gem_object_ggtt_pin(obj, NULL, 0, 0, 0);
> if (IS_ERR(vma)) {
> - drm_err(&i915->drm, "Vma creation failed\n");
> i915_gem_object_put(obj);
> kfree(dsb);
> goto out;
> @@ -298,7 +296,6 @@ void intel_dsb_prepare(struct intel_crtc_state *crtc_state)
>
> buf = i915_gem_object_pin_map_unlocked(vma->obj, I915_MAP_WC);
> if (IS_ERR(buf)) {
> - drm_err(&i915->drm, "Command buffer creation failed\n");
> i915_vma_unpin_and_release(&vma, I915_VMA_RELEASE_MAP);
> kfree(dsb);
> goto out;
> @@ -311,6 +308,9 @@ void intel_dsb_prepare(struct intel_crtc_state *crtc_state)
> dsb->ins_start_offset = 0;
> crtc_state->dsb = dsb;
> out:
> + if (!crtc_state->dsb)
> + drm_info(&i915->drm, "Fallback to mmio for register programming\n");
From the info message, it is hard to know what happened: Something like:
"DSB queue setup failed, will fallback to MMIO for display HW
programming" should be more understandable.
With such change, this is: Reviewed-by: Nirmoy Das <nirmoy.das@intel.com>
Nirmoy
> +
> intel_runtime_pm_put(&i915->runtime_pm, wakeref);
> }
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [Intel-gfx] [PATCH] drm/i915/dsb: modified to drm_info in dsb_prepare()
@ 2022-03-25 16:11 Animesh Manna
2022-04-05 11:44 ` Shankar, Uma
0 siblings, 1 reply; 12+ messages in thread
From: Animesh Manna @ 2022-03-25 16:11 UTC (permalink / raw)
To: intel-gfx; +Cc: Nirmoy Das
The request to aqquire gem resources is failing for DSB in rare
scenario where it is busy and the register programming will be done
through mmio fallback path.
DSB has extra advantage of faster register programming which may
go away through mmio path. Adding wait for gem resource also may
not be right as anyways losing time.
To make the CI execution happy replaced drm_err() to drm_info()
for printing debug info during dsb buffer preparation.
v1: Initial version.
v2: Added print for mmio fallback at out label. [Nirmoy]
v3: Improved debug message. [Nirmoy]
Reviewed-by: Nirmoy Das <nirmoy.das@intel.com>
Cc: Nirmoy Das <nirmoy.das@linux.intel.com>
Signed-off-by: Animesh Manna <animesh.manna@intel.com>
---
drivers/gpu/drm/i915/display/intel_dsb.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dsb.c b/drivers/gpu/drm/i915/display/intel_dsb.c
index b34a67309976..c4affcb216fd 100644
--- a/drivers/gpu/drm/i915/display/intel_dsb.c
+++ b/drivers/gpu/drm/i915/display/intel_dsb.c
@@ -283,14 +283,12 @@ void intel_dsb_prepare(struct intel_crtc_state *crtc_state)
obj = i915_gem_object_create_internal(i915, DSB_BUF_SIZE);
if (IS_ERR(obj)) {
- drm_err(&i915->drm, "Gem object creation failed\n");
kfree(dsb);
goto out;
}
vma = i915_gem_object_ggtt_pin(obj, NULL, 0, 0, 0);
if (IS_ERR(vma)) {
- drm_err(&i915->drm, "Vma creation failed\n");
i915_gem_object_put(obj);
kfree(dsb);
goto out;
@@ -298,7 +296,6 @@ void intel_dsb_prepare(struct intel_crtc_state *crtc_state)
buf = i915_gem_object_pin_map_unlocked(vma->obj, I915_MAP_WC);
if (IS_ERR(buf)) {
- drm_err(&i915->drm, "Command buffer creation failed\n");
i915_vma_unpin_and_release(&vma, I915_VMA_RELEASE_MAP);
kfree(dsb);
goto out;
@@ -311,6 +308,10 @@ void intel_dsb_prepare(struct intel_crtc_state *crtc_state)
dsb->ins_start_offset = 0;
crtc_state->dsb = dsb;
out:
+ if (!crtc_state->dsb)
+ drm_info(&i915->drm,
+ "DSB queue setup failed, will fallback to MMIO for display HW programming\n");
+
intel_runtime_pm_put(&i915->runtime_pm, wakeref);
}
--
2.29.0
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/dsb: modified to drm_info in dsb_prepare()
2022-03-25 16:11 Animesh Manna
@ 2022-04-05 11:44 ` Shankar, Uma
0 siblings, 0 replies; 12+ messages in thread
From: Shankar, Uma @ 2022-04-05 11:44 UTC (permalink / raw)
To: Manna, Animesh, intel-gfx@lists.freedesktop.org; +Cc: Das, Nirmoy
> -----Original Message-----
> From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Animesh
> Manna
> Sent: Friday, March 25, 2022 9:42 PM
> To: intel-gfx@lists.freedesktop.org
> Cc: Das, Nirmoy <nirmoy.das@intel.com>
> Subject: [Intel-gfx] [PATCH] drm/i915/dsb: modified to drm_info in dsb_prepare()
>
> The request to aqquire gem resources is failing for DSB in rare scenario where it is
> busy and the register programming will be done through mmio fallback path.
>
> DSB has extra advantage of faster register programming which may go away
> through mmio path. Adding wait for gem resource also may not be right as anyways
> losing time.
>
> To make the CI execution happy replaced drm_err() to drm_info() for printing debug
> info during dsb buffer preparation.
>
> v1: Initial version.
> v2: Added print for mmio fallback at out label. [Nirmoy]
> v3: Improved debug message. [Nirmoy]
Pushed to drm-intel-next. Thanks for the patch and reviews.
Regards,
Uma Shankar
> Reviewed-by: Nirmoy Das <nirmoy.das@intel.com>
> Cc: Nirmoy Das <nirmoy.das@linux.intel.com>
> Signed-off-by: Animesh Manna <animesh.manna@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dsb.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dsb.c
> b/drivers/gpu/drm/i915/display/intel_dsb.c
> index b34a67309976..c4affcb216fd 100644
> --- a/drivers/gpu/drm/i915/display/intel_dsb.c
> +++ b/drivers/gpu/drm/i915/display/intel_dsb.c
> @@ -283,14 +283,12 @@ void intel_dsb_prepare(struct intel_crtc_state
> *crtc_state)
>
> obj = i915_gem_object_create_internal(i915, DSB_BUF_SIZE);
> if (IS_ERR(obj)) {
> - drm_err(&i915->drm, "Gem object creation failed\n");
> kfree(dsb);
> goto out;
> }
>
> vma = i915_gem_object_ggtt_pin(obj, NULL, 0, 0, 0);
> if (IS_ERR(vma)) {
> - drm_err(&i915->drm, "Vma creation failed\n");
> i915_gem_object_put(obj);
> kfree(dsb);
> goto out;
> @@ -298,7 +296,6 @@ void intel_dsb_prepare(struct intel_crtc_state *crtc_state)
>
> buf = i915_gem_object_pin_map_unlocked(vma->obj, I915_MAP_WC);
> if (IS_ERR(buf)) {
> - drm_err(&i915->drm, "Command buffer creation failed\n");
> i915_vma_unpin_and_release(&vma, I915_VMA_RELEASE_MAP);
> kfree(dsb);
> goto out;
> @@ -311,6 +308,10 @@ void intel_dsb_prepare(struct intel_crtc_state *crtc_state)
> dsb->ins_start_offset = 0;
> crtc_state->dsb = dsb;
> out:
> + if (!crtc_state->dsb)
> + drm_info(&i915->drm,
> + "DSB queue setup failed, will fallback to MMIO for display
> HW
> +programming\n");
> +
> intel_runtime_pm_put(&i915->runtime_pm, wakeref); }
>
> --
> 2.29.0
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2022-04-05 11:44 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-03-24 7:43 [Intel-gfx] [PATCH] drm/i915/dsb: modified to drm_info in dsb_prepare() Animesh Manna
2022-03-24 8:49 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2022-03-24 8:53 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork
2022-03-24 9:08 ` [Intel-gfx] [PATCH] " Das, Nirmoy
2022-03-25 13:22 ` Manna, Animesh
2022-03-25 13:39 ` Das, Nirmoy
2022-03-24 9:21 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2022-03-24 11:47 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2022-03-25 14:28 [Intel-gfx] [PATCH] " Animesh Manna
2022-03-25 14:58 ` Das, Nirmoy
2022-03-25 16:11 Animesh Manna
2022-04-05 11:44 ` Shankar, Uma
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox