Re: [PATCH v5 04/15] drm/i915/alpm: Enable debugfs for DP2.1

["Hogander, Jouni" <jouni.hogander@intel.com>]

On Tue, 2026-08-25 at 11:15 +0530, Animesh Manna wrote:
> Enable ALPM debug info through lobf debug info.
> 
> v2: cosmetic change. [Suraj]
> v3: Use common api instead of DISPLAY_VER check in multiple places.
> [Jani]
> 
> Cc: Jouni Högander <jouni.hogander@intel.com>
> Reviewed-by: Suraj Kandpal <suraj.kandpal@intel.com>
> Signed-off-by: Animesh Manna <animesh.manna@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_alpm.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_alpm.c
> b/drivers/gpu/drm/i915/display/intel_alpm.c
> index 08ad77cd32f8..8cfcda97cf58 100644
> --- a/drivers/gpu/drm/i915/display/intel_alpm.c
> +++ b/drivers/gpu/drm/i915/display/intel_alpm.c
> @@ -617,11 +617,9 @@
> DEFINE_SIMPLE_ATTRIBUTE(i915_edp_lobf_debug_fops,
>  
>  void intel_alpm_lobf_debugfs_add(struct intel_connector *connector)
>  {
> -	struct intel_display *display = to_intel_display(connector);
>  	struct dentry *root = connector->base.debugfs_entry;
>  
> -	if (DISPLAY_VER(display) < 20 ||
> -	    connector->base.connector_type !=
> DRM_MODE_CONNECTOR_eDP)
> +	if (!intel_alpm_source_supported(connector))

Maybe what you actually want is intel_alpm_lobf_source_supported
(referring my comments on patch 3)?

BR,
Jouni Högander

>  		return;
>  
>  	debugfs_create_file("i915_edp_lobf_debug", 0644, root,