From: "Jyri Sarha" <jyri.sarha@iki.fi>
To: "Jani Nikula" <jani.nikula@intel.com>, dri-devel@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
jani.nikula@intel.com, ville.syrjala@linux.intel.com,
"Jyri Sarha" <jyri.sarha@iki.fi>,
"Tomi Valkeinen" <tomi.valkeinen@ideasonboard.com>
Subject: Re: [PATCH 4/6] drm/tidss: use drm_crtc_vblank_crtc()
Date: Sat, 08 Nov 2025 15:54:51 +0000 [thread overview]
Message-ID: <9d5bc82dc6f18adebc784df345b2a948703e3949@iki.fi> (raw)
In-Reply-To: <ffd5ebe03391b3c01e616c0c844a4b8ddecede36.1762513240.git.jani.nikula@intel.com>
[-- Attachment #1: Type: text/plain, Size: 1245 bytes --]
November 7, 2025 at 1:04 PM, "Jani Nikula" <jani.nikula@intel.com mailto:jani.nikula@intel.com?to=%22Jani%20Nikula%22%20%3Cjani.nikula%40intel.com%3E > wrote:
>
> We have drm_crtc_vblank_crtc() to get the struct drm_vblank_crtc pointer
> for a crtc. Use it instead of poking at dev->vblank[] directly.
>
> Cc: Jyri Sarha <jyri.sarha@iki.fi>
> Cc: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
Acked-by: Jyri Sarha <jyri.sarha@iki.fi mailto:jyri.sarha@iki.fi >
Thanks,.
Jyri
---
drivers/gpu/drm/tidss/tidss_crtc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/tidss/tidss_crtc.c b/drivers/gpu/drm/tidss/tidss_crtc.c
index 411b1a25e29c..8f81eb560b9e 100644
--- a/drivers/gpu/drm/tidss/tidss_crtc.c
+++ b/drivers/gpu/drm/tidss/tidss_crtc.c
@@ -248,8 +248,7 @@ static void tidss_crtc_atomic_enable(struct drm_crtc *crtc,
dispc_vp_enable(tidss->dispc, tcrtc->hw_videoport);
if (crtc->state->event) {
- unsigned int pipe = drm_crtc_index(crtc);
- struct drm_vblank_crtc *vblank = &ddev->vblank[pipe];
+ struct drm_vblank_crtc *vblank = drm_crtc_vblank_crtc(crtc);
vblank->time = ktime_get();
--
2.47.3
[-- Attachment #2: Type: text/html, Size: 1629 bytes --]
next prev parent reply other threads:[~2025-11-10 13:41 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-07 11:04 [PATCH 0/6] drm: avoid poking at dev->vblank[] directly Jani Nikula
2025-11-07 11:04 ` [PATCH 1/6] drm/vblank: use drm_crtc_vblank_crtc() in workers Jani Nikula
2025-11-10 9:44 ` Thomas Zimmermann
2025-11-07 11:04 ` [PATCH 2/6] drm/atomic: use drm_crtc_vblank_waitqueue() Jani Nikula
2025-11-10 9:57 ` Thomas Zimmermann
2025-11-10 12:51 ` Jani Nikula
2025-11-10 13:18 ` Thomas Zimmermann
2025-11-10 13:42 ` Jani Nikula
2025-11-07 11:04 ` [PATCH 3/6] drm/msm: " Jani Nikula
2025-11-08 17:00 ` Dmitry Baryshkov
2025-11-07 11:04 ` [PATCH 4/6] drm/tidss: use drm_crtc_vblank_crtc() Jani Nikula
2025-11-08 15:54 ` Jyri Sarha [this message]
2025-11-07 11:04 ` [PATCH 5/6] drm/vmwgfx: " Jani Nikula
2025-11-07 16:21 ` Ian Forbes
2025-11-07 11:05 ` [PATCH 6/6] drm/gma500: " Jani Nikula
2025-11-07 13:11 ` Patrik Jakobsson
2026-01-30 12:44 ` Thomas Zimmermann
2026-01-30 15:24 ` Jani Nikula
2025-11-07 12:34 ` ✓ i915.CI.BAT: success for drm: avoid poking at dev->vblank[] directly Patchwork
2025-11-08 3:40 ` ✗ i915.CI.Full: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d5bc82dc6f18adebc784df345b2a948703e3949@iki.fi \
--to=jyri.sarha@iki.fi \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox