From: Jani Nikula <jani.nikula@intel.com>
To: Thomas Zimmermann <tzimmermann@suse.de>,
Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
Cc: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
intel-xe@lists.freedesktop.org, ville.syrjala@linux.intel.com
Subject: Re: [PATCH 6/6] drm/gma500: use drm_crtc_vblank_crtc()
Date: Fri, 30 Jan 2026 17:24:04 +0200 [thread overview]
Message-ID: <ee3b272aeab7dd88d2285e9234c75f8c14d8ddad@intel.com> (raw)
In-Reply-To: <5aec1964-072c-4335-8f37-35e6efb4910e@suse.de>
On Fri, 30 Jan 2026, Thomas Zimmermann <tzimmermann@suse.de> wrote:
> This patch breaks the driver with a NULL-ptr oops on startup. This is
> because the IRQ initialization in gma_irq_install() now uses CRTCs that
> are only allocated later in psb_modeset_init(). Stack trace is below.
>
> There's a nearby comment about preserving the order of the operations,
> so I don't dare touching it. But reverting commit d930ffa5d6e8
> ("drm/gma500: use drm_crtc_vblank_crtc()") resolves the issue.
Thanks for the report. Since we're at -rc7 and there's going to be -rc8,
I think the only reasonable approach at this time is to revert [1].
BR,
Jani.
[1] https://lore.kernel.org/r/20260130151319.31264-1-jani.nikula@intel.com
--
Jani Nikula, Intel
next prev parent reply other threads:[~2026-01-30 15:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-07 11:04 [PATCH 0/6] drm: avoid poking at dev->vblank[] directly Jani Nikula
2025-11-07 11:04 ` [PATCH 1/6] drm/vblank: use drm_crtc_vblank_crtc() in workers Jani Nikula
2025-11-10 9:44 ` Thomas Zimmermann
2025-11-07 11:04 ` [PATCH 2/6] drm/atomic: use drm_crtc_vblank_waitqueue() Jani Nikula
2025-11-10 9:57 ` Thomas Zimmermann
2025-11-10 12:51 ` Jani Nikula
2025-11-10 13:18 ` Thomas Zimmermann
2025-11-10 13:42 ` Jani Nikula
2025-11-07 11:04 ` [PATCH 3/6] drm/msm: " Jani Nikula
2025-11-08 17:00 ` Dmitry Baryshkov
2025-11-07 11:04 ` [PATCH 4/6] drm/tidss: use drm_crtc_vblank_crtc() Jani Nikula
2025-11-08 15:54 ` Jyri Sarha
2025-11-07 11:04 ` [PATCH 5/6] drm/vmwgfx: " Jani Nikula
2025-11-07 16:21 ` Ian Forbes
2025-11-07 11:05 ` [PATCH 6/6] drm/gma500: " Jani Nikula
2025-11-07 13:11 ` Patrik Jakobsson
2026-01-30 12:44 ` Thomas Zimmermann
2026-01-30 15:24 ` Jani Nikula [this message]
2025-11-07 12:34 ` ✓ i915.CI.BAT: success for drm: avoid poking at dev->vblank[] directly Patchwork
2025-11-08 3:40 ` ✗ i915.CI.Full: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee3b272aeab7dd88d2285e9234c75f8c14d8ddad@intel.com \
--to=jani.nikula@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=patrik.r.jakobsson@gmail.com \
--cc=tzimmermann@suse.de \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox