Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Dave Airlie <airlied@gmail.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 3/9] drm/i915/display: fix misused comma
Date: Thu, 10 Dec 2020 17:09:22 +0200	[thread overview]
Message-ID: <X9I6Ij+8h3VaoDLt@intel.com> (raw)
In-Reply-To: <20201210041755.29088-4-airlied@gmail.com>

On Thu, Dec 10, 2020 at 02:17:49PM +1000, Dave Airlie wrote:
> From: Dave Airlie <airlied@redhat.com>
> 
> There is no need for a comma use here.
> 
> Signed-off-by: Dave Airlie <airlied@redhat.com>

Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> ---
>  drivers/gpu/drm/i915/display/intel_display.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index 62e22d832cab..79d7479beed2 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -989,7 +989,8 @@ chv_find_best_dpll(const struct intel_limit *limit,
>  	 * set to 2.  If requires to support 200Mhz refclk, we need to
>  	 * revisit this because n may not 1 anymore.
>  	 */
> -	clock.n = 1, clock.m1 = 2;
> +	clock.n = 1;
> +	clock.m1 = 2;
>  	target *= 5;	/* fast clock */
>  
>  	for (clock.p1 = limit->p1.max; clock.p1 >= limit->p1.min; clock.p1--) {
> -- 
> 2.27.0
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2020-12-10 15:09 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-10  4:17 [Intel-gfx] [RFC v2] refactor intel display a bit more Dave Airlie
2020-12-10  4:17 ` [Intel-gfx] [PATCH 1/9] drm/i915/display: move needs_modeset to an inline in header Dave Airlie
2020-12-10 15:08   ` Ville Syrjälä
2020-12-10  4:17 ` [Intel-gfx] [PATCH 2/9] drm/i915/display: move to_intel_frontbuffer to header Dave Airlie
2020-12-10 15:08   ` Ville Syrjälä
2020-12-10  4:17 ` [Intel-gfx] [PATCH 3/9] drm/i915/display: fix misused comma Dave Airlie
2020-12-10 15:09   ` Ville Syrjälä [this message]
2020-12-10  4:17 ` [Intel-gfx] [PATCH 4/9] drm/i915: refactor cursor code out of i915_display.c Dave Airlie
2020-12-10 15:06   ` Ville Syrjälä
2020-12-10 16:12     ` Jani Nikula
2020-12-10 16:17       ` Daniel Vetter
2020-12-10  4:17 ` [Intel-gfx] [PATCH 5/9] drm/i915: refactor some crtc code out of intel display Dave Airlie
2020-12-10 15:13   ` Ville Syrjälä
2020-12-10  4:17 ` [Intel-gfx] [PATCH 6/9] drm/i915: refactor pll code out into intel_dpll_legacy.c Dave Airlie
2020-12-10 15:18   ` Ville Syrjälä
2020-12-10 16:31     ` Daniel Vetter
2020-12-10  4:17 ` [Intel-gfx] [PATCH 7/9] drm/i915: split fdi code out from intel_display.c Dave Airlie
2020-12-10  4:17 ` [Intel-gfx] [PATCH 8/9] drm/i915: migrate hsw fdi code to new file Dave Airlie
2020-12-10  4:17 ` [Intel-gfx] [PATCH 9/9] drm/i915: migrate skl planes code " Dave Airlie
2020-12-10  4:32 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/9] drm/i915/display: move needs_modeset to an inline in header Patchwork
2020-12-10  4:33 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2020-12-10  4:37 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork
2020-12-10  5:02 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-12-10  7:11 ` [Intel-gfx] [RFC v2] refactor intel display a bit more Dave Airlie
2020-12-10  7:41 ` [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/9] drm/i915/display: move needs_modeset to an inline in header Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=X9I6Ij+8h3VaoDLt@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=airlied@gmail.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox