From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Dave Airlie <airlied@gmail.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 6/9] drm/i915: refactor pll code out into intel_dpll_legacy.c
Date: Thu, 10 Dec 2020 17:18:54 +0200 [thread overview]
Message-ID: <X9I8XieR98LFRNaY@intel.com> (raw)
In-Reply-To: <20201210041755.29088-7-airlied@gmail.com>
On Thu, Dec 10, 2020 at 02:17:52PM +1000, Dave Airlie wrote:
> From: Dave Airlie <airlied@redhat.com>
>
> This pulls a large chunk of the pll calculation code out of
> intel_display.c to a new file.
>
> One function makse sense to be an inline, otherwise this
> is pretty much a straight copy cover. also all the
> remaining hooks for g45 and older end up the same now.
>
> Signed-off-by: Dave Airlie <airlied@redhat.com>
> ---
> drivers/gpu/drm/i915/Makefile | 1 +
> drivers/gpu/drm/i915/display/intel_display.c | 1393 +----------------
> drivers/gpu/drm/i915/display/intel_display.h | 13 +-
> .../drm/i915/display/intel_display_types.h | 5 +
> .../gpu/drm/i915/display/intel_dpll_legacy.c | 1370 ++++++++++++++++
> 5 files changed, 1398 insertions(+), 1384 deletions(-)
> create mode 100644 drivers/gpu/drm/i915/display/intel_dpll_legacy.c
>
<snip>
> +static int hsw_crtc_compute_clock(struct intel_crtc *crtc,
> + struct intel_crtc_state *crtc_state)
> +{
> + struct drm_i915_private *dev_priv = to_i915(crtc->base.dev);
> + struct intel_atomic_state *state =
> + to_intel_atomic_state(crtc_state->uapi.state);
> +
> + if (!intel_crtc_has_type(crtc_state, INTEL_OUTPUT_DSI) ||
> + INTEL_GEN(dev_priv) >= 11) {
> + struct intel_encoder *encoder =
> + intel_get_crtc_new_encoder(state, crtc_state);
> +
> + if (!intel_reserve_shared_dplls(state, crtc, encoder)) {
> + drm_dbg_kms(&dev_priv->drm,
> + "failed to find PLL for pipe %c\n",
> + pipe_name(crtc->pipe));
> + return -EINVAL;
> + }
> + }
> +
> + return 0;
> +}
If you're moving this then the "legacy" in the fine name is just
wrong. I guess just call it intel_dpll.c if we lack a better idea?
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-12-10 15:18 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-10 4:17 [Intel-gfx] [RFC v2] refactor intel display a bit more Dave Airlie
2020-12-10 4:17 ` [Intel-gfx] [PATCH 1/9] drm/i915/display: move needs_modeset to an inline in header Dave Airlie
2020-12-10 15:08 ` Ville Syrjälä
2020-12-10 4:17 ` [Intel-gfx] [PATCH 2/9] drm/i915/display: move to_intel_frontbuffer to header Dave Airlie
2020-12-10 15:08 ` Ville Syrjälä
2020-12-10 4:17 ` [Intel-gfx] [PATCH 3/9] drm/i915/display: fix misused comma Dave Airlie
2020-12-10 15:09 ` Ville Syrjälä
2020-12-10 4:17 ` [Intel-gfx] [PATCH 4/9] drm/i915: refactor cursor code out of i915_display.c Dave Airlie
2020-12-10 15:06 ` Ville Syrjälä
2020-12-10 16:12 ` Jani Nikula
2020-12-10 16:17 ` Daniel Vetter
2020-12-10 4:17 ` [Intel-gfx] [PATCH 5/9] drm/i915: refactor some crtc code out of intel display Dave Airlie
2020-12-10 15:13 ` Ville Syrjälä
2020-12-10 4:17 ` [Intel-gfx] [PATCH 6/9] drm/i915: refactor pll code out into intel_dpll_legacy.c Dave Airlie
2020-12-10 15:18 ` Ville Syrjälä [this message]
2020-12-10 16:31 ` Daniel Vetter
2020-12-10 4:17 ` [Intel-gfx] [PATCH 7/9] drm/i915: split fdi code out from intel_display.c Dave Airlie
2020-12-10 4:17 ` [Intel-gfx] [PATCH 8/9] drm/i915: migrate hsw fdi code to new file Dave Airlie
2020-12-10 4:17 ` [Intel-gfx] [PATCH 9/9] drm/i915: migrate skl planes code " Dave Airlie
2020-12-10 4:32 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/9] drm/i915/display: move needs_modeset to an inline in header Patchwork
2020-12-10 4:33 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2020-12-10 4:37 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork
2020-12-10 5:02 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-12-10 7:11 ` [Intel-gfx] [RFC v2] refactor intel display a bit more Dave Airlie
2020-12-10 7:41 ` [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/9] drm/i915/display: move needs_modeset to an inline in header Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X9I8XieR98LFRNaY@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=airlied@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox