* [Intel-gfx] [PATCH] drm/i915: update DSC feature flag handling during device init
@ 2022-10-11 9:30 Vinod Govindapillai
2022-10-11 11:01 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
2022-11-01 13:16 ` [Intel-gfx] [PATCH] " Lisovskiy, Stanislav
0 siblings, 2 replies; 3+ messages in thread
From: Vinod Govindapillai @ 2022-10-11 9:30 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula, ville.syrjala, lucas.demarchi
DSC feature information is no longer part of the DFSM register in
some display generations.
Bspec:50075
Signed-off-by: Vinod Govindapillai <vinod.govindapillai@intel.com>
---
drivers/gpu/drm/i915/intel_device_info.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_device_info.c b/drivers/gpu/drm/i915/intel_device_info.c
index 908ec241fe71..17d2e3293892 100644
--- a/drivers/gpu/drm/i915/intel_device_info.c
+++ b/drivers/gpu/drm/i915/intel_device_info.c
@@ -480,7 +480,7 @@ void intel_device_info_runtime_init(struct drm_i915_private *dev_priv)
if (DISPLAY_VER(dev_priv) >= 11 && (dfsm & ICL_DFSM_DMC_DISABLE))
runtime->has_dmc = 0;
- if (DISPLAY_VER(dev_priv) >= 10 &&
+ if (IS_DISPLAY_VER(dev_priv, 10, 12) &&
(dfsm & GLK_DFSM_DISPLAY_DSC_DISABLE))
runtime->has_dsc = 0;
}
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: update DSC feature flag handling during device init
2022-10-11 9:30 [Intel-gfx] [PATCH] drm/i915: update DSC feature flag handling during device init Vinod Govindapillai
@ 2022-10-11 11:01 ` Patchwork
2022-11-01 13:16 ` [Intel-gfx] [PATCH] " Lisovskiy, Stanislav
1 sibling, 0 replies; 3+ messages in thread
From: Patchwork @ 2022-10-11 11:01 UTC (permalink / raw)
To: Vinod Govindapillai; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 7440 bytes --]
== Series Details ==
Series: drm/i915: update DSC feature flag handling during device init
URL : https://patchwork.freedesktop.org/series/109570/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12231 -> Patchwork_109570v1
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_109570v1 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_109570v1, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109570v1/index.html
Participating hosts (46 -> 45)
------------------------------
Additional (1): bat-atsm-1
Missing (2): fi-ctg-p8600 fi-tgl-dsi
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_109570v1:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@gt_timelines:
- bat-dg1-5: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12231/bat-dg1-5/igt@i915_selftest@live@gt_timelines.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109570v1/bat-dg1-5/igt@i915_selftest@live@gt_timelines.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@kms_pipe_crc_basic@suspend-read-crc@pipe-d-dp-3:
- {bat-dg2-9}: [PASS][3] -> [DMESG-WARN][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12231/bat-dg2-9/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-d-dp-3.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109570v1/bat-dg2-9/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-d-dp-3.html
Known issues
------------
Here are the changes found in Patchwork_109570v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live@execlists:
- fi-bdw-gvtdvm: [PASS][5] -> [INCOMPLETE][6] ([i915#2940])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12231/fi-bdw-gvtdvm/igt@i915_selftest@live@execlists.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109570v1/fi-bdw-gvtdvm/igt@i915_selftest@live@execlists.html
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-ivb-3770: NOTRUN -> [SKIP][7] ([fdo#109271] / [fdo#111827])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109570v1/fi-ivb-3770/igt@kms_chamelium@common-hpd-after-suspend.html
- fi-hsw-g3258: NOTRUN -> [SKIP][8] ([fdo#109271] / [fdo#111827])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109570v1/fi-hsw-g3258/igt@kms_chamelium@common-hpd-after-suspend.html
- fi-bdw-5557u: NOTRUN -> [SKIP][9] ([fdo#109271] / [fdo#111827])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109570v1/fi-bdw-5557u/igt@kms_chamelium@common-hpd-after-suspend.html
* igt@runner@aborted:
- fi-bdw-gvtdvm: NOTRUN -> [FAIL][10] ([i915#4312])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109570v1/fi-bdw-gvtdvm/igt@runner@aborted.html
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s0@smem:
- {bat-rplp-1}: [DMESG-WARN][11] ([i915#2867]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12231/bat-rplp-1/igt@gem_exec_suspend@basic-s0@smem.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109570v1/bat-rplp-1/igt@gem_exec_suspend@basic-s0@smem.html
- {bat-adlm-1}: [DMESG-WARN][13] ([i915#2867]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12231/bat-adlm-1/igt@gem_exec_suspend@basic-s0@smem.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109570v1/bat-adlm-1/igt@gem_exec_suspend@basic-s0@smem.html
* igt@i915_selftest@live@gt_pm:
- {bat-rpls-2}: [DMESG-FAIL][15] ([i915#4258]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12231/bat-rpls-2/igt@i915_selftest@live@gt_pm.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109570v1/bat-rpls-2/igt@i915_selftest@live@gt_pm.html
* igt@i915_selftest@live@hangcheck:
- fi-ivb-3770: [INCOMPLETE][17] ([i915#7122]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12231/fi-ivb-3770/igt@i915_selftest@live@hangcheck.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109570v1/fi-ivb-3770/igt@i915_selftest@live@hangcheck.html
- fi-hsw-g3258: [INCOMPLETE][19] ([i915#3303] / [i915#4785]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12231/fi-hsw-g3258/igt@i915_selftest@live@hangcheck.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109570v1/fi-hsw-g3258/igt@i915_selftest@live@hangcheck.html
* igt@i915_suspend@basic-s3-without-i915:
- fi-bdw-5557u: [INCOMPLETE][21] ([i915#146] / [i915#6712]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12231/fi-bdw-5557u/igt@i915_suspend@basic-s3-without-i915.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109570v1/fi-bdw-5557u/igt@i915_suspend@basic-s3-without-i915.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#146]: https://gitlab.freedesktop.org/drm/intel/issues/146
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#2940]: https://gitlab.freedesktop.org/drm/intel/issues/2940
[i915#3303]: https://gitlab.freedesktop.org/drm/intel/issues/3303
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4258]: https://gitlab.freedesktop.org/drm/intel/issues/4258
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4785]: https://gitlab.freedesktop.org/drm/intel/issues/4785
[i915#5278]: https://gitlab.freedesktop.org/drm/intel/issues/5278
[i915#6712]: https://gitlab.freedesktop.org/drm/intel/issues/6712
[i915#6818]: https://gitlab.freedesktop.org/drm/intel/issues/6818
[i915#7029]: https://gitlab.freedesktop.org/drm/intel/issues/7029
[i915#7030]: https://gitlab.freedesktop.org/drm/intel/issues/7030
[i915#7031]: https://gitlab.freedesktop.org/drm/intel/issues/7031
[i915#7122]: https://gitlab.freedesktop.org/drm/intel/issues/7122
Build changes
-------------
* Linux: CI_DRM_12231 -> Patchwork_109570v1
CI-20190529: 20190529
CI_DRM_12231: bb84c1baa34eed834400e9a3cf9642840be002e1 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7007: 39a979fb4453c557022f0477c609afe10a049e48 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_109570v1: bb84c1baa34eed834400e9a3cf9642840be002e1 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
db19f9e8b0aa drm/i915: update DSC feature flag handling during device init
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_109570v1/index.html
[-- Attachment #2: Type: text/html, Size: 8081 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: update DSC feature flag handling during device init
2022-10-11 9:30 [Intel-gfx] [PATCH] drm/i915: update DSC feature flag handling during device init Vinod Govindapillai
2022-10-11 11:01 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
@ 2022-11-01 13:16 ` Lisovskiy, Stanislav
1 sibling, 0 replies; 3+ messages in thread
From: Lisovskiy, Stanislav @ 2022-11-01 13:16 UTC (permalink / raw)
To: Vinod Govindapillai; +Cc: jani.nikula, lucas.demarchi, intel-gfx, ville.syrjala
On Tue, Oct 11, 2022 at 12:30:48PM +0300, Vinod Govindapillai wrote:
> DSC feature information is no longer part of the DFSM register in
> some display generations.
Reviewed-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
>
> Bspec:50075
> Signed-off-by: Vinod Govindapillai <vinod.govindapillai@intel.com>
> ---
> drivers/gpu/drm/i915/intel_device_info.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_device_info.c b/drivers/gpu/drm/i915/intel_device_info.c
> index 908ec241fe71..17d2e3293892 100644
> --- a/drivers/gpu/drm/i915/intel_device_info.c
> +++ b/drivers/gpu/drm/i915/intel_device_info.c
> @@ -480,7 +480,7 @@ void intel_device_info_runtime_init(struct drm_i915_private *dev_priv)
> if (DISPLAY_VER(dev_priv) >= 11 && (dfsm & ICL_DFSM_DMC_DISABLE))
> runtime->has_dmc = 0;
>
> - if (DISPLAY_VER(dev_priv) >= 10 &&
> + if (IS_DISPLAY_VER(dev_priv, 10, 12) &&
> (dfsm & GLK_DFSM_DISPLAY_DSC_DISABLE))
> runtime->has_dsc = 0;
> }
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-01 13:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-11 9:30 [Intel-gfx] [PATCH] drm/i915: update DSC feature flag handling during device init Vinod Govindapillai
2022-10-11 11:01 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
2022-11-01 13:16 ` [Intel-gfx] [PATCH] " Lisovskiy, Stanislav
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox