* [Intel-gfx] [PATCH] drm/i915: Remove CONFIG_PM dependency from RC6.
@ 2022-11-30 2:29 Rodrigo Vivi
2022-11-30 3:19 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Rodrigo Vivi @ 2022-11-30 2:29 UTC (permalink / raw)
To: intel-gfx; +Cc: Paul Cercueil, Rodrigo Vivi
RC6 is a sleep state that doesn't depend on the cpu sleep,
or any of the APM or ACPI or anything related to the
CONFIG_PM.
A long time ago we have removed the module parameter
that allows the RC6 disablement. We want that feature enabled
everywhere. However, for some reason this CONFIG_PM was long
forgotten behind.
If we end up needing knobs to disable RC6 we should create
individual ones, rather than relying on this master one.
Cc: Paul Cercueil <paul@crapouillou.net>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c b/drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c
index cf71305ad586..77327ede18ad 100644
--- a/drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c
+++ b/drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c
@@ -164,7 +164,6 @@ sysfs_gt_attribute_r_func(struct kobject *kobj, struct attribute *attr,
NULL); \
INTEL_GT_ATTR_RO(_name)
-#ifdef CONFIG_PM
static u32 get_residency(struct intel_gt *gt, enum intel_rc6_res_type id)
{
intel_wakeref_t wakeref;
@@ -329,11 +328,6 @@ static void intel_sysfs_rc6_init(struct intel_gt *gt, struct kobject *kobj)
gt->info.id, ERR_PTR(ret));
}
}
-#else
-static void intel_sysfs_rc6_init(struct intel_gt *gt, struct kobject *kobj)
-{
-}
-#endif /* CONFIG_PM */
static u32 __act_freq_mhz_show(struct intel_gt *gt)
{
--
2.38.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Remove CONFIG_PM dependency from RC6. 2022-11-30 2:29 [Intel-gfx] [PATCH] drm/i915: Remove CONFIG_PM dependency from RC6 Rodrigo Vivi @ 2022-11-30 3:19 ` Patchwork 2022-11-30 11:47 ` [Intel-gfx] [PATCH] " Tvrtko Ursulin 2022-11-30 12:41 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for " Patchwork 2 siblings, 0 replies; 7+ messages in thread From: Patchwork @ 2022-11-30 3:19 UTC (permalink / raw) To: Rodrigo Vivi; +Cc: intel-gfx [-- Attachment #1: Type: text/plain, Size: 8842 bytes --] == Series Details == Series: drm/i915: Remove CONFIG_PM dependency from RC6. URL : https://patchwork.freedesktop.org/series/111465/ State : success == Summary == CI Bug Log - changes from CI_DRM_12449 -> Patchwork_111465v1 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/index.html Participating hosts (36 -> 36) ------------------------------ Additional (1): bat-dg1-6 Missing (1): bat-atsm-1 Known issues ------------ Here are the changes found in Patchwork_111465v1 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_lmem_swapping@basic: - fi-apl-guc: NOTRUN -> [SKIP][1] ([fdo#109271] / [i915#4613]) +3 similar issues [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/fi-apl-guc/igt@gem_lmem_swapping@basic.html * igt@gem_mmap@basic: - bat-dg1-6: NOTRUN -> [SKIP][2] ([i915#4083]) [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/bat-dg1-6/igt@gem_mmap@basic.html * igt@gem_render_tiled_blits@basic: - bat-dg1-6: NOTRUN -> [SKIP][3] ([i915#4079]) +1 similar issue [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/bat-dg1-6/igt@gem_render_tiled_blits@basic.html * igt@gem_tiled_fence_blits@basic: - bat-dg1-6: NOTRUN -> [SKIP][4] ([i915#4077]) +2 similar issues [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/bat-dg1-6/igt@gem_tiled_fence_blits@basic.html * igt@i915_pm_backlight@basic-brightness: - bat-dg1-6: NOTRUN -> [SKIP][5] ([i915#7561]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/bat-dg1-6/igt@i915_pm_backlight@basic-brightness.html * igt@i915_pm_rps@basic-api: - bat-dg1-6: NOTRUN -> [SKIP][6] ([i915#6621]) [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/bat-dg1-6/igt@i915_pm_rps@basic-api.html * igt@i915_selftest@live@gt_lrc: - bat-adlp-4: [PASS][7] -> [INCOMPLETE][8] ([i915#4983]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12449/bat-adlp-4/igt@i915_selftest@live@gt_lrc.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/bat-adlp-4/igt@i915_selftest@live@gt_lrc.html * igt@kms_addfb_basic@basic-y-tiled-legacy: - bat-dg1-6: NOTRUN -> [SKIP][9] ([i915#4215]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/bat-dg1-6/igt@kms_addfb_basic@basic-y-tiled-legacy.html * igt@kms_addfb_basic@tile-pitch-mismatch: - bat-dg1-6: NOTRUN -> [SKIP][10] ([i915#4212]) +7 similar issues [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/bat-dg1-6/igt@kms_addfb_basic@tile-pitch-mismatch.html * igt@kms_chamelium@hdmi-crc-fast: - fi-apl-guc: NOTRUN -> [SKIP][11] ([fdo#109271] / [fdo#111827]) +8 similar issues [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/fi-apl-guc/igt@kms_chamelium@hdmi-crc-fast.html - bat-dg1-6: NOTRUN -> [SKIP][12] ([fdo#111827]) +8 similar issues [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/bat-dg1-6/igt@kms_chamelium@hdmi-crc-fast.html * igt@kms_cursor_legacy@basic-busy-flip-before-cursor: - bat-dg1-6: NOTRUN -> [SKIP][13] ([i915#4103] / [i915#4213]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/bat-dg1-6/igt@kms_cursor_legacy@basic-busy-flip-before-cursor.html * igt@kms_force_connector_basic@force-connector-state: - fi-apl-guc: NOTRUN -> [SKIP][14] ([fdo#109271]) +11 similar issues [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/fi-apl-guc/igt@kms_force_connector_basic@force-connector-state.html * igt@kms_force_connector_basic@force-load-detect: - bat-dg1-6: NOTRUN -> [SKIP][15] ([fdo#109285]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/bat-dg1-6/igt@kms_force_connector_basic@force-load-detect.html * igt@kms_psr@sprite_plane_onoff: - bat-dg1-6: NOTRUN -> [SKIP][16] ([i915#1072] / [i915#4078]) +3 similar issues [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/bat-dg1-6/igt@kms_psr@sprite_plane_onoff.html * igt@kms_setmode@basic-clone-single-crtc: - bat-dg1-6: NOTRUN -> [SKIP][17] ([i915#3555]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/bat-dg1-6/igt@kms_setmode@basic-clone-single-crtc.html * igt@prime_vgem@basic-gtt: - bat-dg1-6: NOTRUN -> [SKIP][18] ([i915#3708] / [i915#4077]) +1 similar issue [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/bat-dg1-6/igt@prime_vgem@basic-gtt.html * igt@prime_vgem@basic-read: - bat-dg1-6: NOTRUN -> [SKIP][19] ([i915#3708]) +3 similar issues [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/bat-dg1-6/igt@prime_vgem@basic-read.html * igt@prime_vgem@basic-userptr: - bat-dg1-6: NOTRUN -> [SKIP][20] ([i915#3708] / [i915#4873]) [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/bat-dg1-6/igt@prime_vgem@basic-userptr.html #### Possible fixes #### * igt@gem_render_tiled_blits@basic: - fi-apl-guc: [INCOMPLETE][21] ([i915#7056]) -> [PASS][22] [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12449/fi-apl-guc/igt@gem_render_tiled_blits@basic.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/fi-apl-guc/igt@gem_render_tiled_blits@basic.html * igt@i915_selftest@live@gt_pm: - {bat-adln-1}: [DMESG-FAIL][23] ([i915#4258]) -> [PASS][24] [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12449/bat-adln-1/igt@i915_selftest@live@gt_pm.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/bat-adln-1/igt@i915_selftest@live@gt_pm.html #### Warnings #### * igt@i915_suspend@basic-s3-without-i915: - fi-rkl-11600: [FAIL][25] ([fdo#103375]) -> [INCOMPLETE][26] ([i915#4817]) [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12449/fi-rkl-11600/igt@i915_suspend@basic-s3-without-i915.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/fi-rkl-11600/igt@i915_suspend@basic-s3-without-i915.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072 [i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867 [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555 [i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708 [i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077 [i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078 [i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079 [i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083 [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103 [i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212 [i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213 [i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215 [i915#4258]: https://gitlab.freedesktop.org/drm/intel/issues/4258 [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613 [i915#4817]: https://gitlab.freedesktop.org/drm/intel/issues/4817 [i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873 [i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983 [i915#6434]: https://gitlab.freedesktop.org/drm/intel/issues/6434 [i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621 [i915#7056]: https://gitlab.freedesktop.org/drm/intel/issues/7056 [i915#7346]: https://gitlab.freedesktop.org/drm/intel/issues/7346 [i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561 Build changes ------------- * Linux: CI_DRM_12449 -> Patchwork_111465v1 CI-20190529: 20190529 CI_DRM_12449: bd21d688743bbb6b97f7591203f388af4a018c6b @ git://anongit.freedesktop.org/gfx-ci/linux IGT_7075: ae0ad0ffa147445cdf9d33c96a018f5a8b21a5ee @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git Patchwork_111465v1: bd21d688743bbb6b97f7591203f388af4a018c6b @ git://anongit.freedesktop.org/gfx-ci/linux ### Linux commits 9be54f778375 drm/i915: Remove CONFIG_PM dependency from RC6. == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/index.html [-- Attachment #2: Type: text/html, Size: 10192 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Remove CONFIG_PM dependency from RC6. 2022-11-30 2:29 [Intel-gfx] [PATCH] drm/i915: Remove CONFIG_PM dependency from RC6 Rodrigo Vivi 2022-11-30 3:19 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork @ 2022-11-30 11:47 ` Tvrtko Ursulin 2022-11-30 13:37 ` Vivi, Rodrigo 2022-11-30 12:41 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for " Patchwork 2 siblings, 1 reply; 7+ messages in thread From: Tvrtko Ursulin @ 2022-11-30 11:47 UTC (permalink / raw) To: Rodrigo Vivi, intel-gfx; +Cc: Paul Cercueil On 30/11/2022 02:29, Rodrigo Vivi wrote: > RC6 is a sleep state that doesn't depend on the cpu sleep, > or any of the APM or ACPI or anything related to the > CONFIG_PM. > > A long time ago we have removed the module parameter > that allows the RC6 disablement. We want that feature enabled > everywhere. However, for some reason this CONFIG_PM was long > forgotten behind. > > If we end up needing knobs to disable RC6 we should create > individual ones, rather than relying on this master one. Digging in history shows 5ab3633d6907 ("drm/i915: make rc6 in sysfs functions conditional") and then it appears the issue could still be present, since we still use power_group_name which is NULL when !CONFIG_PM. $ ls -l /sys/class/drm/card0/power/ total 0 -rw-r--r-- 1 root root 4096 Nov 30 11:45 async -rw-r--r-- 1 root root 4096 Nov 30 11:45 autosuspend_delay_ms -rw-r--r-- 1 root root 4096 Nov 30 11:45 control -r--r--r-- 1 root root 4096 Nov 30 11:45 rc6_enable -r--r--r-- 1 root root 4096 Nov 30 11:45 rc6_residency_ms -r--r--r-- 1 root root 4096 Nov 30 11:45 runtime_active_kids -r--r--r-- 1 root root 4096 Nov 30 11:45 runtime_active_time -r--r--r-- 1 root root 4096 Nov 30 11:45 runtime_enabled -r--r--r-- 1 root root 4096 Nov 30 11:45 runtime_status -r--r--r-- 1 root root 4096 Nov 30 11:45 runtime_suspended_time -r--r--r-- 1 root root 4096 Nov 30 11:45 runtime_usage Other than rc6 entries I guess come from somewhere else but I haven't looked from where exactly. Regards, Tvrtko > Cc: Paul Cercueil <paul@crapouillou.net> > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > --- > drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c b/drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c > index cf71305ad586..77327ede18ad 100644 > --- a/drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c > +++ b/drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c > @@ -164,7 +164,6 @@ sysfs_gt_attribute_r_func(struct kobject *kobj, struct attribute *attr, > NULL); \ > INTEL_GT_ATTR_RO(_name) > > -#ifdef CONFIG_PM > static u32 get_residency(struct intel_gt *gt, enum intel_rc6_res_type id) > { > intel_wakeref_t wakeref; > @@ -329,11 +328,6 @@ static void intel_sysfs_rc6_init(struct intel_gt *gt, struct kobject *kobj) > gt->info.id, ERR_PTR(ret)); > } > } > -#else > -static void intel_sysfs_rc6_init(struct intel_gt *gt, struct kobject *kobj) > -{ > -} > -#endif /* CONFIG_PM */ > > static u32 __act_freq_mhz_show(struct intel_gt *gt) > { ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Remove CONFIG_PM dependency from RC6. 2022-11-30 11:47 ` [Intel-gfx] [PATCH] " Tvrtko Ursulin @ 2022-11-30 13:37 ` Vivi, Rodrigo 2022-12-07 14:35 ` Paul Cercueil 0 siblings, 1 reply; 7+ messages in thread From: Vivi, Rodrigo @ 2022-11-30 13:37 UTC (permalink / raw) To: tvrtko.ursulin@linux.intel.com, intel-gfx@lists.freedesktop.org Cc: paul@crapouillou.net On Wed, 2022-11-30 at 11:47 +0000, Tvrtko Ursulin wrote: > > On 30/11/2022 02:29, Rodrigo Vivi wrote: > > RC6 is a sleep state that doesn't depend on the cpu sleep, > > or any of the APM or ACPI or anything related to the > > CONFIG_PM. > > > > A long time ago we have removed the module parameter > > that allows the RC6 disablement. We want that feature enabled > > everywhere. However, for some reason this CONFIG_PM was long > > forgotten behind. > > > > If we end up needing knobs to disable RC6 we should create > > individual ones, rather than relying on this master one. > > Digging in history shows 5ab3633d6907 ("drm/i915: make rc6 in sysfs > functions conditional") and then it appears the issue could still be > present, since we still use power_group_name which is NULL when > !CONFIG_PM. oh, indeed! So, we should probably go with Paul's proposal: https://lists.freedesktop.org/archives/intel-gfx/2022-November/311569.html > > $ ls -l /sys/class/drm/card0/power/ > total 0 > -rw-r--r-- 1 root root 4096 Nov 30 11:45 async > -rw-r--r-- 1 root root 4096 Nov 30 11:45 autosuspend_delay_ms > -rw-r--r-- 1 root root 4096 Nov 30 11:45 control > -r--r--r-- 1 root root 4096 Nov 30 11:45 rc6_enable > -r--r--r-- 1 root root 4096 Nov 30 11:45 rc6_residency_ms > -r--r--r-- 1 root root 4096 Nov 30 11:45 runtime_active_kids > -r--r--r-- 1 root root 4096 Nov 30 11:45 runtime_active_time > -r--r--r-- 1 root root 4096 Nov 30 11:45 runtime_enabled > -r--r--r-- 1 root root 4096 Nov 30 11:45 runtime_status > -r--r--r-- 1 root root 4096 Nov 30 11:45 runtime_suspended_time > -r--r--r-- 1 root root 4096 Nov 30 11:45 runtime_usage > > Other than rc6 entries I guess come from somewhere else but I haven't > looked from where exactly. Ouch! Everything else here comes from the pci's pm_runtime. Probably our bad decision was to add rc6 to it. But we do need to stick to that. > > Regards, > > Tvrtko > > > Cc: Paul Cercueil <paul@crapouillou.net> > > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > > --- > > drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c | 6 ------ > > 1 file changed, 6 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c > > b/drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c > > index cf71305ad586..77327ede18ad 100644 > > --- a/drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c > > +++ b/drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c > > @@ -164,7 +164,6 @@ sysfs_gt_attribute_r_func(struct kobject *kobj, > > struct attribute *attr, > > > > NULL); \ > > INTEL_GT_ATTR_RO(_name) > > > > -#ifdef CONFIG_PM > > static u32 get_residency(struct intel_gt *gt, enum > > intel_rc6_res_type id) > > { > > intel_wakeref_t wakeref; > > @@ -329,11 +328,6 @@ static void intel_sysfs_rc6_init(struct > > intel_gt *gt, struct kobject *kobj) > > gt->info.id, ERR_PTR(ret)); > > } > > } > > -#else > > -static void intel_sysfs_rc6_init(struct intel_gt *gt, struct > > kobject *kobj) > > -{ > > -} > > -#endif /* CONFIG_PM */ > > > > static u32 __act_freq_mhz_show(struct intel_gt *gt) > > { ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Remove CONFIG_PM dependency from RC6. 2022-11-30 13:37 ` Vivi, Rodrigo @ 2022-12-07 14:35 ` Paul Cercueil 2022-12-07 15:58 ` Rodrigo Vivi 0 siblings, 1 reply; 7+ messages in thread From: Paul Cercueil @ 2022-12-07 14:35 UTC (permalink / raw) To: Vivi, Rodrigo, tvrtko.ursulin@linux.intel.com, intel-gfx@lists.freedesktop.org Hi Rodrigo, Le mercredi 30 novembre 2022 à 13:37 +0000, Vivi, Rodrigo a écrit : > On Wed, 2022-11-30 at 11:47 +0000, Tvrtko Ursulin wrote: > > > > On 30/11/2022 02:29, Rodrigo Vivi wrote: > > > RC6 is a sleep state that doesn't depend on the cpu sleep, > > > or any of the APM or ACPI or anything related to the > > > CONFIG_PM. > > > > > > A long time ago we have removed the module parameter > > > that allows the RC6 disablement. We want that feature enabled > > > everywhere. However, for some reason this CONFIG_PM was long > > > forgotten behind. > > > > > > If we end up needing knobs to disable RC6 we should create > > > individual ones, rather than relying on this master one. > > > > Digging in history shows 5ab3633d6907 ("drm/i915: make rc6 in sysfs > > functions conditional") and then it appears the issue could still > > be > > present, since we still use power_group_name which is NULL when > > !CONFIG_PM. > > oh, indeed! > So, we should probably go with Paul's proposal: > https://lists.freedesktop.org/archives/intel-gfx/2022-November/311569.html Could you ack it then? Or is there something to change? Cheers, -Paul > > > > $ ls -l /sys/class/drm/card0/power/ > > total 0 > > -rw-r--r-- 1 root root 4096 Nov 30 11:45 async > > -rw-r--r-- 1 root root 4096 Nov 30 11:45 autosuspend_delay_ms > > -rw-r--r-- 1 root root 4096 Nov 30 11:45 control > > -r--r--r-- 1 root root 4096 Nov 30 11:45 rc6_enable > > -r--r--r-- 1 root root 4096 Nov 30 11:45 rc6_residency_ms > > -r--r--r-- 1 root root 4096 Nov 30 11:45 runtime_active_kids > > -r--r--r-- 1 root root 4096 Nov 30 11:45 runtime_active_time > > -r--r--r-- 1 root root 4096 Nov 30 11:45 runtime_enabled > > -r--r--r-- 1 root root 4096 Nov 30 11:45 runtime_status > > -r--r--r-- 1 root root 4096 Nov 30 11:45 runtime_suspended_time > > -r--r--r-- 1 root root 4096 Nov 30 11:45 runtime_usage > > > > Other than rc6 entries I guess come from somewhere else but I > > haven't > > looked from where exactly. > > > Ouch! Everything else here comes from the pci's pm_runtime. > Probably our bad decision was to add rc6 to it. > But we do need to stick to that. > > > > > > Regards, > > > > Tvrtko > > > > > Cc: Paul Cercueil <paul@crapouillou.net> > > > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > > > --- > > > drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c | 6 ------ > > > 1 file changed, 6 deletions(-) > > > > > > diff --git a/drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c > > > b/drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c > > > index cf71305ad586..77327ede18ad 100644 > > > --- a/drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c > > > +++ b/drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c > > > @@ -164,7 +164,6 @@ sysfs_gt_attribute_r_func(struct kobject > > > *kobj, > > > struct attribute *attr, > > > > > > NULL); \ > > > INTEL_GT_ATTR_RO(_name) > > > > > > -#ifdef CONFIG_PM > > > static u32 get_residency(struct intel_gt *gt, enum > > > intel_rc6_res_type id) > > > { > > > intel_wakeref_t wakeref; > > > @@ -329,11 +328,6 @@ static void intel_sysfs_rc6_init(struct > > > intel_gt *gt, struct kobject *kobj) > > > gt->info.id, ERR_PTR(ret)); > > > } > > > } > > > -#else > > > -static void intel_sysfs_rc6_init(struct intel_gt *gt, struct > > > kobject *kobj) > > > -{ > > > -} > > > -#endif /* CONFIG_PM */ > > > > > > static u32 __act_freq_mhz_show(struct intel_gt *gt) > > > { > > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Remove CONFIG_PM dependency from RC6. 2022-12-07 14:35 ` Paul Cercueil @ 2022-12-07 15:58 ` Rodrigo Vivi 0 siblings, 0 replies; 7+ messages in thread From: Rodrigo Vivi @ 2022-12-07 15:58 UTC (permalink / raw) To: Paul Cercueil; +Cc: intel-gfx@lists.freedesktop.org On Wed, Dec 07, 2022 at 02:35:37PM +0000, Paul Cercueil wrote: > Hi Rodrigo, > > Le mercredi 30 novembre 2022 à 13:37 +0000, Vivi, Rodrigo a écrit : > > On Wed, 2022-11-30 at 11:47 +0000, Tvrtko Ursulin wrote: > > > > > > On 30/11/2022 02:29, Rodrigo Vivi wrote: > > > > RC6 is a sleep state that doesn't depend on the cpu sleep, > > > > or any of the APM or ACPI or anything related to the > > > > CONFIG_PM. > > > > > > > > A long time ago we have removed the module parameter > > > > that allows the RC6 disablement. We want that feature enabled > > > > everywhere. However, for some reason this CONFIG_PM was long > > > > forgotten behind. > > > > > > > > If we end up needing knobs to disable RC6 we should create > > > > individual ones, rather than relying on this master one. > > > > > > Digging in history shows 5ab3633d6907 ("drm/i915: make rc6 in sysfs > > > functions conditional") and then it appears the issue could still > > > be > > > present, since we still use power_group_name which is NULL when > > > !CONFIG_PM. > > > > oh, indeed! > > So, we should probably go with Paul's proposal: > > https://lists.freedesktop.org/archives/intel-gfx/2022-November/311569.html > > Could you ack it then? Or is there something to change? I had just added my rv-b to your patch there. Also, feel free to use my acked-by to merge through drm-misc or any other branch. We will catch this up later to our drm-intel branches with some backmerge. Thanks for the clean up. > > Cheers, > -Paul > > > > > > > $ ls -l /sys/class/drm/card0/power/ > > > total 0 > > > -rw-r--r-- 1 root root 4096 Nov 30 11:45 async > > > -rw-r--r-- 1 root root 4096 Nov 30 11:45 autosuspend_delay_ms > > > -rw-r--r-- 1 root root 4096 Nov 30 11:45 control > > > -r--r--r-- 1 root root 4096 Nov 30 11:45 rc6_enable > > > -r--r--r-- 1 root root 4096 Nov 30 11:45 rc6_residency_ms > > > -r--r--r-- 1 root root 4096 Nov 30 11:45 runtime_active_kids > > > -r--r--r-- 1 root root 4096 Nov 30 11:45 runtime_active_time > > > -r--r--r-- 1 root root 4096 Nov 30 11:45 runtime_enabled > > > -r--r--r-- 1 root root 4096 Nov 30 11:45 runtime_status > > > -r--r--r-- 1 root root 4096 Nov 30 11:45 runtime_suspended_time > > > -r--r--r-- 1 root root 4096 Nov 30 11:45 runtime_usage > > > > > > Other than rc6 entries I guess come from somewhere else but I > > > haven't > > > looked from where exactly. > > > > > > Ouch! Everything else here comes from the pci's pm_runtime. > > Probably our bad decision was to add rc6 to it. > > But we do need to stick to that. > > > > > > > > > > Regards, > > > > > > Tvrtko > > > > > > > Cc: Paul Cercueil <paul@crapouillou.net> > > > > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > > > > --- > > > > drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c | 6 ------ > > > > 1 file changed, 6 deletions(-) > > > > > > > > diff --git a/drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c > > > > b/drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c > > > > index cf71305ad586..77327ede18ad 100644 > > > > --- a/drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c > > > > +++ b/drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c > > > > @@ -164,7 +164,6 @@ sysfs_gt_attribute_r_func(struct kobject > > > > *kobj, > > > > struct attribute *attr, > > > > > > > > NULL); \ > > > > INTEL_GT_ATTR_RO(_name) > > > > > > > > -#ifdef CONFIG_PM > > > > static u32 get_residency(struct intel_gt *gt, enum > > > > intel_rc6_res_type id) > > > > { > > > > intel_wakeref_t wakeref; > > > > @@ -329,11 +328,6 @@ static void intel_sysfs_rc6_init(struct > > > > intel_gt *gt, struct kobject *kobj) > > > > gt->info.id, ERR_PTR(ret)); > > > > } > > > > } > > > > -#else > > > > -static void intel_sysfs_rc6_init(struct intel_gt *gt, struct > > > > kobject *kobj) > > > > -{ > > > > -} > > > > -#endif /* CONFIG_PM */ > > > > > > > > static u32 __act_freq_mhz_show(struct intel_gt *gt) > > > > { > > > > > ^ permalink raw reply [flat|nested] 7+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Remove CONFIG_PM dependency from RC6. 2022-11-30 2:29 [Intel-gfx] [PATCH] drm/i915: Remove CONFIG_PM dependency from RC6 Rodrigo Vivi 2022-11-30 3:19 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork 2022-11-30 11:47 ` [Intel-gfx] [PATCH] " Tvrtko Ursulin @ 2022-11-30 12:41 ` Patchwork 2 siblings, 0 replies; 7+ messages in thread From: Patchwork @ 2022-11-30 12:41 UTC (permalink / raw) To: Rodrigo Vivi; +Cc: intel-gfx [-- Attachment #1: Type: text/plain, Size: 28205 bytes --] == Series Details == Series: drm/i915: Remove CONFIG_PM dependency from RC6. URL : https://patchwork.freedesktop.org/series/111465/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12449_full -> Patchwork_111465v1_full ==================================================== Summary ------- **FAILURE** Serious unknown changes coming with Patchwork_111465v1_full absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_111465v1_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. Participating hosts (10 -> 10) ------------------------------ No changes in participating hosts Possible new issues ------------------- Here are the unknown changes that may have been introduced in Patchwork_111465v1_full: ### IGT changes ### #### Possible regressions #### * igt@gem_exec_fence@long-history: - shard-skl: [PASS][1] -> [FAIL][2] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12449/shard-skl10/igt@gem_exec_fence@long-history.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/shard-skl1/igt@gem_exec_fence@long-history.html Known issues ------------ Here are the changes found in Patchwork_111465v1_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_exec_balancer@parallel-bb-first: - shard-iclb: [PASS][3] -> [SKIP][4] ([i915#4525]) +1 similar issue [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12449/shard-iclb2/igt@gem_exec_balancer@parallel-bb-first.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/shard-iclb8/igt@gem_exec_balancer@parallel-bb-first.html * igt@gem_exec_capture@pi@rcs0: - shard-skl: NOTRUN -> [INCOMPLETE][5] ([i915#3371]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/shard-skl9/igt@gem_exec_capture@pi@rcs0.html * igt@gem_exec_fair@basic-flow@rcs0: - shard-tglb: [PASS][6] -> [FAIL][7] ([i915#2842]) +1 similar issue [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12449/shard-tglb3/igt@gem_exec_fair@basic-flow@rcs0.html [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/shard-tglb2/igt@gem_exec_fair@basic-flow@rcs0.html * igt@gem_lmem_swapping@parallel-random-verify: - shard-skl: NOTRUN -> [SKIP][8] ([fdo#109271] / [i915#4613]) [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/shard-skl9/igt@gem_lmem_swapping@parallel-random-verify.html * igt@gen7_exec_parse@basic-allocation: - shard-tglb: NOTRUN -> [SKIP][9] ([fdo#109289]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/shard-tglb3/igt@gen7_exec_parse@basic-allocation.html * igt@gen9_exec_parse@allowed-single: - shard-apl: [PASS][10] -> [DMESG-WARN][11] ([i915#5566] / [i915#716]) [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12449/shard-apl8/igt@gen9_exec_parse@allowed-single.html [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/shard-apl6/igt@gen9_exec_parse@allowed-single.html * igt@kms_big_fb@yf-tiled-64bpp-rotate-270: - shard-tglb: NOTRUN -> [SKIP][12] ([fdo#111615]) [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/shard-tglb3/igt@kms_big_fb@yf-tiled-64bpp-rotate-270.html * igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_rc_ccs_cc: - shard-skl: NOTRUN -> [SKIP][13] ([fdo#109271] / [i915#3886]) +1 similar issue [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/shard-skl9/igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_rc_ccs_cc.html * igt@kms_ccs@pipe-b-bad-rotation-90-4_tiled_dg2_mc_ccs: - shard-tglb: NOTRUN -> [SKIP][14] ([i915#6095]) [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/shard-tglb3/igt@kms_ccs@pipe-b-bad-rotation-90-4_tiled_dg2_mc_ccs.html * igt@kms_ccs@pipe-b-crc-sprite-planes-basic-y_tiled_ccs: - shard-tglb: NOTRUN -> [SKIP][15] ([i915#3689]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/shard-tglb3/igt@kms_ccs@pipe-b-crc-sprite-planes-basic-y_tiled_ccs.html * igt@kms_ccs@pipe-c-bad-rotation-90-yf_tiled_ccs: - shard-tglb: NOTRUN -> [SKIP][16] ([fdo#111615] / [i915#3689]) +1 similar issue [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/shard-tglb3/igt@kms_ccs@pipe-c-bad-rotation-90-yf_tiled_ccs.html * igt@kms_ccs@pipe-d-bad-pixel-format-4_tiled_dg2_rc_ccs_cc: - shard-skl: NOTRUN -> [SKIP][17] ([fdo#109271]) +14 similar issues [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/shard-skl9/igt@kms_ccs@pipe-d-bad-pixel-format-4_tiled_dg2_rc_ccs_cc.html * igt@kms_chamelium@dp-crc-single: - shard-tglb: NOTRUN -> [SKIP][18] ([fdo#109284] / [fdo#111827]) +1 similar issue [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/shard-tglb3/igt@kms_chamelium@dp-crc-single.html * igt@kms_color_chamelium@ctm-blue-to-red: - shard-skl: NOTRUN -> [SKIP][19] ([fdo#109271] / [fdo#111827]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/shard-skl9/igt@kms_color_chamelium@ctm-blue-to-red.html * igt@kms_cursor_crc@cursor-rapid-movement-32x32: - shard-tglb: NOTRUN -> [SKIP][20] ([i915#3555]) [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/shard-tglb3/igt@kms_cursor_crc@cursor-rapid-movement-32x32.html * igt@kms_dp_tiled_display@basic-test-pattern: - shard-tglb: NOTRUN -> [SKIP][21] ([i915#426]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/shard-tglb3/igt@kms_dp_tiled_display@basic-test-pattern.html * igt@kms_flip@2x-flip-vs-panning-vs-hang: - shard-tglb: NOTRUN -> [SKIP][22] ([fdo#109274] / [fdo#111825] / [i915#3637]) [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/shard-tglb3/igt@kms_flip@2x-flip-vs-panning-vs-hang.html * igt@kms_flip@flip-vs-expired-vblank-interruptible@a-dp1: - shard-apl: [PASS][23] -> [FAIL][24] ([i915#79]) [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12449/shard-apl8/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-dp1.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/shard-apl1/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-dp1.html * igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1: - shard-skl: [PASS][25] -> [FAIL][26] ([i915#79]) [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12449/shard-skl10/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/shard-skl1/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1.html * igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-32bpp-4tiledg2rcccs-upscaling@pipe-a-default-mode: - shard-iclb: NOTRUN -> [SKIP][27] ([i915#2672]) +3 similar issues [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-32bpp-4tiledg2rcccs-upscaling@pipe-a-default-mode.html * igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-downscaling@pipe-a-default-mode: - shard-iclb: NOTRUN -> [SKIP][28] ([i915#3555]) [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-downscaling@pipe-a-default-mode.html * igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-16bpp-4tile-downscaling@pipe-a-valid-mode: - shard-iclb: NOTRUN -> [SKIP][29] ([i915#2587] / [i915#2672]) +3 similar issues [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/shard-iclb1/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-16bpp-4tile-downscaling@pipe-a-valid-mode.html * igt@kms_flip_scaled_crc@flip-64bpp-linear-to-16bpp-linear-downscaling@pipe-a-default-mode: - shard-iclb: [PASS][30] -> [SKIP][31] ([i915#3555]) [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12449/shard-iclb3/igt@kms_flip_scaled_crc@flip-64bpp-linear-to-16bpp-linear-downscaling@pipe-a-default-mode.html [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-linear-to-16bpp-linear-downscaling@pipe-a-default-mode.html * igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-render: - shard-tglb: NOTRUN -> [SKIP][32] ([fdo#109280] / [fdo#111825]) +3 similar issues [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/shard-tglb3/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-render.html * igt@kms_psr2_su@page_flip-p010@pipe-b-edp-1: - shard-iclb: NOTRUN -> [FAIL][33] ([i915#5939]) +5 similar issues [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/shard-iclb2/igt@kms_psr2_su@page_flip-p010@pipe-b-edp-1.html * igt@kms_psr@psr2_primary_blt: - shard-iclb: [PASS][34] -> [SKIP][35] ([fdo#109441]) [34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12449/shard-iclb2/igt@kms_psr@psr2_primary_blt.html [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/shard-iclb5/igt@kms_psr@psr2_primary_blt.html * igt@kms_psr_stress_test@invalidate-primary-flip-overlay: - shard-tglb: [PASS][36] -> [SKIP][37] ([i915#5519]) [36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12449/shard-tglb6/igt@kms_psr_stress_test@invalidate-primary-flip-overlay.html [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/shard-tglb1/igt@kms_psr_stress_test@invalidate-primary-flip-overlay.html #### Possible fixes #### * igt@drm_read@short-buffer-block: - {shard-rkl}: [SKIP][38] ([i915#4098]) -> [PASS][39] +1 similar issue [38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12449/shard-rkl-4/igt@drm_read@short-buffer-block.html [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/shard-rkl-6/igt@drm_read@short-buffer-block.html * igt@fbdev@info: - {shard-rkl}: [SKIP][40] ([i915#2582]) -> [PASS][41] [40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12449/shard-rkl-5/igt@fbdev@info.html [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/shard-rkl-6/igt@fbdev@info.html * igt@gem_exec_balancer@fairslice: - {shard-rkl}: [SKIP][42] ([i915#6259]) -> [PASS][43] [42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12449/shard-rkl-5/igt@gem_exec_balancer@fairslice.html [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/shard-rkl-6/igt@gem_exec_balancer@fairslice.html * igt@gem_exec_balancer@parallel-out-fence: - shard-iclb: [SKIP][44] ([i915#4525]) -> [PASS][45] +1 similar issue [44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12449/shard-iclb3/igt@gem_exec_balancer@parallel-out-fence.html [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/shard-iclb2/igt@gem_exec_balancer@parallel-out-fence.html * igt@gem_exec_flush@basic-batch-kernel-default-cmd: - {shard-rkl}: [SKIP][46] ([fdo#109313]) -> [PASS][47] [46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12449/shard-rkl-4/igt@gem_exec_flush@basic-batch-kernel-default-cmd.html [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/shard-rkl-5/igt@gem_exec_flush@basic-batch-kernel-default-cmd.html * igt@gem_exec_reloc@basic-cpu-read: - {shard-rkl}: [SKIP][48] ([i915#3281]) -> [PASS][49] +1 similar issue [48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12449/shard-rkl-4/igt@gem_exec_reloc@basic-cpu-read.html [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/shard-rkl-5/igt@gem_exec_reloc@basic-cpu-read.html * igt@gem_readwrite@beyond-eob: - {shard-rkl}: [SKIP][50] ([i915#3282]) -> [PASS][51] +1 similar issue [50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12449/shard-rkl-4/igt@gem_readwrite@beyond-eob.html [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/shard-rkl-5/igt@gem_readwrite@beyond-eob.html * igt@gem_softpin@evict-single-offset: - {shard-rkl}: [FAIL][52] ([i915#4171]) -> [PASS][53] [52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12449/shard-rkl-5/igt@gem_softpin@evict-single-offset.html [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/shard-rkl-6/igt@gem_softpin@evict-single-offset.html * igt@gen9_exec_parse@allowed-all: - {shard-rkl}: [SKIP][54] ([i915#2527]) -> [PASS][55] [54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12449/shard-rkl-4/igt@gen9_exec_parse@allowed-all.html [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/shard-rkl-5/igt@gen9_exec_parse@allowed-all.html - shard-apl: [DMESG-WARN][56] ([i915#5566] / [i915#716]) -> [PASS][57] [56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12449/shard-apl3/igt@gen9_exec_parse@allowed-all.html [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/shard-apl3/igt@gen9_exec_parse@allowed-all.html * igt@i915_pm_rc6_residency@rc6-idle@vcs0: - {shard-rkl}: [WARN][58] ([i915#2681]) -> [PASS][59] [58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12449/shard-rkl-5/igt@i915_pm_rc6_residency@rc6-idle@vcs0.html [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/shard-rkl-4/igt@i915_pm_rc6_residency@rc6-idle@vcs0.html * igt@i915_pm_rpm@modeset-lpsp: - {shard-rkl}: [SKIP][60] ([i915#1397]) -> [PASS][61] [60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12449/shard-rkl-4/igt@i915_pm_rpm@modeset-lpsp.html [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/shard-rkl-6/igt@i915_pm_rpm@modeset-lpsp.html * igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-async-flip: - {shard-rkl}: [SKIP][62] ([i915#1845] / [i915#4098]) -> [PASS][63] +21 similar issues [62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12449/shard-rkl-5/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/shard-rkl-6/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html * igt@kms_cursor_edge_walk@top-bottom@pipe-b-edp-1-64x64: - shard-tglb: [INCOMPLETE][64] -> [PASS][65] [64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12449/shard-tglb8/igt@kms_cursor_edge_walk@top-bottom@pipe-b-edp-1-64x64.html [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/shard-tglb3/igt@kms_cursor_edge_walk@top-bottom@pipe-b-edp-1-64x64.html * igt@kms_fbcon_fbt@psr: - {shard-rkl}: [SKIP][66] ([fdo#110189] / [i915#3955]) -> [PASS][67] [66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12449/shard-rkl-5/igt@kms_fbcon_fbt@psr.html [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/shard-rkl-6/igt@kms_fbcon_fbt@psr.html * igt@kms_flip@flip-vs-suspend@c-edp1: - shard-skl: [INCOMPLETE][68] ([i915#4839]) -> [PASS][69] [68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12449/shard-skl10/igt@kms_flip@flip-vs-suspend@c-edp1.html [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/shard-skl9/igt@kms_flip@flip-vs-suspend@c-edp1.html * igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite: - {shard-rkl}: [SKIP][70] ([i915#1849] / [i915#4098]) -> [PASS][71] +20 similar issues [70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12449/shard-rkl-5/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite.html [71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/shard-rkl-6/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-pgflip-blt: - shard-iclb: [FAIL][72] ([i915#2546]) -> [PASS][73] [72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12449/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-pgflip-blt.html [73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/shard-iclb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-pgflip-blt.html * igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-mmap-cpu: - shard-skl: [DMESG-WARN][74] ([i915#1982]) -> [PASS][75] [74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12449/shard-skl1/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-mmap-cpu.html [75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/shard-skl6/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-mmap-cpu.html * igt@kms_plane_scaling@planes-downscale-factor-0-5@pipe-a-edp-1: - shard-iclb: [SKIP][76] ([i915#5235]) -> [PASS][77] +2 similar issues [76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12449/shard-iclb2/igt@kms_plane_scaling@planes-downscale-factor-0-5@pipe-a-edp-1.html [77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/shard-iclb5/igt@kms_plane_scaling@planes-downscale-factor-0-5@pipe-a-edp-1.html * igt@kms_properties@plane-properties-atomic: - {shard-rkl}: [SKIP][78] ([i915#1849]) -> [PASS][79] +1 similar issue [78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12449/shard-rkl-5/igt@kms_properties@plane-properties-atomic.html [79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/shard-rkl-6/igt@kms_properties@plane-properties-atomic.html * igt@kms_psr@dpms: - {shard-rkl}: [SKIP][80] ([i915#1072]) -> [PASS][81] +1 similar issue [80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12449/shard-rkl-5/igt@kms_psr@dpms.html [81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/shard-rkl-6/igt@kms_psr@dpms.html * igt@kms_psr@psr2_no_drrs: - shard-iclb: [SKIP][82] ([fdo#109441]) -> [PASS][83] [82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12449/shard-iclb3/igt@kms_psr@psr2_no_drrs.html [83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/shard-iclb2/igt@kms_psr@psr2_no_drrs.html * igt@kms_psr_stress_test@flip-primary-invalidate-overlay: - shard-iclb: [SKIP][84] ([i915#5519]) -> [PASS][85] [84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12449/shard-iclb3/igt@kms_psr_stress_test@flip-primary-invalidate-overlay.html [85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/shard-iclb7/igt@kms_psr_stress_test@flip-primary-invalidate-overlay.html * igt@sysfs_timeslice_duration@timeout@vecs0: - {shard-dg1}: [FAIL][86] ([i915#1755]) -> [PASS][87] [86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12449/shard-dg1-18/igt@sysfs_timeslice_duration@timeout@vecs0.html [87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/shard-dg1-13/igt@sysfs_timeslice_duration@timeout@vecs0.html #### Warnings #### * igt@gem_exec_balancer@parallel-ordering: - shard-iclb: [FAIL][88] ([i915#6117]) -> [SKIP][89] ([i915#4525]) [88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12449/shard-iclb1/igt@gem_exec_balancer@parallel-ordering.html [89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/shard-iclb5/igt@gem_exec_balancer@parallel-ordering.html * igt@i915_pm_dc@dc3co-vpb-simulation: - shard-iclb: [SKIP][90] ([i915#588]) -> [SKIP][91] ([i915#658]) [90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12449/shard-iclb2/igt@i915_pm_dc@dc3co-vpb-simulation.html [91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/shard-iclb8/igt@i915_pm_dc@dc3co-vpb-simulation.html * igt@kms_plane_alpha_blend@alpha-basic@pipe-c-dp-1: - shard-apl: [DMESG-FAIL][92] ([IGT#6]) -> [FAIL][93] ([i915#4573]) +1 similar issue [92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12449/shard-apl8/igt@kms_plane_alpha_blend@alpha-basic@pipe-c-dp-1.html [93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/shard-apl6/igt@kms_plane_alpha_blend@alpha-basic@pipe-c-dp-1.html * igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-sf: - shard-iclb: [SKIP][94] ([i915#2920]) -> [SKIP][95] ([i915#658]) [94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12449/shard-iclb2/igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-sf.html [95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/shard-iclb8/igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-sf.html * igt@kms_psr2_sf@overlay-plane-update-continuous-sf: - shard-iclb: [SKIP][96] ([i915#2920]) -> [SKIP][97] ([fdo#111068] / [i915#658]) [96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12449/shard-iclb2/igt@kms_psr2_sf@overlay-plane-update-continuous-sf.html [97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/shard-iclb8/igt@kms_psr2_sf@overlay-plane-update-continuous-sf.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [IGT#6]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/6 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274 [fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280 [fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284 [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285 [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289 [fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295 [fdo#109302]: https://bugs.freedesktop.org/show_bug.cgi?id=109302 [fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308 [fdo#109313]: https://bugs.freedesktop.org/show_bug.cgi?id=109313 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189 [fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723 [fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068 [fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614 [fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615 [fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656 [fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072 [i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132 [i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397 [i915#1755]: https://gitlab.freedesktop.org/drm/intel/issues/1755 [i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825 [i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845 [i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849 [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982 [i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527 [i915#2546]: https://gitlab.freedesktop.org/drm/intel/issues/2546 [i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582 [i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587 [i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672 [i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681 [i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705 [i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842 [i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846 [i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920 [i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994 [i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116 [i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281 [i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282 [i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359 [i915#3371]: https://gitlab.freedesktop.org/drm/intel/issues/3371 [i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546 [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555 [i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558 [i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591 [i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637 [i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638 [i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689 [i915#3692]: https://gitlab.freedesktop.org/drm/intel/issues/3692 [i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708 [i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734 [i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886 [i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955 [i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070 [i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078 [i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098 [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103 [i915#4171]: https://gitlab.freedesktop.org/drm/intel/issues/4171 [i915#426]: https://gitlab.freedesktop.org/drm/intel/issues/426 [i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270 [i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387 [i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525 [i915#4573]: https://gitlab.freedesktop.org/drm/intel/issues/4573 [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613 [i915#4839]: https://gitlab.freedesktop.org/drm/intel/issues/4839 [i915#4998]: https://gitlab.freedesktop.org/drm/intel/issues/4998 [i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176 [i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235 [i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286 [i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289 [i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533 [i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461 [i915#5519]: https://gitlab.freedesktop.org/drm/intel/issues/5519 [i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566 [i915#5723]: https://gitlab.freedesktop.org/drm/intel/issues/5723 [i915#588]: https://gitlab.freedesktop.org/drm/intel/issues/588 [i915#5939]: https://gitlab.freedesktop.org/drm/intel/issues/5939 [i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095 [i915#6117]: https://gitlab.freedesktop.org/drm/intel/issues/6117 [i915#6159]: https://gitlab.freedesktop.org/drm/intel/issues/6159 [i915#6247]: https://gitlab.freedesktop.org/drm/intel/issues/6247 [i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248 [i915#6252]: https://gitlab.freedesktop.org/drm/intel/issues/6252 [i915#6259]: https://gitlab.freedesktop.org/drm/intel/issues/6259 [i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497 [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658 [i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768 [i915#6946]: https://gitlab.freedesktop.org/drm/intel/issues/6946 [i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118 [i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716 [i915#7248]: https://gitlab.freedesktop.org/drm/intel/issues/7248 [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79 Build changes ------------- * Linux: CI_DRM_12449 -> Patchwork_111465v1 CI-20190529: 20190529 CI_DRM_12449: bd21d688743bbb6b97f7591203f388af4a018c6b @ git://anongit.freedesktop.org/gfx-ci/linux IGT_7075: ae0ad0ffa147445cdf9d33c96a018f5a8b21a5ee @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git Patchwork_111465v1: bd21d688743bbb6b97f7591203f388af4a018c6b @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_111465v1/index.html [-- Attachment #2: Type: text/html, Size: 28925 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-12-07 15:58 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2022-11-30 2:29 [Intel-gfx] [PATCH] drm/i915: Remove CONFIG_PM dependency from RC6 Rodrigo Vivi 2022-11-30 3:19 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork 2022-11-30 11:47 ` [Intel-gfx] [PATCH] " Tvrtko Ursulin 2022-11-30 13:37 ` Vivi, Rodrigo 2022-12-07 14:35 ` Paul Cercueil 2022-12-07 15:58 ` Rodrigo Vivi 2022-11-30 12:41 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for " Patchwork
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox