* [Intel-gfx] [[topic/core-for-CI]] Revert "perf/core: Avoid removing shared pmu_context on unregister"
@ 2022-12-28 10:47 Rodrigo Vivi
2022-12-28 11:03 ` Rodrigo Vivi
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Rodrigo Vivi @ 2022-12-28 10:47 UTC (permalink / raw)
To: intel-gfx; +Cc: Rodrigo Vivi
There's a complete rewrite of the core context handling in
v6.2-rc1. find_pmu_context function used in this commit doesn't
exist anymore. Also, let's first trust the upstream component,
then work with them to get the issue solved if still present,
re-introduce this patch with the old function only if extremely
needed.
This reverts commit 87b32477e514aa9030a405b168581ee11910ea83.
---
kernel/events/core.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/kernel/events/core.c b/kernel/events/core.c
index 930c99e4d89a..c3762a371dc6 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -11528,8 +11528,7 @@ void perf_pmu_unregister(struct pmu *pmu)
device_del(pmu->dev);
put_device(pmu->dev);
}
- if (!find_pmu_context(pmu->task_ctx_nr))
- free_pmu_context(pmu);
+ free_pmu_context(pmu);
mutex_unlock(&pmus_lock);
}
EXPORT_SYMBOL_GPL(perf_pmu_unregister);
--
2.38.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Intel-gfx] [[topic/core-for-CI]] Revert "perf/core: Avoid removing shared pmu_context on unregister"
2022-12-28 10:47 [Intel-gfx] [[topic/core-for-CI]] Revert "perf/core: Avoid removing shared pmu_context on unregister" Rodrigo Vivi
@ 2022-12-28 11:03 ` Rodrigo Vivi
2022-12-28 11:40 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for ] " Patchwork
2022-12-28 12:07 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Rodrigo Vivi @ 2022-12-28 11:03 UTC (permalink / raw)
To: intel-gfx
On Wed, Dec 28, 2022 at 05:47:12AM -0500, Rodrigo Vivi wrote:
> There's a complete rewrite of the core context handling in
> v6.2-rc1. find_pmu_context function used in this commit doesn't
> exist anymore. Also, let's first trust the upstream component,
> then work with them to get the issue solved if still present,
> re-introduce this patch with the old function only if extremely
> needed.
This revert was an FYI only, since I have removed this patch
directly to get drm-tip compiling again.
>
> This reverts commit 87b32477e514aa9030a405b168581ee11910ea83.
> ---
> kernel/events/core.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/kernel/events/core.c b/kernel/events/core.c
> index 930c99e4d89a..c3762a371dc6 100644
> --- a/kernel/events/core.c
> +++ b/kernel/events/core.c
> @@ -11528,8 +11528,7 @@ void perf_pmu_unregister(struct pmu *pmu)
> device_del(pmu->dev);
> put_device(pmu->dev);
> }
> - if (!find_pmu_context(pmu->task_ctx_nr))
> - free_pmu_context(pmu);
> + free_pmu_context(pmu);
> mutex_unlock(&pmus_lock);
> }
> EXPORT_SYMBOL_GPL(perf_pmu_unregister);
> --
> 2.38.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Intel-gfx] ✗ Fi.CI.SPARSE: warning for ] Revert "perf/core: Avoid removing shared pmu_context on unregister"
2022-12-28 10:47 [Intel-gfx] [[topic/core-for-CI]] Revert "perf/core: Avoid removing shared pmu_context on unregister" Rodrigo Vivi
2022-12-28 11:03 ` Rodrigo Vivi
@ 2022-12-28 11:40 ` Patchwork
2022-12-28 12:07 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2022-12-28 11:40 UTC (permalink / raw)
To: Rodrigo Vivi; +Cc: intel-gfx
== Series Details ==
Series: ] Revert "perf/core: Avoid removing shared pmu_context on unregister"
URL : https://patchwork.freedesktop.org/series/112265/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for ] Revert "perf/core: Avoid removing shared pmu_context on unregister"
2022-12-28 10:47 [Intel-gfx] [[topic/core-for-CI]] Revert "perf/core: Avoid removing shared pmu_context on unregister" Rodrigo Vivi
2022-12-28 11:03 ` Rodrigo Vivi
2022-12-28 11:40 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for ] " Patchwork
@ 2022-12-28 12:07 ` Patchwork
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2022-12-28 12:07 UTC (permalink / raw)
To: Rodrigo Vivi; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 9658 bytes --]
== Series Details ==
Series: ] Revert "perf/core: Avoid removing shared pmu_context on unregister"
URL : https://patchwork.freedesktop.org/series/112265/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12528 -> Patchwork_112265v1
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_112265v1 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_112265v1, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112265v1/index.html
Participating hosts (40 -> 42)
------------------------------
Additional (3): fi-kbl-soraka bat-dg2-9 fi-bsw-kefka
Missing (1): fi-hsw-4770
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_112265v1:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@perf:
- fi-kbl-soraka: NOTRUN -> [INCOMPLETE][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112265v1/fi-kbl-soraka/igt@i915_selftest@live@perf.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@i915_pm_rpm@basic-rte:
- {bat-adln-1}: [PASS][2] -> [DMESG-WARN][3]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12528/bat-adln-1/igt@i915_pm_rpm@basic-rte.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112265v1/bat-adln-1/igt@i915_pm_rpm@basic-rte.html
Known issues
------------
Here are the changes found in Patchwork_112265v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_gttfill@basic:
- fi-kbl-soraka: NOTRUN -> [SKIP][4] ([fdo#109271]) +7 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112265v1/fi-kbl-soraka/igt@gem_exec_gttfill@basic.html
* igt@gem_huc_copy@huc-copy:
- fi-kbl-soraka: NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#2190])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112265v1/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@basic:
- fi-kbl-soraka: NOTRUN -> [SKIP][6] ([fdo#109271] / [i915#4613]) +3 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112265v1/fi-kbl-soraka/igt@gem_lmem_swapping@basic.html
* igt@gem_lmem_swapping@parallel-random-engines:
- bat-adlp-4: NOTRUN -> [SKIP][7] ([i915#4613]) +3 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112265v1/bat-adlp-4/igt@gem_lmem_swapping@parallel-random-engines.html
* igt@i915_pm_rps@basic-api:
- bat-adlp-4: NOTRUN -> [SKIP][8] ([i915#6621])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112265v1/bat-adlp-4/igt@i915_pm_rps@basic-api.html
* igt@i915_selftest@live@gt_heartbeat:
- fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][9] ([i915#5334])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112265v1/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html
* igt@i915_selftest@live@gt_pm:
- fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][10] ([i915#1886])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112265v1/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html
* igt@kms_chamelium@common-hpd-after-suspend:
- bat-adlp-4: NOTRUN -> [SKIP][11] ([fdo#111827])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112265v1/bat-adlp-4/igt@kms_chamelium@common-hpd-after-suspend.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-bsw-kefka: NOTRUN -> [SKIP][12] ([fdo#109271] / [fdo#111827]) +8 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112265v1/fi-bsw-kefka/igt@kms_chamelium@hdmi-hpd-fast.html
- fi-kbl-soraka: NOTRUN -> [SKIP][13] ([fdo#109271] / [fdo#111827]) +7 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112265v1/fi-kbl-soraka/igt@kms_chamelium@hdmi-hpd-fast.html
* igt@kms_setmode@basic-clone-single-crtc:
- fi-snb-2600: NOTRUN -> [SKIP][14] ([fdo#109271])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112265v1/fi-snb-2600/igt@kms_setmode@basic-clone-single-crtc.html
* igt@prime_vgem@basic-fence-flip:
- fi-bsw-kefka: NOTRUN -> [SKIP][15] ([fdo#109271]) +17 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112265v1/fi-bsw-kefka/igt@prime_vgem@basic-fence-flip.html
* igt@prime_vgem@basic-userptr:
- bat-adlp-4: NOTRUN -> [SKIP][16] ([fdo#109295] / [i915#3301] / [i915#3708])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112265v1/bat-adlp-4/igt@prime_vgem@basic-userptr.html
* igt@prime_vgem@basic-write:
- bat-adlp-4: NOTRUN -> [SKIP][17] ([fdo#109295] / [i915#3291] / [i915#3708]) +2 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112265v1/bat-adlp-4/igt@prime_vgem@basic-write.html
#### Possible fixes ####
* igt@i915_pm_rpm@basic-rte:
- bat-adlp-4: [DMESG-WARN][18] ([i915#7077]) -> [PASS][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12528/bat-adlp-4/igt@i915_pm_rpm@basic-rte.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112265v1/bat-adlp-4/igt@i915_pm_rpm@basic-rte.html
* igt@i915_selftest@live@gt_heartbeat:
- fi-cfl-8109u: [DMESG-FAIL][20] ([i915#5334]) -> [PASS][21]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12528/fi-cfl-8109u/igt@i915_selftest@live@gt_heartbeat.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112265v1/fi-cfl-8109u/igt@i915_selftest@live@gt_heartbeat.html
* igt@i915_selftest@live@reset:
- {bat-rpls-2}: [DMESG-FAIL][22] ([i915#4983]) -> [PASS][23]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12528/bat-rpls-2/igt@i915_selftest@live@reset.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112265v1/bat-rpls-2/igt@i915_selftest@live@reset.html
* igt@kms_pipe_crc_basic@suspend-read-crc@pipe-c-dp-1:
- {bat-adlp-9}: [DMESG-WARN][24] ([i915#2867]) -> [PASS][25]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12528/bat-adlp-9/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-c-dp-1.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112265v1/bat-adlp-9/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-c-dp-1.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190
[i915#5274]: https://gitlab.freedesktop.org/drm/intel/issues/5274
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6471]: https://gitlab.freedesktop.org/drm/intel/issues/6471
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6794]: https://gitlab.freedesktop.org/drm/intel/issues/6794
[i915#7077]: https://gitlab.freedesktop.org/drm/intel/issues/7077
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
Build changes
-------------
* Linux: CI_DRM_12528 -> Patchwork_112265v1
CI-20190529: 20190529
CI_DRM_12528: 7e9f060b6f2ad746710306da06ba9c4a53876357 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7104: fe5def13049225967770eaaf19ec01ef80e2adc5 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_112265v1: 7e9f060b6f2ad746710306da06ba9c4a53876357 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112265v1/index.html
[-- Attachment #2: Type: text/html, Size: 10160 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-12-28 12:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-28 10:47 [Intel-gfx] [[topic/core-for-CI]] Revert "perf/core: Avoid removing shared pmu_context on unregister" Rodrigo Vivi
2022-12-28 11:03 ` Rodrigo Vivi
2022-12-28 11:40 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for ] " Patchwork
2022-12-28 12:07 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox