* [Intel-gfx] [PATCH 0/2] Use unversioned blob path for ADLP DMC
@ 2023-01-23 18:20 Gustavo Sousa
2023-01-23 18:20 ` [Intel-gfx] [PATCH 1/2] drm/i915/dmc: Prepare to use unversioned paths Gustavo Sousa
` (4 more replies)
0 siblings, 5 replies; 10+ messages in thread
From: Gustavo Sousa @ 2023-01-23 18:20 UTC (permalink / raw)
To: intel-gfx; +Cc: Jani Nikula, Lucas De Marchi, Rodrigo Vivi
This series introduces the use of unversioned blob path for ADLP DMC,
which begins using the new convention as of v2.18.
In order not to cause regressions with systems not having linux-firmware
up to date, we recall a patch from [1] that adds a fallback mechanism to
load from the latest versioned path in case the unversioned one is not
found.
IMPORTANT: Prior to applying this, we need to wait for a PR to
linux-firmware with the proper update to be applied. I will create such
PR after this series is accepted and CI results are good.
[1]: "drm/i915/dmc: Make firmware loading backwards-compatible"
https://patchwork.freedesktop.org/series/112116/
Signed-off-by: Gustavo Sousa <gustavo.sousa@intel.com>
Gustavo Sousa (2):
drm/i915/dmc: Prepare to use unversioned paths
drm/i915/dmc: Use unversioned path for ADLP
drivers/gpu/drm/i915/display/intel_dmc.c | 66 ++++++++++++++++++------
1 file changed, 50 insertions(+), 16 deletions(-)
--
2.39.0
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Intel-gfx] [PATCH 1/2] drm/i915/dmc: Prepare to use unversioned paths
2023-01-23 18:20 [Intel-gfx] [PATCH 0/2] Use unversioned blob path for ADLP DMC Gustavo Sousa
@ 2023-01-23 18:20 ` Gustavo Sousa
2023-01-23 20:50 ` Rodrigo Vivi
2023-01-23 18:20 ` [Intel-gfx] [PATCH 2/2] drm/i915/dmc: Use unversioned path for ADLP Gustavo Sousa
` (3 subsequent siblings)
4 siblings, 1 reply; 10+ messages in thread
From: Gustavo Sousa @ 2023-01-23 18:20 UTC (permalink / raw)
To: intel-gfx; +Cc: Jani Nikula, Lucas De Marchi, Rodrigo Vivi
New DMC releases in linux-firmware will stop using version number in
blob filenames. This new convention provides the following benefits:
1. It simplifies code maintenance, as new DMC releases for a platform
using the new convention will always use the same filename for the
blob.
2. It allows DMC to be loaded even if the target system does not have
the most recent firmware installed.
Prepare the driver by:
- Using the new convention for DMC_PATH() and renaming the currently
used one to make it clear it is for the legacy scheme.
- Implementing a fallback mechanism for future transitions from
versioned to unversioned paths so that we do not cause a regression
for systems not having the most up-to-date linux-firmware files.
v2:
- Keep using request_firmware() instead of firmware_request_nowarn().
(Jani)
v3:
- Keep current DMC paths instead of directly using unversioned ones,
so that we do not disturb initrd generation.
(Lucas, Rodrigo)
Signed-off-by: Gustavo Sousa <gustavo.sousa@intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
drivers/gpu/drm/i915/display/intel_dmc.c | 62 ++++++++++++++++++------
1 file changed, 46 insertions(+), 16 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c b/drivers/gpu/drm/i915/display/intel_dmc.c
index 370c91d323fc..2464796c769d 100644
--- a/drivers/gpu/drm/i915/display/intel_dmc.c
+++ b/drivers/gpu/drm/i915/display/intel_dmc.c
@@ -42,51 +42,59 @@
#define DMC_VERSION_MAJOR(version) ((version) >> 16)
#define DMC_VERSION_MINOR(version) ((version) & 0xffff)
-#define DMC_PATH(platform, major, minor) \
- "i915/" \
- __stringify(platform) "_dmc_ver" \
- __stringify(major) "_" \
+#define DMC_PATH(platform) \
+ "i915/" __stringify(platform) "_dmc.bin"
+
+/*
+ * New DMC additions should not use this. This is used solely to remain
+ * compatible with systems that have not yet updated DMC blobs to use
+ * unversioned file names.
+ */
+#define DMC_LEGACY_PATH(platform, major, minor) \
+ "i915/" \
+ __stringify(platform) "_dmc_ver" \
+ __stringify(major) "_" \
__stringify(minor) ".bin"
#define DISPLAY_VER13_DMC_MAX_FW_SIZE 0x20000
#define DISPLAY_VER12_DMC_MAX_FW_SIZE ICL_DMC_MAX_FW_SIZE
-#define DG2_DMC_PATH DMC_PATH(dg2, 2, 08)
+#define DG2_DMC_PATH DMC_LEGACY_PATH(dg2, 2, 08)
MODULE_FIRMWARE(DG2_DMC_PATH);
-#define ADLP_DMC_PATH DMC_PATH(adlp, 2, 16)
+#define ADLP_DMC_PATH DMC_LEGACY_PATH(adlp, 2, 16)
MODULE_FIRMWARE(ADLP_DMC_PATH);
-#define ADLS_DMC_PATH DMC_PATH(adls, 2, 01)
+#define ADLS_DMC_PATH DMC_LEGACY_PATH(adls, 2, 01)
MODULE_FIRMWARE(ADLS_DMC_PATH);
-#define DG1_DMC_PATH DMC_PATH(dg1, 2, 02)
+#define DG1_DMC_PATH DMC_LEGACY_PATH(dg1, 2, 02)
MODULE_FIRMWARE(DG1_DMC_PATH);
-#define RKL_DMC_PATH DMC_PATH(rkl, 2, 03)
+#define RKL_DMC_PATH DMC_LEGACY_PATH(rkl, 2, 03)
MODULE_FIRMWARE(RKL_DMC_PATH);
-#define TGL_DMC_PATH DMC_PATH(tgl, 2, 12)
+#define TGL_DMC_PATH DMC_LEGACY_PATH(tgl, 2, 12)
MODULE_FIRMWARE(TGL_DMC_PATH);
-#define ICL_DMC_PATH DMC_PATH(icl, 1, 09)
+#define ICL_DMC_PATH DMC_LEGACY_PATH(icl, 1, 09)
#define ICL_DMC_MAX_FW_SIZE 0x6000
MODULE_FIRMWARE(ICL_DMC_PATH);
-#define GLK_DMC_PATH DMC_PATH(glk, 1, 04)
+#define GLK_DMC_PATH DMC_LEGACY_PATH(glk, 1, 04)
#define GLK_DMC_MAX_FW_SIZE 0x4000
MODULE_FIRMWARE(GLK_DMC_PATH);
-#define KBL_DMC_PATH DMC_PATH(kbl, 1, 04)
+#define KBL_DMC_PATH DMC_LEGACY_PATH(kbl, 1, 04)
#define KBL_DMC_MAX_FW_SIZE BXT_DMC_MAX_FW_SIZE
MODULE_FIRMWARE(KBL_DMC_PATH);
-#define SKL_DMC_PATH DMC_PATH(skl, 1, 27)
+#define SKL_DMC_PATH DMC_LEGACY_PATH(skl, 1, 27)
#define SKL_DMC_MAX_FW_SIZE BXT_DMC_MAX_FW_SIZE
MODULE_FIRMWARE(SKL_DMC_PATH);
-#define BXT_DMC_PATH DMC_PATH(bxt, 1, 07)
+#define BXT_DMC_PATH DMC_LEGACY_PATH(bxt, 1, 07)
#define BXT_DMC_MAX_FW_SIZE 0x3000
MODULE_FIRMWARE(BXT_DMC_PATH);
@@ -845,16 +853,38 @@ static void intel_dmc_runtime_pm_put(struct drm_i915_private *dev_priv)
intel_display_power_put(dev_priv, POWER_DOMAIN_INIT, wakeref);
}
+static const char *dmc_fallback_path(struct drm_i915_private *i915)
+{
+ /* No fallback paths for now. */
+ return NULL;
+}
+
static void dmc_load_work_fn(struct work_struct *work)
{
struct drm_i915_private *dev_priv;
struct intel_dmc *dmc;
const struct firmware *fw = NULL;
+ const char *fallback_path;
+ int err;
dev_priv = container_of(work, typeof(*dev_priv), display.dmc.work);
dmc = &dev_priv->display.dmc;
- request_firmware(&fw, dev_priv->display.dmc.fw_path, dev_priv->drm.dev);
+ err = request_firmware(&fw, dev_priv->display.dmc.fw_path, dev_priv->drm.dev);
+
+ if (err == -ENOENT && !dev_priv->params.dmc_firmware_path) {
+ fallback_path = dmc_fallback_path(dev_priv);
+ if (fallback_path) {
+ drm_dbg_kms(&dev_priv->drm,
+ "%s not found, falling back to %s\n",
+ dmc->fw_path,
+ fallback_path);
+ err = request_firmware(&fw, fallback_path, dev_priv->drm.dev);
+ if (err == 0)
+ dev_priv->display.dmc.fw_path = fallback_path;
+ }
+ }
+
parse_dmc_fw(dev_priv, fw);
if (intel_dmc_has_payload(dev_priv)) {
--
2.39.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [Intel-gfx] [PATCH 2/2] drm/i915/dmc: Use unversioned path for ADLP
2023-01-23 18:20 [Intel-gfx] [PATCH 0/2] Use unversioned blob path for ADLP DMC Gustavo Sousa
2023-01-23 18:20 ` [Intel-gfx] [PATCH 1/2] drm/i915/dmc: Prepare to use unversioned paths Gustavo Sousa
@ 2023-01-23 18:20 ` Gustavo Sousa
2023-01-23 20:50 ` Rodrigo Vivi
2023-01-23 20:19 ` [Intel-gfx] ✓ Fi.CI.BAT: success for Use unversioned blob path for ADLP DMC Patchwork
` (2 subsequent siblings)
4 siblings, 1 reply; 10+ messages in thread
From: Gustavo Sousa @ 2023-01-23 18:20 UTC (permalink / raw)
To: intel-gfx; +Cc: Jani Nikula, Lucas De Marchi, Rodrigo Vivi
The new DMC release for ADLP (v2.18) in linux-firmware adopted the new
convention of using unversioned filenames, so update the driver code for
that new release. Keep the latest versioned path as fallback so we do
not cause regressions.
Signed-off-by: Gustavo Sousa <gustavo.sousa@intel.com>
---
drivers/gpu/drm/i915/display/intel_dmc.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c b/drivers/gpu/drm/i915/display/intel_dmc.c
index 2464796c769d..257aa2b7cf20 100644
--- a/drivers/gpu/drm/i915/display/intel_dmc.c
+++ b/drivers/gpu/drm/i915/display/intel_dmc.c
@@ -63,8 +63,10 @@
#define DG2_DMC_PATH DMC_LEGACY_PATH(dg2, 2, 08)
MODULE_FIRMWARE(DG2_DMC_PATH);
-#define ADLP_DMC_PATH DMC_LEGACY_PATH(adlp, 2, 16)
+#define ADLP_DMC_PATH DMC_PATH(adlp)
+#define ADLP_DMC_FALLBACK_PATH DMC_LEGACY_PATH(adlp, 2, 16)
MODULE_FIRMWARE(ADLP_DMC_PATH);
+MODULE_FIRMWARE(ADLP_DMC_FALLBACK_PATH);
#define ADLS_DMC_PATH DMC_LEGACY_PATH(adls, 2, 01)
MODULE_FIRMWARE(ADLS_DMC_PATH);
@@ -855,7 +857,9 @@ static void intel_dmc_runtime_pm_put(struct drm_i915_private *dev_priv)
static const char *dmc_fallback_path(struct drm_i915_private *i915)
{
- /* No fallback paths for now. */
+ if (IS_ALDERLAKE_P(i915))
+ return ADLP_DMC_FALLBACK_PATH;
+
return NULL;
}
--
2.39.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for Use unversioned blob path for ADLP DMC
2023-01-23 18:20 [Intel-gfx] [PATCH 0/2] Use unversioned blob path for ADLP DMC Gustavo Sousa
2023-01-23 18:20 ` [Intel-gfx] [PATCH 1/2] drm/i915/dmc: Prepare to use unversioned paths Gustavo Sousa
2023-01-23 18:20 ` [Intel-gfx] [PATCH 2/2] drm/i915/dmc: Use unversioned path for ADLP Gustavo Sousa
@ 2023-01-23 20:19 ` Patchwork
2023-01-24 16:39 ` Gustavo Sousa
2023-01-24 4:58 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2023-01-27 19:10 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for Use unversioned blob path for ADLP DMC (rev2) Patchwork
4 siblings, 1 reply; 10+ messages in thread
From: Patchwork @ 2023-01-23 20:19 UTC (permalink / raw)
To: Gustavo Sousa; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 5603 bytes --]
== Series Details ==
Series: Use unversioned blob path for ADLP DMC
URL : https://patchwork.freedesktop.org/series/113238/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12624 -> Patchwork_113238v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/index.html
Participating hosts (38 -> 38)
------------------------------
Additional (2): fi-kbl-soraka fi-pnv-d510
Missing (2): fi-rkl-11600 fi-snb-2520m
Known issues
------------
Here are the changes found in Patchwork_113238v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_huc_copy@huc-copy:
- fi-kbl-soraka: NOTRUN -> [SKIP][1] ([fdo#109271] / [i915#2190])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@basic:
- fi-kbl-soraka: NOTRUN -> [SKIP][2] ([fdo#109271] / [i915#4613]) +3 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/fi-kbl-soraka/igt@gem_lmem_swapping@basic.html
* igt@i915_selftest@live@gt_pm:
- fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][3] ([i915#1886])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html
* igt@i915_selftest@live@guc_multi_lrc:
- fi-kbl-soraka: NOTRUN -> [INCOMPLETE][4] ([i915#7640])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/fi-kbl-soraka/igt@i915_selftest@live@guc_multi_lrc.html
* igt@i915_selftest@live@hangcheck:
- fi-rkl-guc: [PASS][5] -> [INCOMPLETE][6] ([i915#4983])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12624/fi-rkl-guc/igt@i915_selftest@live@hangcheck.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/fi-rkl-guc/igt@i915_selftest@live@hangcheck.html
* igt@kms_chamelium_frames@hdmi-crc-fast:
- fi-kbl-soraka: NOTRUN -> [SKIP][7] ([fdo#109271]) +15 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/fi-kbl-soraka/igt@kms_chamelium_frames@hdmi-crc-fast.html
* igt@kms_psr@primary_page_flip:
- fi-pnv-d510: NOTRUN -> [SKIP][8] ([fdo#109271]) +44 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/fi-pnv-d510/igt@kms_psr@primary_page_flip.html
#### Possible fixes ####
* igt@i915_selftest@live@gt_mocs:
- {bat-rpls-1}: [DMESG-FAIL][9] ([i915#7059]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12624/bat-rpls-1/igt@i915_selftest@live@gt_mocs.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/bat-rpls-1/igt@i915_selftest@live@gt_mocs.html
* igt@i915_selftest@live@requests:
- {bat-rpls-2}: [INCOMPLETE][11] ([i915#6257]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12624/bat-rpls-2/igt@i915_selftest@live@requests.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/bat-rpls-2/igt@i915_selftest@live@requests.html
- {bat-rpls-1}: [INCOMPLETE][13] ([i915#4983]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12624/bat-rpls-1/igt@i915_selftest@live@requests.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/bat-rpls-1/igt@i915_selftest@live@requests.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions:
- fi-bsw-kefka: [FAIL][15] ([i915#6298]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12624/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#6257]: https://gitlab.freedesktop.org/drm/intel/issues/6257
[i915#6298]: https://gitlab.freedesktop.org/drm/intel/issues/6298
[i915#6997]: https://gitlab.freedesktop.org/drm/intel/issues/6997
[i915#7059]: https://gitlab.freedesktop.org/drm/intel/issues/7059
[i915#7640]: https://gitlab.freedesktop.org/drm/intel/issues/7640
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
Build changes
-------------
* Linux: CI_DRM_12624 -> Patchwork_113238v1
CI-20190529: 20190529
CI_DRM_12624: 18fa3d2237f6df82980349f6bef5281096dfc91d @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7134: 61b8c0a0c8a9611c47749c0b1a262843892cccd7 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_113238v1: 18fa3d2237f6df82980349f6bef5281096dfc91d @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
2b1f15adacc1 drm/i915/dmc: Use unversioned path for ADLP
e1384510d25a drm/i915/dmc: Prepare to use unversioned paths
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/index.html
[-- Attachment #2: Type: text/html, Size: 6489 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH 1/2] drm/i915/dmc: Prepare to use unversioned paths
2023-01-23 18:20 ` [Intel-gfx] [PATCH 1/2] drm/i915/dmc: Prepare to use unversioned paths Gustavo Sousa
@ 2023-01-23 20:50 ` Rodrigo Vivi
0 siblings, 0 replies; 10+ messages in thread
From: Rodrigo Vivi @ 2023-01-23 20:50 UTC (permalink / raw)
To: Gustavo Sousa; +Cc: Jani Nikula, intel-gfx, Lucas De Marchi
On Mon, Jan 23, 2023 at 03:20:20PM -0300, Gustavo Sousa wrote:
> New DMC releases in linux-firmware will stop using version number in
> blob filenames. This new convention provides the following benefits:
>
> 1. It simplifies code maintenance, as new DMC releases for a platform
> using the new convention will always use the same filename for the
> blob.
>
> 2. It allows DMC to be loaded even if the target system does not have
> the most recent firmware installed.
>
> Prepare the driver by:
>
> - Using the new convention for DMC_PATH() and renaming the currently
> used one to make it clear it is for the legacy scheme.
>
> - Implementing a fallback mechanism for future transitions from
> versioned to unversioned paths so that we do not cause a regression
> for systems not having the most up-to-date linux-firmware files.
>
> v2:
> - Keep using request_firmware() instead of firmware_request_nowarn().
> (Jani)
> v3:
> - Keep current DMC paths instead of directly using unversioned ones,
> so that we do not disturb initrd generation.
> (Lucas, Rodrigo)
>
> Signed-off-by: Gustavo Sousa <gustavo.sousa@intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dmc.c | 62 ++++++++++++++++++------
> 1 file changed, 46 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c b/drivers/gpu/drm/i915/display/intel_dmc.c
> index 370c91d323fc..2464796c769d 100644
> --- a/drivers/gpu/drm/i915/display/intel_dmc.c
> +++ b/drivers/gpu/drm/i915/display/intel_dmc.c
> @@ -42,51 +42,59 @@
> #define DMC_VERSION_MAJOR(version) ((version) >> 16)
> #define DMC_VERSION_MINOR(version) ((version) & 0xffff)
>
> -#define DMC_PATH(platform, major, minor) \
> - "i915/" \
> - __stringify(platform) "_dmc_ver" \
> - __stringify(major) "_" \
> +#define DMC_PATH(platform) \
> + "i915/" __stringify(platform) "_dmc.bin"
> +
> +/*
> + * New DMC additions should not use this. This is used solely to remain
> + * compatible with systems that have not yet updated DMC blobs to use
> + * unversioned file names.
> + */
> +#define DMC_LEGACY_PATH(platform, major, minor) \
> + "i915/" \
> + __stringify(platform) "_dmc_ver" \
> + __stringify(major) "_" \
> __stringify(minor) ".bin"
>
> #define DISPLAY_VER13_DMC_MAX_FW_SIZE 0x20000
>
> #define DISPLAY_VER12_DMC_MAX_FW_SIZE ICL_DMC_MAX_FW_SIZE
>
> -#define DG2_DMC_PATH DMC_PATH(dg2, 2, 08)
> +#define DG2_DMC_PATH DMC_LEGACY_PATH(dg2, 2, 08)
> MODULE_FIRMWARE(DG2_DMC_PATH);
>
> -#define ADLP_DMC_PATH DMC_PATH(adlp, 2, 16)
> +#define ADLP_DMC_PATH DMC_LEGACY_PATH(adlp, 2, 16)
> MODULE_FIRMWARE(ADLP_DMC_PATH);
>
> -#define ADLS_DMC_PATH DMC_PATH(adls, 2, 01)
> +#define ADLS_DMC_PATH DMC_LEGACY_PATH(adls, 2, 01)
> MODULE_FIRMWARE(ADLS_DMC_PATH);
>
> -#define DG1_DMC_PATH DMC_PATH(dg1, 2, 02)
> +#define DG1_DMC_PATH DMC_LEGACY_PATH(dg1, 2, 02)
> MODULE_FIRMWARE(DG1_DMC_PATH);
>
> -#define RKL_DMC_PATH DMC_PATH(rkl, 2, 03)
> +#define RKL_DMC_PATH DMC_LEGACY_PATH(rkl, 2, 03)
> MODULE_FIRMWARE(RKL_DMC_PATH);
>
> -#define TGL_DMC_PATH DMC_PATH(tgl, 2, 12)
> +#define TGL_DMC_PATH DMC_LEGACY_PATH(tgl, 2, 12)
> MODULE_FIRMWARE(TGL_DMC_PATH);
>
> -#define ICL_DMC_PATH DMC_PATH(icl, 1, 09)
> +#define ICL_DMC_PATH DMC_LEGACY_PATH(icl, 1, 09)
> #define ICL_DMC_MAX_FW_SIZE 0x6000
> MODULE_FIRMWARE(ICL_DMC_PATH);
>
> -#define GLK_DMC_PATH DMC_PATH(glk, 1, 04)
> +#define GLK_DMC_PATH DMC_LEGACY_PATH(glk, 1, 04)
> #define GLK_DMC_MAX_FW_SIZE 0x4000
> MODULE_FIRMWARE(GLK_DMC_PATH);
>
> -#define KBL_DMC_PATH DMC_PATH(kbl, 1, 04)
> +#define KBL_DMC_PATH DMC_LEGACY_PATH(kbl, 1, 04)
> #define KBL_DMC_MAX_FW_SIZE BXT_DMC_MAX_FW_SIZE
> MODULE_FIRMWARE(KBL_DMC_PATH);
>
> -#define SKL_DMC_PATH DMC_PATH(skl, 1, 27)
> +#define SKL_DMC_PATH DMC_LEGACY_PATH(skl, 1, 27)
> #define SKL_DMC_MAX_FW_SIZE BXT_DMC_MAX_FW_SIZE
> MODULE_FIRMWARE(SKL_DMC_PATH);
>
> -#define BXT_DMC_PATH DMC_PATH(bxt, 1, 07)
> +#define BXT_DMC_PATH DMC_LEGACY_PATH(bxt, 1, 07)
> #define BXT_DMC_MAX_FW_SIZE 0x3000
> MODULE_FIRMWARE(BXT_DMC_PATH);
>
> @@ -845,16 +853,38 @@ static void intel_dmc_runtime_pm_put(struct drm_i915_private *dev_priv)
> intel_display_power_put(dev_priv, POWER_DOMAIN_INIT, wakeref);
> }
>
> +static const char *dmc_fallback_path(struct drm_i915_private *i915)
> +{
> + /* No fallback paths for now. */
> + return NULL;
> +}
> +
> static void dmc_load_work_fn(struct work_struct *work)
> {
> struct drm_i915_private *dev_priv;
> struct intel_dmc *dmc;
> const struct firmware *fw = NULL;
> + const char *fallback_path;
> + int err;
>
> dev_priv = container_of(work, typeof(*dev_priv), display.dmc.work);
> dmc = &dev_priv->display.dmc;
>
> - request_firmware(&fw, dev_priv->display.dmc.fw_path, dev_priv->drm.dev);
> + err = request_firmware(&fw, dev_priv->display.dmc.fw_path, dev_priv->drm.dev);
> +
> + if (err == -ENOENT && !dev_priv->params.dmc_firmware_path) {
> + fallback_path = dmc_fallback_path(dev_priv);
> + if (fallback_path) {
> + drm_dbg_kms(&dev_priv->drm,
> + "%s not found, falling back to %s\n",
> + dmc->fw_path,
> + fallback_path);
> + err = request_firmware(&fw, fallback_path, dev_priv->drm.dev);
> + if (err == 0)
> + dev_priv->display.dmc.fw_path = fallback_path;
> + }
> + }
> +
> parse_dmc_fw(dev_priv, fw);
>
> if (intel_dmc_has_payload(dev_priv)) {
> --
> 2.39.0
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH 2/2] drm/i915/dmc: Use unversioned path for ADLP
2023-01-23 18:20 ` [Intel-gfx] [PATCH 2/2] drm/i915/dmc: Use unversioned path for ADLP Gustavo Sousa
@ 2023-01-23 20:50 ` Rodrigo Vivi
0 siblings, 0 replies; 10+ messages in thread
From: Rodrigo Vivi @ 2023-01-23 20:50 UTC (permalink / raw)
To: Gustavo Sousa; +Cc: Jani Nikula, intel-gfx, Lucas De Marchi
On Mon, Jan 23, 2023 at 03:20:21PM -0300, Gustavo Sousa wrote:
> The new DMC release for ADLP (v2.18) in linux-firmware adopted the new
> convention of using unversioned filenames, so update the driver code for
> that new release. Keep the latest versioned path as fallback so we do
> not cause regressions.
>
> Signed-off-by: Gustavo Sousa <gustavo.sousa@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dmc.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c b/drivers/gpu/drm/i915/display/intel_dmc.c
> index 2464796c769d..257aa2b7cf20 100644
> --- a/drivers/gpu/drm/i915/display/intel_dmc.c
> +++ b/drivers/gpu/drm/i915/display/intel_dmc.c
> @@ -63,8 +63,10 @@
> #define DG2_DMC_PATH DMC_LEGACY_PATH(dg2, 2, 08)
> MODULE_FIRMWARE(DG2_DMC_PATH);
>
> -#define ADLP_DMC_PATH DMC_LEGACY_PATH(adlp, 2, 16)
> +#define ADLP_DMC_PATH DMC_PATH(adlp)
> +#define ADLP_DMC_FALLBACK_PATH DMC_LEGACY_PATH(adlp, 2, 16)
> MODULE_FIRMWARE(ADLP_DMC_PATH);
> +MODULE_FIRMWARE(ADLP_DMC_FALLBACK_PATH);
I'm glad this works without warning on the intrd/intramfs generators.
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>
> #define ADLS_DMC_PATH DMC_LEGACY_PATH(adls, 2, 01)
> MODULE_FIRMWARE(ADLS_DMC_PATH);
> @@ -855,7 +857,9 @@ static void intel_dmc_runtime_pm_put(struct drm_i915_private *dev_priv)
>
> static const char *dmc_fallback_path(struct drm_i915_private *i915)
> {
> - /* No fallback paths for now. */
> + if (IS_ALDERLAKE_P(i915))
> + return ADLP_DMC_FALLBACK_PATH;
> +
> return NULL;
> }
>
> --
> 2.39.0
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for Use unversioned blob path for ADLP DMC
2023-01-23 18:20 [Intel-gfx] [PATCH 0/2] Use unversioned blob path for ADLP DMC Gustavo Sousa
` (2 preceding siblings ...)
2023-01-23 20:19 ` [Intel-gfx] ✓ Fi.CI.BAT: success for Use unversioned blob path for ADLP DMC Patchwork
@ 2023-01-24 4:58 ` Patchwork
2023-01-27 19:10 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for Use unversioned blob path for ADLP DMC (rev2) Patchwork
4 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2023-01-24 4:58 UTC (permalink / raw)
To: Gustavo Sousa; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 20511 bytes --]
== Series Details ==
Series: Use unversioned blob path for ADLP DMC
URL : https://patchwork.freedesktop.org/series/113238/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12624_full -> Patchwork_113238v1_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/index.html
Participating hosts (12 -> 11)
------------------------------
Additional (1): shard-rkl0
Missing (2): pig-skl-6260u pig-kbl-iris
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_113238v1_full:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@gem_ccs@block-copy-uncompressed:
- {shard-rkl}: NOTRUN -> [SKIP][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/shard-rkl-5/igt@gem_ccs@block-copy-uncompressed.html
* igt@gem_ccs@block-multicopy-compressed:
- {shard-rkl}: [SKIP][2] ([i915#5325]) -> [SKIP][3]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12624/shard-rkl-2/igt@gem_ccs@block-multicopy-compressed.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/shard-rkl-5/igt@gem_ccs@block-multicopy-compressed.html
Known issues
------------
Here are the changes found in Patchwork_113238v1_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_fair@basic-deadline:
- shard-glk: [PASS][4] -> [FAIL][5] ([i915#2846])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12624/shard-glk9/igt@gem_exec_fair@basic-deadline.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/shard-glk2/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [PASS][6] -> [FAIL][7] ([i915#2842])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12624/shard-glk6/igt@gem_exec_fair@basic-pace-share@rcs0.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/shard-glk3/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gen9_exec_parse@allowed-single:
- shard-glk: [PASS][8] -> [DMESG-WARN][9] ([i915#5566] / [i915#716])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12624/shard-glk4/igt@gen9_exec_parse@allowed-single.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/shard-glk8/igt@gen9_exec_parse@allowed-single.html
* igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions:
- shard-glk: [PASS][10] -> [FAIL][11] ([i915#2346])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12624/shard-glk1/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/shard-glk2/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a1:
- shard-glk: [PASS][12] -> [FAIL][13] ([i915#2122])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12624/shard-glk8/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a1.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/shard-glk4/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a1.html
* igt@runner@aborted:
- shard-glk: NOTRUN -> [FAIL][14] ([i915#4312])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/shard-glk8/igt@runner@aborted.html
#### Possible fixes ####
* igt@feature_discovery@psr2:
- {shard-rkl}: [SKIP][15] ([i915#658]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12624/shard-rkl-3/igt@feature_discovery@psr2.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/shard-rkl-6/igt@feature_discovery@psr2.html
* igt@gem_ctx_persistence@legacy-engines-hang@blt:
- {shard-rkl}: [SKIP][17] ([i915#6252]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12624/shard-rkl-5/igt@gem_ctx_persistence@legacy-engines-hang@blt.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/shard-rkl-4/igt@gem_ctx_persistence@legacy-engines-hang@blt.html
* igt@gem_exec_fair@basic-none-rrul@rcs0:
- {shard-rkl}: [FAIL][19] ([i915#2842]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12624/shard-rkl-2/igt@gem_exec_fair@basic-none-rrul@rcs0.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/shard-rkl-5/igt@gem_exec_fair@basic-none-rrul@rcs0.html
* igt@gem_exec_reloc@basic-gtt-read-noreloc:
- {shard-rkl}: [SKIP][21] ([i915#3281]) -> [PASS][22] +7 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12624/shard-rkl-1/igt@gem_exec_reloc@basic-gtt-read-noreloc.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/shard-rkl-5/igt@gem_exec_reloc@basic-gtt-read-noreloc.html
* igt@gem_partial_pwrite_pread@reads-display:
- {shard-rkl}: [SKIP][23] ([i915#3282]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12624/shard-rkl-1/igt@gem_partial_pwrite_pread@reads-display.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/shard-rkl-5/igt@gem_partial_pwrite_pread@reads-display.html
* igt@gen9_exec_parse@shadow-peek:
- {shard-rkl}: [SKIP][25] ([i915#2527]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12624/shard-rkl-1/igt@gen9_exec_parse@shadow-peek.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/shard-rkl-5/igt@gen9_exec_parse@shadow-peek.html
* igt@i915_hangman@gt-engine-error@bcs0:
- {shard-rkl}: [SKIP][27] ([i915#6258]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12624/shard-rkl-5/igt@i915_hangman@gt-engine-error@bcs0.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/shard-rkl-1/igt@i915_hangman@gt-engine-error@bcs0.html
* igt@i915_pm_rpm@pm-tiling:
- {shard-rkl}: [SKIP][29] ([fdo#109308]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12624/shard-rkl-2/igt@i915_pm_rpm@pm-tiling.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/shard-rkl-6/igt@i915_pm_rpm@pm-tiling.html
* igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_rc_ccs:
- {shard-rkl}: [SKIP][31] ([i915#1845] / [i915#4098]) -> [PASS][32] +19 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12624/shard-rkl-2/igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_rc_ccs.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/shard-rkl-6/igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_rc_ccs.html
* igt@kms_frontbuffer_tracking@fbc-shrfb-scaledprimary:
- {shard-rkl}: [SKIP][33] ([i915#1849] / [i915#4098]) -> [PASS][34] +20 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12624/shard-rkl-2/igt@kms_frontbuffer_tracking@fbc-shrfb-scaledprimary.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/shard-rkl-6/igt@kms_frontbuffer_tracking@fbc-shrfb-scaledprimary.html
* igt@kms_plane@plane-panning-bottom-right@pipe-a-planes:
- {shard-rkl}: [SKIP][35] ([i915#1849]) -> [PASS][36] +2 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12624/shard-rkl-3/igt@kms_plane@plane-panning-bottom-right@pipe-a-planes.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/shard-rkl-6/igt@kms_plane@plane-panning-bottom-right@pipe-a-planes.html
* igt@kms_psr@cursor_mmap_cpu:
- {shard-rkl}: [SKIP][37] ([i915#1072]) -> [PASS][38] +2 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12624/shard-rkl-2/igt@kms_psr@cursor_mmap_cpu.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/shard-rkl-6/igt@kms_psr@cursor_mmap_cpu.html
* igt@kms_universal_plane@universal-plane-pipe-a-sanity:
- {shard-rkl}: [SKIP][39] ([i915#1845] / [i915#4070] / [i915#4098]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12624/shard-rkl-2/igt@kms_universal_plane@universal-plane-pipe-a-sanity.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/shard-rkl-6/igt@kms_universal_plane@universal-plane-pipe-a-sanity.html
* igt@perf@gen12-mi-rpc:
- {shard-rkl}: [SKIP][41] ([fdo#109289]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12624/shard-rkl-5/igt@perf@gen12-mi-rpc.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/shard-rkl-4/igt@perf@gen12-mi-rpc.html
* igt@perf@polling-small-buf:
- {shard-rkl}: [FAIL][43] ([i915#1722]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12624/shard-rkl-2/igt@perf@polling-small-buf.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/shard-rkl-5/igt@perf@polling-small-buf.html
* igt@prime_vgem@basic-fence-flip:
- {shard-rkl}: [SKIP][45] ([fdo#109295] / [i915#3708] / [i915#4098]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12624/shard-rkl-2/igt@prime_vgem@basic-fence-flip.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/shard-rkl-6/igt@prime_vgem@basic-fence-flip.html
* igt@testdisplay:
- {shard-rkl}: [SKIP][47] ([i915#4098]) -> [PASS][48] +2 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12624/shard-rkl-2/igt@testdisplay.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/shard-rkl-6/igt@testdisplay.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109303]: https://bugs.freedesktop.org/show_bug.cgi?id=109303
[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309
[fdo#109313]: https://bugs.freedesktop.org/show_bug.cgi?id=109313
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644
[fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1722]: https://gitlab.freedesktop.org/drm/intel/issues/1722
[i915#1755]: https://gitlab.freedesktop.org/drm/intel/issues/1755
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1850]: https://gitlab.freedesktop.org/drm/intel/issues/1850
[i915#1902]: https://gitlab.freedesktop.org/drm/intel/issues/1902
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2232]: https://gitlab.freedesktop.org/drm/intel/issues/2232
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2436]: https://gitlab.freedesktop.org/drm/intel/issues/2436
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#315]: https://gitlab.freedesktop.org/drm/intel/issues/315
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3804]: https://gitlab.freedesktop.org/drm/intel/issues/3804
[i915#3826]: https://gitlab.freedesktop.org/drm/intel/issues/3826
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3952]: https://gitlab.freedesktop.org/drm/intel/issues/3952
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#404]: https://gitlab.freedesktop.org/drm/intel/issues/404
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#4565]: https://gitlab.freedesktop.org/drm/intel/issues/4565
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4854]: https://gitlab.freedesktop.org/drm/intel/issues/4854
[i915#4859]: https://gitlab.freedesktop.org/drm/intel/issues/4859
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#4881]: https://gitlab.freedesktop.org/drm/intel/issues/4881
[i915#4885]: https://gitlab.freedesktop.org/drm/intel/issues/4885
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5723]: https://gitlab.freedesktop.org/drm/intel/issues/5723
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6227]: https://gitlab.freedesktop.org/drm/intel/issues/6227
[i915#6247]: https://gitlab.freedesktop.org/drm/intel/issues/6247
[i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
[i915#6252]: https://gitlab.freedesktop.org/drm/intel/issues/6252
[i915#6258]: https://gitlab.freedesktop.org/drm/intel/issues/6258
[i915#6259]: https://gitlab.freedesktop.org/drm/intel/issues/6259
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6301]: https://gitlab.freedesktop.org/drm/intel/issues/6301
[i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#6944]: https://gitlab.freedesktop.org/drm/intel/issues/6944
[i915#6946]: https://gitlab.freedesktop.org/drm/intel/issues/6946
[i915#7037]: https://gitlab.freedesktop.org/drm/intel/issues/7037
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7128]: https://gitlab.freedesktop.org/drm/intel/issues/7128
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#7294]: https://gitlab.freedesktop.org/drm/intel/issues/7294
[i915#7443]: https://gitlab.freedesktop.org/drm/intel/issues/7443
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7651]: https://gitlab.freedesktop.org/drm/intel/issues/7651
[i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
[i915#7701]: https://gitlab.freedesktop.org/drm/intel/issues/7701
[i915#7707]: https://gitlab.freedesktop.org/drm/intel/issues/7707
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
Build changes
-------------
* Linux: CI_DRM_12624 -> Patchwork_113238v1
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_12624: 18fa3d2237f6df82980349f6bef5281096dfc91d @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7134: 61b8c0a0c8a9611c47749c0b1a262843892cccd7 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_113238v1: 18fa3d2237f6df82980349f6bef5281096dfc91d @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/index.html
[-- Attachment #2: Type: text/html, Size: 13937 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] ✓ Fi.CI.BAT: success for Use unversioned blob path for ADLP DMC
2023-01-23 20:19 ` [Intel-gfx] ✓ Fi.CI.BAT: success for Use unversioned blob path for ADLP DMC Patchwork
@ 2023-01-24 16:39 ` Gustavo Sousa
2023-01-24 19:47 ` Rodrigo Vivi
0 siblings, 1 reply; 10+ messages in thread
From: Gustavo Sousa @ 2023-01-24 16:39 UTC (permalink / raw)
To: intel-gfx; +Cc: Rodrigo Vivi
On Mon, Jan 23, 2023 at 08:19:59PM +0000, Patchwork wrote:
> == Series Details ==
>
> Series: Use unversioned blob path for ADLP DMC
> URL : https://patchwork.freedesktop.org/series/113238/
> State : success
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_12624 -> Patchwork_113238v1
> ====================================================
>
> Summary
> -------
>
> **SUCCESS**
>
> No regressions found.
>
> External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/index.html
CI is clean, however, looking at the logs for igt@i915_module_load@load
on ADLP (e.g. [1]), it looks like the adlp_dmc.bin firmware blob is
missing, so the tests ended up using ADLP DMC v2.16 instead of v2.18.
(On the bright side, at least that confirmst that the fallback mechanism
works :-))
I thought this PR[2], sent to this list, would make the blobs available
to CI. Did I do something wrong there?
[1]: "Results for igt@i915_module_load@load on bat-adlp-6"
(https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/bat-adlp-6/igt@i915_module_load@load.html)
[2]: "[Intel-gfx] [CI] PR for ADLP DMC 2.18 and MTL DMC 2.11"
(https://lists.freedesktop.org/archives/intel-gfx/2023-January/316102.html)
--
Gustavo Sousa
>
> Participating hosts (38 -> 38)
> ------------------------------
>
> Additional (2): fi-kbl-soraka fi-pnv-d510
> Missing (2): fi-rkl-11600 fi-snb-2520m
>
> Known issues
> ------------
>
> Here are the changes found in Patchwork_113238v1 that come from known issues:
>
> ### IGT changes ###
>
> #### Issues hit ####
>
> * igt@gem_huc_copy@huc-copy:
> - fi-kbl-soraka: NOTRUN -> [SKIP][1] ([fdo#109271] / [i915#2190])
> [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html
>
> * igt@gem_lmem_swapping@basic:
> - fi-kbl-soraka: NOTRUN -> [SKIP][2] ([fdo#109271] / [i915#4613]) +3 similar issues
> [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/fi-kbl-soraka/igt@gem_lmem_swapping@basic.html
>
> * igt@i915_selftest@live@gt_pm:
> - fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][3] ([i915#1886])
> [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html
>
> * igt@i915_selftest@live@guc_multi_lrc:
> - fi-kbl-soraka: NOTRUN -> [INCOMPLETE][4] ([i915#7640])
> [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/fi-kbl-soraka/igt@i915_selftest@live@guc_multi_lrc.html
>
> * igt@i915_selftest@live@hangcheck:
> - fi-rkl-guc: [PASS][5] -> [INCOMPLETE][6] ([i915#4983])
> [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12624/fi-rkl-guc/igt@i915_selftest@live@hangcheck.html
> [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/fi-rkl-guc/igt@i915_selftest@live@hangcheck.html
>
> * igt@kms_chamelium_frames@hdmi-crc-fast:
> - fi-kbl-soraka: NOTRUN -> [SKIP][7] ([fdo#109271]) +15 similar issues
> [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/fi-kbl-soraka/igt@kms_chamelium_frames@hdmi-crc-fast.html
>
> * igt@kms_psr@primary_page_flip:
> - fi-pnv-d510: NOTRUN -> [SKIP][8] ([fdo#109271]) +44 similar issues
> [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/fi-pnv-d510/igt@kms_psr@primary_page_flip.html
>
>
> #### Possible fixes ####
>
> * igt@i915_selftest@live@gt_mocs:
> - {bat-rpls-1}: [DMESG-FAIL][9] ([i915#7059]) -> [PASS][10]
> [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12624/bat-rpls-1/igt@i915_selftest@live@gt_mocs.html
> [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/bat-rpls-1/igt@i915_selftest@live@gt_mocs.html
>
> * igt@i915_selftest@live@requests:
> - {bat-rpls-2}: [INCOMPLETE][11] ([i915#6257]) -> [PASS][12]
> [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12624/bat-rpls-2/igt@i915_selftest@live@requests.html
> [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/bat-rpls-2/igt@i915_selftest@live@requests.html
> - {bat-rpls-1}: [INCOMPLETE][13] ([i915#4983]) -> [PASS][14]
> [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12624/bat-rpls-1/igt@i915_selftest@live@requests.html
> [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/bat-rpls-1/igt@i915_selftest@live@requests.html
>
> * igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions:
> - fi-bsw-kefka: [FAIL][15] ([i915#6298]) -> [PASS][16]
> [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12624/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions.html
> [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions.html
>
>
> {name}: This element is suppressed. This means it is ignored when computing
> the status of the difference (SUCCESS, WARNING, or FAILURE).
>
> [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
> [i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
> [i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
> [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
> [i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
> [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
> [i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
> [i915#6257]: https://gitlab.freedesktop.org/drm/intel/issues/6257
> [i915#6298]: https://gitlab.freedesktop.org/drm/intel/issues/6298
> [i915#6997]: https://gitlab.freedesktop.org/drm/intel/issues/6997
> [i915#7059]: https://gitlab.freedesktop.org/drm/intel/issues/7059
> [i915#7640]: https://gitlab.freedesktop.org/drm/intel/issues/7640
> [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
>
>
> Build changes
> -------------
>
> * Linux: CI_DRM_12624 -> Patchwork_113238v1
>
> CI-20190529: 20190529
> CI_DRM_12624: 18fa3d2237f6df82980349f6bef5281096dfc91d @ git://anongit.freedesktop.org/gfx-ci/linux
> IGT_7134: 61b8c0a0c8a9611c47749c0b1a262843892cccd7 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
> Patchwork_113238v1: 18fa3d2237f6df82980349f6bef5281096dfc91d @ git://anongit.freedesktop.org/gfx-ci/linux
>
>
> ### Linux commits
>
> 2b1f15adacc1 drm/i915/dmc: Use unversioned path for ADLP
> e1384510d25a drm/i915/dmc: Prepare to use unversioned paths
>
> == Logs ==
>
> For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/index.html
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] ✓ Fi.CI.BAT: success for Use unversioned blob path for ADLP DMC
2023-01-24 16:39 ` Gustavo Sousa
@ 2023-01-24 19:47 ` Rodrigo Vivi
0 siblings, 0 replies; 10+ messages in thread
From: Rodrigo Vivi @ 2023-01-24 19:47 UTC (permalink / raw)
To: Gustavo Sousa; +Cc: intel-gfx
On Tue, Jan 24, 2023 at 01:39:59PM -0300, Gustavo Sousa wrote:
> On Mon, Jan 23, 2023 at 08:19:59PM +0000, Patchwork wrote:
> > == Series Details ==
> >
> > Series: Use unversioned blob path for ADLP DMC
> > URL : https://patchwork.freedesktop.org/series/113238/
> > State : success
> >
> > == Summary ==
> >
> > CI Bug Log - changes from CI_DRM_12624 -> Patchwork_113238v1
> > ====================================================
> >
> > Summary
> > -------
> >
> > **SUCCESS**
> >
> > No regressions found.
> >
> > External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/index.html
>
> CI is clean, however, looking at the logs for igt@i915_module_load@load
> on ADLP (e.g. [1]), it looks like the adlp_dmc.bin firmware blob is
> missing, so the tests ended up using ADLP DMC v2.16 instead of v2.18.
>
> (On the bright side, at least that confirmst that the fallback mechanism
> works :-))
That's nice! This gave me more confidence to push the series! :)
>
> I thought this PR[2], sent to this list, would make the blobs available
> to CI. Did I do something wrong there?
my understanding is that the CI would pick the PR for run a local test.
But also that was prepared for the PR with kernel changes simultaneously,
not sure right now. Someone on CI would have to check and fix for the new flow.
But anyway that was a temporary get, to the final one. After that gets
integrated to linux-firmware.git someone in CI was doing a manual sync/update
iirc.
>
>
> [1]: "Results for igt@i915_module_load@load on bat-adlp-6"
> (https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/bat-adlp-6/igt@i915_module_load@load.html)
> [2]: "[Intel-gfx] [CI] PR for ADLP DMC 2.18 and MTL DMC 2.11"
> (https://lists.freedesktop.org/archives/intel-gfx/2023-January/316102.html)
>
> --
> Gustavo Sousa
>
> >
> > Participating hosts (38 -> 38)
> > ------------------------------
> >
> > Additional (2): fi-kbl-soraka fi-pnv-d510
> > Missing (2): fi-rkl-11600 fi-snb-2520m
> >
> > Known issues
> > ------------
> >
> > Here are the changes found in Patchwork_113238v1 that come from known issues:
> >
> > ### IGT changes ###
> >
> > #### Issues hit ####
> >
> > * igt@gem_huc_copy@huc-copy:
> > - fi-kbl-soraka: NOTRUN -> [SKIP][1] ([fdo#109271] / [i915#2190])
> > [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html
> >
> > * igt@gem_lmem_swapping@basic:
> > - fi-kbl-soraka: NOTRUN -> [SKIP][2] ([fdo#109271] / [i915#4613]) +3 similar issues
> > [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/fi-kbl-soraka/igt@gem_lmem_swapping@basic.html
> >
> > * igt@i915_selftest@live@gt_pm:
> > - fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][3] ([i915#1886])
> > [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html
> >
> > * igt@i915_selftest@live@guc_multi_lrc:
> > - fi-kbl-soraka: NOTRUN -> [INCOMPLETE][4] ([i915#7640])
> > [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/fi-kbl-soraka/igt@i915_selftest@live@guc_multi_lrc.html
> >
> > * igt@i915_selftest@live@hangcheck:
> > - fi-rkl-guc: [PASS][5] -> [INCOMPLETE][6] ([i915#4983])
> > [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12624/fi-rkl-guc/igt@i915_selftest@live@hangcheck.html
> > [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/fi-rkl-guc/igt@i915_selftest@live@hangcheck.html
> >
> > * igt@kms_chamelium_frames@hdmi-crc-fast:
> > - fi-kbl-soraka: NOTRUN -> [SKIP][7] ([fdo#109271]) +15 similar issues
> > [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/fi-kbl-soraka/igt@kms_chamelium_frames@hdmi-crc-fast.html
> >
> > * igt@kms_psr@primary_page_flip:
> > - fi-pnv-d510: NOTRUN -> [SKIP][8] ([fdo#109271]) +44 similar issues
> > [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/fi-pnv-d510/igt@kms_psr@primary_page_flip.html
> >
> >
> > #### Possible fixes ####
> >
> > * igt@i915_selftest@live@gt_mocs:
> > - {bat-rpls-1}: [DMESG-FAIL][9] ([i915#7059]) -> [PASS][10]
> > [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12624/bat-rpls-1/igt@i915_selftest@live@gt_mocs.html
> > [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/bat-rpls-1/igt@i915_selftest@live@gt_mocs.html
> >
> > * igt@i915_selftest@live@requests:
> > - {bat-rpls-2}: [INCOMPLETE][11] ([i915#6257]) -> [PASS][12]
> > [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12624/bat-rpls-2/igt@i915_selftest@live@requests.html
> > [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/bat-rpls-2/igt@i915_selftest@live@requests.html
> > - {bat-rpls-1}: [INCOMPLETE][13] ([i915#4983]) -> [PASS][14]
> > [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12624/bat-rpls-1/igt@i915_selftest@live@requests.html
> > [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/bat-rpls-1/igt@i915_selftest@live@requests.html
> >
> > * igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions:
> > - fi-bsw-kefka: [FAIL][15] ([i915#6298]) -> [PASS][16]
> > [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12624/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions.html
> > [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions.html
> >
> >
> > {name}: This element is suppressed. This means it is ignored when computing
> > the status of the difference (SUCCESS, WARNING, or FAILURE).
> >
> > [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
> > [i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
> > [i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
> > [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
> > [i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
> > [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
> > [i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
> > [i915#6257]: https://gitlab.freedesktop.org/drm/intel/issues/6257
> > [i915#6298]: https://gitlab.freedesktop.org/drm/intel/issues/6298
> > [i915#6997]: https://gitlab.freedesktop.org/drm/intel/issues/6997
> > [i915#7059]: https://gitlab.freedesktop.org/drm/intel/issues/7059
> > [i915#7640]: https://gitlab.freedesktop.org/drm/intel/issues/7640
> > [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
> >
> >
> > Build changes
> > -------------
> >
> > * Linux: CI_DRM_12624 -> Patchwork_113238v1
> >
> > CI-20190529: 20190529
> > CI_DRM_12624: 18fa3d2237f6df82980349f6bef5281096dfc91d @ git://anongit.freedesktop.org/gfx-ci/linux
> > IGT_7134: 61b8c0a0c8a9611c47749c0b1a262843892cccd7 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
> > Patchwork_113238v1: 18fa3d2237f6df82980349f6bef5281096dfc91d @ git://anongit.freedesktop.org/gfx-ci/linux
> >
> >
> > ### Linux commits
> >
> > 2b1f15adacc1 drm/i915/dmc: Use unversioned path for ADLP
> > e1384510d25a drm/i915/dmc: Prepare to use unversioned paths
> >
> > == Logs ==
> >
> > For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_113238v1/index.html
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BUILD: failure for Use unversioned blob path for ADLP DMC (rev2)
2023-01-23 18:20 [Intel-gfx] [PATCH 0/2] Use unversioned blob path for ADLP DMC Gustavo Sousa
` (3 preceding siblings ...)
2023-01-24 4:58 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
@ 2023-01-27 19:10 ` Patchwork
4 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2023-01-27 19:10 UTC (permalink / raw)
To: Gustavo Sousa; +Cc: intel-gfx
== Series Details ==
Series: Use unversioned blob path for ADLP DMC (rev2)
URL : https://patchwork.freedesktop.org/series/113238/
State : failure
== Summary ==
Error: patch https://patchwork.freedesktop.org/api/1.0/series/113238/revisions/2/mbox/ not applied
Applying: drm/i915/dmc: Prepare to use unversioned paths
Using index info to reconstruct a base tree...
M drivers/gpu/drm/i915/display/intel_dmc.c
Falling back to patching base and 3-way merge...
Auto-merging drivers/gpu/drm/i915/display/intel_dmc.c
CONFLICT (content): Merge conflict in drivers/gpu/drm/i915/display/intel_dmc.c
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 drm/i915/dmc: Prepare to use unversioned paths
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2023-01-27 19:10 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-23 18:20 [Intel-gfx] [PATCH 0/2] Use unversioned blob path for ADLP DMC Gustavo Sousa
2023-01-23 18:20 ` [Intel-gfx] [PATCH 1/2] drm/i915/dmc: Prepare to use unversioned paths Gustavo Sousa
2023-01-23 20:50 ` Rodrigo Vivi
2023-01-23 18:20 ` [Intel-gfx] [PATCH 2/2] drm/i915/dmc: Use unversioned path for ADLP Gustavo Sousa
2023-01-23 20:50 ` Rodrigo Vivi
2023-01-23 20:19 ` [Intel-gfx] ✓ Fi.CI.BAT: success for Use unversioned blob path for ADLP DMC Patchwork
2023-01-24 16:39 ` Gustavo Sousa
2023-01-24 19:47 ` Rodrigo Vivi
2023-01-24 4:58 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2023-01-27 19:10 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for Use unversioned blob path for ADLP DMC (rev2) Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox