* [Intel-gfx] [PATCH v2] drm/i915: implement async_flip mode per plane tracking
@ 2023-01-11 16:22 Andrzej Hajda
2023-01-11 17:13 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: implement async_flip mode per plane tracking (rev2) Patchwork
` (5 more replies)
0 siblings, 6 replies; 10+ messages in thread
From: Andrzej Hajda @ 2023-01-11 16:22 UTC (permalink / raw)
To: intel-gfx, Ville Syrjälä; +Cc: Andrzej Hajda, Rodrigo Vivi
Current implementation of async flip w/a relies on assumption that
previous atomic commit contains valid information if async_flip is still
enabled on the plane. It is incorrect. If previous commit did not modify
the plane its state->uapi.async_flip can be false. As a result DMAR/PIPE
errors can be observed:
i915 0000:00:02.0: [drm] *ERROR* Fault errors on pipe A: 0x00000080
i915 0000:00:02.0: [drm] *ERROR* Fault errors on pipe A: 0x00000080
DMAR: DRHD: handling fault status reg 2
DMAR: [DMA Read NO_PASID] Request device [00:02.0] fault addr 0x0 [fault reason 0x06] PTE Read access is not set
v2: update async_flip_planes in more reliable places (Ville)
Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
---
drivers/gpu/drm/i915/display/intel_atomic_plane.c | 5 ++++-
drivers/gpu/drm/i915/display/intel_display.c | 7 ++++---
drivers/gpu/drm/i915/display/intel_display_types.h | 3 +++
3 files changed, 11 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_atomic_plane.c b/drivers/gpu/drm/i915/display/intel_atomic_plane.c
index 10e1fc9d069827..3f1b1548ede025 100644
--- a/drivers/gpu/drm/i915/display/intel_atomic_plane.c
+++ b/drivers/gpu/drm/i915/display/intel_atomic_plane.c
@@ -362,6 +362,7 @@ void intel_plane_set_invisible(struct intel_crtc_state *crtc_state,
crtc_state->scaled_planes &= ~BIT(plane->id);
crtc_state->nv12_planes &= ~BIT(plane->id);
crtc_state->c8_planes &= ~BIT(plane->id);
+ crtc_state->async_flip_planes &= ~BIT(plane->id);
crtc_state->data_rate[plane->id] = 0;
crtc_state->data_rate_y[plane->id] = 0;
crtc_state->rel_data_rate[plane->id] = 0;
@@ -581,8 +582,10 @@ static int intel_plane_atomic_calc_changes(const struct intel_crtc_state *old_cr
intel_plane_is_scaled(new_plane_state))))
new_crtc_state->disable_lp_wm = true;
- if (intel_plane_do_async_flip(plane, old_crtc_state, new_crtc_state))
+ if (intel_plane_do_async_flip(plane, old_crtc_state, new_crtc_state)) {
new_crtc_state->do_async_flip = true;
+ new_crtc_state->async_flip_planes |= BIT(plane->id);
+ }
return 0;
}
diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index e75b9b2a0e015a..e1c3b1b0b6a8f1 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -1303,7 +1303,8 @@ static void intel_crtc_async_flip_disable_wa(struct intel_atomic_state *state,
intel_atomic_get_old_crtc_state(state, crtc);
const struct intel_crtc_state *new_crtc_state =
intel_atomic_get_new_crtc_state(state, crtc);
- u8 update_planes = new_crtc_state->update_planes;
+ u8 disable_async_flip_planes = old_crtc_state->async_flip_planes &
+ ~new_crtc_state->async_flip_planes;
const struct intel_plane_state *old_plane_state;
struct intel_plane *plane;
bool need_vbl_wait = false;
@@ -1312,7 +1313,7 @@ static void intel_crtc_async_flip_disable_wa(struct intel_atomic_state *state,
for_each_old_intel_plane_in_state(state, plane, old_plane_state, i) {
if (plane->need_async_flip_disable_wa &&
plane->pipe == crtc->pipe &&
- update_planes & BIT(plane->id)) {
+ disable_async_flip_planes & BIT(plane->id)) {
/*
* Apart from the async flip bit we want to
* preserve the old state for the plane.
@@ -1429,7 +1430,7 @@ static void intel_pre_plane_update(struct intel_atomic_state *state,
* WA for platforms where async address update enable bit
* is double buffered and only latched at start of vblank.
*/
- if (old_crtc_state->uapi.async_flip && !new_crtc_state->uapi.async_flip)
+ if (old_crtc_state->async_flip_planes & ~new_crtc_state->async_flip_planes)
intel_crtc_async_flip_disable_wa(state, crtc);
}
diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h
index 32e8b2fc3cc642..61b1a0ec3dede1 100644
--- a/drivers/gpu/drm/i915/display/intel_display_types.h
+++ b/drivers/gpu/drm/i915/display/intel_display_types.h
@@ -1248,6 +1248,9 @@ struct intel_crtc_state {
/* bitmask of planes that will be updated during the commit */
u8 update_planes;
+ /* bitmask of planes with async flip active */
+ u8 async_flip_planes;
+
u8 framestart_delay; /* 1-4 */
u8 msa_timing_delay; /* 0-3 */
--
2.34.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: implement async_flip mode per plane tracking (rev2)
2023-01-11 16:22 [Intel-gfx] [PATCH v2] drm/i915: implement async_flip mode per plane tracking Andrzej Hajda
@ 2023-01-11 17:13 ` Patchwork
2023-01-11 17:40 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
` (4 subsequent siblings)
5 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2023-01-11 17:13 UTC (permalink / raw)
To: Andrzej Hajda; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: implement async_flip mode per plane tracking (rev2)
URL : https://patchwork.freedesktop.org/series/108371/
State : warning
== Summary ==
Error: dim checkpatch failed
a083ebdf19ad drm/i915: implement async_flip mode per plane tracking
-:14: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#14:
DMAR: [DMA Read NO_PASID] Request device [00:02.0] fault addr 0x0 [fault reason 0x06] PTE Read access is not set
total: 0 errors, 1 warnings, 0 checks, 52 lines checked
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: implement async_flip mode per plane tracking (rev2)
2023-01-11 16:22 [Intel-gfx] [PATCH v2] drm/i915: implement async_flip mode per plane tracking Andrzej Hajda
2023-01-11 17:13 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: implement async_flip mode per plane tracking (rev2) Patchwork
@ 2023-01-11 17:40 ` Patchwork
2023-01-12 10:01 ` Andrzej Hajda
2023-01-23 15:10 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: implement async_flip mode per plane tracking (rev3) Patchwork
` (3 subsequent siblings)
5 siblings, 1 reply; 10+ messages in thread
From: Patchwork @ 2023-01-11 17:40 UTC (permalink / raw)
To: Andrzej Hajda; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 4897 bytes --]
== Series Details ==
Series: drm/i915: implement async_flip mode per plane tracking (rev2)
URL : https://patchwork.freedesktop.org/series/108371/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12573 -> Patchwork_108371v2
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_108371v2 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_108371v2, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v2/index.html
Participating hosts (34 -> 33)
------------------------------
Additional (1): fi-kbl-soraka
Missing (2): fi-rkl-11600 fi-snb-2520m
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_108371v2:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@guc:
- fi-kbl-soraka: NOTRUN -> [INCOMPLETE][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v2/fi-kbl-soraka/igt@i915_selftest@live@guc.html
Known issues
------------
Here are the changes found in Patchwork_108371v2 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_huc_copy@huc-copy:
- fi-kbl-soraka: NOTRUN -> [SKIP][2] ([fdo#109271] / [i915#2190])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v2/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@basic:
- fi-kbl-soraka: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#4613]) +3 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v2/fi-kbl-soraka/igt@gem_lmem_swapping@basic.html
* igt@i915_selftest@live@gt_heartbeat:
- fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][4] ([i915#5334])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v2/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html
* igt@i915_selftest@live@gt_pm:
- fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][5] ([i915#1886])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v2/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html
* igt@kms_chamelium_frames@hdmi-crc-fast:
- fi-kbl-soraka: NOTRUN -> [SKIP][6] ([fdo#109271]) +15 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v2/fi-kbl-soraka/igt@kms_chamelium_frames@hdmi-crc-fast.html
* igt@kms_chamelium_hpd@common-hpd-after-suspend:
- fi-rkl-guc: NOTRUN -> [SKIP][7] ([i915#7828])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v2/fi-rkl-guc/igt@kms_chamelium_hpd@common-hpd-after-suspend.html
#### Possible fixes ####
* igt@i915_selftest@live@gt_lrc:
- fi-rkl-guc: [INCOMPLETE][8] ([i915#4983]) -> [PASS][9]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12573/fi-rkl-guc/igt@i915_selftest@live@gt_lrc.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v2/fi-rkl-guc/igt@i915_selftest@live@gt_lrc.html
* igt@i915_selftest@live@migrate:
- {bat-atsm-1}: [DMESG-FAIL][10] ([i915#7699]) -> [PASS][11]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12573/bat-atsm-1/igt@i915_selftest@live@migrate.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v2/bat-atsm-1/igt@i915_selftest@live@migrate.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#7699]: https://gitlab.freedesktop.org/drm/intel/issues/7699
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
Build changes
-------------
* Linux: CI_DRM_12573 -> Patchwork_108371v2
CI-20190529: 20190529
CI_DRM_12573: 05a39ecbd04e67fb44442617819fc138eca0ac61 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7116: 79eb8984acd309108be713a8831e60667db67e21 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_108371v2: 05a39ecbd04e67fb44442617819fc138eca0ac61 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
01304089b052 drm/i915: implement async_flip mode per plane tracking
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v2/index.html
[-- Attachment #2: Type: text/html, Size: 5815 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: implement async_flip mode per plane tracking (rev2)
2023-01-11 17:40 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
@ 2023-01-12 10:01 ` Andrzej Hajda
0 siblings, 0 replies; 10+ messages in thread
From: Andrzej Hajda @ 2023-01-12 10:01 UTC (permalink / raw)
To: intel-gfx, Patchwork
On 11.01.2023 18:40, Patchwork wrote:
> *Patch Details*
> *Series:* drm/i915: implement async_flip mode per plane tracking (rev2)
> *URL:* https://patchwork.freedesktop.org/series/108371/
> <https://patchwork.freedesktop.org/series/108371/>
> *State:* failure
> *Details:*
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v2/index.html
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v2/index.html>
>
>
> CI Bug Log - changes from CI_DRM_12573 -> Patchwork_108371v2
>
>
> Summary
>
> *FAILURE*
>
> Serious unknown changes coming with Patchwork_108371v2 absolutely need to be
> verified manually.
>
> If you think the reported changes have nothing to do with the changes
> introduced in Patchwork_108371v2, please notify your bug team to allow them
> to document this new failure mode, which will reduce false positives in CI.
>
> External URL:
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v2/index.html
>
>
> Participating hosts (34 -> 33)
>
> Additional (1): fi-kbl-soraka
> Missing (2): fi-rkl-11600 fi-snb-2520m
>
>
> Possible new issues
>
> Here are the unknown changes that may have been introduced in
> Patchwork_108371v2:
>
>
> IGT changes
>
>
> Possible regressions
>
> * igt@i915_selftest@live@guc:
> o fi-kbl-soraka: NOTRUN -> INCOMPLETE
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v2/fi-kbl-soraka/igt@i915_selftest@live@guc.html>
Again not related bug in fi-kbl-soraka and GuC [1] or more generally
live tests[2].
[1]:
https://lore.kernel.org/intel-gfx/?q=b%3A%22fi-kbl-soraka%2Figt%40i915_selftest%40live%40guc.html%22
[2]:
https://lore.kernel.org/intel-gfx/?q=b%3A%22fi-kbl-soraka%2Figt%40i915_selftest%40live%40%22
Regards
Andrzej
>
>
> Known issues
>
> Here are the changes found in Patchwork_108371v2 that come from known
> issues:
>
>
> IGT changes
>
>
> Issues hit
>
> *
>
> igt@gem_huc_copy@huc-copy:
>
> o fi-kbl-soraka: NOTRUN -> SKIP
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v2/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html> (fdo#109271 <https://bugs.freedesktop.org/show_bug.cgi?id=109271> / i915#2190 <https://gitlab.freedesktop.org/drm/intel/issues/2190>)
> *
>
> igt@gem_lmem_swapping@basic:
>
> o fi-kbl-soraka: NOTRUN -> SKIP
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v2/fi-kbl-soraka/igt@gem_lmem_swapping@basic.html> (fdo#109271 <https://bugs.freedesktop.org/show_bug.cgi?id=109271> / i915#4613 <https://gitlab.freedesktop.org/drm/intel/issues/4613>) +3 similar issues
> *
>
> igt@i915_selftest@live@gt_heartbeat:
>
> o fi-kbl-soraka: NOTRUN -> DMESG-FAIL
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v2/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html> (i915#5334 <https://gitlab.freedesktop.org/drm/intel/issues/5334>)
> *
>
> igt@i915_selftest@live@gt_pm:
>
> o fi-kbl-soraka: NOTRUN -> DMESG-FAIL
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v2/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html> (i915#1886 <https://gitlab.freedesktop.org/drm/intel/issues/1886>)
> *
>
> igt@kms_chamelium_frames@hdmi-crc-fast:
>
> o fi-kbl-soraka: NOTRUN -> SKIP
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v2/fi-kbl-soraka/igt@kms_chamelium_frames@hdmi-crc-fast.html> (fdo#109271 <https://bugs.freedesktop.org/show_bug.cgi?id=109271>) +15 similar issues
> *
>
> igt@kms_chamelium_hpd@common-hpd-after-suspend:
>
> o fi-rkl-guc: NOTRUN -> SKIP
> <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v2/fi-rkl-guc/igt@kms_chamelium_hpd@common-hpd-after-suspend.html> (i915#7828 <https://gitlab.freedesktop.org/drm/intel/issues/7828>)
>
>
> Possible fixes
>
> *
>
> igt@i915_selftest@live@gt_lrc:
>
> o fi-rkl-guc: INCOMPLETE
> <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12573/fi-rkl-guc/igt@i915_selftest@live@gt_lrc.html> (i915#4983 <https://gitlab.freedesktop.org/drm/intel/issues/4983>) -> PASS <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v2/fi-rkl-guc/igt@i915_selftest@live@gt_lrc.html>
> *
>
> igt@i915_selftest@live@migrate:
>
> o {bat-atsm-1}: DMESG-FAIL
> <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12573/bat-atsm-1/igt@i915_selftest@live@migrate.html> (i915#7699 <https://gitlab.freedesktop.org/drm/intel/issues/7699>) -> PASS <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v2/bat-atsm-1/igt@i915_selftest@live@migrate.html>
>
> {name}: This element is suppressed. This means it is ignored when computing
> the status of the difference (SUCCESS, WARNING, or FAILURE).
>
>
> Build changes
>
> * Linux: CI_DRM_12573 -> Patchwork_108371v2
>
> CI-20190529: 20190529
> CI_DRM_12573: 05a39ecbd04e67fb44442617819fc138eca0ac61 @
> git://anongit.freedesktop.org/gfx-ci/linux
> IGT_7116: 79eb8984acd309108be713a8831e60667db67e21 @
> https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
> Patchwork_108371v2: 05a39ecbd04e67fb44442617819fc138eca0ac61 @
> git://anongit.freedesktop.org/gfx-ci/linux
>
>
> Linux commits
>
> 01304089b052 drm/i915: implement async_flip mode per plane tracking
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: implement async_flip mode per plane tracking (rev3)
2023-01-11 16:22 [Intel-gfx] [PATCH v2] drm/i915: implement async_flip mode per plane tracking Andrzej Hajda
2023-01-11 17:13 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: implement async_flip mode per plane tracking (rev2) Patchwork
2023-01-11 17:40 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
@ 2023-01-23 15:10 ` Patchwork
2023-01-23 15:39 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
` (2 subsequent siblings)
5 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2023-01-23 15:10 UTC (permalink / raw)
To: Andrzej Hajda; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: implement async_flip mode per plane tracking (rev3)
URL : https://patchwork.freedesktop.org/series/108371/
State : warning
== Summary ==
Error: dim checkpatch failed
4169010b7b5e drm/i915: implement async_flip mode per plane tracking
-:14: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#14:
DMAR: [DMA Read NO_PASID] Request device [00:02.0] fault addr 0x0 [fault reason 0x06] PTE Read access is not set
total: 0 errors, 1 warnings, 0 checks, 52 lines checked
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: implement async_flip mode per plane tracking (rev3)
2023-01-11 16:22 [Intel-gfx] [PATCH v2] drm/i915: implement async_flip mode per plane tracking Andrzej Hajda
` (2 preceding siblings ...)
2023-01-23 15:10 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: implement async_flip mode per plane tracking (rev3) Patchwork
@ 2023-01-23 15:39 ` Patchwork
2023-01-24 3:19 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2023-01-24 14:02 ` [Intel-gfx] [PATCH v2] drm/i915: implement async_flip mode per plane tracking Ville Syrjälä
5 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2023-01-23 15:39 UTC (permalink / raw)
To: Andrzej Hajda; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 4886 bytes --]
== Series Details ==
Series: drm/i915: implement async_flip mode per plane tracking (rev3)
URL : https://patchwork.freedesktop.org/series/108371/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12622 -> Patchwork_108371v3
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v3/index.html
Participating hosts (39 -> 38)
------------------------------
Missing (1): fi-snb-2520m
Known issues
------------
Here are the changes found in Patchwork_108371v3 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_chamelium_hpd@common-hpd-after-suspend:
- fi-rkl-11600: NOTRUN -> [SKIP][1] ([i915#7828])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v3/fi-rkl-11600/igt@kms_chamelium_hpd@common-hpd-after-suspend.html
#### Possible fixes ####
* igt@i915_module_load@load:
- fi-ctg-p8600: [DMESG-WARN][2] ([i915#6020]) -> [PASS][3]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12622/fi-ctg-p8600/igt@i915_module_load@load.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v3/fi-ctg-p8600/igt@i915_module_load@load.html
* igt@i915_selftest@live@migrate:
- {bat-dg2-11}: [DMESG-WARN][4] ([i915#7699]) -> [PASS][5]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12622/bat-dg2-11/igt@i915_selftest@live@migrate.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v3/bat-dg2-11/igt@i915_selftest@live@migrate.html
* igt@i915_selftest@live@mman:
- fi-rkl-guc: [TIMEOUT][6] ([i915#6794]) -> [PASS][7]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12622/fi-rkl-guc/igt@i915_selftest@live@mman.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v3/fi-rkl-guc/igt@i915_selftest@live@mman.html
* igt@i915_selftest@live@requests:
- {bat-rpls-2}: [INCOMPLETE][8] ([i915#6257]) -> [PASS][9]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12622/bat-rpls-2/igt@i915_selftest@live@requests.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v3/bat-rpls-2/igt@i915_selftest@live@requests.html
* igt@i915_selftest@live@slpc:
- {bat-rpls-1}: [DMESG-FAIL][10] ([i915#6367]) -> [PASS][11]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12622/bat-rpls-1/igt@i915_selftest@live@slpc.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v3/bat-rpls-1/igt@i915_selftest@live@slpc.html
* igt@i915_suspend@basic-s3-without-i915:
- fi-rkl-11600: [INCOMPLETE][12] ([i915#4817]) -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12622/fi-rkl-11600/igt@i915_suspend@basic-s3-without-i915.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v3/fi-rkl-11600/igt@i915_suspend@basic-s3-without-i915.html
* igt@kms_pipe_crc_basic@suspend-read-crc@pipe-d-hdmi-a-2:
- bat-dg1-5: [FAIL][14] ([fdo#103375]) -> [PASS][15] +3 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12622/bat-dg1-5/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-d-hdmi-a-2.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v3/bat-dg1-5/igt@kms_pipe_crc_basic@suspend-read-crc@pipe-d-hdmi-a-2.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#4817]: https://gitlab.freedesktop.org/drm/intel/issues/4817
[i915#6020]: https://gitlab.freedesktop.org/drm/intel/issues/6020
[i915#6257]: https://gitlab.freedesktop.org/drm/intel/issues/6257
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6794]: https://gitlab.freedesktop.org/drm/intel/issues/6794
[i915#6997]: https://gitlab.freedesktop.org/drm/intel/issues/6997
[i915#7699]: https://gitlab.freedesktop.org/drm/intel/issues/7699
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
Build changes
-------------
* Linux: CI_DRM_12622 -> Patchwork_108371v3
CI-20190529: 20190529
CI_DRM_12622: 93e8ce8fb03496d8d0ccf15e7363563af90a4f8f @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7131: 13b07163b012f6a195463bc14c06b84ecbd9f094 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_108371v3: 93e8ce8fb03496d8d0ccf15e7363563af90a4f8f @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
8341acf98e17 drm/i915: implement async_flip mode per plane tracking
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v3/index.html
[-- Attachment #2: Type: text/html, Size: 5482 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: implement async_flip mode per plane tracking (rev3)
2023-01-11 16:22 [Intel-gfx] [PATCH v2] drm/i915: implement async_flip mode per plane tracking Andrzej Hajda
` (3 preceding siblings ...)
2023-01-23 15:39 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2023-01-24 3:19 ` Patchwork
2023-01-24 14:02 ` [Intel-gfx] [PATCH v2] drm/i915: implement async_flip mode per plane tracking Ville Syrjälä
5 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2023-01-24 3:19 UTC (permalink / raw)
To: Andrzej Hajda; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 25908 bytes --]
== Series Details ==
Series: drm/i915: implement async_flip mode per plane tracking (rev3)
URL : https://patchwork.freedesktop.org/series/108371/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12622_full -> Patchwork_108371v3_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v3/index.html
Participating hosts (12 -> 10)
------------------------------
Missing (2): pig-skl-6260u pig-kbl-iris
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_108371v3_full:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@kms_vblank@pipe-d-ts-continuation-suspend:
- {shard-dg1}: NOTRUN -> [DMESG-WARN][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v3/shard-dg1-15/igt@kms_vblank@pipe-d-ts-continuation-suspend.html
Known issues
------------
Here are the changes found in Patchwork_108371v3_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_fair@basic-none@rcs0:
- shard-glk: [PASS][2] -> [FAIL][3] ([i915#2842])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12622/shard-glk5/igt@gem_exec_fair@basic-none@rcs0.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v3/shard-glk6/igt@gem_exec_fair@basic-none@rcs0.html
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-glk: NOTRUN -> [FAIL][4] ([i915#2842])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v3/shard-glk7/igt@gem_exec_fair@basic-pace-solo@rcs0.html
* igt@gem_exec_suspend@basic-s3-devices@smem:
- shard-glk: [PASS][5] -> [DMESG-WARN][6] ([i915#118])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12622/shard-glk6/igt@gem_exec_suspend@basic-s3-devices@smem.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v3/shard-glk8/igt@gem_exec_suspend@basic-s3-devices@smem.html
* igt@gen9_exec_parse@allowed-single:
- shard-glk: [PASS][7] -> [DMESG-WARN][8] ([i915#5566] / [i915#716])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12622/shard-glk8/igt@gen9_exec_parse@allowed-single.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v3/shard-glk2/igt@gen9_exec_parse@allowed-single.html
* igt@kms_ccs@pipe-c-missing-ccs-buffer-y_tiled_gen12_mc_ccs:
- shard-glk: NOTRUN -> [SKIP][9] ([fdo#109271] / [i915#3886])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v3/shard-glk7/igt@kms_ccs@pipe-c-missing-ccs-buffer-y_tiled_gen12_mc_ccs.html
* igt@kms_flip@2x-flip-vs-expired-vblank@ac-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][10] -> [FAIL][11] ([i915#79]) +1 similar issue
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12622/shard-glk7/igt@kms_flip@2x-flip-vs-expired-vblank@ac-hdmi-a1-hdmi-a2.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v3/shard-glk5/igt@kms_flip@2x-flip-vs-expired-vblank@ac-hdmi-a1-hdmi-a2.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-draw-mmap-wc:
- shard-glk: NOTRUN -> [SKIP][12] ([fdo#109271]) +32 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v3/shard-glk7/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-draw-mmap-wc.html
* igt@sysfs_clients@pidname:
- shard-glk: NOTRUN -> [SKIP][13] ([fdo#109271] / [i915#2994])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v3/shard-glk7/igt@sysfs_clients@pidname.html
#### Possible fixes ####
* igt@fbdev@read:
- {shard-rkl}: [SKIP][14] ([i915#2582]) -> [PASS][15] +1 similar issue
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12622/shard-rkl-1/igt@fbdev@read.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v3/shard-rkl-6/igt@fbdev@read.html
- {shard-tglu}: [SKIP][16] ([i915#2582]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12622/shard-tglu-6/igt@fbdev@read.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v3/shard-tglu-1/igt@fbdev@read.html
* igt@gem_ctx_exec@basic-nohangcheck:
- {shard-rkl}: [FAIL][18] ([i915#6268]) -> [PASS][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12622/shard-rkl-6/igt@gem_ctx_exec@basic-nohangcheck.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v3/shard-rkl-5/igt@gem_ctx_exec@basic-nohangcheck.html
* igt@gem_exec_fair@basic-none-vip@rcs0:
- {shard-rkl}: [FAIL][20] ([i915#2842]) -> [PASS][21]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12622/shard-rkl-6/igt@gem_exec_fair@basic-none-vip@rcs0.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v3/shard-rkl-5/igt@gem_exec_fair@basic-none-vip@rcs0.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [FAIL][22] ([i915#2842]) -> [PASS][23]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12622/shard-glk7/igt@gem_exec_fair@basic-pace-share@rcs0.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v3/shard-glk7/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_reloc@basic-scanout@vcs0:
- {shard-tglu}: [SKIP][24] ([i915#3639]) -> [PASS][25] +4 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12622/shard-tglu-6/igt@gem_exec_reloc@basic-scanout@vcs0.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v3/shard-tglu-1/igt@gem_exec_reloc@basic-scanout@vcs0.html
* igt@gem_mmap_gtt@coherency:
- {shard-rkl}: [SKIP][26] ([fdo#111656]) -> [PASS][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12622/shard-rkl-6/igt@gem_mmap_gtt@coherency.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v3/shard-rkl-5/igt@gem_mmap_gtt@coherency.html
* igt@gem_pread@bench:
- {shard-rkl}: [SKIP][28] ([i915#3282]) -> [PASS][29] +5 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12622/shard-rkl-6/igt@gem_pread@bench.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v3/shard-rkl-5/igt@gem_pread@bench.html
* igt@gem_userptr_blits@relocations:
- {shard-rkl}: [SKIP][30] ([i915#3281]) -> [PASS][31] +2 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12622/shard-rkl-1/igt@gem_userptr_blits@relocations.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v3/shard-rkl-5/igt@gem_userptr_blits@relocations.html
* igt@gen9_exec_parse@batch-invalid-length:
- {shard-rkl}: [SKIP][32] ([i915#2527]) -> [PASS][33] +3 similar issues
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12622/shard-rkl-1/igt@gen9_exec_parse@batch-invalid-length.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v3/shard-rkl-5/igt@gen9_exec_parse@batch-invalid-length.html
* igt@i915_hangman@gt-engine-error@bcs0:
- {shard-rkl}: [SKIP][34] ([i915#6258]) -> [PASS][35]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12622/shard-rkl-5/igt@i915_hangman@gt-engine-error@bcs0.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v3/shard-rkl-1/igt@i915_hangman@gt-engine-error@bcs0.html
* igt@i915_pm_dc@dc6-dpms:
- {shard-rkl}: [SKIP][36] ([i915#3361]) -> [PASS][37] +1 similar issue
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12622/shard-rkl-5/igt@i915_pm_dc@dc6-dpms.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v3/shard-rkl-2/igt@i915_pm_dc@dc6-dpms.html
* igt@i915_pm_sseu@full-enable:
- {shard-rkl}: [SKIP][38] ([i915#4387]) -> [PASS][39]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12622/shard-rkl-1/igt@i915_pm_sseu@full-enable.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v3/shard-rkl-5/igt@i915_pm_sseu@full-enable.html
* igt@kms_async_flips@alternate-sync-async-flip@pipe-a-hdmi-a-1:
- shard-glk: [FAIL][40] ([i915#2521]) -> [PASS][41]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12622/shard-glk9/igt@kms_async_flips@alternate-sync-async-flip@pipe-a-hdmi-a-1.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v3/shard-glk5/igt@kms_async_flips@alternate-sync-async-flip@pipe-a-hdmi-a-1.html
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy:
- shard-glk: [FAIL][42] ([i915#72]) -> [PASS][43]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12622/shard-glk4/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v3/shard-glk4/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy.html
* igt@kms_cursor_legacy@flip-vs-cursor-crc-atomic:
- {shard-tglu}: [SKIP][44] ([i915#1845]) -> [PASS][45]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12622/shard-tglu-6/igt@kms_cursor_legacy@flip-vs-cursor-crc-atomic.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v3/shard-tglu-1/igt@kms_cursor_legacy@flip-vs-cursor-crc-atomic.html
* igt@kms_cursor_legacy@flip-vs-cursor-crc-legacy:
- {shard-tglu}: [SKIP][46] ([i915#1845] / [i915#7651]) -> [PASS][47] +6 similar issues
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12622/shard-tglu-6/igt@kms_cursor_legacy@flip-vs-cursor-crc-legacy.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v3/shard-tglu-5/igt@kms_cursor_legacy@flip-vs-cursor-crc-legacy.html
* igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size:
- shard-glk: [FAIL][48] ([i915#2346]) -> [PASS][49]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12622/shard-glk3/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v3/shard-glk9/igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions-varying-size.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-plflip-blt:
- {shard-tglu}: [SKIP][50] ([i915#1849]) -> [PASS][51] +4 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12622/shard-tglu-6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-plflip-blt.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v3/shard-tglu-5/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-plflip-blt.html
* igt@kms_frontbuffer_tracking@fbc-badstride:
- {shard-rkl}: [SKIP][52] ([i915#1849] / [i915#4098]) -> [PASS][53] +13 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12622/shard-rkl-3/igt@kms_frontbuffer_tracking@fbc-badstride.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v3/shard-rkl-6/igt@kms_frontbuffer_tracking@fbc-badstride.html
* igt@kms_plane@pixel-format@pipe-b-planes:
- {shard-rkl}: [SKIP][54] ([i915#1849]) -> [PASS][55] +3 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12622/shard-rkl-1/igt@kms_plane@pixel-format@pipe-b-planes.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v3/shard-rkl-6/igt@kms_plane@pixel-format@pipe-b-planes.html
- {shard-tglu}: [SKIP][56] ([i915#1849] / [i915#3558]) -> [PASS][57] +1 similar issue
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12622/shard-tglu-6/igt@kms_plane@pixel-format@pipe-b-planes.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v3/shard-tglu-1/igt@kms_plane@pixel-format@pipe-b-planes.html
* igt@kms_psr@sprite_mmap_gtt:
- {shard-rkl}: [SKIP][58] ([i915#1072]) -> [PASS][59] +1 similar issue
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12622/shard-rkl-3/igt@kms_psr@sprite_mmap_gtt.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v3/shard-rkl-6/igt@kms_psr@sprite_mmap_gtt.html
* igt@kms_rotation_crc@primary-rotation-90:
- {shard-rkl}: [SKIP][60] ([i915#1845] / [i915#4098]) -> [PASS][61] +18 similar issues
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12622/shard-rkl-1/igt@kms_rotation_crc@primary-rotation-90.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v3/shard-rkl-6/igt@kms_rotation_crc@primary-rotation-90.html
* igt@kms_universal_plane@universal-plane-pipe-a-functional:
- {shard-tglu}: [SKIP][62] ([fdo#109274]) -> [PASS][63] +1 similar issue
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12622/shard-tglu-6/igt@kms_universal_plane@universal-plane-pipe-a-functional.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v3/shard-tglu-5/igt@kms_universal_plane@universal-plane-pipe-a-functional.html
* igt@kms_vblank@invalid:
- {shard-tglu}: [SKIP][64] ([i915#7651]) -> [PASS][65] +20 similar issues
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12622/shard-tglu-6/igt@kms_vblank@invalid.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v3/shard-tglu-5/igt@kms_vblank@invalid.html
* igt@perf@gen12-oa-tlb-invalidate:
- {shard-rkl}: [SKIP][66] ([fdo#109289]) -> [PASS][67]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12622/shard-rkl-5/igt@perf@gen12-oa-tlb-invalidate.html
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v3/shard-rkl-2/igt@perf@gen12-oa-tlb-invalidate.html
* igt@perf@gen8-unprivileged-single-ctx-counters:
- {shard-rkl}: [SKIP][68] ([i915#2436]) -> [PASS][69]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12622/shard-rkl-6/igt@perf@gen8-unprivileged-single-ctx-counters.html
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v3/shard-rkl-5/igt@perf@gen8-unprivileged-single-ctx-counters.html
* igt@perf@polling-small-buf:
- {shard-rkl}: [FAIL][70] ([i915#1722]) -> [PASS][71]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12622/shard-rkl-1/igt@perf@polling-small-buf.html
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v3/shard-rkl-5/igt@perf@polling-small-buf.html
* igt@perf@stress-open-close:
- shard-glk: [INCOMPLETE][72] ([i915#5213]) -> [PASS][73]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12622/shard-glk9/igt@perf@stress-open-close.html
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v3/shard-glk7/igt@perf@stress-open-close.html
* igt@prime_vgem@basic-fence-flip:
- {shard-tglu}: [SKIP][74] ([fdo#109295]) -> [PASS][75]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12622/shard-tglu-6/igt@prime_vgem@basic-fence-flip.html
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v3/shard-tglu-1/igt@prime_vgem@basic-fence-flip.html
- {shard-rkl}: [SKIP][76] ([fdo#109295] / [i915#3708] / [i915#4098]) -> [PASS][77]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12622/shard-rkl-1/igt@prime_vgem@basic-fence-flip.html
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v3/shard-rkl-6/igt@prime_vgem@basic-fence-flip.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[IGT#2]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/2
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109302]: https://bugs.freedesktop.org/show_bug.cgi?id=109302
[fdo#109307]: https://bugs.freedesktop.org/show_bug.cgi?id=109307
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644
[fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1722]: https://gitlab.freedesktop.org/drm/intel/issues/1722
[i915#1769]: https://gitlab.freedesktop.org/drm/intel/issues/1769
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1902]: https://gitlab.freedesktop.org/drm/intel/issues/1902
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2434]: https://gitlab.freedesktop.org/drm/intel/issues/2434
[i915#2436]: https://gitlab.freedesktop.org/drm/intel/issues/2436
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3361]: https://gitlab.freedesktop.org/drm/intel/issues/3361
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3528]: https://gitlab.freedesktop.org/drm/intel/issues/3528
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3639]: https://gitlab.freedesktop.org/drm/intel/issues/3639
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3804]: https://gitlab.freedesktop.org/drm/intel/issues/3804
[i915#3826]: https://gitlab.freedesktop.org/drm/intel/issues/3826
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#404]: https://gitlab.freedesktop.org/drm/intel/issues/404
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#426]: https://gitlab.freedesktop.org/drm/intel/issues/426
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#433]: https://gitlab.freedesktop.org/drm/intel/issues/433
[i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873
[i915#4877]: https://gitlab.freedesktop.org/drm/intel/issues/4877
[i915#4885]: https://gitlab.freedesktop.org/drm/intel/issues/4885
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5213]: https://gitlab.freedesktop.org/drm/intel/issues/5213
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5723]: https://gitlab.freedesktop.org/drm/intel/issues/5723
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
[i915#6258]: https://gitlab.freedesktop.org/drm/intel/issues/6258
[i915#6259]: https://gitlab.freedesktop.org/drm/intel/issues/6259
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6334]: https://gitlab.freedesktop.org/drm/intel/issues/6334
[i915#6344]: https://gitlab.freedesktop.org/drm/intel/issues/6344
[i915#6355]: https://gitlab.freedesktop.org/drm/intel/issues/6355
[i915#6493]: https://gitlab.freedesktop.org/drm/intel/issues/6493
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#6944]: https://gitlab.freedesktop.org/drm/intel/issues/6944
[i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953
[i915#7052]: https://gitlab.freedesktop.org/drm/intel/issues/7052
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7128]: https://gitlab.freedesktop.org/drm/intel/issues/7128
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#72]: https://gitlab.freedesktop.org/drm/intel/issues/72
[i915#7294]: https://gitlab.freedesktop.org/drm/intel/issues/7294
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7582]: https://gitlab.freedesktop.org/drm/intel/issues/7582
[i915#7651]: https://gitlab.freedesktop.org/drm/intel/issues/7651
[i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
[i915#7701]: https://gitlab.freedesktop.org/drm/intel/issues/7701
[i915#7707]: https://gitlab.freedesktop.org/drm/intel/issues/7707
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
Build changes
-------------
* Linux: CI_DRM_12622 -> Patchwork_108371v3
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_12622: 93e8ce8fb03496d8d0ccf15e7363563af90a4f8f @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7131: 13b07163b012f6a195463bc14c06b84ecbd9f094 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_108371v3: 93e8ce8fb03496d8d0ccf15e7363563af90a4f8f @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_108371v3/index.html
[-- Attachment #2: Type: text/html, Size: 20992 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH v2] drm/i915: implement async_flip mode per plane tracking
2023-01-11 16:22 [Intel-gfx] [PATCH v2] drm/i915: implement async_flip mode per plane tracking Andrzej Hajda
` (4 preceding siblings ...)
2023-01-24 3:19 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
@ 2023-01-24 14:02 ` Ville Syrjälä
2023-01-26 18:14 ` Andrzej Hajda
5 siblings, 1 reply; 10+ messages in thread
From: Ville Syrjälä @ 2023-01-24 14:02 UTC (permalink / raw)
To: Andrzej Hajda; +Cc: intel-gfx, Rodrigo Vivi
On Wed, Jan 11, 2023 at 05:22:47PM +0100, Andrzej Hajda wrote:
> Current implementation of async flip w/a relies on assumption that
> previous atomic commit contains valid information if async_flip is still
> enabled on the plane. It is incorrect. If previous commit did not modify
> the plane its state->uapi.async_flip can be false. As a result DMAR/PIPE
> errors can be observed:
> i915 0000:00:02.0: [drm] *ERROR* Fault errors on pipe A: 0x00000080
> i915 0000:00:02.0: [drm] *ERROR* Fault errors on pipe A: 0x00000080
> DMAR: DRHD: handling fault status reg 2
> DMAR: [DMA Read NO_PASID] Request device [00:02.0] fault addr 0x0 [fault reason 0x06] PTE Read access is not set
>
> v2: update async_flip_planes in more reliable places (Ville)
>
> Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_atomic_plane.c | 5 ++++-
> drivers/gpu/drm/i915/display/intel_display.c | 7 ++++---
> drivers/gpu/drm/i915/display/intel_display_types.h | 3 +++
> 3 files changed, 11 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_atomic_plane.c b/drivers/gpu/drm/i915/display/intel_atomic_plane.c
> index 10e1fc9d069827..3f1b1548ede025 100644
> --- a/drivers/gpu/drm/i915/display/intel_atomic_plane.c
> +++ b/drivers/gpu/drm/i915/display/intel_atomic_plane.c
> @@ -362,6 +362,7 @@ void intel_plane_set_invisible(struct intel_crtc_state *crtc_state,
> crtc_state->scaled_planes &= ~BIT(plane->id);
> crtc_state->nv12_planes &= ~BIT(plane->id);
> crtc_state->c8_planes &= ~BIT(plane->id);
> + crtc_state->async_flip_planes &= ~BIT(plane->id);
> crtc_state->data_rate[plane->id] = 0;
> crtc_state->data_rate_y[plane->id] = 0;
> crtc_state->rel_data_rate[plane->id] = 0;
> @@ -581,8 +582,10 @@ static int intel_plane_atomic_calc_changes(const struct intel_crtc_state *old_cr
> intel_plane_is_scaled(new_plane_state))))
> new_crtc_state->disable_lp_wm = true;
>
> - if (intel_plane_do_async_flip(plane, old_crtc_state, new_crtc_state))
> + if (intel_plane_do_async_flip(plane, old_crtc_state, new_crtc_state)) {
> new_crtc_state->do_async_flip = true;
> + new_crtc_state->async_flip_planes |= BIT(plane->id);
> + }
intel_modeset_all_pipes() and intel_color_add_affected_planes() would
need to clear this stuff as well. Can't immediately think of other
places that need the same treatment (the nv12 plane stuff I believe
should be fine without this since we should be rejecting async flips
with planar formats).
Though I think that is still going to have annoying ping-pong
for the the wm/ddb optimizations whenever there are internal
sync plane updates injected between async flips. I think to
sort that out fully we'd need to start tracking the last uapi
async flip state for each plane.
>
> return 0;
> }
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index e75b9b2a0e015a..e1c3b1b0b6a8f1 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -1303,7 +1303,8 @@ static void intel_crtc_async_flip_disable_wa(struct intel_atomic_state *state,
> intel_atomic_get_old_crtc_state(state, crtc);
> const struct intel_crtc_state *new_crtc_state =
> intel_atomic_get_new_crtc_state(state, crtc);
> - u8 update_planes = new_crtc_state->update_planes;
> + u8 disable_async_flip_planes = old_crtc_state->async_flip_planes &
> + ~new_crtc_state->async_flip_planes;
> const struct intel_plane_state *old_plane_state;
> struct intel_plane *plane;
> bool need_vbl_wait = false;
> @@ -1312,7 +1313,7 @@ static void intel_crtc_async_flip_disable_wa(struct intel_atomic_state *state,
> for_each_old_intel_plane_in_state(state, plane, old_plane_state, i) {
> if (plane->need_async_flip_disable_wa &&
> plane->pipe == crtc->pipe &&
> - update_planes & BIT(plane->id)) {
> + disable_async_flip_planes & BIT(plane->id)) {
> /*
> * Apart from the async flip bit we want to
> * preserve the old state for the plane.
> @@ -1429,7 +1430,7 @@ static void intel_pre_plane_update(struct intel_atomic_state *state,
> * WA for platforms where async address update enable bit
> * is double buffered and only latched at start of vblank.
> */
> - if (old_crtc_state->uapi.async_flip && !new_crtc_state->uapi.async_flip)
> + if (old_crtc_state->async_flip_planes & ~new_crtc_state->async_flip_planes)
> intel_crtc_async_flip_disable_wa(state, crtc);
> }
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h
> index 32e8b2fc3cc642..61b1a0ec3dede1 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_types.h
> +++ b/drivers/gpu/drm/i915/display/intel_display_types.h
> @@ -1248,6 +1248,9 @@ struct intel_crtc_state {
> /* bitmask of planes that will be updated during the commit */
> u8 update_planes;
>
> + /* bitmask of planes with async flip active */
> + u8 async_flip_planes;
> +
> u8 framestart_delay; /* 1-4 */
> u8 msa_timing_delay; /* 0-3 */
>
> --
> 2.34.1
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH v2] drm/i915: implement async_flip mode per plane tracking
2023-01-24 14:02 ` [Intel-gfx] [PATCH v2] drm/i915: implement async_flip mode per plane tracking Ville Syrjälä
@ 2023-01-26 18:14 ` Andrzej Hajda
2023-01-26 19:45 ` Ville Syrjälä
0 siblings, 1 reply; 10+ messages in thread
From: Andrzej Hajda @ 2023-01-26 18:14 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx, Rodrigo Vivi
On 24.01.2023 15:02, Ville Syrjälä wrote:
> On Wed, Jan 11, 2023 at 05:22:47PM +0100, Andrzej Hajda wrote:
>> Current implementation of async flip w/a relies on assumption that
>> previous atomic commit contains valid information if async_flip is still
>> enabled on the plane. It is incorrect. If previous commit did not modify
>> the plane its state->uapi.async_flip can be false. As a result DMAR/PIPE
>> errors can be observed:
>> i915 0000:00:02.0: [drm] *ERROR* Fault errors on pipe A: 0x00000080
>> i915 0000:00:02.0: [drm] *ERROR* Fault errors on pipe A: 0x00000080
>> DMAR: DRHD: handling fault status reg 2
>> DMAR: [DMA Read NO_PASID] Request device [00:02.0] fault addr 0x0 [fault reason 0x06] PTE Read access is not set
>>
>> v2: update async_flip_planes in more reliable places (Ville)
>>
>> Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
>> ---
>> drivers/gpu/drm/i915/display/intel_atomic_plane.c | 5 ++++-
>> drivers/gpu/drm/i915/display/intel_display.c | 7 ++++---
>> drivers/gpu/drm/i915/display/intel_display_types.h | 3 +++
>> 3 files changed, 11 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_atomic_plane.c b/drivers/gpu/drm/i915/display/intel_atomic_plane.c
>> index 10e1fc9d069827..3f1b1548ede025 100644
>> --- a/drivers/gpu/drm/i915/display/intel_atomic_plane.c
>> +++ b/drivers/gpu/drm/i915/display/intel_atomic_plane.c
>> @@ -362,6 +362,7 @@ void intel_plane_set_invisible(struct intel_crtc_state *crtc_state,
>> crtc_state->scaled_planes &= ~BIT(plane->id);
>> crtc_state->nv12_planes &= ~BIT(plane->id);
>> crtc_state->c8_planes &= ~BIT(plane->id);
>> + crtc_state->async_flip_planes &= ~BIT(plane->id);
>> crtc_state->data_rate[plane->id] = 0;
>> crtc_state->data_rate_y[plane->id] = 0;
>> crtc_state->rel_data_rate[plane->id] = 0;
>> @@ -581,8 +582,10 @@ static int intel_plane_atomic_calc_changes(const struct intel_crtc_state *old_cr
>> intel_plane_is_scaled(new_plane_state))))
>> new_crtc_state->disable_lp_wm = true;
>>
>> - if (intel_plane_do_async_flip(plane, old_crtc_state, new_crtc_state))
>> + if (intel_plane_do_async_flip(plane, old_crtc_state, new_crtc_state)) {
>> new_crtc_state->do_async_flip = true;
>> + new_crtc_state->async_flip_planes |= BIT(plane->id);
>> + }
>
> intel_modeset_all_pipes() and intel_color_add_affected_planes() would
> need to clear this stuff as well. Can't immediately think of other
I am not familiar with the display, so forgive me being verbose in
verification of your comments :)
1. In case of intel_modeset_all_pipes
for every crtc: crtc_state->async_flip_planes = 0;
2. In case of intel_color_add_affected_planes:
for every plane: new_crtc_state->async_flip_planes &= ~BIT(plane->id);
Are the changes OK?
> places that need the same treatment (the nv12 plane stuff I believe
> should be fine without this since we should be rejecting async flips
> with planar formats).
The driver is quite big and I quickly get lost when lurking into it, so
hard to comment it :)
>
> Though I think that is still going to have annoying ping-pong
> for the the wm/ddb optimizations whenever there are internal
> sync plane updates injected between async flips. I think to
Hmm, I hoped, that since intel_crtc_duplicate_state preserves
async_flip_planes ping-pong shouldn't happen.
> sort that out fully we'd need to start tracking the last uapi
> async flip state for each plane.
I hoped async_flip_planes should serve it, modulo it is not fully clear
to me when to switch async_flip. Enabling async flip is quite clear
(requested by user), but disabling:
- full modeset,
- sync fb update,
- plane disable,
- cases mentioned above,
- ?
Is it OK to send next version with added clearing code in
intel_modeset_all_pipes and intel_color_add_affected_planes ?
Regards
Andrzej
>
>>
>> return 0;
>> }
>> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
>> index e75b9b2a0e015a..e1c3b1b0b6a8f1 100644
>> --- a/drivers/gpu/drm/i915/display/intel_display.c
>> +++ b/drivers/gpu/drm/i915/display/intel_display.c
>> @@ -1303,7 +1303,8 @@ static void intel_crtc_async_flip_disable_wa(struct intel_atomic_state *state,
>> intel_atomic_get_old_crtc_state(state, crtc);
>> const struct intel_crtc_state *new_crtc_state =
>> intel_atomic_get_new_crtc_state(state, crtc);
>> - u8 update_planes = new_crtc_state->update_planes;
>> + u8 disable_async_flip_planes = old_crtc_state->async_flip_planes &
>> + ~new_crtc_state->async_flip_planes;
>> const struct intel_plane_state *old_plane_state;
>> struct intel_plane *plane;
>> bool need_vbl_wait = false;
>> @@ -1312,7 +1313,7 @@ static void intel_crtc_async_flip_disable_wa(struct intel_atomic_state *state,
>> for_each_old_intel_plane_in_state(state, plane, old_plane_state, i) {
>> if (plane->need_async_flip_disable_wa &&
>> plane->pipe == crtc->pipe &&
>> - update_planes & BIT(plane->id)) {
>> + disable_async_flip_planes & BIT(plane->id)) {
>> /*
>> * Apart from the async flip bit we want to
>> * preserve the old state for the plane.
>> @@ -1429,7 +1430,7 @@ static void intel_pre_plane_update(struct intel_atomic_state *state,
>> * WA for platforms where async address update enable bit
>> * is double buffered and only latched at start of vblank.
>> */
>> - if (old_crtc_state->uapi.async_flip && !new_crtc_state->uapi.async_flip)
>> + if (old_crtc_state->async_flip_planes & ~new_crtc_state->async_flip_planes)
>> intel_crtc_async_flip_disable_wa(state, crtc);
>> }
>>
>> diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h
>> index 32e8b2fc3cc642..61b1a0ec3dede1 100644
>> --- a/drivers/gpu/drm/i915/display/intel_display_types.h
>> +++ b/drivers/gpu/drm/i915/display/intel_display_types.h
>> @@ -1248,6 +1248,9 @@ struct intel_crtc_state {
>> /* bitmask of planes that will be updated during the commit */
>> u8 update_planes;
>>
>> + /* bitmask of planes with async flip active */
>> + u8 async_flip_planes;
>> +
>> u8 framestart_delay; /* 1-4 */
>> u8 msa_timing_delay; /* 0-3 */
>>
>> --
>> 2.34.1
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH v2] drm/i915: implement async_flip mode per plane tracking
2023-01-26 18:14 ` Andrzej Hajda
@ 2023-01-26 19:45 ` Ville Syrjälä
0 siblings, 0 replies; 10+ messages in thread
From: Ville Syrjälä @ 2023-01-26 19:45 UTC (permalink / raw)
To: Andrzej Hajda; +Cc: intel-gfx, Rodrigo Vivi
On Thu, Jan 26, 2023 at 07:14:30PM +0100, Andrzej Hajda wrote:
> On 24.01.2023 15:02, Ville Syrjälä wrote:
> > On Wed, Jan 11, 2023 at 05:22:47PM +0100, Andrzej Hajda wrote:
> >> Current implementation of async flip w/a relies on assumption that
> >> previous atomic commit contains valid information if async_flip is still
> >> enabled on the plane. It is incorrect. If previous commit did not modify
> >> the plane its state->uapi.async_flip can be false. As a result DMAR/PIPE
> >> errors can be observed:
> >> i915 0000:00:02.0: [drm] *ERROR* Fault errors on pipe A: 0x00000080
> >> i915 0000:00:02.0: [drm] *ERROR* Fault errors on pipe A: 0x00000080
> >> DMAR: DRHD: handling fault status reg 2
> >> DMAR: [DMA Read NO_PASID] Request device [00:02.0] fault addr 0x0 [fault reason 0x06] PTE Read access is not set
> >>
> >> v2: update async_flip_planes in more reliable places (Ville)
> >>
> >> Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
> >> ---
> >> drivers/gpu/drm/i915/display/intel_atomic_plane.c | 5 ++++-
> >> drivers/gpu/drm/i915/display/intel_display.c | 7 ++++---
> >> drivers/gpu/drm/i915/display/intel_display_types.h | 3 +++
> >> 3 files changed, 11 insertions(+), 4 deletions(-)
> >>
> >> diff --git a/drivers/gpu/drm/i915/display/intel_atomic_plane.c b/drivers/gpu/drm/i915/display/intel_atomic_plane.c
> >> index 10e1fc9d069827..3f1b1548ede025 100644
> >> --- a/drivers/gpu/drm/i915/display/intel_atomic_plane.c
> >> +++ b/drivers/gpu/drm/i915/display/intel_atomic_plane.c
> >> @@ -362,6 +362,7 @@ void intel_plane_set_invisible(struct intel_crtc_state *crtc_state,
> >> crtc_state->scaled_planes &= ~BIT(plane->id);
> >> crtc_state->nv12_planes &= ~BIT(plane->id);
> >> crtc_state->c8_planes &= ~BIT(plane->id);
> >> + crtc_state->async_flip_planes &= ~BIT(plane->id);
> >> crtc_state->data_rate[plane->id] = 0;
> >> crtc_state->data_rate_y[plane->id] = 0;
> >> crtc_state->rel_data_rate[plane->id] = 0;
> >> @@ -581,8 +582,10 @@ static int intel_plane_atomic_calc_changes(const struct intel_crtc_state *old_cr
> >> intel_plane_is_scaled(new_plane_state))))
> >> new_crtc_state->disable_lp_wm = true;
> >>
> >> - if (intel_plane_do_async_flip(plane, old_crtc_state, new_crtc_state))
> >> + if (intel_plane_do_async_flip(plane, old_crtc_state, new_crtc_state)) {
> >> new_crtc_state->do_async_flip = true;
> >> + new_crtc_state->async_flip_planes |= BIT(plane->id);
> >> + }
> >
> > intel_modeset_all_pipes() and intel_color_add_affected_planes() would
> > need to clear this stuff as well. Can't immediately think of other
>
> I am not familiar with the display, so forgive me being verbose in
> verification of your comments :)
> 1. In case of intel_modeset_all_pipes
> for every crtc: crtc_state->async_flip_planes = 0;
> 2. In case of intel_color_add_affected_planes:
> for every plane: new_crtc_state->async_flip_planes &= ~BIT(plane->id);
I think I'd do async_flip_planes=0 in both case, and also
do_async_flip=false. Guarantees we don't end up in some funny
state where some planes would want to do an async update
and some other ones a sync update.
> Are the changes OK?
>
> > places that need the same treatment (the nv12 plane stuff I believe
> > should be fine without this since we should be rejecting async flips
> > with planar formats).
>
> The driver is quite big and I quickly get lost when lurking into it, so
> hard to comment it :)
>
> >
> > Though I think that is still going to have annoying ping-pong
> > for the the wm/ddb optimizations whenever there are internal
> > sync plane updates injected between async flips. I think to
>
> Hmm, I hoped, that since intel_crtc_duplicate_state preserves
> async_flip_planes ping-pong shouldn't happen.
>
> > sort that out fully we'd need to start tracking the last uapi
> > async flip state for each plane.
>
>
> I hoped async_flip_planes should serve it, modulo it is not fully clear
> to me when to switch async_flip. Enabling async flip is quite clear
> (requested by user), but disabling:
> - full modeset,
> - sync fb update,
> - plane disable,
> - cases mentioned above,
> - ?
That reminds me that skl_{ddb,wm}_add_affected_planes() should
also disable async flips.
>
> Is it OK to send next version with added clearing code in
> intel_modeset_all_pipes and intel_color_add_affected_planes ?
Yeah, I think that should be good enough improvement for the moment.
>
> Regards
> Andrzej
>
> >
> >>
> >> return 0;
> >> }
> >> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> >> index e75b9b2a0e015a..e1c3b1b0b6a8f1 100644
> >> --- a/drivers/gpu/drm/i915/display/intel_display.c
> >> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> >> @@ -1303,7 +1303,8 @@ static void intel_crtc_async_flip_disable_wa(struct intel_atomic_state *state,
> >> intel_atomic_get_old_crtc_state(state, crtc);
> >> const struct intel_crtc_state *new_crtc_state =
> >> intel_atomic_get_new_crtc_state(state, crtc);
> >> - u8 update_planes = new_crtc_state->update_planes;
> >> + u8 disable_async_flip_planes = old_crtc_state->async_flip_planes &
> >> + ~new_crtc_state->async_flip_planes;
> >> const struct intel_plane_state *old_plane_state;
> >> struct intel_plane *plane;
> >> bool need_vbl_wait = false;
> >> @@ -1312,7 +1313,7 @@ static void intel_crtc_async_flip_disable_wa(struct intel_atomic_state *state,
> >> for_each_old_intel_plane_in_state(state, plane, old_plane_state, i) {
> >> if (plane->need_async_flip_disable_wa &&
> >> plane->pipe == crtc->pipe &&
> >> - update_planes & BIT(plane->id)) {
> >> + disable_async_flip_planes & BIT(plane->id)) {
> >> /*
> >> * Apart from the async flip bit we want to
> >> * preserve the old state for the plane.
> >> @@ -1429,7 +1430,7 @@ static void intel_pre_plane_update(struct intel_atomic_state *state,
> >> * WA for platforms where async address update enable bit
> >> * is double buffered and only latched at start of vblank.
> >> */
> >> - if (old_crtc_state->uapi.async_flip && !new_crtc_state->uapi.async_flip)
> >> + if (old_crtc_state->async_flip_planes & ~new_crtc_state->async_flip_planes)
> >> intel_crtc_async_flip_disable_wa(state, crtc);
> >> }
> >>
> >> diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h
> >> index 32e8b2fc3cc642..61b1a0ec3dede1 100644
> >> --- a/drivers/gpu/drm/i915/display/intel_display_types.h
> >> +++ b/drivers/gpu/drm/i915/display/intel_display_types.h
> >> @@ -1248,6 +1248,9 @@ struct intel_crtc_state {
> >> /* bitmask of planes that will be updated during the commit */
> >> u8 update_planes;
> >>
> >> + /* bitmask of planes with async flip active */
> >> + u8 async_flip_planes;
> >> +
> >> u8 framestart_delay; /* 1-4 */
> >> u8 msa_timing_delay; /* 0-3 */
> >>
> >> --
> >> 2.34.1
> >
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2023-01-26 19:45 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-11 16:22 [Intel-gfx] [PATCH v2] drm/i915: implement async_flip mode per plane tracking Andrzej Hajda
2023-01-11 17:13 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: implement async_flip mode per plane tracking (rev2) Patchwork
2023-01-11 17:40 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2023-01-12 10:01 ` Andrzej Hajda
2023-01-23 15:10 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: implement async_flip mode per plane tracking (rev3) Patchwork
2023-01-23 15:39 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-01-24 3:19 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2023-01-24 14:02 ` [Intel-gfx] [PATCH v2] drm/i915: implement async_flip mode per plane tracking Ville Syrjälä
2023-01-26 18:14 ` Andrzej Hajda
2023-01-26 19:45 ` Ville Syrjälä
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox