Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH] drm/i915/display: Read planes watermarks during initial state readout
@ 2021-02-19 19:16 José Roberto de Souza
  2021-02-19 19:46 ` Ville Syrjälä
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: José Roberto de Souza @ 2021-02-19 19:16 UTC (permalink / raw)
  To: intel-gfx

Without this readout all plane watermarks will be kept at zero in the
initial state readount causing two problems.

All active planes will always have their watermarks programmed
again, even if what firmware programmed matches with the sanitized
state during driver takeover.

State mismatch errors in disabled planes as watermarks will erroneous
match with the calculated state if firmware left watermark registers
with non-zero values.

Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
 drivers/gpu/drm/i915/display/intel_display.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index d0da88751c72..14fba4411be7 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -13620,6 +13620,8 @@ static void intel_modeset_readout_hw_state(struct drm_device *dev)
 			drm_calc_timestamping_constants(&slave->base,
 							&slave_crtc_state->hw.adjusted_mode);
 		}
+
+		skl_pipe_wm_get_hw_state(crtc, &crtc_state->wm.skl.optimal);
 	}
 }
 
-- 
2.30.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2021-02-19 21:43 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-19 19:16 [Intel-gfx] [PATCH] drm/i915/display: Read planes watermarks during initial state readout José Roberto de Souza
2021-02-19 19:46 ` Ville Syrjälä
2021-02-19 20:16   ` Souza, Jose
2021-02-19 20:33     ` Ville Syrjälä
2021-02-19 20:15 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2021-02-19 21:43 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox