* [Intel-gfx] [PATCH 1/2] drm/i915: Fix pre-skl DP AUX precharge length
@ 2021-03-18 18:10 Ville Syrjala
2021-03-18 18:10 ` [Intel-gfx] [PATCH 2/2] drm/i915: Remove stray newlines Ville Syrjala
` (5 more replies)
0 siblings, 6 replies; 10+ messages in thread
From: Ville Syrjala @ 2021-03-18 18:10 UTC (permalink / raw)
To: intel-gfx
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
DP v1.1+ says:
"The DisplayPort transmitter, which is the driving end for a request
transaction, pre-charges the AUX-CH+ and AUX-CH- to a common mode
voltage by transmitting 10 to 16 consecutive 0’s in Manchester II code.
After the active pre-charge, the transmitter sends an AUX Sync pattern.
The AUX Sync pattern must be as follows:
Start with 16 consecutive 0s in Manchester-II code, which results in
a transition from low to high in the middle of each bit period.
Including active pre-charge pulses, there shall be 26 to 32
consecutive 0s before the end of the AUX_SYNC pattern."
BDW bspec says:
"Used to determine the precharge time for the Aux Channel. During this
time the Aux Channel will drive the SYNC pattern. Every microsecond
gives one additional SYNC pulse beyond the hard coded 26 SYNC pulses.
The value is the number of microseconds times 2. Default is 3 decimal
which gives 6us of precharge which is 6 extra SYN pulses for a total
of 32."
CPT bspec says the same thing apart from:
"... Default is 5 decimal which gives 10us of precharge which is 10
extra SYNC pulses for a total of 36."
So it looks like to match the max of 32 of the DP spec we should just
always program this extra precharge time to 3.
Unfortunately g4x/ibx bspec doesn't have this clarification, but
since the cpt default was still the same 5 as for g4x/ibx let's
assume the behaviour was always the same.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/display/intel_dp_aux.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux.c b/drivers/gpu/drm/i915/display/intel_dp_aux.c
index eaebf123310a..d5443d6d6123 100644
--- a/drivers/gpu/drm/i915/display/intel_dp_aux.c
+++ b/drivers/gpu/drm/i915/display/intel_dp_aux.c
@@ -126,12 +126,7 @@ static u32 g4x_get_aux_send_ctl(struct intel_dp *intel_dp,
struct intel_digital_port *dig_port = dp_to_dig_port(intel_dp);
struct drm_i915_private *dev_priv =
to_i915(dig_port->base.base.dev);
- u32 precharge, timeout;
-
- if (IS_GEN(dev_priv, 6))
- precharge = 3;
- else
- precharge = 5;
+ u32 timeout;
if (IS_BROADWELL(dev_priv))
timeout = DP_AUX_CH_CTL_TIME_OUT_600us;
@@ -145,7 +140,7 @@ static u32 g4x_get_aux_send_ctl(struct intel_dp *intel_dp,
timeout |
DP_AUX_CH_CTL_RECEIVE_ERROR |
(send_bytes << DP_AUX_CH_CTL_MESSAGE_SIZE_SHIFT) |
- (precharge << DP_AUX_CH_CTL_PRECHARGE_2US_SHIFT) |
+ (3 << DP_AUX_CH_CTL_PRECHARGE_2US_SHIFT) |
(aux_clock_divider << DP_AUX_CH_CTL_BIT_CLOCK_2X_SHIFT);
}
--
2.26.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [Intel-gfx] [PATCH 2/2] drm/i915: Remove stray newlines
2021-03-18 18:10 [Intel-gfx] [PATCH 1/2] drm/i915: Fix pre-skl DP AUX precharge length Ville Syrjala
@ 2021-03-18 18:10 ` Ville Syrjala
2021-04-26 15:55 ` Imre Deak
2021-03-18 20:09 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: Fix pre-skl DP AUX precharge length Patchwork
` (4 subsequent siblings)
5 siblings, 1 reply; 10+ messages in thread
From: Ville Syrjala @ 2021-03-18 18:10 UTC (permalink / raw)
To: intel-gfx
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
A bunch of files have a stray newline at the end. Remove it.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/display/i9xx_plane.c | 1 -
drivers/gpu/drm/i915/display/skl_universal_plane.c | 1 -
drivers/gpu/drm/i915/gt/uc/intel_guc_log_debugfs.c | 1 -
drivers/gpu/drm/i915/i915_params.h | 1 -
drivers/gpu/drm/i915/i915_vma_types.h | 1 -
5 files changed, 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/i9xx_plane.c b/drivers/gpu/drm/i915/display/i9xx_plane.c
index 8a52beaed2da..7391cd195d41 100644
--- a/drivers/gpu/drm/i915/display/i9xx_plane.c
+++ b/drivers/gpu/drm/i915/display/i9xx_plane.c
@@ -1038,4 +1038,3 @@ i9xx_get_initial_plane_config(struct intel_crtc *crtc,
plane_config->fb = intel_fb;
}
-
diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane.c b/drivers/gpu/drm/i915/display/skl_universal_plane.c
index 1f335cb09149..a06c474223c1 100644
--- a/drivers/gpu/drm/i915/display/skl_universal_plane.c
+++ b/drivers/gpu/drm/i915/display/skl_universal_plane.c
@@ -2263,4 +2263,3 @@ skl_get_initial_plane_config(struct intel_crtc *crtc,
error:
kfree(intel_fb);
}
-
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_log_debugfs.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_log_debugfs.c
index 129e0cf7dfe2..64e0b86bf258 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_guc_log_debugfs.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_log_debugfs.c
@@ -121,4 +121,3 @@ void intel_guc_log_debugfs_register(struct intel_guc_log *log,
intel_gt_debugfs_register_files(root, files, ARRAY_SIZE(files), log);
}
-
diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h
index 48f47e44e848..18bbc92b642d 100644
--- a/drivers/gpu/drm/i915/i915_params.h
+++ b/drivers/gpu/drm/i915/i915_params.h
@@ -96,4 +96,3 @@ void i915_params_copy(struct i915_params *dest, const struct i915_params *src);
void i915_params_free(struct i915_params *params);
#endif
-
diff --git a/drivers/gpu/drm/i915/i915_vma_types.h b/drivers/gpu/drm/i915/i915_vma_types.h
index f5cb848b7a7e..c7614fbabb9c 100644
--- a/drivers/gpu/drm/i915/i915_vma_types.h
+++ b/drivers/gpu/drm/i915/i915_vma_types.h
@@ -282,4 +282,3 @@ struct i915_vma {
};
#endif
-
--
2.26.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: Fix pre-skl DP AUX precharge length
2021-03-18 18:10 [Intel-gfx] [PATCH 1/2] drm/i915: Fix pre-skl DP AUX precharge length Ville Syrjala
2021-03-18 18:10 ` [Intel-gfx] [PATCH 2/2] drm/i915: Remove stray newlines Ville Syrjala
@ 2021-03-18 20:09 ` Patchwork
2021-03-18 20:52 ` Ville Syrjälä
2021-03-18 21:00 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
` (3 subsequent siblings)
5 siblings, 1 reply; 10+ messages in thread
From: Patchwork @ 2021-03-18 20:09 UTC (permalink / raw)
To: Ville Syrjala; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 2573 bytes --]
== Series Details ==
Series: series starting with [1/2] drm/i915: Fix pre-skl DP AUX precharge length
URL : https://patchwork.freedesktop.org/series/88132/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_9870 -> Patchwork_19807
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_19807 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_19807, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_19807:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@execlists:
- fi-kbl-soraka: [PASS][1] -> [DMESG-WARN][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9870/fi-kbl-soraka/igt@i915_selftest@live@execlists.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/fi-kbl-soraka/igt@i915_selftest@live@execlists.html
Known issues
------------
Here are the changes found in Patchwork_19807 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@core_hotunplug@unbind-rebind:
- fi-bwr-2160: [PASS][3] -> [FAIL][4] ([i915#3194])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9870/fi-bwr-2160/igt@core_hotunplug@unbind-rebind.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/fi-bwr-2160/igt@core_hotunplug@unbind-rebind.html
[i915#3194]: https://gitlab.freedesktop.org/drm/intel/issues/3194
Participating hosts (44 -> 40)
------------------------------
Missing (4): fi-ilk-m540 fi-bsw-cyan fi-bdw-samus fi-hsw-4200u
Build changes
-------------
* Linux: CI_DRM_9870 -> Patchwork_19807
CI-20190529: 20190529
CI_DRM_9870: a9a5ed8d2432e5335e6c26118cefb2cfff28ae37 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6036: 5b535494abcdf5ce2b9be99b7bb5df8ab4733083 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19807: 89c9ce9bcfbf7286c2ec25ffaa26041909ec84d6 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
89c9ce9bcfbf drm/i915: Remove stray newlines
6b3f9e7ed7f6 drm/i915: Fix pre-skl DP AUX precharge length
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/index.html
[-- Attachment #1.2: Type: text/html, Size: 3212 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: Fix pre-skl DP AUX precharge length
2021-03-18 20:09 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: Fix pre-skl DP AUX precharge length Patchwork
@ 2021-03-18 20:52 ` Ville Syrjälä
2021-03-18 21:22 ` Vudum, Lakshminarayana
0 siblings, 1 reply; 10+ messages in thread
From: Ville Syrjälä @ 2021-03-18 20:52 UTC (permalink / raw)
To: intel-gfx; +Cc: Vudum, Lakshminarayana
On Thu, Mar 18, 2021 at 08:09:43PM -0000, Patchwork wrote:
> == Series Details ==
>
> Series: series starting with [1/2] drm/i915: Fix pre-skl DP AUX precharge length
> URL : https://patchwork.freedesktop.org/series/88132/
> State : failure
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_9870 -> Patchwork_19807
> ====================================================
>
> Summary
> -------
>
> **FAILURE**
>
> Serious unknown changes coming with Patchwork_19807 absolutely need to be
> verified manually.
>
> If you think the reported changes have nothing to do with the changes
> introduced in Patchwork_19807, please notify your bug team to allow them
> to document this new failure mode, which will reduce false positives in CI.
>
> External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/index.html
>
> Possible new issues
> -------------------
>
> Here are the unknown changes that may have been introduced in Patchwork_19807:
>
> ### IGT changes ###
>
> #### Possible regressions ####
>
> * igt@i915_selftest@live@execlists:
> - fi-kbl-soraka: [PASS][1] -> [DMESG-WARN][2]
> [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9870/fi-kbl-soraka/igt@i915_selftest@live@execlists.html
> [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/fi-kbl-soraka/igt@i915_selftest@live@execlists.html
<3> [1019.090846] i915 0000:00:02.0: [drm] *ERROR* AUX B/DDI B/PHY B: did not complete or timeout within 10ms (status 0xad4003ff)
Unrelated to the patch since it doesn't touch the skl+ AUX code
and this machine is a kbl. So seems to be just some random fail.
>
>
> Known issues
> ------------
>
> Here are the changes found in Patchwork_19807 that come from known issues:
>
> ### IGT changes ###
>
> #### Issues hit ####
>
> * igt@core_hotunplug@unbind-rebind:
> - fi-bwr-2160: [PASS][3] -> [FAIL][4] ([i915#3194])
> [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9870/fi-bwr-2160/igt@core_hotunplug@unbind-rebind.html
> [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/fi-bwr-2160/igt@core_hotunplug@unbind-rebind.html
>
>
> [i915#3194]: https://gitlab.freedesktop.org/drm/intel/issues/3194
>
>
> Participating hosts (44 -> 40)
> ------------------------------
>
> Missing (4): fi-ilk-m540 fi-bsw-cyan fi-bdw-samus fi-hsw-4200u
>
>
> Build changes
> -------------
>
> * Linux: CI_DRM_9870 -> Patchwork_19807
>
> CI-20190529: 20190529
> CI_DRM_9870: a9a5ed8d2432e5335e6c26118cefb2cfff28ae37 @ git://anongit.freedesktop.org/gfx-ci/linux
> IGT_6036: 5b535494abcdf5ce2b9be99b7bb5df8ab4733083 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
> Patchwork_19807: 89c9ce9bcfbf7286c2ec25ffaa26041909ec84d6 @ git://anongit.freedesktop.org/gfx-ci/linux
>
>
> == Linux commits ==
>
> 89c9ce9bcfbf drm/i915: Remove stray newlines
> 6b3f9e7ed7f6 drm/i915: Fix pre-skl DP AUX precharge length
>
> == Logs ==
>
> For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/index.html
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Fix pre-skl DP AUX precharge length
2021-03-18 18:10 [Intel-gfx] [PATCH 1/2] drm/i915: Fix pre-skl DP AUX precharge length Ville Syrjala
2021-03-18 18:10 ` [Intel-gfx] [PATCH 2/2] drm/i915: Remove stray newlines Ville Syrjala
2021-03-18 20:09 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: Fix pre-skl DP AUX precharge length Patchwork
@ 2021-03-18 21:00 ` Patchwork
2021-03-19 2:08 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
` (2 subsequent siblings)
5 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2021-03-18 21:00 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 2175 bytes --]
== Series Details ==
Series: series starting with [1/2] drm/i915: Fix pre-skl DP AUX precharge length
URL : https://patchwork.freedesktop.org/series/88132/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9870 -> Patchwork_19807
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/index.html
Known issues
------------
Here are the changes found in Patchwork_19807 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@core_hotunplug@unbind-rebind:
- fi-bwr-2160: [PASS][1] -> [FAIL][2] ([i915#3194])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9870/fi-bwr-2160/igt@core_hotunplug@unbind-rebind.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/fi-bwr-2160/igt@core_hotunplug@unbind-rebind.html
* igt@i915_selftest@live@execlists:
- fi-kbl-soraka: [PASS][3] -> [DMESG-WARN][4] ([i915#3240])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9870/fi-kbl-soraka/igt@i915_selftest@live@execlists.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/fi-kbl-soraka/igt@i915_selftest@live@execlists.html
[i915#3194]: https://gitlab.freedesktop.org/drm/intel/issues/3194
[i915#3240]: https://gitlab.freedesktop.org/drm/intel/issues/3240
Participating hosts (44 -> 40)
------------------------------
Missing (4): fi-ilk-m540 fi-bsw-cyan fi-bdw-samus fi-hsw-4200u
Build changes
-------------
* Linux: CI_DRM_9870 -> Patchwork_19807
CI-20190529: 20190529
CI_DRM_9870: a9a5ed8d2432e5335e6c26118cefb2cfff28ae37 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6036: 5b535494abcdf5ce2b9be99b7bb5df8ab4733083 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19807: 89c9ce9bcfbf7286c2ec25ffaa26041909ec84d6 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
89c9ce9bcfbf drm/i915: Remove stray newlines
6b3f9e7ed7f6 drm/i915: Fix pre-skl DP AUX precharge length
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/index.html
[-- Attachment #1.2: Type: text/html, Size: 2811 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: Fix pre-skl DP AUX precharge length
2021-03-18 20:52 ` Ville Syrjälä
@ 2021-03-18 21:22 ` Vudum, Lakshminarayana
0 siblings, 0 replies; 10+ messages in thread
From: Vudum, Lakshminarayana @ 2021-03-18 21:22 UTC (permalink / raw)
To: Ville Syrjälä, intel-gfx@lists.freedesktop.org
Re-reported.
-----Original Message-----
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Sent: Thursday, March 18, 2021 1:53 PM
To: intel-gfx@lists.freedesktop.org
Cc: Vudum, Lakshminarayana <lakshminarayana.vudum@intel.com>
Subject: Re: ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: Fix pre-skl DP AUX precharge length
On Thu, Mar 18, 2021 at 08:09:43PM -0000, Patchwork wrote:
> == Series Details ==
>
> Series: series starting with [1/2] drm/i915: Fix pre-skl DP AUX precharge length
> URL : https://patchwork.freedesktop.org/series/88132/
> State : failure
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_9870 -> Patchwork_19807
> ====================================================
>
> Summary
> -------
>
> **FAILURE**
>
> Serious unknown changes coming with Patchwork_19807 absolutely need to be
> verified manually.
>
> If you think the reported changes have nothing to do with the changes
> introduced in Patchwork_19807, please notify your bug team to allow them
> to document this new failure mode, which will reduce false positives in CI.
>
> External URL:
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/index.html
>
> Possible new issues
> -------------------
>
> Here are the unknown changes that may have been introduced in Patchwork_19807:
>
> ### IGT changes ###
>
> #### Possible regressions ####
>
> * igt@i915_selftest@live@execlists:
> - fi-kbl-soraka: [PASS][1] -> [DMESG-WARN][2]
> [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9870/fi-kbl-soraka/igt@i915_selftest@live@execlists.html
> [2]:
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/fi-kbl-soraka
> /igt@i915_selftest@live@execlists.html
<3> [1019.090846] i915 0000:00:02.0: [drm] *ERROR* AUX B/DDI B/PHY B: did not complete or timeout within 10ms (status 0xad4003ff)
Unrelated to the patch since it doesn't touch the skl+ AUX code and this machine is a kbl. So seems to be just some random fail.
>
>
> Known issues
> ------------
>
> Here are the changes found in Patchwork_19807 that come from known issues:
>
> ### IGT changes ###
>
> #### Issues hit ####
>
> * igt@core_hotunplug@unbind-rebind:
> - fi-bwr-2160: [PASS][3] -> [FAIL][4] ([i915#3194])
> [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9870/fi-bwr-2160/igt@core_hotunplug@unbind-rebind.html
> [4]:
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/fi-bwr-2160/i
> gt@core_hotunplug@unbind-rebind.html
>
>
> [i915#3194]: https://gitlab.freedesktop.org/drm/intel/issues/3194
>
>
> Participating hosts (44 -> 40)
> ------------------------------
>
> Missing (4): fi-ilk-m540 fi-bsw-cyan fi-bdw-samus fi-hsw-4200u
>
>
> Build changes
> -------------
>
> * Linux: CI_DRM_9870 -> Patchwork_19807
>
> CI-20190529: 20190529
> CI_DRM_9870: a9a5ed8d2432e5335e6c26118cefb2cfff28ae37 @ git://anongit.freedesktop.org/gfx-ci/linux
> IGT_6036: 5b535494abcdf5ce2b9be99b7bb5df8ab4733083 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
> Patchwork_19807: 89c9ce9bcfbf7286c2ec25ffaa26041909ec84d6 @
> git://anongit.freedesktop.org/gfx-ci/linux
>
>
> == Linux commits ==
>
> 89c9ce9bcfbf drm/i915: Remove stray newlines
> 6b3f9e7ed7f6 drm/i915: Fix pre-skl DP AUX precharge length
>
> == Logs ==
>
> For more details see:
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/index.html
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915: Fix pre-skl DP AUX precharge length
2021-03-18 18:10 [Intel-gfx] [PATCH 1/2] drm/i915: Fix pre-skl DP AUX precharge length Ville Syrjala
` (2 preceding siblings ...)
2021-03-18 21:00 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2021-03-19 2:08 ` Patchwork
2021-03-30 18:06 ` [Intel-gfx] [PATCH 1/2] " Ville Syrjälä
2021-04-26 15:54 ` Imre Deak
5 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2021-03-19 2:08 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 30291 bytes --]
== Series Details ==
Series: series starting with [1/2] drm/i915: Fix pre-skl DP AUX precharge length
URL : https://patchwork.freedesktop.org/series/88132/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9870_full -> Patchwork_19807_full
====================================================
Summary
-------
**WARNING**
Minor unknown changes coming with Patchwork_19807_full need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_19807_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_19807_full:
### IGT changes ###
#### Warnings ####
* igt@runner@aborted:
- shard-apl: ([FAIL][1], [FAIL][2], [FAIL][3], [FAIL][4], [FAIL][5]) ([i915#180] / [i915#2724] / [i915#3002]) -> ([FAIL][6], [FAIL][7], [FAIL][8]) ([i915#2724] / [i915#3002])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9870/shard-apl3/igt@runner@aborted.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9870/shard-apl6/igt@runner@aborted.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9870/shard-apl7/igt@runner@aborted.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9870/shard-apl6/igt@runner@aborted.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9870/shard-apl2/igt@runner@aborted.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-apl7/igt@runner@aborted.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-apl2/igt@runner@aborted.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-apl6/igt@runner@aborted.html
Known issues
------------
Here are the changes found in Patchwork_19807_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@feature_discovery@display-4x:
- shard-tglb: NOTRUN -> [SKIP][9] ([i915#1839])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-tglb7/igt@feature_discovery@display-4x.html
- shard-iclb: NOTRUN -> [SKIP][10] ([i915#1839])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-iclb7/igt@feature_discovery@display-4x.html
* igt@gem_create@create-clear:
- shard-skl: [PASS][11] -> [FAIL][12] ([i915#3160])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9870/shard-skl4/igt@gem_create@create-clear.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-skl1/igt@gem_create@create-clear.html
* igt@gem_ctx_param@set-priority-not-supported:
- shard-iclb: NOTRUN -> [SKIP][13] ([fdo#109314])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-iclb7/igt@gem_ctx_param@set-priority-not-supported.html
* igt@gem_ctx_persistence@idempotent:
- shard-snb: NOTRUN -> [SKIP][14] ([fdo#109271] / [i915#1099]) +3 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-snb7/igt@gem_ctx_persistence@idempotent.html
* igt@gem_ctx_sseu@mmap-args:
- shard-tglb: NOTRUN -> [SKIP][15] ([i915#280])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-tglb7/igt@gem_ctx_sseu@mmap-args.html
* igt@gem_eio@unwedge-stress:
- shard-skl: [PASS][16] -> [TIMEOUT][17] ([i915#2369] / [i915#2771] / [i915#3063])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9870/shard-skl1/igt@gem_eio@unwedge-stress.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-skl9/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: NOTRUN -> [FAIL][18] ([i915#2842])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-glk6/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-pace@rcs0:
- shard-kbl: [PASS][19] -> [FAIL][20] ([i915#2851])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9870/shard-kbl7/igt@gem_exec_fair@basic-pace@rcs0.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-kbl2/igt@gem_exec_fair@basic-pace@rcs0.html
* igt@gem_exec_fair@basic-pace@vcs0:
- shard-iclb: [PASS][21] -> [FAIL][22] ([i915#2842])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9870/shard-iclb1/igt@gem_exec_fair@basic-pace@vcs0.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-iclb1/igt@gem_exec_fair@basic-pace@vcs0.html
* igt@gem_exec_fair@basic-pace@vcs1:
- shard-kbl: [PASS][23] -> [FAIL][24] ([i915#2842])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9870/shard-kbl7/igt@gem_exec_fair@basic-pace@vcs1.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-kbl2/igt@gem_exec_fair@basic-pace@vcs1.html
* igt@gem_exec_reloc@basic-many-active@rcs0:
- shard-snb: NOTRUN -> [FAIL][25] ([i915#2389]) +2 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-snb7/igt@gem_exec_reloc@basic-many-active@rcs0.html
* igt@gem_exec_schedule@u-fairslice@rcs0:
- shard-iclb: [PASS][26] -> [DMESG-WARN][27] ([i915#2803])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9870/shard-iclb2/igt@gem_exec_schedule@u-fairslice@rcs0.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-iclb4/igt@gem_exec_schedule@u-fairslice@rcs0.html
* igt@gem_exec_schedule@u-fairslice@vecs0:
- shard-skl: [PASS][28] -> [DMESG-WARN][29] ([i915#1610] / [i915#2803])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9870/shard-skl6/igt@gem_exec_schedule@u-fairslice@vecs0.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-skl1/igt@gem_exec_schedule@u-fairslice@vecs0.html
* igt@gem_exec_whisper@basic-forked-all:
- shard-glk: [PASS][30] -> [DMESG-WARN][31] ([i915#118] / [i915#95])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9870/shard-glk9/igt@gem_exec_whisper@basic-forked-all.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-glk2/igt@gem_exec_whisper@basic-forked-all.html
* igt@gem_huc_copy@huc-copy:
- shard-apl: NOTRUN -> [SKIP][32] ([fdo#109271] / [i915#2190])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-apl2/igt@gem_huc_copy@huc-copy.html
* igt@gem_pwrite@basic-exhaustion:
- shard-snb: NOTRUN -> [WARN][33] ([i915#2658])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-snb7/igt@gem_pwrite@basic-exhaustion.html
- shard-apl: NOTRUN -> [WARN][34] ([i915#2658])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-apl3/igt@gem_pwrite@basic-exhaustion.html
* igt@gem_render_copy@y-tiled-to-vebox-linear:
- shard-iclb: NOTRUN -> [SKIP][35] ([i915#768]) +1 similar issue
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-iclb7/igt@gem_render_copy@y-tiled-to-vebox-linear.html
* igt@gem_userptr_blits@huge-split:
- shard-apl: NOTRUN -> [INCOMPLETE][36] ([i915#2502])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-apl2/igt@gem_userptr_blits@huge-split.html
* igt@gen9_exec_parse@cmd-crossing-page:
- shard-iclb: NOTRUN -> [SKIP][37] ([fdo#112306])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-iclb7/igt@gen9_exec_parse@cmd-crossing-page.html
* igt@kms_atomic_transition@plane-all-transition-nonblocking@dp-1-pipe-b:
- shard-kbl: [PASS][38] -> [FAIL][39] ([i915#3168])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9870/shard-kbl6/igt@kms_atomic_transition@plane-all-transition-nonblocking@dp-1-pipe-b.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-kbl4/igt@kms_atomic_transition@plane-all-transition-nonblocking@dp-1-pipe-b.html
* igt@kms_big_fb@yf-tiled-32bpp-rotate-0:
- shard-tglb: NOTRUN -> [SKIP][40] ([fdo#111615])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-tglb7/igt@kms_big_fb@yf-tiled-32bpp-rotate-0.html
* igt@kms_ccs@pipe-c-crc-primary-basic:
- shard-skl: NOTRUN -> [SKIP][41] ([fdo#109271] / [fdo#111304])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-skl1/igt@kms_ccs@pipe-c-crc-primary-basic.html
* igt@kms_chamelium@hdmi-crc-multiple:
- shard-iclb: NOTRUN -> [SKIP][42] ([fdo#109284] / [fdo#111827]) +1 similar issue
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-iclb7/igt@kms_chamelium@hdmi-crc-multiple.html
* igt@kms_color@pipe-d-ctm-max:
- shard-skl: NOTRUN -> [SKIP][43] ([fdo#109271]) +62 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-skl5/igt@kms_color@pipe-d-ctm-max.html
* igt@kms_color@pipe-d-degamma:
- shard-iclb: NOTRUN -> [SKIP][44] ([fdo#109278] / [i915#1149])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-iclb7/igt@kms_color@pipe-d-degamma.html
- shard-tglb: NOTRUN -> [FAIL][45] ([i915#1149])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-tglb7/igt@kms_color@pipe-d-degamma.html
* igt@kms_color_chamelium@pipe-a-ctm-blue-to-red:
- shard-snb: NOTRUN -> [SKIP][46] ([fdo#109271] / [fdo#111827]) +14 similar issues
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-snb7/igt@kms_color_chamelium@pipe-a-ctm-blue-to-red.html
* igt@kms_color_chamelium@pipe-a-ctm-limited-range:
- shard-apl: NOTRUN -> [SKIP][47] ([fdo#109271] / [fdo#111827]) +20 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-apl3/igt@kms_color_chamelium@pipe-a-ctm-limited-range.html
* igt@kms_color_chamelium@pipe-b-ctm-negative:
- shard-tglb: NOTRUN -> [SKIP][48] ([fdo#109284] / [fdo#111827]) +1 similar issue
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-tglb7/igt@kms_color_chamelium@pipe-b-ctm-negative.html
* igt@kms_color_chamelium@pipe-d-ctm-0-25:
- shard-glk: NOTRUN -> [SKIP][49] ([fdo#109271] / [fdo#111827]) +2 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-glk6/igt@kms_color_chamelium@pipe-d-ctm-0-25.html
* igt@kms_color_chamelium@pipe-invalid-ctm-matrix-sizes:
- shard-skl: NOTRUN -> [SKIP][50] ([fdo#109271] / [fdo#111827]) +6 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-skl7/igt@kms_color_chamelium@pipe-invalid-ctm-matrix-sizes.html
* igt@kms_content_protection@uevent:
- shard-apl: NOTRUN -> [FAIL][51] ([i915#2105])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-apl3/igt@kms_content_protection@uevent.html
* igt@kms_cursor_crc@pipe-b-cursor-512x512-random:
- shard-iclb: NOTRUN -> [SKIP][52] ([fdo#109278] / [fdo#109279])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-iclb7/igt@kms_cursor_crc@pipe-b-cursor-512x512-random.html
* igt@kms_cursor_edge_walk@pipe-d-256x256-bottom-edge:
- shard-iclb: NOTRUN -> [SKIP][53] ([fdo#109278]) +7 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-iclb7/igt@kms_cursor_edge_walk@pipe-d-256x256-bottom-edge.html
* igt@kms_cursor_legacy@cursora-vs-flipb-atomic-transitions:
- shard-tglb: NOTRUN -> [SKIP][54] ([fdo#111825]) +5 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-tglb7/igt@kms_cursor_legacy@cursora-vs-flipb-atomic-transitions.html
* igt@kms_cursor_legacy@cursorb-vs-flipa-varying-size:
- shard-iclb: NOTRUN -> [SKIP][55] ([fdo#109274] / [fdo#109278]) +1 similar issue
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-iclb7/igt@kms_cursor_legacy@cursorb-vs-flipa-varying-size.html
* igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-atomic:
- shard-apl: NOTRUN -> [DMESG-FAIL][56] ([IGT#6])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-apl7/igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-atomic.html
* igt@kms_dp_dsc@basic-dsc-enable-edp:
- shard-iclb: NOTRUN -> [SKIP][57] ([fdo#109349])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-iclb7/igt@kms_dp_dsc@basic-dsc-enable-edp.html
* igt@kms_draw_crc@draw-method-xrgb2101010-blt-xtiled:
- shard-skl: [PASS][58] -> [DMESG-WARN][59] ([i915#1982])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9870/shard-skl8/igt@kms_draw_crc@draw-method-xrgb2101010-blt-xtiled.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-skl9/igt@kms_draw_crc@draw-method-xrgb2101010-blt-xtiled.html
* igt@kms_flip@2x-absolute-wf_vblank-interruptible:
- shard-iclb: NOTRUN -> [SKIP][60] ([fdo#109274]) +1 similar issue
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-iclb7/igt@kms_flip@2x-absolute-wf_vblank-interruptible.html
* igt@kms_flip@plain-flip-fb-recreate@b-edp1:
- shard-skl: [PASS][61] -> [FAIL][62] ([i915#2122])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9870/shard-skl4/igt@kms_flip@plain-flip-fb-recreate@b-edp1.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-skl1/igt@kms_flip@plain-flip-fb-recreate@b-edp1.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-shrfb-draw-mmap-cpu:
- shard-iclb: NOTRUN -> [SKIP][63] ([fdo#109280]) +5 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-iclb7/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-shrfb-draw-mmap-cpu.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-pwrite:
- shard-kbl: NOTRUN -> [SKIP][64] ([fdo#109271]) +7 similar issues
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-kbl6/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-mmap-cpu:
- shard-glk: NOTRUN -> [SKIP][65] ([fdo#109271]) +29 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-glk6/igt@kms_frontbuffer_tracking@fbcpsr-1p-offscren-pri-indfb-draw-mmap-cpu.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-onoff:
- shard-snb: NOTRUN -> [SKIP][66] ([fdo#109271]) +249 similar issues
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-snb2/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-onoff.html
* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [PASS][67] -> [FAIL][68] ([i915#1188])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9870/shard-skl5/igt@kms_hdr@bpc-switch-dpms.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-skl4/igt@kms_hdr@bpc-switch-dpms.html
* igt@kms_plane_alpha_blend@pipe-a-alpha-7efc:
- shard-apl: NOTRUN -> [FAIL][69] ([fdo#108145] / [i915#265]) +2 similar issues
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-apl3/igt@kms_plane_alpha_blend@pipe-a-alpha-7efc.html
- shard-kbl: NOTRUN -> [FAIL][70] ([fdo#108145] / [i915#265])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-kbl6/igt@kms_plane_alpha_blend@pipe-a-alpha-7efc.html
* igt@kms_plane_alpha_blend@pipe-b-alpha-basic:
- shard-glk: NOTRUN -> [FAIL][71] ([fdo#108145] / [i915#265])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-glk6/igt@kms_plane_alpha_blend@pipe-b-alpha-basic.html
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: NOTRUN -> [FAIL][72] ([fdo#108145] / [i915#265]) +2 similar issues
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-skl9/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
* igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb:
- shard-skl: NOTRUN -> [FAIL][73] ([i915#265])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-skl7/igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [PASS][74] -> [FAIL][75] ([fdo#108145] / [i915#265]) +1 similar issue
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9870/shard-skl1/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-skl9/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
* igt@kms_psr2_sf@cursor-plane-update-sf:
- shard-skl: NOTRUN -> [SKIP][76] ([fdo#109271] / [i915#658]) +2 similar issues
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-skl9/igt@kms_psr2_sf@cursor-plane-update-sf.html
- shard-iclb: NOTRUN -> [SKIP][77] ([i915#658]) +1 similar issue
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-iclb7/igt@kms_psr2_sf@cursor-plane-update-sf.html
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-5:
- shard-apl: NOTRUN -> [SKIP][78] ([fdo#109271] / [i915#658]) +5 similar issues
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-apl3/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-5.html
- shard-kbl: NOTRUN -> [SKIP][79] ([fdo#109271] / [i915#658])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-kbl6/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-5.html
* igt@kms_psr2_sf@plane-move-sf-dmg-area-3:
- shard-glk: NOTRUN -> [SKIP][80] ([fdo#109271] / [i915#658])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-glk6/igt@kms_psr2_sf@plane-move-sf-dmg-area-3.html
* igt@kms_psr@psr2_cursor_render:
- shard-iclb: NOTRUN -> [SKIP][81] ([fdo#109441])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-iclb7/igt@kms_psr@psr2_cursor_render.html
* igt@kms_psr@psr2_sprite_render:
- shard-iclb: [PASS][82] -> [SKIP][83] ([fdo#109441])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9870/shard-iclb2/igt@kms_psr@psr2_sprite_render.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-iclb4/igt@kms_psr@psr2_sprite_render.html
* igt@kms_vblank@pipe-d-wait-idle:
- shard-apl: NOTRUN -> [SKIP][84] ([fdo#109271] / [i915#533]) +2 similar issues
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-apl3/igt@kms_vblank@pipe-d-wait-idle.html
* igt@nouveau_crc@pipe-c-ctx-flip-detection:
- shard-iclb: NOTRUN -> [SKIP][85] ([i915#2530])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-iclb7/igt@nouveau_crc@pipe-c-ctx-flip-detection.html
- shard-tglb: NOTRUN -> [SKIP][86] ([i915#2530])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-tglb7/igt@nouveau_crc@pipe-c-ctx-flip-detection.html
* igt@perf@gen12-unprivileged-single-ctx-counters:
- shard-iclb: NOTRUN -> [SKIP][87] ([fdo#109289])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-iclb7/igt@perf@gen12-unprivileged-single-ctx-counters.html
* igt@perf@polling-parameterized:
- shard-iclb: [PASS][88] -> [FAIL][89] ([i915#1542])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9870/shard-iclb3/igt@perf@polling-parameterized.html
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-iclb3/igt@perf@polling-parameterized.html
* igt@perf@polling-small-buf:
- shard-skl: [PASS][90] -> [FAIL][91] ([i915#1722])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9870/shard-skl8/igt@perf@polling-small-buf.html
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-skl9/igt@perf@polling-small-buf.html
* igt@prime_nv_api@i915_nv_reimport_twice_check_flink_name:
- shard-apl: NOTRUN -> [SKIP][92] ([fdo#109271]) +180 similar issues
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-apl7/igt@prime_nv_api@i915_nv_reimport_twice_check_flink_name.html
* igt@prime_nv_pcopy@test3_4:
- shard-iclb: NOTRUN -> [SKIP][93] ([fdo#109291])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-iclb7/igt@prime_nv_pcopy@test3_4.html
- shard-tglb: NOTRUN -> [SKIP][94] ([fdo#109291])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-tglb7/igt@prime_nv_pcopy@test3_4.html
* igt@sysfs_clients@busy@vecs0:
- shard-kbl: [PASS][95] -> [FAIL][96] ([i915#3009])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9870/shard-kbl7/igt@sysfs_clients@busy@vecs0.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-kbl3/igt@sysfs_clients@busy@vecs0.html
#### Possible fixes ####
* igt@gem_exec_balancer@hang:
- shard-iclb: [INCOMPLETE][97] ([i915#1895] / [i915#3031]) -> [PASS][98]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9870/shard-iclb2/igt@gem_exec_balancer@hang.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-iclb7/igt@gem_exec_balancer@hang.html
* igt@gem_exec_endless@dispatch@vcs0:
- shard-iclb: [INCOMPLETE][99] ([i915#2502]) -> [PASS][100]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9870/shard-iclb1/igt@gem_exec_endless@dispatch@vcs0.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-iclb8/igt@gem_exec_endless@dispatch@vcs0.html
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-tglb: [FAIL][101] ([i915#2842]) -> [PASS][102]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9870/shard-tglb2/igt@gem_exec_fair@basic-none-share@rcs0.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-tglb2/igt@gem_exec_fair@basic-none-share@rcs0.html
* igt@gem_exec_fair@basic-pace@bcs0:
- shard-iclb: [FAIL][103] ([i915#2842]) -> [PASS][104]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9870/shard-iclb1/igt@gem_exec_fair@basic-pace@bcs0.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-iclb1/igt@gem_exec_fair@basic-pace@bcs0.html
* igt@gem_exec_fair@basic-pace@vecs0:
- shard-kbl: [FAIL][105] ([i915#2842]) -> [PASS][106] +1 similar issue
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9870/shard-kbl7/igt@gem_exec_fair@basic-pace@vecs0.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-kbl2/igt@gem_exec_fair@basic-pace@vecs0.html
* igt@gem_exec_reloc@basic-many-active@rcs0:
- shard-glk: [FAIL][107] ([i915#2389]) -> [PASS][108]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9870/shard-glk3/igt@gem_exec_reloc@basic-many-active@rcs0.html
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-glk7/igt@gem_exec_reloc@basic-many-active@rcs0.html
* igt@gem_exec_schedule@u-fairslice@rcs0:
- shard-kbl: [DMESG-WARN][109] ([i915#1610] / [i915#2803]) -> [PASS][110]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9870/shard-kbl6/igt@gem_exec_schedule@u-fairslice@rcs0.html
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-kbl6/igt@gem_exec_schedule@u-fairslice@rcs0.html
* igt@gem_exec_whisper@basic-queues-forked-all:
- shard-iclb: [INCOMPLETE][111] -> [PASS][112]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9870/shard-iclb2/igt@gem_exec_whisper@basic-queues-forked-all.html
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-iclb7/igt@gem_exec_whisper@basic-queues-forked-all.html
* igt@i915_suspend@fence-restore-untiled:
- shard-apl: [DMESG-WARN][113] ([i915#180]) -> [PASS][114] +1 similar issue
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9870/shard-apl6/igt@i915_suspend@fence-restore-untiled.html
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-apl3/igt@i915_suspend@fence-restore-untiled.html
* igt@kms_async_flips@test-time-stamp:
- shard-tglb: [FAIL][115] ([i915#2597]) -> [PASS][116]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9870/shard-tglb5/igt@kms_async_flips@test-time-stamp.html
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-tglb1/igt@kms_async_flips@test-time-stamp.html
* igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding:
- shard-skl: [FAIL][117] ([i915#54]) -> [PASS][118]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9870/shard-skl4/igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding.html
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-skl8/igt@kms_cursor_crc@pipe-a-cursor-64x64-sliding.html
* igt@kms_cursor_legacy@flip-vs-cursor-varying-size:
- shard-tglb: [FAIL][119] ([i915#2346]) -> [PASS][120]
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9870/shard-tglb3/igt@kms_cursor_legacy@flip-vs-cursor-varying-size.html
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-tglb3/igt@kms_cursor_legacy@flip-vs-cursor-varying-size.html
* igt@kms_flip@flip-vs-suspend@b-edp1:
- shard-skl: [INCOMPLETE][121] ([i915#198]) -> [PASS][122]
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9870/shard-skl9/igt@kms_flip@flip-vs-suspend@b-edp1.html
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-skl5/igt@kms_flip@flip-vs-suspend@b-edp1.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- shard-tglb: [INCOMPLETE][123] ([i915#456]) -> [PASS][124]
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9870/shard-tglb7/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-tglb7/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: [FAIL][125] ([fdo#108145] / [i915#265]) -> [PASS][126]
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9870/shard-skl4/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-skl1/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
* igt@kms_psr@psr2_no_drrs:
- shard-iclb: [SKIP][127] ([fdo#109441]) -> [PASS][128] +3 similar issues
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9870/shard-iclb4/igt@kms_psr@psr2_no_drrs.html
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
* igt@sysfs_clients@busy@vcs0:
- shard-kbl: [FAIL][129] ([i915#3009]) -> [PASS][130] +1 similar issue
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9870/shard-kbl7/igt@sysfs_clients@busy@vcs0.html
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-kbl3/igt@sysfs_clients@busy@vcs0.html
* igt@sysfs_clients@recycle-many:
- shard-kbl: [FAIL][131] ([i915#3028]) -> [PASS][132]
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9870/shard-kbl1/igt@sysfs_clients@recycle-many.html
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-kbl6/igt@sysfs_clients@recycle-many.html
* igt@sysfs_clients@split-25@vcs0:
- shard-skl: [SKIP][133] ([fdo#109271]) -> [PASS][134]
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9870/shard-skl10/igt@sysfs_clients@split-25@vcs0.html
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-skl8/igt@sysfs_clients@split-25@vcs0.html
* igt@sysfs_heartbeat_interval@precise@vecs0:
- shard-skl: [FAIL][135] -> [PASS][136]
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9870/shard-skl6/igt@sysfs_heartbeat_interval@precise@vecs0.html
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-skl7/igt@sysfs_heartbeat_interval@precise@vecs0.html
#### Warnings ####
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-iclb: [FAIL][137] ([i915#2849]) -> [FAIL][138] ([i915#2842])
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9870/shard-iclb7/igt@gem_exec_fair@basic-throttle@rcs0.html
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-iclb6/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@i915_pm_rc6_residency@rc6-idle:
- shard-iclb: [WARN][139] ([i915#2681] / [i915#2684]) -> [WARN][140] ([i915#1804] / [i915#2684])
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9870/shard-iclb1/igt@i915_pm_rc6_residency@rc6-idle.html
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-iclb6/igt@i915_pm_rc6_residency@rc6-idle.html
* igt@kms_content_protection@mei_interface:
- shard-iclb: [SKIP][141] ([fdo#109300] / [fdo#111066]) -> [FAIL][142] ([i915#3144])
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9870/shard-iclb8/igt@kms_content_protection@mei_interface.html
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-iclb1/igt@kms_content_protection@mei_interface.html
* igt@kms_content_protection@type1:
- shard-iclb: [FAIL][143] ([i915#3144]) -> [SKIP][144] ([fdo#109300] / [fdo#111066])
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9870/shard-iclb1/igt@kms_content_protection@type1.html
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-iclb6/igt@kms_content_protection@type1.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1:
- shard-iclb: [SKIP][145] ([i915#2920]) -> [SKIP][146] ([i915#658]) +1 similar issue
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9870/shard-iclb2/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1.html
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/shard-iclb7/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1.html
* igt@runner@aborted:
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19807/index.html
[-- Attachment #1.2: Type: text/html, Size: 33506 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH 1/2] drm/i915: Fix pre-skl DP AUX precharge length
2021-03-18 18:10 [Intel-gfx] [PATCH 1/2] drm/i915: Fix pre-skl DP AUX precharge length Ville Syrjala
` (3 preceding siblings ...)
2021-03-19 2:08 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
@ 2021-03-30 18:06 ` Ville Syrjälä
2021-04-26 15:54 ` Imre Deak
5 siblings, 0 replies; 10+ messages in thread
From: Ville Syrjälä @ 2021-03-30 18:06 UTC (permalink / raw)
To: intel-gfx
On Thu, Mar 18, 2021 at 08:10:38PM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> DP v1.1+ says:
> "The DisplayPort transmitter, which is the driving end for a request
> transaction, pre-charges the AUX-CH+ and AUX-CH- to a common mode
> voltage by transmitting 10 to 16 consecutive 0’s in Manchester II code.
> After the active pre-charge, the transmitter sends an AUX Sync pattern.
> The AUX Sync pattern must be as follows:
> Start with 16 consecutive 0s in Manchester-II code, which results in
> a transition from low to high in the middle of each bit period.
> Including active pre-charge pulses, there shall be 26 to 32
> consecutive 0s before the end of the AUX_SYNC pattern."
>
> BDW bspec says:
> "Used to determine the precharge time for the Aux Channel. During this
> time the Aux Channel will drive the SYNC pattern. Every microsecond
> gives one additional SYNC pulse beyond the hard coded 26 SYNC pulses.
> The value is the number of microseconds times 2. Default is 3 decimal
> which gives 6us of precharge which is 6 extra SYN pulses for a total
> of 32."
>
> CPT bspec says the same thing apart from:
> "... Default is 5 decimal which gives 10us of precharge which is 10
> extra SYNC pulses for a total of 36."
>
> So it looks like to match the max of 32 of the DP spec we should just
> always program this extra precharge time to 3.
>
> Unfortunately g4x/ibx bspec doesn't have this clarification, but
> since the cpt default was still the same 5 as for g4x/ibx let's
> assume the behaviour was always the same.
I did a bit more archaeology and found the following:
commit e3421a189447 ("drm/i915: enable DP/eDP for Sandybridge/Cougarpoint")
added the precharge==3 for snb.
commit 092945e11c5b ("drm/i915/dp: Use auxch precharge value of 5 everywhere")
tried to change it to be 5 for snb.
commit 6b4e0a93ff6e ("Revert "drm/i915/dp: Use auxch precharge value of 5 everywhere"")
went back to 3 for snb due to a regression.
So I think the value of 5 was just always wrong, but I guess very
few display actually get upset if we do too many SYNCs. Also DP 1.0
did not specify any max value for this, whereas DP 1.1+ added the
max==32 wording.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dp_aux.c | 9 ++-------
> 1 file changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux.c b/drivers/gpu/drm/i915/display/intel_dp_aux.c
> index eaebf123310a..d5443d6d6123 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp_aux.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp_aux.c
> @@ -126,12 +126,7 @@ static u32 g4x_get_aux_send_ctl(struct intel_dp *intel_dp,
> struct intel_digital_port *dig_port = dp_to_dig_port(intel_dp);
> struct drm_i915_private *dev_priv =
> to_i915(dig_port->base.base.dev);
> - u32 precharge, timeout;
> -
> - if (IS_GEN(dev_priv, 6))
> - precharge = 3;
> - else
> - precharge = 5;
> + u32 timeout;
>
> if (IS_BROADWELL(dev_priv))
> timeout = DP_AUX_CH_CTL_TIME_OUT_600us;
> @@ -145,7 +140,7 @@ static u32 g4x_get_aux_send_ctl(struct intel_dp *intel_dp,
> timeout |
> DP_AUX_CH_CTL_RECEIVE_ERROR |
> (send_bytes << DP_AUX_CH_CTL_MESSAGE_SIZE_SHIFT) |
> - (precharge << DP_AUX_CH_CTL_PRECHARGE_2US_SHIFT) |
> + (3 << DP_AUX_CH_CTL_PRECHARGE_2US_SHIFT) |
> (aux_clock_divider << DP_AUX_CH_CTL_BIT_CLOCK_2X_SHIFT);
> }
>
> --
> 2.26.2
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH 1/2] drm/i915: Fix pre-skl DP AUX precharge length
2021-03-18 18:10 [Intel-gfx] [PATCH 1/2] drm/i915: Fix pre-skl DP AUX precharge length Ville Syrjala
` (4 preceding siblings ...)
2021-03-30 18:06 ` [Intel-gfx] [PATCH 1/2] " Ville Syrjälä
@ 2021-04-26 15:54 ` Imre Deak
5 siblings, 0 replies; 10+ messages in thread
From: Imre Deak @ 2021-04-26 15:54 UTC (permalink / raw)
To: Ville Syrjala; +Cc: intel-gfx
On Thu, Mar 18, 2021 at 08:10:38PM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> DP v1.1+ says:
> "The DisplayPort transmitter, which is the driving end for a request
> transaction, pre-charges the AUX-CH+ and AUX-CH- to a common mode
> voltage by transmitting 10 to 16 consecutive 0’s in Manchester II code.
> After the active pre-charge, the transmitter sends an AUX Sync pattern.
> The AUX Sync pattern must be as follows:
> Start with 16 consecutive 0s in Manchester-II code, which results in
> a transition from low to high in the middle of each bit period.
> Including active pre-charge pulses, there shall be 26 to 32
> consecutive 0s before the end of the AUX_SYNC pattern."
>
> BDW bspec says:
> "Used to determine the precharge time for the Aux Channel. During this
> time the Aux Channel will drive the SYNC pattern. Every microsecond
> gives one additional SYNC pulse beyond the hard coded 26 SYNC pulses.
> The value is the number of microseconds times 2. Default is 3 decimal
> which gives 6us of precharge which is 6 extra SYN pulses for a total
> of 32."
>
> CPT bspec says the same thing apart from:
> "... Default is 5 decimal which gives 10us of precharge which is 10
> extra SYNC pulses for a total of 36."
>
> So it looks like to match the max of 32 of the DP spec we should just
> always program this extra precharge time to 3.
>
> Unfortunately g4x/ibx bspec doesn't have this clarification, but
> since the cpt default was still the same 5 as for g4x/ibx let's
> assume the behaviour was always the same.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Imre Deak <imre.deak@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dp_aux.c | 9 ++-------
> 1 file changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux.c b/drivers/gpu/drm/i915/display/intel_dp_aux.c
> index eaebf123310a..d5443d6d6123 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp_aux.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp_aux.c
> @@ -126,12 +126,7 @@ static u32 g4x_get_aux_send_ctl(struct intel_dp *intel_dp,
> struct intel_digital_port *dig_port = dp_to_dig_port(intel_dp);
> struct drm_i915_private *dev_priv =
> to_i915(dig_port->base.base.dev);
> - u32 precharge, timeout;
> -
> - if (IS_GEN(dev_priv, 6))
> - precharge = 3;
> - else
> - precharge = 5;
> + u32 timeout;
>
> if (IS_BROADWELL(dev_priv))
> timeout = DP_AUX_CH_CTL_TIME_OUT_600us;
> @@ -145,7 +140,7 @@ static u32 g4x_get_aux_send_ctl(struct intel_dp *intel_dp,
> timeout |
> DP_AUX_CH_CTL_RECEIVE_ERROR |
> (send_bytes << DP_AUX_CH_CTL_MESSAGE_SIZE_SHIFT) |
> - (precharge << DP_AUX_CH_CTL_PRECHARGE_2US_SHIFT) |
> + (3 << DP_AUX_CH_CTL_PRECHARGE_2US_SHIFT) |
> (aux_clock_divider << DP_AUX_CH_CTL_BIT_CLOCK_2X_SHIFT);
> }
>
> --
> 2.26.2
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH 2/2] drm/i915: Remove stray newlines
2021-03-18 18:10 ` [Intel-gfx] [PATCH 2/2] drm/i915: Remove stray newlines Ville Syrjala
@ 2021-04-26 15:55 ` Imre Deak
0 siblings, 0 replies; 10+ messages in thread
From: Imre Deak @ 2021-04-26 15:55 UTC (permalink / raw)
To: Ville Syrjala; +Cc: intel-gfx
On Thu, Mar 18, 2021 at 08:10:39PM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> A bunch of files have a stray newline at the end. Remove it.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviwed-by: Imre Deak <imre.deak@intel.com>
> ---
> drivers/gpu/drm/i915/display/i9xx_plane.c | 1 -
> drivers/gpu/drm/i915/display/skl_universal_plane.c | 1 -
> drivers/gpu/drm/i915/gt/uc/intel_guc_log_debugfs.c | 1 -
> drivers/gpu/drm/i915/i915_params.h | 1 -
> drivers/gpu/drm/i915/i915_vma_types.h | 1 -
> 5 files changed, 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/i9xx_plane.c b/drivers/gpu/drm/i915/display/i9xx_plane.c
> index 8a52beaed2da..7391cd195d41 100644
> --- a/drivers/gpu/drm/i915/display/i9xx_plane.c
> +++ b/drivers/gpu/drm/i915/display/i9xx_plane.c
> @@ -1038,4 +1038,3 @@ i9xx_get_initial_plane_config(struct intel_crtc *crtc,
>
> plane_config->fb = intel_fb;
> }
> -
> diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane.c b/drivers/gpu/drm/i915/display/skl_universal_plane.c
> index 1f335cb09149..a06c474223c1 100644
> --- a/drivers/gpu/drm/i915/display/skl_universal_plane.c
> +++ b/drivers/gpu/drm/i915/display/skl_universal_plane.c
> @@ -2263,4 +2263,3 @@ skl_get_initial_plane_config(struct intel_crtc *crtc,
> error:
> kfree(intel_fb);
> }
> -
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_log_debugfs.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_log_debugfs.c
> index 129e0cf7dfe2..64e0b86bf258 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_log_debugfs.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_log_debugfs.c
> @@ -121,4 +121,3 @@ void intel_guc_log_debugfs_register(struct intel_guc_log *log,
>
> intel_gt_debugfs_register_files(root, files, ARRAY_SIZE(files), log);
> }
> -
> diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h
> index 48f47e44e848..18bbc92b642d 100644
> --- a/drivers/gpu/drm/i915/i915_params.h
> +++ b/drivers/gpu/drm/i915/i915_params.h
> @@ -96,4 +96,3 @@ void i915_params_copy(struct i915_params *dest, const struct i915_params *src);
> void i915_params_free(struct i915_params *params);
>
> #endif
> -
> diff --git a/drivers/gpu/drm/i915/i915_vma_types.h b/drivers/gpu/drm/i915/i915_vma_types.h
> index f5cb848b7a7e..c7614fbabb9c 100644
> --- a/drivers/gpu/drm/i915/i915_vma_types.h
> +++ b/drivers/gpu/drm/i915/i915_vma_types.h
> @@ -282,4 +282,3 @@ struct i915_vma {
> };
>
> #endif
> -
> --
> 2.26.2
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2021-04-26 15:55 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-18 18:10 [Intel-gfx] [PATCH 1/2] drm/i915: Fix pre-skl DP AUX precharge length Ville Syrjala
2021-03-18 18:10 ` [Intel-gfx] [PATCH 2/2] drm/i915: Remove stray newlines Ville Syrjala
2021-04-26 15:55 ` Imre Deak
2021-03-18 20:09 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: Fix pre-skl DP AUX precharge length Patchwork
2021-03-18 20:52 ` Ville Syrjälä
2021-03-18 21:22 ` Vudum, Lakshminarayana
2021-03-18 21:00 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-03-19 2:08 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-03-30 18:06 ` [Intel-gfx] [PATCH 1/2] " Ville Syrjälä
2021-04-26 15:54 ` Imre Deak
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox