* [Intel-gfx] [PATCH] drm/i915: Drop all references to DRM IRQ midlayer
@ 2021-06-25 8:47 Thomas Zimmermann
2021-06-25 10:59 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Thomas Zimmermann @ 2021-06-25 8:47 UTC (permalink / raw)
To: jani.nikula, joonas.lahtinen, rodrigo.vivi, airlied, daniel,
chris, mika.kuoppala, matthew.brost, maarten.lankhorst,
lucas.demarchi
Cc: Daniel Vetter, intel-gfx, Thomas Zimmermann, dri-devel
Remove all references to DRM's IRQ midlayer.
The code in xcs_resume() probably didn't work as intended. It uses
struct drm_device.irq, which is allocated to 0, but never initialized
by i915 to the device's interrupt number.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Fixes: 536f77b1caa0 ("drm/i915/gt: Call stop_ring() from ring resume, again")
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
---
drivers/gpu/drm/i915/gt/intel_ring_submission.c | 3 ++-
drivers/gpu/drm/i915/i915_drv.c | 1 -
drivers/gpu/drm/i915/i915_irq.c | 1 -
3 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_ring_submission.c b/drivers/gpu/drm/i915/gt/intel_ring_submission.c
index 5d42a12ef3d6..d893aaaed74f 100644
--- a/drivers/gpu/drm/i915/gt/intel_ring_submission.c
+++ b/drivers/gpu/drm/i915/gt/intel_ring_submission.c
@@ -180,12 +180,13 @@ static bool stop_ring(struct intel_engine_cs *engine)
static int xcs_resume(struct intel_engine_cs *engine)
{
struct intel_ring *ring = engine->legacy.ring;
+ struct pci_dev *pdev = to_pci_dev(engine->i915->drm.dev);
ENGINE_TRACE(engine, "ring:{HEAD:%04x, TAIL:%04x}\n",
ring->head, ring->tail);
/* Double check the ring is empty & disabled before we resume */
- synchronize_hardirq(engine->i915->drm.irq);
+ synchronize_hardirq(pdev->irq);
if (!stop_ring(engine))
goto err;
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index 850b499c71c8..73de45472f60 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -42,7 +42,6 @@
#include <drm/drm_aperture.h>
#include <drm/drm_atomic_helper.h>
#include <drm/drm_ioctl.h>
-#include <drm/drm_irq.h>
#include <drm/drm_managed.h>
#include <drm/drm_probe_helper.h>
diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
index a11bdb667241..eef616d96f12 100644
--- a/drivers/gpu/drm/i915/i915_irq.c
+++ b/drivers/gpu/drm/i915/i915_irq.c
@@ -33,7 +33,6 @@
#include <linux/sysrq.h>
#include <drm/drm_drv.h>
-#include <drm/drm_irq.h>
#include "display/intel_de.h"
#include "display/intel_display_types.h"
base-commit: 8c1323b422f8473421682ba783b5949ddd89a3f4
prerequisite-patch-id: c2b2f08f0eccc9f5df0c0da49fa1d36267deb11d
prerequisite-patch-id: c67e5d886a47b7d0266d81100837557fda34cb24
--
2.32.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Drop all references to DRM IRQ midlayer 2021-06-25 8:47 [Intel-gfx] [PATCH] drm/i915: Drop all references to DRM IRQ midlayer Thomas Zimmermann @ 2021-06-25 10:59 ` Patchwork 2021-06-25 13:20 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork 2021-06-29 16:10 ` [Intel-gfx] [PATCH] " Ville Syrjälä 2 siblings, 0 replies; 5+ messages in thread From: Patchwork @ 2021-06-25 10:59 UTC (permalink / raw) To: Thomas Zimmermann; +Cc: intel-gfx [-- Attachment #1.1: Type: text/plain, Size: 3596 bytes --] == Series Details == Series: drm/i915: Drop all references to DRM IRQ midlayer URL : https://patchwork.freedesktop.org/series/91915/ State : success == Summary == CI Bug Log - changes from CI_DRM_10280 -> Patchwork_20467 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/index.html Possible new issues ------------------- Here are the unknown changes that may have been introduced in Patchwork_20467: ### IGT changes ### #### Suppressed #### The following results come from untrusted machines, tests, or statuses. They do not affect the overall result. * igt@i915_selftest@live@gt_pm: - {fi-jsl-1}: [PASS][1] -> [DMESG-FAIL][2] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10280/fi-jsl-1/igt@i915_selftest@live@gt_pm.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/fi-jsl-1/igt@i915_selftest@live@gt_pm.html Known issues ------------ Here are the changes found in Patchwork_20467 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@amdgpu/amd_basic@cs-gfx: - fi-kbl-soraka: NOTRUN -> [SKIP][3] ([fdo#109271]) +5 similar issues [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/fi-kbl-soraka/igt@amdgpu/amd_basic@cs-gfx.html * igt@amdgpu/amd_basic@semaphore: - fi-bdw-5557u: NOTRUN -> [SKIP][4] ([fdo#109271]) +27 similar issues [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/fi-bdw-5557u/igt@amdgpu/amd_basic@semaphore.html * igt@core_hotunplug@unbind-rebind: - fi-bdw-5557u: NOTRUN -> [WARN][5] ([i915#2283]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/fi-bdw-5557u/igt@core_hotunplug@unbind-rebind.html * igt@kms_chamelium@dp-crc-fast: - fi-bdw-5557u: NOTRUN -> [SKIP][6] ([fdo#109271] / [fdo#111827]) +8 similar issues [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/fi-bdw-5557u/igt@kms_chamelium@dp-crc-fast.html #### Possible fixes #### * igt@i915_selftest@live@hangcheck: - {fi-hsw-gt1}: [DMESG-WARN][7] ([i915#3303]) -> [PASS][8] [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10280/fi-hsw-gt1/igt@i915_selftest@live@hangcheck.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/fi-hsw-gt1/igt@i915_selftest@live@hangcheck.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [i915#2283]: https://gitlab.freedesktop.org/drm/intel/issues/2283 [i915#3303]: https://gitlab.freedesktop.org/drm/intel/issues/3303 Participating hosts (43 -> 39) ------------------------------ Missing (4): fi-ilk-m540 fi-bsw-cyan fi-bdw-samus fi-hsw-4200u Build changes ------------- * Linux: CI_DRM_10280 -> Patchwork_20467 CI-20190529: 20190529 CI_DRM_10280: f931f9f9f1188586bca423930ea09d880dd6a269 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_6119: a306810ebbc8984bde38a57ef0c33eea394f4e18 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git Patchwork_20467: c4b640356a9b733586da2bc0bc3ee43bfc1400b6 @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == c4b640356a9b drm/i915: Drop all references to DRM IRQ midlayer == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/index.html [-- Attachment #1.2: Type: text/html, Size: 4476 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 5+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Drop all references to DRM IRQ midlayer 2021-06-25 8:47 [Intel-gfx] [PATCH] drm/i915: Drop all references to DRM IRQ midlayer Thomas Zimmermann 2021-06-25 10:59 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork @ 2021-06-25 13:20 ` Patchwork 2021-06-29 16:10 ` [Intel-gfx] [PATCH] " Ville Syrjälä 2 siblings, 0 replies; 5+ messages in thread From: Patchwork @ 2021-06-25 13:20 UTC (permalink / raw) To: Thomas Zimmermann; +Cc: intel-gfx [-- Attachment #1.1: Type: text/plain, Size: 30272 bytes --] == Series Details == Series: drm/i915: Drop all references to DRM IRQ midlayer URL : https://patchwork.freedesktop.org/series/91915/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10280_full -> Patchwork_20467_full ==================================================== Summary ------- **FAILURE** Serious unknown changes coming with Patchwork_20467_full absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_20467_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. Possible new issues ------------------- Here are the unknown changes that may have been introduced in Patchwork_20467_full: ### IGT changes ### #### Possible regressions #### * igt@kms_plane@pixel-format-source-clamping@pipe-a-planes: - shard-tglb: [PASS][1] -> [INCOMPLETE][2] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10280/shard-tglb1/igt@kms_plane@pixel-format-source-clamping@pipe-a-planes.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-tglb3/igt@kms_plane@pixel-format-source-clamping@pipe-a-planes.html #### Warnings #### * igt@kms_cursor_crc@pipe-d-cursor-max-size-onscreen: - shard-skl: [SKIP][3] ([fdo#109271]) -> [INCOMPLETE][4] [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10280/shard-skl2/igt@kms_cursor_crc@pipe-d-cursor-max-size-onscreen.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-skl8/igt@kms_cursor_crc@pipe-d-cursor-max-size-onscreen.html Known issues ------------ Here are the changes found in Patchwork_20467_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_ctx_isolation@preservation-s3@vcs0: - shard-kbl: [PASS][5] -> [DMESG-WARN][6] ([i915#180]) +2 similar issues [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10280/shard-kbl7/igt@gem_ctx_isolation@preservation-s3@vcs0.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-kbl1/igt@gem_ctx_isolation@preservation-s3@vcs0.html * igt@gem_ctx_persistence@legacy-engines-mixed: - shard-snb: NOTRUN -> [SKIP][7] ([fdo#109271] / [i915#1099]) +3 similar issues [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-snb2/igt@gem_ctx_persistence@legacy-engines-mixed.html * igt@gem_eio@unwedge-stress: - shard-iclb: [PASS][8] -> [TIMEOUT][9] ([i915#2369] / [i915#2481] / [i915#3070]) [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10280/shard-iclb2/igt@gem_eio@unwedge-stress.html [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-iclb3/igt@gem_eio@unwedge-stress.html * igt@gem_exec_fair@basic-deadline: - shard-glk: [PASS][10] -> [FAIL][11] ([i915#2846]) [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10280/shard-glk8/igt@gem_exec_fair@basic-deadline.html [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-glk4/igt@gem_exec_fair@basic-deadline.html * igt@gem_exec_fair@basic-none-share@rcs0: - shard-iclb: [PASS][12] -> [FAIL][13] ([i915#2842]) [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10280/shard-iclb7/igt@gem_exec_fair@basic-none-share@rcs0.html [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-iclb2/igt@gem_exec_fair@basic-none-share@rcs0.html * igt@gem_exec_fair@basic-none-vip@rcs0: - shard-glk: [PASS][14] -> [FAIL][15] ([i915#2842]) [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10280/shard-glk5/igt@gem_exec_fair@basic-none-vip@rcs0.html [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-glk1/igt@gem_exec_fair@basic-none-vip@rcs0.html * igt@gem_exec_fair@basic-none@rcs0: - shard-kbl: [PASS][16] -> [FAIL][17] ([i915#2842]) +2 similar issues [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10280/shard-kbl6/igt@gem_exec_fair@basic-none@rcs0.html [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-kbl7/igt@gem_exec_fair@basic-none@rcs0.html * igt@gem_exec_fair@basic-pace-share@rcs0: - shard-tglb: [PASS][18] -> [FAIL][19] ([i915#2842]) [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10280/shard-tglb1/igt@gem_exec_fair@basic-pace-share@rcs0.html [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-tglb3/igt@gem_exec_fair@basic-pace-share@rcs0.html * igt@gem_exec_reloc@basic-wide-active@bcs0: - shard-apl: NOTRUN -> [FAIL][20] ([i915#3633]) +3 similar issues [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-apl8/igt@gem_exec_reloc@basic-wide-active@bcs0.html * igt@gem_exec_suspend@basic-s3: - shard-apl: NOTRUN -> [DMESG-WARN][21] ([i915#180]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-apl3/igt@gem_exec_suspend@basic-s3.html * igt@gem_exec_whisper@basic-fds-priority-all: - shard-iclb: [PASS][22] -> [INCOMPLETE][23] ([i915#1895]) [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10280/shard-iclb7/igt@gem_exec_whisper@basic-fds-priority-all.html [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-iclb2/igt@gem_exec_whisper@basic-fds-priority-all.html * igt@gem_mmap_gtt@cpuset-big-copy-odd: - shard-iclb: [PASS][24] -> [FAIL][25] ([i915#307]) [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10280/shard-iclb8/igt@gem_mmap_gtt@cpuset-big-copy-odd.html [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-iclb5/igt@gem_mmap_gtt@cpuset-big-copy-odd.html * igt@gem_pread@exhaustion: - shard-glk: NOTRUN -> [WARN][26] ([i915#2658]) [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-glk7/igt@gem_pread@exhaustion.html - shard-apl: NOTRUN -> [WARN][27] ([i915#2658]) +1 similar issue [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-apl3/igt@gem_pread@exhaustion.html * igt@gem_render_copy@x-tiled-to-vebox-yf-tiled: - shard-kbl: NOTRUN -> [SKIP][28] ([fdo#109271]) +64 similar issues [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-kbl1/igt@gem_render_copy@x-tiled-to-vebox-yf-tiled.html * igt@gem_softpin@evict-snoop-interruptible: - shard-iclb: NOTRUN -> [SKIP][29] ([fdo#109312]) [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-iclb4/igt@gem_softpin@evict-snoop-interruptible.html * igt@gem_userptr_blits@access-control: - shard-iclb: NOTRUN -> [SKIP][30] ([i915#3297]) [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-iclb4/igt@gem_userptr_blits@access-control.html * igt@gem_userptr_blits@vma-merge: - shard-apl: NOTRUN -> [FAIL][31] ([i915#3318]) [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-apl3/igt@gem_userptr_blits@vma-merge.html - shard-glk: NOTRUN -> [FAIL][32] ([i915#3318]) [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-glk7/igt@gem_userptr_blits@vma-merge.html * igt@i915_pm_rpm@modeset-lpsp-stress: - shard-apl: NOTRUN -> [SKIP][33] ([fdo#109271]) +138 similar issues [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-apl3/igt@i915_pm_rpm@modeset-lpsp-stress.html * igt@kms_async_flips@alternate-sync-async-flip: - shard-skl: [PASS][34] -> [FAIL][35] ([i915#2521]) [34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10280/shard-skl9/igt@kms_async_flips@alternate-sync-async-flip.html [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-skl5/igt@kms_async_flips@alternate-sync-async-flip.html * igt@kms_big_fb@linear-32bpp-rotate-180: - shard-glk: NOTRUN -> [DMESG-WARN][36] ([i915#118] / [i915#95]) [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-glk7/igt@kms_big_fb@linear-32bpp-rotate-180.html * igt@kms_big_joiner@2x-modeset: - shard-iclb: NOTRUN -> [SKIP][37] ([i915#2705]) [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-iclb4/igt@kms_big_joiner@2x-modeset.html * igt@kms_chamelium@dp-hpd-for-each-pipe: - shard-glk: NOTRUN -> [SKIP][38] ([fdo#109271] / [fdo#111827]) +3 similar issues [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-glk7/igt@kms_chamelium@dp-hpd-for-each-pipe.html * igt@kms_chamelium@dp-hpd-storm-disable: - shard-skl: NOTRUN -> [SKIP][39] ([fdo#109271] / [fdo#111827]) +1 similar issue [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-skl6/igt@kms_chamelium@dp-hpd-storm-disable.html * igt@kms_chamelium@hdmi-audio: - shard-iclb: NOTRUN -> [SKIP][40] ([fdo#109284] / [fdo#111827]) +2 similar issues [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-iclb4/igt@kms_chamelium@hdmi-audio.html * igt@kms_color@pipe-a-ctm-negative: - shard-skl: [PASS][41] -> [DMESG-WARN][42] ([i915#1982]) [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10280/shard-skl5/igt@kms_color@pipe-a-ctm-negative.html [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-skl2/igt@kms_color@pipe-a-ctm-negative.html * igt@kms_color@pipe-d-gamma: - shard-iclb: NOTRUN -> [SKIP][43] ([fdo#109278] / [i915#1149]) [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-iclb4/igt@kms_color@pipe-d-gamma.html * igt@kms_color_chamelium@pipe-a-ctm-0-25: - shard-kbl: NOTRUN -> [SKIP][44] ([fdo#109271] / [fdo#111827]) +4 similar issues [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-kbl1/igt@kms_color_chamelium@pipe-a-ctm-0-25.html * igt@kms_color_chamelium@pipe-a-ctm-limited-range: - shard-apl: NOTRUN -> [SKIP][45] ([fdo#109271] / [fdo#111827]) +15 similar issues [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-apl8/igt@kms_color_chamelium@pipe-a-ctm-limited-range.html * igt@kms_color_chamelium@pipe-c-ctm-green-to-red: - shard-snb: NOTRUN -> [SKIP][46] ([fdo#109271] / [fdo#111827]) +10 similar issues [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-snb2/igt@kms_color_chamelium@pipe-c-ctm-green-to-red.html * igt@kms_content_protection@legacy: - shard-apl: NOTRUN -> [TIMEOUT][47] ([i915#1319]) [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-apl3/igt@kms_content_protection@legacy.html * igt@kms_content_protection@type1: - shard-iclb: NOTRUN -> [SKIP][48] ([fdo#109300] / [fdo#111066]) [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-iclb4/igt@kms_content_protection@type1.html * igt@kms_content_protection@uevent: - shard-kbl: NOTRUN -> [FAIL][49] ([i915#2105]) [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-kbl1/igt@kms_content_protection@uevent.html * igt@kms_cursor_crc@pipe-a-cursor-512x170-onscreen: - shard-iclb: NOTRUN -> [SKIP][50] ([fdo#109278] / [fdo#109279]) [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-iclb4/igt@kms_cursor_crc@pipe-a-cursor-512x170-onscreen.html * igt@kms_cursor_crc@pipe-d-cursor-128x42-rapid-movement: - shard-iclb: NOTRUN -> [SKIP][51] ([fdo#109278]) +7 similar issues [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-iclb4/igt@kms_cursor_crc@pipe-d-cursor-128x42-rapid-movement.html * igt@kms_cursor_crc@pipe-d-cursor-256x85-rapid-movement: - shard-glk: NOTRUN -> [SKIP][52] ([fdo#109271]) +31 similar issues [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-glk7/igt@kms_cursor_crc@pipe-d-cursor-256x85-rapid-movement.html * igt@kms_cursor_edge_walk@pipe-c-128x128-right-edge: - shard-tglb: [PASS][53] -> [DMESG-WARN][54] ([i915#2868]) [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10280/shard-tglb8/igt@kms_cursor_edge_walk@pipe-c-128x128-right-edge.html [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-tglb5/igt@kms_cursor_edge_walk@pipe-c-128x128-right-edge.html * igt@kms_cursor_legacy@cursorb-vs-flipb-legacy: - shard-iclb: NOTRUN -> [SKIP][55] ([fdo#109274] / [fdo#109278]) [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-iclb4/igt@kms_cursor_legacy@cursorb-vs-flipb-legacy.html * igt@kms_draw_crc@draw-method-xrgb8888-mmap-cpu-ytiled: - shard-glk: [PASS][56] -> [DMESG-WARN][57] ([i915#118] / [i915#95]) [56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10280/shard-glk7/igt@kms_draw_crc@draw-method-xrgb8888-mmap-cpu-ytiled.html [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-glk3/igt@kms_draw_crc@draw-method-xrgb8888-mmap-cpu-ytiled.html * igt@kms_flip@2x-dpms-vs-vblank-race: - shard-iclb: NOTRUN -> [SKIP][58] ([fdo#109274]) [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-iclb4/igt@kms_flip@2x-dpms-vs-vblank-race.html * igt@kms_flip@plain-flip-fb-recreate@b-edp1: - shard-skl: [PASS][59] -> [FAIL][60] ([i915#2122]) [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10280/shard-skl8/igt@kms_flip@plain-flip-fb-recreate@b-edp1.html [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-skl6/igt@kms_flip@plain-flip-fb-recreate@b-edp1.html * igt@kms_frontbuffer_tracking@fbcpsr-farfromfence-mmap-gtt: - shard-skl: NOTRUN -> [SKIP][61] ([fdo#109271]) +10 similar issues [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-skl6/igt@kms_frontbuffer_tracking@fbcpsr-farfromfence-mmap-gtt.html * igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-onoff: - shard-snb: NOTRUN -> [SKIP][62] ([fdo#109271]) +190 similar issues [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-snb5/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-onoff.html * igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-shrfb-draw-blt: - shard-iclb: NOTRUN -> [SKIP][63] ([fdo#109280]) +9 similar issues [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-iclb4/igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-shrfb-draw-blt.html * igt@kms_pipe_crc_basic@read-crc-pipe-d: - shard-kbl: NOTRUN -> [SKIP][64] ([fdo#109271] / [i915#533]) +1 similar issue [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-kbl1/igt@kms_pipe_crc_basic@read-crc-pipe-d.html * igt@kms_plane@plane-panning-bottom-right-suspend@pipe-a-planes: - shard-skl: [PASS][65] -> [INCOMPLETE][66] ([i915#198]) [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10280/shard-skl4/igt@kms_plane@plane-panning-bottom-right-suspend@pipe-a-planes.html [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-skl10/igt@kms_plane@plane-panning-bottom-right-suspend@pipe-a-planes.html * igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb: - shard-apl: NOTRUN -> [FAIL][67] ([fdo#108145] / [i915#265]) [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-apl3/igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb.html * igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-1: - shard-kbl: NOTRUN -> [SKIP][68] ([fdo#109271] / [i915#658]) [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-kbl1/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-1.html * igt@kms_psr2_sf@plane-move-sf-dmg-area-2: - shard-apl: NOTRUN -> [SKIP][69] ([fdo#109271] / [i915#658]) +2 similar issues [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-apl3/igt@kms_psr2_sf@plane-move-sf-dmg-area-2.html * igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1: - shard-glk: NOTRUN -> [SKIP][70] ([fdo#109271] / [i915#658]) [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-glk7/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1.html * igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-5: - shard-iclb: NOTRUN -> [SKIP][71] ([i915#658]) [71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-iclb4/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-5.html * igt@kms_psr@psr2_cursor_plane_move: - shard-iclb: [PASS][72] -> [SKIP][73] ([fdo#109441]) +1 similar issue [72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10280/shard-iclb2/igt@kms_psr@psr2_cursor_plane_move.html [73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-iclb3/igt@kms_psr@psr2_cursor_plane_move.html * igt@kms_setmode@basic: - shard-snb: NOTRUN -> [FAIL][74] ([i915#31]) [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-snb2/igt@kms_setmode@basic.html * igt@kms_setmode@clone-exclusive-crtc: - shard-skl: NOTRUN -> [WARN][75] ([i915#2100]) [75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-skl6/igt@kms_setmode@clone-exclusive-crtc.html * igt@kms_vblank@pipe-a-ts-continuation-suspend: - shard-kbl: [PASS][76] -> [DMESG-WARN][77] ([i915#180] / [i915#295]) [76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10280/shard-kbl2/igt@kms_vblank@pipe-a-ts-continuation-suspend.html [77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-kbl4/igt@kms_vblank@pipe-a-ts-continuation-suspend.html * igt@kms_vblank@pipe-b-ts-continuation-suspend: - shard-skl: [PASS][78] -> [INCOMPLETE][79] ([i915#198] / [i915#2828]) [78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10280/shard-skl7/igt@kms_vblank@pipe-b-ts-continuation-suspend.html [79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-skl7/igt@kms_vblank@pipe-b-ts-continuation-suspend.html * igt@kms_vrr@flip-basic: - shard-iclb: NOTRUN -> [SKIP][80] ([fdo#109502]) [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-iclb4/igt@kms_vrr@flip-basic.html * igt@perf@gen12-oa-tlb-invalidate: - shard-iclb: NOTRUN -> [SKIP][81] ([fdo#109289]) +2 similar issues [81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-iclb4/igt@perf@gen12-oa-tlb-invalidate.html * igt@perf@polling-parameterized: - shard-glk: NOTRUN -> [FAIL][82] ([i915#1542]) [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-glk7/igt@perf@polling-parameterized.html - shard-skl: [PASS][83] -> [FAIL][84] ([i915#1542]) [83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10280/shard-skl10/igt@perf@polling-parameterized.html [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-skl1/igt@perf@polling-parameterized.html * igt@prime_nv_test@nv_write_i915_cpu_mmap_read: - shard-iclb: NOTRUN -> [SKIP][85] ([fdo#109291]) [85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-iclb4/igt@prime_nv_test@nv_write_i915_cpu_mmap_read.html * igt@sysfs_clients@fair-3: - shard-kbl: NOTRUN -> [SKIP][86] ([fdo#109271] / [i915#2994]) [86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-kbl1/igt@sysfs_clients@fair-3.html * igt@sysfs_clients@split-25: - shard-apl: NOTRUN -> [SKIP][87] ([fdo#109271] / [i915#2994]) +1 similar issue [87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-apl3/igt@sysfs_clients@split-25.html * igt@sysfs_clients@split-50: - shard-iclb: NOTRUN -> [SKIP][88] ([i915#2994]) [88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-iclb4/igt@sysfs_clients@split-50.html #### Possible fixes #### * igt@gem_exec_fair@basic-pace-share@rcs0: - shard-glk: [FAIL][89] ([i915#2842]) -> [PASS][90] [89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10280/shard-glk1/igt@gem_exec_fair@basic-pace-share@rcs0.html [90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-glk3/igt@gem_exec_fair@basic-pace-share@rcs0.html * igt@gem_exec_whisper@basic-contexts: - shard-glk: [DMESG-WARN][91] ([i915#118] / [i915#95]) -> [PASS][92] [91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10280/shard-glk7/igt@gem_exec_whisper@basic-contexts.html [92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-glk3/igt@gem_exec_whisper@basic-contexts.html * igt@gem_exec_whisper@basic-contexts-all: - shard-iclb: [INCOMPLETE][93] ([i915#2405]) -> [PASS][94] [93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10280/shard-iclb4/igt@gem_exec_whisper@basic-contexts-all.html [94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-iclb4/igt@gem_exec_whisper@basic-contexts-all.html * igt@kms_color@pipe-a-ctm-0-5: - shard-skl: [DMESG-WARN][95] ([i915#1982]) -> [PASS][96] +2 similar issues [95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10280/shard-skl9/igt@kms_color@pipe-a-ctm-0-5.html [96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-skl5/igt@kms_color@pipe-a-ctm-0-5.html * igt@kms_cursor_crc@pipe-a-cursor-suspend: - shard-apl: [DMESG-WARN][97] ([i915#180]) -> [PASS][98] [97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10280/shard-apl3/igt@kms_cursor_crc@pipe-a-cursor-suspend.html [98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-apl8/igt@kms_cursor_crc@pipe-a-cursor-suspend.html * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions: - shard-skl: [FAIL][99] ([i915#2346]) -> [PASS][100] [99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10280/shard-skl8/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html [100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-skl1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html * igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1: - shard-skl: [FAIL][101] ([i915#79]) -> [PASS][102] [101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10280/shard-skl5/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html [102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-skl2/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html * igt@kms_flip@flip-vs-suspend-interruptible@a-dp1: - shard-kbl: [DMESG-WARN][103] ([i915#180]) -> [PASS][104] +4 similar issues [103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10280/shard-kbl4/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html [104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-kbl3/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html * igt@kms_plane_alpha_blend@pipe-c-coverage-7efc: - shard-skl: [FAIL][105] ([fdo#108145] / [i915#265]) -> [PASS][106] +2 similar issues [105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10280/shard-skl5/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html [106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-skl2/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html * igt@kms_psr2_su@frontbuffer: - shard-iclb: [SKIP][107] ([fdo#109642] / [fdo#111068] / [i915#658]) -> [PASS][108] [107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10280/shard-iclb7/igt@kms_psr2_su@frontbuffer.html [108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-iclb2/igt@kms_psr2_su@frontbuffer.html * igt@kms_psr@psr2_sprite_plane_move: - shard-iclb: [SKIP][109] ([fdo#109441]) -> [PASS][110] [109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10280/shard-iclb7/igt@kms_psr@psr2_sprite_plane_move.html [110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html * igt@perf@polling-small-buf: - shard-skl: [FAIL][111] ([i915#1722]) -> [PASS][112] [111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10280/shard-skl9/igt@perf@polling-small-buf.html [112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-skl7/igt@perf@polling-small-buf.html #### Warnings #### * igt@gem_exec_fair@basic-throttle@rcs0: - shard-iclb: [FAIL][113] ([i915#2842]) -> [FAIL][114] ([i915#2849]) [113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10280/shard-iclb8/igt@gem_exec_fair@basic-throttle@rcs0.html [114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-iclb1/igt@gem_exec_fair@basic-throttle@rcs0.html * igt@i915_pm_rc6_residency@rc6-fence: - shard-iclb: [WARN][115] ([i915#2684]) -> [WARN][116] ([i915#1804] / [i915#2684]) [115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10280/shard-iclb5/igt@i915_pm_rc6_residency@rc6-fence.html [116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-iclb6/igt@i915_pm_rc6_residency@rc6-fence.html * igt@kms_big_fb@x-tiled-32bpp-rotate-180: - shard-glk: [DMESG-WARN][117] ([i915#118] / [i915#1982] / [i915#95]) -> [DMESG-WARN][118] ([i915#118] / [i915#95]) [117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10280/shard-glk3/igt@kms_big_fb@x-tiled-32bpp-rotate-180.html [118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-glk1/igt@kms_big_fb@x-tiled-32bpp-rotate-180.html * igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1: - shard-iclb: [SKIP][119] -> [SKIP][120] ([i915#658]) +1 similar issue [119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10280/shard-iclb2/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1.html [120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-iclb3/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1.html * igt@runner@aborted: - shard-kbl: ([FAIL][121], [FAIL][122], [FAIL][123], [FAIL][124], [FAIL][125], [FAIL][126]) ([i915#180] / [i915#1814] / [i915#3002] / [i915#3363]) -> ([FAIL][127], [FAIL][128], [FAIL][129], [FAIL][130], [FAIL][131], [FAIL][132]) ([i915#1436] / [i915#180] / [i915#1814] / [i915#3002] / [i915#3363] / [i915#602]) [121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10280/shard-kbl1/igt@runner@aborted.html [122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10280/shard-kbl2/igt@runner@aborted.html [123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10280/shard-kbl1/igt@runner@aborted.html [124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10280/shard-kbl4/igt@runner@aborted.html [125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10280/shard-kbl4/igt@runner@aborted.html [126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10280/shard-kbl4/igt@runner@aborted.html [127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-kbl4/igt@runner@aborted.html [128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-kbl4/igt@runner@aborted.html [129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-kbl4/igt@runner@aborted.html [130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-kbl4/igt@runner@aborted.html [131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-kbl1/igt@runner@aborted.html [132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-kbl2/igt@runner@aborted.html - shard-apl: ([FAIL][133], [FAIL][134], [FAIL][135]) ([i915#1814] / [i915#3002] / [i915#3363]) -> ([FAIL][136], [FAIL][137], [FAIL][138]) ([i915#180] / [i915#1814] / [i915#3002] / [i915#3363]) [133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10280/shard-apl8/igt@runner@aborted.html [134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10280/shard-apl3/igt@runner@aborted.html [135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10280/shard-apl1/igt@runner@aborted.html [136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-apl8/igt@runner@aborted.html [137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-apl3/igt@runner@aborted.html [138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/shard-apl3/igt@runner@aborted.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274 [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278 [fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279 [fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280 [fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284 [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289 [fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291 [fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300 [fdo#109312]: https://bugs.freedesktop.org/show_bug.cgi?id=109312 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#109502]: https://bugs.freedesktop.org/show_bug.cgi?id=109502 [fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642 [fdo#111066]: https://bugs.freedesktop.org/show_bug.cgi?id=111066 [fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099 [i915#1149]: https://gitlab.freedesktop.org/drm/intel/issues/1149 [i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118 [i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319 [i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436 [i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542 [i915#1722]: https://gitlab.freedesktop.org/drm/intel/issues/1722 [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180 [i915#1804]: https://gitlab.freedesktop.org/drm/intel/issues/1804 [i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814 == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20467/index.html [-- Attachment #1.2: Type: text/html, Size: 36385 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Drop all references to DRM IRQ midlayer 2021-06-25 8:47 [Intel-gfx] [PATCH] drm/i915: Drop all references to DRM IRQ midlayer Thomas Zimmermann 2021-06-25 10:59 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork 2021-06-25 13:20 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork @ 2021-06-29 16:10 ` Ville Syrjälä 2021-06-29 16:39 ` Daniel Vetter 2 siblings, 1 reply; 5+ messages in thread From: Ville Syrjälä @ 2021-06-29 16:10 UTC (permalink / raw) To: Thomas Zimmermann Cc: airlied, intel-gfx, chris, Daniel Vetter, dri-devel, lucas.demarchi On Fri, Jun 25, 2021 at 10:47:40AM +0200, Thomas Zimmermann wrote: > Remove all references to DRM's IRQ midlayer. > > The code in xcs_resume() probably didn't work as intended. It uses > struct drm_device.irq, which is allocated to 0, but never initialized > by i915 to the device's interrupt number. > > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> > Fixes: 536f77b1caa0 ("drm/i915/gt: Call stop_ring() from ring resume, again") > Cc: Chris Wilson <chris@chris-wilson.co.uk> > Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com> > Cc: Daniel Vetter <daniel.vetter@ffwll.ch> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > Cc: Lucas De Marchi <lucas.demarchi@intel.com> > --- > drivers/gpu/drm/i915/gt/intel_ring_submission.c | 3 ++- > drivers/gpu/drm/i915/i915_drv.c | 1 - > drivers/gpu/drm/i915/i915_irq.c | 1 - > 3 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gt/intel_ring_submission.c b/drivers/gpu/drm/i915/gt/intel_ring_submission.c > index 5d42a12ef3d6..d893aaaed74f 100644 > --- a/drivers/gpu/drm/i915/gt/intel_ring_submission.c > +++ b/drivers/gpu/drm/i915/gt/intel_ring_submission.c > @@ -180,12 +180,13 @@ static bool stop_ring(struct intel_engine_cs *engine) > static int xcs_resume(struct intel_engine_cs *engine) > { > struct intel_ring *ring = engine->legacy.ring; > + struct pci_dev *pdev = to_pci_dev(engine->i915->drm.dev); > > ENGINE_TRACE(engine, "ring:{HEAD:%04x, TAIL:%04x}\n", > ring->head, ring->tail); > > /* Double check the ring is empty & disabled before we resume */ > - synchronize_hardirq(engine->i915->drm.irq); > + synchronize_hardirq(pdev->irq); We have intel_synchronize_irq() to hide all these mundane details. Might want to add a matching intel_synchronize_hardirq(). > if (!stop_ring(engine)) > goto err; > > diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c > index 850b499c71c8..73de45472f60 100644 > --- a/drivers/gpu/drm/i915/i915_drv.c > +++ b/drivers/gpu/drm/i915/i915_drv.c > @@ -42,7 +42,6 @@ > #include <drm/drm_aperture.h> > #include <drm/drm_atomic_helper.h> > #include <drm/drm_ioctl.h> > -#include <drm/drm_irq.h> > #include <drm/drm_managed.h> > #include <drm/drm_probe_helper.h> > > diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c > index a11bdb667241..eef616d96f12 100644 > --- a/drivers/gpu/drm/i915/i915_irq.c > +++ b/drivers/gpu/drm/i915/i915_irq.c > @@ -33,7 +33,6 @@ > #include <linux/sysrq.h> > > #include <drm/drm_drv.h> > -#include <drm/drm_irq.h> > > #include "display/intel_de.h" > #include "display/intel_display_types.h" > > base-commit: 8c1323b422f8473421682ba783b5949ddd89a3f4 > prerequisite-patch-id: c2b2f08f0eccc9f5df0c0da49fa1d36267deb11d > prerequisite-patch-id: c67e5d886a47b7d0266d81100837557fda34cb24 > -- > 2.32.0 -- Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Drop all references to DRM IRQ midlayer 2021-06-29 16:10 ` [Intel-gfx] [PATCH] " Ville Syrjälä @ 2021-06-29 16:39 ` Daniel Vetter 0 siblings, 0 replies; 5+ messages in thread From: Daniel Vetter @ 2021-06-29 16:39 UTC (permalink / raw) To: Ville Syrjälä Cc: Dave Airlie, intel-gfx, Wilson, Chris, dri-devel, Thomas Zimmermann, Lucas De Marchi On Tue, Jun 29, 2021 at 6:11 PM Ville Syrjälä <ville.syrjala@linux.intel.com> wrote: > > On Fri, Jun 25, 2021 at 10:47:40AM +0200, Thomas Zimmermann wrote: > > Remove all references to DRM's IRQ midlayer. > > > > The code in xcs_resume() probably didn't work as intended. It uses > > struct drm_device.irq, which is allocated to 0, but never initialized > > by i915 to the device's interrupt number. > > > > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> > > Fixes: 536f77b1caa0 ("drm/i915/gt: Call stop_ring() from ring resume, again") > > Cc: Chris Wilson <chris@chris-wilson.co.uk> > > Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com> > > Cc: Daniel Vetter <daniel.vetter@ffwll.ch> > > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> > > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> > > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> > > Cc: Lucas De Marchi <lucas.demarchi@intel.com> > > --- > > drivers/gpu/drm/i915/gt/intel_ring_submission.c | 3 ++- > > drivers/gpu/drm/i915/i915_drv.c | 1 - > > drivers/gpu/drm/i915/i915_irq.c | 1 - > > 3 files changed, 2 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/gt/intel_ring_submission.c b/drivers/gpu/drm/i915/gt/intel_ring_submission.c > > index 5d42a12ef3d6..d893aaaed74f 100644 > > --- a/drivers/gpu/drm/i915/gt/intel_ring_submission.c > > +++ b/drivers/gpu/drm/i915/gt/intel_ring_submission.c > > @@ -180,12 +180,13 @@ static bool stop_ring(struct intel_engine_cs *engine) > > static int xcs_resume(struct intel_engine_cs *engine) > > { > > struct intel_ring *ring = engine->legacy.ring; > > + struct pci_dev *pdev = to_pci_dev(engine->i915->drm.dev); > > > > ENGINE_TRACE(engine, "ring:{HEAD:%04x, TAIL:%04x}\n", > > ring->head, ring->tail); > > > > /* Double check the ring is empty & disabled before we resume */ > > - synchronize_hardirq(engine->i915->drm.irq); > > + synchronize_hardirq(pdev->irq); > > We have intel_synchronize_irq() to hide all these mundane details. > Might want to add a matching intel_synchronize_hardirq(). Hm I wonder whether we shouldn't just use the normal synchronize_irq() here. We don't have a threaded irq handler, and this should be called from process context. intel-gfx-ci will catch if I'm wrong :-) -Daniel > > > if (!stop_ring(engine)) > > goto err; > > > > diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c > > index 850b499c71c8..73de45472f60 100644 > > --- a/drivers/gpu/drm/i915/i915_drv.c > > +++ b/drivers/gpu/drm/i915/i915_drv.c > > @@ -42,7 +42,6 @@ > > #include <drm/drm_aperture.h> > > #include <drm/drm_atomic_helper.h> > > #include <drm/drm_ioctl.h> > > -#include <drm/drm_irq.h> > > #include <drm/drm_managed.h> > > #include <drm/drm_probe_helper.h> > > > > diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c > > index a11bdb667241..eef616d96f12 100644 > > --- a/drivers/gpu/drm/i915/i915_irq.c > > +++ b/drivers/gpu/drm/i915/i915_irq.c > > @@ -33,7 +33,6 @@ > > #include <linux/sysrq.h> > > > > #include <drm/drm_drv.h> > > -#include <drm/drm_irq.h> > > > > #include "display/intel_de.h" > > #include "display/intel_display_types.h" > > > > base-commit: 8c1323b422f8473421682ba783b5949ddd89a3f4 > > prerequisite-patch-id: c2b2f08f0eccc9f5df0c0da49fa1d36267deb11d > > prerequisite-patch-id: c67e5d886a47b7d0266d81100837557fda34cb24 > > -- > > 2.32.0 > > -- > Ville Syrjälä > Intel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-06-29 16:39 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2021-06-25 8:47 [Intel-gfx] [PATCH] drm/i915: Drop all references to DRM IRQ midlayer Thomas Zimmermann 2021-06-25 10:59 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork 2021-06-25 13:20 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork 2021-06-29 16:10 ` [Intel-gfx] [PATCH] " Ville Syrjälä 2021-06-29 16:39 ` Daniel Vetter
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox