Re: [Intel-gfx] [PATCH 09/11] drm/i915: Add a platform independent way to check for CCS control planes

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Wed, Oct 13, 2021 at 11:27:02PM +0300, Ville Syrjälä wrote:
> On Thu, Oct 07, 2021 at 11:35:15PM +0300, Imre Deak wrote:
> > Future platforms change the location of CCS control planes in CCS
> > framebuffers, so add intel_fb_is_rc_ccs_ctrl_plane() to query for these
> 
> Don't we use the term 'ccs_plane' everywhere else?
> 
> > planes independently of the platform. This function can be used
> > everywhere instead of is_ccs_plane() (or is_ccs_plane() && !cc_plane()),
> > since all the callers are only interested in control planes (and not CCS
> > color-clear planes).

Hmm. I guess you're changing the terminology across the board?
If it's used consistently then no objections from me.

> > 
> > Add the corresponding intel_fb_is_gen12_ccs_ctrl_plane(), which can be
> > used everywhere instead of is_gen12_ccs_plane(), based on the above
> > explanation.
> > 
> > This change also unexports the is_gen12_ccs_modifier(),
> > is_gen12_ccs_plane(), is_gen12_ccs_cc_plane() functions as they are only
> > used in intel_fb.c
> > 
> > Signed-off-by: Imre Deak <imre.deak@intel.com>
> > ---
> >  .../drm/i915/display/intel_display_types.h    |  7 --
> >  drivers/gpu/drm/i915/display/intel_fb.c       | 73 ++++++++++++++-----
> >  drivers/gpu/drm/i915/display/intel_fb.h       |  5 +-
> >  .../drm/i915/display/skl_universal_plane.c    |  3 +-
> >  4 files changed, 56 insertions(+), 32 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h
> > index bb53b01f07aee..b4b6a31caf4e3 100644
> > --- a/drivers/gpu/drm/i915/display/intel_display_types.h
> > +++ b/drivers/gpu/drm/i915/display/intel_display_types.h
> > @@ -2050,11 +2050,4 @@ static inline bool is_ccs_modifier(u64 modifier)
> >  	       modifier == I915_FORMAT_MOD_Yf_TILED_CCS;
> >  }
> >  
> > -static inline bool is_gen12_ccs_modifier(u64 modifier)
> > -{
> > -	return modifier == I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS ||
> > -	       modifier == I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC ||
> > -	       modifier == I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS;
> > -}
> > -
> >  #endif /*  __INTEL_DISPLAY_TYPES_H__ */
> > diff --git a/drivers/gpu/drm/i915/display/intel_fb.c b/drivers/gpu/drm/i915/display/intel_fb.c
> > index e8fe198b1b6a1..392f89e659eb6 100644
> > --- a/drivers/gpu/drm/i915/display/intel_fb.c
> > +++ b/drivers/gpu/drm/i915/display/intel_fb.c
> > @@ -125,6 +125,8 @@ const struct intel_modifier_desc {
> >  #define INTEL_CCS_ANY		(INTEL_CCS_RC | INTEL_CCS_RC_CC | INTEL_CCS_MC)
> >  		u8 type:3;
> >  		u8 cc_planes:3;
> > +		u8 packed_ctrl_planes:4;
> > +		u8 planar_ctrl_planes:4;
> >  	} ccs;
> >  } intel_modifiers[] = {
> >  	{
> > @@ -151,6 +153,7 @@ const struct intel_modifier_desc {
> >  		.tiling = I915_TILING_Y,
> >  
> >  		.ccs.type = INTEL_CCS_RC,
> > +		.ccs.packed_ctrl_planes = BIT(1),
> >  
> >  		FORMAT_OVERRIDE(skl_ccs_formats),
> >  	},
> > @@ -159,6 +162,7 @@ const struct intel_modifier_desc {
> >  		.display_versions = DISPLAY_VER_MASK(9, 11),
> >  
> >  		.ccs.type = INTEL_CCS_RC,
> > +		.ccs.packed_ctrl_planes = BIT(1),
> >  
> >  		FORMAT_OVERRIDE(skl_ccs_formats),
> >  	},
> > @@ -168,6 +172,7 @@ const struct intel_modifier_desc {
> >  		.tiling = I915_TILING_Y,
> >  
> >  		.ccs.type = INTEL_CCS_RC,
> > +		.ccs.packed_ctrl_planes = BIT(1),
> >  
> >  		FORMAT_OVERRIDE(gen12_ccs_formats),
> >  	},
> > @@ -177,6 +182,7 @@ const struct intel_modifier_desc {
> >  		.tiling = I915_TILING_Y,
> >  
> >  		.ccs.type = INTEL_CCS_RC_CC,
> > +		.ccs.packed_ctrl_planes = BIT(1),
> >  		.ccs.cc_planes = BIT(2),
> >  
> >  		FORMAT_OVERRIDE(gen12_ccs_cc_formats),
> > @@ -187,6 +193,8 @@ const struct intel_modifier_desc {
> >  		.tiling = I915_TILING_Y,
> >  
> >  		.ccs.type = INTEL_CCS_MC,
> > +		.ccs.packed_ctrl_planes = BIT(1),
> > +		.ccs.planar_ctrl_planes = BIT(2) | BIT(3),
> >  
> >  		FORMAT_OVERRIDE(gen12_ccs_formats),
> >  	},
> > @@ -385,17 +393,44 @@ bool intel_format_info_is_yuv_semiplanar(const struct drm_format_info *info,
> >  	return format_is_yuv_semiplanar(lookup_modifier(modifier), info);
> >  }
> >  
> > -bool is_ccs_plane(const struct drm_framebuffer *fb, int plane)
> > +static u8 ccs_ctrl_plane_mask(const struct intel_modifier_desc *md,
> > +			      const struct drm_format_info *format)
> >  {
> > -	if (!is_ccs_modifier(fb->modifier))
> > -		return false;
> > +	if (format_is_yuv_semiplanar(md, format))
> > +		return md->ccs.planar_ctrl_planes;
> > +	else
> > +		return md->ccs.packed_ctrl_planes;
> > +}
> > +
> > +/**
> > + * intel_fb_is_ccs_ctrl_plane: Check if a framebuffer color plane is a CCS control plane
> > + * @fb: Framebuffer
> > + * @plane: color plane index to check
> > + *
> > + * Returns:
> > + * Returns %true if @fb's color plane at index @plane is a CCS control plane.
> > + */
> > +bool intel_fb_is_ccs_ctrl_plane(const struct drm_framebuffer *fb, int plane)
> > +{
> > +	const struct intel_modifier_desc *md = lookup_modifier(fb->modifier);
> >  
> > -	return plane >= fb->format->num_planes / 2;
> > +	return ccs_ctrl_plane_mask(md, fb->format) & BIT(plane);
> >  }
> >  
> > -bool is_gen12_ccs_plane(const struct drm_framebuffer *fb, int plane)
> > +/**
> > + * intel_fb_is_gen12_ccs_ctrl_plane: Check if a framebuffer color plane is a GEN12 CCS control plane
> > + * @fb: Framebuffer
> > + * @plane: color plane index to check
> > + *
> > + * Returns:
> > + * Returns %true if @fb's color plane at index @plane is a GEN12 CCS control plane.
> > + */
> > +static bool intel_fb_is_gen12_ccs_ctrl_plane(const struct drm_framebuffer *fb, int plane)
> >  {
> > -	return is_gen12_ccs_modifier(fb->modifier) && is_ccs_plane(fb, plane);
> > +	const struct intel_modifier_desc *md = lookup_modifier(fb->modifier);
> > +
> > +	return md->display_versions & (DISPLAY_VER_MASK(12, 13)) &&

Aha! No RPN here ;)

-- 
Ville Syrjälä
Intel