* [Intel-gfx] [PATCH v2] drm/i915: fix header file inclusion for might_alloc()
@ 2022-01-24 9:03 Andi Shyti
0 siblings, 0 replies; 3+ messages in thread
From: Andi Shyti @ 2022-01-24 9:03 UTC (permalink / raw)
To: Intel GFX, DRI Devel; +Cc: Thomas Hellström
Replace "linux/slab.h" with "linux/sched/mm.h" header inclusion
as the first is not required, while the second, if not included,
prdouces the following error:
drivers/gpu/drm/i915/i915_vma_resource.c: In function ‘i915_vma_resource_bind_dep_await’:
drivers/gpu/drm/i915/i915_vma_resource.c:381:9: error: implicit declaration of function ‘might_alloc’; did you mean ‘might_lock’? [-Werror=implicit-function-declaration]
381 | might_alloc(gfp);
| ^~~~~~~~~~~
| might_lock
Fixes: 2f6b90da9192 ("drm/i915: Use vma resources for async unbinding")
Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com>
Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Reviewed-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
---
Hi,
in V2 I just added the Fixes tag (I think I got the right commit)
and added Thomas r-b.
Andi
drivers/gpu/drm/i915/i915_vma_resource.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_vma_resource.c b/drivers/gpu/drm/i915/i915_vma_resource.c
index 1f41c0c699eb..bbb0ff14272f 100644
--- a/drivers/gpu/drm/i915/i915_vma_resource.c
+++ b/drivers/gpu/drm/i915/i915_vma_resource.c
@@ -4,7 +4,7 @@
*/
#include <linux/interval_tree_generic.h>
-#include <linux/slab.h>
+#include <linux/sched/mm.h>
#include "i915_sw_fence.h"
#include "i915_vma_resource.h"
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Intel-gfx] [PATCH v2] drm/i915: fix header file inclusion for might_alloc()
@ 2022-01-24 9:42 Andi Shyti
2022-01-24 9:45 ` Andi Shyti
0 siblings, 1 reply; 3+ messages in thread
From: Andi Shyti @ 2022-01-24 9:42 UTC (permalink / raw)
To: Intel GFX, DRI Devel; +Cc: Thomas Hellström, Thomas Zimmermann
Replace "linux/slab.h" with "linux/sched/mm.h" header inclusion
as the first is not required, while the second, if not included,
prdouces the following error:
drivers/gpu/drm/i915/i915_vma_resource.c: In function ‘i915_vma_resource_bind_dep_await’:
drivers/gpu/drm/i915/i915_vma_resource.c:381:9: error: implicit declaration of function ‘might_alloc’; did you mean ‘might_lock’? [-Werror=implicit-function-declaration]
381 | might_alloc(gfp);
| ^~~~~~~~~~~
| might_lock
Fixes: 2f6b90da9192 ("drm/i915: Use vma resources for async unbinding")
Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com>
Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Reviewed-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
---
Hi,
in V2 I just added the Fixes tag (I think I got the right commit)
and added Thomas r-b.
Andi
drivers/gpu/drm/i915/i915_vma_resource.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_vma_resource.c b/drivers/gpu/drm/i915/i915_vma_resource.c
index 1f41c0c699eb..bbb0ff14272f 100644
--- a/drivers/gpu/drm/i915/i915_vma_resource.c
+++ b/drivers/gpu/drm/i915/i915_vma_resource.c
@@ -4,7 +4,7 @@
*/
#include <linux/interval_tree_generic.h>
-#include <linux/slab.h>
+#include <linux/sched/mm.h>
#include "i915_sw_fence.h"
#include "i915_vma_resource.h"
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Intel-gfx] [PATCH v2] drm/i915: fix header file inclusion for might_alloc()
2022-01-24 9:42 [Intel-gfx] [PATCH v2] drm/i915: fix header file inclusion for might_alloc() Andi Shyti
@ 2022-01-24 9:45 ` Andi Shyti
0 siblings, 0 replies; 3+ messages in thread
From: Andi Shyti @ 2022-01-24 9:45 UTC (permalink / raw)
To: Andi Shyti; +Cc: Thomas Hellström, Intel GFX, Thomas Zimmermann, DRI Devel
Sorry for spamming! Just called the command from the history
On Mon, Jan 24, 2022 at 11:42:43AM +0200, Andi Shyti wrote:
> Replace "linux/slab.h" with "linux/sched/mm.h" header inclusion
> as the first is not required, while the second, if not included,
> prdouces the following error:
>
> drivers/gpu/drm/i915/i915_vma_resource.c: In function ‘i915_vma_resource_bind_dep_await’:
> drivers/gpu/drm/i915/i915_vma_resource.c:381:9: error: implicit declaration of function ‘might_alloc’; did you mean ‘might_lock’? [-Werror=implicit-function-declaration]
> 381 | might_alloc(gfp);
> | ^~~~~~~~~~~
> | might_lock
>
> Fixes: 2f6b90da9192 ("drm/i915: Use vma resources for async unbinding")
> Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com>
> Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
> Reviewed-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
> ---
> Hi,
>
> in V2 I just added the Fixes tag (I think I got the right commit)
> and added Thomas r-b.
>
> Andi
>
> drivers/gpu/drm/i915/i915_vma_resource.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_vma_resource.c b/drivers/gpu/drm/i915/i915_vma_resource.c
> index 1f41c0c699eb..bbb0ff14272f 100644
> --- a/drivers/gpu/drm/i915/i915_vma_resource.c
> +++ b/drivers/gpu/drm/i915/i915_vma_resource.c
> @@ -4,7 +4,7 @@
> */
>
> #include <linux/interval_tree_generic.h>
> -#include <linux/slab.h>
> +#include <linux/sched/mm.h>
>
> #include "i915_sw_fence.h"
> #include "i915_vma_resource.h"
> --
> 2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-24 9:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-01-24 9:42 [Intel-gfx] [PATCH v2] drm/i915: fix header file inclusion for might_alloc() Andi Shyti
2022-01-24 9:45 ` Andi Shyti
-- strict thread matches above, loose matches on Subject: below --
2022-01-24 9:03 Andi Shyti
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox