* [Intel-gfx] [PATCH 0/7] drm/i915: split out function structs from i915_drv.h
@ 2022-02-03 14:02 Jani Nikula
2022-02-03 14:02 ` [Intel-gfx] [PATCH 1/7] drm/i915: group i915_drv.h forward declarations together Jani Nikula
` (9 more replies)
0 siblings, 10 replies; 15+ messages in thread
From: Jani Nikula @ 2022-02-03 14:02 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
Most of the structs can be hidden away.
Jani Nikula (7):
drm/i915: group i915_drv.h forward declarations together
drm/i915/color: hide struct intel_color_funcs
drm/i915/hpd: hide struct intel_hotplug_funcs
drm/i915/fdi: hide struct intel_fdi_funcs
drm/i915/dpll: add intel_dpll_crtc_compute_clock()
drm/i915/dpll: hide struct intel_dpll_funcs
drm/i915/pm: hide struct drm_i915_clock_gating_funcs
drivers/gpu/drm/i915/display/intel_color.c | 19 +++++
drivers/gpu/drm/i915/display/intel_display.c | 2 +-
drivers/gpu/drm/i915/display/intel_dpll.c | 12 +++
drivers/gpu/drm/i915/display/intel_dpll.h | 1 +
drivers/gpu/drm/i915/display/intel_fdi.c | 5 ++
drivers/gpu/drm/i915/display/intel_hotplug.c | 7 +-
drivers/gpu/drm/i915/i915_drv.h | 86 ++++++--------------
drivers/gpu/drm/i915/i915_irq.c | 10 +++
drivers/gpu/drm/i915/i915_irq.h | 1 +
drivers/gpu/drm/i915/intel_pm.c | 4 +
10 files changed, 78 insertions(+), 69 deletions(-)
--
2.30.2
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Intel-gfx] [PATCH 1/7] drm/i915: group i915_drv.h forward declarations together
2022-02-03 14:02 [Intel-gfx] [PATCH 0/7] drm/i915: split out function structs from i915_drv.h Jani Nikula
@ 2022-02-03 14:02 ` Jani Nikula
2022-02-09 10:42 ` Ville Syrjälä
2022-02-03 14:02 ` [Intel-gfx] [PATCH 2/7] drm/i915/color: hide struct intel_color_funcs Jani Nikula
` (8 subsequent siblings)
9 siblings, 1 reply; 15+ messages in thread
From: Jani Nikula @ 2022-02-03 14:02 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
Group the forward declarations in i915_drv.h together near the top, like
in other header files, and sort.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/i915_drv.h | 44 ++++++++++++++-------------------
1 file changed, 19 insertions(+), 25 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index 8c1706fd81f9..5a1615c02971 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -106,6 +106,25 @@
#include "gt/intel_timeline.h"
#include "i915_vma.h"
+struct dpll;
+struct drm_i915_gem_object;
+struct drm_i915_private;
+struct intel_atomic_state;
+struct intel_audio_funcs;
+struct intel_cdclk_config;
+struct intel_cdclk_funcs;
+struct intel_cdclk_state;
+struct intel_cdclk_vals;
+struct intel_connector;
+struct intel_crtc;
+struct intel_dp;
+struct intel_encoder;
+struct intel_fbdev;
+struct intel_initial_plane_config;
+struct intel_limit;
+struct intel_overlay;
+struct intel_overlay_error_state;
+struct vlv_s0ix_state;
/* General customization:
*/
@@ -115,8 +134,6 @@
#define DRIVER_DATE "20201103"
#define DRIVER_TIMESTAMP 1604406085
-struct drm_i915_gem_object;
-
/* Threshold == 5 for long IRQs, 50 for short */
#define HPD_STORM_DEFAULT_THRESHOLD 50
@@ -166,8 +183,6 @@ struct i915_hotplug {
I915_GEM_DOMAIN_INSTRUCTION | \
I915_GEM_DOMAIN_VERTEX)
-struct drm_i915_private;
-
struct drm_i915_file_private {
struct drm_i915_private *dev_priv;
@@ -274,9 +289,6 @@ struct drm_i915_file_private {
#define DRIVER_MINOR 6
#define DRIVER_PATCHLEVEL 0
-struct intel_overlay;
-struct intel_overlay_error_state;
-
struct sdvo_device_mapping {
u8 initialized;
u8 dvo_port;
@@ -286,18 +298,6 @@ struct sdvo_device_mapping {
u8 ddc_pin;
};
-struct intel_connector;
-struct intel_encoder;
-struct intel_atomic_state;
-struct intel_cdclk_config;
-struct intel_cdclk_funcs;
-struct intel_cdclk_state;
-struct intel_cdclk_vals;
-struct intel_initial_plane_config;
-struct intel_crtc;
-struct intel_limit;
-struct dpll;
-
/* functions used internal in intel_pm.c */
struct drm_i915_clock_gating_funcs {
void (*init_clock_gating)(struct drm_i915_private *dev_priv);
@@ -385,7 +385,6 @@ enum drrs_support_type {
SEAMLESS_DRRS_SUPPORT = 2
};
-struct intel_dp;
struct i915_drrs {
struct mutex mutex;
struct delayed_work work;
@@ -403,8 +402,6 @@ struct i915_drrs {
#define QUIRK_INCREASE_DDI_DISABLED_TIME (1<<7)
#define QUIRK_NO_PPS_BACKLIGHT_POWER_HOOK (1<<8)
-struct intel_fbdev;
-
struct intel_gmbus {
struct i2c_adapter adapter;
#define GMBUS_FORCE_BIT_RETRY (1U << 31)
@@ -423,8 +420,6 @@ struct i915_suspend_saved_registers {
u16 saveGCDGMBUS;
};
-struct vlv_s0ix_state;
-
#define MAX_L3_SLICES 2
struct intel_l3_parity {
u32 *remap_info[MAX_L3_SLICES];
@@ -613,7 +608,6 @@ struct i915_selftest_stash {
};
/* intel_audio.c private */
-struct intel_audio_funcs;
struct intel_audio_private {
/* Display internal audio functions */
const struct intel_audio_funcs *funcs;
--
2.30.2
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [Intel-gfx] [PATCH 2/7] drm/i915/color: hide struct intel_color_funcs
2022-02-03 14:02 [Intel-gfx] [PATCH 0/7] drm/i915: split out function structs from i915_drv.h Jani Nikula
2022-02-03 14:02 ` [Intel-gfx] [PATCH 1/7] drm/i915: group i915_drv.h forward declarations together Jani Nikula
@ 2022-02-03 14:02 ` Jani Nikula
2022-02-09 10:43 ` Ville Syrjälä
2022-02-03 14:02 ` [Intel-gfx] [PATCH 3/7] drm/i915/hpd: hide struct intel_hotplug_funcs Jani Nikula
` (7 subsequent siblings)
9 siblings, 1 reply; 15+ messages in thread
From: Jani Nikula @ 2022-02-03 14:02 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
The struct is only needed in intel_color.c, move it there.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/display/intel_color.c | 19 +++++++++++++++++++
drivers/gpu/drm/i915/i915_drv.h | 20 +-------------------
2 files changed, 20 insertions(+), 19 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_color.c b/drivers/gpu/drm/i915/display/intel_color.c
index de3ded1e327a..8f8b34b60f27 100644
--- a/drivers/gpu/drm/i915/display/intel_color.c
+++ b/drivers/gpu/drm/i915/display/intel_color.c
@@ -28,6 +28,25 @@
#include "intel_dpll.h"
#include "vlv_dsi_pll.h"
+struct intel_color_funcs {
+ int (*color_check)(struct intel_crtc_state *crtc_state);
+ /*
+ * Program double buffered color management registers during
+ * vblank evasion. The registers should then latch during the
+ * next vblank start, alongside any other double buffered registers
+ * involved with the same commit.
+ */
+ void (*color_commit)(const struct intel_crtc_state *crtc_state);
+ /*
+ * Load LUTs (and other single buffered color management
+ * registers). Will (hopefully) be called during the vblank
+ * following the latching of any double buffered registers
+ * involved with the same commit.
+ */
+ void (*load_luts)(const struct intel_crtc_state *crtc_state);
+ void (*read_luts)(struct intel_crtc_state *crtc_state);
+};
+
#define CTM_COEFF_SIGN (1ULL << 63)
#define CTM_COEFF_1_0 (1ULL << 32)
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index 5a1615c02971..cac18b57808e 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -115,6 +115,7 @@ struct intel_cdclk_config;
struct intel_cdclk_funcs;
struct intel_cdclk_state;
struct intel_cdclk_vals;
+struct intel_color_funcs;
struct intel_connector;
struct intel_crtc;
struct intel_dp;
@@ -320,25 +321,6 @@ struct drm_i915_wm_disp_funcs {
int (*compute_global_watermarks)(struct intel_atomic_state *state);
};
-struct intel_color_funcs {
- int (*color_check)(struct intel_crtc_state *crtc_state);
- /*
- * Program double buffered color management registers during
- * vblank evasion. The registers should then latch during the
- * next vblank start, alongside any other double buffered registers
- * involved with the same commit.
- */
- void (*color_commit)(const struct intel_crtc_state *crtc_state);
- /*
- * Load LUTs (and other single buffered color management
- * registers). Will (hopefully) be called during the vblank
- * following the latching of any double buffered registers
- * involved with the same commit.
- */
- void (*load_luts)(const struct intel_crtc_state *crtc_state);
- void (*read_luts)(struct intel_crtc_state *crtc_state);
-};
-
struct intel_hotplug_funcs {
void (*hpd_irq_setup)(struct drm_i915_private *dev_priv);
};
--
2.30.2
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [Intel-gfx] [PATCH 3/7] drm/i915/hpd: hide struct intel_hotplug_funcs
2022-02-03 14:02 [Intel-gfx] [PATCH 0/7] drm/i915: split out function structs from i915_drv.h Jani Nikula
2022-02-03 14:02 ` [Intel-gfx] [PATCH 1/7] drm/i915: group i915_drv.h forward declarations together Jani Nikula
2022-02-03 14:02 ` [Intel-gfx] [PATCH 2/7] drm/i915/color: hide struct intel_color_funcs Jani Nikula
@ 2022-02-03 14:02 ` Jani Nikula
2022-02-03 14:02 ` [Intel-gfx] [PATCH 4/7] drm/i915/fdi: hide struct intel_fdi_funcs Jani Nikula
` (6 subsequent siblings)
9 siblings, 0 replies; 15+ messages in thread
From: Jani Nikula @ 2022-02-03 14:02 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
With intel_hpd_irq_setup() in i915_irq.c, struct intel_hotplug_funcs is
also only needed there.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/display/intel_hotplug.c | 7 +------
drivers/gpu/drm/i915/i915_drv.h | 5 +----
drivers/gpu/drm/i915/i915_irq.c | 10 ++++++++++
drivers/gpu/drm/i915/i915_irq.h | 1 +
4 files changed, 13 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_hotplug.c b/drivers/gpu/drm/i915/display/intel_hotplug.c
index 912b7003dcfa..8204126d17f9 100644
--- a/drivers/gpu/drm/i915/display/intel_hotplug.c
+++ b/drivers/gpu/drm/i915/display/intel_hotplug.c
@@ -24,6 +24,7 @@
#include <linux/kernel.h>
#include "i915_drv.h"
+#include "i915_irq.h"
#include "intel_display_types.h"
#include "intel_hotplug.h"
@@ -213,12 +214,6 @@ intel_hpd_irq_storm_switch_to_polling(struct drm_i915_private *dev_priv)
}
}
-static void intel_hpd_irq_setup(struct drm_i915_private *i915)
-{
- if (i915->display_irqs_enabled && i915->hotplug_funcs)
- i915->hotplug_funcs->hpd_irq_setup(i915);
-}
-
static void intel_hpd_irq_storm_reenable_work(struct work_struct *work)
{
struct drm_i915_private *dev_priv =
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index cac18b57808e..e13e0188530e 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -121,6 +121,7 @@ struct intel_crtc;
struct intel_dp;
struct intel_encoder;
struct intel_fbdev;
+struct intel_hotplug_funcs;
struct intel_initial_plane_config;
struct intel_limit;
struct intel_overlay;
@@ -321,10 +322,6 @@ struct drm_i915_wm_disp_funcs {
int (*compute_global_watermarks)(struct intel_atomic_state *state);
};
-struct intel_hotplug_funcs {
- void (*hpd_irq_setup)(struct drm_i915_private *dev_priv);
-};
-
struct intel_fdi_funcs {
void (*fdi_link_train)(struct intel_crtc *crtc,
const struct intel_crtc_state *crtc_state);
diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
index c05eb09d8a66..4e97d22ff081 100644
--- a/drivers/gpu/drm/i915/i915_irq.c
+++ b/drivers/gpu/drm/i915/i915_irq.c
@@ -4347,6 +4347,10 @@ static irqreturn_t i965_irq_handler(int irq, void *arg)
return ret;
}
+struct intel_hotplug_funcs {
+ void (*hpd_irq_setup)(struct drm_i915_private *i915);
+};
+
#define HPD_FUNCS(platform) \
static const struct intel_hotplug_funcs platform##_hpd_funcs = { \
.hpd_irq_setup = platform##_hpd_irq_setup, \
@@ -4361,6 +4365,12 @@ HPD_FUNCS(spt);
HPD_FUNCS(ilk);
#undef HPD_FUNCS
+void intel_hpd_irq_setup(struct drm_i915_private *i915)
+{
+ if (i915->display_irqs_enabled && i915->hotplug_funcs)
+ i915->hotplug_funcs->hpd_irq_setup(i915);
+}
+
/**
* intel_irq_init - initializes irq support
* @dev_priv: i915 device instance
diff --git a/drivers/gpu/drm/i915/i915_irq.h b/drivers/gpu/drm/i915/i915_irq.h
index 0eb90d271fa7..82639d9d7e82 100644
--- a/drivers/gpu/drm/i915/i915_irq.h
+++ b/drivers/gpu/drm/i915/i915_irq.h
@@ -37,6 +37,7 @@ i915_disable_pipestat(struct drm_i915_private *dev_priv, enum pipe pipe,
void valleyview_enable_display_irqs(struct drm_i915_private *dev_priv);
void valleyview_disable_display_irqs(struct drm_i915_private *dev_priv);
+void intel_hpd_irq_setup(struct drm_i915_private *i915);
void i915_hotplug_interrupt_update(struct drm_i915_private *dev_priv,
u32 mask,
u32 bits);
--
2.30.2
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [Intel-gfx] [PATCH 4/7] drm/i915/fdi: hide struct intel_fdi_funcs
2022-02-03 14:02 [Intel-gfx] [PATCH 0/7] drm/i915: split out function structs from i915_drv.h Jani Nikula
` (2 preceding siblings ...)
2022-02-03 14:02 ` [Intel-gfx] [PATCH 3/7] drm/i915/hpd: hide struct intel_hotplug_funcs Jani Nikula
@ 2022-02-03 14:02 ` Jani Nikula
2022-02-03 14:02 ` [Intel-gfx] [PATCH 5/7] drm/i915/dpll: add intel_dpll_crtc_compute_clock() Jani Nikula
` (5 subsequent siblings)
9 siblings, 0 replies; 15+ messages in thread
From: Jani Nikula @ 2022-02-03 14:02 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
The struct is only needed in intel_fdi.c, move it there.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/display/intel_fdi.c | 5 +++++
drivers/gpu/drm/i915/i915_drv.h | 6 +-----
2 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_fdi.c b/drivers/gpu/drm/i915/display/intel_fdi.c
index 3d6e22923601..4e4b43669b14 100644
--- a/drivers/gpu/drm/i915/display/intel_fdi.c
+++ b/drivers/gpu/drm/i915/display/intel_fdi.c
@@ -10,6 +10,11 @@
#include "intel_display_types.h"
#include "intel_fdi.h"
+struct intel_fdi_funcs {
+ void (*fdi_link_train)(struct intel_crtc *crtc,
+ const struct intel_crtc_state *crtc_state);
+};
+
static void assert_fdi_tx(struct drm_i915_private *dev_priv,
enum pipe pipe, bool state)
{
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index e13e0188530e..784233ad9f16 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -121,6 +121,7 @@ struct intel_crtc;
struct intel_dp;
struct intel_encoder;
struct intel_fbdev;
+struct intel_fdi_funcs;
struct intel_hotplug_funcs;
struct intel_initial_plane_config;
struct intel_limit;
@@ -322,11 +323,6 @@ struct drm_i915_wm_disp_funcs {
int (*compute_global_watermarks)(struct intel_atomic_state *state);
};
-struct intel_fdi_funcs {
- void (*fdi_link_train)(struct intel_crtc *crtc,
- const struct intel_crtc_state *crtc_state);
-};
-
struct intel_dpll_funcs {
int (*crtc_compute_clock)(struct intel_crtc_state *crtc_state);
};
--
2.30.2
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [Intel-gfx] [PATCH 5/7] drm/i915/dpll: add intel_dpll_crtc_compute_clock()
2022-02-03 14:02 [Intel-gfx] [PATCH 0/7] drm/i915: split out function structs from i915_drv.h Jani Nikula
` (3 preceding siblings ...)
2022-02-03 14:02 ` [Intel-gfx] [PATCH 4/7] drm/i915/fdi: hide struct intel_fdi_funcs Jani Nikula
@ 2022-02-03 14:02 ` Jani Nikula
2022-02-03 14:02 ` [Intel-gfx] [PATCH 6/7] drm/i915/dpll: hide struct intel_dpll_funcs Jani Nikula
` (4 subsequent siblings)
9 siblings, 0 replies; 15+ messages in thread
From: Jani Nikula @ 2022-02-03 14:02 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
Avoid referencing the function pointer directly to be able to abstract
the call better.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/display/intel_display.c | 2 +-
drivers/gpu/drm/i915/display/intel_dpll.c | 8 ++++++++
drivers/gpu/drm/i915/display/intel_dpll.h | 1 +
3 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index df347329d90e..04909088cae6 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -5266,7 +5266,7 @@ static int intel_crtc_atomic_check(struct intel_atomic_state *state,
if (mode_changed && crtc_state->hw.enable &&
!drm_WARN_ON(&dev_priv->drm, crtc_state->shared_dpll)) {
- ret = dev_priv->dpll_funcs->crtc_compute_clock(crtc_state);
+ ret = intel_dpll_crtc_compute_clock(crtc_state);
if (ret)
return ret;
}
diff --git a/drivers/gpu/drm/i915/display/intel_dpll.c b/drivers/gpu/drm/i915/display/intel_dpll.c
index 1ce0c171f4fb..809b2004e5b2 100644
--- a/drivers/gpu/drm/i915/display/intel_dpll.c
+++ b/drivers/gpu/drm/i915/display/intel_dpll.c
@@ -1400,6 +1400,14 @@ static const struct intel_dpll_funcs i8xx_dpll_funcs = {
.crtc_compute_clock = i8xx_crtc_compute_clock,
};
+int intel_dpll_crtc_compute_clock(struct intel_crtc_state *crtc_state)
+{
+ struct intel_crtc *crtc = to_intel_crtc(crtc_state->uapi.crtc);
+ struct drm_i915_private *i915 = to_i915(crtc->base.dev);
+
+ return i915->dpll_funcs->crtc_compute_clock(crtc_state);
+}
+
void
intel_dpll_init_clock_hook(struct drm_i915_private *dev_priv)
{
diff --git a/drivers/gpu/drm/i915/display/intel_dpll.h b/drivers/gpu/drm/i915/display/intel_dpll.h
index 1af0ac43cca4..69b06a9e473e 100644
--- a/drivers/gpu/drm/i915/display/intel_dpll.h
+++ b/drivers/gpu/drm/i915/display/intel_dpll.h
@@ -15,6 +15,7 @@ struct intel_crtc_state;
enum pipe;
void intel_dpll_init_clock_hook(struct drm_i915_private *dev_priv);
+int intel_dpll_crtc_compute_clock(struct intel_crtc_state *crtc_state);
int vlv_calc_dpll_params(int refclk, struct dpll *clock);
int pnv_calc_dpll_params(int refclk, struct dpll *clock);
int i9xx_calc_dpll_params(int refclk, struct dpll *clock);
--
2.30.2
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [Intel-gfx] [PATCH 6/7] drm/i915/dpll: hide struct intel_dpll_funcs
2022-02-03 14:02 [Intel-gfx] [PATCH 0/7] drm/i915: split out function structs from i915_drv.h Jani Nikula
` (4 preceding siblings ...)
2022-02-03 14:02 ` [Intel-gfx] [PATCH 5/7] drm/i915/dpll: add intel_dpll_crtc_compute_clock() Jani Nikula
@ 2022-02-03 14:02 ` Jani Nikula
2022-02-03 14:02 ` [Intel-gfx] [PATCH 7/7] drm/i915/pm: hide struct drm_i915_clock_gating_funcs Jani Nikula
` (3 subsequent siblings)
9 siblings, 0 replies; 15+ messages in thread
From: Jani Nikula @ 2022-02-03 14:02 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
The struct is only needed in intel_dpll.c, move it there.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/display/intel_dpll.c | 4 ++++
drivers/gpu/drm/i915/i915_drv.h | 5 +----
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dpll.c b/drivers/gpu/drm/i915/display/intel_dpll.c
index 809b2004e5b2..14f5ffe27d05 100644
--- a/drivers/gpu/drm/i915/display/intel_dpll.c
+++ b/drivers/gpu/drm/i915/display/intel_dpll.c
@@ -16,6 +16,10 @@
#include "intel_snps_phy.h"
#include "vlv_sideband.h"
+struct intel_dpll_funcs {
+ int (*crtc_compute_clock)(struct intel_crtc_state *crtc_state);
+};
+
struct intel_limit {
struct {
int min, max;
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index 784233ad9f16..078fc50e7eb9 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -119,6 +119,7 @@ struct intel_color_funcs;
struct intel_connector;
struct intel_crtc;
struct intel_dp;
+struct intel_dpll_funcs;
struct intel_encoder;
struct intel_fbdev;
struct intel_fdi_funcs;
@@ -323,10 +324,6 @@ struct drm_i915_wm_disp_funcs {
int (*compute_global_watermarks)(struct intel_atomic_state *state);
};
-struct intel_dpll_funcs {
- int (*crtc_compute_clock)(struct intel_crtc_state *crtc_state);
-};
-
struct drm_i915_display_funcs {
/* Returns the active state of the crtc, and if the crtc is active,
* fills out the pipe-config with the hw state. */
--
2.30.2
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [Intel-gfx] [PATCH 7/7] drm/i915/pm: hide struct drm_i915_clock_gating_funcs
2022-02-03 14:02 [Intel-gfx] [PATCH 0/7] drm/i915: split out function structs from i915_drv.h Jani Nikula
` (5 preceding siblings ...)
2022-02-03 14:02 ` [Intel-gfx] [PATCH 6/7] drm/i915/dpll: hide struct intel_dpll_funcs Jani Nikula
@ 2022-02-03 14:02 ` Jani Nikula
2022-02-09 10:45 ` Ville Syrjälä
2022-02-03 14:56 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: split out function structs from i915_drv.h Patchwork
` (2 subsequent siblings)
9 siblings, 1 reply; 15+ messages in thread
From: Jani Nikula @ 2022-02-03 14:02 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
The struct is only needed in intel_pm.c, move it there.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/i915_drv.h | 6 +-----
drivers/gpu/drm/i915/intel_pm.c | 4 ++++
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index 078fc50e7eb9..4ac0fcb9a4ca 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -107,6 +107,7 @@
#include "i915_vma.h"
struct dpll;
+struct drm_i915_clock_gating_funcs;
struct drm_i915_gem_object;
struct drm_i915_private;
struct intel_atomic_state;
@@ -302,11 +303,6 @@ struct sdvo_device_mapping {
u8 ddc_pin;
};
-/* functions used internal in intel_pm.c */
-struct drm_i915_clock_gating_funcs {
- void (*init_clock_gating)(struct drm_i915_private *dev_priv);
-};
-
/* functions used for watermark calcs for display. */
struct drm_i915_wm_disp_funcs {
/* update_wm is for legacy wm management */
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 859be750fb22..2e84d45f9bf0 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -55,6 +55,10 @@
#include "vlv_sideband.h"
#include "../../../platform/x86/intel_ips.h"
+struct drm_i915_clock_gating_funcs {
+ void (*init_clock_gating)(struct drm_i915_private *i915);
+};
+
/* Stores plane specific WM parameters */
struct skl_wm_params {
bool x_tiled, y_tiled;
--
2.30.2
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: split out function structs from i915_drv.h
2022-02-03 14:02 [Intel-gfx] [PATCH 0/7] drm/i915: split out function structs from i915_drv.h Jani Nikula
` (6 preceding siblings ...)
2022-02-03 14:02 ` [Intel-gfx] [PATCH 7/7] drm/i915/pm: hide struct drm_i915_clock_gating_funcs Jani Nikula
@ 2022-02-03 14:56 ` Patchwork
2022-02-03 15:26 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-02-03 18:28 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
9 siblings, 0 replies; 15+ messages in thread
From: Patchwork @ 2022-02-03 14:56 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: split out function structs from i915_drv.h
URL : https://patchwork.freedesktop.org/series/99669/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: split out function structs from i915_drv.h
2022-02-03 14:02 [Intel-gfx] [PATCH 0/7] drm/i915: split out function structs from i915_drv.h Jani Nikula
` (7 preceding siblings ...)
2022-02-03 14:56 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: split out function structs from i915_drv.h Patchwork
@ 2022-02-03 15:26 ` Patchwork
2022-02-03 18:28 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
9 siblings, 0 replies; 15+ messages in thread
From: Patchwork @ 2022-02-03 15:26 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 14221 bytes --]
== Series Details ==
Series: drm/i915: split out function structs from i915_drv.h
URL : https://patchwork.freedesktop.org/series/99669/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11184 -> Patchwork_22168
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/index.html
Participating hosts (42 -> 43)
------------------------------
Additional (10): bat-dg1-6 bat-dg1-5 fi-adl-ddr4 fi-apl-guc bat-adlp-6 fi-pnv-d510 bat-rpls-1 bat-rpls-2 bat-jsl-2 bat-jsl-1
Missing (9): fi-rkl-11600 shard-tglu fi-hsw-4200u fi-icl-u2 fi-bsw-cyan fi-ctg-p8600 fi-kbl-8809g shard-rkl fi-bdw-samus
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_22168:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@gem_exec_suspend@basic-s3@smem:
- {fi-adl-ddr4}: NOTRUN -> [INCOMPLETE][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/fi-adl-ddr4/igt@gem_exec_suspend@basic-s3@smem.html
Known issues
------------
Here are the changes found in Patchwork_22168 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_cs_nop@sync-fork-compute0:
- fi-snb-2600: NOTRUN -> [SKIP][2] ([fdo#109271]) +17 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/fi-snb-2600/igt@amdgpu/amd_cs_nop@sync-fork-compute0.html
* igt@debugfs_test@read_all_entries:
- fi-apl-guc: NOTRUN -> [DMESG-WARN][3] ([i915#1610])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/fi-apl-guc/igt@debugfs_test@read_all_entries.html
* igt@fbdev@nullptr:
- bat-dg1-6: NOTRUN -> [SKIP][4] ([i915#2582]) +4 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/bat-dg1-6/igt@fbdev@nullptr.html
* igt@gem_exec_gttfill@basic:
- bat-dg1-6: NOTRUN -> [SKIP][5] ([i915#4086])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/bat-dg1-6/igt@gem_exec_gttfill@basic.html
- bat-dg1-5: NOTRUN -> [SKIP][6] ([i915#4086])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/bat-dg1-5/igt@gem_exec_gttfill@basic.html
* igt@gem_exec_suspend@basic-s3@smem:
- fi-bdw-5557u: [PASS][7] -> [INCOMPLETE][8] ([i915#146])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11184/fi-bdw-5557u/igt@gem_exec_suspend@basic-s3@smem.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/fi-bdw-5557u/igt@gem_exec_suspend@basic-s3@smem.html
* igt@gem_huc_copy@huc-copy:
- fi-pnv-d510: NOTRUN -> [SKIP][9] ([fdo#109271]) +57 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/fi-pnv-d510/igt@gem_huc_copy@huc-copy.html
* igt@gem_mmap@basic:
- bat-dg1-5: NOTRUN -> [SKIP][10] ([i915#4083])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/bat-dg1-5/igt@gem_mmap@basic.html
- bat-dg1-6: NOTRUN -> [SKIP][11] ([i915#4083])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/bat-dg1-6/igt@gem_mmap@basic.html
* igt@gem_mmap_gtt@basic:
- bat-dg1-5: NOTRUN -> [SKIP][12] ([i915#4077]) +2 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/bat-dg1-5/igt@gem_mmap_gtt@basic.html
* igt@gem_tiled_blits@basic:
- bat-dg1-6: NOTRUN -> [SKIP][13] ([i915#4077]) +2 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/bat-dg1-6/igt@gem_tiled_blits@basic.html
* igt@gem_tiled_pread_basic:
- bat-dg1-6: NOTRUN -> [SKIP][14] ([i915#4079]) +1 similar issue
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/bat-dg1-6/igt@gem_tiled_pread_basic.html
- bat-dg1-5: NOTRUN -> [SKIP][15] ([i915#4079]) +1 similar issue
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/bat-dg1-5/igt@gem_tiled_pread_basic.html
* igt@i915_pm_backlight@basic-brightness:
- bat-dg1-5: NOTRUN -> [SKIP][16] ([i915#1155])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/bat-dg1-5/igt@i915_pm_backlight@basic-brightness.html
- bat-dg1-6: NOTRUN -> [SKIP][17] ([i915#1155])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/bat-dg1-6/igt@i915_pm_backlight@basic-brightness.html
* igt@i915_selftest@live@hangcheck:
- bat-dg1-5: NOTRUN -> [DMESG-FAIL][18] ([i915#4494] / [i915#4957])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/bat-dg1-5/igt@i915_selftest@live@hangcheck.html
* igt@kms_addfb_basic@addfb25-x-tiled-legacy:
- bat-dg1-6: NOTRUN -> [SKIP][19] ([i915#4212]) +7 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/bat-dg1-6/igt@kms_addfb_basic@addfb25-x-tiled-legacy.html
* igt@kms_addfb_basic@basic-y-tiled-legacy:
- bat-dg1-5: NOTRUN -> [SKIP][20] ([i915#4215])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/bat-dg1-5/igt@kms_addfb_basic@basic-y-tiled-legacy.html
- bat-dg1-6: NOTRUN -> [SKIP][21] ([i915#4215])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/bat-dg1-6/igt@kms_addfb_basic@basic-y-tiled-legacy.html
* igt@kms_addfb_basic@tile-pitch-mismatch:
- bat-dg1-5: NOTRUN -> [SKIP][22] ([i915#4212]) +7 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/bat-dg1-5/igt@kms_addfb_basic@tile-pitch-mismatch.html
* igt@kms_busy@basic:
- bat-dg1-6: NOTRUN -> [SKIP][23] ([i915#4303])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/bat-dg1-6/igt@kms_busy@basic.html
* igt@kms_chamelium@dp-hpd-fast:
- bat-dg1-5: NOTRUN -> [SKIP][24] ([fdo#111827]) +8 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/bat-dg1-5/igt@kms_chamelium@dp-hpd-fast.html
* igt@kms_chamelium@hdmi-edid-read:
- bat-dg1-6: NOTRUN -> [SKIP][25] ([fdo#111827]) +8 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/bat-dg1-6/igt@kms_chamelium@hdmi-edid-read.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- bat-dg1-5: NOTRUN -> [SKIP][26] ([i915#4103] / [i915#4213]) +1 similar issue
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/bat-dg1-5/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
- bat-dg1-6: NOTRUN -> [SKIP][27] ([i915#4103] / [i915#4213]) +1 similar issue
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/bat-dg1-6/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
* igt@kms_cursor_legacy@basic-flip-after-cursor-legacy:
- bat-dg1-6: NOTRUN -> [SKIP][28] ([i915#4078]) +24 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/bat-dg1-6/igt@kms_cursor_legacy@basic-flip-after-cursor-legacy.html
* igt@kms_force_connector_basic@force-load-detect:
- bat-dg1-6: NOTRUN -> [SKIP][29] ([fdo#109285])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/bat-dg1-6/igt@kms_force_connector_basic@force-load-detect.html
- bat-dg1-5: NOTRUN -> [SKIP][30] ([fdo#109285])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/bat-dg1-5/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_psr@cursor_plane_move:
- bat-dg1-6: NOTRUN -> [SKIP][31] ([i915#1072] / [i915#4078]) +3 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/bat-dg1-6/igt@kms_psr@cursor_plane_move.html
* igt@kms_psr@primary_page_flip:
- bat-dg1-5: NOTRUN -> [SKIP][32] ([i915#1072] / [i915#4078]) +3 similar issues
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/bat-dg1-5/igt@kms_psr@primary_page_flip.html
* igt@prime_vgem@basic-fence-flip:
- bat-dg1-5: NOTRUN -> [SKIP][33] ([i915#3708]) +3 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/bat-dg1-5/igt@prime_vgem@basic-fence-flip.html
- bat-dg1-6: NOTRUN -> [SKIP][34] ([i915#3708]) +3 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/bat-dg1-6/igt@prime_vgem@basic-fence-flip.html
* igt@prime_vgem@basic-fence-mmap:
- bat-dg1-5: NOTRUN -> [SKIP][35] ([i915#3708] / [i915#4077]) +1 similar issue
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/bat-dg1-5/igt@prime_vgem@basic-fence-mmap.html
* igt@prime_vgem@basic-gtt:
- bat-dg1-6: NOTRUN -> [SKIP][36] ([i915#3708] / [i915#4077]) +1 similar issue
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/bat-dg1-6/igt@prime_vgem@basic-gtt.html
* igt@prime_vgem@basic-userptr:
- bat-dg1-6: NOTRUN -> [SKIP][37] ([i915#3708] / [i915#4873])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/bat-dg1-6/igt@prime_vgem@basic-userptr.html
- bat-dg1-5: NOTRUN -> [SKIP][38] ([i915#3708] / [i915#4873])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/bat-dg1-5/igt@prime_vgem@basic-userptr.html
* igt@runner@aborted:
- fi-apl-guc: NOTRUN -> [FAIL][39] ([i915#2426] / [i915#4312])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/fi-apl-guc/igt@runner@aborted.html
#### Possible fixes ####
* igt@i915_selftest@live@hangcheck:
- fi-snb-2600: [INCOMPLETE][40] ([i915#3921]) -> [PASS][41]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11184/fi-snb-2600/igt@i915_selftest@live@hangcheck.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/fi-snb-2600/igt@i915_selftest@live@hangcheck.html
#### Warnings ####
* igt@kms_psr@primary_page_flip:
- fi-skl-6600u: [INCOMPLETE][42] ([i915#4547] / [i915#4838]) -> [FAIL][43] ([i915#4547])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11184/fi-skl-6600u/igt@kms_psr@primary_page_flip.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/fi-skl-6600u/igt@kms_psr@primary_page_flip.html
* igt@runner@aborted:
- fi-skl-6600u: [FAIL][44] ([i915#2722] / [i915#4312]) -> [FAIL][45] ([i915#4312])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11184/fi-skl-6600u/igt@runner@aborted.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/fi-skl-6600u/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#146]: https://gitlab.freedesktop.org/drm/intel/issues/146
[i915#1610]: https://gitlab.freedesktop.org/drm/intel/issues/1610
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2722]: https://gitlab.freedesktop.org/drm/intel/issues/2722
[i915#3003]: https://gitlab.freedesktop.org/drm/intel/issues/3003
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3921]: https://gitlab.freedesktop.org/drm/intel/issues/3921
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4086]: https://gitlab.freedesktop.org/drm/intel/issues/4086
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
[i915#4303]: https://gitlab.freedesktop.org/drm/intel/issues/4303
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4494]: https://gitlab.freedesktop.org/drm/intel/issues/4494
[i915#4547]: https://gitlab.freedesktop.org/drm/intel/issues/4547
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4838]: https://gitlab.freedesktop.org/drm/intel/issues/4838
[i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873
[i915#4898]: https://gitlab.freedesktop.org/drm/intel/issues/4898
[i915#4957]: https://gitlab.freedesktop.org/drm/intel/issues/4957
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
Build changes
-------------
* Linux: CI_DRM_11184 -> Patchwork_22168
CI-20190529: 20190529
CI_DRM_11184: 04d657f075e9162f0d622c5a91115395cbd7dd98 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6339: 9cd99d763440ae75d9981ce4e361d3deb5edb4e4 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_22168: d95afbb472d05e3e4c928b03f79c5737e8795c37 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
d95afbb472d0 drm/i915/pm: hide struct drm_i915_clock_gating_funcs
fc6c82f21428 drm/i915/dpll: hide struct intel_dpll_funcs
b6588e21d1d4 drm/i915/dpll: add intel_dpll_crtc_compute_clock()
9644ddf1d294 drm/i915/fdi: hide struct intel_fdi_funcs
b0d4c38f7c34 drm/i915/hpd: hide struct intel_hotplug_funcs
640ee40e5670 drm/i915/color: hide struct intel_color_funcs
7f57aded06ee drm/i915: group i915_drv.h forward declarations together
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/index.html
[-- Attachment #2: Type: text/html, Size: 17056 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: split out function structs from i915_drv.h
2022-02-03 14:02 [Intel-gfx] [PATCH 0/7] drm/i915: split out function structs from i915_drv.h Jani Nikula
` (8 preceding siblings ...)
2022-02-03 15:26 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2022-02-03 18:28 ` Patchwork
9 siblings, 0 replies; 15+ messages in thread
From: Patchwork @ 2022-02-03 18:28 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 30275 bytes --]
== Series Details ==
Series: drm/i915: split out function structs from i915_drv.h
URL : https://patchwork.freedesktop.org/series/99669/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11184_full -> Patchwork_22168_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_22168_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_22168_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Participating hosts (12 -> 12)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_22168_full:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@guc_multi_lrc:
- shard-skl: NOTRUN -> [INCOMPLETE][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-skl6/igt@i915_selftest@live@guc_multi_lrc.html
* igt@i915_selftest@mock@requests:
- shard-skl: [PASS][2] -> [INCOMPLETE][3]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11184/shard-skl10/igt@i915_selftest@mock@requests.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-skl7/igt@i915_selftest@mock@requests.html
Known issues
------------
Here are the changes found in Patchwork_22168_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_shared@create-shared-gtt:
- shard-glk: [PASS][4] -> [DMESG-WARN][5] ([i915#118]) +1 similar issue
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11184/shard-glk8/igt@gem_ctx_shared@create-shared-gtt.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-glk1/igt@gem_ctx_shared@create-shared-gtt.html
* igt@gem_eio@in-flight-10ms:
- shard-tglb: [PASS][6] -> [TIMEOUT][7] ([i915#3063])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11184/shard-tglb6/igt@gem_eio@in-flight-10ms.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-tglb2/igt@gem_eio@in-flight-10ms.html
* igt@gem_eio@in-flight-immediate:
- shard-skl: [PASS][8] -> [TIMEOUT][9] ([i915#3063])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11184/shard-skl10/igt@gem_eio@in-flight-immediate.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-skl7/igt@gem_eio@in-flight-immediate.html
* igt@gem_exec_balancer@parallel-contexts:
- shard-iclb: [PASS][10] -> [SKIP][11] ([i915#4525]) +3 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11184/shard-iclb1/igt@gem_exec_balancer@parallel-contexts.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-iclb7/igt@gem_exec_balancer@parallel-contexts.html
* igt@gem_exec_capture@pi@rcs0:
- shard-skl: NOTRUN -> [INCOMPLETE][12] ([i915#4547])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-skl8/igt@gem_exec_capture@pi@rcs0.html
* igt@gem_exec_fair@basic-deadline:
- shard-kbl: NOTRUN -> [FAIL][13] ([i915#2846])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-kbl3/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-none@vcs0:
- shard-kbl: [PASS][14] -> [FAIL][15] ([i915#2842]) +2 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11184/shard-kbl6/igt@gem_exec_fair@basic-none@vcs0.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-kbl3/igt@gem_exec_fair@basic-none@vcs0.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglb: [PASS][16] -> [FAIL][17] ([i915#2842])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11184/shard-tglb3/igt@gem_exec_fair@basic-pace-share@rcs0.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-tglb6/igt@gem_exec_fair@basic-pace-share@rcs0.html
- shard-apl: [PASS][18] -> [FAIL][19] ([i915#2842])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11184/shard-apl7/igt@gem_exec_fair@basic-pace-share@rcs0.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-apl3/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-iclb: NOTRUN -> [FAIL][20] ([i915#2842]) +4 similar issues
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-iclb8/igt@gem_exec_fair@basic-pace-solo@rcs0.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-glk: [PASS][21] -> [FAIL][22] ([i915#2842])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11184/shard-glk5/igt@gem_exec_fair@basic-throttle@rcs0.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-glk4/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@gem_huc_copy@huc-copy:
- shard-skl: NOTRUN -> [SKIP][23] ([fdo#109271] / [i915#2190])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-skl2/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@parallel-multi:
- shard-kbl: NOTRUN -> [SKIP][24] ([fdo#109271] / [i915#4613])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-kbl6/igt@gem_lmem_swapping@parallel-multi.html
* igt@gem_lmem_swapping@parallel-random:
- shard-skl: NOTRUN -> [SKIP][25] ([fdo#109271] / [i915#4613]) +3 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-skl9/igt@gem_lmem_swapping@parallel-random.html
* igt@gem_lmem_swapping@random:
- shard-apl: NOTRUN -> [SKIP][26] ([fdo#109271] / [i915#4613]) +1 similar issue
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-apl4/igt@gem_lmem_swapping@random.html
* igt@gem_pwrite@basic-exhaustion:
- shard-skl: NOTRUN -> [WARN][27] ([i915#2658])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-skl4/igt@gem_pwrite@basic-exhaustion.html
* igt@gem_pxp@reject-modify-context-protection-off-3:
- shard-iclb: NOTRUN -> [SKIP][28] ([i915#4270])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-iclb8/igt@gem_pxp@reject-modify-context-protection-off-3.html
* igt@gem_render_copy@y-tiled-to-vebox-y-tiled:
- shard-iclb: NOTRUN -> [SKIP][29] ([i915#768])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-iclb8/igt@gem_render_copy@y-tiled-to-vebox-y-tiled.html
* igt@gem_userptr_blits@dmabuf-sync:
- shard-kbl: NOTRUN -> [SKIP][30] ([fdo#109271] / [i915#3323])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-kbl6/igt@gem_userptr_blits@dmabuf-sync.html
- shard-apl: NOTRUN -> [SKIP][31] ([fdo#109271] / [i915#3323])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-apl8/igt@gem_userptr_blits@dmabuf-sync.html
- shard-skl: NOTRUN -> [SKIP][32] ([fdo#109271] / [i915#3323])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-skl1/igt@gem_userptr_blits@dmabuf-sync.html
* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-apl: NOTRUN -> [SKIP][33] ([fdo#109271] / [i915#658])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-apl8/igt@i915_pm_dc@dc3co-vpb-simulation.html
- shard-kbl: NOTRUN -> [SKIP][34] ([fdo#109271] / [i915#658])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-kbl6/igt@i915_pm_dc@dc3co-vpb-simulation.html
* igt@i915_pm_dc@dc6-dpms:
- shard-iclb: [PASS][35] -> [FAIL][36] ([i915#454])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11184/shard-iclb7/igt@i915_pm_dc@dc6-dpms.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-iclb3/igt@i915_pm_dc@dc6-dpms.html
- shard-skl: NOTRUN -> [FAIL][37] ([i915#454])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-skl10/igt@i915_pm_dc@dc6-dpms.html
* igt@i915_pm_rpm@gem-execbuf-stress-pc8:
- shard-iclb: NOTRUN -> [SKIP][38] ([fdo#109293] / [fdo#109506])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-iclb8/igt@i915_pm_rpm@gem-execbuf-stress-pc8.html
* igt@i915_selftest@live@gt_pm:
- shard-skl: NOTRUN -> [DMESG-FAIL][39] ([i915#1886] / [i915#2291])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-skl6/igt@i915_selftest@live@gt_pm.html
* igt@i915_suspend@forcewake:
- shard-kbl: NOTRUN -> [DMESG-WARN][40] ([i915#180])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-kbl6/igt@i915_suspend@forcewake.html
* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip:
- shard-skl: NOTRUN -> [SKIP][41] ([fdo#109271] / [i915#3777]) +5 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-skl10/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip.html
- shard-kbl: NOTRUN -> [SKIP][42] ([fdo#109271] / [i915#3777]) +1 similar issue
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-kbl6/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip.html
* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-async-flip:
- shard-skl: NOTRUN -> [FAIL][43] ([i915#3763])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-skl4/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-async-flip.html
* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-hflip:
- shard-apl: NOTRUN -> [SKIP][44] ([fdo#109271] / [i915#3777]) +1 similar issue
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-apl4/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-hflip.html
* igt@kms_ccs@pipe-a-bad-rotation-90-y_tiled_gen12_mc_ccs:
- shard-iclb: NOTRUN -> [SKIP][45] ([fdo#109278] / [i915#3886])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-iclb8/igt@kms_ccs@pipe-a-bad-rotation-90-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][46] ([fdo#109271] / [i915#3886]) +3 similar issues
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-apl8/igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc:
- shard-skl: NOTRUN -> [SKIP][47] ([fdo#109271] / [i915#3886]) +12 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-skl10/igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-c-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs:
- shard-kbl: NOTRUN -> [SKIP][48] ([fdo#109271] / [i915#3886]) +2 similar issues
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-kbl3/igt@kms_ccs@pipe-c-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs.html
* igt@kms_chamelium@hdmi-aspect-ratio:
- shard-skl: NOTRUN -> [SKIP][49] ([fdo#109271] / [fdo#111827]) +26 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-skl10/igt@kms_chamelium@hdmi-aspect-ratio.html
* igt@kms_chamelium@hdmi-hpd-for-each-pipe:
- shard-kbl: NOTRUN -> [SKIP][50] ([fdo#109271] / [fdo#111827]) +6 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-kbl6/igt@kms_chamelium@hdmi-hpd-for-each-pipe.html
- shard-apl: NOTRUN -> [SKIP][51] ([fdo#109271] / [fdo#111827]) +4 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-apl8/igt@kms_chamelium@hdmi-hpd-for-each-pipe.html
* igt@kms_color_chamelium@pipe-a-ctm-limited-range:
- shard-iclb: NOTRUN -> [SKIP][52] ([fdo#109284] / [fdo#111827]) +1 similar issue
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-iclb8/igt@kms_color_chamelium@pipe-a-ctm-limited-range.html
* igt@kms_cursor_crc@pipe-c-cursor-512x170-random:
- shard-iclb: NOTRUN -> [SKIP][53] ([fdo#109278] / [fdo#109279])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-iclb7/igt@kms_cursor_crc@pipe-c-cursor-512x170-random.html
* igt@kms_cursor_crc@pipe-d-cursor-256x256-rapid-movement:
- shard-iclb: NOTRUN -> [SKIP][54] ([fdo#109278]) +10 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-iclb8/igt@kms_cursor_crc@pipe-d-cursor-256x256-rapid-movement.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-iclb: [PASS][55] -> [FAIL][56] ([i915#2346])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11184/shard-iclb1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-iclb7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
- shard-skl: [PASS][57] -> [FAIL][58] ([i915#2346])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11184/shard-skl1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-skl1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
* igt@kms_flip@2x-flip-vs-expired-vblank@bc-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][59] -> [FAIL][60] ([i915#79])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11184/shard-glk4/igt@kms_flip@2x-flip-vs-expired-vblank@bc-hdmi-a1-hdmi-a2.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-glk8/igt@kms_flip@2x-flip-vs-expired-vblank@bc-hdmi-a1-hdmi-a2.html
* igt@kms_flip@2x-wf_vblank-ts-check-interruptible:
- shard-iclb: NOTRUN -> [SKIP][61] ([fdo#109274])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-iclb8/igt@kms_flip@2x-wf_vblank-ts-check-interruptible.html
* igt@kms_flip@flip-vs-expired-vblank@a-edp1:
- shard-skl: [PASS][62] -> [FAIL][63] ([i915#79])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11184/shard-skl10/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-skl3/igt@kms_flip@flip-vs-expired-vblank@a-edp1.html
* igt@kms_flip@flip-vs-suspend-interruptible@c-dp1:
- shard-kbl: [PASS][64] -> [INCOMPLETE][65] ([i915#636])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11184/shard-kbl4/igt@kms_flip@flip-vs-suspend-interruptible@c-dp1.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-kbl3/igt@kms_flip@flip-vs-suspend-interruptible@c-dp1.html
* igt@kms_flip@plain-flip-ts-check-interruptible@b-edp1:
- shard-skl: [PASS][66] -> [FAIL][67] ([i915#2122]) +2 similar issues
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11184/shard-skl10/igt@kms_flip@plain-flip-ts-check-interruptible@b-edp1.html
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-skl3/igt@kms_flip@plain-flip-ts-check-interruptible@b-edp1.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-downscaling:
- shard-skl: NOTRUN -> [INCOMPLETE][68] ([i915#3701])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-skl6/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-downscaling.html
- shard-iclb: [PASS][69] -> [SKIP][70] ([i915#3701])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11184/shard-iclb8/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-downscaling.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-downscaling.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-mmap-wc:
- shard-apl: NOTRUN -> [SKIP][71] ([fdo#109271]) +101 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-apl1/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-indfb-pgflip-blt:
- shard-iclb: NOTRUN -> [SKIP][72] ([fdo#109280]) +3 similar issues
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-iclb7/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-indfb-pgflip-blt.html
* igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-mmap-gtt:
- shard-kbl: NOTRUN -> [SKIP][73] ([fdo#109271]) +64 similar issues
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-kbl6/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-shrfb-draw-mmap-gtt.html
* igt@kms_frontbuffer_tracking@psr-suspend:
- shard-skl: NOTRUN -> [INCOMPLETE][74] ([i915#123])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-skl2/igt@kms_frontbuffer_tracking@psr-suspend.html
* igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-d:
- shard-apl: NOTRUN -> [SKIP][75] ([fdo#109271] / [i915#533])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-apl1/igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-d.html
* igt@kms_plane@plane-panning-bottom-right-suspend@pipe-b-planes:
- shard-apl: [PASS][76] -> [DMESG-WARN][77] ([i915#180]) +1 similar issue
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11184/shard-apl3/igt@kms_plane@plane-panning-bottom-right-suspend@pipe-b-planes.html
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-apl3/igt@kms_plane@plane-panning-bottom-right-suspend@pipe-b-planes.html
* igt@kms_plane_alpha_blend@pipe-a-alpha-7efc:
- shard-skl: NOTRUN -> [FAIL][78] ([fdo#108145] / [i915#265]) +2 similar issues
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-skl1/igt@kms_plane_alpha_blend@pipe-a-alpha-7efc.html
- shard-apl: NOTRUN -> [FAIL][79] ([fdo#108145] / [i915#265])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-apl8/igt@kms_plane_alpha_blend@pipe-a-alpha-7efc.html
- shard-kbl: NOTRUN -> [FAIL][80] ([fdo#108145] / [i915#265])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-kbl6/igt@kms_plane_alpha_blend@pipe-a-alpha-7efc.html
* igt@kms_psr2_su@page_flip-xrgb8888:
- shard-skl: NOTRUN -> [SKIP][81] ([fdo#109271] / [i915#658]) +1 similar issue
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-skl2/igt@kms_psr2_su@page_flip-xrgb8888.html
* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [PASS][82] -> [SKIP][83] ([fdo#109441]) +2 similar issues
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11184/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-iclb6/igt@kms_psr@psr2_sprite_plane_move.html
* igt@kms_scaling_modes@scaling-mode-none@edp-1-pipe-a:
- shard-skl: NOTRUN -> [SKIP][84] ([fdo#109271]) +254 similar issues
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-skl1/igt@kms_scaling_modes@scaling-mode-none@edp-1-pipe-a.html
* igt@kms_vblank@pipe-d-wait-idle:
- shard-skl: NOTRUN -> [SKIP][85] ([fdo#109271] / [i915#533]) +5 similar issues
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-skl8/igt@kms_vblank@pipe-d-wait-idle.html
* igt@kms_writeback@writeback-pixel-formats:
- shard-skl: NOTRUN -> [SKIP][86] ([fdo#109271] / [i915#2437])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-skl9/igt@kms_writeback@writeback-pixel-formats.html
* igt@nouveau_crc@pipe-a-source-outp-inactive:
- shard-iclb: NOTRUN -> [SKIP][87] ([i915#2530])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-iclb3/igt@nouveau_crc@pipe-a-source-outp-inactive.html
* igt@perf_pmu@event-wait@rcs0:
- shard-iclb: NOTRUN -> [SKIP][88] ([fdo#112283])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-iclb3/igt@perf_pmu@event-wait@rcs0.html
* igt@prime_nv_pcopy@test_semaphore:
- shard-iclb: NOTRUN -> [SKIP][89] ([fdo#109291]) +1 similar issue
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-iclb7/igt@prime_nv_pcopy@test_semaphore.html
* igt@prime_vgem@coherency-gtt:
- shard-iclb: NOTRUN -> [SKIP][90] ([fdo#109292])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-iclb8/igt@prime_vgem@coherency-gtt.html
* igt@sysfs_clients@create:
- shard-apl: NOTRUN -> [SKIP][91] ([fdo#109271] / [i915#2994]) +2 similar issues
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-apl8/igt@sysfs_clients@create.html
- shard-kbl: NOTRUN -> [SKIP][92] ([fdo#109271] / [i915#2994])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-kbl6/igt@sysfs_clients@create.html
* igt@sysfs_clients@fair-0:
- shard-skl: NOTRUN -> [SKIP][93] ([fdo#109271] / [i915#2994]) +3 similar issues
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-skl9/igt@sysfs_clients@fair-0.html
* igt@sysfs_clients@fair-1:
- shard-iclb: NOTRUN -> [SKIP][94] ([i915#2994])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-iclb8/igt@sysfs_clients@fair-1.html
* igt@sysfs_heartbeat_interval@mixed@rcs0:
- shard-skl: [PASS][95] -> [WARN][96] ([i915#4055])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11184/shard-skl10/igt@sysfs_heartbeat_interval@mixed@rcs0.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-skl3/igt@sysfs_heartbeat_interval@mixed@rcs0.html
* igt@sysfs_heartbeat_interval@mixed@vcs0:
- shard-skl: [PASS][97] -> [FAIL][98] ([i915#1731]) +1 similar issue
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11184/shard-skl10/igt@sysfs_heartbeat_interval@mixed@vcs0.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-skl3/igt@sysfs_heartbeat_interval@mixed@vcs0.html
#### Possible fixes ####
* igt@feature_discovery@psr2:
- shard-iclb: [SKIP][99] ([i915#658]) -> [PASS][100]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11184/shard-iclb3/igt@feature_discovery@psr2.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-iclb2/igt@feature_discovery@psr2.html
* igt@gem_eio@unwedge-stress:
- {shard-tglu}: [TIMEOUT][101] ([i915#3063] / [i915#3648]) -> [PASS][102]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11184/shard-tglu-2/igt@gem_eio@unwedge-stress.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-tglu-1/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_balancer@parallel-keep-submit-fence:
- shard-iclb: [SKIP][103] ([i915#4525]) -> [PASS][104]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11184/shard-iclb7/igt@gem_exec_balancer@parallel-keep-submit-fence.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-iclb1/igt@gem_exec_balancer@parallel-keep-submit-fence.html
* igt@gem_exec_fair@basic-none-vip@rcs0:
- shard-glk: [FAIL][105] ([i915#2842]) -> [PASS][106]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11184/shard-glk6/igt@gem_exec_fair@basic-none-vip@rcs0.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-glk5/igt@gem_exec_fair@basic-none-vip@rcs0.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- {shard-tglu}: [FAIL][107] ([i915#2842]) -> [PASS][108]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11184/shard-tglu-4/igt@gem_exec_fair@basic-pace-share@rcs0.html
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-tglu-6/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_whisper@basic-queues-priority:
- shard-iclb: [INCOMPLETE][109] ([i915#1895]) -> [PASS][110]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11184/shard-iclb7/igt@gem_exec_whisper@basic-queues-priority.html
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-iclb8/igt@gem_exec_whisper@basic-queues-priority.html
* igt@gen9_exec_parse@allowed-single:
- shard-skl: [DMESG-WARN][111] ([i915#1436] / [i915#716]) -> [PASS][112]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11184/shard-skl6/igt@gen9_exec_parse@allowed-single.html
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-skl6/igt@gen9_exec_parse@allowed-single.html
* igt@i915_pm_dc@dc6-dpms:
- {shard-tglu}: [FAIL][113] ([i915#454]) -> [PASS][114]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11184/shard-tglu-3/igt@i915_pm_dc@dc6-dpms.html
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-tglu-4/igt@i915_pm_dc@dc6-dpms.html
* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a:
- {shard-tglu}: [FAIL][115] ([i915#3825]) -> [PASS][116]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11184/shard-tglu-2/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a.html
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-tglu-1/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a.html
* igt@i915_pm_rc6_residency@rc6-fence:
- {shard-tglu}: [WARN][117] ([i915#2681]) -> [PASS][118]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11184/shard-tglu-1/igt@i915_pm_rc6_residency@rc6-fence.html
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-tglu-2/igt@i915_pm_rc6_residency@rc6-fence.html
* igt@i915_suspend@debugfs-reader:
- shard-kbl: [DMESG-WARN][119] ([i915#180]) -> [PASS][120] +3 similar issues
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11184/shard-kbl4/igt@i915_suspend@debugfs-reader.html
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-kbl3/igt@i915_suspend@debugfs-reader.html
* igt@i915_suspend@fence-restore-tiled2untiled:
- shard-apl: [DMESG-WARN][121] ([i915#180]) -> [PASS][122] +5 similar issues
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11184/shard-apl3/igt@i915_suspend@fence-restore-tiled2untiled.html
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-apl8/igt@i915_suspend@fence-restore-tiled2untiled.html
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ab-hdmi-a1-hdmi-a2:
- shard-glk: [FAIL][123] ([i915#79]) -> [PASS][124]
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11184/shard-glk1/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ab-hdmi-a1-hdmi-a2.html
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-glk3/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ab-hdmi-a1-hdmi-a2.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1:
- shard-skl: [FAIL][125] ([i915#79]) -> [PASS][126]
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11184/shard-skl7/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-skl3/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
* igt@kms_flip@flip-vs-suspend-interruptible@a-edp1:
- shard-skl: [INCOMPLETE][127] -> [PASS][128]
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11184/shard-skl9/igt@kms_flip@flip-vs-suspend-interruptible@a-edp1.html
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-skl9/igt@kms_flip@flip-vs-suspend-interruptible@a-edp1.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-upscaling:
- shard-glk: [FAIL][129] ([i915#4911]) -> [PASS][130]
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11184/shard-glk8/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-upscaling.html
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-glk1/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-upscaling.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-mmap-wc:
- {shard-rkl}: ([PASS][131], [SKIP][132]) ([i915#4098]) -> [PASS][133]
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11184/shard-rkl-6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-mmap-wc.html
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11184/shard-rkl-4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-mmap-wc.html
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-rkl-6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-mmap-wc.html
* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [SKIP][134] ([fdo#109441]) -> [PASS][135] +3 similar issues
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11184/shard-iclb8/igt@kms_psr@psr2_cursor_render.html
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
* igt@kms_vblank@pipe-a-query-forked-busy:
- {shard-rkl}: ([SKIP][136], [PASS][137]) ([i915#1845]) -> [PASS][138]
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11184/shard-rkl-4/igt@kms_vblank@pipe-a-query-forked-busy.html
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11184/shard-rkl-6/igt@kms_vblank@pipe-a-query-forked-busy.html
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-rkl-6/igt@kms_vblank@pipe-a-query-forked-busy.html
* igt@perf@polling-parameterized:
- shard-skl: [FAIL][139] ([i915#1542]) -> [PASS][140]
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11184/shard-skl7/igt@perf@polling-parameterized.html
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/shard-skl4/igt@perf@polling-parameterized.html
#### Warnings ####
* igt@gem_eio
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22168/index.html
[-- Attachment #2: Type: text/html, Size: 33450 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Intel-gfx] [PATCH 1/7] drm/i915: group i915_drv.h forward declarations together
2022-02-03 14:02 ` [Intel-gfx] [PATCH 1/7] drm/i915: group i915_drv.h forward declarations together Jani Nikula
@ 2022-02-09 10:42 ` Ville Syrjälä
0 siblings, 0 replies; 15+ messages in thread
From: Ville Syrjälä @ 2022-02-09 10:42 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
On Thu, Feb 03, 2022 at 04:02:27PM +0200, Jani Nikula wrote:
> Group the forward declarations in i915_drv.h together near the top, like
> in other header files, and sort.
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/i915_drv.h | 44 ++++++++++++++-------------------
> 1 file changed, 19 insertions(+), 25 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index 8c1706fd81f9..5a1615c02971 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -106,6 +106,25 @@
> #include "gt/intel_timeline.h"
> #include "i915_vma.h"
>
> +struct dpll;
> +struct drm_i915_gem_object;
> +struct drm_i915_private;
> +struct intel_atomic_state;
> +struct intel_audio_funcs;
> +struct intel_cdclk_config;
> +struct intel_cdclk_funcs;
> +struct intel_cdclk_state;
> +struct intel_cdclk_vals;
We're already including intel_cdclk.h so these shouldn't
even be needed.
Apart from that
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Intel-gfx] [PATCH 2/7] drm/i915/color: hide struct intel_color_funcs
2022-02-03 14:02 ` [Intel-gfx] [PATCH 2/7] drm/i915/color: hide struct intel_color_funcs Jani Nikula
@ 2022-02-09 10:43 ` Ville Syrjälä
0 siblings, 0 replies; 15+ messages in thread
From: Ville Syrjälä @ 2022-02-09 10:43 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
On Thu, Feb 03, 2022 at 04:02:28PM +0200, Jani Nikula wrote:
> The struct is only needed in intel_color.c, move it there.
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_color.c | 19 +++++++++++++++++++
> drivers/gpu/drm/i915/i915_drv.h | 20 +-------------------
> 2 files changed, 20 insertions(+), 19 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_color.c b/drivers/gpu/drm/i915/display/intel_color.c
> index de3ded1e327a..8f8b34b60f27 100644
> --- a/drivers/gpu/drm/i915/display/intel_color.c
> +++ b/drivers/gpu/drm/i915/display/intel_color.c
> @@ -28,6 +28,25 @@
> #include "intel_dpll.h"
> #include "vlv_dsi_pll.h"
>
> +struct intel_color_funcs {
> + int (*color_check)(struct intel_crtc_state *crtc_state);
> + /*
> + * Program double buffered color management registers during
> + * vblank evasion. The registers should then latch during the
> + * next vblank start, alongside any other double buffered registers
> + * involved with the same commit.
> + */
> + void (*color_commit)(const struct intel_crtc_state *crtc_state);
> + /*
> + * Load LUTs (and other single buffered color management
> + * registers). Will (hopefully) be called during the vblank
> + * following the latching of any double buffered registers
> + * involved with the same commit.
> + */
> + void (*load_luts)(const struct intel_crtc_state *crtc_state);
> + void (*read_luts)(struct intel_crtc_state *crtc_state);
> +};
> +
> #define CTM_COEFF_SIGN (1ULL << 63)
>
> #define CTM_COEFF_1_0 (1ULL << 32)
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index 5a1615c02971..cac18b57808e 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -115,6 +115,7 @@ struct intel_cdclk_config;
> struct intel_cdclk_funcs;
> struct intel_cdclk_state;
> struct intel_cdclk_vals;
> +struct intel_color_funcs;
> struct intel_connector;
> struct intel_crtc;
> struct intel_dp;
> @@ -320,25 +321,6 @@ struct drm_i915_wm_disp_funcs {
> int (*compute_global_watermarks)(struct intel_atomic_state *state);
> };
>
> -struct intel_color_funcs {
> - int (*color_check)(struct intel_crtc_state *crtc_state);
> - /*
> - * Program double buffered color management registers during
> - * vblank evasion. The registers should then latch during the
> - * next vblank start, alongside any other double buffered registers
> - * involved with the same commit.
> - */
> - void (*color_commit)(const struct intel_crtc_state *crtc_state);
> - /*
> - * Load LUTs (and other single buffered color management
> - * registers). Will (hopefully) be called during the vblank
> - * following the latching of any double buffered registers
> - * involved with the same commit.
> - */
> - void (*load_luts)(const struct intel_crtc_state *crtc_state);
> - void (*read_luts)(struct intel_crtc_state *crtc_state);
> -};
> -
> struct intel_hotplug_funcs {
> void (*hpd_irq_setup)(struct drm_i915_private *dev_priv);
> };
> --
> 2.30.2
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Intel-gfx] [PATCH 7/7] drm/i915/pm: hide struct drm_i915_clock_gating_funcs
2022-02-03 14:02 ` [Intel-gfx] [PATCH 7/7] drm/i915/pm: hide struct drm_i915_clock_gating_funcs Jani Nikula
@ 2022-02-09 10:45 ` Ville Syrjälä
2022-02-09 13:12 ` Jani Nikula
0 siblings, 1 reply; 15+ messages in thread
From: Ville Syrjälä @ 2022-02-09 10:45 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
On Thu, Feb 03, 2022 at 04:02:33PM +0200, Jani Nikula wrote:
> The struct is only needed in intel_pm.c, move it there.
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
I find these single vfunc structs a bit ridiculous, but since
we have them might as well hide them.
For the series is
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/i915_drv.h | 6 +-----
> drivers/gpu/drm/i915/intel_pm.c | 4 ++++
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index 078fc50e7eb9..4ac0fcb9a4ca 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -107,6 +107,7 @@
> #include "i915_vma.h"
>
> struct dpll;
> +struct drm_i915_clock_gating_funcs;
> struct drm_i915_gem_object;
> struct drm_i915_private;
> struct intel_atomic_state;
> @@ -302,11 +303,6 @@ struct sdvo_device_mapping {
> u8 ddc_pin;
> };
>
> -/* functions used internal in intel_pm.c */
> -struct drm_i915_clock_gating_funcs {
> - void (*init_clock_gating)(struct drm_i915_private *dev_priv);
> -};
> -
> /* functions used for watermark calcs for display. */
> struct drm_i915_wm_disp_funcs {
> /* update_wm is for legacy wm management */
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index 859be750fb22..2e84d45f9bf0 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -55,6 +55,10 @@
> #include "vlv_sideband.h"
> #include "../../../platform/x86/intel_ips.h"
>
> +struct drm_i915_clock_gating_funcs {
> + void (*init_clock_gating)(struct drm_i915_private *i915);
> +};
> +
> /* Stores plane specific WM parameters */
> struct skl_wm_params {
> bool x_tiled, y_tiled;
> --
> 2.30.2
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Intel-gfx] [PATCH 7/7] drm/i915/pm: hide struct drm_i915_clock_gating_funcs
2022-02-09 10:45 ` Ville Syrjälä
@ 2022-02-09 13:12 ` Jani Nikula
0 siblings, 0 replies; 15+ messages in thread
From: Jani Nikula @ 2022-02-09 13:12 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
On Wed, 09 Feb 2022, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Thu, Feb 03, 2022 at 04:02:33PM +0200, Jani Nikula wrote:
>> The struct is only needed in intel_pm.c, move it there.
>>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> I find these single vfunc structs a bit ridiculous, but since
> we have them might as well hide them.
>
> For the series is
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Thanks, pushed the lot.
BR,
Jani.
>
>> ---
>> drivers/gpu/drm/i915/i915_drv.h | 6 +-----
>> drivers/gpu/drm/i915/intel_pm.c | 4 ++++
>> 2 files changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
>> index 078fc50e7eb9..4ac0fcb9a4ca 100644
>> --- a/drivers/gpu/drm/i915/i915_drv.h
>> +++ b/drivers/gpu/drm/i915/i915_drv.h
>> @@ -107,6 +107,7 @@
>> #include "i915_vma.h"
>>
>> struct dpll;
>> +struct drm_i915_clock_gating_funcs;
>> struct drm_i915_gem_object;
>> struct drm_i915_private;
>> struct intel_atomic_state;
>> @@ -302,11 +303,6 @@ struct sdvo_device_mapping {
>> u8 ddc_pin;
>> };
>>
>> -/* functions used internal in intel_pm.c */
>> -struct drm_i915_clock_gating_funcs {
>> - void (*init_clock_gating)(struct drm_i915_private *dev_priv);
>> -};
>> -
>> /* functions used for watermark calcs for display. */
>> struct drm_i915_wm_disp_funcs {
>> /* update_wm is for legacy wm management */
>> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
>> index 859be750fb22..2e84d45f9bf0 100644
>> --- a/drivers/gpu/drm/i915/intel_pm.c
>> +++ b/drivers/gpu/drm/i915/intel_pm.c
>> @@ -55,6 +55,10 @@
>> #include "vlv_sideband.h"
>> #include "../../../platform/x86/intel_ips.h"
>>
>> +struct drm_i915_clock_gating_funcs {
>> + void (*init_clock_gating)(struct drm_i915_private *i915);
>> +};
>> +
>> /* Stores plane specific WM parameters */
>> struct skl_wm_params {
>> bool x_tiled, y_tiled;
>> --
>> 2.30.2
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2022-02-09 13:13 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-03 14:02 [Intel-gfx] [PATCH 0/7] drm/i915: split out function structs from i915_drv.h Jani Nikula
2022-02-03 14:02 ` [Intel-gfx] [PATCH 1/7] drm/i915: group i915_drv.h forward declarations together Jani Nikula
2022-02-09 10:42 ` Ville Syrjälä
2022-02-03 14:02 ` [Intel-gfx] [PATCH 2/7] drm/i915/color: hide struct intel_color_funcs Jani Nikula
2022-02-09 10:43 ` Ville Syrjälä
2022-02-03 14:02 ` [Intel-gfx] [PATCH 3/7] drm/i915/hpd: hide struct intel_hotplug_funcs Jani Nikula
2022-02-03 14:02 ` [Intel-gfx] [PATCH 4/7] drm/i915/fdi: hide struct intel_fdi_funcs Jani Nikula
2022-02-03 14:02 ` [Intel-gfx] [PATCH 5/7] drm/i915/dpll: add intel_dpll_crtc_compute_clock() Jani Nikula
2022-02-03 14:02 ` [Intel-gfx] [PATCH 6/7] drm/i915/dpll: hide struct intel_dpll_funcs Jani Nikula
2022-02-03 14:02 ` [Intel-gfx] [PATCH 7/7] drm/i915/pm: hide struct drm_i915_clock_gating_funcs Jani Nikula
2022-02-09 10:45 ` Ville Syrjälä
2022-02-09 13:12 ` Jani Nikula
2022-02-03 14:56 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: split out function structs from i915_drv.h Patchwork
2022-02-03 15:26 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-02-03 18:28 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox