* [Intel-gfx] [PATCH v6 1/2] drm/vrr: Set VRR capable prop only if it is attached to connector
@ 2022-02-25 1:30 Manasi Navare
2022-02-25 1:30 ` [Intel-gfx] [PATCH v6 2/2] drm/i915/display/vrr: Reset VRR capable property on a long hpd Manasi Navare
` (4 more replies)
0 siblings, 5 replies; 11+ messages in thread
From: Manasi Navare @ 2022-02-25 1:30 UTC (permalink / raw)
To: intel-gfx; +Cc: Jani Nikula, dri-devel
VRR capable property is not attached by default to the connector
It is attached only if VRR is supported.
So if the driver tries to call drm core set prop function without
it being attached that causes NULL dereference.
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>
---
drivers/gpu/drm/drm_connector.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c
index a50c82bc2b2f..76a8c707c34b 100644
--- a/drivers/gpu/drm/drm_connector.c
+++ b/drivers/gpu/drm/drm_connector.c
@@ -2330,6 +2330,9 @@ EXPORT_SYMBOL(drm_connector_atomic_hdr_metadata_equal);
void drm_connector_set_vrr_capable_property(
struct drm_connector *connector, bool capable)
{
+ if (!connector->vrr_capable_property)
+ return;
+
drm_object_property_set_value(&connector->base,
connector->vrr_capable_property,
capable);
--
2.19.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [Intel-gfx] [PATCH v6 2/2] drm/i915/display/vrr: Reset VRR capable property on a long hpd
2022-02-25 1:30 [Intel-gfx] [PATCH v6 1/2] drm/vrr: Set VRR capable prop only if it is attached to connector Manasi Navare
@ 2022-02-25 1:30 ` Manasi Navare
2022-02-25 9:13 ` Ville Syrjälä
2022-02-25 4:46 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v6,1/2] drm/vrr: Set VRR capable prop only if it is attached to connector Patchwork
` (3 subsequent siblings)
4 siblings, 1 reply; 11+ messages in thread
From: Manasi Navare @ 2022-02-25 1:30 UTC (permalink / raw)
To: intel-gfx; +Cc: Jani Nikula
With some VRR panels, user can turn VRR ON/OFF on the fly from the panel settings.
When VRR is turned OFF ,sends a long HPD to the driver clearing the Ignore MSA bit
in the DPCD. Currently the driver parses that onevery HPD but fails to reset
the corresponding VRR Capable Connector property.
Hence the userspace still sees this as VRR Capable panel which is incorrect.
Fix this by explicitly resetting the connector property.
v2: Reset vrr capable if status == connector_disconnected
v3: Use i915 and use bool vrr_capable (Jani Nikula)
v4: Move vrr_capable to after update modes call (Jani N)
Remove the redundant comment (Jan N)
v5: Fixes the regression on older platforms by reseting the VRR
only if HAS_VRR
v6: Remove the checks from driver, add in drm core before
setting VRR prop (Ville)
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Fixes: 390a1f8beb87 ("Revert "drm/i915/display/vrr: Reset VRR capable property on a long hpd")
Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>
---
drivers/gpu/drm/i915/display/intel_dp.c | 15 +++++++++++----
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index 1046e7fe310a..f96123b56935 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -4455,6 +4455,10 @@ intel_dp_detect(struct drm_connector *connector,
memset(&intel_dp->compliance, 0, sizeof(intel_dp->compliance));
memset(intel_dp->dsc_dpcd, 0, sizeof(intel_dp->dsc_dpcd));
+ /* Reset VRR Capable property on disconnect */
+ drm_connector_set_vrr_capable_property(connector,
+ false);
+
if (intel_dp->is_mst) {
drm_dbg_kms(&dev_priv->drm,
"MST device may have disappeared %d vs %d\n",
@@ -4569,15 +4573,18 @@ static int intel_dp_get_modes(struct drm_connector *connector)
{
struct intel_connector *intel_connector = to_intel_connector(connector);
struct edid *edid;
+ struct drm_i915_private *i915 = to_i915(connector->dev);
int num_modes = 0;
edid = intel_connector->detect_edid;
if (edid) {
- num_modes = intel_connector_update_modes(connector, edid);
+ bool vrr_capable;
- if (intel_vrr_is_capable(connector))
- drm_connector_set_vrr_capable_property(connector,
- true);
+ num_modes = intel_connector_update_modes(connector, edid);
+ vrr_capable = intel_vrr_is_capable(connector);
+ drm_dbg_kms(&i915->drm, "[CONNECTOR:%d:%s] VRR capable: %s\n",
+ connector->base.id, connector->name, yesno(vrr_capable));
+ drm_connector_set_vrr_capable_property(connector, vrr_capable);
}
/* Also add fixed mode, which may or may not be present in EDID */
--
2.19.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v6,1/2] drm/vrr: Set VRR capable prop only if it is attached to connector
2022-02-25 1:30 [Intel-gfx] [PATCH v6 1/2] drm/vrr: Set VRR capable prop only if it is attached to connector Manasi Navare
2022-02-25 1:30 ` [Intel-gfx] [PATCH v6 2/2] drm/i915/display/vrr: Reset VRR capable property on a long hpd Manasi Navare
@ 2022-02-25 4:46 ` Patchwork
2022-02-25 5:18 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
` (2 subsequent siblings)
4 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2022-02-25 4:46 UTC (permalink / raw)
To: Manasi Navare; +Cc: intel-gfx
== Series Details ==
Series: series starting with [v6,1/2] drm/vrr: Set VRR capable prop only if it is attached to connector
URL : https://patchwork.freedesktop.org/series/100712/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
783e65f81a2e drm/vrr: Set VRR capable prop only if it is attached to connector
b22db1344f58 drm/i915/display/vrr: Reset VRR capable property on a long hpd
-:10: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#10:
With some VRR panels, user can turn VRR ON/OFF on the fly from the panel settings.
-:22: WARNING:TYPO_SPELLING: 'reseting' may be misspelled - perhaps 'resetting'?
#22:
v5: Fixes the regression on older platforms by reseting the VRR
^^^^^^^^
total: 0 errors, 2 warnings, 0 checks, 32 lines checked
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v6,1/2] drm/vrr: Set VRR capable prop only if it is attached to connector
2022-02-25 1:30 [Intel-gfx] [PATCH v6 1/2] drm/vrr: Set VRR capable prop only if it is attached to connector Manasi Navare
2022-02-25 1:30 ` [Intel-gfx] [PATCH v6 2/2] drm/i915/display/vrr: Reset VRR capable property on a long hpd Manasi Navare
2022-02-25 4:46 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v6,1/2] drm/vrr: Set VRR capable prop only if it is attached to connector Patchwork
@ 2022-02-25 5:18 ` Patchwork
2022-02-25 9:11 ` [Intel-gfx] [PATCH v6 1/2] " Ville Syrjälä
2022-02-25 21:55 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [v6,1/2] " Patchwork
4 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2022-02-25 5:18 UTC (permalink / raw)
To: Manasi Navare; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 7594 bytes --]
== Series Details ==
Series: series starting with [v6,1/2] drm/vrr: Set VRR capable prop only if it is attached to connector
URL : https://patchwork.freedesktop.org/series/100712/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11285 -> Patchwork_22405
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/index.html
Participating hosts (39 -> 39)
------------------------------
Additional (1): fi-kbl-soraka
Missing (1): fi-bdw-samus
Known issues
------------
Here are the changes found in Patchwork_22405 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_fence@basic-busy@bcs0:
- fi-kbl-soraka: NOTRUN -> [SKIP][1] ([fdo#109271]) +8 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/fi-kbl-soraka/igt@gem_exec_fence@basic-busy@bcs0.html
* igt@gem_exec_suspend@basic-s0@smem:
- fi-glk-dsi: [PASS][2] -> [DMESG-WARN][3] ([i915#2943])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11285/fi-glk-dsi/igt@gem_exec_suspend@basic-s0@smem.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/fi-glk-dsi/igt@gem_exec_suspend@basic-s0@smem.html
* igt@gem_huc_copy@huc-copy:
- fi-skl-6600u: NOTRUN -> [SKIP][4] ([fdo#109271] / [i915#2190])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/fi-skl-6600u/igt@gem_huc_copy@huc-copy.html
- fi-kbl-soraka: NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#2190])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@basic:
- fi-kbl-soraka: NOTRUN -> [SKIP][6] ([fdo#109271] / [i915#4613]) +3 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/fi-kbl-soraka/igt@gem_lmem_swapping@basic.html
* igt@gem_lmem_swapping@verify-random:
- fi-skl-6600u: NOTRUN -> [SKIP][7] ([fdo#109271] / [i915#4613]) +3 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/fi-skl-6600u/igt@gem_lmem_swapping@verify-random.html
* igt@i915_selftest@live:
- fi-skl-6600u: NOTRUN -> [FAIL][8] ([i915#4547])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/fi-skl-6600u/igt@i915_selftest@live.html
* igt@i915_selftest@live@gt_pm:
- fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][9] ([i915#1886] / [i915#2291])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html
* igt@i915_selftest@live@hangcheck:
- fi-snb-2600: [PASS][10] -> [INCOMPLETE][11] ([i915#3921])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11285/fi-snb-2600/igt@i915_selftest@live@hangcheck.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/fi-snb-2600/igt@i915_selftest@live@hangcheck.html
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-kbl-soraka: NOTRUN -> [SKIP][12] ([fdo#109271] / [fdo#111827]) +8 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/fi-kbl-soraka/igt@kms_chamelium@common-hpd-after-suspend.html
* igt@kms_chamelium@vga-edid-read:
- fi-skl-6600u: NOTRUN -> [SKIP][13] ([fdo#109271] / [fdo#111827]) +8 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/fi-skl-6600u/igt@kms_chamelium@vga-edid-read.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- fi-skl-6600u: NOTRUN -> [SKIP][14] ([fdo#109271]) +3 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/fi-skl-6600u/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
* igt@kms_frontbuffer_tracking@basic:
- fi-cfl-8109u: [PASS][15] -> [DMESG-FAIL][16] ([i915#295])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11285/fi-cfl-8109u/igt@kms_frontbuffer_tracking@basic.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/fi-cfl-8109u/igt@kms_frontbuffer_tracking@basic.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b:
- fi-cfl-8109u: [PASS][17] -> [DMESG-WARN][18] ([i915#295]) +10 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11285/fi-cfl-8109u/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/fi-cfl-8109u/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- fi-skl-6600u: NOTRUN -> [SKIP][19] ([fdo#109271] / [i915#533])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/fi-skl-6600u/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
- fi-kbl-soraka: NOTRUN -> [SKIP][20] ([fdo#109271] / [i915#533])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/fi-kbl-soraka/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
#### Possible fixes ####
* igt@kms_flip@basic-flip-vs-modeset@a-edp1:
- {bat-adlp-6}: [DMESG-WARN][21] ([i915#3576]) -> [PASS][22] +1 similar issue
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11285/bat-adlp-6/igt@kms_flip@basic-flip-vs-modeset@a-edp1.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/bat-adlp-6/igt@kms_flip@basic-flip-vs-modeset@a-edp1.html
#### Warnings ####
* igt@runner@aborted:
- fi-skl-6600u: [FAIL][23] ([i915#4312]) -> [FAIL][24] ([i915#1436] / [i915#4312])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11285/fi-skl-6600u/igt@runner@aborted.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/fi-skl-6600u/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2291]: https://gitlab.freedesktop.org/drm/intel/issues/2291
[i915#2943]: https://gitlab.freedesktop.org/drm/intel/issues/2943
[i915#295]: https://gitlab.freedesktop.org/drm/intel/issues/295
[i915#3576]: https://gitlab.freedesktop.org/drm/intel/issues/3576
[i915#3921]: https://gitlab.freedesktop.org/drm/intel/issues/3921
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4547]: https://gitlab.freedesktop.org/drm/intel/issues/4547
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
Build changes
-------------
* Linux: CI_DRM_11285 -> Patchwork_22405
CI-20190529: 20190529
CI_DRM_11285: 937927c7022766ecf991e0071ae055412fb3805f @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6357: 6546304ecf053b9c5ec278ee3c210d2c6d50a3a6 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_22405: b22db1344f58d908849a545f69cd1025f84e8bc3 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
b22db1344f58 drm/i915/display/vrr: Reset VRR capable property on a long hpd
783e65f81a2e drm/vrr: Set VRR capable prop only if it is attached to connector
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/index.html
[-- Attachment #2: Type: text/html, Size: 9627 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [PATCH v6 1/2] drm/vrr: Set VRR capable prop only if it is attached to connector
2022-02-25 1:30 [Intel-gfx] [PATCH v6 1/2] drm/vrr: Set VRR capable prop only if it is attached to connector Manasi Navare
` (2 preceding siblings ...)
2022-02-25 5:18 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2022-02-25 9:11 ` Ville Syrjälä
2022-02-25 21:55 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [v6,1/2] " Patchwork
4 siblings, 0 replies; 11+ messages in thread
From: Ville Syrjälä @ 2022-02-25 9:11 UTC (permalink / raw)
To: Manasi Navare; +Cc: Jani Nikula, intel-gfx, dri-devel
On Thu, Feb 24, 2022 at 05:30:54PM -0800, Manasi Navare wrote:
> VRR capable property is not attached by default to the connector
> It is attached only if VRR is supported.
> So if the driver tries to call drm core set prop function without
> it being attached that causes NULL dereference.
>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/drm_connector.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c
> index a50c82bc2b2f..76a8c707c34b 100644
> --- a/drivers/gpu/drm/drm_connector.c
> +++ b/drivers/gpu/drm/drm_connector.c
> @@ -2330,6 +2330,9 @@ EXPORT_SYMBOL(drm_connector_atomic_hdr_metadata_equal);
> void drm_connector_set_vrr_capable_property(
> struct drm_connector *connector, bool capable)
> {
> + if (!connector->vrr_capable_property)
> + return;
> +
> drm_object_property_set_value(&connector->base,
> connector->vrr_capable_property,
> capable);
> --
> 2.19.1
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [PATCH v6 2/2] drm/i915/display/vrr: Reset VRR capable property on a long hpd
2022-02-25 1:30 ` [Intel-gfx] [PATCH v6 2/2] drm/i915/display/vrr: Reset VRR capable property on a long hpd Manasi Navare
@ 2022-02-25 9:13 ` Ville Syrjälä
2022-02-26 1:11 ` Navare, Manasi
0 siblings, 1 reply; 11+ messages in thread
From: Ville Syrjälä @ 2022-02-25 9:13 UTC (permalink / raw)
To: Manasi Navare; +Cc: Jani Nikula, intel-gfx
On Thu, Feb 24, 2022 at 05:30:55PM -0800, Manasi Navare wrote:
> With some VRR panels, user can turn VRR ON/OFF on the fly from the panel settings.
> When VRR is turned OFF ,sends a long HPD to the driver clearing the Ignore MSA bit
> in the DPCD. Currently the driver parses that onevery HPD but fails to reset
> the corresponding VRR Capable Connector property.
> Hence the userspace still sees this as VRR Capable panel which is incorrect.
>
> Fix this by explicitly resetting the connector property.
>
> v2: Reset vrr capable if status == connector_disconnected
> v3: Use i915 and use bool vrr_capable (Jani Nikula)
> v4: Move vrr_capable to after update modes call (Jani N)
> Remove the redundant comment (Jan N)
> v5: Fixes the regression on older platforms by reseting the VRR
> only if HAS_VRR
> v6: Remove the checks from driver, add in drm core before
> setting VRR prop (Ville)
>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Fixes: 390a1f8beb87 ("Revert "drm/i915/display/vrr: Reset VRR capable property on a long hpd")
> Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dp.c | 15 +++++++++++----
> 1 file changed, 11 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index 1046e7fe310a..f96123b56935 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -4455,6 +4455,10 @@ intel_dp_detect(struct drm_connector *connector,
> memset(&intel_dp->compliance, 0, sizeof(intel_dp->compliance));
> memset(intel_dp->dsc_dpcd, 0, sizeof(intel_dp->dsc_dpcd));
>
> + /* Reset VRR Capable property on disconnect */
> + drm_connector_set_vrr_capable_property(connector,
> + false);
> +
> if (intel_dp->is_mst) {
> drm_dbg_kms(&dev_priv->drm,
> "MST device may have disappeared %d vs %d\n",
> @@ -4569,15 +4573,18 @@ static int intel_dp_get_modes(struct drm_connector *connector)
> {
> struct intel_connector *intel_connector = to_intel_connector(connector);
> struct edid *edid;
> + struct drm_i915_private *i915 = to_i915(connector->dev);
> int num_modes = 0;
>
> edid = intel_connector->detect_edid;
> if (edid) {
> - num_modes = intel_connector_update_modes(connector, edid);
> + bool vrr_capable;
>
> - if (intel_vrr_is_capable(connector))
> - drm_connector_set_vrr_capable_property(connector,
> - true);
> + num_modes = intel_connector_update_modes(connector, edid);
> + vrr_capable = intel_vrr_is_capable(connector);
> + drm_dbg_kms(&i915->drm, "[CONNECTOR:%d:%s] VRR capable: %s\n",
> + connector->base.id, connector->name, yesno(vrr_capable));
> + drm_connector_set_vrr_capable_property(connector, vrr_capable);
As mentioned on irc I think intel_dp_(un)set_edid() would be a better
place for these.
> }
>
> /* Also add fixed mode, which may or may not be present in EDID */
> --
> 2.19.1
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [v6,1/2] drm/vrr: Set VRR capable prop only if it is attached to connector
2022-02-25 1:30 [Intel-gfx] [PATCH v6 1/2] drm/vrr: Set VRR capable prop only if it is attached to connector Manasi Navare
` (3 preceding siblings ...)
2022-02-25 9:11 ` [Intel-gfx] [PATCH v6 1/2] " Ville Syrjälä
@ 2022-02-25 21:55 ` Patchwork
4 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2022-02-25 21:55 UTC (permalink / raw)
To: Manasi Navare; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 30318 bytes --]
== Series Details ==
Series: series starting with [v6,1/2] drm/vrr: Set VRR capable prop only if it is attached to connector
URL : https://patchwork.freedesktop.org/series/100712/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11285_full -> Patchwork_22405_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_22405_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_22405_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Participating hosts (11 -> 11)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_22405_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_ctx_persistence@smoketest:
- shard-skl: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11285/shard-skl9/igt@gem_ctx_persistence@smoketest.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-skl1/igt@gem_ctx_persistence@smoketest.html
* igt@i915_pm_rpm@modeset-non-lpsp-stress:
- shard-kbl: NOTRUN -> [TIMEOUT][3]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-kbl3/igt@i915_pm_rpm@modeset-non-lpsp-stress.html
Known issues
------------
Here are the changes found in Patchwork_22405_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_fair@basic-flow@rcs0:
- shard-skl: NOTRUN -> [SKIP][4] ([fdo#109271]) +107 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-skl9/igt@gem_exec_fair@basic-flow@rcs0.html
* igt@gem_exec_fair@basic-none-rrul@rcs0:
- shard-kbl: NOTRUN -> [FAIL][5] ([i915#2842])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-kbl7/igt@gem_exec_fair@basic-none-rrul@rcs0.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [PASS][6] -> [FAIL][7] ([i915#2842]) +1 similar issue
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11285/shard-glk9/igt@gem_exec_fair@basic-pace-share@rcs0.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-glk3/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-pace@vcs1:
- shard-kbl: [PASS][8] -> [FAIL][9] ([i915#2842]) +1 similar issue
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11285/shard-kbl1/igt@gem_exec_fair@basic-pace@vcs1.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-kbl3/igt@gem_exec_fair@basic-pace@vcs1.html
* igt@gem_exec_schedule@u-submit-golden-slice@vecs0:
- shard-skl: [PASS][10] -> [INCOMPLETE][11] ([i915#3797])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11285/shard-skl9/igt@gem_exec_schedule@u-submit-golden-slice@vecs0.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-skl3/igt@gem_exec_schedule@u-submit-golden-slice@vecs0.html
* igt@gem_huc_copy@huc-copy:
- shard-kbl: NOTRUN -> [SKIP][12] ([fdo#109271] / [i915#2190])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-kbl3/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@heavy-multi:
- shard-apl: NOTRUN -> [SKIP][13] ([fdo#109271] / [i915#4613]) +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-apl1/igt@gem_lmem_swapping@heavy-multi.html
* igt@gem_lmem_swapping@heavy-verify-multi:
- shard-skl: NOTRUN -> [SKIP][14] ([fdo#109271] / [i915#4613])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-skl9/igt@gem_lmem_swapping@heavy-verify-multi.html
* igt@gem_lmem_swapping@parallel-random:
- shard-kbl: NOTRUN -> [SKIP][15] ([fdo#109271] / [i915#4613]) +1 similar issue
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-kbl4/igt@gem_lmem_swapping@parallel-random.html
* igt@gem_pread@exhaustion:
- shard-apl: NOTRUN -> [WARN][16] ([i915#2658])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-apl3/igt@gem_pread@exhaustion.html
- shard-kbl: NOTRUN -> [WARN][17] ([i915#2658])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-kbl4/igt@gem_pread@exhaustion.html
* igt@gem_pwrite@basic-exhaustion:
- shard-skl: NOTRUN -> [WARN][18] ([i915#2658])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-skl9/igt@gem_pwrite@basic-exhaustion.html
* igt@gen9_exec_parse@bb-start-out:
- shard-iclb: NOTRUN -> [SKIP][19] ([i915#2856])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-iclb6/igt@gen9_exec_parse@bb-start-out.html
* igt@i915_pm_rpm@system-suspend:
- shard-skl: [PASS][20] -> [INCOMPLETE][21] ([i915#151])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11285/shard-skl4/igt@i915_pm_rpm@system-suspend.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-skl9/igt@i915_pm_rpm@system-suspend.html
* igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-hflip:
- shard-kbl: NOTRUN -> [SKIP][22] ([fdo#109271] / [i915#3777]) +2 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-kbl3/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-hflip.html
* igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip:
- shard-apl: NOTRUN -> [SKIP][23] ([fdo#109271] / [i915#3777]) +2 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-apl1/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip.html
* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-async-flip:
- shard-skl: NOTRUN -> [FAIL][24] ([i915#3763])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-skl10/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-async-flip.html
* igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-hflip:
- shard-skl: NOTRUN -> [SKIP][25] ([fdo#109271] / [i915#3777])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-skl10/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-hflip.html
* igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][26] ([fdo#109271] / [i915#3886]) +4 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-apl1/igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc:
- shard-skl: NOTRUN -> [SKIP][27] ([fdo#109271] / [i915#3886]) +3 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-skl9/igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_mc_ccs:
- shard-kbl: NOTRUN -> [SKIP][28] ([fdo#109271] / [i915#3886]) +6 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-kbl3/igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_mc_ccs.html
* igt@kms_chamelium@vga-hpd-for-each-pipe:
- shard-apl: NOTRUN -> [SKIP][29] ([fdo#109271] / [fdo#111827]) +5 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-apl3/igt@kms_chamelium@vga-hpd-for-each-pipe.html
* igt@kms_chamelium@vga-hpd-without-ddc:
- shard-kbl: NOTRUN -> [SKIP][30] ([fdo#109271] / [fdo#111827]) +10 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-kbl3/igt@kms_chamelium@vga-hpd-without-ddc.html
* igt@kms_color_chamelium@pipe-b-ctm-0-25:
- shard-skl: NOTRUN -> [SKIP][31] ([fdo#109271] / [fdo#111827]) +5 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-skl6/igt@kms_color_chamelium@pipe-b-ctm-0-25.html
* igt@kms_color_chamelium@pipe-c-ctm-green-to-red:
- shard-iclb: NOTRUN -> [SKIP][32] ([fdo#109284] / [fdo#111827])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-iclb6/igt@kms_color_chamelium@pipe-c-ctm-green-to-red.html
* igt@kms_content_protection@lic:
- shard-kbl: NOTRUN -> [TIMEOUT][33] ([i915#1319])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-kbl3/igt@kms_content_protection@lic.html
* igt@kms_content_protection@srm:
- shard-iclb: NOTRUN -> [SKIP][34] ([fdo#109300] / [fdo#111066])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-iclb6/igt@kms_content_protection@srm.html
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-kbl: NOTRUN -> [DMESG-WARN][35] ([i915#180])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-kbl4/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
* igt@kms_cursor_crc@pipe-b-cursor-512x170-rapid-movement:
- shard-tglb: NOTRUN -> [SKIP][36] ([i915#3359])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-tglb2/igt@kms_cursor_crc@pipe-b-cursor-512x170-rapid-movement.html
* igt@kms_cursor_crc@pipe-b-cursor-suspend:
- shard-apl: [PASS][37] -> [DMESG-WARN][38] ([i915#180]) +3 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11285/shard-apl7/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-apl4/igt@kms_cursor_crc@pipe-b-cursor-suspend.html
* igt@kms_cursor_crc@pipe-d-cursor-256x256-onscreen:
- shard-kbl: NOTRUN -> [SKIP][39] ([fdo#109271]) +131 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-kbl4/igt@kms_cursor_crc@pipe-d-cursor-256x256-onscreen.html
* igt@kms_cursor_edge_walk@pipe-a-128x128-top-edge:
- shard-skl: NOTRUN -> [DMESG-WARN][40] ([i915#1982])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-skl9/igt@kms_cursor_edge_walk@pipe-a-128x128-top-edge.html
* igt@kms_cursor_legacy@cursorb-vs-flipa-atomic:
- shard-iclb: NOTRUN -> [SKIP][41] ([fdo#109274] / [fdo#109278])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-iclb6/igt@kms_cursor_legacy@cursorb-vs-flipa-atomic.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-skl: [PASS][42] -> [FAIL][43] ([i915#2346])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11285/shard-skl7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-skl1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-skl: [PASS][44] -> [FAIL][45] ([i915#2346] / [i915#533])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11285/shard-skl6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-skl6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_flip@2x-flip-vs-panning:
- shard-apl: NOTRUN -> [SKIP][46] ([fdo#109271]) +82 similar issues
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-apl1/igt@kms_flip@2x-flip-vs-panning.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile-downscaling:
- shard-iclb: [PASS][47] -> [SKIP][48] ([i915#3701])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11285/shard-iclb4/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile-downscaling.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile-downscaling.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-indfb-draw-mmap-cpu:
- shard-iclb: NOTRUN -> [SKIP][49] ([fdo#109280]) +2 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-iclb6/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-pri-indfb-draw-mmap-cpu.html
* igt@kms_frontbuffer_tracking@psr-suspend:
- shard-skl: [PASS][50] -> [INCOMPLETE][51] ([i915#123])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11285/shard-skl4/igt@kms_frontbuffer_tracking@psr-suspend.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-skl1/igt@kms_frontbuffer_tracking@psr-suspend.html
* igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-d:
- shard-skl: NOTRUN -> [SKIP][52] ([fdo#109271] / [i915#533])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-skl6/igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-d.html
* igt@kms_plane@plane-panning-bottom-right-suspend@pipe-b-planes:
- shard-kbl: [PASS][53] -> [DMESG-WARN][54] ([i915#180]) +6 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11285/shard-kbl3/igt@kms_plane@plane-panning-bottom-right-suspend@pipe-b-planes.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-kbl7/igt@kms_plane@plane-panning-bottom-right-suspend@pipe-b-planes.html
* igt@kms_plane_alpha_blend@pipe-a-alpha-7efc:
- shard-skl: NOTRUN -> [FAIL][55] ([fdo#108145] / [i915#265]) +1 similar issue
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-skl9/igt@kms_plane_alpha_blend@pipe-a-alpha-7efc.html
* igt@kms_plane_alpha_blend@pipe-b-alpha-7efc:
- shard-kbl: NOTRUN -> [FAIL][56] ([fdo#108145] / [i915#265]) +1 similar issue
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-kbl4/igt@kms_plane_alpha_blend@pipe-b-alpha-7efc.html
* igt@kms_plane_alpha_blend@pipe-b-alpha-basic:
- shard-apl: NOTRUN -> [FAIL][57] ([fdo#108145] / [i915#265]) +1 similar issue
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-apl1/igt@kms_plane_alpha_blend@pipe-b-alpha-basic.html
* igt@kms_plane_alpha_blend@pipe-d-alpha-opaque-fb:
- shard-iclb: NOTRUN -> [SKIP][58] ([fdo#109278])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-iclb6/igt@kms_plane_alpha_blend@pipe-d-alpha-opaque-fb.html
* igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping:
- shard-kbl: NOTRUN -> [SKIP][59] ([fdo#109271] / [i915#2733])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-kbl3/igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping.html
* igt@kms_psr2_sf@cursor-plane-update-sf:
- shard-skl: NOTRUN -> [SKIP][60] ([fdo#109271] / [i915#658]) +1 similar issue
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-skl9/igt@kms_psr2_sf@cursor-plane-update-sf.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area:
- shard-apl: NOTRUN -> [SKIP][61] ([fdo#109271] / [i915#658]) +2 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-apl3/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area.html
- shard-kbl: NOTRUN -> [SKIP][62] ([fdo#109271] / [i915#658])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-kbl4/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area.html
* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [PASS][63] -> [SKIP][64] ([fdo#109441]) +2 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11285/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-iclb1/igt@kms_psr@psr2_cursor_render.html
* igt@kms_setmode@basic:
- shard-apl: [PASS][65] -> [FAIL][66] ([i915#31])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11285/shard-apl4/igt@kms_setmode@basic.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-apl1/igt@kms_setmode@basic.html
* igt@kms_vblank@pipe-d-wait-idle:
- shard-kbl: NOTRUN -> [SKIP][67] ([fdo#109271] / [i915#533]) +1 similar issue
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-kbl4/igt@kms_vblank@pipe-d-wait-idle.html
- shard-apl: NOTRUN -> [SKIP][68] ([fdo#109271] / [i915#533])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-apl3/igt@kms_vblank@pipe-d-wait-idle.html
* igt@kms_writeback@writeback-pixel-formats:
- shard-skl: NOTRUN -> [SKIP][69] ([fdo#109271] / [i915#2437])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-skl6/igt@kms_writeback@writeback-pixel-formats.html
* igt@perf@polling-parameterized:
- shard-skl: NOTRUN -> [FAIL][70] ([i915#1542])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-skl9/igt@perf@polling-parameterized.html
* igt@sysfs_clients@create:
- shard-apl: NOTRUN -> [SKIP][71] ([fdo#109271] / [i915#2994]) +2 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-apl3/igt@sysfs_clients@create.html
- shard-kbl: NOTRUN -> [SKIP][72] ([fdo#109271] / [i915#2994]) +1 similar issue
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-kbl4/igt@sysfs_clients@create.html
#### Possible fixes ####
* igt@gem_exec_balancer@parallel-balancer:
- shard-iclb: [SKIP][73] ([i915#4525]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11285/shard-iclb7/igt@gem_exec_balancer@parallel-balancer.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-iclb4/igt@gem_exec_balancer@parallel-balancer.html
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-iclb: [FAIL][75] ([i915#2842]) -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11285/shard-iclb4/igt@gem_exec_fair@basic-none-share@rcs0.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-iclb4/igt@gem_exec_fair@basic-none-share@rcs0.html
* igt@gem_exec_suspend@basic-s3@smem:
- shard-snb: [SKIP][77] ([fdo#109271]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11285/shard-snb6/igt@gem_exec_suspend@basic-s3@smem.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-snb2/igt@gem_exec_suspend@basic-s3@smem.html
* igt@gem_exec_whisper@basic-forked:
- shard-glk: [DMESG-WARN][79] ([i915#118]) -> [PASS][80]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11285/shard-glk7/igt@gem_exec_whisper@basic-forked.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-glk5/igt@gem_exec_whisper@basic-forked.html
* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [FAIL][81] ([i915#454]) -> [PASS][82]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11285/shard-iclb3/igt@i915_pm_dc@dc6-psr.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-iclb6/igt@i915_pm_dc@dc6-psr.html
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-apl: [INCOMPLETE][83] ([i915#180]) -> [PASS][84]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11285/shard-apl8/igt@kms_fbcon_fbt@fbc-suspend.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-apl1/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@ac-hdmi-a1-hdmi-a2:
- shard-glk: [FAIL][85] ([i915#2122]) -> [PASS][86]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11285/shard-glk3/igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@ac-hdmi-a1-hdmi-a2.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-glk7/igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@ac-hdmi-a1-hdmi-a2.html
* igt@kms_flip@flip-vs-suspend@a-dp1:
- shard-apl: [DMESG-WARN][87] ([i915#180]) -> [PASS][88] +1 similar issue
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11285/shard-apl2/igt@kms_flip@flip-vs-suspend@a-dp1.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-apl8/igt@kms_flip@flip-vs-suspend@a-dp1.html
* igt@kms_flip@plain-flip-fb-recreate@b-edp1:
- shard-skl: [FAIL][89] ([i915#2122]) -> [PASS][90]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11285/shard-skl3/igt@kms_flip@plain-flip-fb-recreate@b-edp1.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-skl10/igt@kms_flip@plain-flip-fb-recreate@b-edp1.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-upscaling:
- shard-glk: [FAIL][91] ([i915#4911]) -> [PASS][92]
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11285/shard-glk8/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-upscaling.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-glk2/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-upscaling.html
* igt@kms_hdr@bpc-switch-suspend:
- shard-kbl: [DMESG-WARN][93] ([i915#180]) -> [PASS][94] +5 similar issues
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11285/shard-kbl1/igt@kms_hdr@bpc-switch-suspend.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-kbl4/igt@kms_hdr@bpc-switch-suspend.html
- shard-skl: [FAIL][95] ([i915#1188]) -> [PASS][96] +1 similar issue
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11285/shard-skl4/igt@kms_hdr@bpc-switch-suspend.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-skl8/igt@kms_hdr@bpc-switch-suspend.html
* igt@kms_plane_lowres@pipe-a-tiling-x:
- {shard-tglu}: [FAIL][97] ([i915#3957]) -> [PASS][98]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11285/shard-tglu-1/igt@kms_plane_lowres@pipe-a-tiling-x.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-tglu-2/igt@kms_plane_lowres@pipe-a-tiling-x.html
* {igt@kms_plane_scaling@upscale-with-rotation-factor-4@pipe-a-upscale-with-rotation}:
- shard-skl: [DMESG-WARN][99] ([i915#1982]) -> [PASS][100]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11285/shard-skl6/igt@kms_plane_scaling@upscale-with-rotation-factor-4@pipe-a-upscale-with-rotation.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-skl3/igt@kms_plane_scaling@upscale-with-rotation-factor-4@pipe-a-upscale-with-rotation.html
* igt@kms_setmode@basic:
- shard-glk: [FAIL][101] ([i915#31]) -> [PASS][102]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11285/shard-glk2/igt@kms_setmode@basic.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-glk6/igt@kms_setmode@basic.html
* igt@perf@polling-small-buf:
- shard-skl: [FAIL][103] ([i915#1722]) -> [PASS][104]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11285/shard-skl9/igt@perf@polling-small-buf.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-skl1/igt@perf@polling-small-buf.html
#### Warnings ####
* igt@gem_exec_balancer@parallel-keep-in-fence:
- shard-iclb: [SKIP][105] ([i915#4525]) -> [DMESG-WARN][106] ([i915#5076]) +1 similar issue
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11285/shard-iclb7/igt@gem_exec_balancer@parallel-keep-in-fence.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-iclb4/igt@gem_exec_balancer@parallel-keep-in-fence.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area:
- shard-iclb: [SKIP][107] ([fdo#111068] / [i915#658]) -> [SKIP][108] ([i915#2920]) +1 similar issue
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11285/shard-iclb4/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area.html
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-iclb2/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area.html
* igt@runner@aborted:
- shard-apl: ([FAIL][109], [FAIL][110], [FAIL][111], [FAIL][112], [FAIL][113], [FAIL][114]) ([i915#180] / [i915#2426] / [i915#3002] / [i915#4312]) -> ([FAIL][115], [FAIL][116], [FAIL][117], [FAIL][118], [FAIL][119], [FAIL][120], [FAIL][121]) ([fdo#109271] / [i915#180] / [i915#1814] / [i915#2426] / [i915#3002] / [i915#4312])
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11285/shard-apl2/igt@runner@aborted.html
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11285/shard-apl6/igt@runner@aborted.html
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11285/shard-apl1/igt@runner@aborted.html
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11285/shard-apl8/igt@runner@aborted.html
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11285/shard-apl8/igt@runner@aborted.html
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11285/shard-apl6/igt@runner@aborted.html
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-apl8/igt@runner@aborted.html
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-apl8/igt@runner@aborted.html
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-apl2/igt@runner@aborted.html
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-apl4/igt@runner@aborted.html
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-apl6/igt@runner@aborted.html
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-apl6/igt@runner@aborted.html
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-apl4/igt@runner@aborted.html
- shard-kbl: ([FAIL][122], [FAIL][123], [FAIL][124], [FAIL][125], [FAIL][126], [FAIL][127], [FAIL][128], [FAIL][129], [FAIL][130], [FAIL][131], [FAIL][132], [FAIL][133], [FAIL][134], [FAIL][135], [FAIL][136], [FAIL][137], [FAIL][138], [FAIL][139]) ([i915#1436] / [i915#180] / [i915#1814] / [i915#2426] / [i915#3002] / [i915#4312] / [i915#92]) -> ([FAIL][140], [FAIL][141], [FAIL][142], [FAIL][143], [FAIL][144], [FAIL][145], [FAIL][146], [FAIL][147], [FAIL][148], [FAIL][149], [FAIL][150], [FAIL][151], [FAIL][152], [FAIL][153], [FAIL][154], [FAIL][155]) ([i915#1436] / [i915#180] / [i915#1814] / [i915#2426] / [i915#4312] / [i915#602] / [i915#92])
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11285/shard-kbl3/igt@runner@aborted.html
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11285/shard-kbl1/igt@runner@aborted.html
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11285/shard-kbl1/igt@runner@aborted.html
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11285/shard-kbl3/igt@runner@aborted.html
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11285/shard-kbl1/igt@runner@aborted.html
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11285/shard-kbl3/igt@runner@aborted.html
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11285/shard-kbl4/igt@runner@aborted.html
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11285/shard-kbl1/igt@runner@aborted.html
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11285/shard-kbl3/igt@runner@aborted.html
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11285/shard-kbl1/igt@runner@aborted.html
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11285/shard-kbl3/igt@runner@aborted.html
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11285/shard-kbl4/igt@runner@aborted.html
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11285/shard-kbl6/igt@runner@aborted.html
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11285/shard-kbl6/igt@runner@aborted.html
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11285/shard-kbl4/igt@runner@aborted.html
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11285/shard-kbl6/igt@runner@aborted.html
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11285/shard-kbl7/igt@runner@aborted.html
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11285/shard-kbl6/igt@runner@aborted.html
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-kbl6/igt@runner@aborted.html
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-kbl4/igt@runner@aborted.html
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-kbl7/igt@runner@aborted.html
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-kbl6/igt@runner@aborted.html
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-kbl7/igt@runner@aborted.html
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-kbl1/igt@runner@aborted.html
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-kbl7/igt@runner@aborted.html
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-kbl1/igt@runner@aborted.html
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-kbl7/igt@runner@aborted.html
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-kbl1/igt@runner@aborted.html
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-kbl1/igt@runner@aborted.html
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-kbl1/igt@runner@aborted.html
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-kbl6/igt@runner@aborted.html
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-kbl6/igt@runner@aborted.html
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-kbl1/igt@runner@aborted.html
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/shard-kbl4/igt@runner@aborted.html
- shard-skl: ([FAIL][156], [FAIL][157], [FAIL][158], [FAIL][159], [FAIL][160]) ([i915#1436] / [i915#2029] / [i915#2426] / [i915#3002] / [i915#4312]) -> ([FAIL][161], [FAIL][162], [FAIL][163], [FAIL][164]) ([i915#1436] / [i915#1814] / [i915#2029]
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22405/index.html
[-- Attachment #2: Type: text/html, Size: 33500 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [PATCH v6 2/2] drm/i915/display/vrr: Reset VRR capable property on a long hpd
2022-02-25 9:13 ` Ville Syrjälä
@ 2022-02-26 1:11 ` Navare, Manasi
2022-03-01 19:30 ` Navare, Manasi
0 siblings, 1 reply; 11+ messages in thread
From: Navare, Manasi @ 2022-02-26 1:11 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: Jani Nikula, intel-gfx
On Fri, Feb 25, 2022 at 11:13:35AM +0200, Ville Syrjälä wrote:
> On Thu, Feb 24, 2022 at 05:30:55PM -0800, Manasi Navare wrote:
> > With some VRR panels, user can turn VRR ON/OFF on the fly from the panel settings.
> > When VRR is turned OFF ,sends a long HPD to the driver clearing the Ignore MSA bit
> > in the DPCD. Currently the driver parses that onevery HPD but fails to reset
> > the corresponding VRR Capable Connector property.
> > Hence the userspace still sees this as VRR Capable panel which is incorrect.
> >
> > Fix this by explicitly resetting the connector property.
> >
> > v2: Reset vrr capable if status == connector_disconnected
> > v3: Use i915 and use bool vrr_capable (Jani Nikula)
> > v4: Move vrr_capable to after update modes call (Jani N)
> > Remove the redundant comment (Jan N)
> > v5: Fixes the regression on older platforms by reseting the VRR
> > only if HAS_VRR
> > v6: Remove the checks from driver, add in drm core before
> > setting VRR prop (Ville)
> >
> > Cc: Jani Nikula <jani.nikula@intel.com>
> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Fixes: 390a1f8beb87 ("Revert "drm/i915/display/vrr: Reset VRR capable property on a long hpd")
> > Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>
> > ---
> > drivers/gpu/drm/i915/display/intel_dp.c | 15 +++++++++++----
> > 1 file changed, 11 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> > index 1046e7fe310a..f96123b56935 100644
> > --- a/drivers/gpu/drm/i915/display/intel_dp.c
> > +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> > @@ -4455,6 +4455,10 @@ intel_dp_detect(struct drm_connector *connector,
> > memset(&intel_dp->compliance, 0, sizeof(intel_dp->compliance));
> > memset(intel_dp->dsc_dpcd, 0, sizeof(intel_dp->dsc_dpcd));
> >
> > + /* Reset VRR Capable property on disconnect */
> > + drm_connector_set_vrr_capable_property(connector,
> > + false);
> > +
> > if (intel_dp->is_mst) {
> > drm_dbg_kms(&dev_priv->drm,
> > "MST device may have disappeared %d vs %d\n",
> > @@ -4569,15 +4573,18 @@ static int intel_dp_get_modes(struct drm_connector *connector)
> > {
> > struct intel_connector *intel_connector = to_intel_connector(connector);
> > struct edid *edid;
> > + struct drm_i915_private *i915 = to_i915(connector->dev);
> > int num_modes = 0;
> >
> > edid = intel_connector->detect_edid;
> > if (edid) {
> > - num_modes = intel_connector_update_modes(connector, edid);
> > + bool vrr_capable;
> >
> > - if (intel_vrr_is_capable(connector))
> > - drm_connector_set_vrr_capable_property(connector,
> > - true);
> > + num_modes = intel_connector_update_modes(connector, edid);
> > + vrr_capable = intel_vrr_is_capable(connector);
> > + drm_dbg_kms(&i915->drm, "[CONNECTOR:%d:%s] VRR capable: %s\n",
> > + connector->base.id, connector->name, yesno(vrr_capable));
> > + drm_connector_set_vrr_capable_property(connector, vrr_capable);
>
> As mentioned on irc I think intel_dp_(un)set_edid() would be a better
> place for these.
Yes I guess I can add the above to check for vrr_capable and set it to true/false in intel_dp_set_edid()
But the resetting part needs to happen outside of intel_dp_unset_edid so that we dont always set it to false
before set_edid. It can just stay in intel_dp_detect where we clear other othing on connect status == disconnected.
Is that fine?
Manasi
>
> > }
> >
> > /* Also add fixed mode, which may or may not be present in EDID */
> > --
> > 2.19.1
>
> --
> Ville Syrjälä
> Intel
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [PATCH v6 2/2] drm/i915/display/vrr: Reset VRR capable property on a long hpd
2022-02-26 1:11 ` Navare, Manasi
@ 2022-03-01 19:30 ` Navare, Manasi
2022-03-01 19:34 ` Ville Syrjälä
0 siblings, 1 reply; 11+ messages in thread
From: Navare, Manasi @ 2022-03-01 19:30 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: Jani Nikula, intel-gfx
Hi Ville,
Does it make sense to add the set prop in intel_dp_Set_edid but keep the reset to false
in intel_dp_detect where we clear other parameters?
Manasi
On Fri, Feb 25, 2022 at 05:11:02PM -0800, Navare, Manasi wrote:
> On Fri, Feb 25, 2022 at 11:13:35AM +0200, Ville Syrjälä wrote:
> > On Thu, Feb 24, 2022 at 05:30:55PM -0800, Manasi Navare wrote:
> > > With some VRR panels, user can turn VRR ON/OFF on the fly from the panel settings.
> > > When VRR is turned OFF ,sends a long HPD to the driver clearing the Ignore MSA bit
> > > in the DPCD. Currently the driver parses that onevery HPD but fails to reset
> > > the corresponding VRR Capable Connector property.
> > > Hence the userspace still sees this as VRR Capable panel which is incorrect.
> > >
> > > Fix this by explicitly resetting the connector property.
> > >
> > > v2: Reset vrr capable if status == connector_disconnected
> > > v3: Use i915 and use bool vrr_capable (Jani Nikula)
> > > v4: Move vrr_capable to after update modes call (Jani N)
> > > Remove the redundant comment (Jan N)
> > > v5: Fixes the regression on older platforms by reseting the VRR
> > > only if HAS_VRR
> > > v6: Remove the checks from driver, add in drm core before
> > > setting VRR prop (Ville)
> > >
> > > Cc: Jani Nikula <jani.nikula@intel.com>
> > > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > Fixes: 390a1f8beb87 ("Revert "drm/i915/display/vrr: Reset VRR capable property on a long hpd")
> > > Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>
> > > ---
> > > drivers/gpu/drm/i915/display/intel_dp.c | 15 +++++++++++----
> > > 1 file changed, 11 insertions(+), 4 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> > > index 1046e7fe310a..f96123b56935 100644
> > > --- a/drivers/gpu/drm/i915/display/intel_dp.c
> > > +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> > > @@ -4455,6 +4455,10 @@ intel_dp_detect(struct drm_connector *connector,
> > > memset(&intel_dp->compliance, 0, sizeof(intel_dp->compliance));
> > > memset(intel_dp->dsc_dpcd, 0, sizeof(intel_dp->dsc_dpcd));
> > >
> > > + /* Reset VRR Capable property on disconnect */
> > > + drm_connector_set_vrr_capable_property(connector,
> > > + false);
> > > +
> > > if (intel_dp->is_mst) {
> > > drm_dbg_kms(&dev_priv->drm,
> > > "MST device may have disappeared %d vs %d\n",
> > > @@ -4569,15 +4573,18 @@ static int intel_dp_get_modes(struct drm_connector *connector)
> > > {
> > > struct intel_connector *intel_connector = to_intel_connector(connector);
> > > struct edid *edid;
> > > + struct drm_i915_private *i915 = to_i915(connector->dev);
> > > int num_modes = 0;
> > >
> > > edid = intel_connector->detect_edid;
> > > if (edid) {
> > > - num_modes = intel_connector_update_modes(connector, edid);
> > > + bool vrr_capable;
> > >
> > > - if (intel_vrr_is_capable(connector))
> > > - drm_connector_set_vrr_capable_property(connector,
> > > - true);
> > > + num_modes = intel_connector_update_modes(connector, edid);
> > > + vrr_capable = intel_vrr_is_capable(connector);
> > > + drm_dbg_kms(&i915->drm, "[CONNECTOR:%d:%s] VRR capable: %s\n",
> > > + connector->base.id, connector->name, yesno(vrr_capable));
> > > + drm_connector_set_vrr_capable_property(connector, vrr_capable);
> >
> > As mentioned on irc I think intel_dp_(un)set_edid() would be a better
> > place for these.
>
> Yes I guess I can add the above to check for vrr_capable and set it to true/false in intel_dp_set_edid()
>
> But the resetting part needs to happen outside of intel_dp_unset_edid so that we dont always set it to false
> before set_edid. It can just stay in intel_dp_detect where we clear other othing on connect status == disconnected.
> Is that fine?
>
> Manasi
>
> >
> > > }
> > >
> > > /* Also add fixed mode, which may or may not be present in EDID */
> > > --
> > > 2.19.1
> >
> > --
> > Ville Syrjälä
> > Intel
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [PATCH v6 2/2] drm/i915/display/vrr: Reset VRR capable property on a long hpd
2022-03-01 19:30 ` Navare, Manasi
@ 2022-03-01 19:34 ` Ville Syrjälä
2022-03-01 23:27 ` Navare, Manasi
0 siblings, 1 reply; 11+ messages in thread
From: Ville Syrjälä @ 2022-03-01 19:34 UTC (permalink / raw)
To: Navare, Manasi; +Cc: Jani Nikula, intel-gfx
On Tue, Mar 01, 2022 at 11:30:52AM -0800, Navare, Manasi wrote:
> Hi Ville,
>
> Does it make sense to add the set prop in intel_dp_Set_edid but keep the reset to false
> in intel_dp_detect where we clear other parameters?
We don't clear stuff in .detect(), or at least shouldn't. .detect() doesn't
even get run when forcing the connector status.
>
> Manasi
>
>
> On Fri, Feb 25, 2022 at 05:11:02PM -0800, Navare, Manasi wrote:
> > On Fri, Feb 25, 2022 at 11:13:35AM +0200, Ville Syrjälä wrote:
> > > On Thu, Feb 24, 2022 at 05:30:55PM -0800, Manasi Navare wrote:
> > > > With some VRR panels, user can turn VRR ON/OFF on the fly from the panel settings.
> > > > When VRR is turned OFF ,sends a long HPD to the driver clearing the Ignore MSA bit
> > > > in the DPCD. Currently the driver parses that onevery HPD but fails to reset
> > > > the corresponding VRR Capable Connector property.
> > > > Hence the userspace still sees this as VRR Capable panel which is incorrect.
> > > >
> > > > Fix this by explicitly resetting the connector property.
> > > >
> > > > v2: Reset vrr capable if status == connector_disconnected
> > > > v3: Use i915 and use bool vrr_capable (Jani Nikula)
> > > > v4: Move vrr_capable to after update modes call (Jani N)
> > > > Remove the redundant comment (Jan N)
> > > > v5: Fixes the regression on older platforms by reseting the VRR
> > > > only if HAS_VRR
> > > > v6: Remove the checks from driver, add in drm core before
> > > > setting VRR prop (Ville)
> > > >
> > > > Cc: Jani Nikula <jani.nikula@intel.com>
> > > > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > > Fixes: 390a1f8beb87 ("Revert "drm/i915/display/vrr: Reset VRR capable property on a long hpd")
> > > > Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>
> > > > ---
> > > > drivers/gpu/drm/i915/display/intel_dp.c | 15 +++++++++++----
> > > > 1 file changed, 11 insertions(+), 4 deletions(-)
> > > >
> > > > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> > > > index 1046e7fe310a..f96123b56935 100644
> > > > --- a/drivers/gpu/drm/i915/display/intel_dp.c
> > > > +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> > > > @@ -4455,6 +4455,10 @@ intel_dp_detect(struct drm_connector *connector,
> > > > memset(&intel_dp->compliance, 0, sizeof(intel_dp->compliance));
> > > > memset(intel_dp->dsc_dpcd, 0, sizeof(intel_dp->dsc_dpcd));
> > > >
> > > > + /* Reset VRR Capable property on disconnect */
> > > > + drm_connector_set_vrr_capable_property(connector,
> > > > + false);
> > > > +
> > > > if (intel_dp->is_mst) {
> > > > drm_dbg_kms(&dev_priv->drm,
> > > > "MST device may have disappeared %d vs %d\n",
> > > > @@ -4569,15 +4573,18 @@ static int intel_dp_get_modes(struct drm_connector *connector)
> > > > {
> > > > struct intel_connector *intel_connector = to_intel_connector(connector);
> > > > struct edid *edid;
> > > > + struct drm_i915_private *i915 = to_i915(connector->dev);
> > > > int num_modes = 0;
> > > >
> > > > edid = intel_connector->detect_edid;
> > > > if (edid) {
> > > > - num_modes = intel_connector_update_modes(connector, edid);
> > > > + bool vrr_capable;
> > > >
> > > > - if (intel_vrr_is_capable(connector))
> > > > - drm_connector_set_vrr_capable_property(connector,
> > > > - true);
> > > > + num_modes = intel_connector_update_modes(connector, edid);
> > > > + vrr_capable = intel_vrr_is_capable(connector);
> > > > + drm_dbg_kms(&i915->drm, "[CONNECTOR:%d:%s] VRR capable: %s\n",
> > > > + connector->base.id, connector->name, yesno(vrr_capable));
> > > > + drm_connector_set_vrr_capable_property(connector, vrr_capable);
> > >
> > > As mentioned on irc I think intel_dp_(un)set_edid() would be a better
> > > place for these.
> >
> > Yes I guess I can add the above to check for vrr_capable and set it to true/false in intel_dp_set_edid()
> >
> > But the resetting part needs to happen outside of intel_dp_unset_edid so that we dont always set it to false
> > before set_edid. It can just stay in intel_dp_detect where we clear other othing on connect status == disconnected.
> > Is that fine?
> >
> > Manasi
> >
> > >
> > > > }
> > > >
> > > > /* Also add fixed mode, which may or may not be present in EDID */
> > > > --
> > > > 2.19.1
> > >
> > > --
> > > Ville Syrjälä
> > > Intel
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [PATCH v6 2/2] drm/i915/display/vrr: Reset VRR capable property on a long hpd
2022-03-01 19:34 ` Ville Syrjälä
@ 2022-03-01 23:27 ` Navare, Manasi
0 siblings, 0 replies; 11+ messages in thread
From: Navare, Manasi @ 2022-03-01 23:27 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: Jani Nikula, intel-gfx
On Tue, Mar 01, 2022 at 09:34:54PM +0200, Ville Syrjälä wrote:
> On Tue, Mar 01, 2022 at 11:30:52AM -0800, Navare, Manasi wrote:
> > Hi Ville,
> >
> > Does it make sense to add the set prop in intel_dp_Set_edid but keep the reset to false
> > in intel_dp_detect where we clear other parameters?
>
> We don't clear stuff in .detect(), or at least shouldn't. .detect() doesn't
> even get run when forcing the connector status.
Well we do clear some compliance variables there.
But okay I can move the VRR rest stuff in intel_dp_unset_edid(), just that this will also
get called evertime we set edid, it will always clear this first.
Manasi
>
> >
> > Manasi
> >
> >
> > On Fri, Feb 25, 2022 at 05:11:02PM -0800, Navare, Manasi wrote:
> > > On Fri, Feb 25, 2022 at 11:13:35AM +0200, Ville Syrjälä wrote:
> > > > On Thu, Feb 24, 2022 at 05:30:55PM -0800, Manasi Navare wrote:
> > > > > With some VRR panels, user can turn VRR ON/OFF on the fly from the panel settings.
> > > > > When VRR is turned OFF ,sends a long HPD to the driver clearing the Ignore MSA bit
> > > > > in the DPCD. Currently the driver parses that onevery HPD but fails to reset
> > > > > the corresponding VRR Capable Connector property.
> > > > > Hence the userspace still sees this as VRR Capable panel which is incorrect.
> > > > >
> > > > > Fix this by explicitly resetting the connector property.
> > > > >
> > > > > v2: Reset vrr capable if status == connector_disconnected
> > > > > v3: Use i915 and use bool vrr_capable (Jani Nikula)
> > > > > v4: Move vrr_capable to after update modes call (Jani N)
> > > > > Remove the redundant comment (Jan N)
> > > > > v5: Fixes the regression on older platforms by reseting the VRR
> > > > > only if HAS_VRR
> > > > > v6: Remove the checks from driver, add in drm core before
> > > > > setting VRR prop (Ville)
> > > > >
> > > > > Cc: Jani Nikula <jani.nikula@intel.com>
> > > > > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > > > Fixes: 390a1f8beb87 ("Revert "drm/i915/display/vrr: Reset VRR capable property on a long hpd")
> > > > > Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>
> > > > > ---
> > > > > drivers/gpu/drm/i915/display/intel_dp.c | 15 +++++++++++----
> > > > > 1 file changed, 11 insertions(+), 4 deletions(-)
> > > > >
> > > > > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> > > > > index 1046e7fe310a..f96123b56935 100644
> > > > > --- a/drivers/gpu/drm/i915/display/intel_dp.c
> > > > > +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> > > > > @@ -4455,6 +4455,10 @@ intel_dp_detect(struct drm_connector *connector,
> > > > > memset(&intel_dp->compliance, 0, sizeof(intel_dp->compliance));
> > > > > memset(intel_dp->dsc_dpcd, 0, sizeof(intel_dp->dsc_dpcd));
> > > > >
> > > > > + /* Reset VRR Capable property on disconnect */
> > > > > + drm_connector_set_vrr_capable_property(connector,
> > > > > + false);
> > > > > +
> > > > > if (intel_dp->is_mst) {
> > > > > drm_dbg_kms(&dev_priv->drm,
> > > > > "MST device may have disappeared %d vs %d\n",
> > > > > @@ -4569,15 +4573,18 @@ static int intel_dp_get_modes(struct drm_connector *connector)
> > > > > {
> > > > > struct intel_connector *intel_connector = to_intel_connector(connector);
> > > > > struct edid *edid;
> > > > > + struct drm_i915_private *i915 = to_i915(connector->dev);
> > > > > int num_modes = 0;
> > > > >
> > > > > edid = intel_connector->detect_edid;
> > > > > if (edid) {
> > > > > - num_modes = intel_connector_update_modes(connector, edid);
> > > > > + bool vrr_capable;
> > > > >
> > > > > - if (intel_vrr_is_capable(connector))
> > > > > - drm_connector_set_vrr_capable_property(connector,
> > > > > - true);
> > > > > + num_modes = intel_connector_update_modes(connector, edid);
> > > > > + vrr_capable = intel_vrr_is_capable(connector);
> > > > > + drm_dbg_kms(&i915->drm, "[CONNECTOR:%d:%s] VRR capable: %s\n",
> > > > > + connector->base.id, connector->name, yesno(vrr_capable));
> > > > > + drm_connector_set_vrr_capable_property(connector, vrr_capable);
> > > >
> > > > As mentioned on irc I think intel_dp_(un)set_edid() would be a better
> > > > place for these.
> > >
> > > Yes I guess I can add the above to check for vrr_capable and set it to true/false in intel_dp_set_edid()
> > >
> > > But the resetting part needs to happen outside of intel_dp_unset_edid so that we dont always set it to false
> > > before set_edid. It can just stay in intel_dp_detect where we clear other othing on connect status == disconnected.
> > > Is that fine?
> > >
> > > Manasi
> > >
> > > >
> > > > > }
> > > > >
> > > > > /* Also add fixed mode, which may or may not be present in EDID */
> > > > > --
> > > > > 2.19.1
> > > >
> > > > --
> > > > Ville Syrjälä
> > > > Intel
>
> --
> Ville Syrjälä
> Intel
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2022-03-01 23:26 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-25 1:30 [Intel-gfx] [PATCH v6 1/2] drm/vrr: Set VRR capable prop only if it is attached to connector Manasi Navare
2022-02-25 1:30 ` [Intel-gfx] [PATCH v6 2/2] drm/i915/display/vrr: Reset VRR capable property on a long hpd Manasi Navare
2022-02-25 9:13 ` Ville Syrjälä
2022-02-26 1:11 ` Navare, Manasi
2022-03-01 19:30 ` Navare, Manasi
2022-03-01 19:34 ` Ville Syrjälä
2022-03-01 23:27 ` Navare, Manasi
2022-02-25 4:46 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v6,1/2] drm/vrr: Set VRR capable prop only if it is attached to connector Patchwork
2022-02-25 5:18 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-02-25 9:11 ` [Intel-gfx] [PATCH v6 1/2] " Ville Syrjälä
2022-02-25 21:55 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [v6,1/2] " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox