* [Intel-gfx] [PATCH 1/2] Revert "drm/i915/display: Ensure PSR gets disabled if no encoders in new state"
@ 2022-07-14 15:07 José Roberto de Souza
2022-07-14 15:07 ` [Intel-gfx] [PATCH 2/2] drm/i915/psr: Disable PSR before disable pipe José Roberto de Souza
` (4 more replies)
0 siblings, 5 replies; 9+ messages in thread
From: José Roberto de Souza @ 2022-07-14 15:07 UTC (permalink / raw)
To: intel-gfx
This patches fixes a issue but not in the right way as
for_each_oldnew_intel_crtc_in_state() will interate over all CRTCs
not only the crtc passed as parameter, also this two for_each loops
are not necessary and only make code harder to understand.
Proper fix will be discussed in the next patch.
This reverts commit 75f664903d8672897333b86bb450335ec6486ad5.
Cc: Jouni Högander <jouni.hogander@intel.com>
Cc: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
drivers/gpu/drm/i915/display/intel_psr.c | 53 ++++++++++--------------
1 file changed, 22 insertions(+), 31 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
index 90599dd1cb1b5..e6a870641cd25 100644
--- a/drivers/gpu/drm/i915/display/intel_psr.c
+++ b/drivers/gpu/drm/i915/display/intel_psr.c
@@ -1863,45 +1863,36 @@ void intel_psr_pre_plane_update(struct intel_atomic_state *state,
struct intel_crtc *crtc)
{
struct drm_i915_private *i915 = to_i915(state->base.dev);
- struct intel_crtc_state *new_crtc_state, *old_crtc_state;
- int i;
+ const struct intel_crtc_state *crtc_state =
+ intel_atomic_get_new_crtc_state(state, crtc);
+ struct intel_encoder *encoder;
if (!HAS_PSR(i915))
return;
- for_each_oldnew_intel_crtc_in_state(state, crtc, old_crtc_state,
- new_crtc_state, i) {
- struct intel_encoder *encoder;
- u32 old_new_encoder_mask = old_crtc_state->uapi.encoder_mask |
- new_crtc_state->uapi.encoder_mask;
-
- for_each_intel_encoder_mask_with_psr(state->base.dev, encoder,
- old_new_encoder_mask) {
- struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
- struct intel_psr *psr = &intel_dp->psr;
- bool needs_to_disable = false;
+ for_each_intel_encoder_mask_with_psr(state->base.dev, encoder,
+ crtc_state->uapi.encoder_mask) {
+ struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
+ struct intel_psr *psr = &intel_dp->psr;
+ bool needs_to_disable = false;
- mutex_lock(&psr->lock);
+ mutex_lock(&psr->lock);
- /*
- * Reasons to disable:
- * - PSR disabled in new state
- * - All planes will go inactive
- * - Changing between PSR versions
- * - Encoder isn't present in new mask
- */
- needs_to_disable |= intel_crtc_needs_modeset(new_crtc_state);
- needs_to_disable |= !new_crtc_state->has_psr;
- needs_to_disable |= !new_crtc_state->active_planes;
- needs_to_disable |= new_crtc_state->has_psr2 != psr->psr2_enabled;
- needs_to_disable |= !(new_crtc_state->uapi.encoder_mask &
- drm_encoder_mask(&(encoder)->base));
+ /*
+ * Reasons to disable:
+ * - PSR disabled in new state
+ * - All planes will go inactive
+ * - Changing between PSR versions
+ */
+ needs_to_disable |= intel_crtc_needs_modeset(crtc_state);
+ needs_to_disable |= !crtc_state->has_psr;
+ needs_to_disable |= !crtc_state->active_planes;
+ needs_to_disable |= crtc_state->has_psr2 != psr->psr2_enabled;
- if (psr->enabled && needs_to_disable)
- intel_psr_disable_locked(intel_dp);
+ if (psr->enabled && needs_to_disable)
+ intel_psr_disable_locked(intel_dp);
- mutex_unlock(&psr->lock);
- }
+ mutex_unlock(&psr->lock);
}
}
--
2.37.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Intel-gfx] [PATCH 2/2] drm/i915/psr: Disable PSR before disable pipe
2022-07-14 15:07 [Intel-gfx] [PATCH 1/2] Revert "drm/i915/display: Ensure PSR gets disabled if no encoders in new state" José Roberto de Souza
@ 2022-07-14 15:07 ` José Roberto de Souza
2022-07-15 5:33 ` Hogander, Jouni
2022-07-14 15:53 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] Revert "drm/i915/display: Ensure PSR gets disabled if no encoders in new state" Patchwork
` (3 subsequent siblings)
4 siblings, 1 reply; 9+ messages in thread
From: José Roberto de Souza @ 2022-07-14 15:07 UTC (permalink / raw)
To: intel-gfx
The issue here was on for_each_intel_encoder_mask_with_psr() over the
new_crtc_state encoder mask, so if the CRTC was being disabled mask
would be zero and it would not have any chance to disable PSR.
So here doing for_each_intel_encoder_mask_with_psr() over the
old_crtc_state encoder mask and then using the new_crtc_state to
check if PSR needs to be disabled.
Cc: Jouni Högander <jouni.hogander@intel.com>
Cc: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
drivers/gpu/drm/i915/display/intel_psr.c | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
index e6a870641cd25..98c3c8015a5c4 100644
--- a/drivers/gpu/drm/i915/display/intel_psr.c
+++ b/drivers/gpu/drm/i915/display/intel_psr.c
@@ -1863,7 +1863,9 @@ void intel_psr_pre_plane_update(struct intel_atomic_state *state,
struct intel_crtc *crtc)
{
struct drm_i915_private *i915 = to_i915(state->base.dev);
- const struct intel_crtc_state *crtc_state =
+ const struct intel_crtc_state *old_crtc_state =
+ intel_atomic_get_old_crtc_state(state, crtc);
+ const struct intel_crtc_state *new_crtc_state =
intel_atomic_get_new_crtc_state(state, crtc);
struct intel_encoder *encoder;
@@ -1871,7 +1873,7 @@ void intel_psr_pre_plane_update(struct intel_atomic_state *state,
return;
for_each_intel_encoder_mask_with_psr(state->base.dev, encoder,
- crtc_state->uapi.encoder_mask) {
+ old_crtc_state->uapi.encoder_mask) {
struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
struct intel_psr *psr = &intel_dp->psr;
bool needs_to_disable = false;
@@ -1884,10 +1886,10 @@ void intel_psr_pre_plane_update(struct intel_atomic_state *state,
* - All planes will go inactive
* - Changing between PSR versions
*/
- needs_to_disable |= intel_crtc_needs_modeset(crtc_state);
- needs_to_disable |= !crtc_state->has_psr;
- needs_to_disable |= !crtc_state->active_planes;
- needs_to_disable |= crtc_state->has_psr2 != psr->psr2_enabled;
+ needs_to_disable |= intel_crtc_needs_modeset(new_crtc_state);
+ needs_to_disable |= !new_crtc_state->has_psr;
+ needs_to_disable |= !new_crtc_state->active_planes;
+ needs_to_disable |= new_crtc_state->has_psr2 != psr->psr2_enabled;
if (psr->enabled && needs_to_disable)
intel_psr_disable_locked(intel_dp);
--
2.37.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] Revert "drm/i915/display: Ensure PSR gets disabled if no encoders in new state"
2022-07-14 15:07 [Intel-gfx] [PATCH 1/2] Revert "drm/i915/display: Ensure PSR gets disabled if no encoders in new state" José Roberto de Souza
2022-07-14 15:07 ` [Intel-gfx] [PATCH 2/2] drm/i915/psr: Disable PSR before disable pipe José Roberto de Souza
@ 2022-07-14 15:53 ` Patchwork
2022-07-14 18:55 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] Revert "drm/i915/display: Ensure PSR gets disabled if no encoders in new state" (rev2) Patchwork
` (2 subsequent siblings)
4 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2022-07-14 15:53 UTC (permalink / raw)
To: Souza, Jose; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 9475 bytes --]
== Series Details ==
Series: series starting with [1/2] Revert "drm/i915/display: Ensure PSR gets disabled if no encoders in new state"
URL : https://patchwork.freedesktop.org/series/106357/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11893 -> Patchwork_106357v1
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_106357v1 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_106357v1, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v1/index.html
Participating hosts (31 -> 33)
------------------------------
Additional (2): fi-rkl-11600 fi-icl-u2
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_106357v1:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@gt_lrc:
- fi-rkl-guc: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/fi-rkl-guc/igt@i915_selftest@live@gt_lrc.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v1/fi-rkl-guc/igt@i915_selftest@live@gt_lrc.html
Known issues
------------
Here are the changes found in Patchwork_106357v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_huc_copy@huc-copy:
- fi-rkl-11600: NOTRUN -> [SKIP][3] ([i915#2190])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v1/fi-rkl-11600/igt@gem_huc_copy@huc-copy.html
- fi-icl-u2: NOTRUN -> [SKIP][4] ([i915#2190])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v1/fi-icl-u2/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@parallel-random-engines:
- fi-rkl-11600: NOTRUN -> [SKIP][5] ([i915#4613]) +3 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v1/fi-rkl-11600/igt@gem_lmem_swapping@parallel-random-engines.html
* igt@gem_lmem_swapping@random-engines:
- fi-icl-u2: NOTRUN -> [SKIP][6] ([i915#4613]) +3 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v1/fi-icl-u2/igt@gem_lmem_swapping@random-engines.html
* igt@gem_tiled_pread_basic:
- fi-rkl-11600: NOTRUN -> [SKIP][7] ([i915#3282])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v1/fi-rkl-11600/igt@gem_tiled_pread_basic.html
* igt@i915_pm_backlight@basic-brightness:
- fi-rkl-11600: NOTRUN -> [SKIP][8] ([i915#3012])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v1/fi-rkl-11600/igt@i915_pm_backlight@basic-brightness.html
* igt@i915_selftest@live@requests:
- fi-pnv-d510: [PASS][9] -> [DMESG-FAIL][10] ([i915#4528])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/fi-pnv-d510/igt@i915_selftest@live@requests.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v1/fi-pnv-d510/igt@i915_selftest@live@requests.html
* igt@i915_suspend@basic-s3-without-i915:
- fi-rkl-11600: NOTRUN -> [INCOMPLETE][11] ([i915#5982])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v1/fi-rkl-11600/igt@i915_suspend@basic-s3-without-i915.html
- fi-icl-u2: NOTRUN -> [SKIP][12] ([i915#5903])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v1/fi-icl-u2/igt@i915_suspend@basic-s3-without-i915.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-rkl-11600: NOTRUN -> [SKIP][13] ([fdo#111827]) +7 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v1/fi-rkl-11600/igt@kms_chamelium@hdmi-hpd-fast.html
- fi-icl-u2: NOTRUN -> [SKIP][14] ([fdo#111827]) +8 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v1/fi-icl-u2/igt@kms_chamelium@hdmi-hpd-fast.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor:
- fi-rkl-11600: NOTRUN -> [SKIP][15] ([i915#4103])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v1/fi-rkl-11600/igt@kms_cursor_legacy@basic-busy-flip-before-cursor.html
- fi-icl-u2: NOTRUN -> [SKIP][16] ([i915#4103])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v1/fi-icl-u2/igt@kms_cursor_legacy@basic-busy-flip-before-cursor.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size:
- fi-bsw-kefka: [PASS][17] -> [FAIL][18] ([i915#6298])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v1/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size.html
* igt@kms_force_connector_basic@force-connector-state:
- fi-icl-u2: NOTRUN -> [WARN][19] ([i915#6008])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v1/fi-icl-u2/igt@kms_force_connector_basic@force-connector-state.html
* igt@kms_force_connector_basic@force-load-detect:
- fi-rkl-11600: NOTRUN -> [SKIP][20] ([fdo#109285] / [i915#4098])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v1/fi-rkl-11600/igt@kms_force_connector_basic@force-load-detect.html
- fi-icl-u2: NOTRUN -> [SKIP][21] ([fdo#109285])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v1/fi-icl-u2/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_psr@sprite_plane_onoff:
- fi-rkl-11600: NOTRUN -> [SKIP][22] ([i915#1072]) +3 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v1/fi-rkl-11600/igt@kms_psr@sprite_plane_onoff.html
* igt@kms_setmode@basic-clone-single-crtc:
- fi-rkl-11600: NOTRUN -> [SKIP][23] ([i915#3555] / [i915#4098])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v1/fi-rkl-11600/igt@kms_setmode@basic-clone-single-crtc.html
- fi-icl-u2: NOTRUN -> [SKIP][24] ([i915#3555])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v1/fi-icl-u2/igt@kms_setmode@basic-clone-single-crtc.html
* igt@prime_vgem@basic-read:
- fi-rkl-11600: NOTRUN -> [SKIP][25] ([fdo#109295] / [i915#3291] / [i915#3708]) +2 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v1/fi-rkl-11600/igt@prime_vgem@basic-read.html
* igt@prime_vgem@basic-userptr:
- fi-icl-u2: NOTRUN -> [SKIP][26] ([fdo#109295] / [i915#3301])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v1/fi-icl-u2/igt@prime_vgem@basic-userptr.html
- fi-rkl-11600: NOTRUN -> [SKIP][27] ([fdo#109295] / [i915#3301] / [i915#3708])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v1/fi-rkl-11600/igt@prime_vgem@basic-userptr.html
* igt@runner@aborted:
- fi-pnv-d510: NOTRUN -> [FAIL][28] ([fdo#109271] / [i915#2403] / [i915#4312])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v1/fi-pnv-d510/igt@runner@aborted.html
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2403]: https://gitlab.freedesktop.org/drm/intel/issues/2403
[i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#5903]: https://gitlab.freedesktop.org/drm/intel/issues/5903
[i915#5982]: https://gitlab.freedesktop.org/drm/intel/issues/5982
[i915#6008]: https://gitlab.freedesktop.org/drm/intel/issues/6008
[i915#6298]: https://gitlab.freedesktop.org/drm/intel/issues/6298
Build changes
-------------
* Linux: CI_DRM_11893 -> Patchwork_106357v1
CI-20190529: 20190529
CI_DRM_11893: 932d346f9726fae3af81aba5e4362b428f6e3c56 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6582: c7f7fabcd7c075bfee48cbb79b5990894743204d @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_106357v1: 932d346f9726fae3af81aba5e4362b428f6e3c56 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
06a2f6e9d764 drm/i915/psr: Disable PSR before disable pipe
ce3ee034369f Revert "drm/i915/display: Ensure PSR gets disabled if no encoders in new state"
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v1/index.html
[-- Attachment #2: Type: text/html, Size: 11414 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] Revert "drm/i915/display: Ensure PSR gets disabled if no encoders in new state" (rev2)
2022-07-14 15:07 [Intel-gfx] [PATCH 1/2] Revert "drm/i915/display: Ensure PSR gets disabled if no encoders in new state" José Roberto de Souza
2022-07-14 15:07 ` [Intel-gfx] [PATCH 2/2] drm/i915/psr: Disable PSR before disable pipe José Roberto de Souza
2022-07-14 15:53 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] Revert "drm/i915/display: Ensure PSR gets disabled if no encoders in new state" Patchwork
@ 2022-07-14 18:55 ` Patchwork
2022-07-15 1:15 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-07-15 5:21 ` [Intel-gfx] [PATCH 1/2] Revert "drm/i915/display: Ensure PSR gets disabled if no encoders in new state" Hogander, Jouni
4 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2022-07-14 18:55 UTC (permalink / raw)
To: Souza, Jose; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 13225 bytes --]
== Series Details ==
Series: series starting with [1/2] Revert "drm/i915/display: Ensure PSR gets disabled if no encoders in new state" (rev2)
URL : https://patchwork.freedesktop.org/series/106357/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11893 -> Patchwork_106357v2
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/index.html
Participating hosts (31 -> 41)
------------------------------
Additional (10): fi-rkl-11600 bat-dg2-8 bat-adlm-1 fi-icl-u2 bat-adlp-6 bat-adlp-4 bat-adln-1 bat-rpls-1 bat-rpls-2 bat-jsl-1
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_106357v2:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@i915_module_load@reload:
- {bat-rpls-2}: NOTRUN -> [INCOMPLETE][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/bat-rpls-2/igt@i915_module_load@reload.html
Known issues
------------
Here are the changes found in Patchwork_106357v2 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_huc_copy@huc-copy:
- fi-icl-u2: NOTRUN -> [SKIP][2] ([i915#2190])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/fi-icl-u2/igt@gem_huc_copy@huc-copy.html
- fi-rkl-11600: NOTRUN -> [SKIP][3] ([i915#2190])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/fi-rkl-11600/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@basic:
- fi-rkl-11600: NOTRUN -> [SKIP][4] ([i915#4613]) +3 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/fi-rkl-11600/igt@gem_lmem_swapping@basic.html
* igt@gem_lmem_swapping@parallel-random-engines:
- bat-adlp-4: NOTRUN -> [SKIP][5] ([i915#4613]) +3 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/bat-adlp-4/igt@gem_lmem_swapping@parallel-random-engines.html
* igt@gem_lmem_swapping@random-engines:
- fi-icl-u2: NOTRUN -> [SKIP][6] ([i915#4613]) +3 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/fi-icl-u2/igt@gem_lmem_swapping@random-engines.html
* igt@gem_tiled_pread_basic:
- fi-rkl-11600: NOTRUN -> [SKIP][7] ([i915#3282])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/fi-rkl-11600/igt@gem_tiled_pread_basic.html
- bat-adlp-4: NOTRUN -> [SKIP][8] ([i915#3282])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/bat-adlp-4/igt@gem_tiled_pread_basic.html
* igt@i915_pm_backlight@basic-brightness:
- fi-rkl-11600: NOTRUN -> [SKIP][9] ([i915#3012])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/fi-rkl-11600/igt@i915_pm_backlight@basic-brightness.html
* igt@i915_pm_rpm@module-reload:
- fi-cfl-8109u: [PASS][10] -> [DMESG-FAIL][11] ([i915#62])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/fi-cfl-8109u/igt@i915_pm_rpm@module-reload.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/fi-cfl-8109u/igt@i915_pm_rpm@module-reload.html
* igt@i915_selftest@live@requests:
- fi-pnv-d510: [PASS][12] -> [DMESG-FAIL][13] ([i915#4528])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/fi-pnv-d510/igt@i915_selftest@live@requests.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/fi-pnv-d510/igt@i915_selftest@live@requests.html
* igt@i915_suspend@basic-s3-without-i915:
- fi-rkl-11600: NOTRUN -> [INCOMPLETE][14] ([i915#5982])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/fi-rkl-11600/igt@i915_suspend@basic-s3-without-i915.html
- fi-icl-u2: NOTRUN -> [SKIP][15] ([i915#5903])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/fi-icl-u2/igt@i915_suspend@basic-s3-without-i915.html
- bat-adlp-4: NOTRUN -> [SKIP][16] ([i915#5903])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/bat-adlp-4/igt@i915_suspend@basic-s3-without-i915.html
* igt@kms_chamelium@dp-crc-fast:
- bat-adlp-4: NOTRUN -> [SKIP][17] ([fdo#111827]) +8 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/bat-adlp-4/igt@kms_chamelium@dp-crc-fast.html
* igt@kms_chamelium@hdmi-edid-read:
- fi-rkl-11600: NOTRUN -> [SKIP][18] ([fdo#111827]) +7 similar issues
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/fi-rkl-11600/igt@kms_chamelium@hdmi-edid-read.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-icl-u2: NOTRUN -> [SKIP][19] ([fdo#111827]) +8 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/fi-icl-u2/igt@kms_chamelium@hdmi-hpd-fast.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor:
- bat-adlp-4: NOTRUN -> [SKIP][20] ([i915#4103])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/bat-adlp-4/igt@kms_cursor_legacy@basic-busy-flip-before-cursor.html
- fi-rkl-11600: NOTRUN -> [SKIP][21] ([i915#4103])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/fi-rkl-11600/igt@kms_cursor_legacy@basic-busy-flip-before-cursor.html
- fi-icl-u2: NOTRUN -> [SKIP][22] ([i915#4103])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/fi-icl-u2/igt@kms_cursor_legacy@basic-busy-flip-before-cursor.html
* igt@kms_force_connector_basic@force-connector-state:
- fi-icl-u2: NOTRUN -> [WARN][23] ([i915#6008])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/fi-icl-u2/igt@kms_force_connector_basic@force-connector-state.html
* igt@kms_force_connector_basic@force-load-detect:
- bat-adlp-4: NOTRUN -> [SKIP][24] ([i915#4093]) +3 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/bat-adlp-4/igt@kms_force_connector_basic@force-load-detect.html
- fi-rkl-11600: NOTRUN -> [SKIP][25] ([fdo#109285] / [i915#4098])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/fi-rkl-11600/igt@kms_force_connector_basic@force-load-detect.html
- fi-icl-u2: NOTRUN -> [SKIP][26] ([fdo#109285])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/fi-icl-u2/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_frontbuffer_tracking@basic:
- fi-cfl-8109u: [PASS][27] -> [DMESG-WARN][28] ([i915#62]) +12 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/fi-cfl-8109u/igt@kms_frontbuffer_tracking@basic.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/fi-cfl-8109u/igt@kms_frontbuffer_tracking@basic.html
* igt@kms_psr@primary_page_flip:
- fi-rkl-11600: NOTRUN -> [SKIP][29] ([i915#1072]) +3 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/fi-rkl-11600/igt@kms_psr@primary_page_flip.html
* igt@kms_setmode@basic-clone-single-crtc:
- fi-rkl-11600: NOTRUN -> [SKIP][30] ([i915#3555] / [i915#4098])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/fi-rkl-11600/igt@kms_setmode@basic-clone-single-crtc.html
- fi-icl-u2: NOTRUN -> [SKIP][31] ([i915#3555])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/fi-icl-u2/igt@kms_setmode@basic-clone-single-crtc.html
- bat-adlp-4: NOTRUN -> [SKIP][32] ([i915#3555] / [i915#4579])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/bat-adlp-4/igt@kms_setmode@basic-clone-single-crtc.html
* igt@prime_vgem@basic-read:
- fi-rkl-11600: NOTRUN -> [SKIP][33] ([fdo#109295] / [i915#3291] / [i915#3708]) +2 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/fi-rkl-11600/igt@prime_vgem@basic-read.html
* igt@prime_vgem@basic-userptr:
- fi-icl-u2: NOTRUN -> [SKIP][34] ([fdo#109295] / [i915#3301])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/fi-icl-u2/igt@prime_vgem@basic-userptr.html
- bat-adlp-4: NOTRUN -> [SKIP][35] ([fdo#109295] / [i915#3301] / [i915#3708])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/bat-adlp-4/igt@prime_vgem@basic-userptr.html
- fi-rkl-11600: NOTRUN -> [SKIP][36] ([fdo#109295] / [i915#3301] / [i915#3708])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/fi-rkl-11600/igt@prime_vgem@basic-userptr.html
* igt@prime_vgem@basic-write:
- bat-adlp-4: NOTRUN -> [SKIP][37] ([fdo#109295] / [i915#3291] / [i915#3708]) +2 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/bat-adlp-4/igt@prime_vgem@basic-write.html
* igt@runner@aborted:
- fi-pnv-d510: NOTRUN -> [FAIL][38] ([fdo#109271] / [i915#2403] / [i915#4312])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/fi-pnv-d510/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2403]: https://gitlab.freedesktop.org/drm/intel/issues/2403
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#3003]: https://gitlab.freedesktop.org/drm/intel/issues/3003
[i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3595]: https://gitlab.freedesktop.org/drm/intel/issues/3595
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4093]: https://gitlab.freedesktop.org/drm/intel/issues/4093
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5087]: https://gitlab.freedesktop.org/drm/intel/issues/5087
[i915#5174]: https://gitlab.freedesktop.org/drm/intel/issues/5174
[i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190
[i915#5274]: https://gitlab.freedesktop.org/drm/intel/issues/5274
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5763]: https://gitlab.freedesktop.org/drm/intel/issues/5763
[i915#5903]: https://gitlab.freedesktop.org/drm/intel/issues/5903
[i915#5982]: https://gitlab.freedesktop.org/drm/intel/issues/5982
[i915#6008]: https://gitlab.freedesktop.org/drm/intel/issues/6008
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#6257]: https://gitlab.freedesktop.org/drm/intel/issues/6257
[i915#6297]: https://gitlab.freedesktop.org/drm/intel/issues/6297
Build changes
-------------
* Linux: CI_DRM_11893 -> Patchwork_106357v2
CI-20190529: 20190529
CI_DRM_11893: 932d346f9726fae3af81aba5e4362b428f6e3c56 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6582: c7f7fabcd7c075bfee48cbb79b5990894743204d @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_106357v2: 932d346f9726fae3af81aba5e4362b428f6e3c56 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
bb2c97529bab drm/i915/psr: Disable PSR before disable pipe
9f7a873de829 Revert "drm/i915/display: Ensure PSR gets disabled if no encoders in new state"
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/index.html
[-- Attachment #2: Type: text/html, Size: 14651 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] Revert "drm/i915/display: Ensure PSR gets disabled if no encoders in new state" (rev2)
2022-07-14 15:07 [Intel-gfx] [PATCH 1/2] Revert "drm/i915/display: Ensure PSR gets disabled if no encoders in new state" José Roberto de Souza
` (2 preceding siblings ...)
2022-07-14 18:55 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] Revert "drm/i915/display: Ensure PSR gets disabled if no encoders in new state" (rev2) Patchwork
@ 2022-07-15 1:15 ` Patchwork
2022-07-15 5:21 ` [Intel-gfx] [PATCH 1/2] Revert "drm/i915/display: Ensure PSR gets disabled if no encoders in new state" Hogander, Jouni
4 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2022-07-15 1:15 UTC (permalink / raw)
To: Souza, Jose; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 49871 bytes --]
== Series Details ==
Series: series starting with [1/2] Revert "drm/i915/display: Ensure PSR gets disabled if no encoders in new state" (rev2)
URL : https://patchwork.freedesktop.org/series/106357/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11893_full -> Patchwork_106357v2_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_106357v2_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_106357v2_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Participating hosts (12 -> 12)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_106357v2_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_eio@in-flight-suspend:
- shard-skl: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-skl10/igt@gem_eio@in-flight-suspend.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-skl10/igt@gem_eio@in-flight-suspend.html
#### Warnings ####
* igt@kms_frontbuffer_tracking@fbcpsr-tiling-linear:
- shard-tglb: [FAIL][3] ([i915#160]) -> [INCOMPLETE][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-tglb2/igt@kms_frontbuffer_tracking@fbcpsr-tiling-linear.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-tglb8/igt@kms_frontbuffer_tracking@fbcpsr-tiling-linear.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@kms_frontbuffer_tracking@fbcpsr-tiling-y:
- {shard-rkl}: [SKIP][5] ([i915#1849] / [i915#4098]) -> [FAIL][6] +6 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-rkl-2/igt@kms_frontbuffer_tracking@fbcpsr-tiling-y.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-rkl-6/igt@kms_frontbuffer_tracking@fbcpsr-tiling-y.html
Known issues
------------
Here are the changes found in Patchwork_106357v2_full that come from known issues:
### CI changes ###
#### Possible fixes ####
* boot:
- shard-skl: ([PASS][7], [PASS][8], [PASS][9], [PASS][10], [PASS][11], [PASS][12], [PASS][13], [PASS][14], [PASS][15], [FAIL][16], [PASS][17], [PASS][18], [PASS][19], [PASS][20], [PASS][21], [PASS][22], [PASS][23], [PASS][24], [PASS][25], [PASS][26], [PASS][27], [PASS][28]) ([i915#5032]) -> ([PASS][29], [PASS][30], [PASS][31], [PASS][32], [PASS][33], [PASS][34], [PASS][35], [PASS][36], [PASS][37], [PASS][38], [PASS][39], [PASS][40], [PASS][41], [PASS][42], [PASS][43], [PASS][44], [PASS][45], [PASS][46], [PASS][47], [PASS][48], [PASS][49], [PASS][50], [PASS][51], [PASS][52])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-skl9/boot.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-skl9/boot.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-skl9/boot.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-skl7/boot.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-skl7/boot.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-skl7/boot.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-skl6/boot.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-skl6/boot.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-skl6/boot.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-skl5/boot.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-skl5/boot.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-skl5/boot.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-skl4/boot.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-skl4/boot.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-skl4/boot.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-skl2/boot.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-skl1/boot.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-skl1/boot.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-skl1/boot.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-skl10/boot.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-skl10/boot.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-skl10/boot.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-skl10/boot.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-skl10/boot.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-skl10/boot.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-skl1/boot.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-skl1/boot.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-skl1/boot.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-skl1/boot.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-skl4/boot.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-skl4/boot.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-skl4/boot.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-skl4/boot.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-skl5/boot.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-skl5/boot.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-skl5/boot.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-skl6/boot.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-skl6/boot.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-skl6/boot.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-skl6/boot.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-skl7/boot.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-skl7/boot.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-skl7/boot.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-skl9/boot.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-skl9/boot.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-skl9/boot.html
### IGT changes ###
#### Issues hit ####
* igt@gem_busy@close-race:
- shard-snb: [PASS][53] -> [TIMEOUT][54] ([i915#5748])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-snb5/igt@gem_busy@close-race.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-snb2/igt@gem_busy@close-race.html
* igt@gem_ctx_persistence@engines-mixed:
- shard-snb: NOTRUN -> [SKIP][55] ([fdo#109271] / [i915#1099])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-snb4/igt@gem_ctx_persistence@engines-mixed.html
* igt@gem_eio@in-flight-immediate:
- shard-skl: [PASS][56] -> [TIMEOUT][57] ([i915#3063])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-skl1/igt@gem_eio@in-flight-immediate.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-skl1/igt@gem_eio@in-flight-immediate.html
* igt@gem_eio@unwedge-stress:
- shard-iclb: [PASS][58] -> [TIMEOUT][59] ([i915#3070])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-iclb5/igt@gem_eio@unwedge-stress.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-iclb6/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_balancer@parallel-bb-first:
- shard-iclb: [PASS][60] -> [SKIP][61] ([i915#4525])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-iclb4/igt@gem_exec_balancer@parallel-bb-first.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-iclb7/igt@gem_exec_balancer@parallel-bb-first.html
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-apl: [PASS][62] -> [FAIL][63] ([i915#2842])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-apl1/igt@gem_exec_fair@basic-none-solo@rcs0.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-apl4/igt@gem_exec_fair@basic-none-solo@rcs0.html
* igt@gem_exec_fair@basic-none@rcs0:
- shard-kbl: [PASS][64] -> [FAIL][65] ([i915#2842]) +1 similar issue
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-kbl4/igt@gem_exec_fair@basic-none@rcs0.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-kbl7/igt@gem_exec_fair@basic-none@rcs0.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [PASS][66] -> [FAIL][67] ([i915#2842]) +2 similar issues
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-glk7/igt@gem_exec_fair@basic-pace-share@rcs0.html
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-glk1/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_lmem_swapping@heavy-verify-multi-ccs:
- shard-glk: NOTRUN -> [SKIP][68] ([fdo#109271] / [i915#4613])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-glk7/igt@gem_lmem_swapping@heavy-verify-multi-ccs.html
* igt@gem_lmem_swapping@heavy-verify-random:
- shard-tglb: NOTRUN -> [SKIP][69] ([i915#4613])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-tglb1/igt@gem_lmem_swapping@heavy-verify-random.html
* igt@gem_lmem_swapping@parallel-random-verify:
- shard-skl: NOTRUN -> [SKIP][70] ([fdo#109271] / [i915#4613]) +3 similar issues
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-skl4/igt@gem_lmem_swapping@parallel-random-verify.html
* igt@gem_pxp@display-protected-crc:
- shard-tglb: NOTRUN -> [SKIP][71] ([i915#4270])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-tglb1/igt@gem_pxp@display-protected-crc.html
* igt@gem_softpin@evict-single-offset:
- shard-apl: NOTRUN -> [FAIL][72] ([i915#4171])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-apl8/igt@gem_softpin@evict-single-offset.html
* igt@gem_userptr_blits@readonly-unsync:
- shard-tglb: NOTRUN -> [SKIP][73] ([i915#3297]) +1 similar issue
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-tglb1/igt@gem_userptr_blits@readonly-unsync.html
* igt@gen7_exec_parse@basic-offset:
- shard-tglb: NOTRUN -> [SKIP][74] ([fdo#109289])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-tglb1/igt@gen7_exec_parse@basic-offset.html
* igt@gen9_exec_parse@secure-batches:
- shard-tglb: NOTRUN -> [SKIP][75] ([i915#2527] / [i915#2856])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-tglb1/igt@gen9_exec_parse@secure-batches.html
* igt@i915_pm_rpm@pc8-residency:
- shard-tglb: NOTRUN -> [SKIP][76] ([fdo#109506] / [i915#2411])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-tglb1/igt@i915_pm_rpm@pc8-residency.html
* igt@kms_async_flips@alternate-sync-async-flip@pipe-c-edp-1:
- shard-skl: [PASS][77] -> [FAIL][78] ([i915#2521])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-skl6/igt@kms_async_flips@alternate-sync-async-flip@pipe-c-edp-1.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-skl10/igt@kms_async_flips@alternate-sync-async-flip@pipe-c-edp-1.html
* igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-0-hflip:
- shard-tglb: NOTRUN -> [SKIP][79] ([i915#5286]) +1 similar issue
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-tglb1/igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-0-hflip.html
* igt@kms_big_fb@linear-8bpp-rotate-90:
- shard-tglb: NOTRUN -> [SKIP][80] ([fdo#111614]) +1 similar issue
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-tglb1/igt@kms_big_fb@linear-8bpp-rotate-90.html
* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-async-flip:
- shard-skl: NOTRUN -> [FAIL][81] ([i915#3763])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-skl7/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-async-flip.html
* igt@kms_big_fb@yf-tiled-32bpp-rotate-0:
- shard-glk: [PASS][82] -> [DMESG-FAIL][83] ([i915#118] / [i915#1888])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-glk6/igt@kms_big_fb@yf-tiled-32bpp-rotate-0.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-glk8/igt@kms_big_fb@yf-tiled-32bpp-rotate-0.html
* igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-async-flip:
- shard-skl: NOTRUN -> [FAIL][84] ([i915#3743]) +2 similar issues
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-skl7/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-async-flip.html
- shard-tglb: NOTRUN -> [SKIP][85] ([fdo#111615]) +1 similar issue
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-tglb1/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-async-flip.html
* igt@kms_ccs@pipe-a-crc-primary-rotation-180-4_tiled_dg2_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][86] ([i915#3689] / [i915#6095]) +1 similar issue
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-tglb1/igt@kms_ccs@pipe-a-crc-primary-rotation-180-4_tiled_dg2_mc_ccs.html
* igt@kms_ccs@pipe-a-crc-primary-rotation-180-4_tiled_dg2_rc_ccs:
- shard-apl: NOTRUN -> [SKIP][87] ([fdo#109271]) +50 similar issues
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-apl4/igt@kms_ccs@pipe-a-crc-primary-rotation-180-4_tiled_dg2_rc_ccs.html
* igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs:
- shard-kbl: NOTRUN -> [SKIP][88] ([fdo#109271] / [i915#3886]) +1 similar issue
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-kbl4/igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc:
- shard-skl: NOTRUN -> [SKIP][89] ([fdo#109271] / [i915#3886]) +4 similar issues
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-skl7/igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-a-random-ccs-data-y_tiled_gen12_rc_ccs_cc:
- shard-glk: NOTRUN -> [SKIP][90] ([fdo#109271] / [i915#3886]) +1 similar issue
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-glk7/igt@kms_ccs@pipe-a-random-ccs-data-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-b-crc-primary-basic-4_tiled_dg2_rc_ccs:
- shard-tglb: NOTRUN -> [SKIP][91] ([i915#6095])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-tglb1/igt@kms_ccs@pipe-b-crc-primary-basic-4_tiled_dg2_rc_ccs.html
* igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][92] ([i915#3689] / [i915#3886])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-tglb1/igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-c-bad-pixel-format-y_tiled_gen12_rc_ccs_cc:
- shard-snb: NOTRUN -> [SKIP][93] ([fdo#109271]) +72 similar issues
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-snb4/igt@kms_ccs@pipe-c-bad-pixel-format-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_mc_ccs:
- shard-apl: NOTRUN -> [SKIP][94] ([fdo#109271] / [i915#3886])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-apl1/igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_mc_ccs.html
* igt@kms_chamelium@dp-crc-multiple:
- shard-skl: NOTRUN -> [SKIP][95] ([fdo#109271] / [fdo#111827]) +12 similar issues
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-skl7/igt@kms_chamelium@dp-crc-multiple.html
* igt@kms_chamelium@hdmi-crc-nonplanar-formats:
- shard-glk: NOTRUN -> [SKIP][96] ([fdo#109271] / [fdo#111827]) +2 similar issues
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-glk7/igt@kms_chamelium@hdmi-crc-nonplanar-formats.html
* igt@kms_color_chamelium@pipe-a-ctm-green-to-red:
- shard-apl: NOTRUN -> [SKIP][97] ([fdo#109271] / [fdo#111827]) +1 similar issue
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-apl8/igt@kms_color_chamelium@pipe-a-ctm-green-to-red.html
* igt@kms_color_chamelium@pipe-a-ctm-limited-range:
- shard-snb: NOTRUN -> [SKIP][98] ([fdo#109271] / [fdo#111827]) +1 similar issue
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-snb4/igt@kms_color_chamelium@pipe-a-ctm-limited-range.html
* igt@kms_color_chamelium@pipe-d-ctm-0-25:
- shard-tglb: NOTRUN -> [SKIP][99] ([fdo#109284] / [fdo#111827]) +1 similar issue
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-tglb1/igt@kms_color_chamelium@pipe-d-ctm-0-25.html
* igt@kms_content_protection@atomic-dpms:
- shard-tglb: NOTRUN -> [SKIP][100] ([i915#1063])
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-tglb1/igt@kms_content_protection@atomic-dpms.html
* igt@kms_cursor_legacy@cursor-vs-flip@atomic-transitions:
- shard-iclb: [PASS][101] -> [FAIL][102] ([i915#5072])
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-iclb5/igt@kms_cursor_legacy@cursor-vs-flip@atomic-transitions.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-iclb7/igt@kms_cursor_legacy@cursor-vs-flip@atomic-transitions.html
* igt@kms_draw_crc@draw-method-rgb565-pwrite-4tiled:
- shard-tglb: NOTRUN -> [SKIP][103] ([i915#5287])
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-tglb1/igt@kms_draw_crc@draw-method-rgb565-pwrite-4tiled.html
* igt@kms_fbcon_fbt@psr-suspend:
- shard-kbl: NOTRUN -> [SKIP][104] ([fdo#109271]) +9 similar issues
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-kbl4/igt@kms_fbcon_fbt@psr-suspend.html
* igt@kms_flip@2x-modeset-vs-vblank-race:
- shard-tglb: NOTRUN -> [SKIP][105] ([fdo#109274] / [fdo#111825] / [i915#3637])
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-tglb1/igt@kms_flip@2x-modeset-vs-vblank-race.html
* igt@kms_flip@flip-vs-blocking-wf-vblank@a-edp1:
- shard-skl: [PASS][106] -> [FAIL][107] ([i915#2122]) +1 similar issue
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-skl6/igt@kms_flip@flip-vs-blocking-wf-vblank@a-edp1.html
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-skl10/igt@kms_flip@flip-vs-blocking-wf-vblank@a-edp1.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a1:
- shard-glk: [PASS][108] -> [FAIL][109] ([i915#79])
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-glk6/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a1.html
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-glk8/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a1.html
* igt@kms_flip@flip-vs-suspend@a-dp1:
- shard-apl: [PASS][110] -> [DMESG-WARN][111] ([i915#180]) +1 similar issue
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-apl7/igt@kms_flip@flip-vs-suspend@a-dp1.html
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-apl3/igt@kms_flip@flip-vs-suspend@a-dp1.html
* igt@kms_flip@flip-vs-suspend@b-edp1:
- shard-skl: [PASS][112] -> [INCOMPLETE][113] ([i915#4839])
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-skl5/igt@kms_flip@flip-vs-suspend@b-edp1.html
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-skl7/igt@kms_flip@flip-vs-suspend@b-edp1.html
* igt@kms_flip_scaled_crc@flip-32bpp-xtile-to-64bpp-xtile-downscaling@pipe-a-default-mode:
- shard-iclb: NOTRUN -> [SKIP][114] ([i915#3555])
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-xtile-to-64bpp-xtile-downscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-32bpp-yftileccs-to-64bpp-yftile-upscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][115] ([i915#2672]) +6 similar issues
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-iclb5/igt@kms_flip_scaled_crc@flip-32bpp-yftileccs-to-64bpp-yftile-upscaling@pipe-a-valid-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tiledg2rcccs-upscaling@pipe-a-default-mode:
- shard-skl: NOTRUN -> [SKIP][116] ([fdo#109271]) +170 similar issues
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-skl7/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tiledg2rcccs-upscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tiledg2rcccs-upscaling@pipe-a-valid-mode:
- shard-tglb: NOTRUN -> [SKIP][117] ([i915#2672])
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-tglb1/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tiledg2rcccs-upscaling@pipe-a-valid-mode.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-mmap-gtt:
- shard-tglb: NOTRUN -> [FAIL][118] ([i915#160]) +1 similar issue
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-tglb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-mmap-gtt.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-spr-indfb-fullscreen:
- shard-tglb: NOTRUN -> [SKIP][119] ([fdo#109280] / [fdo#111825]) +4 similar issues
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-tglb1/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-spr-indfb-fullscreen.html
* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-spr-indfb-draw-mmap-cpu:
- shard-glk: NOTRUN -> [SKIP][120] ([fdo#109271]) +38 similar issues
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-glk7/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-spr-indfb-draw-mmap-cpu.html
* igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb:
- shard-glk: NOTRUN -> [FAIL][121] ([i915#265])
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-glk7/igt@kms_plane_alpha_blend@pipe-b-alpha-transparent-fb.html
* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min:
- shard-skl: NOTRUN -> [FAIL][122] ([fdo#108145] / [i915#265]) +2 similar issues
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-skl7/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html
* igt@kms_plane_alpha_blend@pipe-c-alpha-basic:
- shard-apl: NOTRUN -> [FAIL][123] ([fdo#108145] / [i915#265])
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-apl4/igt@kms_plane_alpha_blend@pipe-c-alpha-basic.html
* igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-5@pipe-a-edp-1:
- shard-iclb: [PASS][124] -> [SKIP][125] ([i915#5176]) +2 similar issues
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-iclb1/igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-5@pipe-a-edp-1.html
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-iclb2/igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-5@pipe-a-edp-1.html
* igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-sf:
- shard-kbl: NOTRUN -> [SKIP][126] ([fdo#109271] / [i915#658])
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-kbl4/igt@kms_psr2_sf@cursor-plane-move-continuous-exceed-sf.html
* igt@kms_psr2_sf@plane-move-sf-dmg-area:
- shard-tglb: NOTRUN -> [SKIP][127] ([i915#2920])
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-tglb1/igt@kms_psr2_sf@plane-move-sf-dmg-area.html
* igt@kms_psr2_su@page_flip-xrgb8888:
- shard-iclb: [PASS][128] -> [SKIP][129] ([fdo#109642] / [fdo#111068] / [i915#658]) +1 similar issue
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-iclb2/igt@kms_psr2_su@page_flip-xrgb8888.html
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-iclb4/igt@kms_psr2_su@page_flip-xrgb8888.html
- shard-skl: NOTRUN -> [SKIP][130] ([fdo#109271] / [i915#658]) +2 similar issues
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-skl7/igt@kms_psr2_su@page_flip-xrgb8888.html
* igt@kms_psr@psr2_suspend:
- shard-tglb: NOTRUN -> [FAIL][131] ([i915#132] / [i915#3467])
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-tglb1/igt@kms_psr@psr2_suspend.html
* igt@kms_vblank@pipe-d-wait-idle:
- shard-skl: NOTRUN -> [SKIP][132] ([fdo#109271] / [i915#533])
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-skl4/igt@kms_vblank@pipe-d-wait-idle.html
* igt@kms_writeback@writeback-fb-id:
- shard-apl: NOTRUN -> [SKIP][133] ([fdo#109271] / [i915#2437])
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-apl8/igt@kms_writeback@writeback-fb-id.html
* igt@nouveau_crc@pipe-d-ctx-flip-detection:
- shard-tglb: NOTRUN -> [SKIP][134] ([i915#2530])
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-tglb1/igt@nouveau_crc@pipe-d-ctx-flip-detection.html
* igt@prime_nv_test@i915_blt_fill_nv_read:
- shard-tglb: NOTRUN -> [SKIP][135] ([fdo#109291])
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-tglb1/igt@prime_nv_test@i915_blt_fill_nv_read.html
* igt@sysfs_clients@busy:
- shard-skl: NOTRUN -> [SKIP][136] ([fdo#109271] / [i915#2994]) +1 similar issue
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-skl7/igt@sysfs_clients@busy.html
* igt@sysfs_clients@fair-3:
- shard-glk: NOTRUN -> [SKIP][137] ([fdo#109271] / [i915#2994])
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-glk7/igt@sysfs_clients@fair-3.html
* igt@sysfs_clients@split-10:
- shard-apl: NOTRUN -> [SKIP][138] ([fdo#109271] / [i915#2994])
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-apl4/igt@sysfs_clients@split-10.html
#### Possible fixes ####
* igt@feature_discovery@psr1:
- {shard-rkl}: [SKIP][139] ([i915#658]) -> [PASS][140]
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-rkl-2/igt@feature_discovery@psr1.html
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-rkl-6/igt@feature_discovery@psr1.html
* igt@gem_ctx_persistence@hostile:
- {shard-rkl}: [FAIL][141] ([i915#2410]) -> [PASS][142]
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-rkl-1/igt@gem_ctx_persistence@hostile.html
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-rkl-5/igt@gem_ctx_persistence@hostile.html
* igt@gem_eio@unwedge-stress:
- {shard-rkl}: [TIMEOUT][143] ([i915#3063]) -> [PASS][144]
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-rkl-1/igt@gem_eio@unwedge-stress.html
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-rkl-1/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_balancer@parallel-balancer:
- shard-iclb: [SKIP][145] ([i915#4525]) -> [PASS][146]
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-iclb6/igt@gem_exec_balancer@parallel-balancer.html
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-iclb1/igt@gem_exec_balancer@parallel-balancer.html
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-iclb: [FAIL][147] ([i915#2842]) -> [PASS][148]
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-iclb8/igt@gem_exec_fair@basic-none-share@rcs0.html
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-iclb3/igt@gem_exec_fair@basic-none-share@rcs0.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-apl: [FAIL][149] ([i915#2842]) -> [PASS][150]
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-apl7/igt@gem_exec_fair@basic-pace-share@rcs0.html
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-apl3/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-pace@vcs1:
- shard-kbl: [FAIL][151] ([i915#2842]) -> [PASS][152] +1 similar issue
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-kbl4/igt@gem_exec_fair@basic-pace@vcs1.html
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-kbl6/igt@gem_exec_fair@basic-pace@vcs1.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-iclb: [FAIL][153] ([i915#2849]) -> [PASS][154]
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-iclb2/igt@gem_exec_fair@basic-throttle@rcs0.html
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-iclb1/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@gem_exec_reloc@basic-gtt-wc-noreloc:
- {shard-rkl}: [SKIP][155] ([i915#3281]) -> [PASS][156] +6 similar issues
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-rkl-1/igt@gem_exec_reloc@basic-gtt-wc-noreloc.html
[156]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-rkl-5/igt@gem_exec_reloc@basic-gtt-wc-noreloc.html
* igt@gem_readwrite@beyond-eob:
- {shard-rkl}: [SKIP][157] ([i915#3282]) -> [PASS][158] +4 similar issues
[157]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-rkl-1/igt@gem_readwrite@beyond-eob.html
[158]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-rkl-5/igt@gem_readwrite@beyond-eob.html
* igt@gem_softpin@evict-single-offset:
- {shard-rkl}: [FAIL][159] ([i915#4171]) -> [PASS][160]
[159]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-rkl-5/igt@gem_softpin@evict-single-offset.html
[160]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-rkl-1/igt@gem_softpin@evict-single-offset.html
* igt@gem_workarounds@suspend-resume:
- shard-apl: [DMESG-WARN][161] ([i915#180]) -> [PASS][162] +2 similar issues
[161]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-apl1/igt@gem_workarounds@suspend-resume.html
[162]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-apl8/igt@gem_workarounds@suspend-resume.html
* igt@gen9_exec_parse@allowed-single:
- shard-kbl: [DMESG-WARN][163] ([i915#5566] / [i915#716]) -> [PASS][164]
[163]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-kbl4/igt@gen9_exec_parse@allowed-single.html
[164]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-kbl4/igt@gen9_exec_parse@allowed-single.html
* igt@gen9_exec_parse@batch-without-end:
- {shard-rkl}: [SKIP][165] ([i915#2527]) -> [PASS][166] +1 similar issue
[165]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-rkl-1/igt@gen9_exec_parse@batch-without-end.html
[166]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-rkl-5/igt@gen9_exec_parse@batch-without-end.html
* igt@i915_pm_backlight@fade_with_suspend:
- {shard-rkl}: [SKIP][167] ([i915#3012]) -> [PASS][168]
[167]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-rkl-2/igt@i915_pm_backlight@fade_with_suspend.html
[168]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-rkl-6/igt@i915_pm_backlight@fade_with_suspend.html
* igt@i915_pm_rc6_residency@rc6-idle@vcs0:
- shard-apl: [WARN][169] ([i915#6405]) -> [PASS][170]
[169]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-apl3/igt@i915_pm_rc6_residency@rc6-idle@vcs0.html
[170]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-apl7/igt@i915_pm_rc6_residency@rc6-idle@vcs0.html
* igt@i915_pm_rpm@dpms-lpsp:
- {shard-rkl}: [SKIP][171] ([i915#1397]) -> [PASS][172] +1 similar issue
[171]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-rkl-5/igt@i915_pm_rpm@dpms-lpsp.html
[172]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-rkl-6/igt@i915_pm_rpm@dpms-lpsp.html
* igt@i915_pm_sseu@full-enable:
- {shard-rkl}: [SKIP][173] ([i915#4387]) -> [PASS][174]
[173]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-rkl-1/igt@i915_pm_sseu@full-enable.html
[174]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-rkl-5/igt@i915_pm_sseu@full-enable.html
* igt@kms_cursor_legacy@cursor-vs-flip@atomic-transitions:
- shard-tglb: [INCOMPLETE][175] -> [PASS][176]
[175]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-tglb8/igt@kms_cursor_legacy@cursor-vs-flip@atomic-transitions.html
[176]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-tglb1/igt@kms_cursor_legacy@cursor-vs-flip@atomic-transitions.html
* igt@kms_draw_crc@draw-method-xrgb8888-pwrite-xtiled:
- {shard-rkl}: [SKIP][177] ([fdo#111314] / [i915#4098] / [i915#4369]) -> [PASS][178] +9 similar issues
[177]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-rkl-2/igt@kms_draw_crc@draw-method-xrgb8888-pwrite-xtiled.html
[178]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-rkl-6/igt@kms_draw_crc@draw-method-xrgb8888-pwrite-xtiled.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a2:
- shard-glk: [FAIL][179] ([i915#79]) -> [PASS][180]
[179]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-glk6/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a2.html
[180]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-glk8/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a2.html
* igt@kms_flip@plain-flip-ts-check-interruptible@b-hdmi-a1:
- shard-glk: [FAIL][181] ([i915#2122]) -> [PASS][182]
[181]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-glk2/igt@kms_flip@plain-flip-ts-check-interruptible@b-hdmi-a1.html
[182]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-glk1/igt@kms_flip@plain-flip-ts-check-interruptible@b-hdmi-a1.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt:
- {shard-rkl}: [SKIP][183] ([i915#1849] / [i915#4098]) -> [PASS][184] +15 similar issues
[183]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-rkl-2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt.html
[184]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-rkl-6/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt.html
* igt@kms_hdr@bpc-switch-dpms@pipe-a-dp-1:
- shard-kbl: [FAIL][185] ([i915#1188]) -> [PASS][186] +1 similar issue
[185]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-kbl4/igt@kms_hdr@bpc-switch-dpms@pipe-a-dp-1.html
[186]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-kbl7/igt@kms_hdr@bpc-switch-dpms@pipe-a-dp-1.html
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- {shard-rkl}: [SKIP][187] ([i915#1849] / [i915#4070] / [i915#4098]) -> [PASS][188]
[187]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-rkl-2/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
[188]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-rkl-6/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
* igt@kms_plane_multiple@atomic-pipe-a-tiling-y:
- {shard-rkl}: [SKIP][189] ([i915#1849] / [i915#3558]) -> [PASS][190] +2 similar issues
[189]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-rkl-5/igt@kms_plane_multiple@atomic-pipe-a-tiling-y.html
[190]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-rkl-6/igt@kms_plane_multiple@atomic-pipe-a-tiling-y.html
* igt@kms_psr@cursor_plane_move:
- {shard-rkl}: [SKIP][191] ([i915#1072]) -> [PASS][192]
[191]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-rkl-2/igt@kms_psr@cursor_plane_move.html
[192]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-rkl-6/igt@kms_psr@cursor_plane_move.html
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [SKIP][193] ([fdo#109441]) -> [PASS][194]
[193]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-iclb1/igt@kms_psr@psr2_primary_mmap_cpu.html
[194]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
* igt@kms_universal_plane@disable-primary-vs-flip-pipe-a:
- {shard-rkl}: [SKIP][195] ([i915#1845] / [i915#4070] / [i915#4098]) -> [PASS][196]
[195]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-rkl-2/igt@kms_universal_plane@disable-primary-vs-flip-pipe-a.html
[196]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-rkl-6/igt@kms_universal_plane@disable-primary-vs-flip-pipe-a.html
* igt@kms_vblank@pipe-b-query-forked:
- {shard-rkl}: [SKIP][197] ([i915#1845] / [i915#4098]) -> [PASS][198] +29 similar issues
[197]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-rkl-5/igt@kms_vblank@pipe-b-query-forked.html
[198]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-rkl-6/igt@kms_vblank@pipe-b-query-forked.html
#### Warnings ####
* igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-64bpp-yftile-upscaling@pipe-a-default-mode:
- shard-skl: [SKIP][199] ([fdo#109271] / [i915#1888]) -> [SKIP][200] ([fdo#109271])
[199]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-skl1/igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-64bpp-yftile-upscaling@pipe-a-default-mode.html
[200]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-skl1/igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-64bpp-yftile-upscaling@pipe-a-default-mode.html
* igt@kms_psr2_su@page_flip-nv12:
- shard-iclb: [SKIP][201] ([fdo#109642] / [fdo#111068] / [i915#658]) -> [FAIL][202] ([i915#5939])
[201]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-iclb1/igt@kms_psr2_su@page_flip-nv12.html
[202]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-iclb2/igt@kms_psr2_su@page_flip-nv12.html
* igt@runner@aborted:
- shard-skl: ([FAIL][203], [FAIL][204]) ([i915#3002] / [i915#4312] / [i915#5257]) -> ([FAIL][205], [FAIL][206], [FAIL][207]) ([i915#2029] / [i915#3002] / [i915#4312] / [i915#5257])
[203]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-skl6/igt@runner@aborted.html
[204]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-skl5/igt@runner@aborted.html
[205]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-skl5/igt@runner@aborted.html
[206]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-skl10/igt@runner@aborted.html
[207]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-skl1/igt@runner@aborted.html
- shard-kbl: ([FAIL][208], [FAIL][209], [FAIL][210]) ([fdo#109271] / [i915#3002] / [i915#4312] / [i915#5257] / [i915#716]) -> ([FAIL][211], [FAIL][212]) ([i915#3002] / [i915#4312] / [i915#5257])
[208]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-kbl1/igt@runner@aborted.html
[209]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-kbl7/igt@runner@aborted.html
[210]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11893/shard-kbl4/igt@runner@aborted.html
[211]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-kbl1/igt@runner@aborted.html
[212]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/shard-kbl6/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111314]: https://bugs.freedesktop.org/show_bug.cgi?id=111314
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1063]: https://gitlab.freedesktop.org/drm/intel/issues/1063
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#160]: https://gitlab.freedesktop.org/drm/intel/issues/160
[i915#1769]: https://gitlab.freedesktop.org/drm/intel/issues/1769
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#2029]: https://gitlab.freedesktop.org/drm/intel/issues/2029
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2410]: https://gitlab.freedesktop.org/drm/intel/issues/2410
[i915#2411]: https://gitlab.freedesktop.org/drm/intel/issues/2411
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2530]: https://gitlab.freedesktop.org/drm/intel/issues/2530
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#2849]: https://gitlab.freedesktop.org/drm/intel/issues/2849
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
[i915#3063]: https://gitlab.freedesktop.org/drm/intel/issues/3063
[i915#3070]: https://gitlab.freedesktop.org/drm/intel/issues/3070
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3467]: https://gitlab.freedesktop.org/drm/intel/issues/3467
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
[i915#3763]: https://gitlab.freedesktop.org/drm/intel/issues/3763
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#3989]: https://gitlab.freedesktop.org/drm/intel/issues/3989
[i915#404]: https://gitlab.freedesktop.org/drm/intel/issues/404
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4171]: https://gitlab.freedesktop.org/drm/intel/issues/4171
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4369]: https://gitlab.freedesktop.org/drm/intel/issues/4369
[i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387
[i915#4462]: https://gitlab.freedesktop.org/drm/intel/issues/4462
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4839]: https://gitlab.freedesktop.org/drm/intel/issues/4839
[i915#4893]: https://gitlab.freedesktop.org/drm/intel/issues/4893
[i915#4991]: https://gitlab.freedesktop.org/drm/intel/issues/4991
[i915#5032]: https://gitlab.freedesktop.org/drm/intel/issues/5032
[i915#5072]: https://gitlab.freedesktop.org/drm/intel/issues/5072
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5257]: https://gitlab.freedesktop.org/drm/intel/issues/5257
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5287]: https://gitlab.freedesktop.org/drm/intel/issues/5287
[i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#5327]: https://gitlab.freedesktop.org/drm/intel/issues/5327
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5748]: https://gitlab.freedesktop.org/drm/intel/issues/5748
[i915#5939]: https://gitlab.freedesktop.org/drm/intel/issues/5939
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6230]: https://gitlab.freedesktop.org/drm/intel/issues/6230
[i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
[i915#6251]: https://gitlab.freedesktop.org/drm/intel/issues/6251
[i915#6252]: https://gitlab.freedesktop.org/drm/intel/issues/6252
[i915#6405]: https://gitlab.freedesktop.org/drm/intel/issues/6405
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
Build changes
-------------
* Linux: CI_DRM_11893 -> Patchwork_106357v2
CI-20190529: 20190529
CI_DRM_11893: 932d346f9726fae3af81aba5e4362b428f6e3c56 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6582: c7f7fabcd7c075bfee48cbb79b5990894743204d @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_106357v2: 932d346f9726fae3af81aba5e4362b428f6e3c56 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106357v2/index.html
[-- Attachment #2: Type: text/html, Size: 56846 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Intel-gfx] [PATCH 1/2] Revert "drm/i915/display: Ensure PSR gets disabled if no encoders in new state"
2022-07-14 15:07 [Intel-gfx] [PATCH 1/2] Revert "drm/i915/display: Ensure PSR gets disabled if no encoders in new state" José Roberto de Souza
` (3 preceding siblings ...)
2022-07-15 1:15 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
@ 2022-07-15 5:21 ` Hogander, Jouni
4 siblings, 0 replies; 9+ messages in thread
From: Hogander, Jouni @ 2022-07-15 5:21 UTC (permalink / raw)
To: intel-gfx@lists.freedesktop.org, Souza, Jose
On Thu, 2022-07-14 at 08:07 -0700, José Roberto de Souza wrote:
> This patches fixes a issue but not in the right way as
> for_each_oldnew_intel_crtc_in_state() will interate over all CRTCs
> not only the crtc passed as parameter, also this two for_each loops
> are not necessary and only make code harder to understand.
Reviewed-by: Jouni Högander <jouni.hogander@intel.com>
>
> Proper fix will be discussed in the next patch.
>
> This reverts commit 75f664903d8672897333b86bb450335ec6486ad5.
>
> Cc: Jouni Högander <jouni.hogander@intel.com>
> Cc: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_psr.c | 53 ++++++++++----------
> ----
> 1 file changed, 22 insertions(+), 31 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_psr.c
> b/drivers/gpu/drm/i915/display/intel_psr.c
> index 90599dd1cb1b5..e6a870641cd25 100644
> --- a/drivers/gpu/drm/i915/display/intel_psr.c
> +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> @@ -1863,45 +1863,36 @@ void intel_psr_pre_plane_update(struct
> intel_atomic_state *state,
> struct intel_crtc *crtc)
> {
> struct drm_i915_private *i915 = to_i915(state->base.dev);
> - struct intel_crtc_state *new_crtc_state, *old_crtc_state;
> - int i;
> + const struct intel_crtc_state *crtc_state =
> + intel_atomic_get_new_crtc_state(state, crtc);
> + struct intel_encoder *encoder;
>
> if (!HAS_PSR(i915))
> return;
>
> - for_each_oldnew_intel_crtc_in_state(state, crtc,
> old_crtc_state,
> - new_crtc_state, i) {
> - struct intel_encoder *encoder;
> - u32 old_new_encoder_mask = old_crtc_state-
> >uapi.encoder_mask |
> - new_crtc_state->uapi.encoder_mask;
> -
> - for_each_intel_encoder_mask_with_psr(state->base.dev,
> encoder,
> - old_new_encoder_ma
> sk) {
> - struct intel_dp *intel_dp =
> enc_to_intel_dp(encoder);
> - struct intel_psr *psr = &intel_dp->psr;
> - bool needs_to_disable = false;
> + for_each_intel_encoder_mask_with_psr(state->base.dev, encoder,
> + crtc_state-
> >uapi.encoder_mask) {
> + struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
> + struct intel_psr *psr = &intel_dp->psr;
> + bool needs_to_disable = false;
>
> - mutex_lock(&psr->lock);
> + mutex_lock(&psr->lock);
>
> - /*
> - * Reasons to disable:
> - * - PSR disabled in new state
> - * - All planes will go inactive
> - * - Changing between PSR versions
> - * - Encoder isn't present in new mask
> - */
> - needs_to_disable |=
> intel_crtc_needs_modeset(new_crtc_state);
> - needs_to_disable |= !new_crtc_state->has_psr;
> - needs_to_disable |= !new_crtc_state-
> >active_planes;
> - needs_to_disable |= new_crtc_state->has_psr2 !=
> psr->psr2_enabled;
> - needs_to_disable |= !(new_crtc_state-
> >uapi.encoder_mask &
> - drm_encoder_mask(&(encode
> r)->base));
> + /*
> + * Reasons to disable:
> + * - PSR disabled in new state
> + * - All planes will go inactive
> + * - Changing between PSR versions
> + */
> + needs_to_disable |=
> intel_crtc_needs_modeset(crtc_state);
> + needs_to_disable |= !crtc_state->has_psr;
> + needs_to_disable |= !crtc_state->active_planes;
> + needs_to_disable |= crtc_state->has_psr2 != psr-
> >psr2_enabled;
>
> - if (psr->enabled && needs_to_disable)
> - intel_psr_disable_locked(intel_dp);
> + if (psr->enabled && needs_to_disable)
> + intel_psr_disable_locked(intel_dp);
>
> - mutex_unlock(&psr->lock);
> - }
> + mutex_unlock(&psr->lock);
> }
> }
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Intel-gfx] [PATCH 2/2] drm/i915/psr: Disable PSR before disable pipe
2022-07-14 15:07 ` [Intel-gfx] [PATCH 2/2] drm/i915/psr: Disable PSR before disable pipe José Roberto de Souza
@ 2022-07-15 5:33 ` Hogander, Jouni
2022-07-15 8:39 ` Lisovskiy, Stanislav
0 siblings, 1 reply; 9+ messages in thread
From: Hogander, Jouni @ 2022-07-15 5:33 UTC (permalink / raw)
To: intel-gfx@lists.freedesktop.org, Souza, Jose
On Thu, 2022-07-14 at 08:07 -0700, José Roberto de Souza wrote:
> The issue here was on for_each_intel_encoder_mask_with_psr() over the
> new_crtc_state encoder mask, so if the CRTC was being disabled mask
> would be zero and it would not have any chance to disable PSR.
>
> So here doing for_each_intel_encoder_mask_with_psr() over the
> old_crtc_state encoder mask and then using the new_crtc_state to
> check if PSR needs to be disabled.
>
> Cc: Jouni Högander <jouni.hogander@intel.com>
> Cc: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_psr.c | 14 ++++++++------
> 1 file changed, 8 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_psr.c
> b/drivers/gpu/drm/i915/display/intel_psr.c
> index e6a870641cd25..98c3c8015a5c4 100644
> --- a/drivers/gpu/drm/i915/display/intel_psr.c
> +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> @@ -1863,7 +1863,9 @@ void intel_psr_pre_plane_update(struct
> intel_atomic_state *state,
> struct intel_crtc *crtc)
> {
> struct drm_i915_private *i915 = to_i915(state->base.dev);
> - const struct intel_crtc_state *crtc_state =
> + const struct intel_crtc_state *old_crtc_state =
> + intel_atomic_get_old_crtc_state(state, crtc);
> + const struct intel_crtc_state *new_crtc_state =
> intel_atomic_get_new_crtc_state(state, crtc);
> struct intel_encoder *encoder;
>
> @@ -1871,7 +1873,7 @@ void intel_psr_pre_plane_update(struct
> intel_atomic_state *state,
> return;
>
> for_each_intel_encoder_mask_with_psr(state->base.dev, encoder,
> - crtc_state-
> >uapi.encoder_mask) {
> + old_crtc_state-
> >uapi.encoder_mask) {
I would add comment here explaining why using encoder mask from
old_crtc_state, but using new_crtc_state inside the loop. It's up to
you:
Reviewed-by: Jouni Högander <jouni.hogander@intel.com>
> struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
> struct intel_psr *psr = &intel_dp->psr;
> bool needs_to_disable = false;
> @@ -1884,10 +1886,10 @@ void intel_psr_pre_plane_update(struct
> intel_atomic_state *state,
> * - All planes will go inactive
> * - Changing between PSR versions
> */
> - needs_to_disable |=
> intel_crtc_needs_modeset(crtc_state);
> - needs_to_disable |= !crtc_state->has_psr;
> - needs_to_disable |= !crtc_state->active_planes;
> - needs_to_disable |= crtc_state->has_psr2 != psr-
> >psr2_enabled;
> + needs_to_disable |=
> intel_crtc_needs_modeset(new_crtc_state);
> + needs_to_disable |= !new_crtc_state->has_psr;
> + needs_to_disable |= !new_crtc_state->active_planes;
> + needs_to_disable |= new_crtc_state->has_psr2 != psr-
> >psr2_enabled;
>
> if (psr->enabled && needs_to_disable)
> intel_psr_disable_locked(intel_dp);
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Intel-gfx] [PATCH 2/2] drm/i915/psr: Disable PSR before disable pipe
2022-07-15 5:33 ` Hogander, Jouni
@ 2022-07-15 8:39 ` Lisovskiy, Stanislav
2022-07-15 13:35 ` Souza, Jose
0 siblings, 1 reply; 9+ messages in thread
From: Lisovskiy, Stanislav @ 2022-07-15 8:39 UTC (permalink / raw)
To: Hogander, Jouni; +Cc: intel-gfx@lists.freedesktop.org
On Fri, Jul 15, 2022 at 08:33:43AM +0300, Hogander, Jouni wrote:
> On Thu, 2022-07-14 at 08:07 -0700, José Roberto de Souza wrote:
> > The issue here was on for_each_intel_encoder_mask_with_psr() over the
> > new_crtc_state encoder mask, so if the CRTC was being disabled mask
> > would be zero and it would not have any chance to disable PSR.
> >
> > So here doing for_each_intel_encoder_mask_with_psr() over the
> > old_crtc_state encoder mask and then using the new_crtc_state to
> > check if PSR needs to be disabled.
Are we sure that using old_crtc_state mask is safe here?
Because currently we would be basically mixing a usage of
encoder from old_crtc_state mask with new_crtc_state.
If you mention a specific scenario, when this happens(i.e crtc
is being disabled and new mask is 0) should we add a specific check
instructing us to use old_crtc_state mask only?
Because currently you might be touching some other scenarios as
well, that is what I'm concerned about.
Stan
> >
> > Cc: Jouni Högander <jouni.hogander@intel.com>
> > Cc: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
> > Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> > ---
> > drivers/gpu/drm/i915/display/intel_psr.c | 14 ++++++++------
> > 1 file changed, 8 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_psr.c
> > b/drivers/gpu/drm/i915/display/intel_psr.c
> > index e6a870641cd25..98c3c8015a5c4 100644
> > --- a/drivers/gpu/drm/i915/display/intel_psr.c
> > +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> > @@ -1863,7 +1863,9 @@ void intel_psr_pre_plane_update(struct
> > intel_atomic_state *state,
> > struct intel_crtc *crtc)
> > {
> > struct drm_i915_private *i915 = to_i915(state->base.dev);
> > - const struct intel_crtc_state *crtc_state =
> > + const struct intel_crtc_state *old_crtc_state =
> > + intel_atomic_get_old_crtc_state(state, crtc);
> > + const struct intel_crtc_state *new_crtc_state =
> > intel_atomic_get_new_crtc_state(state, crtc);
> > struct intel_encoder *encoder;
> >
> > @@ -1871,7 +1873,7 @@ void intel_psr_pre_plane_update(struct
> > intel_atomic_state *state,
> > return;
> >
> > for_each_intel_encoder_mask_with_psr(state->base.dev, encoder,
> > - crtc_state-
> > >uapi.encoder_mask) {
> > + old_crtc_state-
> > >uapi.encoder_mask) {
>
> I would add comment here explaining why using encoder mask from
> old_crtc_state, but using new_crtc_state inside the loop. It's up to
> you:
>
> Reviewed-by: Jouni Högander <jouni.hogander@intel.com>
>
> > struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
> > struct intel_psr *psr = &intel_dp->psr;
> > bool needs_to_disable = false;
> > @@ -1884,10 +1886,10 @@ void intel_psr_pre_plane_update(struct
> > intel_atomic_state *state,
> > * - All planes will go inactive
> > * - Changing between PSR versions
> > */
> > - needs_to_disable |=
> > intel_crtc_needs_modeset(crtc_state);
> > - needs_to_disable |= !crtc_state->has_psr;
> > - needs_to_disable |= !crtc_state->active_planes;
> > - needs_to_disable |= crtc_state->has_psr2 != psr-
> > >psr2_enabled;
> > + needs_to_disable |=
> > intel_crtc_needs_modeset(new_crtc_state);
> > + needs_to_disable |= !new_crtc_state->has_psr;
> > + needs_to_disable |= !new_crtc_state->active_planes;
> > + needs_to_disable |= new_crtc_state->has_psr2 != psr-
> > >psr2_enabled;
> >
> > if (psr->enabled && needs_to_disable)
> > intel_psr_disable_locked(intel_dp);
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Intel-gfx] [PATCH 2/2] drm/i915/psr: Disable PSR before disable pipe
2022-07-15 8:39 ` Lisovskiy, Stanislav
@ 2022-07-15 13:35 ` Souza, Jose
0 siblings, 0 replies; 9+ messages in thread
From: Souza, Jose @ 2022-07-15 13:35 UTC (permalink / raw)
To: Lisovskiy, Stanislav, Hogander, Jouni; +Cc: intel-gfx@lists.freedesktop.org
On Fri, 2022-07-15 at 11:39 +0300, Lisovskiy, Stanislav wrote:
> On Fri, Jul 15, 2022 at 08:33:43AM +0300, Hogander, Jouni wrote:
> > On Thu, 2022-07-14 at 08:07 -0700, José Roberto de Souza wrote:
> > > The issue here was on for_each_intel_encoder_mask_with_psr() over the
> > > new_crtc_state encoder mask, so if the CRTC was being disabled mask
> > > would be zero and it would not have any chance to disable PSR.
> > >
> > > So here doing for_each_intel_encoder_mask_with_psr() over the
> > > old_crtc_state encoder mask and then using the new_crtc_state to
> > > check if PSR needs to be disabled.
>
> Are we sure that using old_crtc_state mask is safe here?
> Because currently we would be basically mixing a usage of
> encoder from old_crtc_state mask with new_crtc_state.
>
> If you mention a specific scenario, when this happens(i.e crtc
> is being disabled and new mask is 0) should we add a specific check
> instructing us to use old_crtc_state mask only?
>
This scenario were new_crtc_state is being disabled(ie encoder_mask = 0) is handled by intel_crtc_needs_modeset() check.
This same check will handle more complicated cases like pipe A(with PSR) now will drive a different port...
> Because currently you might be touching some other scenarios as
> well, that is what I'm concerned about.
>
>
> Stan
>
> > >
> > > Cc: Jouni Högander <jouni.hogander@intel.com>
> > > Cc: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
> > > Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> > > ---
> > > drivers/gpu/drm/i915/display/intel_psr.c | 14 ++++++++------
> > > 1 file changed, 8 insertions(+), 6 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/display/intel_psr.c
> > > b/drivers/gpu/drm/i915/display/intel_psr.c
> > > index e6a870641cd25..98c3c8015a5c4 100644
> > > --- a/drivers/gpu/drm/i915/display/intel_psr.c
> > > +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> > > @@ -1863,7 +1863,9 @@ void intel_psr_pre_plane_update(struct
> > > intel_atomic_state *state,
> > > struct intel_crtc *crtc)
> > > {
> > > struct drm_i915_private *i915 = to_i915(state->base.dev);
> > > - const struct intel_crtc_state *crtc_state =
> > > + const struct intel_crtc_state *old_crtc_state =
> > > + intel_atomic_get_old_crtc_state(state, crtc);
> > > + const struct intel_crtc_state *new_crtc_state =
> > > intel_atomic_get_new_crtc_state(state, crtc);
> > > struct intel_encoder *encoder;
> > >
> > > @@ -1871,7 +1873,7 @@ void intel_psr_pre_plane_update(struct
> > > intel_atomic_state *state,
> > > return;
> > >
> > > for_each_intel_encoder_mask_with_psr(state->base.dev, encoder,
> > > - crtc_state-
> > > > uapi.encoder_mask) {
> > > + old_crtc_state-
> > > > uapi.encoder_mask) {
> >
> > I would add comment here explaining why using encoder mask from
> > old_crtc_state, but using new_crtc_state inside the loop. It's up to
> > you:
> >
> > Reviewed-by: Jouni Högander <jouni.hogander@intel.com>
> >
> > > struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
> > > struct intel_psr *psr = &intel_dp->psr;
> > > bool needs_to_disable = false;
> > > @@ -1884,10 +1886,10 @@ void intel_psr_pre_plane_update(struct
> > > intel_atomic_state *state,
> > > * - All planes will go inactive
> > > * - Changing between PSR versions
> > > */
> > > - needs_to_disable |=
> > > intel_crtc_needs_modeset(crtc_state);
> > > - needs_to_disable |= !crtc_state->has_psr;
> > > - needs_to_disable |= !crtc_state->active_planes;
> > > - needs_to_disable |= crtc_state->has_psr2 != psr-
> > > > psr2_enabled;
> > > + needs_to_disable |=
> > > intel_crtc_needs_modeset(new_crtc_state);
> > > + needs_to_disable |= !new_crtc_state->has_psr;
> > > + needs_to_disable |= !new_crtc_state->active_planes;
> > > + needs_to_disable |= new_crtc_state->has_psr2 != psr-
> > > > psr2_enabled;
> > >
> > > if (psr->enabled && needs_to_disable)
> > > intel_psr_disable_locked(intel_dp);
> >
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2022-07-16 14:36 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-14 15:07 [Intel-gfx] [PATCH 1/2] Revert "drm/i915/display: Ensure PSR gets disabled if no encoders in new state" José Roberto de Souza
2022-07-14 15:07 ` [Intel-gfx] [PATCH 2/2] drm/i915/psr: Disable PSR before disable pipe José Roberto de Souza
2022-07-15 5:33 ` Hogander, Jouni
2022-07-15 8:39 ` Lisovskiy, Stanislav
2022-07-15 13:35 ` Souza, Jose
2022-07-14 15:53 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] Revert "drm/i915/display: Ensure PSR gets disabled if no encoders in new state" Patchwork
2022-07-14 18:55 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] Revert "drm/i915/display: Ensure PSR gets disabled if no encoders in new state" (rev2) Patchwork
2022-07-15 1:15 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-07-15 5:21 ` [Intel-gfx] [PATCH 1/2] Revert "drm/i915/display: Ensure PSR gets disabled if no encoders in new state" Hogander, Jouni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox