* [Intel-gfx] [PATCH] drm/i915/selftests: Fix comment typo
@ 2022-07-16 4:05 Jason Wang
2022-07-20 15:37 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/selftests: Fix comment typo (rev2) Patchwork
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Jason Wang @ 2022-07-16 4:05 UTC (permalink / raw)
To: daniel
Cc: Jason Wang, michal.winiarski, airlied, intel-gfx, linux-kernel,
dri-devel, rodrigo.vivi, zhou1615
Fix the double `wait' typo in comment.
Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
---
drivers/gpu/drm/i915/selftests/i915_request.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/selftests/i915_request.c b/drivers/gpu/drm/i915/selftests/i915_request.c
index c56a0c2cd2f7..ec05f578a698 100644
--- a/drivers/gpu/drm/i915/selftests/i915_request.c
+++ b/drivers/gpu/drm/i915/selftests/i915_request.c
@@ -971,7 +971,7 @@ static struct i915_vma *empty_batch(struct drm_i915_private *i915)
if (err)
goto err;
- /* Force the wait wait now to avoid including it in the benchmark */
+ /* Force the wait now to avoid including it in the benchmark */
err = i915_vma_sync(vma);
if (err)
goto err_pin;
--
2.35.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/selftests: Fix comment typo (rev2)
2022-07-16 4:05 [Intel-gfx] [PATCH] drm/i915/selftests: Fix comment typo Jason Wang
@ 2022-07-20 15:37 ` Patchwork
2022-07-20 16:56 ` [Intel-gfx] [PATCH] drm/i915/selftests: Fix comment typo Andrzej Hajda
2022-07-21 13:08 ` Andi Shyti
2 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2022-07-20 15:37 UTC (permalink / raw)
To: Jason Wang; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 11116 bytes --]
== Series Details ==
Series: drm/i915/selftests: Fix comment typo (rev2)
URL : https://patchwork.freedesktop.org/series/106534/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11928 -> Patchwork_106534v2
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_106534v2 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_106534v2, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106534v2/index.html
Participating hosts (37 -> 35)
------------------------------
Additional (5): fi-kbl-soraka fi-bxt-dsi fi-cfl-8700k fi-kbl-x1275 fi-kbl-8809g
Missing (7): bat-dg1-5 fi-icl-u2 bat-dg2-9 bat-adlp-6 bat-adlp-4 bat-adln-1 bat-rpls-2
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_106534v2:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@reset:
- fi-kbl-soraka: NOTRUN -> [INCOMPLETE][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106534v2/fi-kbl-soraka/igt@i915_selftest@live@reset.html
Known issues
------------
Here are the changes found in Patchwork_106534v2 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_gttfill@basic:
- fi-kbl-soraka: NOTRUN -> [SKIP][2] ([fdo#109271]) +8 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106534v2/fi-kbl-soraka/igt@gem_exec_gttfill@basic.html
* igt@gem_huc_copy@huc-copy:
- fi-kbl-8809g: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#2190])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106534v2/fi-kbl-8809g/igt@gem_huc_copy@huc-copy.html
- fi-bxt-dsi: NOTRUN -> [SKIP][4] ([fdo#109271] / [i915#2190])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106534v2/fi-bxt-dsi/igt@gem_huc_copy@huc-copy.html
- fi-cfl-8700k: NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#2190])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106534v2/fi-cfl-8700k/igt@gem_huc_copy@huc-copy.html
- fi-kbl-x1275: NOTRUN -> [SKIP][6] ([fdo#109271] / [i915#2190])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106534v2/fi-kbl-x1275/igt@gem_huc_copy@huc-copy.html
- fi-kbl-soraka: NOTRUN -> [SKIP][7] ([fdo#109271] / [i915#2190])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106534v2/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@basic:
- fi-kbl-soraka: NOTRUN -> [SKIP][8] ([fdo#109271] / [i915#4613]) +3 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106534v2/fi-kbl-soraka/igt@gem_lmem_swapping@basic.html
- fi-cfl-8700k: NOTRUN -> [SKIP][9] ([fdo#109271] / [i915#4613]) +3 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106534v2/fi-cfl-8700k/igt@gem_lmem_swapping@basic.html
- fi-kbl-8809g: NOTRUN -> [SKIP][10] ([fdo#109271] / [i915#4613]) +3 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106534v2/fi-kbl-8809g/igt@gem_lmem_swapping@basic.html
* igt@gem_lmem_swapping@verify-random:
- fi-kbl-x1275: NOTRUN -> [SKIP][11] ([fdo#109271] / [i915#4613]) +3 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106534v2/fi-kbl-x1275/igt@gem_lmem_swapping@verify-random.html
- fi-bxt-dsi: NOTRUN -> [SKIP][12] ([fdo#109271] / [i915#4613]) +3 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106534v2/fi-bxt-dsi/igt@gem_lmem_swapping@verify-random.html
* igt@gem_tiled_blits@basic:
- fi-bxt-dsi: NOTRUN -> [SKIP][13] ([fdo#109271]) +12 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106534v2/fi-bxt-dsi/igt@gem_tiled_blits@basic.html
* igt@i915_selftest@live@gem:
- fi-blb-e6850: NOTRUN -> [DMESG-FAIL][14] ([i915#4528])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106534v2/fi-blb-e6850/igt@i915_selftest@live@gem.html
* igt@i915_selftest@live@gt_lrc:
- fi-bsw-n3050: [PASS][15] -> [DMESG-FAIL][16] ([i915#2373])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11928/fi-bsw-n3050/igt@i915_selftest@live@gt_lrc.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106534v2/fi-bsw-n3050/igt@i915_selftest@live@gt_lrc.html
* igt@i915_selftest@live@gt_pm:
- fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][17] ([i915#1886])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106534v2/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html
* igt@i915_selftest@live@hangcheck:
- fi-snb-2600: [PASS][18] -> [INCOMPLETE][19] ([i915#3921])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11928/fi-snb-2600/igt@i915_selftest@live@hangcheck.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106534v2/fi-snb-2600/igt@i915_selftest@live@hangcheck.html
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-kbl-8809g: NOTRUN -> [SKIP][20] ([fdo#109271] / [fdo#111827]) +8 similar issues
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106534v2/fi-kbl-8809g/igt@kms_chamelium@common-hpd-after-suspend.html
* igt@kms_chamelium@dp-crc-fast:
- fi-kbl-x1275: NOTRUN -> [SKIP][21] ([fdo#109271] / [fdo#111827]) +8 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106534v2/fi-kbl-x1275/igt@kms_chamelium@dp-crc-fast.html
* igt@kms_chamelium@dp-hpd-fast:
- fi-cfl-8700k: NOTRUN -> [SKIP][22] ([fdo#109271] / [fdo#111827]) +8 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106534v2/fi-cfl-8700k/igt@kms_chamelium@dp-hpd-fast.html
* igt@kms_chamelium@hdmi-edid-read:
- fi-bxt-dsi: NOTRUN -> [SKIP][23] ([fdo#109271] / [fdo#111827]) +8 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106534v2/fi-bxt-dsi/igt@kms_chamelium@hdmi-edid-read.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-soraka: NOTRUN -> [SKIP][24] ([fdo#109271] / [fdo#111827]) +7 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106534v2/fi-kbl-soraka/igt@kms_chamelium@hdmi-hpd-fast.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor:
- fi-cfl-8700k: NOTRUN -> [SKIP][25] ([fdo#109271]) +10 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106534v2/fi-cfl-8700k/igt@kms_cursor_legacy@basic-busy-flip-before-cursor.html
- fi-kbl-8809g: NOTRUN -> [SKIP][26] ([fdo#109271]) +26 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106534v2/fi-kbl-8809g/igt@kms_cursor_legacy@basic-busy-flip-before-cursor.html
* igt@prime_vgem@basic-userptr:
- fi-kbl-x1275: NOTRUN -> [SKIP][27] ([fdo#109271]) +11 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106534v2/fi-kbl-x1275/igt@prime_vgem@basic-userptr.html
* igt@runner@aborted:
- fi-bsw-n3050: NOTRUN -> [FAIL][28] ([fdo#109271] / [i915#4312])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106534v2/fi-bsw-n3050/igt@runner@aborted.html
#### Possible fixes ####
* igt@i915_pm_rpm@module-reload:
- fi-cfl-8109u: [DMESG-FAIL][29] ([i915#62]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11928/fi-cfl-8109u/igt@i915_pm_rpm@module-reload.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106534v2/fi-cfl-8109u/igt@i915_pm_rpm@module-reload.html
* igt@i915_selftest@live@requests:
- fi-blb-e6850: [DMESG-FAIL][31] ([i915#4528]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11928/fi-blb-e6850/igt@i915_selftest@live@requests.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106534v2/fi-blb-e6850/igt@i915_selftest@live@requests.html
* igt@i915_selftest@live@ring_submission:
- fi-cfl-8109u: [DMESG-WARN][33] ([i915#5904]) -> [PASS][34] +29 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11928/fi-cfl-8109u/igt@i915_selftest@live@ring_submission.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106534v2/fi-cfl-8109u/igt@i915_selftest@live@ring_submission.html
* igt@i915_suspend@basic-s2idle-without-i915:
- fi-cfl-8109u: [DMESG-WARN][35] ([i915#5904] / [i915#62]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11928/fi-cfl-8109u/igt@i915_suspend@basic-s2idle-without-i915.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106534v2/fi-cfl-8109u/igt@i915_suspend@basic-s2idle-without-i915.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size:
- fi-bsw-kefka: [FAIL][37] ([i915#6298]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11928/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106534v2/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size.html
* igt@kms_frontbuffer_tracking@basic:
- fi-cfl-8109u: [DMESG-WARN][39] ([i915#62]) -> [PASS][40] +12 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11928/fi-cfl-8109u/igt@kms_frontbuffer_tracking@basic.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106534v2/fi-cfl-8109u/igt@kms_frontbuffer_tracking@basic.html
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2373]: https://gitlab.freedesktop.org/drm/intel/issues/2373
[i915#3921]: https://gitlab.freedesktop.org/drm/intel/issues/3921
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#5904]: https://gitlab.freedesktop.org/drm/intel/issues/5904
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#6298]: https://gitlab.freedesktop.org/drm/intel/issues/6298
Build changes
-------------
* Linux: CI_DRM_11928 -> Patchwork_106534v2
CI-20190529: 20190529
CI_DRM_11928: 8aa8753730556013fd562e01965e5dd571ae55ea @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6593: 6ac554e19b3bb4232877367911e9185e5d35296f @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_106534v2: 8aa8753730556013fd562e01965e5dd571ae55ea @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
ea846f8654e8 drm/i915/selftests: Fix comment typo
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106534v2/index.html
[-- Attachment #2: Type: text/html, Size: 14842 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [Intel-gfx] [PATCH] drm/i915/selftests: Fix comment typo
2022-07-16 4:05 [Intel-gfx] [PATCH] drm/i915/selftests: Fix comment typo Jason Wang
2022-07-20 15:37 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/selftests: Fix comment typo (rev2) Patchwork
@ 2022-07-20 16:56 ` Andrzej Hajda
2022-07-21 8:08 ` Rodrigo Vivi
2022-07-21 13:08 ` Andi Shyti
2 siblings, 1 reply; 8+ messages in thread
From: Andrzej Hajda @ 2022-07-20 16:56 UTC (permalink / raw)
To: Jason Wang, daniel
Cc: michal.winiarski, airlied, intel-gfx, linux-kernel, dri-devel,
rodrigo.vivi, zhou1615
On 16.07.2022 06:05, Jason Wang wrote:
> Fix the double `wait' typo in comment.
>
> Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
> ---
> drivers/gpu/drm/i915/selftests/i915_request.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/selftests/i915_request.c b/drivers/gpu/drm/i915/selftests/i915_request.c
> index c56a0c2cd2f7..ec05f578a698 100644
> --- a/drivers/gpu/drm/i915/selftests/i915_request.c
> +++ b/drivers/gpu/drm/i915/selftests/i915_request.c
> @@ -971,7 +971,7 @@ static struct i915_vma *empty_batch(struct drm_i915_private *i915)
> if (err)
> goto err;
>
> - /* Force the wait wait now to avoid including it in the benchmark */
> + /* Force the wait now to avoid including it in the benchmark */
> err = i915_vma_sync(vma);
> if (err)
> goto err_pin;
Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
Regards
Andrzej
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/selftests: Fix comment typo
2022-07-20 16:56 ` [Intel-gfx] [PATCH] drm/i915/selftests: Fix comment typo Andrzej Hajda
@ 2022-07-21 8:08 ` Rodrigo Vivi
0 siblings, 0 replies; 8+ messages in thread
From: Rodrigo Vivi @ 2022-07-21 8:08 UTC (permalink / raw)
To: Andrzej Hajda
Cc: michal.winiarski, airlied, intel-gfx, linux-kernel, Jason Wang,
dri-devel, zhou1615
On Wed, Jul 20, 2022 at 06:56:16PM +0200, Andrzej Hajda wrote:
> On 16.07.2022 06:05, Jason Wang wrote:
> > Fix the double `wait' typo in comment.
> >
> > Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
> > ---
> > drivers/gpu/drm/i915/selftests/i915_request.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/selftests/i915_request.c b/drivers/gpu/drm/i915/selftests/i915_request.c
> > index c56a0c2cd2f7..ec05f578a698 100644
> > --- a/drivers/gpu/drm/i915/selftests/i915_request.c
> > +++ b/drivers/gpu/drm/i915/selftests/i915_request.c
> > @@ -971,7 +971,7 @@ static struct i915_vma *empty_batch(struct drm_i915_private *i915)
> > if (err)
> > goto err;
> > - /* Force the wait wait now to avoid including it in the benchmark */
> > + /* Force the wait now to avoid including it in the benchmark */
> > err = i915_vma_sync(vma);
> > if (err)
> > goto err_pin;
>
> Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
Thanks for the patch and review. Pushed to drm-intel-gt-next.
>
> Regards
> Andrzej
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/selftests: Fix comment typo
2022-07-16 4:05 [Intel-gfx] [PATCH] drm/i915/selftests: Fix comment typo Jason Wang
2022-07-20 15:37 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/selftests: Fix comment typo (rev2) Patchwork
2022-07-20 16:56 ` [Intel-gfx] [PATCH] drm/i915/selftests: Fix comment typo Andrzej Hajda
@ 2022-07-21 13:08 ` Andi Shyti
2022-07-21 13:19 ` Andi Shyti
2 siblings, 1 reply; 8+ messages in thread
From: Andi Shyti @ 2022-07-21 13:08 UTC (permalink / raw)
To: Jason Wang
Cc: michal.winiarski, airlied, intel-gfx, linux-kernel, dri-devel,
rodrigo.vivi, zhou1615
Hi Jason,
On Sat, Jul 16, 2022 at 12:05:20PM +0800, Jason Wang wrote:
> Fix the double `wait' typo in comment.
>
> Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
Few warnings for this patch:
1. you missed Rodrigo's r-b tag.
2. please add a counter to your patch, this would be [PATCH v2]
3. please add a changelog, as this is a single patch, do it
after the '---'
No need to resend, just keep the three notes in mind for your
next patches. Anyway, thanks for the fix and as I am at it:
Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Thanks,
Andi
> ---
> drivers/gpu/drm/i915/selftests/i915_request.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/selftests/i915_request.c b/drivers/gpu/drm/i915/selftests/i915_request.c
> index c56a0c2cd2f7..ec05f578a698 100644
> --- a/drivers/gpu/drm/i915/selftests/i915_request.c
> +++ b/drivers/gpu/drm/i915/selftests/i915_request.c
> @@ -971,7 +971,7 @@ static struct i915_vma *empty_batch(struct drm_i915_private *i915)
> if (err)
> goto err;
>
> - /* Force the wait wait now to avoid including it in the benchmark */
> + /* Force the wait now to avoid including it in the benchmark */
> err = i915_vma_sync(vma);
> if (err)
> goto err_pin;
> --
> 2.35.1
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [Intel-gfx] [PATCH] drm/i915/selftests: Fix comment typo
2022-07-21 13:08 ` Andi Shyti
@ 2022-07-21 13:19 ` Andi Shyti
0 siblings, 0 replies; 8+ messages in thread
From: Andi Shyti @ 2022-07-21 13:19 UTC (permalink / raw)
To: Andi Shyti
Cc: michal.winiarski, dri-devel, airlied, intel-gfx, linux-kernel,
Jason Wang, rodrigo.vivi, zhou1615
> On Sat, Jul 16, 2022 at 12:05:20PM +0800, Jason Wang wrote:
> > Fix the double `wait' typo in comment.
> >
> > Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
>
> Few warnings for this patch:
>
> 1. you missed Rodrigo's r-b tag.
> 2. please add a counter to your patch, this would be [PATCH v2]
> 3. please add a changelog, as this is a single patch, do it
> after the '---'
>
> No need to resend, just keep the three notes in mind for your
> next patches. Anyway, thanks for the fix and as I am at it:
>
> Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Pushed in drm-intel-next.
Thanks,
Andi
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Intel-gfx] [PATCH] drm/i915/selftests: Fix comment typo
@ 2022-07-15 5:19 Jason Wang
2022-07-18 18:28 ` Rodrigo Vivi
0 siblings, 1 reply; 8+ messages in thread
From: Jason Wang @ 2022-07-15 5:19 UTC (permalink / raw)
To: daniel
Cc: Jason Wang, michal.winiarski, airlied, intel-gfx, linux-kernel,
dri-devel, rodrigo.vivi, zhou1615
The double `wait' is duplicated in line 974, remove one.
Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
---
drivers/gpu/drm/i915/selftests/i915_request.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/selftests/i915_request.c b/drivers/gpu/drm/i915/selftests/i915_request.c
index c56a0c2cd2f7..ec05f578a698 100644
--- a/drivers/gpu/drm/i915/selftests/i915_request.c
+++ b/drivers/gpu/drm/i915/selftests/i915_request.c
@@ -971,7 +971,7 @@ static struct i915_vma *empty_batch(struct drm_i915_private *i915)
if (err)
goto err;
- /* Force the wait wait now to avoid including it in the benchmark */
+ /* Force the wait now to avoid including it in the benchmark */
err = i915_vma_sync(vma);
if (err)
goto err_pin;
--
2.35.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/selftests: Fix comment typo
2022-07-15 5:19 Jason Wang
@ 2022-07-18 18:28 ` Rodrigo Vivi
0 siblings, 0 replies; 8+ messages in thread
From: Rodrigo Vivi @ 2022-07-18 18:28 UTC (permalink / raw)
To: Jason Wang
Cc: michal.winiarski, airlied, intel-gfx, linux-kernel, dri-devel,
zhou1615
On Fri, Jul 15, 2022 at 01:19:53PM +0800, Jason Wang wrote:
> The double `wait' is duplicated in line 974, remove one.
The line number changes... if you remove the "in line #"
the msg gets better.
With that changed:
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>
> Signed-off-by: Jason Wang <wangborong@cdjrlc.com>
> ---
> drivers/gpu/drm/i915/selftests/i915_request.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/selftests/i915_request.c b/drivers/gpu/drm/i915/selftests/i915_request.c
> index c56a0c2cd2f7..ec05f578a698 100644
> --- a/drivers/gpu/drm/i915/selftests/i915_request.c
> +++ b/drivers/gpu/drm/i915/selftests/i915_request.c
> @@ -971,7 +971,7 @@ static struct i915_vma *empty_batch(struct drm_i915_private *i915)
> if (err)
> goto err;
>
> - /* Force the wait wait now to avoid including it in the benchmark */
> + /* Force the wait now to avoid including it in the benchmark */
> err = i915_vma_sync(vma);
> if (err)
> goto err_pin;
> --
> 2.35.1
>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2022-07-21 13:19 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-16 4:05 [Intel-gfx] [PATCH] drm/i915/selftests: Fix comment typo Jason Wang
2022-07-20 15:37 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/selftests: Fix comment typo (rev2) Patchwork
2022-07-20 16:56 ` [Intel-gfx] [PATCH] drm/i915/selftests: Fix comment typo Andrzej Hajda
2022-07-21 8:08 ` Rodrigo Vivi
2022-07-21 13:08 ` Andi Shyti
2022-07-21 13:19 ` Andi Shyti
-- strict thread matches above, loose matches on Subject: below --
2022-07-15 5:19 Jason Wang
2022-07-18 18:28 ` Rodrigo Vivi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox