Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Shyti <andi.shyti@linux.intel.com>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 0/4] Further multi-gt handling
Date: Thu, 15 Sep 2022 23:41:43 +0200	[thread overview]
Message-ID: <YyOcFzZnIWqkkjZ7@alfio.lan> (raw)
In-Reply-To: <87czbwsu38.fsf@intel.com>

Hi Jani,

On Thu, Sep 15, 2022 at 03:25:15PM +0300, Jani Nikula wrote:
> On Wed, 14 Sep 2022, Matt Roper <matthew.d.roper@intel.com> wrote:
> > Now that MTL is going to start providing two GTs, there are a few more
> > places in the driver that need to iterate over each GT instead of
> > operating directly on gt0.  Also some more deliberate cleanup is needed,
> > in cases where we fail GT/engine initialization after the first GT has
> > been fully setup.
> 
> Hijacking the thread a bit, not to be considered a blocker for this
> series:
> 
> Is there a plan to kzalloc i915->gt[0] too in intel_gt_probe_all() so we
> wouldn't need to have intel_gt gt0 in struct drm_i915_private? And the
> to_gt() inline would return i915->gt[0] instead of &i915->gt0? (And
> maybe i915_drv.h wouldn't need the definition of intel_gt anymore! :o)

I had a patch that was doing that and sent it long time ago and
it was rejected.

I can't find it but I will check better to see what was the
reason for it to be rejected.

Andi

  reply	other threads:[~2022-09-15 21:42 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-14 22:04 [Intel-gfx] [PATCH 0/4] Further multi-gt handling Matt Roper
2022-09-14 22:04 ` [Intel-gfx] [PATCH 1/4] drm/i915/gt: Cleanup partial engine discovery failures Matt Roper
2022-09-15 10:40   ` Janusz Krzysztofik
2022-09-14 22:04 ` [Intel-gfx] [PATCH 2/4] drm/i915: Make GEM resume all engines Matt Roper
2022-09-15 21:34   ` Andi Shyti
2022-09-14 22:04 ` [Intel-gfx] [PATCH 3/4] drm/i915: Make GEM suspend all GTs Matt Roper
2022-09-15 21:36   ` Andi Shyti
2022-09-14 22:04 ` [Intel-gfx] [PATCH 4/4] drm/i915: Handle all GTs on driver (un)load paths Matt Roper
2022-09-15  1:01   ` Ceraolo Spurio, Daniele
2022-09-15  2:18 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Further multi-gt handling Patchwork
2022-09-15  2:37 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-09-15 12:25 ` [Intel-gfx] [PATCH 0/4] " Jani Nikula
2022-09-15 21:41   ` Andi Shyti [this message]
2022-09-15 23:29   ` Matt Roper
2022-09-15 19:15 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YyOcFzZnIWqkkjZ7@alfio.lan \
    --to=andi.shyti@linux.intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox