From: Andi Shyti <andi.shyti@linux.intel.com>
To: Andrzej Hajda <andrzej.hajda@intel.com>
Cc: intel-gfx@lists.freedesktop.org,
Lucas De Marchi <lucas.demarchi@intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [Intel-gfx] [PATCH 4/4] drm/i915: use proper helper for register updates
Date: Tue, 4 Oct 2022 01:44:08 +0200 [thread overview]
Message-ID: <YztzyOJh6Bsu3CX2@ashyti-mobl2.lan> (raw)
In-Reply-To: <20221003223258.2650934-5-andrzej.hajda@intel.com>
Hi Andrzej,
[...]
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index 2595ec5aeb77f6..c07c97f4036abd 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -885,38 +885,28 @@ static void pnv_update_wm(struct drm_i915_private *dev_priv)
> wm = intel_calculate_wm(pixel_rate, &pnv_display_wm,
> pnv_display_wm.fifo_size,
> cpp, latency->display_sr);
> - reg = intel_uncore_read(&dev_priv->uncore, DSPFW1);
> - reg &= ~DSPFW_SR_MASK;
> - reg |= FW_WM(wm, SR);
> - intel_uncore_write(&dev_priv->uncore, DSPFW1, reg);
> + intel_uncore_rmw(&dev_priv->uncore, DSPFW1, DSPFW_SR_MASK, FW_WM(wm, SR));
any chance to break these lines in 80 characters? (valid for the
rest of the lines)
Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Andi
next prev parent reply other threads:[~2022-10-03 23:44 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-03 22:32 [Intel-gfx] [PATCH 0/4] Simplify uncore register updates Andrzej Hajda
2022-10-03 22:32 ` [Intel-gfx] [PATCH 1/4] drm/i915/display: Use drm_device alias if defined Andrzej Hajda
2022-10-03 23:45 ` Andi Shyti
2022-10-04 7:59 ` Andrzej Hajda
2022-10-04 7:22 ` Jani Nikula
2022-10-04 7:31 ` Andrzej Hajda
2022-10-04 8:46 ` Jani Nikula
2022-10-04 9:50 ` Andi Shyti
2022-10-04 10:40 ` Jani Nikula
2022-10-03 22:32 ` [Intel-gfx] [PATCH 2/4] drm/i915/display: Use intel_uncore " Andrzej Hajda
2022-10-03 23:45 ` Andi Shyti
2022-10-03 22:32 ` [Intel-gfx] [PATCH 3/4] drm/i915: refactor intel_uncore_rmw Andrzej Hajda
2022-10-03 23:46 ` Andi Shyti
2022-10-04 7:27 ` Jani Nikula
2022-10-03 22:32 ` [Intel-gfx] [PATCH 4/4] drm/i915: use proper helper for register updates Andrzej Hajda
2022-10-03 23:44 ` Andi Shyti [this message]
2022-10-04 3:13 ` kernel test robot
2022-10-04 0:15 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Simplify uncore " Patchwork
2022-10-04 0:15 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-10-04 0:38 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-10-04 7:58 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YztzyOJh6Bsu3CX2@ashyti-mobl2.lan \
--to=andi.shyti@linux.intel.com \
--cc=andrzej.hajda@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox