Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v4] drm/i915: ensure segment offset never exceeds allowed max
@ 2024-10-28 16:00 Karas, Krzysztof
  2024-10-29 13:00 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: ensure segment offset never exceeds allowed max (rev5) Patchwork
                   ` (5 more replies)
  0 siblings, 6 replies; 8+ messages in thread
From: Karas, Krzysztof @ 2024-10-28 16:00 UTC (permalink / raw)
  To: intel-gfx; +Cc: Andi Shyti

Commit 255fc1703e42 ("drm/i915/gem: Calculate object page offset for
partial memory mapping") introduced a new offset that is compared to
sg_dma_len(r.sgt.sgp) in remap_io_sg() function. However, later in
remap_sg() the offset (which at that point resides in r->sgt.curr)
is compared to r->sgt.max. Scatter-gather list's max relies on one
of two values (see i915_scatterlist.h):
 a) sg_dma_len(s.sgp) when `dma` is true,
 b) s.sgp->length otherwise.
This suggests that in cases where `dma` is false, we should use
s.sgp->length to determine the max value instead of sg_dma_len(),
which is used regardless in remap_io_sg() (use_dma(iobase) might return
false there).

This patch uses r.sgt.max to check if offset is within allowed bounds,
because that max value is already set according to the `dma` value.

v3:
 - instead of checking if r.sgt.curr would exceed allowed max, changed
the value in the while loop to be aligned with `dma` value.

v4:
 - remove unnecessary parent relation

Signed-off-by: Krzysztof Karas <krzysztof.karas@intel.com>
---
 drivers/gpu/drm/i915/i915_mm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_mm.c b/drivers/gpu/drm/i915/i915_mm.c
index f5c97a620962..76e2801619f0 100644
--- a/drivers/gpu/drm/i915/i915_mm.c
+++ b/drivers/gpu/drm/i915/i915_mm.c
@@ -143,8 +143,8 @@ int remap_io_sg(struct vm_area_struct *vma,
 	/* We rely on prevalidation of the io-mapping to skip track_pfn(). */
 	GEM_BUG_ON((vma->vm_flags & EXPECTED_FLAGS) != EXPECTED_FLAGS);
 
-	while (offset >= sg_dma_len(r.sgt.sgp) >> PAGE_SHIFT) {
-		offset -= sg_dma_len(r.sgt.sgp) >> PAGE_SHIFT;
+	while (offset >= r.sgt.max >> PAGE_SHIFT) {
+		offset -= r.sgt.max >> PAGE_SHIFT;
 		r.sgt = __sgt_iter(__sg_next(r.sgt.sgp), use_dma(iobase));
 		if (!r.sgt.sgp)
 			return -EINVAL;
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2024-12-03 14:15 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-28 16:00 [PATCH v4] drm/i915: ensure segment offset never exceeds allowed max Karas, Krzysztof
2024-10-29 13:00 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915: ensure segment offset never exceeds allowed max (rev5) Patchwork
2024-10-29 13:16 ` ✓ Fi.CI.BAT: success " Patchwork
2024-10-29 16:15 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-10-30 15:02 ` [PATCH v4] drm/i915: ensure segment offset never exceeds allowed max Andi Shyti
2024-10-31 13:43   ` Krzysztof Karas
2024-10-30 20:19 ` ✗ Fi.CI.IGT: failure for drm/i915: ensure segment offset never exceeds allowed max (rev5) Patchwork
2024-12-03 14:15 ` [PATCH v4] drm/i915: ensure segment offset never exceeds allowed max Andi Shyti

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox