* [PATCH v1] drm/i915/selftest: Log throttle reasons on failure
@ 2024-12-05 8:14 Raag Jadav
2024-12-05 13:20 ` Andi Shyti
` (3 more replies)
0 siblings, 4 replies; 9+ messages in thread
From: Raag Jadav @ 2024-12-05 8:14 UTC (permalink / raw)
To: intel-gfx; +Cc: anshuman.gupta, Raag Jadav
Log throttle reasons on selftest failure which will be useful for
debugging.
Signed-off-by: Raag Jadav <raag.jadav@intel.com>
---
drivers/gpu/drm/i915/gt/selftest_rps.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/selftest_rps.c b/drivers/gpu/drm/i915/gt/selftest_rps.c
index dcef8d498919..1e0e59bc69b6 100644
--- a/drivers/gpu/drm/i915/gt/selftest_rps.c
+++ b/drivers/gpu/drm/i915/gt/selftest_rps.c
@@ -478,8 +478,11 @@ int live_rps_control(void *arg)
min, max, ktime_to_ns(min_dt), ktime_to_ns(max_dt));
if (limit == rps->min_freq) {
- pr_err("%s: GPU throttled to minimum!\n",
- engine->name);
+ u32 throttle = intel_uncore_read(gt->uncore,
+ intel_gt_perf_limit_reasons_reg(gt));
+
+ pr_err("%s: GPU throttled to minimum frequency with reasons 0x%08x\n",
+ engine->name, throttle & GT0_PERF_LIMIT_REASONS_MASK);
show_pstate_limits(rps);
err = -ENODEV;
break;
--
2.34.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v1] drm/i915/selftest: Log throttle reasons on failure
2024-12-05 8:14 [PATCH v1] drm/i915/selftest: Log throttle reasons on failure Raag Jadav
@ 2024-12-05 13:20 ` Andi Shyti
2024-12-05 17:13 ` ✓ i915.CI.BAT: success for " Patchwork
` (2 subsequent siblings)
3 siblings, 0 replies; 9+ messages in thread
From: Andi Shyti @ 2024-12-05 13:20 UTC (permalink / raw)
To: Raag Jadav; +Cc: intel-gfx, anshuman.gupta
Hi Raag,
On Thu, Dec 05, 2024 at 01:44:13PM +0530, Raag Jadav wrote:
> Log throttle reasons on selftest failure which will be useful for
> debugging.
>
> Signed-off-by: Raag Jadav <raag.jadav@intel.com>
Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Thanks,
Andi
^ permalink raw reply [flat|nested] 9+ messages in thread
* ✓ i915.CI.BAT: success for drm/i915/selftest: Log throttle reasons on failure
2024-12-05 8:14 [PATCH v1] drm/i915/selftest: Log throttle reasons on failure Raag Jadav
2024-12-05 13:20 ` Andi Shyti
@ 2024-12-05 17:13 ` Patchwork
2024-12-05 18:46 ` ✗ i915.CI.Full: failure " Patchwork
2024-12-06 15:45 ` [PATCH v1] " Rodrigo Vivi
3 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2024-12-05 17:13 UTC (permalink / raw)
To: Raag Jadav; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/selftest: Log throttle reasons on failure
URL : https://patchwork.freedesktop.org/series/142148/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_15794 -> Patchwork_142148v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/index.html
Participating hosts (44 -> 43)
------------------------------
Missing (1): fi-snb-2520m
Known issues
------------
Here are the changes found in Patchwork_142148v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence:
- bat-dg2-11: [PASS][1] -> [SKIP][2] ([i915#9197]) +2 other tests skip
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15794/bat-dg2-11/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/bat-dg2-11/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence.html
#### Possible fixes ####
* igt@dmabuf@all-tests@dma_fence_chain:
- fi-bsw-nick: [INCOMPLETE][3] ([i915#12904]) -> [PASS][4] +1 other test pass
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15794/fi-bsw-nick/igt@dmabuf@all-tests@dma_fence_chain.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/fi-bsw-nick/igt@dmabuf@all-tests@dma_fence_chain.html
* igt@i915_selftest@live:
- bat-mtlp-8: [ABORT][5] ([i915#12061]) -> [PASS][6] +1 other test pass
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15794/bat-mtlp-8/igt@i915_selftest@live.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/bat-mtlp-8/igt@i915_selftest@live.html
* igt@i915_selftest@live@workarounds:
- bat-arls-5: [ABORT][7] ([i915#12061]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15794/bat-arls-5/igt@i915_selftest@live@workarounds.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/bat-arls-5/igt@i915_selftest@live@workarounds.html
[i915#12061]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12061
[i915#12904]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12904
[i915#9197]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9197
Build changes
-------------
* Linux: CI_DRM_15794 -> Patchwork_142148v1
CI-20190529: 20190529
CI_DRM_15794: 6148006e767be69293d1ec77dd127dba49db51dd @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_8138: 8138
Patchwork_142148v1: 6148006e767be69293d1ec77dd127dba49db51dd @ git://anongit.freedesktop.org/gfx-ci/linux
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/index.html
^ permalink raw reply [flat|nested] 9+ messages in thread
* ✗ i915.CI.Full: failure for drm/i915/selftest: Log throttle reasons on failure
2024-12-05 8:14 [PATCH v1] drm/i915/selftest: Log throttle reasons on failure Raag Jadav
2024-12-05 13:20 ` Andi Shyti
2024-12-05 17:13 ` ✓ i915.CI.BAT: success for " Patchwork
@ 2024-12-05 18:46 ` Patchwork
2024-12-06 15:45 ` [PATCH v1] " Rodrigo Vivi
3 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2024-12-05 18:46 UTC (permalink / raw)
To: Raag Jadav; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 28115 bytes --]
== Series Details ==
Series: drm/i915/selftest: Log throttle reasons on failure
URL : https://patchwork.freedesktop.org/series/142148/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_15794_full -> Patchwork_142148v1_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_142148v1_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_142148v1_full, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
to document this new failure mode, which will reduce false positives in CI.
Participating hosts (9 -> 10)
------------------------------
Additional (1): shard-dg2-set2
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_142148v1_full:
### IGT changes ###
#### Possible regressions ####
* igt@i915_module_load@load:
- shard-dg2: ([PASS][1], [PASS][2], [PASS][3], [PASS][4], [PASS][5], [PASS][6], [PASS][7], [PASS][8], [PASS][9], [PASS][10], [PASS][11], [PASS][12], [PASS][13], [PASS][14], [PASS][15], [PASS][16], [PASS][17], [PASS][18], [PASS][19], [PASS][20], [PASS][21], [PASS][22], [PASS][23]) -> ([PASS][24], [DMESG-WARN][25], [PASS][26], [PASS][27], [PASS][28], [PASS][29], [PASS][30], [PASS][31], [PASS][32], [PASS][33], [PASS][34], [PASS][35], [PASS][36], [PASS][37], [PASS][38], [PASS][39], [PASS][40], [PASS][41], [PASS][42], [PASS][43], [PASS][44], [PASS][45], [PASS][46])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15794/shard-dg2-6/igt@i915_module_load@load.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15794/shard-dg2-11/igt@i915_module_load@load.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15794/shard-dg2-3/igt@i915_module_load@load.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15794/shard-dg2-11/igt@i915_module_load@load.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15794/shard-dg2-4/igt@i915_module_load@load.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15794/shard-dg2-1/igt@i915_module_load@load.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15794/shard-dg2-8/igt@i915_module_load@load.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15794/shard-dg2-11/igt@i915_module_load@load.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15794/shard-dg2-8/igt@i915_module_load@load.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15794/shard-dg2-4/igt@i915_module_load@load.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15794/shard-dg2-3/igt@i915_module_load@load.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15794/shard-dg2-1/igt@i915_module_load@load.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15794/shard-dg2-8/igt@i915_module_load@load.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15794/shard-dg2-10/igt@i915_module_load@load.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15794/shard-dg2-7/igt@i915_module_load@load.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15794/shard-dg2-5/igt@i915_module_load@load.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15794/shard-dg2-2/igt@i915_module_load@load.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15794/shard-dg2-7/igt@i915_module_load@load.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15794/shard-dg2-10/igt@i915_module_load@load.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15794/shard-dg2-5/igt@i915_module_load@load.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15794/shard-dg2-6/igt@i915_module_load@load.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15794/shard-dg2-10/igt@i915_module_load@load.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15794/shard-dg2-3/igt@i915_module_load@load.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-dg2-1/igt@i915_module_load@load.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-dg2-2/igt@i915_module_load@load.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-dg2-2/igt@i915_module_load@load.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-dg2-1/igt@i915_module_load@load.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-dg2-7/igt@i915_module_load@load.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-dg2-3/igt@i915_module_load@load.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-dg2-4/igt@i915_module_load@load.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-dg2-4/igt@i915_module_load@load.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-dg2-11/igt@i915_module_load@load.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-dg2-8/igt@i915_module_load@load.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-dg2-7/igt@i915_module_load@load.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-dg2-5/igt@i915_module_load@load.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-dg2-6/igt@i915_module_load@load.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-dg2-1/igt@i915_module_load@load.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-dg2-10/igt@i915_module_load@load.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-dg2-8/igt@i915_module_load@load.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-dg2-5/igt@i915_module_load@load.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-dg2-6/igt@i915_module_load@load.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-dg2-5/igt@i915_module_load@load.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-dg2-11/igt@i915_module_load@load.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-dg2-6/igt@i915_module_load@load.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-dg2-10/igt@i915_module_load@load.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-dg2-2/igt@i915_module_load@load.html
Known issues
------------
Here are the changes found in Patchwork_142148v1_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_basic@multigpu-create-close:
- shard-tglu-1: NOTRUN -> [SKIP][47] ([i915#7697])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-tglu-1/igt@gem_basic@multigpu-create-close.html
* igt@gem_exec_fence@submit3:
- shard-dg2: NOTRUN -> [SKIP][48] ([i915#4812])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-dg2-11/igt@gem_exec_fence@submit3.html
* igt@gem_exec_flush@basic-uc-prw-default:
- shard-dg2: NOTRUN -> [SKIP][49] ([i915#3539])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-dg2-11/igt@gem_exec_flush@basic-uc-prw-default.html
* igt@gem_exec_flush@basic-wb-pro-default:
- shard-dg2: NOTRUN -> [SKIP][50] ([i915#3539] / [i915#4852])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-dg2-11/igt@gem_exec_flush@basic-wb-pro-default.html
* igt@gem_exec_reloc@basic-write-gtt-noreloc:
- shard-dg2: NOTRUN -> [SKIP][51] ([i915#3281])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-dg2-11/igt@gem_exec_reloc@basic-write-gtt-noreloc.html
* igt@gem_lmem_swapping@smem-oom:
- shard-tglu-1: NOTRUN -> [SKIP][52] ([i915#4613])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-tglu-1/igt@gem_lmem_swapping@smem-oom.html
* igt@gem_lmem_swapping@smem-oom@lmem0:
- shard-dg2: NOTRUN -> [TIMEOUT][53] ([i915#5493]) +1 other test timeout
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-dg2-11/igt@gem_lmem_swapping@smem-oom@lmem0.html
* igt@gem_mmap_wc@write-gtt-read-wc:
- shard-dg2: NOTRUN -> [SKIP][54] ([i915#4083]) +1 other test skip
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-dg2-11/igt@gem_mmap_wc@write-gtt-read-wc.html
* igt@gem_render_copy@y-tiled-mc-ccs-to-yf-tiled-ccs:
- shard-dg2: NOTRUN -> [SKIP][55] ([i915#5190] / [i915#8428]) +2 other tests skip
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-dg2-11/igt@gem_render_copy@y-tiled-mc-ccs-to-yf-tiled-ccs.html
* igt@gem_set_tiling_vs_gtt:
- shard-dg2: NOTRUN -> [SKIP][56] ([i915#4079])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-dg2-11/igt@gem_set_tiling_vs_gtt.html
* igt@gem_userptr_blits@coherency-sync:
- shard-tglu: NOTRUN -> [SKIP][57] ([i915#3297])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-tglu-3/igt@gem_userptr_blits@coherency-sync.html
* igt@gen7_exec_parse@bitmasks:
- shard-dg2: NOTRUN -> [SKIP][58] +3 other tests skip
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-dg2-11/igt@gen7_exec_parse@bitmasks.html
* igt@i915_pm_freq_api@freq-suspend@gt0:
- shard-dg2: NOTRUN -> [ABORT][59] ([i915#13218]) +1 other test abort
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-dg2-11/igt@i915_pm_freq_api@freq-suspend@gt0.html
* igt@i915_pm_freq_mult@media-freq@gt0:
- shard-dg1: NOTRUN -> [SKIP][60] ([i915#6590]) +1 other test skip
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-dg1-17/igt@i915_pm_freq_mult@media-freq@gt0.html
* igt@kms_big_fb@4-tiled-8bpp-rotate-180:
- shard-tglu-1: NOTRUN -> [SKIP][61] ([i915#5286])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-tglu-1/igt@kms_big_fb@4-tiled-8bpp-rotate-180.html
* igt@kms_big_fb@yf-tiled-64bpp-rotate-0:
- shard-dg2: NOTRUN -> [SKIP][62] ([i915#4538] / [i915#5190]) +1 other test skip
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-dg2-11/igt@kms_big_fb@yf-tiled-64bpp-rotate-0.html
* igt@kms_big_fb@yf-tiled-8bpp-rotate-270:
- shard-tglu: NOTRUN -> [SKIP][63] +6 other tests skip
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-tglu-9/igt@kms_big_fb@yf-tiled-8bpp-rotate-270.html
* igt@kms_ccs@ccs-on-another-bo-y-tiled-ccs@pipe-d-hdmi-a-3:
- shard-dg2: NOTRUN -> [SKIP][64] ([i915#10307] / [i915#6095]) +47 other tests skip
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-dg2-5/igt@kms_ccs@ccs-on-another-bo-y-tiled-ccs@pipe-d-hdmi-a-3.html
* igt@kms_ccs@crc-primary-basic-4-tiled-mtl-mc-ccs@pipe-b-hdmi-a-1:
- shard-rkl: NOTRUN -> [SKIP][65] ([i915#6095]) +37 other tests skip
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-rkl-7/igt@kms_ccs@crc-primary-basic-4-tiled-mtl-mc-ccs@pipe-b-hdmi-a-1.html
* igt@kms_ccs@crc-primary-rotation-180-4-tiled-mtl-rc-ccs-cc@pipe-b-hdmi-a-1:
- shard-tglu-1: NOTRUN -> [SKIP][66] ([i915#6095]) +4 other tests skip
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-tglu-1/igt@kms_ccs@crc-primary-rotation-180-4-tiled-mtl-rc-ccs-cc@pipe-b-hdmi-a-1.html
* igt@kms_ccs@crc-primary-suspend-4-tiled-mtl-rc-ccs-cc@pipe-d-hdmi-a-3:
- shard-dg1: NOTRUN -> [SKIP][67] ([i915#6095]) +16 other tests skip
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-dg1-12/igt@kms_ccs@crc-primary-suspend-4-tiled-mtl-rc-ccs-cc@pipe-d-hdmi-a-3.html
* igt@kms_ccs@missing-ccs-buffer-4-tiled-mtl-mc-ccs@pipe-d-hdmi-a-1:
- shard-tglu: NOTRUN -> [SKIP][68] ([i915#6095]) +9 other tests skip
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-tglu-3/igt@kms_ccs@missing-ccs-buffer-4-tiled-mtl-mc-ccs@pipe-d-hdmi-a-1.html
* igt@kms_ccs@missing-ccs-buffer-y-tiled-ccs@pipe-d-hdmi-a-1:
- shard-dg2: NOTRUN -> [SKIP][69] ([i915#10307] / [i915#10434] / [i915#6095]) +1 other test skip
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-dg2-4/igt@kms_ccs@missing-ccs-buffer-y-tiled-ccs@pipe-d-hdmi-a-1.html
* igt@kms_content_protection@legacy:
- shard-dg2: NOTRUN -> [SKIP][70] ([i915#7118] / [i915#9424])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-dg2-11/igt@kms_content_protection@legacy.html
* igt@kms_content_protection@srm:
- shard-dg1: NOTRUN -> [SKIP][71] ([i915#7116])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-dg1-17/igt@kms_content_protection@srm.html
* igt@kms_content_protection@srm@pipe-a-dp-4:
- shard-dg2: NOTRUN -> [TIMEOUT][72] ([i915#7173])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-dg2-10/igt@kms_content_protection@srm@pipe-a-dp-4.html
* igt@kms_cursor_crc@cursor-onscreen-256x85@pipe-a-hdmi-a-2:
- shard-rkl: NOTRUN -> [DMESG-WARN][73] ([i915#12964]) +1 other test dmesg-warn
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-rkl-3/igt@kms_cursor_crc@cursor-onscreen-256x85@pipe-a-hdmi-a-2.html
* igt@kms_cursor_crc@cursor-rapid-movement-32x10:
- shard-tglu-1: NOTRUN -> [SKIP][74] ([i915#3555]) +1 other test skip
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-tglu-1/igt@kms_cursor_crc@cursor-rapid-movement-32x10.html
* igt@kms_cursor_crc@cursor-rapid-movement-512x512:
- shard-dg2: NOTRUN -> [SKIP][75] ([i915#13049])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-dg2-11/igt@kms_cursor_crc@cursor-rapid-movement-512x512.html
* igt@kms_cursor_crc@cursor-rapid-movement-max-size:
- shard-dg2: NOTRUN -> [SKIP][76] ([i915#3555])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-dg2-11/igt@kms_cursor_crc@cursor-rapid-movement-max-size.html
* igt@kms_cursor_legacy@2x-flip-vs-cursor-atomic:
- shard-tglu-1: NOTRUN -> [SKIP][77] +7 other tests skip
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-tglu-1/igt@kms_cursor_legacy@2x-flip-vs-cursor-atomic.html
* igt@kms_cursor_legacy@flip-vs-cursor-varying-size:
- shard-snb: [PASS][78] -> [FAIL][79] ([i915#2346])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15794/shard-snb5/igt@kms_cursor_legacy@flip-vs-cursor-varying-size.html
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-snb1/igt@kms_cursor_legacy@flip-vs-cursor-varying-size.html
* igt@kms_cursor_legacy@short-flip-after-cursor-toggle:
- shard-glk: [PASS][80] -> [FAIL][81] ([i915#2346]) +1 other test fail
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15794/shard-glk9/igt@kms_cursor_legacy@short-flip-after-cursor-toggle.html
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-glk8/igt@kms_cursor_legacy@short-flip-after-cursor-toggle.html
* igt@kms_flip@2x-flip-vs-fences:
- shard-tglu-1: NOTRUN -> [SKIP][82] ([i915#3637]) +1 other test skip
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-tglu-1/igt@kms_flip@2x-flip-vs-fences.html
* igt@kms_flip@2x-flip-vs-wf_vblank:
- shard-tglu: NOTRUN -> [SKIP][83] ([i915#3637]) +1 other test skip
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-tglu-3/igt@kms_flip@2x-flip-vs-wf_vblank.html
* igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-16bpp-4tile-upscaling:
- shard-tglu-1: NOTRUN -> [SKIP][84] ([i915#2672] / [i915#3555])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-tglu-1/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-16bpp-4tile-upscaling.html
* igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-16bpp-4tile-upscaling@pipe-a-valid-mode:
- shard-tglu-1: NOTRUN -> [SKIP][85] ([i915#2587] / [i915#2672])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-tglu-1/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-16bpp-4tile-upscaling@pipe-a-valid-mode.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-blt:
- shard-dg2: [PASS][86] -> [FAIL][87] ([i915#6880]) +1 other test fail
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15794/shard-dg2-4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-blt.html
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-dg2-7/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-blt.html
* igt@kms_frontbuffer_tracking@fbc-2p-rte:
- shard-dg2: NOTRUN -> [SKIP][88] ([i915#5354]) +7 other tests skip
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-dg2-11/igt@kms_frontbuffer_tracking@fbc-2p-rte.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-pwrite:
- shard-dg1: NOTRUN -> [SKIP][89]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-dg1-17/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-mmap-gtt:
- shard-dg2: NOTRUN -> [SKIP][90] ([i915#8708]) +1 other test skip
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-dg2-11/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-mmap-gtt.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-mmap-gtt:
- shard-dg1: NOTRUN -> [SKIP][91] ([i915#8708])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-dg1-17/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-mmap-gtt.html
* igt@kms_frontbuffer_tracking@psr-indfb-scaledprimary:
- shard-dg2: NOTRUN -> [SKIP][92] ([i915#3458]) +6 other tests skip
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-dg2-11/igt@kms_frontbuffer_tracking@psr-indfb-scaledprimary.html
* igt@kms_multipipe_modeset@basic-max-pipe-crc-check:
- shard-tglu: NOTRUN -> [SKIP][93] ([i915#1839])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-tglu-10/igt@kms_multipipe_modeset@basic-max-pipe-crc-check.html
* igt@kms_pm_backlight@brightness-with-dpms:
- shard-dg1: NOTRUN -> [SKIP][94] ([i915#12343])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-dg1-17/igt@kms_pm_backlight@brightness-with-dpms.html
* igt@kms_pm_rpm@pm-tiling:
- shard-dg2: NOTRUN -> [SKIP][95] ([i915#4077])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-dg2-11/igt@kms_pm_rpm@pm-tiling.html
* igt@kms_pm_rpm@system-suspend-modeset:
- shard-rkl: [PASS][96] -> [ABORT][97] ([i915#13218])
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15794/shard-rkl-2/igt@kms_pm_rpm@system-suspend-modeset.html
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-rkl-5/igt@kms_pm_rpm@system-suspend-modeset.html
* igt@kms_psr2_sf@fbc-psr2-overlay-plane-move-continuous-exceed-fully-sf:
- shard-dg2: NOTRUN -> [SKIP][98] ([i915#11520])
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-dg2-11/igt@kms_psr2_sf@fbc-psr2-overlay-plane-move-continuous-exceed-fully-sf.html
* igt@kms_psr2_sf@pr-overlay-plane-update-continuous-sf:
- shard-tglu: NOTRUN -> [SKIP][99] ([i915#11520]) +1 other test skip
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-tglu-10/igt@kms_psr2_sf@pr-overlay-plane-update-continuous-sf.html
* igt@kms_psr@fbc-psr2-sprite-blt:
- shard-tglu-1: NOTRUN -> [SKIP][100] ([i915#9732])
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-tglu-1/igt@kms_psr@fbc-psr2-sprite-blt.html
* igt@kms_psr@psr2-cursor-blt:
- shard-dg2: NOTRUN -> [SKIP][101] ([i915#1072] / [i915#9732]) +3 other tests skip
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-dg2-11/igt@kms_psr@psr2-cursor-blt.html
* igt@kms_rotation_crc@bad-pixel-format:
- shard-dg2: NOTRUN -> [SKIP][102] ([i915#12755])
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-dg2-11/igt@kms_rotation_crc@bad-pixel-format.html
* igt@kms_selftest@drm_framebuffer:
- shard-tglu-1: NOTRUN -> [ABORT][103] ([i915#13179]) +1 other test abort
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-tglu-1/igt@kms_selftest@drm_framebuffer.html
* igt@kms_selftest@drm_framebuffer@drm_test_framebuffer_free:
- shard-dg2: NOTRUN -> [ABORT][104] ([i915#13179]) +1 other test abort
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-dg2-11/igt@kms_selftest@drm_framebuffer@drm_test_framebuffer_free.html
* igt@perf@per-context-mode-unprivileged:
- shard-tglu: NOTRUN -> [ABORT][105] ([i915#13218]) +2 other tests abort
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-tglu-9/igt@perf@per-context-mode-unprivileged.html
* igt@perf_pmu@busy-accuracy-50:
- shard-tglu-1: NOTRUN -> [ABORT][106] ([i915#13218]) +3 other tests abort
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-tglu-1/igt@perf_pmu@busy-accuracy-50.html
* igt@perf_pmu@rc6-all-gts:
- shard-dg2: NOTRUN -> [SKIP][107] ([i915#8516])
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-dg2-11/igt@perf_pmu@rc6-all-gts.html
* igt@perf_pmu@render-node-busy:
- shard-dg1: NOTRUN -> [ABORT][108] ([i915#13218]) +1 other test abort
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-dg1-17/igt@perf_pmu@render-node-busy.html
#### Possible fixes ####
* igt@kms_setmode@basic@pipe-a-hdmi-a-1:
- shard-rkl: [FAIL][109] ([i915#5465]) -> [PASS][110] +1 other test pass
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15794/shard-rkl-4/igt@kms_setmode@basic@pipe-a-hdmi-a-1.html
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-rkl-2/igt@kms_setmode@basic@pipe-a-hdmi-a-1.html
#### Warnings ####
* igt@kms_content_protection@srm:
- shard-dg2: [SKIP][111] ([i915#7118]) -> [TIMEOUT][112] ([i915#7173])
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15794/shard-dg2-3/igt@kms_content_protection@srm.html
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-dg2-10/igt@kms_content_protection@srm.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-mmap-cpu:
- shard-dg2: [SKIP][113] ([i915#10433] / [i915#3458]) -> [SKIP][114] ([i915#3458]) +1 other test skip
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15794/shard-dg2-4/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-mmap-cpu.html
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-dg2-7/igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-mmap-cpu.html
* igt@kms_hdr@brightness-with-hdr:
- shard-dg2: [SKIP][115] -> [SKIP][116] ([i915#12713])
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15794/shard-dg2-10/igt@kms_hdr@brightness-with-hdr.html
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/shard-dg2-5/igt@kms_hdr@brightness-with-hdr.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#10307]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10307
[i915#10433]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10433
[i915#10434]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10434
[i915#1072]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1072
[i915#11520]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11520
[i915#12343]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12343
[i915#12713]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12713
[i915#12755]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12755
[i915#12964]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12964
[i915#13049]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13049
[i915#13179]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13179
[i915#13218]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13218
[i915#1839]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1839
[i915#2346]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2346
[i915#2587]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2587
[i915#2672]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2672
[i915#3281]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3281
[i915#3297]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3297
[i915#3458]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3458
[i915#3539]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3539
[i915#3555]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3555
[i915#3637]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3637
[i915#4077]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4083
[i915#4538]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4538
[i915#4613]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4613
[i915#4812]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4812
[i915#4852]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4852
[i915#5190]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5190
[i915#5286]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5286
[i915#5354]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5354
[i915#5465]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5465
[i915#5493]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/5493
[i915#6095]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6095
[i915#6590]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6590
[i915#6880]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/6880
[i915#7116]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7116
[i915#7118]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7118
[i915#7173]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7173
[i915#7697]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7697
[i915#8428]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8428
[i915#8516]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8516
[i915#8708]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8708
[i915#9424]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9424
[i915#9732]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9732
Build changes
-------------
* Linux: CI_DRM_15794 -> Patchwork_142148v1
CI-20190529: 20190529
CI_DRM_15794: 6148006e767be69293d1ec77dd127dba49db51dd @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_8138: 8138
Patchwork_142148v1: 6148006e767be69293d1ec77dd127dba49db51dd @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142148v1/index.html
[-- Attachment #2: Type: text/html, Size: 32582 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v1] drm/i915/selftest: Log throttle reasons on failure
2024-12-05 8:14 [PATCH v1] drm/i915/selftest: Log throttle reasons on failure Raag Jadav
` (2 preceding siblings ...)
2024-12-05 18:46 ` ✗ i915.CI.Full: failure " Patchwork
@ 2024-12-06 15:45 ` Rodrigo Vivi
2024-12-07 6:14 ` Raag Jadav
3 siblings, 1 reply; 9+ messages in thread
From: Rodrigo Vivi @ 2024-12-06 15:45 UTC (permalink / raw)
To: Raag Jadav; +Cc: intel-gfx, anshuman.gupta
On Thu, Dec 05, 2024 at 01:44:13PM +0530, Raag Jadav wrote:
> Log throttle reasons on selftest failure which will be useful for
> debugging.
>
> Signed-off-by: Raag Jadav <raag.jadav@intel.com>
> ---
> drivers/gpu/drm/i915/gt/selftest_rps.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/selftest_rps.c b/drivers/gpu/drm/i915/gt/selftest_rps.c
> index dcef8d498919..1e0e59bc69b6 100644
> --- a/drivers/gpu/drm/i915/gt/selftest_rps.c
> +++ b/drivers/gpu/drm/i915/gt/selftest_rps.c
> @@ -478,8 +478,11 @@ int live_rps_control(void *arg)
> min, max, ktime_to_ns(min_dt), ktime_to_ns(max_dt));
>
> if (limit == rps->min_freq) {
I was going to merge this, but then I noticed that this prints only
when the throttle moves that to our min_freq... When PCODE throttle
the freq, the guaranteed freq can be at any point, not necessarily
to the minimal, so this print is not very effective in the end of the day
> - pr_err("%s: GPU throttled to minimum!\n",
> - engine->name);
> + u32 throttle = intel_uncore_read(gt->uncore,
> + intel_gt_perf_limit_reasons_reg(gt));
> +
> + pr_err("%s: GPU throttled to minimum frequency with reasons 0x%08x\n",
> + engine->name, throttle & GT0_PERF_LIMIT_REASONS_MASK);
> show_pstate_limits(rps);
> err = -ENODEV;
> break;
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v1] drm/i915/selftest: Log throttle reasons on failure
2024-12-06 15:45 ` [PATCH v1] " Rodrigo Vivi
@ 2024-12-07 6:14 ` Raag Jadav
2024-12-09 16:28 ` Rodrigo Vivi
0 siblings, 1 reply; 9+ messages in thread
From: Raag Jadav @ 2024-12-07 6:14 UTC (permalink / raw)
To: Rodrigo Vivi; +Cc: intel-gfx, anshuman.gupta, chris.p.wilson
Cc: Chris
On Fri, Dec 06, 2024 at 10:45:18AM -0500, Rodrigo Vivi wrote:
> On Thu, Dec 05, 2024 at 01:44:13PM +0530, Raag Jadav wrote:
> > Log throttle reasons on selftest failure which will be useful for
> > debugging.
> >
> > Signed-off-by: Raag Jadav <raag.jadav@intel.com>
> > ---
> > drivers/gpu/drm/i915/gt/selftest_rps.c | 7 +++++--
> > 1 file changed, 5 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/gt/selftest_rps.c b/drivers/gpu/drm/i915/gt/selftest_rps.c
> > index dcef8d498919..1e0e59bc69b6 100644
> > --- a/drivers/gpu/drm/i915/gt/selftest_rps.c
> > +++ b/drivers/gpu/drm/i915/gt/selftest_rps.c
> > @@ -478,8 +478,11 @@ int live_rps_control(void *arg)
> > min, max, ktime_to_ns(min_dt), ktime_to_ns(max_dt));
> >
> > if (limit == rps->min_freq) {
>
> I was going to merge this, but then I noticed that this prints only
> when the throttle moves that to our min_freq... When PCODE throttle
> the freq, the guaranteed freq can be at any point, not necessarily
> to the minimal, so this print is not very effective in the end of the day
Makes me wonder why such a criteria at all?
Raag
> > - pr_err("%s: GPU throttled to minimum!\n",
> > - engine->name);
> > + u32 throttle = intel_uncore_read(gt->uncore,
> > + intel_gt_perf_limit_reasons_reg(gt));
> > +
> > + pr_err("%s: GPU throttled to minimum frequency with reasons 0x%08x\n",
> > + engine->name, throttle & GT0_PERF_LIMIT_REASONS_MASK);
> > show_pstate_limits(rps);
> > err = -ENODEV;
> > break;
> > --
> > 2.34.1
> >
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v1] drm/i915/selftest: Log throttle reasons on failure
2024-12-07 6:14 ` Raag Jadav
@ 2024-12-09 16:28 ` Rodrigo Vivi
2024-12-10 8:53 ` Raag Jadav
0 siblings, 1 reply; 9+ messages in thread
From: Rodrigo Vivi @ 2024-12-09 16:28 UTC (permalink / raw)
To: Raag Jadav; +Cc: intel-gfx, anshuman.gupta, chris.p.wilson
On Sat, Dec 07, 2024 at 08:14:42AM +0200, Raag Jadav wrote:
> Cc: Chris
>
> On Fri, Dec 06, 2024 at 10:45:18AM -0500, Rodrigo Vivi wrote:
> > On Thu, Dec 05, 2024 at 01:44:13PM +0530, Raag Jadav wrote:
> > > Log throttle reasons on selftest failure which will be useful for
> > > debugging.
> > >
> > > Signed-off-by: Raag Jadav <raag.jadav@intel.com>
> > > ---
> > > drivers/gpu/drm/i915/gt/selftest_rps.c | 7 +++++--
> > > 1 file changed, 5 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/gt/selftest_rps.c b/drivers/gpu/drm/i915/gt/selftest_rps.c
> > > index dcef8d498919..1e0e59bc69b6 100644
> > > --- a/drivers/gpu/drm/i915/gt/selftest_rps.c
> > > +++ b/drivers/gpu/drm/i915/gt/selftest_rps.c
> > > @@ -478,8 +478,11 @@ int live_rps_control(void *arg)
> > > min, max, ktime_to_ns(min_dt), ktime_to_ns(max_dt));
> > >
> > > if (limit == rps->min_freq) {
> >
> > I was going to merge this, but then I noticed that this prints only
> > when the throttle moves that to our min_freq... When PCODE throttle
> > the freq, the guaranteed freq can be at any point, not necessarily
> > to the minimal, so this print is not very effective in the end of the day
>
> Makes me wonder why such a criteria at all?
very good question...
Perhaps we need to revamp entirely this selftest or kill it?
>
> Raag
>
> > > - pr_err("%s: GPU throttled to minimum!\n",
> > > - engine->name);
> > > + u32 throttle = intel_uncore_read(gt->uncore,
> > > + intel_gt_perf_limit_reasons_reg(gt));
> > > +
> > > + pr_err("%s: GPU throttled to minimum frequency with reasons 0x%08x\n",
> > > + engine->name, throttle & GT0_PERF_LIMIT_REASONS_MASK);
> > > show_pstate_limits(rps);
> > > err = -ENODEV;
> > > break;
> > > --
> > > 2.34.1
> > >
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v1] drm/i915/selftest: Log throttle reasons on failure
2024-12-09 16:28 ` Rodrigo Vivi
@ 2024-12-10 8:53 ` Raag Jadav
2024-12-10 22:38 ` Rodrigo Vivi
0 siblings, 1 reply; 9+ messages in thread
From: Raag Jadav @ 2024-12-10 8:53 UTC (permalink / raw)
To: Rodrigo Vivi; +Cc: intel-gfx, anshuman.gupta, chris.p.wilson
On Mon, Dec 09, 2024 at 11:28:39AM -0500, Rodrigo Vivi wrote:
> On Sat, Dec 07, 2024 at 08:14:42AM +0200, Raag Jadav wrote:
> > Cc: Chris
> >
> > On Fri, Dec 06, 2024 at 10:45:18AM -0500, Rodrigo Vivi wrote:
> > > On Thu, Dec 05, 2024 at 01:44:13PM +0530, Raag Jadav wrote:
> > > > Log throttle reasons on selftest failure which will be useful for
> > > > debugging.
> > > >
> > > > Signed-off-by: Raag Jadav <raag.jadav@intel.com>
> > > > ---
> > > > drivers/gpu/drm/i915/gt/selftest_rps.c | 7 +++++--
> > > > 1 file changed, 5 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/drivers/gpu/drm/i915/gt/selftest_rps.c b/drivers/gpu/drm/i915/gt/selftest_rps.c
> > > > index dcef8d498919..1e0e59bc69b6 100644
> > > > --- a/drivers/gpu/drm/i915/gt/selftest_rps.c
> > > > +++ b/drivers/gpu/drm/i915/gt/selftest_rps.c
> > > > @@ -478,8 +478,11 @@ int live_rps_control(void *arg)
> > > > min, max, ktime_to_ns(min_dt), ktime_to_ns(max_dt));
> > > >
> > > > if (limit == rps->min_freq) {
> > >
> > > I was going to merge this, but then I noticed that this prints only
> > > when the throttle moves that to our min_freq... When PCODE throttle
> > > the freq, the guaranteed freq can be at any point, not necessarily
> > > to the minimal, so this print is not very effective in the end of the day
> >
> > Makes me wonder why such a criteria at all?
>
> very good question...
> Perhaps we need to revamp entirely this selftest or kill it?
Depends. Do we qualify throttling as a failure?
If yes, we'll keep hitting this every now and then.
If no, then just dropping this condition might be enough.
Raag
> > > > - pr_err("%s: GPU throttled to minimum!\n",
> > > > - engine->name);
> > > > + u32 throttle = intel_uncore_read(gt->uncore,
> > > > + intel_gt_perf_limit_reasons_reg(gt));
> > > > +
> > > > + pr_err("%s: GPU throttled to minimum frequency with reasons 0x%08x\n",
> > > > + engine->name, throttle & GT0_PERF_LIMIT_REASONS_MASK);
> > > > show_pstate_limits(rps);
> > > > err = -ENODEV;
> > > > break;
> > > > --
> > > > 2.34.1
> > > >
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v1] drm/i915/selftest: Log throttle reasons on failure
2024-12-10 8:53 ` Raag Jadav
@ 2024-12-10 22:38 ` Rodrigo Vivi
0 siblings, 0 replies; 9+ messages in thread
From: Rodrigo Vivi @ 2024-12-10 22:38 UTC (permalink / raw)
To: Raag Jadav; +Cc: intel-gfx, anshuman.gupta, chris.p.wilson
On Tue, Dec 10, 2024 at 10:53:10AM +0200, Raag Jadav wrote:
> On Mon, Dec 09, 2024 at 11:28:39AM -0500, Rodrigo Vivi wrote:
> > On Sat, Dec 07, 2024 at 08:14:42AM +0200, Raag Jadav wrote:
> > > Cc: Chris
> > >
> > > On Fri, Dec 06, 2024 at 10:45:18AM -0500, Rodrigo Vivi wrote:
> > > > On Thu, Dec 05, 2024 at 01:44:13PM +0530, Raag Jadav wrote:
> > > > > Log throttle reasons on selftest failure which will be useful for
> > > > > debugging.
> > > > >
> > > > > Signed-off-by: Raag Jadav <raag.jadav@intel.com>
> > > > > ---
> > > > > drivers/gpu/drm/i915/gt/selftest_rps.c | 7 +++++--
> > > > > 1 file changed, 5 insertions(+), 2 deletions(-)
> > > > >
> > > > > diff --git a/drivers/gpu/drm/i915/gt/selftest_rps.c b/drivers/gpu/drm/i915/gt/selftest_rps.c
> > > > > index dcef8d498919..1e0e59bc69b6 100644
> > > > > --- a/drivers/gpu/drm/i915/gt/selftest_rps.c
> > > > > +++ b/drivers/gpu/drm/i915/gt/selftest_rps.c
> > > > > @@ -478,8 +478,11 @@ int live_rps_control(void *arg)
> > > > > min, max, ktime_to_ns(min_dt), ktime_to_ns(max_dt));
> > > > >
> > > > > if (limit == rps->min_freq) {
> > > >
> > > > I was going to merge this, but then I noticed that this prints only
> > > > when the throttle moves that to our min_freq... When PCODE throttle
> > > > the freq, the guaranteed freq can be at any point, not necessarily
> > > > to the minimal, so this print is not very effective in the end of the day
> > >
> > > Makes me wonder why such a criteria at all?
> >
> > very good question...
> > Perhaps we need to revamp entirely this selftest or kill it?
>
> Depends. Do we qualify throttling as a failure?
> If yes, we'll keep hitting this every now and then.
> If no, then just dropping this condition might be enough.
hmm that will make CI angry... we can remove the condition and
then tune down the msg to debug and not error.
But perhaps the test was done with the assumption in mind that
a throttle to a minimum is a catastrofic error, which I disagree.
Throttle is throttle is normal operation and depending on many
external factors and many things that are out of our control and
that changes from platform to platform.
>
> Raag
>
> > > > > - pr_err("%s: GPU throttled to minimum!\n",
> > > > > - engine->name);
> > > > > + u32 throttle = intel_uncore_read(gt->uncore,
> > > > > + intel_gt_perf_limit_reasons_reg(gt));
> > > > > +
> > > > > + pr_err("%s: GPU throttled to minimum frequency with reasons 0x%08x\n",
> > > > > + engine->name, throttle & GT0_PERF_LIMIT_REASONS_MASK);
> > > > > show_pstate_limits(rps);
> > > > > err = -ENODEV;
> > > > > break;
> > > > > --
> > > > > 2.34.1
> > > > >
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2024-12-10 22:39 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-05 8:14 [PATCH v1] drm/i915/selftest: Log throttle reasons on failure Raag Jadav
2024-12-05 13:20 ` Andi Shyti
2024-12-05 17:13 ` ✓ i915.CI.BAT: success for " Patchwork
2024-12-05 18:46 ` ✗ i915.CI.Full: failure " Patchwork
2024-12-06 15:45 ` [PATCH v1] " Rodrigo Vivi
2024-12-07 6:14 ` Raag Jadav
2024-12-09 16:28 ` Rodrigo Vivi
2024-12-10 8:53 ` Raag Jadav
2024-12-10 22:38 ` Rodrigo Vivi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox