From: Andi Shyti <andi.shyti@linux.intel.com>
To: Krzysztof Karas <krzysztof.karas@intel.com>
Cc: Andi Shyti <andi.shyti@linux.intel.com>,
intel-gfx <intel-gfx@lists.freedesktop.org>,
Andi Shyti <andi.shyti@kernel.org>
Subject: Re: [PATCH 2/4] drm/i915/gt: Fix SPDX license format
Date: Wed, 19 Mar 2025 01:34:20 +0100 [thread overview]
Message-ID: <Z9oRDO0O7oDsyACd@ashyti-mobl2.lan> (raw)
In-Reply-To: <luoyuhjv5ibwv4omqvg5s432mvix4txrzrbuevou5llt5axkl7@dhrwqme3fbkt>
On Tue, Mar 18, 2025 at 10:55:03AM +0000, Krzysztof Karas wrote:
> > Header files need to declare the SPDX under /* ... */ style
> All files modified in this patch series start with:
> // SPDX-License-Identifier: MIT
> rather than:
> /* SPDX-License-Identifier: MIT */
>
> As a note:
> :~/linux/drm-tip/drivers/gpu/drm/i915$ rg "// SPDX-License-Identifier: " | wc -l
> 242
> :~/linux/drm-tip/drivers/gpu/drm/i915$ rg "/* SPDX-License-Identifier: " | wc -l
> 696
>
> are those styles interchangable or is one preferred over the
> other? I am just curious seeing both are being used.
It's an ugly mess that for some reason people have accepted from
the beginning. The SPDX license has a different format for .c and
.h file :/
Andi
next prev parent reply other threads:[~2025-03-19 0:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-14 2:12 [PATCH 0/4] Trivial style fixes Andi Shyti
2025-03-14 2:12 ` [PATCH 1/4] drm/i915/gt: Fix typos in comments Andi Shyti
2025-03-14 13:37 ` Sebastian Brzezinka
2025-03-14 13:41 ` Andi Shyti
2025-03-14 2:12 ` [PATCH 2/4] drm/i915/gt: Fix SPDX license format Andi Shyti
2025-03-18 10:55 ` Krzysztof Karas
2025-03-19 0:34 ` Andi Shyti [this message]
2025-03-20 7:38 ` Gote, Nitin R
2025-03-14 2:12 ` [PATCH 3/4] drm/i915/gt: Remove trailing blank lines Andi Shyti
2025-03-20 6:59 ` Gote, Nitin R
2025-03-14 2:12 ` [PATCH 4/4] drm/i915/gt: Use proper sleeping functions for timeouts shorter than 20ms Andi Shyti
2025-03-20 6:54 ` Gote, Nitin R
2025-03-14 4:05 ` ✗ Fi.CI.CHECKPATCH: warning for Trivial style fixes Patchwork
2025-03-14 4:05 ` ✗ Fi.CI.SPARSE: " Patchwork
2025-03-14 12:10 ` [PATCH 0/4] " Sebastian Brzezinka
2025-03-18 11:04 ` Krzysztof Karas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9oRDO0O7oDsyACd@ashyti-mobl2.lan \
--to=andi.shyti@linux.intel.com \
--cc=andi.shyti@kernel.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=krzysztof.karas@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox